Squeak-dev November 2014

squeak-dev@lists.squeakfoundation.org

41 participants
125 discussions

#'insufficient object memory' in Spur
by Chris Muller 14 Nov '14

14 Nov '14

Hi Eliot, thanks a lot for your help on the CM header. I decided to try to add a new bit indicator in my CompiledMethodBuffer (pickled state of a CM) to indicate which header format it was pickled in so I can hopefully maintain a heterogeneous environment. Now, maybe I goofed up my image while testing it at some point because I cannot seem to allocate a 50MB ByteString (even though (Smalltalk vmParameterAt: 3) reports just 89,627,904) String new: 50000000 causes a failure in primitve 71, which causes the failure code to run, which sends #growMemoryByAtLeast: to Smalltalk. But, there are no implementors of #growMemoryByAtLeast: in the image..! Do you have an impl. of that method? This could be a real problem for me to move to Spur because I absolutely depend on handling OutOfMemory errors to build my large models..

2 3

Re: [squeak-dev] The Trunk: System-cmm.689.mcz
by Eliot Miranda 14 Nov '14

14 Nov '14

Hi Chris, I think the postscript also needs to do a Locale resetKnownLocals because at least in a recently updated tests image of mine the Locale KnownLocales dictionary contained a duplicate and caused an error in DictionaryTest>>testIntegrityOfDictionaries On Wed, Nov 12, 2014 at 1:26 PM, <commits(a)source.squeak.org> wrote: > Chris Muller uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-cmm.689.mcz > > ==================== Summary ==================== > > Name: System-cmm.689 > Author: cmm > Time: 12 November 2014, 3:19:56.156 pm > UUID: a1ffba24-42ff-4391-9387-4e8ee20e6b2a > Ancestors: System-ul.688 > > Populate all LocaleID's 'country's. > > =============== Diff against System-ul.688 =============== > > Item was added: > + ----- Method: LocaleID class>>countryFor: (in category 'accessing') ----- > + countryFor: iso6391Code > + "http://www.loc.gov/standards/iso639-2/php/code_list.php" > + ^ iso6391Code > + caseOf: > + { ['af'] -> ['Afrikaans']. > + ['ca'] -> ['Catalan']. > + ['cs'] -> [ 'Czech']. > + ['da'] -> [ 'Danish']. > + ['de'] -> [ 'German']. > + ['el'] -> [ 'Greek Modern']. > + ['en'] -> [ 'English']. > + ['es'] -> [ 'Spanish']. > + ['eu'] -> [ 'Basque']. > + ['fi'] -> [ 'Finnish']. > + ['fo'] -> [ 'Faroese']. > + ['fr'] -> [ 'French']. > + ['ga'] -> [ 'Irish']. > + ['gd'] -> [ 'Gaelic']. > + ['hr'] -> [ 'Croatian']. > + ['hu'] -> [ 'Hungarian']. > + ['is'] -> [ 'Icelandic']. > + ['it'] -> [ 'Italian']. > + ['ja'] -> [ 'Japanese']. > + ['ja-etoys'] -> [ 'Japanese']. > + ['ko'] -> [ 'Korean']. > + ['nl'] -> [ 'Dutch']. > + ['no'] -> [ 'Norwegian']. > + ['pt'] -> [ 'Portuguese']. > + ['rm'] -> [ 'Romansh']. > + ['ro'] -> [ 'Romainian']. > + ['sk'] -> [ 'Slovak']. > + ['sl'] -> [ 'Slovenian']. > + ['sq'] -> [ 'Albanian']. > + ['sv'] -> [ 'Swedish']. > + ['sw'] -> [ 'Swahili']. > + ['zh'] -> [ 'Chinese'] } > + otherwise: > + [ 'other' ]! > > Item was changed: > ----- Method: LocaleID>>isoLanguage:isoCountry: (in category > 'initialize') ----- > + isoLanguage: langString isoCountry: countryStringOrNil > - isoLanguage: langString isoCountry: countryStringOrNil > isoLanguage := langString. > + isoCountry := countryStringOrNil ifNil: (self class countryFor: > langString)! > - isoCountry := countryStringOrNil! > > Item was changed: > (PackageInfo named: 'System') postscript: '"Preferences already removed > by hand, but whose state still lingers:" > + LocaleID allInstances do: > + [ : each | each > + isoLanguage: each isoLanguage > + isoCountry: (each isoCountry ifNil: [ each isoCountry ]) ]. > + LanguageEnvironment knownEnvironments rehash'! > - Preferences removePreference: #upgradeIsMerge. > - Preferences removePreference: #colorWhenPrettyPrinting. > - Preferences removePreference: #promptForUpdateServer. > - Preferences removePreference: #updateSavesFile. > - Preferences removePreference: #updateFromServerAtStartup.'! > > > -- best, Eliot

1 0

Spur Identity Hash [was: The Trunk: System-cmm.689.mcz]
by Eliot Miranda 14 Nov '14

14 Nov '14

Hi Chris, interesting! On Wed, Nov 12, 2014 at 1:40 PM, Chris Muller <asqueaker(a)gmail.com> wrote: > I finally tracked down why the keys of the #knownEnvironments > Dictionary were changing when trying to build an image in Spur. > > It's because, in my core-extensions package, I override > UndefinedObject>>#hash to have hard-coded value independent of its > #identityHash, to be safer with distributed systems which may be using > nil in a hash calculation -- in case they would be different due to > accessing with a Spur image, for example. > > Such a hash calculation is made for the keys of the #knownEnvironments > Dictionary when the country's are nil. By the different hash value in > Spur, the image would lock when trying to load my core-extensions > package, because it tried to access knownEnvironments as part of the > load-operation itself. > > The least-lazy way to "fix" it was to ensure something is populated in > the LocaleID's 'country's. Whew! > > Anyway, something to be aware of -- anywhere we have true, false or > nil used in a hash calculation, now has a different hash in Spur vs. > Cog. Maybe we should think about separating those objects' logical > "value" hash from their identityHash in trunk..? That could be useful > when we move to 64-bit someday.. > Remember that Spur has a common header format for both 32-bit and 64-bit versions, so in both there is a 22-bit identityHash and hence the identityHashes of all objects in a 64-bit Spur image bootstrapped from a 32-bit Spur image will be _unchanged_. Convenient. So no need to worry. And it should be the case that a freshly bootstrapped 64-bit Spur image does not need to be rehashed to function properly. But while we're on the subject, one thing we could do is arrange that Symbols have an identityHash based on their value. So when interning a string we'd compute its string hash and derive and assign the identityHash of the Symbol from the string hash. That would mean that when unpickling classes in e.g. Fuel we would not have to rehash method dictionaries, which would be very nice indeed. On Wed, Nov 12, 2014 at 3:26 PM, <commits(a)source.squeak.org> wrote: > > Chris Muller uploaded a new version of System to project The Trunk: > > http://source.squeak.org/trunk/System-cmm.689.mcz > > > > ==================== Summary ==================== > > > > Name: System-cmm.689 > > Author: cmm > > Time: 12 November 2014, 3:19:56.156 pm > > UUID: a1ffba24-42ff-4391-9387-4e8ee20e6b2a > > Ancestors: System-ul.688 > > > > Populate all LocaleID's 'country's. > > > > =============== Diff against System-ul.688 =============== > > > > Item was added: > > + ----- Method: LocaleID class>>countryFor: (in category 'accessing') > ----- > > + countryFor: iso6391Code > > + "http://www.loc.gov/standards/iso639-2/php/code_list.php" > > + ^ iso6391Code > > + caseOf: > > + { ['af'] -> ['Afrikaans']. > > + ['ca'] -> ['Catalan']. > > + ['cs'] -> [ 'Czech']. > > + ['da'] -> [ 'Danish']. > > + ['de'] -> [ 'German']. > > + ['el'] -> [ 'Greek Modern']. > > + ['en'] -> [ 'English']. > > + ['es'] -> [ 'Spanish']. > > + ['eu'] -> [ 'Basque']. > > + ['fi'] -> [ 'Finnish']. > > + ['fo'] -> [ 'Faroese']. > > + ['fr'] -> [ 'French']. > > + ['ga'] -> [ 'Irish']. > > + ['gd'] -> [ 'Gaelic']. > > + ['hr'] -> [ 'Croatian']. > > + ['hu'] -> [ 'Hungarian']. > > + ['is'] -> [ 'Icelandic']. > > + ['it'] -> [ 'Italian']. > > + ['ja'] -> [ 'Japanese']. > > + ['ja-etoys'] -> [ 'Japanese']. > > + ['ko'] -> [ 'Korean']. > > + ['nl'] -> [ 'Dutch']. > > + ['no'] -> [ 'Norwegian']. > > + ['pt'] -> [ 'Portuguese']. > > + ['rm'] -> [ 'Romansh']. > > + ['ro'] -> [ 'Romainian']. > > + ['sk'] -> [ 'Slovak']. > > + ['sl'] -> [ 'Slovenian']. > > + ['sq'] -> [ 'Albanian']. > > + ['sv'] -> [ 'Swedish']. > > + ['sw'] -> [ 'Swahili']. > > + ['zh'] -> [ 'Chinese'] } > > + otherwise: > > + [ 'other' ]! > > > > Item was changed: > > ----- Method: LocaleID>>isoLanguage:isoCountry: (in category > 'initialize') ----- > > + isoLanguage: langString isoCountry: countryStringOrNil > > - isoLanguage: langString isoCountry: countryStringOrNil > > isoLanguage := langString. > > + isoCountry := countryStringOrNil ifNil: (self class countryFor: > langString)! > > - isoCountry := countryStringOrNil! > > > > Item was changed: > > (PackageInfo named: 'System') postscript: '"Preferences already > removed by hand, but whose state still lingers:" > > + LocaleID allInstances do: > > + [ : each | each > > + isoLanguage: each isoLanguage > > + isoCountry: (each isoCountry ifNil: [ each isoCountry ]) > ]. > > + LanguageEnvironment knownEnvironments rehash'! > > - Preferences removePreference: #upgradeIsMerge. > > - Preferences removePreference: #colorWhenPrettyPrinting. > > - Preferences removePreference: #promptForUpdateServer. > > - Preferences removePreference: #updateSavesFile. > > - Preferences removePreference: #updateFromServerAtStartup.'! > > > > > > -- best, Eliot

5 6

Re: [squeak-dev] The Trunk: System-cmm.689.mcz
by Chris Muller 14 Nov '14

14 Nov '14

I finally tracked down why the keys of the #knownEnvironments Dictionary were changing when trying to build an image in Spur. It's because, in my core-extensions package, I override UndefinedObject>>#hash to have hard-coded value independent of its #identityHash, to be safer with distributed systems which may be using nil in a hash calculation -- in case they would be different due to accessing with a Spur image, for example. Such a hash calculation is made for the keys of the #knownEnvironments Dictionary when the country's are nil. By the different hash value in Spur, the image would lock when trying to load my core-extensions package, because it tried to access knownEnvironments as part of the load-operation itself. The least-lazy way to "fix" it was to ensure something is populated in the LocaleID's 'country's. Whew! Anyway, something to be aware of -- anywhere we have true, false or nil used in a hash calculation, now has a different hash in Spur vs. Cog. Maybe we should think about separating those objects' logical "value" hash from their identityHash in trunk..? That could be useful when we move to 64-bit someday.. On Wed, Nov 12, 2014 at 3:26 PM, <commits(a)source.squeak.org> wrote: > Chris Muller uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-cmm.689.mcz > > ==================== Summary ==================== > > Name: System-cmm.689 > Author: cmm > Time: 12 November 2014, 3:19:56.156 pm > UUID: a1ffba24-42ff-4391-9387-4e8ee20e6b2a > Ancestors: System-ul.688 > > Populate all LocaleID's 'country's. > > =============== Diff against System-ul.688 =============== > > Item was added: > + ----- Method: LocaleID class>>countryFor: (in category 'accessing') ----- > + countryFor: iso6391Code > + "http://www.loc.gov/standards/iso639-2/php/code_list.php" > + ^ iso6391Code > + caseOf: > + { ['af'] -> ['Afrikaans']. > + ['ca'] -> ['Catalan']. > + ['cs'] -> [ 'Czech']. > + ['da'] -> [ 'Danish']. > + ['de'] -> [ 'German']. > + ['el'] -> [ 'Greek Modern']. > + ['en'] -> [ 'English']. > + ['es'] -> [ 'Spanish']. > + ['eu'] -> [ 'Basque']. > + ['fi'] -> [ 'Finnish']. > + ['fo'] -> [ 'Faroese']. > + ['fr'] -> [ 'French']. > + ['ga'] -> [ 'Irish']. > + ['gd'] -> [ 'Gaelic']. > + ['hr'] -> [ 'Croatian']. > + ['hu'] -> [ 'Hungarian']. > + ['is'] -> [ 'Icelandic']. > + ['it'] -> [ 'Italian']. > + ['ja'] -> [ 'Japanese']. > + ['ja-etoys'] -> [ 'Japanese']. > + ['ko'] -> [ 'Korean']. > + ['nl'] -> [ 'Dutch']. > + ['no'] -> [ 'Norwegian']. > + ['pt'] -> [ 'Portuguese']. > + ['rm'] -> [ 'Romansh']. > + ['ro'] -> [ 'Romainian']. > + ['sk'] -> [ 'Slovak']. > + ['sl'] -> [ 'Slovenian']. > + ['sq'] -> [ 'Albanian']. > + ['sv'] -> [ 'Swedish']. > + ['sw'] -> [ 'Swahili']. > + ['zh'] -> [ 'Chinese'] } > + otherwise: > + [ 'other' ]! > > Item was changed: > ----- Method: LocaleID>>isoLanguage:isoCountry: (in category 'initialize') ----- > + isoLanguage: langString isoCountry: countryStringOrNil > - isoLanguage: langString isoCountry: countryStringOrNil > isoLanguage := langString. > + isoCountry := countryStringOrNil ifNil: (self class countryFor: langString)! > - isoCountry := countryStringOrNil! > > Item was changed: > (PackageInfo named: 'System') postscript: '"Preferences already removed by hand, but whose state still lingers:" > + LocaleID allInstances do: > + [ : each | each > + isoLanguage: each isoLanguage > + isoCountry: (each isoCountry ifNil: [ each isoCountry ]) ]. > + LanguageEnvironment knownEnvironments rehash'! > - Preferences removePreference: #upgradeIsMerge. > - Preferences removePreference: #colorWhenPrettyPrinting. > - Preferences removePreference: #promptForUpdateServer. > - Preferences removePreference: #updateSavesFile. > - Preferences removePreference: #updateFromServerAtStartup.'! > >

3 3

Looking for volunteer for Seaside GRSqueakPlatform (was: Someone to tackle failing tests in Squeak?)
by David T. Lewis 14 Nov '14

14 Nov '14

On Thu, Nov 13, 2014 at 10:43:48AM +0100, Philippe Marschall wrote: > On Thu, Nov 13, 2014 at 3:49 AM, David T. Lewis <lewis(a)mail.msen.com> wrote: > > On Tue, Nov 11, 2014 at 08:11:33AM +0100, Johan Brichau wrote: > >> Hi David, > >> > >> > On 11 Nov 2014, at 01:44, David T. Lewis <lewis(a)mail.msen.com> wrote: > >> > > >> > Is there a Metacello configuration for Seaside that I should be using to get > >> > me closer to the correct configuration? > >> > >> Looks like Paul gave you the necessary instructions. Mind that the failing tests are in latest version of Grease, which is loaded for Seaside 3.1.x (stable) and Seaside 3.2.0 (which is in development). > >> Btw, the Metacello instructions are also mentioned on http://seaside.st/download/pharo <http://seaside.st/download/pharo> > >> > >> Let me know if you need any help. > > > > Hi Johan, > > > > I am able to load Grease and Seaside 3.2.0 from the Metacello configurations, > > which work very well. There is one glitch in loading Seaside, because > > WASecureKeyGenerator class>>canSeed tries to use GRPharoPlaform subclass, > > does not exist. But that seems to be related to the same issue that is > > causing the original unit test failures that you are asking about. > > That should probably not be. I'll have a look. > > > The failures in WAExternalFileLibraryTest are related to GRPlatform. > > GRPlatform is providing a range of compatibility methods that are > > vectored through its concrete subclasses, which appear to include > > implementations for the various flavors of Pharo, as well as for a > > number of versions of Gemstone. > > > > I do not see any implementation of GRPlatform for Squeak. Presumably > > this might be a class called GRSqueakPlatform, but I cannot find this > > in any of the repositories, and the "GRPlatform current" idiom does > > not answer anything appropriate for generic Squeak. > > > > Hopefully I am just confused (by far the most likely explanation), but > > it seems that either I am not loading the right packages, or (worse) > > I am trying to "debug" software that nobody has gotten around to writing > > yet. > > > > Are these Travis CI failures actual failures, in the sense that they > > are tests that used to work, but now are failing due to some new > > problem? Or are they just an indication that GRSqueakPlatform does > > not exist, and we need to find someone to implement it? > > Right GRSqueakPlatform does not exist. The clean solution would be to > create a Grease-Squeak-Core and Grease-Tests-Squeak-Core with a > GRSqueakPlatform and the necessary class extension methods. That would > be very welcome. > Because we don't have the resources to do this we currently treat > Squeak as similar to Pharo 1.2 (or something) and load a > GRPharoPlaform class and some class extensions. If the load scripts > have a bug they don't even do that and you just GRPlatform with no > subclass. Squeak-dev: We need a volunteer to implement a Squeak-specific compatibility class in Grease for Seaside, as described by Philippe above. Is there someone who might be interested in implementing the missing GRSqueakPlatform support? Most likely, the implementation could be modeled after the existing Grease support for Pharo 1.2. Pharo 1.2 was basically the same as Squeak 3.9, and the Squeak development stream is generally quite good about maintaining compatibility of interfaces required by external packages. I expect that this would not be a large project, and it would be of great value for the Squeak community as well as for Seaside. Thanks! Dave

1 0

Class HelpOnHelp class comment reads "Welcome to Pharo Smalltalk Help System"
by gettimothy 14 Nov '14

14 Nov '14

FYI Squeak4.5 latest update: #13680 Class comment for class HelpOnHelp references Pharo. cordially, tty

2 4

The Trunk: HelpSystem-Core-dtl.64.mcz
by commits＠source.squeak.org 14 Nov '14

14 Nov '14

David T. Lewis uploaded a new version of HelpSystem-Core to project The Trunk: http://source.squeak.org/trunk/HelpSystem-Core-dtl.64.mcz ==================== Summary ==================== Name: HelpSystem-Core-dtl.64 Author: dtl Time: 13 November 2014, 7:22:23.658 pm UUID: e62ff056-805c-4d5f-89ab-4301c49dca3c Ancestors: HelpSystem-Core-kfr.63 Class comment for HelpOnHelp - be generic. =============== Diff against HelpSystem-Core-kfr.63 =============== Item was changed: CustomHelp subclass: #HelpOnHelp instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'HelpSystem-Core-Help'! + !HelpOnHelp commentStamp: 'dtl 11/13/2014 19:20' prior: 0! + HelpOnHelp is documentation for the help system! - !HelpOnHelp commentStamp: 'tbn 2/12/2010 14:27' prior: 0! - Welcome to Pharo Smalltalk Help System!

1 0

The Inbox: Morphic-dhn.723.mcz
by commits＠source.squeak.org 13 Nov '14

13 Nov '14

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-dhn.723.mcz ==================== Summary ==================== Name: Morphic-dhn.723 Author: dhn Time: 13 November 2014, 3:45:53.764 pm UUID: d65075d4-7a76-2741-9dbd-36fecda5d257 Ancestors: Morphic-dhn.722 Reduce cropping of SystemWindow submorphs by fullScreen =============== Diff against Morphic-cmm.721 =============== Item was changed: ----- Method: SystemWindow>>fullScreen (in category 'menu') ----- fullScreen + "Zoom Window to full owner size, allowing for scroll bars and desk margins" - "Zoom Window to Full World size with possible DeskMargins" - "SystemWindow fullScreen" | left right possibleBounds | left := right := 0. self paneMorphs do: [:pane | ((pane isKindOf: ScrollPane) and: [pane retractableScrollBar]) ifTrue: [pane scrollBarOnLeft ifTrue: [left := left max: pane scrollBarThickness] ifFalse: [right := right max: pane scrollBarThickness]]]. + possibleBounds := (RealEstateAgent maximumUsableAreaInWorld: self owner) - possibleBounds := (RealEstateAgent maximumUsableAreaInWorld: self world) insetBy: (left @ 0 corner: right @ 0). Preferences fullScreenLeavesDeskMargins ifTrue: [possibleBounds := possibleBounds insetBy: 22]. self bounds: possibleBounds!

1 0

What happened to CompiledMethod>>#numLiterals in Spur?
by Chris Muller 13 Nov '14

13 Nov '14

Hi Eliot and all, while moving some serialized objects from a Cog image into a Spur image, I am encountered an issue materializaing a CompiledMethod instance in the target Spur image due to the new implementation of #numLiterals. In Cog it's: numLiterals "Answer the number of literals used by the receiver." | header | ^(header := self header) < 0 ifTrue: [header bitAnd: 65535] ifFalse: [(header bitShift: -9) bitAnd: 16rFF] but in Spur, only the negative header condition is present: numLiterals "Answer the number of literals used by the receiver." ^self header bitAnd: 65535 The header was positive in the source Cog image, in fact, there are NO instances of CM's with negative headers in either my Cog or Spur images. So after constructing the CompiledMethod for materialization within the Spur image with the same #header it had in Cog, it reports the wrong #numLiterals and can't finish the materialization because of that. I'm able to force a correct materialization by changing the place where I access "numLiterals" to the original True condition of Cog -- "(header bitShift: -9) bitAnd: 16rFF". But that's just "making it work" and not understanding the implications of what I'm doing. I know Spur can allow more literals per CM, but assuming I'm willing to stay with a max of just 255 literals for now, is my override above the best way to handle this need to be able to transfer objects back-and-forth within a heterogeneous environment of Cog and Spur images? Thanks for any advice and insight..

2 2

Installing OmniBrowser - OmniBrowser-cbc.2.mcm
by Chris Cunnington 13 Nov '14

13 Nov '14

I guess two years can make a lot of difference. I used the mcm and 4.5 was not loving it much. I got lots of error windows about missing OB dependencies. One of the big problems in installing OB that set me off looking for a different script was the removal of Utilities>>timeStampForMethod: from current images. For older install scripts this absence is a problem. Whoever created the Metacello script for installation appears to have addressed that change. Chris

1 0

← Newer
1
...
7
8
9
10
11
12
13
Older →