Hm... it's always challenging to draw a line ... It feels that many things will badly break if #translated gets broken. At least the interactive tools. Well, it's still about user-facing texts, so this is okay.
Maybe do not put #translated into logs that are only for Transcript of log files. For (other) interactive things (e.g. debugger, info dialog) is fine.
Best, Marcel
Am 24.02.2024 21:58:36 schrieb Thiede, Christoph christoph.thiede@student.hpi.uni-potsdam.de:
Before I merge this, I wondered whether there are any low-level methods that we do NOT want to use #translated to avoid an infinite chain of errors when #translated itself is broken? Or would this be too cautious?
Best, Christoph
--- Sent from Squeak Inbox Talkhttps://github.com/hpi-swa-lab/squeak-inbox-talk
On 2021-04-12T20:15:10+00:00, commits@source.squeak.org wrote:
A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ct.1385.mcz
==================== Summary ====================
Name: Kernel-ct.1385 Author: ct Time: 12 April 2021, 10:15:07.18369 pm UUID: e2817a6e-1a1f-e246-aa66-2fa9289a7703 Ancestors: Kernel-nice.1384
Improves multilingual support for basic errors on Object.
=============== Diff against Kernel-nice.1384 ===============
Item was changed: ----- Method: Object>>error (in category 'error handling') ----- error "Throw a generic Error exception."
^ self error: 'Error!!' translated!
^self error: 'Error!!'.!Item was changed: ----- Method: Object>>errorImproperStore (in category 'private') ----- errorImproperStore "Create an error notification that an improper store was attempted."
^ self error: 'Improper store into indexable object' translated!
self error: 'Improper store into indexable object'!Item was changed: ----- Method: Object>>errorNonIntegerIndex (in category 'private') ----- errorNonIntegerIndex "Create an error notification that an improper object was used as an index."
^ self error: 'Only integers should be used as indices' translated!
self error: 'only integers should be used as indices'!Item was changed: ----- Method: Object>>errorSubscriptBounds: (in category 'private') ----- errorSubscriptBounds: index "Create an error notification that an improper integer was used as an index."
^ self error: ('Subscript is out of bounds: {1}' translated format: {index})!
self error: 'subscript is out of bounds: ' , index printString!