On Tue, 29 Feb 2000, Jesse Welton wrote:
I for one prefer saving my original downloaded archive, which is considerably more compact than the expanded image and changes. In this case, it is perfectly safe to overwrite the expanded image. In fact, I generally prefer to do this because it means I don't have to throw away the space-wasting virgin image.
Good point. I did consider that some people might want to do this, and if so, I figured someone would pipe up. :)
Once I've saved over my original image with full knowledge of what I'm doing, I would not want to have to see the warning again. If this warning is incorporated into the base image (which is, I'm sure, a great idea), I'd like to see an option added to prevent the message from being shown in the future. Attached is a modification which checks the preference suppressCleanSaveWarning, and offers to set it if the save is proceeded.
I like the addition of the preference. In fact, I'm not sure if you even need to bother bringing up a second prompt to ask whether someone wants to set it, I would just go ahead and set it. I doubt that anyone would care to be repeatedly warned once they've decided to overwrite the clean image. This simplifies the code a bit too... I've attached a newer changeset which does this.
(Although I guess there might be some value in notifying the user that a preference is about to be set. I don't really have a strong preference between this changeset and Jesse's, if one of them is to be added to the base image. Either one would be better than my first changeset.)
- Doug Way EAI/Transom Technologies, Ann Arbor, MI http://www.transom.com dway@mat.net, @eai.com