On 27 December 2012 12:29, H. Hirzel hannes.hirzel@gmail.com wrote:
You mean I have to re-download http://www.squeakci.org/job/ReleaseSqueakTrunk/lastSuccessfulBuild/artifact/... ?
I would have expected a note and/or a higher version number....
The version number is the update number. Since the error was in the release script, fixing the error didn't result in pushing anything to the Trunk, hence no new update, hence the version number remained the same.
Something else the release script/s need is better diagnostics: the problem was that something went wrong and the scripts didn't bail out.
Oh, and you're right re the scripts: the release.sh feeds the release.st as a startup script into the image to be released. The Smalltalk then executes as DoIts. You can see these if you try Recover Changes.
frank
On 12/27/12, Frank Shearar frank.shearar@gmail.com wrote:
On 27 December 2012 11:55, Frank Shearar frank.shearar@gmail.com wrote:
On 27 December 2012 11:48, H. Hirzel hannes.hirzel@gmail.com wrote:
Frank,
On 12/27/12, Frank Shearar frank.shearar@gmail.com wrote:
On 27 December 2012 11:00, H. Hirzel hannes.hirzel@gmail.com wrote:
Frank,
where can I have a look at the build script?
And the console output is not very talkative....
https://github.com/frankshearar/squeak-ci/blob/download-vms/release.sh
OK, so the following bash script
#! /bin/sh # This script takes the output of builtastic.sh and creates a
releasable # artifact.
SRC=$(cd $(dirname "$0"); pwd) . "${SRC}/versions.sh" . "${SRC}/functions.sh" SQUEAK_VERSION=`cat ${SRC}/target/TrunkImage.version` BASENAME=Squeak4.4-${SQUEAK_VERSION} build_interpreter_vm echo Using ${INTERPRETER_VM} echo Preparing ${BASENAME}... cp ${SRC}/target/TrunkImage.changes
${SRC}/target/${BASENAME}.changes cp ${SRC}/target/TrunkImage.image ${SRC}/target/${BASENAME}.image
chmod +w ${SRC}/target/${BASENAME}.changes chmod +w ${SRC}/target/${BASENAME}.image echo Releasing ${BASENAME}... ${INTERPRETER_VM} -vm-sound-null -vm-display-null ${SRC}/target
/${BASENAME}.image ${SRC}/release.st
echo Zipping ${BASENAME}... # Previous runs might leave a zip lying around. rm ${SRC}/target/${BASENAME}.zip (cd ${SRC}/target; zip -j ${BASENAME}.zip ${BASENAME}.changes
${BASENAME}.image)
CALLS the SMALLTALK script
https://github.com/frankshearar/squeak-ci/blob/download-vms/release.st
Form openAsBackground: (FileDirectory default / '..' /
'resources/wallpaper.png') pathName. Workspace allInstances do: [:w | w topView delete]. ReleaseBuilderFor4dot4 prepareNewBuild. Smalltalk snapshot: true andQuit: true.
Just by inspection (and with the knowledge that the version number of the resulting image is correct) it seems that the error might be in the Smalltalk script.
What error? There _was_ an error, that you reported a few days, but that should be fixed. Have you looked at output of the latestSuccessfulBuild for that job?
Er, right. Maybe it would have helped me _saying_ that I'd fixed the error you reported!
frank
NOTE: Anybody who downloads the latest trunk image and executes the above Smalltalk script is in the position to find the error....... (hint, hint to everybody...)
No, the scripts are not talkative at all. I'm really not sure how to make them more talkative. Obviously in the shell scripts you can use echo, but those do hardly anything. Really what I want is something that writes to the Transcript when headful and to stdout/stderr when headless. I don't think we have such a thing at the moment.
I also think that the ReleaseBuilder stuff doesn't belong in the Trunk image and should be maintained externally. (MAYBE it could be loaded into an image just as part of the release process, but really I'd like scaffolding - ConfigurationOf packages, ReleaseBuilder stuff, etc. - to not be in the image at all.)
I am actually very fine with the scaffolding script in the image, reason see the note above.
And in addition this is what Andreas suggested in his memo which is cited in the welcome window. External packages configurations / scripts which are community supported should be in the image...
--Hannes
frank
--Hannes
On 12/24/12, Frank Shearar frank.shearar@gmail.com wrote: > On 24 December 2012 09:18, Frank Shearar frank.shearar@gmail.com > wrote: >> On 24 December 2012 07:48, H. Hirzel hannes.hirzel@gmail.com >> wrote: >>> Though it has version number 12324 it still shows the rice-paper >>> background and has a 'welcome to Squeak 4.3' workspace. >> >> Oh crumbs. Thanks, Hannes, I must have an error in my script. > > http://squeakci.org/job/ReleaseSqueakTrunk/17/ > >> frank >> >>> --Hannes >>> >>> On 12/23/12, Frank Shearar frank.shearar@gmail.com wrote: >>>> On 23 December 2012 19:14, Frank Shearar frank.shearar@gmail.com >>>> wrote: >>>>> On 23 December 2012 19:09, Frank Shearar >>>>> frank.shearar@gmail.com >>>>> wrote: >>>>>> http://squeakci.org/job/ReleaseSqueakTrunk/lastSuccessfulBuild/artifact/targ... >>>>>> >>>>>> I'm trying to automate more and more of the build/release >>>>>> process. >>>>>> See >>>>>> https://github.com/frankshearar/squeak-ci/tree/download-vms for >>>>>> details. (I'll merge this branch back into master at some point >>>>>> in >>>>>> the >>>>>> near future.) >>>>> >>>>> This does _not_ address Bert's issue about the positioning of the >>>>> Squeak window; it's just an illustration of yet another piece of >>>>> automation. I like automation. >>>> >>>> I see three dirty packages, all dirty - apparently - because of >>>> package restructurings. >>>> >>>> * FlexibleVocabularies - FlexibleVocabularies-Info removed? >>>> * Multilingual - Multilingual-Editor added? >>>> * SMLoader - looks like SMLoader-Models was removed? >>>> >>>> (I may have the situation reversed; I'm not sure whether "old" >>>> refers >>>> to the blue strikeout text or the red, nor whether "old" refers to >>>> the >>>> image or to trunk.) >>>> >>>> frank >>>> >>>> >>> > >