Squeak-dev April 2024

squeak-dev@lists.squeakfoundation.org

22 participants
38 discussions

Key not found: (PEGParserSAXWMGeneratorTest>>#testPageWithTable "a CompiledMethod(443890)")
by gettimothy 22 Apr '24

22 Apr '24

Hi folks, I am not sure how to handle this one.... In the test runner, or when I run a test outside of it and it fails, when I click on the Test Failure inspectorto see the output and why it failed, a window with the title in the subject line pops up. I tried garbage collecting to no avail. Suggestions appreciated. thx t Image ----- /bulkstorage/shared/Squeak6.1alpha-22713-64bit.image Squeak6.1alpha latest update: #22721 Current Change Set: Grammar Image format 68533 (64 bit) Preferred bytecode set: SistaV1 Virtual Machine --------------- /home/wm/usr/bin/sqcogspur64linuxht/lib/squeak/5.0-202206021410-64bit/squeak Open Smalltalk Cog[Spur] VM [CoInterpreterPrimitives VMMaker.oscog-dtl.3185] Unix built on Jun 2 2022 15:26:05 Compiler: Clang 9.0.0 (tags/RELEASE_900/final) platform sources revision VM: 202206021410 runner@fv-az125-921:work/opensmalltalk-vm/opensmalltalk-vm Date: Thu Jun 2 16:10:44 2022 CommitHash: c9fd365 Plugins: 202206021410 runner@fv-az125-921:work/opensmalltalk-vm/opensmalltalk-vm CoInterpreter VMMaker.oscog-dtl.3185 uuid: 0e7f07b8-eed6-4362-b223-86c98594ddb9 Jun 2 2022 StackToRegisterMappingCogit VMMaker.oscog-mt.3179 uuid: c6fbcb07-2a19-ed4f-8b40-9c119a70882a Jun 2 2022

1 0

trunk debugger unusably slow...
by Eliot Miranda 20 Apr '24

20 Apr '24

Hi All, I'm trying to debug an inlining edge case in the VM for the threaded VM that Leon is doing. The debugger is unusably slow (steps taking 10 seconds, etc). I've raised this issue before but was brushed off. I suspect somewhere in the new (last two years?) highlighting code is taking a lot of time. Would the author(s) please provide me with some snippets of code i can use to try and measure performance? And/or would anybody be willing to pair (I'm on PST) in trying to get to the bottom of this? It's extremely frustrating to try and work when the debugger is unusable. _,,,^..^,,,_ best, Eliot

5 9

The Trunk: System-mt.1454.mcz
by commits＠source.squeak.org 17 Apr '24

17 Apr '24

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1454.mcz ==================== Summary ==================== Name: System-mt.1454 Author: mt Time: 17 April 2024, 11:21:13.595706 am UUID: 5a4cbd93-f34a-5140-9d06-312754b6eb39 Ancestors: System-mt.1453 Complement FFI-Kernel-mt.232 (See PrimErrFFIMarshallingError and #ffiFail: in SqueakFFI plugin). =============== Diff against System-mt.1453 =============== Item was changed: ----- Method: SmalltalkImage>>recreateSpecialObjectsArray (in category 'special objects') ----- recreateSpecialObjectsArray "Smalltalk recreateSpecialObjectsArray" "To external package developers: **** DO NOT OVERRIDE THIS METHOD. ***** If you are writing a plugin and need additional special object(s) for your own use, use addGCRoot() function and use own, separate special objects registry " "The Special Objects Array is an array of objects used by the Squeak virtual machine. Its contents are critical and accesses to it by the VM are unchecked, so don't even think of playing here unless you know what you are doing." | newArray | newArray := Array new: 60. "Nil false and true get used throughout the VM" newArray at: 1 put: nil. newArray at: 2 put: false. newArray at: 3 put: true. "This association holds the active process (a ProcessScheduler)" newArray at: 4 put: (self specialObjectsArray at: 4) "(self bindingOf: #Processor) but it answers an Alias". "Numerous classes below used for type checking and instantiation" newArray at: 5 put: Bitmap. newArray at: 6 put: SmallInteger. newArray at: 7 put: ByteString. newArray at: 8 put: Array. newArray at: 9 put: Smalltalk. newArray at: 10 put: BoxedFloat64. newArray at: 11 put: (self globals at: #Context). newArray at: 12 put: WideString. "Was BlockContext" newArray at: 13 put: Point. newArray at: 14 put: LargePositiveInteger. newArray at: 15 put: Display. newArray at: 16 put: Message. newArray at: 17 put: CompiledMethod. newArray at: 18 put: ((self specialObjectsArray at: 18) ifNil: [Semaphore new]). "low space Semaphore" newArray at: 19 put: Semaphore. newArray at: 20 put: Character. newArray at: 21 put: #doesNotUnderstand:. newArray at: 22 put: #cannotReturn:. newArray at: 23 put: nil. "This is the process signalling low space." "An array of the 32 selectors that are compiled as special bytecodes, paired alternately with the number of arguments each takes." newArray at: 24 put: #(+ 1 - 1 < 1 > 1 <= 1 >= 1 = 1 ~= 1 * 1 / 1 \\ 1 @ 1 bitShift: 1 // 1 bitAnd: 1 bitOr: 1 at: 1 at:put: 2 size 0 next 0 nextPut: 1 atEnd 0 == 1 class 0 ~~ 1 value 0 value: 1 do: 1 new 0 new: 1 x 0 y 0 ). newArray at: 25 put: nil. "Was an array of the 255 Characters in ascii order. This is nil in Spur, which has immediate Characters." newArray at: 26 put: #mustBeBoolean. newArray at: 27 put: ByteArray. newArray at: 28 put: Process. "An array of up to 31 classes whose instances will have compact headers; an empty array in Spur" newArray at: 29 put: self compactClassesArray. newArray at: 30 put: ((self specialObjectsArray at: 30) ifNil: [Semaphore new]). "delay Semaphore" newArray at: 31 put: ((self specialObjectsArray at: 31) ifNil: [Semaphore new]). "user interrupt Semaphore" "Entries 32 - 34 unreferenced. Previously these contained prototype instances to be copied for fast initialization" newArray at: 32 put: DoubleByteArray. "was the prototype Float" newArray at: 33 put: WordArray. "was the prototype 4-byte LargePositiveInteger" newArray at: 34 put: DoubleWordArray. "was the prototype Point" newArray at: 35 put: #cannotInterpret:. newArray at: 36 put: nil. "was the prototype MethodContext" newArray at: 37 put: BlockClosure. newArray at: 38 put: (self at: #FullBlockClosure ifAbsent: []). "was the prototype BlockContext" "array of objects referred to by external code" newArray at: 39 put: (self specialObjectsArray at: 39). "external semaphores" newArray at: 40 put: nil. "Reserved for Mutex in Cog VMs" newArray at: 41 put: ((self specialObjectsArray at: 41) ifNil: [LinkedList new]). "Reserved for a LinkedList instance for overlapped calls in CogMT" newArray at: 42 put: ((self specialObjectsArray at: 42) ifNil: [Semaphore new]). "finalization Semaphore" newArray at: 43 put: LargeNegativeInteger. "External objects for callout. Note: Written so that one can actually completely remove the FFI." newArray at: 44 put: (self at: #ExternalAddress ifAbsent: []). newArray at: 45 put: (self at: #ExternalStructure ifAbsent: []). newArray at: 46 put: (self at: #ExternalData ifAbsent: []). newArray at: 47 put: (self at: #ExternalFunction ifAbsent: []). newArray at: 48 put: (self at: #ExternalLibrary ifAbsent: []). newArray at: 49 put: #aboutToReturn:through:. newArray at: 50 put: #run:with:in:. "51 reserved for immutability message" newArray at: 51 put: #attemptToAssign:withIndex:. newArray at: 52 put: #(nil "nil => generic error" #'bad receiver' #'bad argument' #'bad index' #'bad number of arguments' #'inappropriate operation' #'unsupported operation' #'no modification' #'insufficient object memory' #'insufficient C memory' #'not found' #'bad method' #'internal error in named primitive machinery' #'object may move' #'resource limit exceeded' #'object is pinned' #'primitive write beyond end of object' #'object moved' #'object not pinned' #'callback error'), { PrimitiveError new errorName: #'operating system error'; yourself. ExceptionInFFICallError new errorName: #'exception in FFI call'; yourself}, #( #'heap compaction needed' #'operation failed' + #'internal error' #'uninitialized'), + { PrimitiveError new errorName: #'FFI marshalling error'; yourself}. - #'internal error' #'uninitialized'). "53 to 55 are for Alien" newArray at: 53 put: (self at: #Alien ifAbsent: []). newArray at: 54 put: #invokeCallbackContext:. "use invokeCallback:stack:registers:jmpbuf: for old Alien callbacks." newArray at: 55 put: (self at: #UnsafeAlien ifAbsent: []). "Used to be WeakFinalizationList for WeakFinalizationList hasNewFinalization, obsoleted by ephemeron support." newArray at: 56 put: nil. "reserved for foreign callback process" newArray at: 57 put: (self specialObjectsArray at: 57 ifAbsent: []). newArray at: 58 put: #unusedBytecode. "59 reserved for Sista counter tripped message" newArray at: 59 put: #conditionalBranchCounterTrippedOn:. "60 reserved for Sista class trap message" newArray at: 60 put: #classTrapFor:. "Now replace the virtual machine's reference in one atomic operation" self specialObjectsArray becomeForward: newArray! Item was changed: + (PackageInfo named: 'System') postscript: 'SystemNavigation initializeAuthors. "Adds Leon Matthes (LM)" + Smalltalk recreateSpecialObjectsArray. "Adds ffi-marshalling-error to error table"'! - (PackageInfo named: 'System') postscript: '"In Process, threadId/threadAffinity have been around for a long time." - Smalltalk processHasThreadAffinityInstVar: true. - "Squeak 6.0 and above have #scaleFactor support in image." - Smalltalk upscaleDisplayOnHighDPI: false. - - SystemNavigation initializeAuthors. "Adds Leon Matthes (LM)"'!

1 0

FFI: FFI-Kernel-mt.232.mcz
by commits＠source.squeak.org 17 Apr '24

17 Apr '24

Marcel Taeumel uploaded a new version of FFI-Kernel to project FFI: http://source.squeak.org/FFI/FFI-Kernel-mt.232.mcz ==================== Summary ==================== Name: FFI-Kernel-mt.232 Author: mt Time: 17 April 2024, 11:17:11.319706 am UUID: 7bf5313f-0238-2541-97d4-daeeadc57839 Ancestors: FFI-Kernel-mt.231 For communicating failed FFI callouts, add support for PrimitiveError and ExceptionInFFICallError. =============== Diff against FFI-Kernel-mt.231 =============== Item was changed: ----- Method: ExternalFunction class>>externalCallFailedWith: (in category 'error handling') ----- externalCallFailedWith: primErrorCode "Raise an error after a failed call to an external function. The primFailCode could be any of: - a symbol; one of the standard primitive errors defined in Smalltalk primitiveErrorTable - nil; the VM does not support primitive errors and is not providing error codes - an integer; one of the FFI codes incremented by Smalltalk primitiveErrorTable size + 2 + so as not to clash with the standard primitive errors + - an instance of PrimitiveError that encodes an FFI marshalling error + - an instance of PrimitiveError that encodes an FFI callout exception error." + + primErrorCode isExceptionInFFICallError ifTrue: + [^self error: primErrorCode errorName, ' (', primErrorCode pc asString, ')']. + primErrorCode isPrimitiveError ifTrue: + [^self error: primErrorCode errorName, ' (', (self errorMessageFor: primErrorCode errorCode), ')']. + - so as not to clash with the standard primitive errors." ^self error: (primErrorCode isInteger ifTrue: [self errorMessageFor: primErrorCode - (Smalltalk primitiveErrorTable size + 2)] ifFalse: [primErrorCode isNil ifTrue: ['Call to external function failed'] ifFalse: [primErrorCode]])! Item was added: + ----- Method: Object>>externalCallFailedWith: (in category '*FFI-Kernel') ----- + externalCallFailedWith: primErrorCode + + ^ ExternalFunction externalCallFailedWith: primErrorCode!

1 0

FFI: FFI-Pools-mt.40.mcz
by commits＠source.squeak.org 17 Apr '24

17 Apr '24

Marcel Taeumel uploaded a new version of FFI-Pools to project FFI: http://source.squeak.org/FFI/FFI-Pools-mt.40.mcz ==================== Summary ==================== Name: FFI-Pools-mt.40 Author: mt Time: 17 April 2024, 11:14:11.267706 am UUID: cc8f5f16-1bea-8445-8e66-ba1b56b94e4b Ancestors: FFI-Pools-mt.39 Expose primitive 220 to let clients manage FFI exception handling. =============== Diff against FFI-Pools-mt.39 =============== Item was added: + ----- Method: FFIConstants class>>getFFIExceptionHandling (in category 'exception handling') ----- + getFFIExceptionHandling + <primitive: 220> "#primitiveGetSetFFIExceptionHandling" + ^ -1! Item was added: + ----- Method: FFIConstants class>>setFFIExceptionHandling: (in category 'exception handling') ----- + setFFIExceptionHandling: anInteger + "Set whether exceptions in FFI callouts should result in #primitiveFailed or + crash the VM. + -1 never fail (but crash) + 0 fail if method has a primitive error code (default) + 1 always fail" + <primitive: 220 error: ec> "#primitiveGetSetFFIExceptionHandling" + ec == #'bad argument' ifTrue: + [^self error: 'argument must be -1, 0, or 1']. + ec == #'unsupported operation' ifTrue: + [^self error: 'platform does not support FFI exception handling']. + self primitiveFailed.!

1 0

FFI: FFI-Pools-mt.40.mcz
by commits＠source.squeak.org 17 Apr '24

17 Apr '24

1 0

The Trunk: System-mt.1453.mcz
by commits＠source.squeak.org 17 Apr '24

17 Apr '24

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1453.mcz ==================== Summary ==================== Name: System-mt.1453 Author: mt Time: 17 April 2024, 10:43:17.752706 am UUID: d5ecd791-4890-e748-950c-809da8376186 Ancestors: System-mt.1452 For structured primitive errors, expose #errorName in its print-string to make the error table more readable (see index 52 in #specialObjectsArray). While ExceptionInFFICallError has both a custom name and an extra slot, you can use any custom instance of PrimitiveError to pass scoped error codes from failing primitives such as the existing #'operating system error' and its platform-specific error codes. However, you would need to reserve a new index in the error table and thus update the special-objects array. Therefore, custom VM plugins might want to choose an extra interface to communicate failed operations. For example, SqueakFFI uses #getLastError and #externalCallFailed to fabricate readable error messages. Not sure why we do it this way (see #ffiFail: in plugin code) ... the approach via PrimitiveError seems more elegant to me... and via PrimErrFFIMarshallingError there is even a way to use the new scheme. :-) =============== Diff against System-mt.1452 =============== Item was added: + ----- Method: PrimitiveError>>printOn: (in category 'printing') ----- + printOn: aStream + + self errorName + ifNil: [super printOn: aStream] + ifNotNil: [:nm | nm printOn: aStream].!

1 0

The Trunk: System-mt.1453.mcz
by commits＠source.squeak.org 17 Apr '24

17 Apr '24

1 0

The Trunk: Tools-eem.1250.mcz
by commits＠source.squeak.org 17 Apr '24

17 Apr '24

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.1250.mcz ==================== Summary ==================== Name: Tools-eem.1250 Author: eem Time: 16 April 2024, 10:16:10.120513 pm UUID: 51b04f56-0b7b-4505-8928-2571e6ecf553 Ancestors: Tools-ct.1249 Fix SavedMultiWindowState's class comment. Remove accessor for private inst var. =============== Diff against Tools-ct.1249 =============== Item was changed: Object subclass: #SavedMultiWindowState instanceVariableNames: 'models modelStates modelDependents currentModelIndex prototype' classVariableNames: '' poolDictionaries: '' category: 'Tools-Base'! + !SavedMultiWindowState commentStamp: 'eem 4/16/2024 14:42' prior: 0! + A SavedMultiWindowState is a collection of states of inactive windows for a multi-window tool ui where one can select between multiple copies of a tool sharing a single system window, each tool having its own state. It manages switching between windows, swapping unaccepted edit state (e.g. in text views) as it does so. - !SavedMultiWindowState commentStamp: 'eem 6/30/2010 15:45' prior: 0! - A SavedMultiWindowState is a collection of states of inactive windows for a multi-window tool ui where one can select between multiple copies of a tool sharing a single system window, each tol having its own state. It manages switching between windows, swapping unaccepted edit state (e.g. in text views) as it does so. Instance Variables + currentModelIndex: <Integer> + modelDependents: <IdentitySet> - currentModelIndex: <Integer> - modelDependents: <IdentitySet> modelStates: <OrderedCollection of: (Array + with: modelState <Object> + with: unacceptedEditStates <WeakIdentityKeyDictionary>) > + models: <OrderedCollection of: Model> + prototype: <Model> - with: modelState <Object> - with: unacceptedEditStates <WeakIdentityKeyDictionary>) > - models: <OrderedCollection of: Model> currentModelIndex - index into models and modelStates of current window selection modelDependents - set of all dependents modelStates - the pairs of model-specific selection state and widget-specfic unaccepted edit state for each unselected/inactive window models - the models for each window + + prototype + - a shallow copy of the initial tool/model, used to create new tools/models! - ! Item was removed: - ----- Method: SavedMultiWindowState>>currentModelIndex (in category 'accessing') ----- - currentModelIndex - ^currentModelIndex!

1 0

transparency, black, and PNG files
by Lauren Pullen 17 Apr '24

17 Apr '24

Hi List, I have a 32-bit Form I imported from a PNG without an alpha layer that has a black background for transparency, but this is what I get when I examine it in the inspector: self pixelValueAt: 1@1. 4278190080 . self pixelValueFor: Color black. 4278190081 . self colorAt: 1@1. Color transparent . self isTransparentAt: 1@1. false . self pixelValueFor: Color transparent. 0 . I feel like having #colorAt: answer transparent while #isTransparentAt: answers false is a bug.

3 3