Squeak-dev February 2023

squeak-dev@lists.squeakfoundation.org

28 participants
108 discussions

Please Try | New TreeBrowser
by Marcel Taeumel 24 Apr '23

24 Apr '23

Hi all -- Here is a slightly alternative version of Squeak's default browser. It uses tree widgets for the first three panes, that is, system/class categories, classes, message categories. Menus, filters, drag/drop, updates etc. should all work as in the traditional "Browser" browser. SystemBrowser default: TreeBrowser. SystemBrowser default: Browser. Please report issues. I plan to merge this soon. Note that there are 3 preferences: TreeBrowser showAllClassesInPackage TreeBrowser showBlankClassIcons TreeBrowser showEmptyPackages Yes, there is a slim integration with PackageInfo and Monticello packages. Best, Marcel

7 18

PNGReadWriter buglet
by tim Rowledge 24 Mar '23

24 Mar '23

I have a stack of png file to read. They appear fine in Preview and various other image handling programs. In Squeak (both 5.3 release and the trunk, on both ARM and intel VMs) they look rather odd - almost as if every other line is missing. From Preview Squeak 6 trunk arm Squeak 6 mac intel update 22101 same mac, squeak6 trunk .. but those last two are artefacts of the size of the FileList and resizing it larger - so the preview in the bottom pane gets larger - returns the displayed image to match the arm system. Evidently the resizing is a bit messed up too. Ah, and on a Pi resizing the FileList does the same things, so at least we're platform consistently messed up! I have plenty of other png files that appear perfectly ok in Squeak and rescale cleanly. Before I start whacking at things in a debugger I thought I'd ask if anyone else plays with PNGs right now and has been fixing things. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful random insult:- Wasn't fully debugged before being released.

7 33

How do I "sleep 5"?
by Eduardo Ochs 05 Mar '23

05 Mar '23

Hi list, a few days ago I asked for help on how to send a "synthetic" keyboard event to a morph, and Karl Ramberg gave me exactly the right hints in this thread: http://lists.squeakfoundation.org/pipermail/squeak-dev/2023-February/223473… My code is ready except for documentation and comments - I'll work on that in the next few days and then post the result here and on the wiki... ...but there's a feature that I want to add to it that - again =( - needs something that I'm not being able to discover by myself. How do I write a line of code that waits for 5 seconds, sort of like running "sleep 5" in a shell, and that doesn't block the rest of the system? If I have that I'll be able to run these two lines in a workspace, self mySleep: 5000. kf := self currentHand keyboardFocus. switch the keyboard focus to something else by clicking on it, and then the variable kf will be set to this "something else"... Thanks in advance! Eduardo Ochs http://anggtwu.net/eev-squeak.html

15 42

Where does the compiler handle the "local bindings" of workspaces?
by Eduardo Ochs 01 Mar '23

01 Mar '23

Hi list, first some context: I was trying to put some blocks of executable notes in something like the "Terse Guide to Squeak"... the Terse Guide is implemented as a class called TerseGuideHelp, and I was working on a modified copy of that class, that I called EdrxGuideHelp... but then I saw that the window that shows the content of a topic in a help browser treats local variables in a way that is different than the one in workspaces - if I run "a := 42" in the window with the contents of a topic I get a dialog window whose title is: Unknown variable: a! please correct, or cancel: Now a more basic question. I sort of know where the "local variables" of a workspace are stored... if I start with a single workspace and I run this on it, w := Workspace new. w buildAndOpen. and then I run this on the second workspace, a := 2. b := a + 3. and then go back to the first workspace and "print it" this, w bindings. I get: a Dictionary('a'->2 'b'->5 ) My first guess was that "do it"s and "print it"s in a workspace use a dictionary of bindings, but "do it"s and "print it"s in the mini-workspace of a help browser do not. I tried to understand "real" workspaces first, and after setting a breakpoint in TextEditor >> #printIt and doing lots of single-steppings I arrived at this method, TextEditor >> #evaluateSelectionAndDo: that has this: result := [ rcvr class evaluatorClass new evaluate: self selectionAsStream in: ctxt to: rcvr environment: (model environment ifNil: [Smalltalk globals]) notifying: self ifFail: [self flash. ^ nil] logged: true. ] on: OutOfScopeNotification do: [ :ex | ex resume: true]. but when that code calls this method Compiler >> #evaluate:in:to:environment:notifying:ifFail:logged: the "rcvr class evaluatorClass new" is simply a "Compiler new", "self selectionAsStream" is "a := 2. b := a + 3." as a stream, the ctxt and the rcvr are nil, and the environment is just "Smalltalk"... where does the dictionary of local bindings enter the story? Am I doing something wrong in the debugger?... Thanks in advance! Eduardo Ochs http://angg.twu.net/eev-squeak.html

2 10

Inconsistent growing behavior of Streams and Collections
by Marcel Taeumel 28 Feb '23

28 Feb '23

Hi all -- What is the best growing strategy we currently have and can we use it consistently in the image? 1) HashedCollection (i.e., Dictionary etc.) - growing is rather clever via prime table and max. 75% load factor - see #growSize 2) OrderedCollection - grow if less than 50% free space (see #makeRoomAt*) - grow by 100% (see #growAt*) 3) WriteStream (e.g., String streamContents: [...]) - !! grow by 100% (at most 1 Million !) via #grownBy: for #nextPut:/#pastEndPut: (and #nextPutAll: for Strings) - grow by min+25% via #growTo: for #nextPutAll: (for non-strings) --- Well, using "String streamContents: [...]" is *really* slow for very large strings (e.g., > 100 MB) bc. it triggers a lot of full GCs bc. #grownBy: only adds a 1 megabyte at most per grow. Therefore, our JSON support suffers a serious performance impact when using #asJsonString on larger structures. Best, Marcel

2 1

The Inbox: Tools-jl.1178.mcz
by commits＠source.squeak.org 28 Feb '23

28 Feb '23

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jl.1178.mcz ==================== Summary ==================== Name: Tools-jl.1178 Author: jl Time: 28 February 2023, 4:42:25.541268 pm UUID: c65c6ada-fea0-7749-a936-727e06378ef3 Ancestors: Tools-ct.1177 new menu entry for workspaces: remove all styling from the text objects in this workspace. helpful if you have clickable links with pointers to big objects you would like to be garbage-collected =============== Diff against Tools-ct.1177 =============== Item was changed: ----- Method: Workspace>>addModelItemsToWindowMenu: (in category 'menu commands') ----- addModelItemsToWindowMenu: aMenu aMenu addLine. aMenu add: 'change file name...' target: self action: #changeFileName. aMenu add: 'save contents to file...' target: self action: #saveContentsInFile. aMenu addUpdating: #saveContentsInFileOnAcceptWording target: self action: #saveContentsInFileOnAccept. aMenu addUpdating: #appendContentsToFileOnAcceptWording target: self action: #appendContentsToFileOnAccept. aMenu addLine. aMenu add: 'inspect variables' target: self action: #inspectBindings. aMenu add: 'reset variables' target: self action: #resetBindings. + aMenu + add: 'reset styles' + target: self + action: #resetStyles. aMenu addLine. aMenu addUpdating: #mustDeclareVariableWording target: self action: #toggleVariableDeclarationMode. aMenu addUpdating: #acceptDroppedMorphsWording target: self action: #toggleDroppingMorphForReference. self addToggleStylingMenuItemTo: aMenu. ! Item was added: + ----- Method: Workspace>>resetStyles (in category 'menu commands') ----- + resetStyles + "remove all styling from the text objects in this workspace. helpful if you have clickable links with pointers to big objects you would like to be garbage-collected" + + self contents isText ifTrue: [self contents removeAllAttributes]. + self codeTextPane text removeAllAttributes. + self codeTextPane changed!

1 0

The Trunk: Graphics-nice.540.mcz
by commits＠source.squeak.org 27 Feb '23

27 Feb '23

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.540.mcz ==================== Summary ==================== Name: Graphics-nice.540 Author: nice Time: 27 February 2023, 11:08:20.503071 pm UUID: 3ed34a8a-0e5a-9044-a70b-de82186f7a48 Ancestors: Graphics-nice.539 Fix load of interlaced PNG again : we must use rule 31 (Form paintAlpha) which does the right thing: - use destinationPixel when sourcePixel is zero - else use sourcePixel This is because the default constant sourceAlpha used for blending is 255, and rule 31 perform this pseudo code for each A,R,G,B channel: (sourceChannel * sourceAlpha) + (destinationChannel * (255 - sourceAlpha)) / 255 which is = sourceChannel. =============== Diff against Graphics-nice.539 =============== Item was changed: ----- Method: PNGReadWriter>>copyPixelsRGB:at:by: (in category 'pixel copies') ----- copyPixelsRGB: y at: startX by: incX "Handle interlaced RGB color mode (colorType = 2)" | i pixel tempForm tempBits xx loopsToDo | tempForm := Form extent: width@1 depth: 32. tempBits := tempForm bits. pixel := LargePositiveInteger new: 4. pixel at: 4 put: 16rFF. loopsToDo := width - startX + incX - 1 // incX. bitsPerChannel = 8 ifTrue: [i := (startX // incX * 3) + 1. xx := startX+1. 1 to: loopsToDo do: [ :j | pixel at: 3 put: (thisScanline at: i); at: 2 put: (thisScanline at: i+1); at: 1 put: (thisScanline at: i+2). tempBits at: xx put: pixel normalize. i := i + 3. xx := xx + incX]. transparentPixelValue ifNotNil: [startX to: width-1 by: incX do: [ :x | (tempBits at: x+1) = transparentPixelValue ifTrue: [ tempBits at: x+1 put: 0]]]] ifFalse: [i := (startX // incX * 6) + 1. xx := startX+1. 1 to: loopsToDo do: [ :j | (transparentPixelValue == nil or: [(1 to: 6) anySatisfy: [:k | (transparentPixelValue digitAt: k) ~= (thisScanline at: i + 6 - k)]]) ifTrue: [pixel at: 3 put: (thisScanline at: i); at: 2 put: (thisScanline at: i+2); at: 1 put: (thisScanline at: i+4). tempBits at: xx put: pixel normalize.] ifFalse: [tempBits at: xx put: 0]. i := i + 6. xx := xx + incX]]. + tempForm displayOn: form at: 0@y rule: Form paintAlpha - tempForm displayOn: form at: 0@y rule: Form blendAlphaUnscaled ! Item was changed: ----- Method: PNGReadWriter>>copyPixelsRGBA:at:by: (in category 'pixel copies') ----- copyPixelsRGBA: y at: startX by: incX "Handle interlaced RGBA color modes (colorType = 6)" | i pixel tempForm tempBits | tempForm := Form extent: width@1 depth: 32. tempBits := tempForm bits. pixel := LargePositiveInteger new: 4. bitsPerChannel = 8 ifTrue: [ i := (startX // incX << 2) + 1. startX to: width-1 by: incX do: [ :x | pixel at: 4 put: (thisScanline at: i+3); at: 3 put: (thisScanline at: i); at: 2 put: (thisScanline at: i+1); at: 1 put: (thisScanline at: i+2). tempBits at: x+1 put: pixel normalize. i := i + 4. ] ] ifFalse: [ i := (startX // incX << 3) +1. startX to: width-1 by: incX do: [ :x | pixel at: 4 put: (thisScanline at: i+6); at: 3 put: (thisScanline at: i); at: 2 put: (thisScanline at: i+2); at: 1 put: (thisScanline at: i+4). tempBits at: x+1 put: pixel normalize. i := i + 8. ]. ]. + tempForm displayOn: form at: 0@y rule: Form paintAlpha. - tempForm displayOn: form at: 0@y rule: Form blendAlphaScaled. !

1 0

The Trunk: GraphicsTests-nice.62.mcz
by commits＠source.squeak.org 27 Feb '23

27 Feb '23

Nicolas Cellier uploaded a new version of GraphicsTests to project The Trunk: http://source.squeak.org/trunk/GraphicsTests-nice.62.mcz ==================== Summary ==================== Name: GraphicsTests-nice.62 Author: nice Time: 27 February 2023, 5:05:11.232119 pm UUID: 1490c410-0f9a-a749-a2e2-d8b5539d582f Ancestors: GraphicsTests-mt.60 Fix testAllAlphasRgbMul The BitBlt primitive for rgbMul rule has been fixed so as to round to nearest paint. The test must reflect this. =============== Diff against GraphicsTests-mt.60 =============== Item was changed: ----- Method: BitBltTest>>testAllAlphasRgbMul (in category 'tests') ----- testAllAlphasRgbMul "self run: #testAllAlphasRgbMul" | sourceForm destForm blt correctAlphas | <timeout: 10> correctAlphas := 0. 0 to: 255 do: [:sourceAlpha | sourceForm := Form extent: 1 @ 1 depth: 32. sourceForm bits at: 1 put: sourceAlpha << 24 + (33 << 16) + (25 << 8) + 27. 0 to: 255 do: [:destAlpha | destForm := Form extent: 1 @ 1 depth: 32. destForm bits at: 1 put: destAlpha << 24 + (255 << 16) + (255 << 8) + 255. blt := BitBlt new. blt sourceForm: sourceForm. blt sourceOrigin: 0 @ 0. blt setDestForm: destForm. blt destOrigin: 0 @ 0. blt combinationRule: 37. "rgbMul" blt copyBits. correctAlphas := correctAlphas + + (((blt destForm bits at: 1) digitAt: 4) = (((destAlpha) * (sourceAlpha) / 255) rounded) - + (((blt destForm bits at: 1) digitAt: 4) = ((destAlpha+1) * (sourceAlpha+1)- 1 // 256) ifTrue: [1] ifFalse: [0]) ]]. self assert: 65536 equals: correctAlphas!

1 0

The Trunk: Graphics-nice.539.mcz
by commits＠source.squeak.org 27 Feb '23

27 Feb '23

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.539.mcz ==================== Summary ==================== Name: Graphics-nice.539 Author: nice Time: 27 February 2023, 4:07:26.40556 pm UUID: 5cf207ee-4818-a040-8f22-7f5dff8773d2 Ancestors: Graphics-mt.538 Fix loading of interlaced PNG images with color and alpha Form over was used in https://source.squeak.org/trunk/Graphics-nice.292.diff so as to correctly handle (cheap) transparency in RGB images. Unfortunately, this cannot work with interlaced images, because we overwrite parts of the image that were already downloaded in previous chunks. Concerning interlaced RGBA images, the bug was different and dating from origins (at least from 2004). The rule Form paintAlpha does not use the alpha channel of the image, but rather a constant alpha channel. We replace these erroneous BitBlt rules with Form blendAlphaScaled. =============== Diff against Graphics-mt.538 =============== Item was changed: ----- Method: PNGReadWriter>>copyPixelsRGB:at:by: (in category 'pixel copies') ----- copyPixelsRGB: y at: startX by: incX "Handle interlaced RGB color mode (colorType = 2)" | i pixel tempForm tempBits xx loopsToDo | tempForm := Form extent: width@1 depth: 32. tempBits := tempForm bits. pixel := LargePositiveInteger new: 4. pixel at: 4 put: 16rFF. loopsToDo := width - startX + incX - 1 // incX. bitsPerChannel = 8 ifTrue: [i := (startX // incX * 3) + 1. xx := startX+1. 1 to: loopsToDo do: [ :j | pixel at: 3 put: (thisScanline at: i); at: 2 put: (thisScanline at: i+1); at: 1 put: (thisScanline at: i+2). tempBits at: xx put: pixel normalize. i := i + 3. xx := xx + incX]. transparentPixelValue ifNotNil: [startX to: width-1 by: incX do: [ :x | (tempBits at: x+1) = transparentPixelValue ifTrue: [ tempBits at: x+1 put: 0]]]] ifFalse: [i := (startX // incX * 6) + 1. xx := startX+1. 1 to: loopsToDo do: [ :j | (transparentPixelValue == nil or: [(1 to: 6) anySatisfy: [:k | (transparentPixelValue digitAt: k) ~= (thisScanline at: i + 6 - k)]]) ifTrue: [pixel at: 3 put: (thisScanline at: i); at: 2 put: (thisScanline at: i+2); at: 1 put: (thisScanline at: i+4). tempBits at: xx put: pixel normalize.] ifFalse: [tempBits at: xx put: 0]. i := i + 6. xx := xx + incX]]. + tempForm displayOn: form at: 0@y rule: Form blendAlphaUnscaled - tempForm displayOn: form at: 0@y rule: Form over. ! Item was changed: ----- Method: PNGReadWriter>>copyPixelsRGBA:at:by: (in category 'pixel copies') ----- copyPixelsRGBA: y at: startX by: incX "Handle interlaced RGBA color modes (colorType = 6)" | i pixel tempForm tempBits | tempForm := Form extent: width@1 depth: 32. tempBits := tempForm bits. pixel := LargePositiveInteger new: 4. bitsPerChannel = 8 ifTrue: [ i := (startX // incX << 2) + 1. startX to: width-1 by: incX do: [ :x | pixel at: 4 put: (thisScanline at: i+3); at: 3 put: (thisScanline at: i); at: 2 put: (thisScanline at: i+1); at: 1 put: (thisScanline at: i+2). tempBits at: x+1 put: pixel normalize. i := i + 4. ] ] ifFalse: [ i := (startX // incX << 3) +1. startX to: width-1 by: incX do: [ :x | pixel at: 4 put: (thisScanline at: i+6); at: 3 put: (thisScanline at: i); at: 2 put: (thisScanline at: i+2); at: 1 put: (thisScanline at: i+4). tempBits at: x+1 put: pixel normalize. i := i + 8. ]. ]. + tempForm displayOn: form at: 0@y rule: Form blendAlphaScaled. - tempForm displayOn: form at: 0@y rule: Form paintAlpha. !

1 0

The Trunk: Tools-mt.1191.mcz
by commits＠source.squeak.org 27 Feb '23

27 Feb '23

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1191.mcz ==================== Summary ==================== Name: Tools-mt.1191 Author: mt Time: 27 February 2023, 3:34:31.568644 pm UUID: b6ead586-b005-7143-ac17-513acd0404a4 Ancestors: Tools-mt.1190 Fixes shortcut inconsistency in single-category browsers. Now it matches the popup menu again. =============== Diff against Tools-mt.1190 =============== Item was changed: ----- Method: Browser>>systemCatSingletonKey:from: (in category 'initialize-release') ----- systemCatSingletonKey: aChar from: aView + ^ self systemCatListKey: aChar from: aView! - ^ self messageListKey: aChar from: aView! Item was removed: - ----- Method: HierarchyBrowser>>systemCatSingletonKey:from: (in category 'menu messages') ----- - systemCatSingletonKey: aChar from: aView - "This appears to be obsolete now that the hierarchybrowser has not category view" - ^ self systemCatListKey: aChar from: aView!

1 0

← Newer
1
2
3
4
5
6
7
...
11
Older →