Squeak-dev February 2023

squeak-dev@lists.squeakfoundation.org

28 participants
108 discussions

Missing ID in DataStream TypeMap for CompiledBlock
by Stéphane Rollandin 01 Feb '23

01 Feb '23

Hello all, While checking if my code works in 6.0, I noticed that a serialization failed because a CompiledBlock is not filed out with its correct type ID (as in DataStream>>#typeIDFor:). Adding the entry in the TypeMap dictionary fixed the problem (CompiledMethod was present with ID 21, but not CompiledBlock). See the attached method. Stef

2 1

The Trunk: System-mt.1388.mcz
by commits＠source.squeak.org 01 Feb '23

01 Feb '23

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1388.mcz ==================== Summary ==================== Name: System-mt.1388 Author: mt Time: 1 February 2023, 11:43:21.869959 am UUID: 5efd03cc-8603-8540-8313-cd8b7292549c Ancestors: System-mt.1387 Fix file-out type-id for CompiledBlock. Thanks to Stéphane (spfa)! =============== Diff against System-mt.1387 =============== Item was changed: ----- Method: DataStream class>>initialize (in category 'class initialization') ----- initialize "TypeMap maps Smalltalk classes to type ID numbers which identify the data stream primitive formats. nextPut: writes these IDs to the data stream. NOTE: Changing these type ID numbers will invalidate all extant data stream files. Adding new ones is OK. Classes named here have special formats in the file. If such a class has a subclass, it will use type 9 and write correctly. It will just be slow. (Later write the class name in the special format, then subclasses can use the type also.) See nextPut:, next, typeIDFor:, & ReferenceStream>>isAReferenceType:" "DataStream initialize" | refTypes t | refTypes := OrderedCollection new. t := TypeMap := WeakIdentityKeyDictionary new. "It has to be weak, because some classes may go away, leaving obsolete versions in this dictionary which may make it corrupt." t at: UndefinedObject put: 1. refTypes add: 0. t at: True put: 2. refTypes add: 0. t at: False put: 3. refTypes add: 0. t at: SmallInteger put: 4. refTypes add: 0. t at: ByteString put: 5. refTypes add: 1. t at: ByteSymbol put: 6. refTypes add: 1. t at: ByteArray put: 7. refTypes add: 1. t at: Array put: 8. refTypes add: 1. "(type ID 9 is for arbitrary instances of any class, cf. typeIDFor:)" refTypes add: 1. "(type ID 10 is for references, cf. ReferenceStream>>tryToPutReference:)" refTypes add: 0. t at: Bitmap put: 11. refTypes add: 1. t at: Metaclass put: 12. refTypes add: 0. "Type ID 13 is used for HyperSqueak User classes that must be reconstructed." refTypes add: 1. t at: Float put: 14. refTypes add: 1. t at: Rectangle put: 15. refTypes add: 1. "Allow compact Rects." "type ID 16 is an instance with short header. See beginInstance:size:" refTypes add: 1. self flag: #ByteArray. t at: ByteString put: 17. refTypes add: 1. "new String format, 1 or 4 bytes of length" t at: WordArray put: 18. refTypes add: 1. "bitmap-like" t at: WordArrayForSegment put: 19. refTypes add: 1. "bitmap-like" t at: SoundBuffer put: 20. refTypes add: 1. "And all other word arrays, both 16-bit and 32-bit. See methods in ArrayedCollection. Overridden in SoundBuffer." t at: CompiledMethod put: 21. refTypes add: 1. "special creation method" + t at: CompiledBlock put: 21. refTypes add: 1. "special creation method" "t at: put: 22. refTypes add: 0." ReferenceStream refTypes: refTypes. "save it" "For all classes that are like WordArrays, store them the way ColorArray is stored. As bits, and able to change endianness." Smalltalk globals do: [:cls | (cls isInMemory and: [ cls isBehavior and: [ cls isObsolete not and: [ cls isPointers not and: [ cls isVariable and: [ cls isWords and: [ (t includesKey: cls) not ] ] ] ] ] ]) ifTrue: [ t at: cls put: 20 ] ]!

1 0

Squeak 6.0: System-mt.1368.mcz
by commits＠source.squeak.org 01 Feb '23

01 Feb '23

Marcel Taeumel uploaded a new version of System to project Squeak 6.0: http://source.squeak.org/squeak60/System-mt.1368.mcz ==================== Summary ==================== Name: System-mt.1368 Author: mt Time: 1 February 2023, 11:42:38.689822 am UUID: c6edc712-47e7-dd4d-8426-23f9228cf3dc Ancestors: System-mt.1367 Fix file-out type-id for CompiledBlock. Thanks to Stéphane (spfa)! =============== Diff against System-mt.1367 =============== Item was changed: ----- Method: DataStream class>>initialize (in category 'class initialization') ----- initialize "TypeMap maps Smalltalk classes to type ID numbers which identify the data stream primitive formats. nextPut: writes these IDs to the data stream. NOTE: Changing these type ID numbers will invalidate all extant data stream files. Adding new ones is OK. Classes named here have special formats in the file. If such a class has a subclass, it will use type 9 and write correctly. It will just be slow. (Later write the class name in the special format, then subclasses can use the type also.) See nextPut:, next, typeIDFor:, & ReferenceStream>>isAReferenceType:" "DataStream initialize" | refTypes t | refTypes := OrderedCollection new. t := TypeMap := WeakIdentityKeyDictionary new. "It has to be weak, because some classes may go away, leaving obsolete versions in this dictionary which may make it corrupt." t at: UndefinedObject put: 1. refTypes add: 0. t at: True put: 2. refTypes add: 0. t at: False put: 3. refTypes add: 0. t at: SmallInteger put: 4. refTypes add: 0. t at: ByteString put: 5. refTypes add: 1. t at: ByteSymbol put: 6. refTypes add: 1. t at: ByteArray put: 7. refTypes add: 1. t at: Array put: 8. refTypes add: 1. "(type ID 9 is for arbitrary instances of any class, cf. typeIDFor:)" refTypes add: 1. "(type ID 10 is for references, cf. ReferenceStream>>tryToPutReference:)" refTypes add: 0. t at: Bitmap put: 11. refTypes add: 1. t at: Metaclass put: 12. refTypes add: 0. "Type ID 13 is used for HyperSqueak User classes that must be reconstructed." refTypes add: 1. t at: Float put: 14. refTypes add: 1. t at: Rectangle put: 15. refTypes add: 1. "Allow compact Rects." "type ID 16 is an instance with short header. See beginInstance:size:" refTypes add: 1. self flag: #ByteArray. t at: ByteString put: 17. refTypes add: 1. "new String format, 1 or 4 bytes of length" t at: WordArray put: 18. refTypes add: 1. "bitmap-like" t at: WordArrayForSegment put: 19. refTypes add: 1. "bitmap-like" t at: SoundBuffer put: 20. refTypes add: 1. "And all other word arrays, both 16-bit and 32-bit. See methods in ArrayedCollection. Overridden in SoundBuffer." t at: CompiledMethod put: 21. refTypes add: 1. "special creation method" + t at: CompiledBlock put: 21. refTypes add: 1. "special creation method" "t at: put: 22. refTypes add: 0." ReferenceStream refTypes: refTypes. "save it" "For all classes that are like WordArrays, store them the way ColorArray is stored. As bits, and able to change endianness." Smalltalk globals do: [:cls | (cls isInMemory and: [ cls isBehavior and: [ cls isObsolete not and: [ cls isPointers not and: [ cls isVariable and: [ cls isWords and: [ (t includesKey: cls) not ] ] ] ] ] ]) ifTrue: [ t at: cls put: 20 ] ]!

1 0

The Inbox: Morphic-ct.2082.mcz
by commits＠source.squeak.org 01 Feb '23

01 Feb '23

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2082.mcz ==================== Summary ==================== Name: Morphic-ct.2082 Author: ct Time: 28 January 2023, 8:57:55.639628 pm UUID: dfcaa928-8758-5a42-a55b-2d89712a2a86 Ancestors: Morphic-mt.2081 To review: Fixes flickering in multi-column lists by ensuring sufficiently stable computation in #maxWidth. This is likely to have a small but noticable negative impact on the performance for large lists, but I think this is inevitable if we want to avoid flickering. Otherwise, we could only consider computing the layout completely lazily during drawing. For instance, the original bug can be reproduced by loading the SimulationMethodFinder from SimulationStudio, doing Morph new exploreProtocol and scrolling down until methodCommentAsBalloonHelp comes into view. =============== Diff against Morphic-mt.2081 =============== Item was changed: ----- Method: LazyListMorph>>maxWidth (in category 'layout') ----- maxWidth + "Approximate the maximum width of this lazy list. Take all visible items as a sample. + + NOTE that we MUST compute the width for all items in view!! Otherwise, maxWidth might be instable and be increased again during drawing in #item:, causing the receiver to flicker after each #layoutChanged (e.g., from PluggableMultiColumnListMorph>>#updateColumns)." - "Approximate the maximum width of this lazy list. Take first n items as a sample." + | listSize visibleBounds topRow bottomRow | + maxWidth ifNotNil: [^maxWidth]. + - | threshold listSize | - maxWidth ifNotNil:[^maxWidth]. - - threshold := 30. listSize := self getListSize. + visibleBounds := self bounds: self owner bounds from: self owner. + topRow := self rowAtLocation: visibleBounds topLeft. + bottomRow := self rowAtLocation: visibleBounds bottomLeft. + maxWidth := 0. + topRow to: bottomRow do: [:index | - 1 to: (threshold min: listSize) do: [:index | maxWidth := maxWidth max: (self widthToDisplayItem: (self getListItem: index))]. + + ^ maxWidth! - - ^ maxWidth - !

4 5

{'Squeak Help' . a TheWorldMainDockingBar . #squeakHelp . nil}
by Eduardo Ochs 01 Feb '23

01 Feb '23

Hi list, I'm trying to port to Squeak an idea that use a lot in Emacs, that is to use one-liners as hyperlinks. There's a page with a detailed explanation of that idea in this link, http://anggtwu.net/eev-squeak.html and here goes a short explanation, and a question. I'm working on a class called "See", and my one-liners that work as hyperlinks always start with "See". For example, these ones See class: HelpBrowser. See class: HelpBrowser method: #accept:. See class: See. See class: See classMethod: #item1ctsa:. See class: See classMethod: #class:method:. See class: See classMethod: #class:classMethod:. make the SystemBrowser display different pieces of information, and these one liners See fileList. See helpBrowser. See messageNames. See methodFinder. are equivalent to running: Tools -> File List Apps -> Help Browser World -> open -> message names World -> open -> method finder but there are LOTS of menu entries that I don't know how to implement as one-liners, because their "targets" are objects that I don't know how to access from "global code"... let me explain this. When I run "See methodFinder" it runs this: "ECToolSet openSelectorBrowser". I discovered that the "action" associated to "World -> open -> method finder" is "ECToolSet openSelectorBrowser" by using the halo to duplicate the entry "method finder" in the menu "World -> open", and then I examined the "contents", the "target", the "selector", and "arguments" of that first item of that menu with just one entry. Here is a visual explanation in a screenshot, http://anggtwu.net/IMAGES/2023-squeak-item1ctsa.png and in that case my function that returns the fields "contents", "target", "selector", and "arguments" of a menu item returns this: {'method finder' . ECToolSet . #openSelectorBrowser . #()} When I try to do the same for "Help -> Squeak help" I get: {'Squeak Help' . a TheWorldMainDockingBar . #squeakHelp . nil} note the "a"... =( When I run this to try to find a global variable that holds an object of the class TheWorldMainDockingBar, Smalltalk globals keysAndValuesDo: [:k :v | (v isKindOf: TheWorldMainDockingBar) ifTrue: [ Transcript show: k; cr. ] ]. it returns nothing. So I wrote these two methods in my class "See" to help me find active morphs of a given class, --snip--snip-- !See class methodsFor: 'other links' stamp: 'Edrx 2/1/2023 00:55'! worldMorphs "Return an OrderCollection with all the morphs whose world is non-nil. Test: See worldMorphs explore. " ^ Morph allSubInstances select: [ :m | m world notNil ]. ! ! !See class methodsFor: 'other links' stamp: 'Edrx 2/1/2023 00:57'! worldMorphs: class "Return an OrderCollection with all the morphs whose world is non-nil, and that are objects of the given class. Test: (See worldMorphs: DockingBarItemMorph) explore. " ^ Morph allSubInstances select: [ :m | (m world notNil) and: [m isKindOf: class] ] ! ! --snip--snip-- but for the class TheWorldMainDockingBar this one-liner (See worldMorphs: TheWorldMainDockingBar) explore. returned no instances... Any suggestions? Thanks in advance, Eduardo Ochs http://anggtwu.net/eev-squeak.html http://anggtwu.net/SQUEAK/See.st.html http://anggtwu.net/SQUEAK/See.st P.S.: I tried to send questions to the beginners mailing list, but that list is kind of dead... so I tried to make my question a bit less beginner-ish, and I am sending it here to squeak-dev...

2 1

The Trunk: Morphic-mt.2088.mcz
by commits＠source.squeak.org 01 Feb '23

01 Feb '23

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2088.mcz ==================== Summary ==================== Name: Morphic-mt.2088 Author: mt Time: 1 February 2023, 10:50:36.863309 am UUID: bdece633-329a-554b-8704-cc4235bc4966 Ancestors: Morphic-mt.2087 Fixes visual glitch w/ filter background in multi-column lists. =============== Diff against Morphic-mt.2087 =============== Item was changed: ----- Method: LazyListMorph>>drawOn: (in category 'drawing') ----- drawOn: aCanvas | topRow bottomRow | + self backgroundColor ifNotNil: [:bgColor | | extra | + self owner ifNil: [extra := 0] ifNotNil: [:o | + extra := o boundsInWorld bottom - self boundsInWorld bottom max: 0]. + aCanvas + fillRectangle: (self topLeft corner: self bottomRight + (0@extra)) + color: bgColor]. - self backgroundColor ifNotNil: - [:bkgndColor | - aCanvas fillRectangle: (self topLeft corner: self right @ ((self owner ifNil: [self]) bottom)) color: bkgndColor]. self getListSize = 0 ifTrue: [ ^self ]. self drawPreSelectionOn: aCanvas. topRow := self topVisibleRowForCanvas: aCanvas. bottomRow := self bottomVisibleRowForCanvas: aCanvas. "Draw multi-selection." self listSource hasMultiSelection ifTrue: [topRow to: bottomRow do: [:row | (self listSource itemSelectedAmongMultiple: row) ifTrue: [self drawBackgroundForMulti: row on: aCanvas]]]. self drawSelectionOn: aCanvas. "Draw hovered row if preference enabled." PluggableListMorph highlightHoveredRow ifTrue: [self listSource hoverRow > 0 ifTrue: [self highlightHoverRow: listSource hoverRow on: aCanvas ]]. "Draw all visible rows." topRow to: bottomRow do: [:row | self display: (self item: row) atRow: row on: aCanvas ]. "Finally, highlight drop row for drag/drop operations.." self listSource potentialDropRow > 0 ifTrue: [self highlightPotentialDropRow: self listSource potentialDropRow on: aCanvas ].!

1 0

The Trunk: Morphic-mt.2087.mcz
by commits＠source.squeak.org 01 Feb '23

01 Feb '23

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2087.mcz ==================== Summary ==================== Name: Morphic-mt.2087 Author: mt Time: 1 February 2023, 10:28:20.602309 am UUID: cce09371-2b26-b54b-b6e3-dc09e11cc469 Ancestors: Morphic-mt.2086 Harmonize filter-background color between multi-column lists and tree widgets. =============== Diff against Morphic-mt.2086 =============== Item was changed: ----- Method: IndentingListItemMorph class>>applyUserInterfaceTheme (in category 'preferences') ----- applyUserInterfaceTheme + FilterBackgroundColor := PluggableMultiColumnListMorph filterColumnColor.! - FilterBackgroundColor := (UserInterfaceTheme current get: #hoverSelectionModifier for: #PluggableListMorph) - ifNil: [ Color white darker alpha: 0.3 ] - ifNotNil: [:modifier | modifier value: ((UserInterfaceTheme current get: #color for: #ScrollPane) - ifNil: [ Color white ]) ].! Item was changed: ----- Method: IndentingListItemMorph class>>themePriority (in category 'preferences') ----- themePriority + ^ PluggableMultiColumnListMorph themePriority - 1! - ^ 65! Item was changed: ----- Method: IndentingListItemMorph class>>themeProperties (in category 'preferences') ----- themeProperties ^ { + { #filterBackgroundColor. 'Styling'. 'Background color for filter matches.' }. - { #backgroundFilterColor. 'Styling'. 'Background color for filter matches.' }. }! Item was changed: ----- Method: IndentingListItemMorph>>applyUserInterfaceTheme (in category 'updating') ----- applyUserInterfaceTheme + filterOffsets := nil. + backgroundColor ifNotNil: [backgroundColor := FilterBackgroundColor].! - filterOffsets := nil.! Item was changed: PluggableListMorph subclass: #PluggableMultiColumnListMorph instanceVariableNames: 'listMorphs' + classVariableNames: 'FilterColumnColor' - classVariableNames: '' poolDictionaries: '' category: 'Morphic-Pluggable Widgets'! !PluggableMultiColumnListMorph commentStamp: '<historical>' prior: 0! This morph can be used to show a list having multiple columns, The columns are self width sized to make the largest entry in each list fit. In some cases the pane may then be too narrow. Use it like a regular PluggableListMorph except pass in an array of lists instead of a single list. There are base assumptions made here that each list in the array of lists is the same size. Also, the highlight color for the selection is easy to modify in the #highlightSelection method. I used blue when testing just to see it work.! Item was added: + ----- Method: PluggableMultiColumnListMorph class>>applyUserInterfaceTheme (in category 'preferences') ----- + applyUserInterfaceTheme + + FilterColumnColor := nil.! Item was added: + ----- Method: PluggableMultiColumnListMorph class>>filterColumnColor (in category 'defaults') ----- + filterColumnColor + + ^ FilterColumnColor ifNil: [FilterColumnColor := (self userInterfaceTheme get: #hoverSelectionModifier for: self) + ifNil: [ (Color gray: 0.85) alpha: 0.5 ] + ifNotNil: [:modifier | modifier value: ((self userInterfaceTheme get: #color for: self) + ifNil: [ Color white ])]]! Item was added: + ----- Method: PluggableMultiColumnListMorph class>>themePriority (in category 'defaults') ----- + themePriority + + ^ 65! Item was added: + ----- Method: PluggableMultiColumnListMorph class>>themeProperties (in category 'preferences') ----- + themeProperties + + ^ super themeProperties, { + { #filterColumnColor. 'Styling'. 'Background color for filtered columns.' }. + }! Item was changed: ----- Method: PluggableMultiColumnListMorph>>filterColumnColor (in category 'filtering') ----- filterColumnColor + ^ self class filterColumnColor! - ^ (Color gray: 0.85) alpha: 0.4! Item was changed: ----- Method: PluggableMultiColumnListMorph>>setListParameters (in category 'initialization') ----- setListParameters listMorphs ifEmpty: [^ super setListParameters]. + listMorphs do: [:lm | + lm showFilter ifTrue: [lm backgroundColor: self filterColumnColor]. + listMorph := lm. super setListParameters]. - listMorphs do: [:lm | listMorph := lm. super setListParameters]. listMorph := listMorphs first.!

1 0

The Trunk: Morphic-mt.2086.mcz
by commits＠source.squeak.org 01 Feb '23

01 Feb '23

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2086.mcz ==================== Summary ==================== Name: Morphic-mt.2086 Author: mt Time: 1 February 2023, 9:22:07.208309 am UUID: e88c200d-3b9f-1b48-ad27-1ac0669b74a2 Ancestors: Morphic-mt.2085 Fix filter-background color in tree widgets. =============== Diff against Morphic-mt.2085 =============== Item was changed: + (PackageInfo named: 'Morphic') postscript: 'IndentingListItemMorph applyUserInterfaceTheme. "Filter background color"'! - (PackageInfo named: 'Morphic') postscript: 'UserInterfaceTheme cleanUpAndReset.'!

1 0