Squeak-dev June 2022

squeak-dev@lists.squeakfoundation.org

30 participants
309 discussions

The Trunk: Graphics-mt.519.mcz
by commits＠source.squeak.org 03 Jun '22

03 Jun '22

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.519.mcz ==================== Summary ==================== Name: Graphics-mt.519 Author: mt Time: 3 June 2022, 11:46:00.379122 am UUID: 617a1b80-ce28-3146-8ddd-1544e6042cc8 Ancestors: Graphics-mt.518 To avoid graphics glitches when drawing text selections, adjust #lineHeight instead of #bottomMargin to realize #lineSpacing during text composition. =============== Diff against Graphics-mt.518 =============== Item was changed: ----- Method: CompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide: (in category 'scanning') ----- composeFrom: startIndex inRectangle: lineRectangle firstLine: firstLine leftSide: leftSide rightSide: rightSide "Answer an instance of TextLineInterval that represents the next line in the paragraph." | runLength stopCondition lineSpacing | "Set up margins" leftMargin := lineRectangle left. leftSide ifTrue: [leftMargin := leftMargin + (firstLine ifTrue: [textStyle firstIndent] ifFalse: [textStyle restIndent])]. destX := spaceX := leftMargin. rightMargin := lineRectangle right. rightSide ifTrue: [rightMargin := rightMargin - textStyle rightIndent]. lastIndex := startIndex. "scanning sets last index" destY := lineRectangle top. lineHeight := baseline := 0. "Will be increased by setFont" lineGap := lineGapSlice := -9999. "Will be increased by setFont; allow negative to show all effects of a custom #extraGap value. See TTFontDescription." topMargin := bottomMargin := 0. line := (TextLine start: lastIndex stop: 0 internalSpaces: 0 paddingWidth: 0) rectangle: lineRectangle. self setStopConditions. "also sets font" runLength := text runLengthFor: startIndex. runStopIndex := (lastIndex := startIndex) + (runLength - 1). nextIndexAfterLineBreak := spaceCount := 0. lastBreakIsNotASpace := false. self handleIndentation. leftMargin := destX. line leftMargin: leftMargin. [stopCondition := self scanCharactersFrom: lastIndex to: runStopIndex in: text string rightX: rightMargin. "See setStopConditions for stopping conditions for composing." self perform: stopCondition] whileFalse. lineHeight := lineHeight + lineGap. baseline := baseline + lineGapSlice. + (lineSpacing := textStyle lineSpacing) = 0.0 ifFalse: [ + "Modify lineHeight to realize lineSpacing instead of bottomMargin to avoid + rendering glitches for lineSpacing values < 0.0." + lineHeight := lineHeight + (lineSpacing * lineHeight) truncated. + "ALT: bottomMargin := bottomMargin + (lineSpacing * lineHeight) truncated"]. - "TODO: Allow special characters or text attributes to accumulate extra top or bottom margin." - (lineSpacing := textStyle lineSpacing) = 0.0 - ifFalse: [bottomMargin := bottomMargin + (lineSpacing * lineHeight) truncated]. line lineHeight: lineHeight baseline: baseline. + "TODO: Allow special characters or text attributes to accumulate extra top or bottom margin." line topMargin: topMargin bottomMargin: bottomMargin. ^ line!

1 0

[ANN] OpenSmalltalk VM 2022.06 released (tag 202206021410)
by Marcel Taeumel 03 Jun '22

03 Jun '22

Hi all! We just made a patch release: https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/202206021410 [https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/202206021410] - Adds joystick/gamepad support on Linux - Fixes support for OpenSSL3 on Linux - Fixes resolution of fully-qualified domain names (FQDNs) longer than 64 characters on Linux (Squeak's bundles will be updated ASAP. Check the name of the file/archive download.) Best, Marcel (on behalf of the OSVM core dev team)

1 0

The Trunk: Morphic-mt.1998.mcz
by commits＠source.squeak.org 03 Jun '22

03 Jun '22

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1998.mcz ==================== Summary ==================== Name: Morphic-mt.1998 Author: mt Time: 3 June 2022, 10:03:38.000381 am UUID: 50a6fd6c-1405-403a-a99b-7944c2f6ce0a Ancestors: Morphic-tonyg.1997 For macOS platform, fixes the preference "Legacy keyboard shortcuts (US/UK only)". Thanks to Tim (tcj) for the pointer! =============== Diff against Morphic-tonyg.1997 =============== Item was changed: ----- Method: LegacyShortcutsFilter class>>filterEvent:for: (in category 'event filter') ----- filterEvent: aKeyboardEvent for: textMorph + aKeyboardEvent isKeystroke ifFalse: [^ aKeyboardEvent]. aKeyboardEvent commandKeyPressed ifFalse: [^ aKeyboardEvent]. Preferences cmdKeysInText ifFalse: [^ aKeyboardEvent]. + + (Smalltalk platformName = 'Mac OS' and: [aKeyboardEvent shiftPressed]) + ifTrue: ["Work around an issue in the VM where SHIFT is not honored + in the KeyChar event's character. This should only be the case for + KeyDown events to encode virtual-key presses. The VM should not + do this for KeyChar events. Works for U.S. keyboard layout only." + aKeyboardEvent keyValue: ( + aKeyboardEvent keyCharacter caseOf: { + [$9] -> [$(]. [$0] -> [$)]. + [$,] -> [$<]. [$.] -> [$>]. + [$[] -> [${]. [$]] -> [$}]. + [$'] -> [$"] } + otherwise: [aKeyboardEvent keyCharacter]) asInteger]. + - ('()[]{}|''"<>' includes: aKeyboardEvent keyCharacter) ifTrue: [textMorph handleInteraction: [(textMorph editor enclose: aKeyboardEvent) ifTrue: [aKeyboardEvent ignore]] fromEvent: aKeyboardEvent]. ^ aKeyboardEvent " Preferences cmdKeysInText Preferences cmdGesturesEnabled Preferences honorDesktopCmdKeys PasteUpMorph globalCommandKeysEnabled. "!

1 0

testOutOfMemorySignalExtreme too disruptive
by Lauren Pullen 02 Jun '22

02 Jun '22

Hi list, I can't remember if I already asked this, please ignore if it's a double. AllocationTest's testOutOfMemorySignalExtreme is too disruptive to the rest of the OS to run by default. It will absolutely fill my hard drive with pagefile if the OS doesn't trap and ask me to start terminating processes first. If the pagefile fills the hard drive many programs are simply incapable of not corrupting their persisted state... every time it happens I need to go through and delete preferences and cache folders. The test has never completed, and I lack a 1 TB hard drive or unused ones to RAID together. I feel it's appropriate to disable that test and require users explicitly allow it to run. Personally, I delete the method. Can this be disabled?

5 5

Latest VM appears to mess with initial window size
by tim Rowledge 02 Jun '22

02 Jun '22

I'm just trying the latest release VM (ARMv8 on a Pi in this case) and it seems to be doing Odd Things with the window size. The same image on two different Pis opens with different window sizes. One Pi has a 1920@180 screen and the initial window is notably smaller than what it was when I saved the image, the other has a 1920@1440 screen and the initial window size is what I set. That size is not larger than the 1920@1080 screen, by the way. To the best of my recollection this is new (mis)behaviour. We've always done some startup checks in the VM to fit the window within the available display limits but I don't remember previously over-riding the requested size this aggressively. Has anyone changed this code recently? Or is this a side effect of recent scale factor stuff? I can't spot any suspicious code in the image right now. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim A misplaced modifier walks into a bar owned a man with a glass eye named Ralph

3 11

Latest trunk image - but in loading OCompletion
by Chris Cunningham 02 Jun '22

02 Jun '22

Hi. Just downloaded the latest trunk image (interestingly was a 5/18 image - 14 days since last image available), and while configuring, decided to load the Completion package (chose the check box). It failed partway through with #ifNotNilDo: undefined, called in: ORecentChanges>>fillCompletionTable: table withRecord: r r methodClass ifNotNilDo: [:cls | table compiled: r methodSelector in: cls date: r timeStamp] Thanks, cbc

2 1

The Trunk: KernelTests-cmm.423.mcz
by commits＠source.squeak.org 02 Jun '22

02 Jun '22

Marcel Taeumel uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-cmm.423.mcz ==================== Summary ==================== Name: KernelTests-cmm.423 Author: cmm Time: 31 May 2022, 5:53:42.444296 pm UUID: a504f011-37fb-4d93-ae2f-c3e1fc832b49 Ancestors: KernelTests-nice.422 #testOutOfMemorySignalExtreme can be stressful on a system that running the Squeak VM unconstrained (which is the default). Therefore, only run it if the vm is explicitly constrained. Note this requires =============== Diff against KernelTests-nice.422 =============== Item was changed: ----- Method: AllocationTest>>testOutOfMemorySignalExtreme (in category 'tests') ----- testOutOfMemorySignalExtreme + "Try to allocate more memory than permitted by the -memory vm argument, and check whether the expected error is signaled. Note that current (2017) Spur VMs fail in #new: and #basicNew: with #'bad argument' if given other than a non-negative SmallInteger." + Smalltalk heapMemoryLimit ifNotNil: + [ : bytes | + self + should: [ Array new: (bytes // Smalltalk wordSize) + 100 ] + raise: OutOfMemory, Error + withExceptionDo: + [:ex| + ex class == Error ifTrue: + [self assert: [ex messageText includesSubstring: 'basicNew: with invalid argument' ]]]]! - "Try to allocate a ridiculous amount of memory and check whether the expected error is signaled. Call Eliot when this test fails, he want your machine. :-) - - Note that current (2017) Spur VMs fail in #new: and #basicNew: with #'bad argument' if given other than a non-negative SmallInteger. - - Also note that this test can be quite stressful to your machine depending on how your operating system allocates the required memory behind the curtains. Better not triggering some robot fetching a tape from somewhere..." - - | sz | - sz := 1024*1024*1024*1024. "= 1 TiB" - self should: [Array new: sz] - raise: OutOfMemory, Error - withExceptionDo: - [:ex| - ex class == Error ifTrue: - [self assert: [ex messageText includesSubstring: 'basicNew: with invalid argument']]]!

1 0

The Trunk: KernelTests-mt.425.mcz
by commits＠source.squeak.org 02 Jun '22

02 Jun '22

Marcel Taeumel uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-mt.425.mcz ==================== Summary ==================== Name: KernelTests-mt.425 Author: mt Time: 2 June 2022, 4:50:53.645188 pm UUID: 40d8ed98-0cd5-794a-b71f-0201c1d44ec0 Ancestors: KernelTests-mt.424, KernelTests-cmm.423 Merge KernelTests-cmm.423. #testOutOfMemorySignalExtreme can be stressful on a system that running the Squeak VM unconstrained (which is the default). Therefore, only run it if the vm is explicitly constrained. =============== Diff against KernelTests-mt.424 =============== Item was changed: ----- Method: AllocationTest>>testOutOfMemorySignalExtreme (in category 'tests') ----- testOutOfMemorySignalExtreme + "Try to allocate more memory than permitted by the -memory vm argument, and check whether the expected error is signaled. Note that current (2017) Spur VMs fail in #new: and #basicNew: with #'bad argument' if given other than a non-negative SmallInteger." + Smalltalk heapMemoryLimit ifNotNil: + [ : bytes | + self + should: [ Array new: (bytes // Smalltalk wordSize) + 100 ] + raise: OutOfMemory, Error + withExceptionDo: + [:ex| + ex class == Error ifTrue: + [self assert: [ex messageText includesSubstring: 'basicNew: with invalid argument' ]]]]! - "Try to allocate a ridiculous amount of memory and check whether the expected error is signaled. Call Eliot when this test fails, he want your machine. :-) - - Note that current (2017) Spur VMs fail in #new: and #basicNew: with #'bad argument' if given other than a non-negative SmallInteger. - - Also note that this test can be quite stressful to your machine depending on how your operating system allocates the required memory behind the curtains. Better not triggering some robot fetching a tape from somewhere..." - - | sz | - sz := 1024*1024*1024*1024. "= 1 TiB" - self should: [Array new: sz] - raise: OutOfMemory, Error - withExceptionDo: - [:ex| - ex class == Error ifTrue: - [self assert: [ex messageText includesSubstring: 'basicNew: with invalid argument']]]!

1 0

The Trunk: System-cmm.1353.mcz
by commits＠source.squeak.org 02 Jun '22

02 Jun '22

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.1353.mcz ==================== Summary ==================== Name: System-cmm.1353 Author: cmm Time: 31 May 2022, 5:50:31.586558 pm UUID: 52f9f789-3ad3-4ec7-914f-85f05ecaaead Ancestors: System-mt.1352 Added SmalltalkImage>>#heapMemoryLimit to access the -memory or -maxoldspace arguments passed to the vm. =============== Diff against System-mt.1352 =============== Item was added: + ----- Method: SmalltalkImage>>heapMemoryLimit (in category 'memory space') ----- + heapMemoryLimit + "If a memory-limiting argument to the vm was supplied (-memory or -maxoldspace), answer it as an Integer number of bytes, otherwise, nil." + | foundMemoryArg | + foundMemoryArg := false. + Smalltalk optionsDo: + [ : each | + (#('-memory' '--memory' '-maxoldspace' '--maxoldspace') includes: each) + ifTrue: [ foundMemoryArg := true ] + ifFalse: + [ foundMemoryArg ifTrue: + [ | arg | + arg := each. + "The memory arg is expected to be a number that ends in k, m, or g." + (arg isEmptyOrNil or: [ arg size < 2 ]) ifFalse: + [ | requestedMemory | + requestedMemory := (arg copyFrom: 1 to: arg size - 1) asNumber. + requestedMemory > 0 ifTrue: + [ ^ requestedMemory * (arg last + caseOf: + { [$k] -> [1000]. [$K] -> [1000]. + [$m] -> [1e6]. [$M] -> [1e6]. + [$g] -> [1e9]. [$G] -> [1e9] } + otherwise: [^nil]) ] ] ] ] ]. + ^ nil! Item was removed: - ----- Method: TTFileDescription>>profileAll (in category '*System-Tools-profiling') ----- - profileAll - "Profile reading all the glyphs" - MessageTally spyOn:[ - 1 to: numGlyphs do:[:glyphIndex| self readGlyphAt: glyphIndex-1]. - ].!

1 0

The Trunk: System-mt.1354.mcz
by commits＠source.squeak.org 02 Jun '22

02 Jun '22

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1354.mcz ==================== Summary ==================== Name: System-mt.1354 Author: mt Time: 2 June 2022, 4:49:50.191188 pm UUID: 385b6eb3-474e-1a42-920c-f6ab09d67baa Ancestors: System-ct.1353, System-cmm.1353 Merge System-cmm.1353 in preparetion of fixing that exteme allocation test. =============== Diff against System-ct.1353 =============== Item was added: + ----- Method: SmalltalkImage>>heapMemoryLimit (in category 'memory space') ----- + heapMemoryLimit + "If a memory-limiting argument to the vm was supplied (-memory or -maxoldspace), answer it as an Integer number of bytes, otherwise, nil." + | foundMemoryArg | + foundMemoryArg := false. + Smalltalk optionsDo: + [ : each | + (#('-memory' '--memory' '-maxoldspace' '--maxoldspace') includes: each) + ifTrue: [ foundMemoryArg := true ] + ifFalse: + [ foundMemoryArg ifTrue: + [ | arg | + arg := each. + "The memory arg is expected to be a number that ends in k, m, or g." + (arg isEmptyOrNil or: [ arg size < 2 ]) ifFalse: + [ | requestedMemory | + requestedMemory := (arg copyFrom: 1 to: arg size - 1) asNumber. + requestedMemory > 0 ifTrue: + [ ^ requestedMemory * (arg last + caseOf: + { [$k] -> [1000]. [$K] -> [1000]. + [$m] -> [1e6]. [$M] -> [1e6]. + [$g] -> [1e9]. [$G] -> [1e9] } + otherwise: [^nil]) ] ] ] ] ]. + ^ nil!

1 0

Jump to page: