Squeak-dev March 2020

squeak-dev@lists.squeakfoundation.org

38 participants
318 discussions

tedious programming-in-the-debugger error needs fixing
by Eliot Miranda 09 Oct '20

09 Oct '20

Hi All, if in a block in the debugger and one redefines the method, the debugger says "I will need to go back to the method that defined this block" or some such. If there is a syntax error in the new code one is trying to compile then the original method is displayed, the syntax error is displayed in that original text, and one's edited text is lost. _,,,^..^,,,_ best, Eliot

16 51

The Inbox: ToolBuilder-Kernel-ct.135.mcz
by commits＠source.squeak.org 01 Oct '20

01 Oct '20

Christoph Thiede uploaded a new version of ToolBuilder-Kernel to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Kernel-ct.135.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-ct.135 Author: ct Time: 24 January 2020, 6:34:43.604574 pm UUID: 3ec2613e-56d3-2d41-b5c3-799a66a986e9 Ancestors: ToolBuilder-Kernel-mt.134 Provides fallback implementations for some UIManager messages =============== Diff against ToolBuilder-Kernel-mt.134 =============== Item was changed: ----- Method: UIManager>>chooseFrom:values:lines:title: (in category 'ui requests') ----- chooseFrom: labelList values: valueList lines: linesArray title: aString + "Choose an item from the given list. Answer the corresponding value." + | result | + result := self chooseFrom: labelList lines: linesArray title: aString. + (result isNil or: [result isZero]) ifTrue: [^ nil]. + ^ valueList at: result! - "Choose an item from the given list. Answer the selected item." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>confirm:orCancel: (in category 'ui requests') ----- confirm: aString orCancel: cancelBlock + "Put up a yes/no/cancel menu with caption aString. Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. This is a modal question--the user must respond yes or no." + ^ (self confirm: aString) + ifFalse: [cancelBlock value]; + yourself! - "Put up a yes/no/cancel menu with caption aString. Answer true if - the response is yes, false if no. If cancel is chosen, evaluate - cancelBlock. This is a modal question--the user must respond yes or no." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>confirm:orCancel:title: (in category 'ui requests') ----- confirm: aString orCancel: cancelBlock title: titleString + "Put up a yes/no/cancel menu with caption aString, and titleString to label the dialog. Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. This is a modal question--the user must respond yes or no." + ^ (self confirm: aString title: titleString) + ifFalse: [cancelBlock value]; + yourself! - "Put up a yes/no/cancel menu with caption aString, and titleString to label the dialog. - Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. - This is a modal question--the user must respond yes or no." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>request:initialAnswer:centerAt: (in category 'ui requests - text') ----- request: queryString initialAnswer: defaultAnswer centerAt: aPoint + "Create an instance of me whose question is queryString with the given initial answer. Invoke it centered at the given point, and answer the string the user accepts. Answer the empty string if the user cancels." - "Create an instance of me whose question is queryString with the given - initial answer. Invoke it centered at the given point, and answer the - string the user accepts. Answer the empty string if the user cancels." + ^ self request: queryString initialAnswer: defaultAnswer! - ^self subclassResponsibility!

3 3

TranslucentColor for World: Rendering issue
by Thiede, Christoph 19 Sep '20

19 Sep '20

Hi, should it be a valid state for the World (not an arbitrary PasteUpMorph, but one that #isWorldMorph) to have a transparent TranslucentColor? The current implementation does not forbid this. I know this would not make much sense, but I discovered a quite interesting rendering problem: World color: (Color darkGray alpha: 0.2). MagnifierMorph new openInWorld. bg := BackgroundMorph new addMorph: Morph new; position: 200 @ 100; extent: 128 @ 128; "works" openInWorld. Hover the BackgroundMorph, and the magnifier will work as expected. Now do: bg extent: 128 @ 127. "fails" On my machine (SqueakCog, build 15341b5, on Win1903), the magnifier now does not always display the BackgroundMorph but most of the time its background. I can also perceive some flickering, only few frames are rendered correctly. I also tested other ratios, it seems as if the error occurs iff the BackgroundMorph's bounds area (number of pixels) is lower than 2e14. By debugging the number of unique colors in #magnifiedForm|form, I found out that the defect must occur somewhere in Display>>#copy:. Unfortunately, I could not reproduce it by stepping through the code. As said before, I see that a transparent World color is probably useless, but as I do not understand all relevant code entirely, I thought there could be a more general defect somewhere, beyond this situation. tldr: 1. The given code piece produces a failure. Should we forbid transparent World colors? 2. Where does this weird 2e14 limit come from? 3. By the way: For testing, I turned the conditional in #magnifiedForm off, in order to always call PasteUpMorph>>#patchAt:without:andNothingAbove:. The comment indicates that Display>>#copy: would be faster, but I could not measure any difference in performance. Is this conditional still needed? The #patchAt:without:andNothingAbove: variant also seems not to be affected by the described rendering issue. I would be very happy about your reactions :-) Best, Christoph

3 5

The Inbox: Morphic-ct.1540.mcz
by commits＠source.squeak.org 19 Sep '20

19 Sep '20

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1540.mcz ==================== Summary ==================== Name: Morphic-ct.1540 Author: ct Time: 23 September 2019, 4:44:32.818523 pm UUID: 064f7940-90ea-1646-a6f5-6c0a82c06e91 Ancestors: Morphic-mt.1539 Proposal: Remember & explore provenance of any morph. Sure, this is a performance regression (that's why it's turned off by default), but when you are debugging, I could tell you of so many cases in which this can be a useful utility. Looking at #browseCreatorMethod, we can also use this to allow beginners for quickly browsing the <example> method that created a morph. =============== Diff against Morphic-mt.1539 =============== Item was changed: Object subclass: #Morph instanceVariableNames: 'bounds owner submorphs fullBounds color extension' + classVariableNames: 'HaloForAll IndicateKeyboardFocus MetaMenuForAll PreferredCornerRadius RememberProvenance UseSoftDropShadow' - classVariableNames: 'HaloForAll IndicateKeyboardFocus MetaMenuForAll PreferredCornerRadius UseSoftDropShadow' poolDictionaries: '' category: 'Morphic-Kernel'! !Morph commentStamp: 'klc 3/14/2017 11:30' prior: 0! A Morph (from the Greek "shape" or "form") is an interactive graphical object. General information on the Morphic system can be found at http://wiki.squeak.org/squeak/30. Morphs exist in a tree, rooted at a World (generally a PasteUpMorph). The morphs owned by a morph are its submorphs. Morphs are drawn recursively; if a Morph has no owner it never gets drawn. To hide a Morph and its submorphs, set its #visible property to false using the #visible: method. The World (screen) coordinate system is used for most coordinates, but can be changed if there is a TransformMorph somewhere in the owner chain. My instance variables have accessor methods (e.g., #bounds, #bounds:). Most users should use the accessor methods instead of using the instance variables directly. Structure: instance var Type Description bounds Rectangle A Rectangle indicating my position and a size that will enclose me. owner Morph My parent Morph, or nil for the top-level Morph, which is a or nil world, typically a PasteUpMorph. submorphs Array My child Morphs. fullBounds Rectangle A Rectangle minimally enclosing me and my submorphs. color Color My primary color. Subclasses can use this in different ways. extension MorphExtension Allows extra properties to be stored without adding a or nil storage burden to all morphs. By default, Morphs do not position their submorphs. Morphs may position their submorphs directly or use a LayoutPolicy to automatically control their submorph positioning. Although Morph has some support for BorderStyle, most users should use BorderedMorph if they want borders.! Item was added: + ----- Method: Morph class>>rememberProvenance (in category 'preferences') ----- + rememberProvenance + + <preference: 'Remember provenance of each morph' + categoryList: #(Morphic) + description: 'If enabled, each morph will contain a debug item to view its creator stack. This allows you to explore its provenance later. May affect performance.' + type: #Boolean> + ^ RememberProvenance ifNil: [false]! Item was added: + ----- Method: Morph class>>rememberProvenance: (in category 'preferences') ----- + rememberProvenance: aBoolean + + RememberProvenance := aBoolean.! Item was added: + ----- Method: Morph>>browseCreatorMethod (in category 'debug and other') ----- + browseCreatorMethod + + ^ (self valueOfProperty: #officialCreator) browse! Item was changed: ----- Method: Morph>>buildDebugMenu: (in category 'debug and other') ----- buildDebugMenu: aHand "Answer a debugging menu for the receiver. The hand argument is seemingly historical and plays no role presently" | aMenu aPlayer | aMenu := MenuMorph new defaultTarget: self. aMenu addStayUpItem. (self hasProperty: #errorOnDraw) ifTrue: [aMenu add: 'start drawing again' translated action: #resumeAfterDrawError. aMenu addLine]. (self hasProperty: #errorOnStep) ifTrue: [aMenu add: 'start stepping again' translated action: #resumeAfterStepError. aMenu addLine]. aMenu add: 'inspect morph' translated action: #inspectInMorphic:. aMenu add: 'inspect owner chain' translated action: #inspectOwnerChain. Smalltalk isMorphic ifFalse: [aMenu add: 'inspect morph (in MVC)' translated action: #inspect]. self isMorphicModel ifTrue: [aMenu add: 'inspect model' translated target: self model action: #inspect; add: 'explore model' translated target: self model action: #explore]. (aPlayer := self player) ifNotNil: [aMenu add: 'inspect player' translated target: aPlayer action: #inspect]. aMenu add: 'explore morph' translated target: self selector: #exploreInMorphic:. aMenu addLine. aPlayer ifNotNil: [ aMenu add: 'viewer for Player' translated target: self player action: #beViewed. aMenu balloonTextForLastItem: 'Opens a viewer on my Player -- this is the same thing you get if you click on the cyan "View" halo handle' translated ]. aMenu add: 'viewer for Morph' translated target: self action: #viewMorphDirectly. aMenu balloonTextForLastItem: 'Opens a Viewer on this Morph, rather than on its Player' translated. aMenu addLine. aPlayer ifNotNil: [aPlayer class isUniClass ifTrue: [ aMenu add: 'browse player class' translated target: aPlayer selector: #haveFullProtocolBrowsedShowingSelector: argumentList: #(nil)]]. aMenu add: 'browse morph class' translated target: self selector: #browseHierarchy. + self isMorphicModel - (self isMorphicModel) ifTrue: [aMenu add: 'browse model class' target: self model selector: #browseHierarchy]. + (self valueOfProperty: #officialCreator ifAbsent: [nil]) ifNotNil: [ + aMenu add: 'browse creator method' action: #browseCreatorMethod]. + (self hasProperty: #creatorStack) ifTrue: [ + aMenu add: 'explore creator stack' action: #exploreCreatorStack]. aMenu addLine. self addViewingItemsTo: aMenu. aMenu add: 'make own subclass' translated action: #subclassMorph; add: 'save morph in file' translated action: #saveOnFile; addLine; add: 'call #tempCommand' translated action: #tempCommand; add: 'define #tempCommand' translated action: #defineTempCommand; addLine; add: 'control-menu...' translated target: self selector: #invokeMetaMenu:; add: 'edit balloon help' translated action: #editBalloonHelpText. ^ aMenu! Item was added: + ----- Method: Morph>>exploreCreatorStack (in category 'debug and other') ----- + exploreCreatorStack + + ^ (self valueOfProperty: #creatorStack) explore! Item was changed: ----- Method: Morph>>initialize (in category 'initialization') ----- initialize "initialize the state of the receiver" owner := nil. submorphs := Array empty. bounds := self defaultBounds. + color := self defaultColor. + self class rememberProvenance ifTrue: [ + | creatorStack | + creatorStack := thisContext home stack collect: #method. + self setProperty: #creatorStack toValue: creatorStack. + creatorStack + detect: [:method | method hasPragma: #example] + ifFound: [:method | self setProperty: #officialCreator toValue: method]].! - color := self defaultColor!

5 10

The Inbox: Sound-ct.70.mcz
by commits＠source.squeak.org 19 Sep '20

19 Sep '20

A new version of Sound was added to project The Inbox: http://source.squeak.org/inbox/Sound-ct.70.mcz ==================== Summary ==================== Name: Sound-ct.70 Author: ct Time: 1 October 2019, 11:24:29.223339 pm UUID: 2f133210-3aa3-7140-96bf-52dc03b1dea6 Ancestors: Sound-eem.66 Add example "Yesterday" for SampledSound This commit is part of reconstruction of Objectland (also known as "The Worlds of Squeak"). For more information, see: http://forum.world.st/The-Inbox-MorphicExtras-ct-267-mcz-td5104764.html =============== Diff against Sound-eem.66 =============== Item was added: + ----- Method: SampledSound class>>exampleYesterday (in category 'examples') ----- + exampleYesterday + "SampledSound exampleYesterday play" + + ^ SampledSound + samples: (SoundBuffer fromByteArray: (Base64MimeConverter mimeDecodeToBytes: + self yesterdaySamples readStream) contents) + samplingRate: 22050! Item was added: + ----- Method: SampledSound class>>yesterdaySamples (in category 'examples') ----- (excessive size, no diff calculated)

5 6

The Inbox: Graphics-ct.419.mcz
by commits＠source.squeak.org 17 Sep '20

17 Sep '20

A new version of Graphics was added to project The Inbox: http://source.squeak.org/inbox/Graphics-ct.419.mcz ==================== Summary ==================== Name: Graphics-ct.419 Author: ct Time: 20 September 2019, 7:45:53.388726 pm UUID: 5deebfce-0321-9645-aebd-0b4bfb428259 Ancestors: Graphics-nice.417 Add Rectangle>>#pointAtFraction: Example: [(5@5 rect: 10@20) pointAtFraction: 0.5@1] will give you 7.5 @ 20. dep:feat-ol =============== Diff against Graphics-nice.417 =============== Item was added: + ----- Method: Rectangle>>pointAtFraction: (in category 'rectangle functions') ----- + pointAtFraction: relativePoint + + ^ self origin + (self extent * relativePoint)!

4 4

UndeclaredVariable correction raises Error in Parser
by Thiede, Christoph 17 Sep '20

17 Sep '20

Hi all, maybe someone has time and knowledge to fix the following bug? Scenario: Try to compile the following method: foo ba := nil. 42 ifNotNil: [:ba | ba]. Then accept it and answer the UndeclaredVariable dialog with 'declare temp variable'. Expected behavior: The method should be corrected to: foo | ba | ba := nil. 42 ifNotNil: [: "Name already used in this method ->"ba | ba]. Actual behavior: UndeclaredVariableNode>>#sizeCodeForStorePop: is called and raises a #shouldNotImplement. Interpretation: I guess the problem is in #undeclaredTemps, where the encoder does not declare ba which was shadowed by the declaration in the block. How could that be solved? My first approach would be to store all UndeclaredTempVars in #bindUndeclaredTemp: separately, but I'm quite sure this is not efficient ... How would you solve this problem the best way? However, I attached a change set for my attempt, all tests are green. I'm excited to hear your answers! :) Best, Christoph

2 2

[BUG] Text drag and drop to workspace unreliable
by Jakob Reschke 24 Aug '20

24 Aug '20

Hi, I just noticed that the newly introduced text drag and drop sometimes does not work when dragging text between workspaces. It has always worked until today so I suspect the culprit is among the more recent changes. Problem: When dragging the selected text from one workspace to another, sometimes an object reference is copied to the bindings of the workspace instead of pasting the text. In the target text, the newly created variable name appears instead (e. g. text3997962) as if I had dropped another non-text object. At least the text is not removed from the source workspace when this happens... Problem #2: It does not always happen. When dragging from a third workspace it suddenly worked and then also from the second again. Then I reset my texts back to the old state and now it is broken again. Expected behavior: The selected text from the source workspace is cut from there, and pasted at the drop hand location in the target workspace. Currently I have three workspaces #1, #2, #3. If I drag the selection from #1 to #2, it works. If I drag from #1 to #3 it does not. Dragging from #2 to #3 does not work. Dragging from #2 to #1 does work. Now dragging from #1 to #3 suddenly does work... I dragged to the start of the text this time. Dragging back from #3 to #1 works. Dragging from #1 to #3 to the end of it also works. Dragging back from #1 to #3. Resetting (Cmd+l, lowercase L) text of #3. Dragging from #1 to the end of #3 does not work again. Variable pasted at the start of the text. Repeated dragging of the same text from #1 to #3 always pastes the variable. Dragging to the middle of #3 works! Dragging the pasted text inside of #3 to the end removed the text and pasted a variable instead. Hypothesis: it does not work to drop the text beyond the TextMorphForEditView. And so far I might just have been lucky to always have enough blank lines at the end of my target workspace. Workspaces #1 and #2 from above contain much more text than #3 and fill the whole editing area of the workspace, so this would be consistent. Squeak5.3beta latest update: #19300 Kind regards, Jakob

2 3

Support an updated image format number for Sista
by David T. Lewis 19 Jul '20

19 Jul '20

Hi Eliot, This is a belated follow up on earlier private discussion during a Squeak board meeting a few months ago, in which we agreed that identifying "Sista in use" in the image format number would be a useful thing to do. I previously added the documentation for this in ImageFormat-dtl.39.mcz (as well as the updated ckformat.c program to match). Attached here is a change set that can be loaded into a VMMaker image to add VM support for setting and reading the updated image format numbers. Here I used a primitive to initially set or clear the "sista bit". There are other ways this could be done, but this at least gets us started with a working implementation. By way of explanation, I am copying below both the change set preamble and the earlier ImageFormat commit notice: === Change Set: VMM-Sista-bit-dtl Date: 12 January 2020 Author: David T. Lewis Let the image inform the interpreter that alternate bytecodes either are or are not in use, and remember that setting when writing or reading the image format number in a shapshot file header. Provide primitiveMultipleBytecodesActive to allow the setting to be updated from the image. Expected usage is that the image can call this primitive after recompiling with Systa bytecodes, or after reverting back. Note that an alternative implemenation would be to use a VM parameter. The primitive was chosen here because it can perform parameter checking and does not require coordinated update the the VM parameter usage. Expected usage is that this feature will remain unused for some grace period (perhaps a few months) during which an updated VM can be widely circulated. After that period, images using Sista bytecodes may be safely saved with the updated image format number indicating that multiple bytecodes are in use. This change set includes helper methods in SmalltalkImage for testing or setting the multipleBytecodeSetsActive setting in the VM. Note the change set postscript which is necessary for initializing a class variable prior to code generation. === Name: ImageFormat-dtl.37 Author: dtl Time: 20 July 2019, 5:23:59.004 pm UUID: 52b464d5-0bf7-4326-bde3-4f18ad70b239 Ancestors: ImageFormat-dtl.36 Identify extended bytecodes for Sista in the image format number. Bit 10 identifies an image that contains extended bytecodes. Thus a 32 bit Spur image is 6521, with Sista it is 7033, and a 64 bit Spur image is 68021, with Sista it is 68533. It is expected that additional bytecode sets can be identified by an additional field in the image header, probably 32 bits containing two 16 bit fields, if both zero then Sista. Per discussion with Eliot and Bert in a Squeak oversight board meeting 2019-05-15. Dave

1 3

porting Croquet to Squeak6.0 alpha...
by gettimothy 29 May '20

29 May '20

Okey dokey, Poking along, there is a stray glyph in OGLUnix openGLLibraryName after openGLLibraryName ^Smalltalk osVersion = 'linux' ifTrue: ['libGL.so.1'] ifFalse: ['GL'] I removed it in my install and got past that error. Working exclusively with Croquet(Master)... My next error is in OGLUnixX11LE(OpenGL)>>glMatrixMode: glMatrixMode: mode "This method was automatically generated." "void glMatrixMode(GLenum mode);" <apicall: void 'glMatrixMode' (ulong) module: '#openGLLibraryName'> ^self externalCallFailed The <apicall:...> fails How to think about this? Is Croquet behind OpenGL latest? Would teaching myself OpenGL programming be of use to the Croquet project? cheers, tty

6 16

← Newer
1
2
3
4
5
6
7
8
...
32
Older →

Jump to page: