Squeak-dev March 2020

squeak-dev@lists.squeakfoundation.org

38 participants
318 discussions

The Inbox: Morphic-ct.1635.mcz
by commits＠source.squeak.org 02 Mar '20

02 Mar '20

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1635.mcz ==================== Summary ==================== Name: Morphic-ct.1635 Author: ct Time: 29 February 2020, 12:39:08.00383 pm UUID: 1d028c27-ec3c-fd4f-924c-5c0372d0323e Ancestors: Morphic-mt.1631 Proposal: Revive #errorOnStep detection. Introduce #setErrorOnStep to keep it (quite) easy to add non-morphic receivers into the steplist (such as ObjectExplorer). Hm, should we maybe define #setErrorOnStep as a method stub on Object? =============== Diff against Morphic-mt.1631 =============== Item was added: + ----- Method: Morph>>setErrorOnStep (in category 'WiW support') ----- + setErrorOnStep + + self setProperty: #errorOnStep toValue: true.! Item was added: + ----- Method: StepMessage>>value: (in category 'evaluating') ----- + value: anArgument + + ^ [super value: anArgument] + ifCurtailed: [ + (self receiver respondsTo: #setErrorOnStep) + ifTrue: [self receiver setErrorOnStep]]!

3 4

The Inbox: HelpSystem-Core-ct.131.mcz
by commits＠source.squeak.org 02 Mar '20

02 Mar '20

Christoph Thiede uploaded a new version of HelpSystem-Core to project The Inbox: http://source.squeak.org/inbox/HelpSystem-Core-ct.131.mcz ==================== Summary ==================== Name: HelpSystem-Core-ct.131 Author: ct Time: 2 March 2020, 10:56:11.800949 am UUID: 9b0d6d0c-a344-5648-9a03-7ac23afa7515 Ancestors: HelpSystem-Core-mt.119 Proposal: Make HtmlHelpTopic downloads more robust by retrying the download up to three times if the request was not successful. =============== Diff against HelpSystem-Core-mt.119 =============== Item was changed: ----- Method: HtmlHelpTopic>>document (in category 'accessing') ----- document + | retriesRemaining | + document ifNotNil: [^ document]. + retriesRemaining := 3. + ^ document := [ - ^ document ifNil: [document := [ + | response | + response := WebClient new httpGet: self url do: [:req | + req headerAt: 'Accept' put: 'text/html']. + response isSuccess + ifFalse: [self error: #serverError]. + response content + ] on: Error do: [:err | + err messageText = #serverError + ifFalse: [err pass]. + retriesRemaining strictlyPositive + ifFalse: [err ignore] + ifTrue: [ + retriesRemaining := retriesRemaining - 1. + err retry]] + ] on: Error do: [:err | err printString]! - (HTTPSocket httpGet: self url accept: 'text/html') contents - ] on: Error do: [:err | err printString]]!

1 0

The Inbox: HelpSystem-Core-ct.130.mcz
by commits＠source.squeak.org 02 Mar '20

02 Mar '20

Christoph Thiede uploaded a new version of HelpSystem-Core to project The Inbox: http://source.squeak.org/inbox/HelpSystem-Core-ct.130.mcz ==================== Summary ==================== Name: HelpSystem-Core-ct.130 Author: ct Time: 2 March 2020, 10:39:50.205949 am UUID: b3afc4b5-ac91-4042-9f09-5576de307df8 Ancestors: HelpSystem-Core-mt.119 Small refactoring of HtmlHelpTopic (apply Guard Clause idiom and add proper #key implementation) =============== Diff against HelpSystem-Core-mt.119 =============== Item was added: + ----- Method: HtmlHelpTopic>>key (in category 'accessing') ----- + key + + ^ self url! Item was changed: ----- Method: HtmlHelpTopic>>subtopicUrls (in category 'accessing') ----- subtopicUrls + | urls start end endGuard | + subtopicUrls ifNotNil: [^ subtopicUrls]. + + urls := OrderedCollection new. - ^ subtopicUrls ifNil: [ - | start end endGuard | - subtopicUrls := OrderedCollection new. + start := self document findString: '<a '. + start := self document findString: 'href' startingAt: start. + [start > 0] whileTrue: [ + start := self document findString: '"' startingAt: start. + end := self document findString: '"' startingAt: start + 1. + endGuard := self document findString: '>' startingAt: start + 1. + end > 0 ifTrue: [ + end < endGuard ifTrue: [ + | nextUrl | + nextUrl := self document copyFrom: start + 1 to: end - 1. + urls addIfNotPresent: nextUrl]. + start := self document findString: '<a ' startingAt: end + 1]. + start > 0 ifTrue: [start := self document findString: 'href' startingAt: start]]. - start := self document findString: '<a '. - start := self document findString: 'href' startingAt: start. - [start > 0] whileTrue: [ - start := self document findString: '"' startingAt: start. - end := self document findString: '"' startingAt: start+1. - endGuard := self document findString: '>' startingAt: start+1. - end > 0 ifTrue: [ - end < endGuard - ifTrue: [subtopicUrls addIfNotPresent: (self document copyFrom: start+1 to: end-1)]. - start := self document findString: '<a ' startingAt: end+1]. - start > 0 ifTrue: [start := self document findString: 'href' startingAt: start]]. + ^ subtopicUrls := urls + select: self selectBlock + thenCollect: self convertBlock! - subtopicUrls := subtopicUrls - select: self selectBlock - thenCollect: self convertBlock. - subtopicUrls]!

1 0

The Inbox: Help-Squeak-SWiki-ct.3.mcz
by commits＠source.squeak.org 02 Mar '20

02 Mar '20

Christoph Thiede uploaded a new version of Help-Squeak-SWiki to project The Inbox: http://source.squeak.org/inbox/Help-Squeak-SWiki-ct.3.mcz ==================== Summary ==================== Name: Help-Squeak-SWiki-ct.3 Author: ct Time: 2 March 2020, 10:35:15.674949 am UUID: 35ed0b75-38a5-3e4f-8ade-20102ed718eb Ancestors: Help-Squeak-SWiki-mt.2 Complements HelpSystem-Core-ct.129: Specify cleanseBlock for better parsing of the wikis =============== Diff against Help-Squeak-SWiki-mt.2 =============== Item was changed: ----- Method: SWikiHelp class>>asHelpTopic (in category 'converting') ----- asHelpTopic ^ HtmlHelpTopic new url: 'http://wiki.squeak.org/squeak'; + selectBlock: [:url | (url beginsWith: '/squeak/') and: [(url includes: $.) not ".edit, .history, ..."] and: [url last isDigit]]; - selectBlock: [:url | ((url beginsWith: '/squeak/') and: [(url includes: $.) not ".edit, .history, ..."]) and: [url last isDigit]]; convertBlock: [:url | 'http://wiki.squeak.org', url]; + cleanseBlock: [:contents | (contents readStream + upToAll: '<table border=0 cellspacing=0 cellpadding=0 width="100%"'; + upToAll: '</table>'; + upToEnd) ifEmpty: [contents]] yourself!

1 0

The Inbox: Morphic-ct.1633.mcz
by commits＠source.squeak.org 02 Mar '20

02 Mar '20

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1633.mcz ==================== Summary ==================== Name: Morphic-ct.1633 Author: ct Time: 29 February 2020, 11:33:45.993896 am UUID: f258f893-f17e-f245-af98-b875a4701f7e Ancestors: Morphic-mt.1631 Fixes MorphicHierarchy, which was broken because #world is nil before opening the list in the world. =============== Diff against Morphic-mt.1631 =============== Item was changed: ----- Method: MorphHierarchyListMorph>>createContainer (in category 'private') ----- createContainer "Private - Create a container" | container | container := BorderedMorph new. + container extent: (self currentWorld extent * (1 / 4 @ (2 / 3))) rounded. - container extent: (self world extent * (1 / 4 @ (2 / 3))) rounded. container layoutPolicy: TableLayout new. container hResizing: #rigid. container vResizing: #rigid. container color: (Color gray: 0.9); borderWidth: 1; borderColor: Color gray. container layoutInset: 0. "container useRoundedCorners." "" container setProperty: #morphHierarchy toValue: true. container setNameTo: 'Objects Hierarchy' translated. "" ^ container!

2 1

The Inbox: HelpSystem-Core-ct.129.mcz
by commits＠source.squeak.org 02 Mar '20

02 Mar '20

Christoph Thiede uploaded a new version of HelpSystem-Core to project The Inbox: http://source.squeak.org/inbox/HelpSystem-Core-ct.129.mcz ==================== Summary ==================== Name: HelpSystem-Core-ct.129 Author: ct Time: 2 March 2020, 10:32:56.341949 am UUID: 65f1da58-ae12-c14a-a12c-bc9a3b7a08b3 Ancestors: HelpSystem-Core-mt.119 Improves parsing of html help topics - Detect relative links and convert them to absolute version - Add support for a cleanseBlock that will be applied to the html body source - Trim leading and trailing blanks from the text - Cache contents Small refactoring: - Remove unnecessary duplicate parse logic from #subtopics - Again in #subtopics, don't pass the result of [self fooBlock] but the instance variable fooBlock instead. Don't manifest default values ... =============== Diff against HelpSystem-Core-mt.119 =============== Item was changed: AbstractHelpTopic subclass: #HtmlHelpTopic + instanceVariableNames: 'url level selectBlock convertBlock cleanseBlock document contents subtopicUrls subtopics' - instanceVariableNames: 'url document selectBlock convertBlock subtopicUrls subtopics level' classVariableNames: '' poolDictionaries: '' category: 'HelpSystem-Core-Model'! Item was added: + ----- Method: HtmlHelpTopic>>cleanseBlock (in category 'accessing') ----- + cleanseBlock + "Answer the block that will be applied to the HTML body source in order to filter relevant information." + + ^ cleanseBlock ifNil: [ [:contents | contents] ]! Item was added: + ----- Method: HtmlHelpTopic>>cleanseBlock: (in category 'accessing') ----- + cleanseBlock: aBlock + "Indicate the block that will be applied to the HTML body source in order to filter relevant information." + + cleanseBlock := aBlock.! Item was changed: ----- Method: HtmlHelpTopic>>contents (in category 'accessing') ----- contents + | start end source text rootUrl | + contents ifNotNil: [^ contents]. + + start := self document findString: '<body'. - | start end | - start := (self document findString: '<body'). start := (self document findString: '>' startingAt: start) + 1. end := self document findString: '</body>' startingAt: start. start > end ifTrue: [^ self document]. + source := self document copyFrom: start to: end - 1. + source := self cleanseBlock value: source. + text := (source copyReplaceAll: String cr with: '<br>') + asTextFromHtml. + + "Convert relative URLs (https://www.w3.org/TR/WD-html40-970917/htmlweb.html#h-5.1.2)" + rootUrl := url readStream in: [:urlStream | + | host scheme | + scheme := urlStream upToAll: '://'. + host := urlStream upTo: $/. + scheme , '://' , host]. + (text runs gather: #yourself) withoutDuplicates + select: [:attribute | attribute isKindOf: TextURL] + thenDo: [:attribute | + (attribute info beginsWith: '..') + ifTrue: [attribute url: self url , (attribute info skip: 2)]. + (attribute info beginsWith: '/') + ifTrue: [attribute url: rootUrl , attribute info]]. + + ^ contents := text withBlanksTrimmed! - ^ ((self document copyFrom: start to: end - 1) - copyReplaceAll: String cr with: '<br>') - asTextFromHtml! Item was changed: ----- Method: HtmlHelpTopic>>subtopics (in category 'accessing') ----- subtopics - | start end urls | subtopics ifNotNil: [^ subtopics]. - urls := OrderedCollection new. - - start := self document findString: '<a '. - [start > 0] whileTrue: [ - start := self document findString: 'href' startingAt: start. - start := (self document findString: '"' startingAt: start) + 1. - end := self document findString: '"' startingAt: start. - urls addIfNotPresent: (self document copyFrom: start to: end - 1). - start := self document findString: '<a ' startingAt: start.]. - subtopics := (self subtopicUrls collect: [:aUrl | self class new level: self level + 1; url: aUrl; + selectBlock: selectBlock; + convertBlock: convertBlock; + cleanseBlock: cleanseBlock]). - selectBlock: self selectBlock; - convertBlock: self convertBlock]). Project current uiProcess == Processor activeProcess ifTrue: [self fetchSubtopics]. ^ subtopics!

1 0

Separation of domain from UI in Squeak (was: 5.3 cannot rename subclasses of Error)
by Chris Muller 02 Mar '20

02 Mar '20

Hi Marcel, > especially for this one tiny little thing of a modal alert when renaming > classes? > > It is a more general issue. There should be no UI invocation code in a > non-UI part of the system. So, "Transcript showln:." is fine but "self > inform:" is not. Why? Because those cannot be trapped in scripts, which is > - for example - unfortunate in automated pipelines such as our CI. > Actually, they can. "example 1" [ self inform: 'stop everything and pay attention to me!' ] on: ProvideAnswerNotification do: [ : noti | noti resume ] "nil" "example 2" [UIManager default request: 'what is the answer?' initialAnswer: 'tell me now!' ] on: ProvideAnswerNotification do: [ : noti | noti resume: 42 ] "42 " I assumed this is what the CI jobs were doing.. they're not? I totally share your sentiments about no UI invocation code in the domain, and is how I do my own designs, of course, but Squeak chose default to being an <<interactive system>>, and requires handlers of ProvideAnswerNotification to make it non-interactive, rather than the other way around. If you want to flip the above in 5.4 to the normal way -- signaling a kind of ProvideAnswerNotification whose defaultAction issues the modal popup -- then let's flip them, but it doesn't seem like we need a new layer of notification classes just yet. ProvideAnswerNotification may be sufficient. Best, Chris > > > What happened to simply opening up a MessageSet on the references > afterward? > > Still there. Unrelated to this issue. See the end of Browser >> > #renameClass. > > > Say, why do we need a modal alert at all? > > I agree, that extra check in Class >> #rename: might not be necessary and > maybe moved to our refactoring tools. > > Best, > Marcel > > Am 26.02.2020 00:21:48 schrieb Chris Muller <asqueaker(a)gmail.com>: > -1. "Notice" is such a generic, common word to steal from all > applications that might want to create their own, especially for this one > tiny little thing of a modal alert when renaming classes? Say, why do we > need a modal alert at all? What happened to simply opening up a MessageSet > on the references afterward? > > - Chris > > > > > > On Tue, Feb 25, 2020 at 8:17 AM Marcel Taeumel <marcel.taeumel(a)hpi.de> > wrote: > >> Just "Notice"? >> >> Am 25.02.2020 12:11:33 schrieb Eliot Miranda <eliot.miranda(a)gmail.com>: >> >> >> On Feb 25, 2020, at 1:40 AM, Marcel Taeumel <marcel.taeumel(a)hpi.de> >> wrote: >> >> >> Fixed. BUT: Please take a look at >> >> Kernel-mt.1305 >> Tools-mt.941 >> >> We need a name! :-) >> >> >> On second thoughts Notice might be a better name. >> >> >> Best, >> Marcel >> >> Am 25.02.2020 10:11:22 schrieb Marcel Taeumel <marcel.taeumel(a)hpi.de>: >> > Maybe it is a sporadic issue? >> >> It is! Related to the ProgressNotification which I accidentially catch in >> Browser >> #renameClass. I wanted to get the UI call out of Class >> >> #rename:. >> >> That progress notification does not appear every time. Only above a >> certain threshold. That's why it appears to be sporadic. >> >> Best, >> Marcel >> >> Am 25.02.2020 09:37:13 schrieb Thiede, Christoph < >> christoph.thiede(a)student.hpi.uni-potsdam.de>: >> >> I could reproduce it one single time ... Maybe it is a sporadic issue? >> >> >> Best, >> >> Christoph >> <http://www.hpi.de/> >> ------------------------------ >> *Von:* Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org> im >> Auftrag von Taeumel, Marcel >> *Gesendet:* Dienstag, 25. Februar 2020 09:34:03 >> *An:* John Pfersich via Squeak-dev; Chris Muller >> *Betreff:* Re: [squeak-dev] 5.3 cannot rename subclasses of Error >> >> Hmm... I can reproduce the bug. Yet, calling "Error2 rename: #Error1" >> from a workspace works fine. Strange. >> >> Best, >> Marcel >> >> Am 25.02.2020 09:16:13 schrieb Thiede, Christoph < >> christoph.thiede(a)student.hpi.uni-potsdam.de>: >> >> Hi Chris, >> >> >> in a fresh image, I cannot reproduce this. Are you sure the class has not >> been renamed or is it possible that the class list was not updated properly? >> >> >> Best, >> >> Christoph >> <http://www.hpi.de/> >> ------------------------------ >> *Von:* Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org> im >> Auftrag von Chris Muller <asqueaker(a)gmail.com> >> *Gesendet:* Dienstag, 25. Februar 2020 06:29:00 >> *An:* squeak dev >> *Betreff:* [squeak-dev] 5.3 cannot rename subclasses of Error >> >> In trunk / 5.3 RC. >> >> - Make a subclass of Error called MyError1 >> - Make a subclass of Error called MyError2 >> - Delete MyError1 >> - Try to rename MyError2 to MyError1 >> >> The last step fails. No errors or debuggers, but the class is not >> renamed. >> >> Works in 5.2. >> >> >> >> >

5 7

The Inbox: Tools-kks.943.mcz
by commits＠source.squeak.org 01 Mar '20

01 Mar '20

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-kks.943.mcz ==================== Summary ==================== Name: Tools-kks.943 Author: kks Time: 1 March 2020, 5:31:21.925863 pm UUID: 669645d6-dd0d-4904-91c6-a9d539751f95 Ancestors: Tools-mt.942 Browser printOut was writing chunk format into an html file making it unreadable. It now opens a help topic instead which is more useful. Perhaps, the menu item needs to be renamed to 'Help'. =============== Diff against Tools-mt.942 =============== Item was changed: ----- Method: Browser>>printOutClass (in category 'class functions') ----- printOutClass + "Print class comments and methods into a hyperlinked text topic and open it in Help Browser" - "Print a description of the selected class onto a file whose name is the - category name followed by .html." Cursor write showWhile: + [self hasClassSelected ifTrue: [HelpBrowser openOn: self selectedClass asHelpTopic ]]! - [self hasClassSelected ifTrue: [self selectedClass fileOutAsHtml: true]]!

1 0

Jump to page: