Squeak-dev March 2020

squeak-dev@lists.squeakfoundation.org

38 participants
318 discussions

The Trunk: Morphic-nice.1625.mcz
by commits＠source.squeak.org 03 Mar '20

03 Mar '20

Nicolas Cellier uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-nice.1625.mcz ==================== Summary ==================== Name: Morphic-nice.1625 Author: nice Time: 17 February 2020, 5:06:10.606532 pm UUID: 094e2566-ddfe-2340-8fab-2338d255e164 Ancestors: Morphic-mt.1624 Free our mind from un-initialized LayoutFrame. There should not be any such thing. Require Graphics-nice.425 =============== Diff against Morphic-mt.1624 =============== Item was changed: ----- Method: BorderedMorph>>addMorph:fullFrame: (in category 'resize handling') ----- addMorph: aMorph fullFrame: aLayoutFrame "Add aMorph according to aLayoutFrame." self cellGap > 0 ifTrue: [ | left right bottom top spacing | spacing := self cellGap. + left := aLayoutFrame leftOffset. + right := aLayoutFrame rightOffset. - left := aLayoutFrame leftOffset ifNil: [0]. - right := aLayoutFrame rightOffset ifNil: [0]. + bottom := aLayoutFrame bottomOffset. + top := aLayoutFrame topOffset. - bottom := aLayoutFrame bottomOffset ifNil: [0]. - top := aLayoutFrame topOffset ifNil: [0]. "Add a spacing to the frame if it is not top or leftmost." aLayoutFrame leftFraction = 0 ifFalse: [left := left + spacing] ifTrue: [ "Expect another, resizable widget besides me if I have a fixed width." aLayoutFrame hasFixedWidth ifTrue: [right := right - spacing]]. aLayoutFrame topFraction = 0 ifFalse: [top := top + spacing] ifTrue: [ "Expect another, resizable widget besides me if I have a fixed height." aLayoutFrame hasFixedHeight ifTrue: [bottom := bottom - spacing]]. aLayoutFrame topOffset: top; bottomOffset: bottom; leftOffset: left; rightOffset: right]. super addMorph: aMorph fullFrame: aLayoutFrame. self wantsPaneSplitters ifTrue: [self addPaneSplitters].! Item was changed: ----- Method: BorderedMorph>>addPaneHSplitterAtBottomOfRow: (in category 'resize handling') ----- addPaneHSplitterAtBottomOfRow: someMorphs | targetY minX maxX splitter | targetY := someMorphs first layoutFrame bottomFraction. minX := (someMorphs detectMin: [:each | each layoutFrame leftFraction]) layoutFrame leftFraction. maxX := (someMorphs detectMax: [:each | each layoutFrame rightFraction]) layoutFrame rightFraction. splitter := ProportionalSplitterMorph new beSplitsTopAndBottom; yourself. splitter layoutFrame: (LayoutFrame fractions: (minX @ targetY corner: maxX @ targetY) + offsets: (someMorphs first layoutFrame leftOffset @ 0 + corner: someMorphs first layoutFrame rightOffset @ AbstractResizerMorph gripThickness)). - offsets: ((someMorphs first layoutFrame leftOffset ifNil: [0]) @ 0 - corner: (someMorphs first layoutFrame rightOffset ifNil: [0]) @ AbstractResizerMorph gripThickness)). self addMorphBack: (splitter position: self position).! Item was changed: ----- Method: BorderedMorph>>addPaneVSplitterAtRightOfColumn: (in category 'resize handling') ----- addPaneVSplitterAtRightOfColumn: someMorphs | targetX minY maxY splitter | targetX := someMorphs first layoutFrame rightFraction. minY := (someMorphs detectMin: [:each | each layoutFrame topFraction]) layoutFrame topFraction. maxY := (someMorphs detectMax: [:each | each layoutFrame bottomFraction]) layoutFrame bottomFraction. splitter := ProportionalSplitterMorph new beSplitsLeftAndRight; yourself. splitter layoutFrame: (LayoutFrame fractions: (targetX @ minY corner: targetX @ maxY) + offsets: (0 @ (someMorphs first layoutFrame topOffset) + corner: (AbstractResizerMorph gripThickness@ (someMorphs first layoutFrame bottomOffset)))). - offsets: (0 @ (someMorphs first layoutFrame topOffset ifNil: [0]) - corner: (AbstractResizerMorph gripThickness@ (someMorphs first layoutFrame bottomOffset ifNil: [0])))). self addMorphBack: (splitter position: self position).! Item was changed: ----- Method: BorderedMorph>>linkSubmorphsToSplitters (in category 'resize handling') ----- linkSubmorphsToSplitters self splitters do: [:splitter | splitter splitsTopAndBottom ifTrue: [ self submorphsDo: [:morph | ((morph ~= splitter and: [morph layoutFrame bottomFraction = splitter layoutFrame topFraction]) and: [morph layoutFrame hasFixedHeight not + or: [(morph layoutFrame topOffset) < 0]]) - or: [(morph layoutFrame topOffset ifNil: [0]) < 0]]) ifTrue: [splitter addLeftOrTop: morph]. ((morph ~= splitter and: [morph layoutFrame topFraction = splitter layoutFrame bottomFraction]) and: [morph layoutFrame hasFixedHeight not + or: [(morph layoutFrame bottomOffset) > 0]]) - or: [(morph layoutFrame bottomOffset ifNil: [0]) > 0]]) ifTrue: [splitter addRightOrBottom: morph]]]. splitter splitsLeftAndRight ifTrue: [ self submorphsDo: [:morph | ((morph ~= splitter and: [morph layoutFrame rightFraction = splitter layoutFrame leftFraction]) and: [morph layoutFrame hasFixedWidth not + or: [(morph layoutFrame leftOffset) < 0]]) - or: [(morph layoutFrame leftOffset ifNil: [0]) < 0]]) ifTrue: [splitter addLeftOrTop: morph]. ((morph ~= splitter and: [morph layoutFrame leftFraction = splitter layoutFrame rightFraction]) and: [morph layoutFrame hasFixedWidth not + or: [(morph layoutFrame rightOffset) > 0]]) - or: [(morph layoutFrame rightOffset ifNil: [0]) > 0]]) ifTrue: [splitter addRightOrBottom: morph]]]]! Item was changed: ----- Method: ProportionalSplitterMorph>>balanceOffsets (in category 'events') ----- balanceOffsets | fdx fdy | (self hasProperty: #fullDelta) ifFalse: [^ self]. fdx := (self valueOfProperty: #fullDelta) x. fdy := (self valueOfProperty: #fullDelta) y. self layoutFrame hasFixedHeight ifTrue: [ | otop obot ctop cbot topf | otop := (owner submorphs detect: [:m | m layoutFrame topFraction isZero] ifNone: [^ self]) in: [:tm | + tm top - (tm layoutFrame topOffset)]. - tm top - (tm layoutFrame topOffset ifNil: [0])]. obot := (owner submorphs detect: [:m | m layoutFrame bottomFraction = 1] ifNone: [^ self]) in: [:tm | + tm bottom - (tm layoutFrame bottomOffset)]. - tm bottom - (tm layoutFrame bottomOffset ifNil: [0])]. ctop := (self layoutFrame topFraction * (obot - otop)) rounded + + otop + (self layoutFrame topOffset). - + otop + (self layoutFrame topOffset ifNil: [0]). cbot := (self layoutFrame bottomFraction * (obot - otop)) rounded + + otop + (self layoutFrame bottomOffset). - + otop + (self layoutFrame bottomOffset ifNil: [0]). topf := self layoutFrame topFraction. self layoutFrame topFraction: ((ctop + cbot) * 0.5 - otop) / (obot - otop) asFloat. self layoutFrame bottomFraction: self layoutFrame topFraction. self layoutFrame topOffset: self layoutFrame topOffset - fdy. self layoutFrame bottomOffset: self layoutFrame bottomOffset - fdy. (leftOrTop copy union: rightOrBottom) do: [:m | (m layoutFrame topFraction closeTo: topf) ifTrue: [ m layoutFrame topFraction: self layoutFrame topFraction. m layoutFrame topOffset: m layoutFrame topOffset - fdy]. (m layoutFrame bottomFraction closeTo: topf) ifTrue: [ m layoutFrame bottomFraction: self layoutFrame topFraction. m layoutFrame bottomOffset: m layoutFrame bottomOffset - fdy]]] . self layoutFrame hasFixedWidth ifTrue: [ | oleft oright cleft cright leftf | oleft := (owner submorphs detect: [:m | m layoutFrame leftFraction isZero] ifNone: [^ self]) in: [:tm | + tm left - (tm layoutFrame leftOffset)]. - tm left - (tm layoutFrame leftOffset ifNil: [0])]. oright := (owner submorphs detect: [:m | m layoutFrame rightFraction = 1] ifNone: [^ self]) in: [:tm | + tm right - (tm layoutFrame rightOffset)]. - tm right - (tm layoutFrame rightOffset ifNil: [0])]. cleft := (self layoutFrame leftFraction * (oright - oleft)) rounded + + oleft + (self layoutFrame leftOffset). - + oleft + (self layoutFrame leftOffset ifNil: [0]). cright := (self layoutFrame rightFraction * (oright - oleft)) rounded + + oleft + (self layoutFrame rightOffset). - + oleft + (self layoutFrame rightOffset ifNil: [0]). leftf := self layoutFrame leftFraction. self layoutFrame leftFraction: ((cleft + cright) * 0.5 - oleft) / (oright - oleft) asFloat. self layoutFrame rightFraction: self layoutFrame leftFraction. self layoutFrame leftOffset: self layoutFrame leftOffset - fdx. self layoutFrame rightOffset: self layoutFrame rightOffset - fdx. (leftOrTop copy union: rightOrBottom) do: [:m | (m layoutFrame leftFraction closeTo: leftf) ifTrue: [ m layoutFrame leftFraction: self layoutFrame leftFraction. m layoutFrame leftOffset: m layoutFrame leftOffset - fdx]. (m layoutFrame rightFraction closeTo: leftf) ifTrue: [ m layoutFrame rightFraction: self layoutFrame leftFraction. m layoutFrame rightOffset: m layoutFrame rightOffset - fdx.]]] . self removeProperty: #fullDelta. owner layoutChanged ! Item was changed: ----- Method: ProportionalSplitterMorph>>repositionBy: (in category 'events') ----- repositionBy: delta | selfTop selfBottom selfLeft selfRight | self setProperty: #fullDelta toValue: ((self valueOfProperty: #fullDelta) ifNil: [0@0]) + delta. leftOrTop do: [ : each | | firstRight firstBottom firstLeft firstTop | + firstRight := each layoutFrame rightOffset. + firstBottom := each layoutFrame bottomOffset. - firstRight := each layoutFrame rightOffset ifNil: [ 0 ]. - firstBottom := each layoutFrame bottomOffset ifNil: [ 0 ]. each layoutFrame rightOffset: firstRight + delta x. each layoutFrame bottomOffset: firstBottom + delta y. each layoutFrame hasFixedHeight ifTrue: [ + firstTop := each layoutFrame topOffset. - firstTop := each layoutFrame topOffset ifNil: [ 0 ]. each layoutFrame topOffset: firstTop + delta y ]. each layoutFrame hasFixedWidth ifTrue: [ + firstLeft := each layoutFrame leftOffset. - firstLeft := each layoutFrame leftOffset ifNil: [ 0 ]. each layoutFrame leftOffset: firstLeft + delta x. ] ]. rightOrBottom do: [ : each | | secondLeft secondTop secondRight secondBottom | + secondLeft := each layoutFrame leftOffset. + secondTop := each layoutFrame topOffset. - secondLeft := each layoutFrame leftOffset ifNil: [ 0 ]. - secondTop := each layoutFrame topOffset ifNil: [ 0 ]. each layoutFrame leftOffset: secondLeft + delta x. each layoutFrame topOffset: secondTop + delta y. each layoutFrame hasFixedHeight ifTrue: [ + secondBottom := each layoutFrame bottomOffset. - secondBottom := each layoutFrame bottomOffset ifNil: [ 0 ]. each layoutFrame bottomOffset: secondBottom + delta y. ]. each layoutFrame hasFixedWidth ifTrue: [ + secondRight := each layoutFrame rightOffset. - secondRight := each layoutFrame rightOffset ifNil: [ 0 ]. each layoutFrame rightOffset: secondRight + delta x. ] ]. + selfTop := self layoutFrame topOffset. + selfBottom := self layoutFrame bottomOffset. + selfLeft := self layoutFrame leftOffset. + selfRight := self layoutFrame rightOffset. - selfTop := self layoutFrame topOffset ifNil: [ 0 ]. - selfBottom := self layoutFrame bottomOffset ifNil: [ 0 ]. - selfLeft := self layoutFrame leftOffset ifNil: [ 0 ]. - selfRight := self layoutFrame rightOffset ifNil: [ 0 ]. self layoutFrame topOffset: selfTop + delta y ; bottomOffset: selfBottom + delta y ; leftOffset: selfLeft + delta x ; rightOffset: selfRight + delta x. self owner layoutChanged. self movements removeFirst; add: (splitsTopAndBottom ifTrue: [ delta y sign ] ifFalse: [ delta x sign ])! Item was changed: ----- Method: SystemWindow>>convertAlignment (in category 'layout') ----- convertAlignment "Primarily Jesse Welton's code to convert old system windows to ones with modern layout scheme" self layoutPolicy: ProportionalLayout new. (paneMorphs isNil or: [paneRects isNil or: [paneMorphs size ~= paneRects size]]) ifFalse: [self addLabelArea. self putLabelItemsInLabelArea. self setFramesForLabelArea. paneMorphs with: paneRects do: [:m :r | | frame | frame := LayoutFrame new. frame leftFraction: r left; rightFraction: r right; topFraction: r top; bottomFraction: r bottom. m layoutFrame: frame. m hResizing: #spaceFill; vResizing: #spaceFill]]. labelArea isNil ifTrue: [self addLabelArea. self putLabelItemsInLabelArea. self setFramesForLabelArea. paneMorphs ifNotNil: [paneMorphs do: [:m | | frame | frame := m layoutFrame ifNil: [LayoutFrame new]. + frame topOffset: (frame topOffset) - self labelHeight. - frame topOffset: (frame topOffset ifNil: [0]) - self labelHeight. frame bottomFraction ~= 1.0 ifTrue: + [frame bottomOffset: (frame bottomOffset) - self labelHeight]]]]. - [frame bottomOffset: (frame bottomOffset ifNil: [0]) - self labelHeight]]]]. label ifNotNil: [| frame | frame := LayoutFrame new. frame leftFraction: 0.5; topFraction: 0; leftOffset: label width negated // 2. label layoutFrame: frame]. collapseBox ifNotNil: [| frame | frame := LayoutFrame new. frame rightFraction: 1; topFraction: 0; rightOffset: -1; topOffset: 1. collapseBox layoutFrame: frame]. stripes ifNotNil: [| frame | frame := LayoutFrame new. frame leftFraction: 0; topFraction: 0; rightFraction: 1; leftOffset: 1; topOffset: 1; rightOffset: -1. stripes first layoutFrame: frame. stripes first height: self labelHeight - 2. stripes first hResizing: #spaceFill. frame := LayoutFrame new. frame leftFraction: 0; topFraction: 0; rightFraction: 1; leftOffset: 3; topOffset: 3; rightOffset: -3. stripes last layoutFrame: frame. stripes last height: self labelHeight - 6. stripes last hResizing: #spaceFill]. menuBox ifNotNil: [| frame | frame := LayoutFrame new. frame leftFraction: 0; leftOffset: 19; topFraction: 0; topOffset: 1. menuBox layoutFrame: frame]. closeBox ifNotNil: [| frame | frame := LayoutFrame new. frame leftFraction: 0; leftOffset: 4; topFraction: 0; topOffset: 1. closeBox layoutFrame: frame]! Item was changed: ----- Method: SystemWindow>>setPaneRectsFromBounds (in category 'geometry') ----- setPaneRectsFromBounds "Reset proportional specs from actual bounds, eg, after reframing panes" | layoutBounds | layoutBounds := self layoutBounds. paneMorphs do:[:m| | box left bottom top frame right | frame := m layoutFrame. box := m bounds. frame ifNotNil:[ + left := box left - layoutBounds left - frame leftOffset. + right := box right - layoutBounds left - frame rightOffset. + top := box top - layoutBounds top - frame topOffset. + bottom := box bottom - layoutBounds top - frame bottomOffset. - left := box left - layoutBounds left - (frame leftOffset ifNil:[0]). - right := box right - layoutBounds left - (frame rightOffset ifNil:[0]). - top := box top - layoutBounds top - (frame topOffset ifNil:[0]). - bottom := box bottom - layoutBounds top - (frame bottomOffset ifNil:[0]). frame leftFraction: (left / layoutBounds width asFloat). frame rightFraction: (right / layoutBounds width asFloat). frame topFraction: (top / layoutBounds height asFloat). frame bottomFraction: (bottom / layoutBounds height asFloat). ]. ].!

1 0

The Trunk: Graphics-nice.429.mcz
by commits＠source.squeak.org 03 Mar '20

03 Mar '20

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.429.mcz ==================== Summary ==================== Name: Graphics-nice.429 Author: nice Time: 3 March 2020, 10:13:13.903846 pm UUID: a105e385-79ed-4ae5-8216-31282d6beb71 Ancestors: Graphics-nice.428, Graphics-ct.411 Merge Graphics-ct.411 We can now specify LayoutFrame fullFrame =============== Diff against Graphics-nice.428 =============== Item was added: + ----- Method: LayoutFrame class>>fullFrame (in category 'instance creation') ----- + fullFrame + + ^ self fractions: (0 @ 0 corner: 1 @ 1)!

1 0

The Trunk: Graphics-nice.428.mcz
by commits＠source.squeak.org 03 Mar '20

03 Mar '20

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.428.mcz ==================== Summary ==================== Name: Graphics-nice.428 Author: nice Time: 3 March 2020, 10:11:33.559746 pm UUID: b9310c73-f7b2-43d3-b457-16b9d8b0b0dc Ancestors: Graphics-nice.427 Really expunge ifNil: guards from LayoutFrame We can now do it, because we provided proper fixup for upgrading existing instances in previous commit/update map. Note: explicit the layout constraints that we want to respect when calculating #minWidthFrom: and #minHeightFrom: See how we can do it without having to revert to right or bottom fraction = 1. Those methods are unused in trunk image, but might be in additional packages, if you depend on it, please test it. =============== Diff against Graphics-nice.427 =============== Item was changed: ----- Method: LayoutFrame>>layout:in: (in category 'layout') ----- layout: oldBounds in: newBounds "Return the proportional rectangle insetting the given bounds" + | left right top bottom | + left := newBounds left + (newBounds width * leftFraction). + left := left + leftOffset. + right := newBounds right - (newBounds width * (1.0 - rightFraction)). + right := right + rightOffset. + top := newBounds top + (newBounds height * topFraction). + top := top + topOffset. + bottom := newBounds bottom - (newBounds height * (1.0 - bottomFraction)). + bottom := bottom + bottomOffset. - | left right top bottom | - leftFraction ifNotNil:[ - left := newBounds left + (newBounds width * leftFraction). - leftOffset ifNotNil:[left := left + leftOffset]]. - rightFraction ifNotNil:[ - right := newBounds right - (newBounds width * (1.0 - rightFraction)). - rightOffset ifNotNil:[right := right + rightOffset]]. - topFraction ifNotNil:[ - top := newBounds top + (newBounds height * topFraction). - topOffset ifNotNil:[top := top + topOffset]]. - bottomFraction ifNotNil:[ - bottom := newBounds bottom - (newBounds height * (1.0 - bottomFraction)). - bottomOffset ifNotNil:[bottom := bottom + bottomOffset]]. - left ifNil:[ right - ifNil:[left := oldBounds left. right := oldBounds right] - ifNotNil:[left := right - oldBounds width]]. - right ifNil:[right := left + oldBounds width]. - top ifNil:[ bottom - ifNil:[top := oldBounds top. bottom := oldBounds bottom] - ifNotNil:[top := bottom - oldBounds height]]. - bottom ifNil:[bottom := top + oldBounds height]. ^(left rounded @ top rounded) corner: (right rounded @ bottom rounded)! Item was changed: ----- Method: LayoutFrame>>minHeightFrom: (in category 'layout') ----- minHeightFrom: minHeight + "Return the minimal height the given bounds can be represented in + we have: + top = (height * topFraction + topOffset) + bottom = (height * bottomFraction + bottomOffset) + we want to fullfill those constraints if possible: + 0 <= top <= height + 0 <= bottom <= heigth + bottom - top >= minHeight" + | height | + height := bottomFraction = topFraction - "Return the minimal extent the given bounds can be represented in" - | height top bottom | - top := topFraction ifNil: [0.0]. - bottom := bottomFraction ifNil: [1.0]. - height := bottom = top ifTrue: [0] + ifFalse: [minHeight + topOffset - bottomOffset / (bottomFraction - topFraction) max: 0]. + topFraction < 1 ifTrue: [height := height max: topOffset / (1 - topFraction)]. + bottomFraction < 1 ifTrue: [height := height max: bottomOffset / (1 - bottomFraction)]. + topFraction > 0 ifTrue: [height := height max: topOffset negated / topFraction]. + bottomFraction > 0 ifTrue: [height := height max: bottomOffset negated / bottomFraction]. - ifFalse: [minHeight / (bottom - top)]. - topOffset ifNotNil:[height := height + topOffset]. - bottomOffset ifNotNil:[height := height + bottomOffset]. ^ height truncated! Item was changed: ----- Method: LayoutFrame>>minWidthFrom: (in category 'layout') ----- minWidthFrom: minWidth + "Return the minimal width the given bounds can be represented in + we have: + left = (width * leftFraction + leftOffset) + right = (width * rightFraction + rightOffset) + we want to fullfill those constraints if possible: + 0 <= left <= width + 0 <= right <= heigth + right - left >= minwidth" + | width | + width := rightFraction = leftFraction - "Return the minimal extent the given bounds can be represented in" - | width left right | - left := leftFraction ifNil: [0.0]. - right := rightFraction ifNil: [1.0]. - width := left = right ifTrue: [0] + ifFalse: [minWidth + leftOffset - rightOffset / (rightFraction - leftFraction) max: 0]. + leftFraction < 1 ifTrue: [width := width max: leftOffset / (1 - leftFraction)]. + rightFraction < 1 ifTrue: [width := width max: rightOffset / (1 - rightFraction)]. + leftFraction > 0 ifTrue: [width := width max: leftOffset negated / leftFraction]. + rightFraction > 0 ifTrue: [width := width max: rightOffset negated / rightFraction]. + ^ width truncated! - ifFalse: [minWidth / (right - left)]. - leftOffset ifNotNil:[width := width + leftOffset]. - rightOffset ifNotNil:[width := width + rightOffset]. - ^width truncated! Item was changed: ----- Method: LayoutFrame>>printOn: (in category 'printing') ----- printOn: aStream super printOn: aStream. aStream nextPutAll: '( '. { {'l'. self leftFraction. self leftOffset}. {'t'. self topFraction. self topOffset}. {'r'. self rightFraction. self rightOffset}. {'b'. self bottomFraction. self bottomOffset} } do: [:spec | aStream nextPutAll: spec first; space. + spec second printOn: aStream maxDecimalPlaces: 2. - (spec second ifNil: [0]) printOn: aStream maxDecimalPlaces: 2. + aStream nextPutAll: (spec third >= 0 ifTrue: ['+'] ifFalse: ['-']). + spec third abs printOn: aStream maxDecimalPlaces: 0] - aStream nextPutAll: ((spec third ifNil: [0]) >= 0 ifTrue: ['+'] ifFalse: ['-']). - (spec third ifNil: [0]) abs printOn: aStream maxDecimalPlaces: 0] separatedBy: [aStream space]. aStream nextPutAll: ' )'.!

1 0

The Trunk: Graphics-nice.427.mcz
by commits＠source.squeak.org 03 Mar '20

03 Mar '20

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.427.mcz ==================== Summary ==================== Name: Graphics-nice.427 Author: nice Time: 3 March 2020, 9:47:31.024562 pm UUID: 3360bf54-2add-4383-befa-e1aa8863d7fe Ancestors: Graphics-mt.426 Let's initialize all LayoutFrame inst var to zero instead (empty layout). This will provide the most reasonable default (the least surprising one). This way we can continue using: - (Layout offsets: aRectangle), and get an absolute layout. - (Layout fractions: aRectangle), and get a pure proportional layout. The goal is to expunge the nil protection out of the LayoutFrame. Those nils are like additional states (to be or not to be nil...) and are gratuitous complexifications. We Ain't Gonna Need It anymore (the personal form of YAGNI). =============== Diff against Graphics-mt.426 =============== Item was added: + ----- Method: LayoutFrame>>fixup (in category 'initialize-release') ----- + fixup + "Set-up default value for un-initialized layout frames" + + "LayoutFrame allInstancesDo: [:e | e fixup]." + + leftFraction ifNil: [leftFraction := 0]. + leftOffset ifNil: [leftOffset := 0]. + topFraction ifNil: [topFraction := 0]. + topOffset ifNil: [topOffset := 0]. + rightFraction ifNil: [rightFraction := 0]. + rightOffset ifNil: [rightOffset := 0]. + bottomFraction ifNil: [bottomFraction := 0]. + bottomOffset ifNil: [bottomOffset := 0].! Item was added: + ----- Method: LayoutFrame>>initialize (in category 'initialize-release') ----- + initialize + "By default, let the frame be empty. + This way, we can later define a proportional layout via fractions, + or a fixed layout via offsets, or whatever mixture of both." + + leftFraction := leftOffset := topFraction := topOffset := rightFraction := rightOffset := bottomFraction := bottomOffset := 0! Item was changed: (PackageInfo named: 'Graphics') postscript: ' + "Fix those LayoutFrame with un-initialized instance variable" + LayoutFrame allInstancesDo: [:e | e fixup].'! - "Initialize RGBToName dictionary" - Color initializeNamesMap.'!

1 0

[BUG] Browsing uniclasses
by Thiede, Christoph 03 Mar '20

03 Mar '20

Hi all, there is another small bug IWLT fix for the release: [cid:aa5eb5d7-bdf8-4287-ab79-d2f540ce587e] The message [category] list is empty. At first glance, Browser >> #hasClassSelected is erroneous because it hardcodes Smalltalk instead of the displayed environment: hasClassSelected ^ selectedClassName notNil and: [(Smalltalk classNamed: selectedClassName) notNil] Is my assumption correct that there should be almost zero references to Smalltalk in Browser & Co.? Now I have to ask the question of whether you should use self environment or self selectedEnvironment here. What's the difference? Best, Christoph

3 6

The Trunk: Graphics-ct.411.mcz
by commits＠source.squeak.org 03 Mar '20

03 Mar '20

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-ct.411.mcz ==================== Summary ==================== Name: Graphics-ct.411 Author: ct Time: 6 September 2019, 1:02:01.259698 pm UUID: ac0b5286-28f7-614c-adfb-4729ed485475 Ancestors: Graphics-mt.410 Add a the #fullFrame constant to LayoutFrame This is a value used quite often ... =============== Diff against Graphics-mt.410 =============== Item was added: + ----- Method: LayoutFrame class>>fullFrame (in category 'instance creation') ----- + fullFrame + + ^ self fractions: (0 @ 0 corner: 1 @ 1)!

1 0

The Trunk: SMBase-nice.143.mcz
by commits＠source.squeak.org 03 Mar '20

03 Mar '20

Nicolas Cellier uploaded a new version of SMBase to project The Trunk: http://source.squeak.org/trunk/SMBase-nice.143.mcz ==================== Summary ==================== Name: SMBase-nice.143 Author: nice Time: 3 March 2020, 8:25:18.229606 pm UUID: 8cd650f5-1462-4f4e-b81f-ec3e4a963249 Ancestors: SMBase-nice.142, SMBase-tpr.141 Merge 5.2 SMBase-tpr.141 which did not find its way to 5.3 =============== Diff against SMBase-nice.142 =============== Item was changed: ----- Method: SMSqueakMap>>loadFullFrom: (in category 'private') ----- + loadFullFrom: aServerName + "Contact the SqueakMap at aServerName, building the the url for this version and load a full map from scratch. + Allow several retries in case of net slowness etc." + | url zipped attempts mapContents | + url := 'http://' , aServerName , '/loadgz?mapversion=' , SMSqueakMap version , '&checkpoint=' , checkpointNumber asString. + attempts := 0. - loadFullFrom: aServerName - "Contact the SqueakMap at the url <aSqueakMapUrl> - and load a full map from scratch." + [attempts := attempts + 1. + zipped := HTTPSocket httpGet: url. + zipped isString + ifTrue: ["awful legacy way to detect net error - use a proper technique + when the httpsocket can be replaced with a webclient. For now, raise a generic exception" + NetworkError signal]] + on: NetworkError + do: [:ex | + attempts >= 3 + ifTrue: [self halt: 'Unable to load SqueakMap map update after ' , attempts asString , ' attempts']. + ex retry]. + + mapContents := zipped contents. + ((self checkVersion: mapContents) + and: [mapContents ~= 'UPTODATE']) + ifTrue: [self saveCheckpoint: mapContents. + self reload]! - | url zipped | - url := 'http://', aServerName, '/loadgz?mapversion=', SMSqueakMap version, '&checkpoint=', checkpointNumber asString. - Transcript show: 'Fetch: ', (Time millisecondsToRun: [ zipped := (HTTPSocket httpGet: url) contents]) asString, ' ms';cr. - Transcript show: 'Size: ', zipped size asString, ' bytes';cr. - ((self checkVersion: zipped) and: [zipped ~= 'UPTODATE']) - ifTrue:[ - Transcript show: 'Save checkpoint to disk: ', (Time millisecondsToRun: [ - self saveCheckpoint: zipped]) asString, ' ms';cr. - Transcript show: 'Full reload from checkpoint: ', (Time millisecondsToRun: [ - self reload]) asString, ' ms';cr.]!

1 0

The Trunk: SMBase-tpr.141.mcz
by commits＠source.squeak.org 03 Mar '20

03 Mar '20

Nicolas Cellier uploaded a new version of SMBase to project The Trunk: http://source.squeak.org/trunk/SMBase-tpr.141.mcz ==================== Summary ==================== Name: SMBase-tpr.141 Author: tpr Time: 18 January 2019, 4:24:49.815196 pm UUID: 4997d27a-e261-41e0-b019-7723c85a5c1b Ancestors: SMBase-cmm.140 First step towards improving the SM loading stuff; allow up to 3 attempts to help with handling network slowness etc. Next step should be using a webclient instead of the httpsocket and getting somewhat nice eror handling. =============== Diff against SMBase-cmm.140 =============== Item was changed: ----- Method: SMSqueakMap>>loadFullFrom: (in category 'private') ----- + loadFullFrom: aServerName + "Contact the SqueakMap at aServerName, building the the url for this version and load a full map from scratch. + Allow several retries in case of net slowness etc." + | url zipped attempts mapContents | + url := 'http://' , aServerName , '/loadgz?mapversion=' , SMSqueakMap version , '&checkpoint=' , checkpointNumber asString. + attempts := 0. - loadFullFrom: aServerName - "Contact the SqueakMap at the url <aSqueakMapUrl> - and load a full map from scratch." + [attempts := attempts + 1. + zipped := HTTPSocket httpGet: url. + zipped isString + ifTrue: ["awful legacy way to detect net error - use a proper technique + when the httpsocket can be replaced with a webclient. For now, raise a generic exception" + NetworkError signal]] + on: NetworkError + do: [:ex | + attempts >= 3 + ifTrue: [self halt: 'Unable to load SqueakMap map update after ' , attempts asString , ' attempts']. + ex retry]. + + mapContents := zipped contents. + ((self checkVersion: mapContents) + and: [mapContents ~= 'UPTODATE']) + ifTrue: [self saveCheckpoint: mapContents. + self reload]! - | url zipped | - url := 'http://', aServerName, '/loadgz?mapversion=', SMSqueakMap version, '&checkpoint=', checkpointNumber asString. - Transcript show: 'Fetch: ', (Time millisecondsToRun: [ zipped := (HTTPSocket httpGet: url) contents]) asString, ' ms';cr. - Transcript show: 'Size: ', zipped size asString, ' bytes';cr. - ((self checkVersion: zipped) and: [zipped ~= 'UPTODATE']) - ifTrue:[ - Transcript show: 'Save checkpoint to disk: ', (Time millisecondsToRun: [ - self saveCheckpoint: zipped]) asString, ' ms';cr. - Transcript show: 'Full reload from checkpoint: ', (Time millisecondsToRun: [ - self reload]) asString, ' ms';cr.]!

1 0

Re: [squeak-dev] Squeak/Opensmalltalk Funding and Organization
by 6107415315＠txt.att.net 03 Mar '20

03 Mar '20

7726 -----Original Message----- From: <squeak-dev(a)lists.squeakfoundation.org> Sent: Tue, 3 Mar 2020 12:59:12 -0500 To: 6107415315(a)txt.att.net Subject: Re: [squeak-dev] Squeak/Opensmalltalk Funding and Organization >Sure, icons are one example. I am also thinking VM development. Or to pay >someone to revamp Morphic / graphics, etc. I think these are big scale >areas of improvement that are h ================================================================== This mobile text message is brought to you by AT&T

1 0

The Trunk: ReleaseBuilder-mt.208.mcz
by commits＠source.squeak.org 03 Mar '20

03 Mar '20

Marcel Taeumel uploaded a new version of ReleaseBuilder to project The Trunk: http://source.squeak.org/trunk/ReleaseBuilder-mt.208.mcz ==================== Summary ==================== Name: ReleaseBuilder-mt.208 Author: mt Time: 3 March 2020, 12:28:11.466812 pm UUID: 8e130da6-cb1a-b14e-8627-ef0e7a587926 Ancestors: ReleaseBuilder-mt.207 Set release version 5.3. (This MC version will be copied to the release repo.) =============== Diff against ReleaseBuilder-mt.207 =============== Item was changed: ----- Method: ReleaseBuilder class>>initialize (in category 'class initialization') ----- initialize QAndA ifNil: [self clearQAndA]. "We have to be after AutoStart so that Morphic is up and running." Smalltalk addToStartUpList: ReleaseBuilder after: AutoStart. + SystemVersion newVersion: 'Squeak5.3'! - SystemVersion newVersion: 'Squeak5.3rc3'!

1 0

Jump to page: