Squeak-dev February 2020

squeak-dev@lists.squeakfoundation.org

32 participants
305 discussions

Support an updated image format number for Sista
by David T. Lewis 19 Jul '20

19 Jul '20

Hi Eliot, This is a belated follow up on earlier private discussion during a Squeak board meeting a few months ago, in which we agreed that identifying "Sista in use" in the image format number would be a useful thing to do. I previously added the documentation for this in ImageFormat-dtl.39.mcz (as well as the updated ckformat.c program to match). Attached here is a change set that can be loaded into a VMMaker image to add VM support for setting and reading the updated image format numbers. Here I used a primitive to initially set or clear the "sista bit". There are other ways this could be done, but this at least gets us started with a working implementation. By way of explanation, I am copying below both the change set preamble and the earlier ImageFormat commit notice: === Change Set: VMM-Sista-bit-dtl Date: 12 January 2020 Author: David T. Lewis Let the image inform the interpreter that alternate bytecodes either are or are not in use, and remember that setting when writing or reading the image format number in a shapshot file header. Provide primitiveMultipleBytecodesActive to allow the setting to be updated from the image. Expected usage is that the image can call this primitive after recompiling with Systa bytecodes, or after reverting back. Note that an alternative implemenation would be to use a VM parameter. The primitive was chosen here because it can perform parameter checking and does not require coordinated update the the VM parameter usage. Expected usage is that this feature will remain unused for some grace period (perhaps a few months) during which an updated VM can be widely circulated. After that period, images using Sista bytecodes may be safely saved with the updated image format number indicating that multiple bytecodes are in use. This change set includes helper methods in SmalltalkImage for testing or setting the multipleBytecodeSetsActive setting in the VM. Note the change set postscript which is necessary for initializing a class variable prior to code generation. === Name: ImageFormat-dtl.37 Author: dtl Time: 20 July 2019, 5:23:59.004 pm UUID: 52b464d5-0bf7-4326-bde3-4f18ad70b239 Ancestors: ImageFormat-dtl.36 Identify extended bytecodes for Sista in the image format number. Bit 10 identifies an image that contains extended bytecodes. Thus a 32 bit Spur image is 6521, with Sista it is 7033, and a 64 bit Spur image is 68021, with Sista it is 68533. It is expected that additional bytecode sets can be identified by an additional field in the image header, probably 32 bits containing two 16 bit fields, if both zero then Sista. Per discussion with Eliot and Bert in a Squeak oversight board meeting 2019-05-15. Dave

1 3

The Inbox: EToys-ct.367.mcz
by commits＠source.squeak.org 29 Mar '20

29 Mar '20

A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-ct.367.mcz ==================== Summary ==================== Name: EToys-ct.367 Author: ct Time: 15 October 2019, 2:46:24.862129 pm UUID: 1394344f-b1e3-5640-a13a-70c5dffd51f4 Ancestors: EToys-mt.361 Allow for embedding SyntaxMorphs into test tiles. =============== Diff against EToys-mt.361 =============== Item was added: + ----- Method: SyntaxMorph>>parseNodeWith:asStatement: (in category '*Etoys-Squeakland-code generation') ----- + parseNodeWith: encoder asStatement: aBoolean + + ^ self parseNode!

4 11

The Inbox: HelpSystem-Core-ct.123.mcz
by commits＠source.squeak.org 26 Mar '20

26 Mar '20

A new version of HelpSystem-Core was added to project The Inbox: http://source.squeak.org/inbox/HelpSystem-Core-ct.123.mcz ==================== Summary ==================== Name: HelpSystem-Core-ct.123 Author: ct Time: 13 October 2019, 9:04:08.373932 pm UUID: dec7ceca-320f-d945-8d2a-c2f6a5e49a52 Ancestors: HelpSystem-Core-ct.120 Refactors HelpBrowser menu: Move menu stuff from HelpBrowser into HelpTopic hierarchy in favor of a better object design Thanks again, Marcel :-) =============== Diff against HelpSystem-Core-ct.120 =============== Item was added: + ----- Method: AbstractHelpTopic>>browseTopicFromParent: (in category 'tools') ----- + browseTopicFromParent: parentTopic + + self canBrowseTopic + ifTrue: [^ self browseTopic]. + parentTopic canBrowseSubtopic + ifTrue: [^ parentTopic browseSubtopic: self]. + ! Item was added: + ----- Method: AbstractHelpTopic>>canBrowseSubtopic (in category 'testing') ----- + canBrowseSubtopic + + ^ false! Item was added: + ----- Method: AbstractHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ false! Item was added: + ----- Method: AbstractHelpTopic>>canBrowseTopicFromParent: (in category 'testing') ----- + canBrowseTopicFromParent: parentTopic + + ^ self canBrowseTopic or: [ + parentTopic ifNotNil: #canBrowseSubtopic ifNil: [false]]! Item was added: + ----- Method: AbstractHelpTopic>>topicMenu:parentTopic: (in category 'menus') ----- + topicMenu: aMenu parentTopic: parentTopic + + aMenu + add: 'Inspect (i)' translated target: self action: #inspect; + add: 'Explore (I)' translated target: self action: #explore. + (self canBrowseTopicFromParent: parentTopic) + ifTrue: [ + aMenu add: 'Browse (b)' translated + target: self + selector: #browseTopicFromParent: + argumentList: {parentTopic} ]. + + ^ aMenu! Item was added: + ----- Method: AbstractHelpTopic>>topicMenuKey:fromParent: (in category 'menus') ----- + topicMenuKey: aChar fromParent: parentTopic + + aChar + caseOf: { + [$b] -> [(self canBrowseTopicFromParent: parentTopic) + ifTrue: [ self browseTopicFromParent: parentTopic ]]. + [$i] -> [self inspect]. + [$I] -> [self explore] } + otherwise: [^ false]. + ^ true! Item was added: + ----- Method: ClassAPIHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: ClassBasedHelpTopic>>canBrowseSubtopic (in category 'testing') ----- + canBrowseSubtopic + + ^ true! Item was added: + ----- Method: ClassBasedHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: DirectoryBasedHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: FileBasedHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was removed: - ----- Method: HelpBrowser>>browseTopic (in category 'actions') ----- - browseTopic - - ^ (self currentTopic respondsTo: #browseTopic) - ifTrue: [self currentTopic browseTopic] - ifFalse: [self currentParentTopic browseSubtopic: self currentTopic]! Item was removed: - ----- Method: HelpBrowser>>canBrowseTopic (in category 'testing') ----- - canBrowseTopic - - ^ (self currentTopic respondsTo: #browseTopic) - or: [self currentParentTopic respondsTo: #browseSubtopic:]! Item was removed: - ----- Method: HelpBrowser>>exploreTopic (in category 'actions') ----- - exploreTopic - - ^ self currentTopic explore! Item was removed: - ----- Method: HelpBrowser>>inspectTopic (in category 'actions') ----- - inspectTopic - - ^ self currentTopic inspect! Item was changed: ----- Method: HelpBrowser>>treeKey:from:event: (in category 'menus') ----- treeKey: aChar from: aView event: anEvent anEvent anyModifierKeyPressed ifFalse: [^ false]. + ^ (self currentTopic topicMenuKey: aChar fromParent: self currentParentTopic)! - aChar - caseOf: { - [$b] -> [self browseTopic]. - [$i] -> [self inspectTopic]. - [$I] -> [self exploreTopic]. } - otherwise: [^ false]. - ^ true! Item was changed: ----- Method: HelpBrowser>>treeListMenu: (in category 'menus') ----- treeListMenu: aMenu <treeListMenu> + ^ self currentTopic + ifNil: [aMenu] + ifNotNil: [:topic | topic + topicMenu: aMenu + parentTopic: self currentParentTopic]! - self currentTopic ifNil: [^ aMenu]. - - aMenu - add: 'Inspect (i)' action: #inspectTopic; - add: 'Explore (I)' action: #exploreTopic. - - self canBrowseTopic ifTrue: [ - aMenu - addLine; - add: 'Browse (b)' action: #browseTopic]. - - ^ aMenu! Item was added: + ----- Method: MethodListHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: PackageAPIHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true!

9 22

[BUG] Timestamps don't work for classes with special character names
by Thiede, Christoph 20 Mar '20

20 Mar '20

Hi all, found just another bug. If you get tired of them, just tell me :-) Steps to reproduce: Print it: class := Object subclass: #CTTèstClass "sic (with accent in name)!" instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'CT-Experiments'. class compile: 'foo ^ #foo'. (class >> #foo) timeStamp Expected output: Something like 'ct 12/21/2019 15:13'. Actual output: ''. Please note that everything would have worked fine if we named class #CTTestClass (without accent) instead. Do we want to support special class names in general? If yes, this is a bug in my opinion. If no, we should raise an error in the first statement. Cause of infection not yet investigated. Best, Christoph

3 9

[BUG] Parser does not detect syntax error with double colon
by Thiede, Christoph 13 Mar '20

13 Mar '20

Steps to reproduce: Try doIt this (for example, in a workspace): 2 raisedTo:: 3. Expected behavior: 2 raisedTo:"Argument expected ->": 3. Actual behavior: [cid:c80a10c0-c0f3-449a-b34d-733c44256241] If you are thumb enough to choose #raisedTo:: (I was), you get a subsequent error: [cid:c80d78da-81df-4634-82c0-1721a66c80c2] Even worse: If you try to doIt the same code snippet again, no parser warning/error will be raised at all but you get a runtime error: MessageNotUnderstood: SmallInteger>>raisedTo::. Best, Christoph

5 12

[BUG] Objects as methods break method search
by Thiede, Christoph 07 Mar '20

07 Mar '20

Steps to reproduce: Debug TestObjectsAsMethods >> #testAddNumbers, for example. Keep the debugger open. Search for senders of any literal in your image, for example, "senders of #foo". Expected behavior: A MessageTrace with the calling methods opens as usual. Actual behavior: In SystemNavigation >> #allCallsOn:fromBehaviors:sorted:, an exception is raised: MessageNotUnderstood: ObjectsAsMethodsExample>>hasLiteral:scanForSpecial:. Considerations: There are further bugs, for example, browse implementors of #foo, which will give you an MNU for AbstractObjectsAsMethod>>isDeprecated. I see three possible solution approaches: Approach A: Define an abstract superclass of all "objects as methods" classes, for example in AbstractObjectsAsMethod. Add an implementation of #hasLiteral:scanForSpecial: there, it might be sufficient to return false. Pro: We can assure each value in a method dictionary actually understands a minimum protocol and do not need to add safety checks at other places such as SystemNavigation. Con: We increase the complexity of implementing an object as method. By requiring a certain superclass, it is not possible for an existing class to accept the OaM responsibility. Con: The number of methods to implement in this superclass might be large and unclear. Approach B: In SystemNavigation >> #allCallsOn:fromBehaviors:sorted:, check that method responds to #hasLiteral:scanForSpecial: before sending the message, or catch any DNUs via #ifError: or so. In CodeHolder >> #formattedLabel:forSelector:inClass:, we would need to wrap the call to #isDeprecated the same way. Con: There is possibly a very large number of clients of method dictionaries. It will be a mess to secure them all. Note also how WrappedBreakpoint and TestCoverage are implemented. They keep a reference to the actual CompiledMethod they replace and forward all messages not understood to this method. There is duplication among these two classes, maybe we should refactor this as well. However, the forwarding approach cannot work if there is no wrapped method available. So Approach C would be: Should we maybe provide some kind of "null method object" we could forward all unknown messages to? Each OaM implementor that is not a wrapper then would need to implement the following method: doesNotUnderstand: aMessage ^ aMessage sendTo: CompiledMethod nullMethod Pro: Very easy to implement for both users of method dictionaries and implementors of OaM. Con: It is not possible for an existing class that already forwards messages via #doesNotUnderstand: to accept the OaM responsibility. But this appears rather a hypothetic problem to me, as you could always decompose this responsibility ... (For illustration, the probably cheapest fix of the concrete bugs mentioned above might be this: AbstractObjectsAsMethod >> doesNotUnderstand: aMessage ^ aMessage sendTo: thisContext method But this is the drawback of such a workaround: [cid:e740fd3a-62ea-442c-8eff-a3517c7d92a0]) So, which way would you go? To me, approach C sounds most useful, as we could actually provide a tweaked instance of CompiledMethod instead of reimplementing the protocol in another class (and having to maintain it). Do we already have any constructor that could work as a method null object? Something like "Compiler new compiledMethodFor: '' in: nil to: nil notifying: nil ifFail: nil"? But this one has also two literals. Best, Christoph

2 2

[BUG] Keyhandling on Windows
by Thiede, Christoph 05 Mar '20

05 Mar '20

Hi all, sorry to report to you another, though minor issue related to keyboard handling. Steps to reproduce: * Open a fresh trunk image on Windows * turn off num lock (so that 4 works like arrowLeft) * Go to any editor, such as workspace * Press the number key 5 Expected behavior: No character is inserted, as digits are turned off. Actual behavior: The quotes character (") is inserted. Notes: The issue already existed in Squeak 5.2, 4.6 and 3.9 (from my random tests). Best, Christoph

4 9

something for the next release
by Eliot Miranda 04 Mar '20

04 Mar '20

Hi All, Hi Marcel, in implementing inspectors for the VMMaker I'm wanting to close all open inspectors associated with a simulation when the simulation window is closed. I notice in SystemWindow>>delete there is non-generic code (a.k.a. a horrible hack) for the sketch editors associated palettes. This badly needs rewriting to be generic. So instead of delete ... sketchEditor := self extantSketchEditor. ... sketchEditor ifNotNil: [sketchEditor deleteSelfAndSubordinates. (thisWorld notNil and: [(aPaintBox := thisWorld paintBoxOrNil) notNil]) ifTrue: [aPaintBox delete]]. it reads something like delete ... dependentMorphs := self dependentMorphsOrNil. ... dependentMorphs ifNotNil: [dependentMorphs do: [:each| each deleteSelfAndSubordinates]]. then I can easily extend this to deal with additional inspector windows, instead of having code in the model to search for them. _,,,^..^,,,_ best, Eliot

2 1

[BUG] Browsing uniclasses
by Thiede, Christoph 03 Mar '20

03 Mar '20

Hi all, there is another small bug IWLT fix for the release: [cid:aa5eb5d7-bdf8-4287-ab79-d2f540ce587e] The message [category] list is empty. At first glance, Browser >> #hasClassSelected is erroneous because it hardcodes Smalltalk instead of the displayed environment: hasClassSelected ^ selectedClassName notNil and: [(Smalltalk classNamed: selectedClassName) notNil] Is my assumption correct that there should be almost zero references to Smalltalk in Browser & Co.? Now I have to ask the question of whether you should use self environment or self selectedEnvironment here. What's the difference? Best, Christoph

3 6

The Inbox: Morphic-ct.1634.mcz
by commits＠source.squeak.org 03 Mar '20

03 Mar '20

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1634.mcz ==================== Summary ==================== Name: Morphic-ct.1634 Author: ct Time: 29 February 2020, 11:46:44.317896 am UUID: 71271fa2-4ed1-6d4f-8f58-30ed8165c367 Ancestors: Morphic-mt.1631 Proposal: Add pick button to NewColorPickerMorph that allows to pick a color from the Display. With this enhancement, NCPM is finally superior to the old ColorPickerMorph and could now replace the latter by the default preferences. =============== Diff against Morphic-mt.1631 =============== Item was changed: Morph subclass: #NewColorPickerMorph + instanceVariableNames: 'target setColorSelector hsvaMorph colorPresenter isPicking' - instanceVariableNames: 'target setColorSelector hsvaMorph colorPresenter' classVariableNames: 'UseIt' poolDictionaries: '' category: 'Morphic-Widgets'! !NewColorPickerMorph commentStamp: 'cmm 12/3/2010 13:36' prior: 0! A NewColorPickerMorph is a new widget for choosing colors in Morphic. Instantiate a NewColorPickerMorph: (NewColorPickerMorph on: objectToHaveItsColorSet getColorSelector: itsColorGetterSymbol setColorSelector: itsColorSetterSymbol) openInWorld ! Item was changed: ----- Method: NewColorPickerMorph>>colorSelected: (in category 'model') ----- colorSelected: aColor + self isPicking ifFalse: [ + self targetColor: aColor]. - self targetColor: aColor. self changed: #colorExpression! Item was changed: ----- Method: NewColorPickerMorph>>initialize (in category 'initialize-release') ----- initialize + super initialize. + isPicking := false. + self initializeHsvaMorph.! - self initializeHsvaMorph! Item was added: + ----- Method: NewColorPickerMorph>>isPicking (in category 'accessing') ----- + isPicking + + ^ isPicking! Item was added: + ----- Method: NewColorPickerMorph>>isPicking: (in category 'picking') ----- + isPicking: aBoolean + + isPicking := aBoolean. + self changed: #isPicking. + aBoolean ifTrue: [self pickColor].! Item was changed: ----- Method: NewColorPickerMorph>>newBottomRow (in category 'initialize-release') ----- newBottomRow ^ Morph new + color: Color transparent; + changeTableLayout; + listDirection: #leftToRight; + hResizing: #spaceFill; vResizing: #shrinkWrap; + height: 20; + cellGap: 4; + addMorphBack: self newPickButton; + addMorphBack: (StringMorph contents: 'Current selection:' translated); + addMorphBack: self newColorPresenterMorph; + addMorphBack: self newCloseButton; + yourself! - color: Color transparent ; - changeTableLayout ; - listDirection: #leftToRight ; - hResizing: #spaceFill; vResizing: #shrinkWrap ; - height: 20 ; - cellGap: 4 ; - addMorph: (StringMorph contents: 'Current selection:' translated) ; - addMorphBack: self newColorPresenterMorph ; - addMorphBack: self newCloseButton! Item was changed: ----- Method: NewColorPickerMorph>>newCloseButton (in category 'initialize-release') ----- newCloseButton ^ (PluggableButtonMorph on: self getState: nil action: #delete label: #closeButtonLabel) + vResizing: #spaceFill; - vResizing: #spaceFill ; hResizing: #spaceFill; + balloonText: self closeButtonLabel; + yourself! - yourself! Item was added: + ----- Method: NewColorPickerMorph>>newPickButton (in category 'initialize-release') ----- + newPickButton + ^ (PluggableButtonMorph + on: self + getState: #isPicking + action: #togglePicking + label: #pickingButtonLabel) + vResizing: #spaceFill; + hResizing: #spaceFill; + balloonText: self pickingButtonLabel; + yourself! Item was added: + ----- Method: NewColorPickerMorph>>pickColor (in category 'picking') ----- + pickColor + + | selectedColor | + [ + | previousColor | + previousColor := self selectedColor. + selectedColor := self pickColorFromDisplay. + selectedColor ifNil: [^ self selectedColor: previousColor]. + ] ensure: [ + self isPicking: false]. + self selectedColor: selectedColor.! Item was added: + ----- Method: NewColorPickerMorph>>pickColorFromDisplay (in category 'picking') ----- + pickColorFromDisplay + + [Sensor anyButtonPressed] + whileTrue; + whileFalse: [ + Sensor peekKeyboard = Character escape ifTrue: [ + Sensor flushKeyboard. + ^ nil]. + ((ActiveHand world morphsAt: Sensor cursorPoint) includes: self) ifFalse: [ + self selectedColor: (Display colorAt: Sensor cursorPoint)]. + self world displayWorldSafely; runStepMethods]. + Sensor yellowButtonPressed + ifTrue: [^ nil]. + ((ActiveHand world morphsAt: Sensor cursorPoint) includes: self) + ifTrue: [^ nil]. + ^ self selectedColor! Item was added: + ----- Method: NewColorPickerMorph>>pickingButtonLabel (in category 'initialize-release') ----- + pickingButtonLabel + ^ 'Picking' translated! Item was changed: ----- Method: NewColorPickerMorph>>setup (in category 'initialize-release') ----- setup + self + color: Color white darker; + cornerStyle: #rounded; + changeTableLayout; + hResizing: #shrinkWrap; + vResizing: #shrinkWrap; + extent: 240@240; + addMorphBack: hsvaMorph; + addMorphBack: self newColorExpressionMorph; + addMorphBack: self newBottomRow; + layoutInset: 4; + cellGap: 2. + + Preferences menuAppearance3d + ifTrue: [self addDropShadow].! - color: (Color white darker) ; - cornerStyle: #rounded ; - changeTableLayout ; - hResizing: #shrinkWrap ; - vResizing: #shrinkWrap ; - extent: 240@240 ; - addMorphBack: hsvaMorph ; - addMorphBack: self newColorExpressionMorph ; - addMorphBack: self newBottomRow ; - layoutInset: 4 ; - cellGap: 2. - - Preferences menuAppearance3d - ifTrue: [self addDropShadow]. - ! Item was changed: ----- Method: NewColorPickerMorph>>setupForProperties (in category 'initialize-release') ----- setupForProperties + self + color: Color white darker; + changeTableLayout; + hResizing: #shrinkWrap; + vResizing: #shrinkWrap; + extent: 240@240; + addMorphBack: hsvaMorph; + layoutInset: 4; + cellGap: 2.! - color: (Color white darker) ; - changeTableLayout ; - hResizing: #shrinkWrap ; - vResizing: #shrinkWrap ; - extent: 240@240 ; - addMorphBack: hsvaMorph ; - layoutInset: 4 ; - cellGap: 2.! Item was added: + ----- Method: NewColorPickerMorph>>togglePicking (in category 'picking') ----- + togglePicking + self isPicking: self isPicking not!

6 17

← Newer
1
2
3
4
5
6
7
8
...
31
Older →

Jump to page: