Squeak-dev February 2020

squeak-dev@lists.squeakfoundation.org

32 participants
305 discussions

[BUG] MultiByteFileStream(Object)>>error: primGetPosition: failed
by Thiede, Christoph 06 Feb '20

06 Feb '20

Hi all, I don't know if someone of you saw this error message recently? MultiByteFileStream(Object)>>error: primGetPosition: failed (Just for the case this should be a VM-related problem, I'm using OpenSmalltalk 201912311458 on Win 1903.) I experienced it various times, and each time, once the error had occurred once, no more access to the sources file was possible. I could neither select any message then nor debug, even quitting the image without saving was not possible; each attempt raised the same error again. Now I finally discovered a scenario to reproduce this issue: (Disclaimer: This might crash your image! Save *before* doing this!) Debug the following, step over #unload, and during then loading happens, interrupt the process via cmd-dot: [cid:29c3b6a6-5fdf-498d-a47b-a9dd34666273] Please note that you will probably only have one chance to reproduce it, because the package will be cached. If you now open a browser, for example, selecting any message will raise the #primGetPosition: failure. However, if you continue from the interrupt, your image won't suffer consequential damages. This is a real problem because especially on slower images<http://forum.world.st/The-Inbox-ShoutCore-ct-78-mcz-tp5109909p5110050.html>, various tests can fail and damage your image because of their timeout limits. In a fresh (!) Trunk image, I could reproduce this several times by running MCPackageTest or MCFileInTest. Increasing their timeouts would be a dirty workaround for the moment. I also experienced the same problem in other projects where related MC operations were run in a timeout-limited context. So, how can we fix it? I assume that it is problematic if the file pointer does not get closed correctly. Would you consider a critical block an appropriate solution to fix the issue? But how would you write one the best way (never faced that stuff before), and doesn't this have undesirable disadvantages such as restricted debugging possibilities? Questions over questions :-) Any help or response will be appreciated! Best, Christoph

1 1

The Inbox: Tests-ct.426.mcz
by commits＠source.squeak.org 06 Feb '20

06 Feb '20

Christoph Thiede uploaded a new version of Tests to project The Inbox: http://source.squeak.org/inbox/Tests-ct.426.mcz ==================== Summary ==================== Name: Tests-ct.426 Author: ct Time: 6 February 2020, 6:58:06.300648 pm UUID: 2a0d3e63-9e48-5040-a1af-145fa43c9695 Ancestors: Tests-mt.424 Tests load and unload order of MCScriptDefinitions This is currently not working properly, see http://forum.world.st/Monticello-Bug-Preamble-of-removal-is-executed-too-la…. Fix is coming very soon! =============== Diff against Tests-mt.424 =============== Item was changed: SystemOrganization addCategory: #'Tests-Bugs'! SystemOrganization addCategory: #'Tests-Compiler'! SystemOrganization addCategory: #'Tests-Dependencies'! SystemOrganization addCategory: #'Tests-Digital Signatures'! SystemOrganization addCategory: #'Tests-Environments'! SystemOrganization addCategory: #'Tests-Exceptions'! SystemOrganization addCategory: #'Tests-FilePackage'! SystemOrganization addCategory: #'Tests-Files'! SystemOrganization addCategory: #'Tests-Finalization'! SystemOrganization addCategory: #'Tests-Hex'! SystemOrganization addCategory: #'Tests-Installer-Core'! SystemOrganization addCategory: #'Tests-Localization'! SystemOrganization addCategory: #'Tests-Monticello'! SystemOrganization addCategory: #'Tests-Monticello-Mocks'! SystemOrganization addCategory: #'Tests-Monticello-Utils'! SystemOrganization addCategory: #'Tests-Object Events'! SystemOrganization addCategory: #'Tests-ObjectsAsMethods'! SystemOrganization addCategory: #'Tests-PrimCallController'! SystemOrganization addCategory: #'Tests-Release'! SystemOrganization addCategory: #'Tests-System-Applications'! SystemOrganization addCategory: #'Tests-System-Digital Signatures'! SystemOrganization addCategory: #'Tests-System-Object Storage'! SystemOrganization addCategory: #'Tests-System-Preferences'! SystemOrganization addCategory: #'Tests-System-Support'! SystemOrganization addCategory: #'Tests-Utilities'! SystemOrganization addCategory: #'Tests-VM'! + SystemOrganization addCategory: #'Tests-MonticelloMocks'! Item was added: + ----- Method: MCPackageTest>>testLoadOrder (in category 'tests') ----- + testLoadOrder + + | snapshot loader additions | + snapshot := MCMockPackageInfo new mcPackage snapshot. + loader := MCPackageLoader new. + loader installSnapshot: snapshot. + loader analyze. + additions := loader instVarNamed: #additions. + self assert: [(additions findLast: [:ea | ea isKindOf: MCPreambleDefinition]) + < (additions findFirst: [:ea | ea isClassDefinition])]. + self assert: [(additions findFirst: [:ea | ea isKindOf: MCPostscriptDefinition]) + > (additions findLast: [:ea | ea isClassDefinition])].! Item was added: + ----- Method: MCPackageTest>>testUnloadOrder (in category 'tests') ----- + testUnloadOrder + + | package loader removals | + package := MCMockPackageInfo new mcPackage. + loader := MCPackageLoader new. + loader unloadPackage: package. + loader analyze. + removals := loader instVarNamed: #removals. + self assert: [(removals findLast: [:ea | ea isKindOf: MCRemovalPreambleDefinition]) + < (removals findFirst: [:ea | ea isClassDefinition])]. + self assert: [(removals findFirst: [:ea | ea isKindOf: MCRemovalPostscriptDefinition]) + > (removals findLast: [:ea | ea isClassDefinition])].! Item was changed: ----- Method: MCWorkingCopyRenameTest>>mockPackage (in category 'running') ----- mockPackage + ^MCPackage named: self mockCategoryName! - ^MCPackage new name: self mockCategoryName!

2 1

Monticello Bug? Preamble of removal is executed too late
by Thiede, Christoph 06 Feb '20

06 Feb '20

Hi all, I found a possible bug in Monticello scripts. Let me try to describe the issue: Steps to reproduce 1. In Monticello Browser, create a new package named #Foo 2. In the System Browser, create a new class named #FooClass in the system category #Foo 3. On its class side, add a method named #bar - just declare it. 4. In Monticello Browser, edit the preambleOfRemoval for our #Foo Package and set it to: FooClass bar 5. Save a version of our #Foo package 6. Still in Monticello Browser, unload the foo package via context menu. Expected behavior The package is unloaded without any errors. If Foo class >> bar has a real implementation, it will have run when the package is removed. Actual behavior In MCRemovalPreambleDefinition >> #evaluate: UndefinedObject does not understand #bar. Reason In MCPackageLoader >> #analyze, the MCDependencySorter for removals does not return the removal preamble definition as the last item, but the class definition of FooClass. This happens somewhere in #addExternalProvisions:, because FooClass depends on Object and thus is moved to the end (?). Questions Am I right that this is a bug? I think we really want to execute the removal preamble *before* unloading any code definitions? How could one solve this issue? Is it necessary to treat preambles/postambles separated so that they can't be messed up by dependencies? Or would know an easier way? I'm not familiar at all with this domain, so if we want a fast solution, maybe someone others could have a look at it. Otherwise, I'd be happy to hear your opinions. Best, Christoph

4 4

The Inbox: Monticello-ct.715.mcz
by commits＠source.squeak.org 06 Feb '20

06 Feb '20

Christoph Thiede uploaded a new version of Monticello to project The Inbox: http://source.squeak.org/inbox/Monticello-ct.715.mcz ==================== Summary ==================== Name: Monticello-ct.715 Author: ct Time: 6 February 2020, 6:58:26.533648 pm UUID: 199bf8a3-5eee-1045-a44b-89ad30fa5523 Ancestors: Monticello-cmm.708 Fixes wrong load and unload order of MCScriptDefinitions See http://forum.world.st/Monticello-Bug-Preamble-of-removal-is-executed-too-la…. Regression tests are in Tests-ct.426. Please review! =============== Diff against Monticello-cmm.708 =============== Item was added: + ----- Method: MCDefinition>>wantsToBeOutermost (in category 'testing') ----- + wantsToBeOutermost + + ^ false! Item was changed: Object subclass: #MCDependencySorter + instanceVariableNames: 'required provided deferred orderedItems' - instanceVariableNames: 'required provided orderedItems' classVariableNames: '' poolDictionaries: '' category: 'Monticello-Loading'! Item was changed: ----- Method: MCDependencySorter>>add: (in category 'building') ----- add: anItem | requirements | + (anItem wantsToBeOutermost) + ifTrue: [^self addDeferred: anItem]. requirements := self unresolvedRequirementsFor: anItem. requirements isEmpty ifTrue: [self addToOrder: anItem] ifFalse: [self addRequirements: requirements for: anItem]. ^anItem! Item was added: + ----- Method: MCDependencySorter>>addDeferred (in category 'building') ----- + addDeferred + deferred do: [:ea | + self addToOrder: ea].! Item was added: + ----- Method: MCDependencySorter>>addDeferred: (in category 'private') ----- + addDeferred: anItem + ^ deferred add: anItem! Item was changed: ----- Method: MCDependencySorter>>initialize (in category 'initialize-release') ----- initialize provided := Set new. required := Dictionary new. + orderedItems := OrderedCollection new. + deferred := OrderedCollection new.! - orderedItems := OrderedCollection new.! Item was changed: ----- Method: MCPackageLoader>>sorterForItems: (in category 'private') ----- sorterForItems: aCollection | sorter | sorter := MCDependencySorter items: aCollection. sorter addExternalProvisions: self provisions. + sorter addDeferred. ^ sorter! Item was added: + ----- Method: MCPostscriptDefinition>>wantsToBeOutermost (in category 'nil') ----- + wantsToBeOutermost + + ^ true! Item was added: + ----- Method: MCRemovalPreambleDefinition>>wantsToBeOutermost (in category 'testing') ----- + wantsToBeOutermost + + ^ true!

1 0

Tone
by Tobias Pape 06 Feb '20

06 Feb '20

" >> We can look at other such libraries, OpenJDK also uses 10 for ArrayList: http://hg.openjdk.java.net/jdk/jdk/file/9211f6e20448/src/java.base/share/cl… > Java based its core library off Smalltalk, Jakob.. " A condescending tone like that is uncalled for. Please cease it. -t PS: I will fight against useless new:/new changes.

2 1

The Inbox: Collections-cmm.874.mcz
by commits＠source.squeak.org 06 Feb '20

06 Feb '20

Chris Muller uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-cmm.874.mcz ==================== Summary ==================== Name: Collections-cmm.874 Author: cmm Time: 24 January 2020, 3:32:43.628249 pm UUID: 107f3a74-177c-4338-9ad3-648e427419a1 Ancestors: Collections-ul.871 - Optimize for system compactness by ensuring the default internal array size of any HashedCollection is not initialized larger than it may ever need to be. - Let #new: be used to define larger sizes than the minimum, and perform comparably with #new even if the minimum size is specified. =============== Diff against Collections-ul.871 =============== Item was changed: ----- Method: HashedCollection class>>new (in category 'instance creation') ----- new + ^ self basicNew initialize: 3! - ^ self basicNew initialize: 5!

10 23

Squeak Oversight Board 2020 Results
by Ron Teitelbaum 06 Feb '20

06 Feb '20

Hello Everyone, I'm very pleased to announce your Squeak Oversight Board for 2020. They are: 1. Bert Freudenberg 2. Tim Rowledge 3. Marcel Taeumel 4. Craig Latta 5. David T. Lewis 6. Chris Muller 7. John-Reed Maffeo http://wiki.squeak.org/squeak/6636 I would like to thank everyone that served on the board last year! Thank you for contributions to Squeak! Thank you to everyone that ran this year and for everyone that voted! We are looking forward to a great year in the Squeak community! Please help me to congratulate your new board for 2020!! All the best, Ron Teitelbaum

4 3

The Inbox: Kernel-fn.1294.mcz
by commits＠source.squeak.org 06 Feb '20

06 Feb '20

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-fn.1294.mcz ==================== Summary ==================== Name: Kernel-fn.1294 Author: fn Time: 29 January 2020, 6:47:12.028071 pm UUID: 0b61cdfe-41e2-4aee-a5f0-80d8e7d45127 Ancestors: Kernel-tonyg.1293 Remove inputSemaphore and hasInputSemaphore from EventSensor (both are no longer in use). Also drop EventSensor>>primSetInputSemaphore:. =============== Diff against Kernel-tonyg.1293 =============== Item was changed: Object subclass: #EventSensor + instanceVariableNames: 'mouseButtons mousePosition mouseWheelDelta keyboardBuffer interruptKey interruptSemaphore eventQueue lastEventPoll' - instanceVariableNames: 'mouseButtons mousePosition mouseWheelDelta keyboardBuffer interruptKey interruptSemaphore eventQueue inputSemaphore lastEventPoll hasInputSemaphore' classVariableNames: 'ButtonDecodeTable EventPollPeriod EventTicklerProcess InterruptSemaphore InterruptWatcherProcess KeyDecodeTable' poolDictionaries: 'EventSensorConstants' category: 'Kernel-Processes'! !EventSensor commentStamp: 'mt 12/13/2019 14:38' prior: 0! An EventSensor is an interface to the user input devices. There is at least one instance of EventSensor named Sensor in the system. EventSensor is a replacement for the earlier InputSensor implementation based on a set of (optional) event primitives. An EventSensor updates its state when events are received so that all state based users of Sensor (e.g., Sensor keyboard, Sensor leftShiftDown, Sensor mouseButtons) will work exactly as before, by moving the current VM mechanisms into EventSensor itself. An optional input semaphore is part of the new design. For platforms that support true asynchronous event notification, the semaphore will be signaled to indicate pending events. On platforms that do not support asynchronous notifications about events, the UI will have to poll EventSensor periodically to read events from the VM. Instance variables: mouseButtons <Integer> - mouse button state as replacement for primMouseButtons mousePosition <Point> - mouse position as replacement for primMousePt keyboardBuffer <SharedQueue> - keyboard input buffer interruptKey <Integer> - currently defined interrupt key interruptSemaphore <Semaphore> - the semaphore signaled when the interruptKey is detected eventQueue <SharedQueue> - an optional event queue for event driven applications inputSemaphore <Semaphore>- the semaphore signaled by the VM if asynchronous event notification is supported lastEventPoll <Integer> - the last millisecondClockValue at which we called fetchMoreEvents hasInputSemaphore <Boolean> - true if my inputSemaphore has actually been signaled at least once. Class variables: ButtonDecodeTable <ByteArray> - maps mouse buttons as reported by the VM to ones reported in the events. KeyDecodeTable <Dictionary<SmallInteger->SmallInteger>> - maps some keys and their modifiers to other keys (used for instance to map Ctrl-X to Alt-X) InterruptSemaphore <Semaphore> - signalled by the the VM and/or the event loop upon receiving an interrupt keystroke. InterruptWatcherProcess <Process> - waits on the InterruptSemaphore and then responds as appropriate. EventPollPeriod <Integer> - the number of milliseconds to wait between polling for more events in the userInterruptHandler. EventTicklerProcess <Process> - the process that makes sure that events are polled for often enough (at least every EventPollPeriod milliseconds). Event format: The current event format is very simple. Each event is recorded into an 8 element array. All events must provide some SmallInteger ID (the first field in the event buffer) and a time stamp (the second field in the event buffer), so that the difference between the time stamp of an event and the current time can be reported. Currently, the following events are defined: Null event ============= The Null event is returned when the ST side asks for more events but no more events are available. Structure: [1] - event type 0 [2-8] - unused Mouse event structure ========================== Mouse events are generated when mouse input is detected. [1] - event type 1 [2] - time stamp [3] - mouse x position [4] - mouse y position [5] - button state; bitfield with the following entries: 1 - 2r001 yellow (e.g., right) button 2 - 2r010 blue (e.g., middle) button 4 - 2r100 red (e.g., left) button [all other bits are currently undefined] [6] - modifier keys; bitfield with the following entries: 1 - shift key 2 - ctrl key 4 - (Mac specific) option key 8 - Cmd/Alt key [all other bits are currently undefined] [7] - reserved. [8] - host window id. Keyboard events ==================== Keyboard events are generated when keyboard input is detected. [1] - event type 2 [2] - time stamp [3] - character code (Ascii) For now the character code is in Mac Roman encoding. See #macToSqueak. For key press/release (see [4]), character codes are normalized. [4] - press state; integer with the following meaning 0 - character (aka. key stroke or key still pressed) 1 - key press (aka. key down) 2 - key release (aka. key up) [5] - modifier keys (same as in mouse events) For key press/release (see [4]), modifier keys are still accessible. [6] - character code (Unicode UTF32) Manual decoding via KeyboardInputInterpreter possible. For key press/release (see [4]), character codes are normalized. [7] - reserved. [8] - host window id. Mouse-wheel event structure ========================== Mouse-wheel events are generated when mouse-wheel input is detected. [1] - event type 7 [2] - time stamp [3] - horizontal scroll delta [4] - vertical scroll delta [5] - button state (same as in mouse events) [6] - modifier keys (same as in mouse events) [7] - reserved. [8] - host window id. ! Item was changed: ----- Method: EventSensor>>fetchMoreEvents (in category 'private-I/O') ----- fetchMoreEvents "Fetch more events from the VM" | eventBuffer type | - "Reset input semaphore so clients can wait for the next events after this one." - inputSemaphore isSignaled - ifTrue: [ hasInputSemaphore := true. - inputSemaphore initSignals ]. - "Remember the last time that I checked for events." lastEventPoll := Time millisecondClockValue. eventBuffer := Array new: 8. [self primGetNextEvent: eventBuffer. type := eventBuffer at: 1. type = EventTypeNone] whileFalse: [self processEvent: eventBuffer]. ! Item was changed: ----- Method: EventSensor>>initialize (in category 'initialize') ----- initialize "Initialize the receiver" mouseButtons := 0. mousePosition := 0 @ 0. mouseWheelDelta := 0 @ 0. keyboardBuffer := SharedQueue new. self setInterruptKey: (interruptKey ifNil: [$. asciiValue bitOr: 16r0800 ]). "cmd-." interruptSemaphore := (Smalltalk specialObjectsArray at: 31) ifNil: [Semaphore new]. + self flushAllButDandDEvents.! - self flushAllButDandDEvents. - inputSemaphore := Semaphore new. - hasInputSemaphore := false.! Item was removed: - ----- Method: EventSensor>>primSetInputSemaphore: (in category 'private-I/O') ----- - primSetInputSemaphore: semaIndex - "Set the input semaphore the VM should use for asynchronously signaling the availability of events. Primitive. Optional." - <primitive: 93> - ^nil! Item was changed: ----- Method: EventSensor>>shutDown (in category 'initialize') ----- shutDown InterruptWatcherProcess ifNotNil: [ InterruptWatcherProcess terminate. InterruptWatcherProcess := nil ]. EventTicklerProcess ifNotNil: [ EventTicklerProcess terminate. + EventTicklerProcess := nil. ].! - EventTicklerProcess := nil. ]. - - inputSemaphore ifNotNil:[Smalltalk unregisterExternalObject: inputSemaphore].! Item was changed: ----- Method: EventSensor>>startUp (in category 'initialize') ----- startUp self initialize. - self primSetInputSemaphore: (Smalltalk registerExternalObject: inputSemaphore). self installInterruptWatcher. self installEventTickler. + Smalltalk isMorphic ifTrue: [self flushAllButDandDEvents].! - Smalltalk isMorphic ifTrue: [self flushAllButDandDEvents]. - - "Attempt to discover whether the input semaphore is actually being signaled." - hasInputSemaphore := false. - inputSemaphore initSignals.!

7 13

The Inbox: Collections-ul.873.mcz
by commits＠source.squeak.org 06 Feb '20

06 Feb '20

Levente Uzonyi uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ul.873.mcz ==================== Summary ==================== Name: Collections-ul.873 Author: ul Time: 5 February 2020, 4:29:23.449183 pm UUID: fc9428f9-07fc-43fb-90b0-dc7368b64cec Ancestors: Collections-ul.872 HashedCollection changes: - speed up #goodPrimeAtLeast: when its argument is small - let #sizeFor: return the smallest possible capacity (3) - use #sizeFor: instead of #goodPrimeAtLeast: in #compact. This fixes the case when a 4 element dictionary is compacted to 80% capacity (array size = 5), which is higher than the advertised maximum: 75%. - fixed the formula in #sizeFor:, which made the shortcut for small values unnecessary. Removed the shortcut. The fix often yields smaller dictionaries. - store good primes in a class variable GoodPrimes for faster access and possible customization - use blocks instead of symbols in #compactAll and #rehashAll - introduced #slowSize in HashedCollection, which makes it possible to not override #growSize and #compact in weak subclasses =============== Diff against Collections-ul.872 =============== Item was changed: Collection subclass: #HashedCollection instanceVariableNames: 'tally array' + classVariableNames: 'GoodPrimes' - classVariableNames: '' poolDictionaries: '' category: 'Collections-Abstract'! !HashedCollection commentStamp: 'ul 4/12/2010 22:37' prior: 0! I am an abstract collection of objects that implement hash and equality in a consitent way. This means that whenever two objects are equal, their hashes have to be equal too. If two objects are equal then I can only store one of them. Hashes are expected to be integers (preferably SmallIntegers). I also expect that the objects contained by me do not change their hashes. If that happens, hash invariants have to be re-established, which can be done by #rehash. Since I'm abstract, no instances of me should exist. My subclasses should implement #scanFor:, #fixCollisionsFrom: and #noCheckNoGrowFillFrom:. Instance Variables array: <ArrayedCollection> (typically Array or WeakArray) tally: <Integer> (non-negative) array - An array whose size is a prime number, it's non-nil elements are the elements of the collection, and whose nil elements are empty slots. There is always at least one nil. In fact I try to keep my "load" at 75% or less so that hashing will work well. tally - The number of elements in the collection. The array size is always greater than this. Implementation details: I implement a hash table which uses open addressing with linear probing as the method of collision resolution. Searching for an element or a free slot for an element is done by #scanFor: which should return the index of the slot in array corresponding to it's argument. When an element is removed #fixCollisionsFrom: should rehash all elements in array between the original index of the removed element, wrapping around after the last slot until reaching an empty slot. My maximum load factor (75%) is hardcoded in #atNewIndex:put:, so it can only be changed by overriding that method. When my load factor reaches this limit I replace my array with a larger one (see #grow) ensuring that my load factor will be less than or equal to 50%. The new array is filled by #noCheckNoGrowFillFrom: which should use #scanForEmptySlotFor: instead of #scanFor: for better performance. I do not shrink. ! Item was changed: ----- Method: HashedCollection class>>compactAll (in category 'initialize-release') ----- compactAll "HashedCollection compactAll" + self allSubclassesDo: [ :each | each compactAllInstances ]! - self allSubclassesDo: #compactAllInstances! Item was changed: ----- Method: HashedCollection class>>goodPrimeAtLeast: (in category 'sizing') ----- goodPrimeAtLeast: lowerLimit + "Answer the smallest good prime >= lowerlimit. + If lowerLimit is larger than the largest known good prime, just make it odd. + Use linear search, and exponential search to speed up cases when lowerLimit is small (<2500 and <100000, respectively). + Assume that there are goodPrimes greater than 100000." - "Answer the next good prime >= lowerlimit. - If lowerLimit is larger than the largest known good prime, - just make it odd." + | highIndex midIndex lowIndex prime | + lowerLimit <= 7 ifTrue: [ + lowerLimit <= 3 ifTrue: [ ^3 ]. + lowerLimit <= 5 ifTrue: [ ^5 ]. + ^7 ]. + GoodPrimes ifNil: [ "migration only" + self initializeGoodPrimes ]. + lowerLimit < 2500 ifTrue: [ + "Use linear search when the limit is small. The boundary is based on measurements." + highIndex := 4. "skip 3 5 and 7" + [ (GoodPrimes at: highIndex) < lowerLimit ] whileTrue: [ + highIndex := highIndex + 1 ]. + ^GoodPrimes at: highIndex ]. + lowerLimit < 100000 + ifTrue: [ + "Use exponential search when the limit is not too large. The boundary is based on measurements." + highIndex := 1. + [ (GoodPrimes at: highIndex) < lowerLimit ] whileTrue: [ + highIndex := highIndex * 2 ]. + lowIndex := highIndex // 2 + 1. "highIndex // 2 was smaller than lowerLimit" ] + ifFalse: [ + "Regular binary search." + lowIndex := 1. + highIndex := GoodPrimes size. + "Check whether the largest prime would fit" + (GoodPrimes at: highIndex) < lowerLimit ifTrue: [ + ^lowerLimit bitOr: 1 ]. ]. + [ highIndex - lowIndex <= 1 ] whileFalse: [ + midIndex := highIndex + lowIndex // 2. + prime := GoodPrimes at: midIndex. - | low mid high prime primes | - primes := self goodPrimes. - high := primes size. - lowerLimit > (primes at: high) ifTrue: [ - ^lowerLimit bitOr: 1 ]. - low := 1. - [ high - low <= 1 ] whileFalse: [ - mid := high + low // 2. - prime := primes at: mid. lowerLimit < prime + ifTrue: [ highIndex := midIndex ] - ifTrue: [ high := mid ] ifFalse: [ lowerLimit > prime + ifTrue: [ lowIndex := midIndex ] - ifTrue: [ low := mid ] ifFalse: [ ^prime ] ] ]. + (GoodPrimes at: lowIndex) >= lowerLimit ifTrue: [ ^GoodPrimes at: lowIndex ]. + ^GoodPrimes at: highIndex! - (primes at: low) >= lowerLimit ifTrue: [ ^primes at: low ]. - ^primes at: high! Item was changed: ----- Method: HashedCollection class>>goodPrimes (in category 'sizing') ----- goodPrimes + "Answer a sorted array of prime numbers less than one billion that make good hash table sizes. See #initializeGoodPrimes." - "Answer a sorted array of prime numbers less than one billion that make good - hash table sizes. Should be expanded as needed. See comments below code" + ^GoodPrimes ifNil: [ + self initializeGoodPrimes. + GoodPrimes ]! - ^#(3 5 7 11 13 17 23 31 43 59 79 107 149 199 269 359 479 641 857 1151 1549 2069 - 2237 2423 2617 2797 2999 3167 3359 3539 3727 3911 - 4441 4787 5119 5471 5801 6143 6521 6827 7177 7517 7853 - 8783 9601 10243 10867 11549 12239 12919 13679 14293 15013 15731 - 17569 19051 20443 21767 23159 24611 25847 27397 28571 30047 31397 - 35771 38201 40841 43973 46633 48989 51631 54371 57349 60139 62969 - 70589 76091 80347 85843 90697 95791 101051 106261 111143 115777 120691 126311 - 140863 150523 160969 170557 181243 190717 201653 211891 221251 232591 242873 251443 - 282089 300869 321949 341227 362353 383681 401411 422927 443231 464951 482033 504011 - 562621 605779 647659 681607 723623 763307 808261 844709 886163 926623 967229 1014617 - 1121987 1201469 1268789 1345651 1429531 1492177 1577839 1651547 1722601 1800377 1878623 1942141 2028401 - 2242727 2399581 2559173 2686813 2836357 3005579 3144971 3283993 3460133 3582923 3757093 3903769 4061261 - 4455361 4783837 5068529 5418079 5680243 6000023 6292981 6611497 6884641 7211599 7514189 7798313 8077189 - 9031853 9612721 10226107 10745291 11338417 11939203 12567671 13212697 13816333 14337529 14938571 15595673 16147291 - 17851577 18993941 20180239 21228533 22375079 23450491 24635579 25683871 26850101 27921689 29090911 30153841 31292507 32467307 - 35817611 37983761 40234253 42457253 44750177 46957969 49175831 51442639 53726417 55954637 58126987 60365939 62666977 64826669 - 71582779 76039231 80534381 84995153 89500331 93956777 98470819 102879613 107400389 111856841 116365721 120819287 125246581 129732203 - 143163379 152076289 161031319 169981667 179000669 187913573 196826447 205826729 214748357 223713691 232679021 241591901 250504801 259470131 - 285162679 301939921 318717121 335494331 352271573 369148753 385926017 402603193 419480419 436157621 453034849 469712051 486589307 503366497 520043707 - 570475349 603929813 637584271 671138659 704693081 738247541 771801929 805356457 838910803 872365267 905919671 939574117 973128521 1006682977 1040137411 - 1073741833) - - "The above primes past 2069 were chosen carefully so that they do not interact badly with 1664525 (used by hashMultiply), and so that gcd(p, (256^k) +/- a) = 1, for 0<a<=32 and 0<k<=8. See Knuth's TAOCP for details." - - "The above primes also try to map the values of ((0 to: 4095) collect: [ :each | each << 18 \\ prime ]) sort to an equidistant sequence of numbers. This helps to avoid the collision of chains in identity-based hashed collections. To do that they were chosen to return a low value when the following block is evaluated with them as argument: - [ :prime | - | n slots cost optimalDistance | - n := 1 bitShift: 22. - slots := Array new: n + 1. - 0 to: n - 1 do: [ :ea | slots at: ea + 1 put: (ea bitShift: 8) \\ prime ]. - slots at: n + 1 put: prime. - slots sort. - cost := 0. - optimalDistance := prime // n. - 2 to: n + 1 do: [ :index | - | newCost | - newCost := optimalDistance - ((slots at: index) - (slots at: index - 1)). - newCost > cost ifTrue: [ cost := newCost ] ]. - result add: prime -> cost ] - - The shifts in the block relate to the numer of bits the #identityHash consists of (22) and the number of bits #scaledIdentityHash shifts it (8)"! Item was added: + ----- Method: HashedCollection class>>initialize (in category 'sizing') ----- + initialize + + self initializeGoodPrimes! Item was added: + ----- Method: HashedCollection class>>initializeGoodPrimes (in category 'sizing') ----- + initializeGoodPrimes + "GoodPrimes is a sorted array of prime numbers less than one billion that make good hash table sizes. Should be expanded as needed. See comments below code." + + GoodPrimes := #(3 5 7 11 13 17 23 31 43 59 79 107 149 199 269 359 479 641 857 1151 1549 2069 + 2237 2423 2617 2797 2999 3167 3359 3539 3727 3911 + 4441 4787 5119 5471 5801 6143 6521 6827 7177 7517 7853 + 8783 9601 10243 10867 11549 12239 12919 13679 14293 15013 15731 + 17569 19051 20443 21767 23159 24611 25847 27397 28571 30047 31397 + 35771 38201 40841 43973 46633 48989 51631 54371 57349 60139 62969 + 70589 76091 80347 85843 90697 95791 101051 106261 111143 115777 120691 126311 + 140863 150523 160969 170557 181243 190717 201653 211891 221251 232591 242873 251443 + 282089 300869 321949 341227 362353 383681 401411 422927 443231 464951 482033 504011 + 562621 605779 647659 681607 723623 763307 808261 844709 886163 926623 967229 1014617 + 1121987 1201469 1268789 1345651 1429531 1492177 1577839 1651547 1722601 1800377 1878623 1942141 2028401 + 2242727 2399581 2559173 2686813 2836357 3005579 3144971 3283993 3460133 3582923 3757093 3903769 4061261 + 4455361 4783837 5068529 5418079 5680243 6000023 6292981 6611497 6884641 7211599 7514189 7798313 8077189 + 9031853 9612721 10226107 10745291 11338417 11939203 12567671 13212697 13816333 14337529 14938571 15595673 16147291 + 17851577 18993941 20180239 21228533 22375079 23450491 24635579 25683871 26850101 27921689 29090911 30153841 31292507 32467307 + 35817611 37983761 40234253 42457253 44750177 46957969 49175831 51442639 53726417 55954637 58126987 60365939 62666977 64826669 + 71582779 76039231 80534381 84995153 89500331 93956777 98470819 102879613 107400389 111856841 116365721 120819287 125246581 129732203 + 143163379 152076289 161031319 169981667 179000669 187913573 196826447 205826729 214748357 223713691 232679021 241591901 250504801 259470131 + 285162679 301939921 318717121 335494331 352271573 369148753 385926017 402603193 419480419 436157621 453034849 469712051 486589307 503366497 520043707 + 570475349 603929813 637584271 671138659 704693081 738247541 771801929 805356457 838910803 872365267 905919671 939574117 973128521 1006682977 1040137411 + 1073741833) + + "The above primes past 2069 were chosen carefully so that they do not interact badly with 1664525 (used by hashMultiply), and so that gcd(p, (256^k) +/- a) = 1, for 0<a<=32 and 0<k<=8. See Knuth's TAOCP for details." + + "The above primes also try to map the values of ((0 to: 4095) collect: [ :each | each << 18 \\ prime ]) sort to an equidistant sequence of numbers. This helps to avoid the collision of chains in identity-based hashed collections. To do that they were chosen to return a low value when the following block is evaluated with them as argument: + [ :prime | + | n slots cost optimalDistance | + n := 1 bitShift: 22. + slots := Array new: n + 1. + 0 to: n - 1 do: [ :ea | slots at: ea + 1 put: (ea bitShift: 8) \\ prime ]. + slots at: n + 1 put: prime. + slots sort. + cost := 0. + optimalDistance := prime // n. + 2 to: n + 1 do: [ :index | + | newCost | + newCost := optimalDistance - ((slots at: index) - (slots at: index - 1)). + newCost > cost ifTrue: [ cost := newCost ] ]. + result add: prime -> cost ] + + The shifts in the block relate to the numer of bits the #identityHash consists of (22) and the number of bits #scaledIdentityHash shifts it (8)"! Item was changed: ----- Method: HashedCollection class>>new (in category 'instance creation') ----- new + "Create a HashedCollection large enough to hold 3 different objects without growing." + + ^self basicNew initialize: 5 "For performance, inline the value 5 which would normally be returned by #sizeFor:."! - ^ self basicNew initialize: 5! Item was changed: ----- Method: HashedCollection class>>new: (in category 'instance creation') ----- + new: numberOfElements + "Create a HashedCollection large enough to hold numberOfElements different objects without growing." + + ^self basicNew initialize: (numberOfElements <= 3 + ifFalse: [ self sizeFor: numberOfElements ] + ifTrue: [ "Inline values returned by #sizeFor: to ensure that #new: is not significantly slower than #new for small values." + numberOfElements < 3 + ifTrue: [ 3 ] + ifFalse: [ 5 ] ])! - new: nElements - "Create a Set large enough to hold nElements without growing" - ^ self basicNew initialize: (self sizeFor: nElements)! Item was changed: ----- Method: HashedCollection class>>rehashAll (in category 'initialize-release') ----- rehashAll "HashedCollection rehashAll" + self allSubclassesDo: [ :each | each rehashAllInstances ]! - self allSubclassesDo: #rehashAllInstances! Item was changed: ----- Method: HashedCollection class>>sizeFor: (in category 'sizing') ----- + sizeFor: numberOfElements + "Return a large enough prime (or odd if too large), the size of the internal array to hold numberOfElements with at most 75% load factor." - sizeFor: nElements - "Large enough prime (or odd if too large) size to hold nElements with some slop (see fullCheck)" + ^self goodPrimeAtLeast: numberOfElements * 4 + 2 // 3 "Optimized version of (numberOfElements * 4 / 3) ceiling."! - nElements < 4 ifTrue: [ ^5 ]. - ^self goodPrimeAtLeast: nElements + 1 * 4 // 3! Item was changed: ----- Method: HashedCollection>>compact (in category 'private') ----- compact "Reduce the size of array so that the load factor will be ~75%." | newCapacity | + newCapacity := self class sizeFor: self slowSize. - newCapacity := self class goodPrimeAtLeast: tally * 4 // 3. self growTo: newCapacity! Item was changed: ----- Method: HashedCollection>>growSize (in category 'private') ----- growSize "Answer what my next higher table size should be" + ^self class sizeFor: self slowSize * 2! - ^self class goodPrimeAtLeast: array size * 3 // 2 + 2! Item was added: + ----- Method: HashedCollection>>slowSize (in category 'accessing') ----- + slowSize + "Answer an upper bound of the number of elements in this collection. For regular collections, this can simply be the value of tally, but for collections that cannot maintain an exact value, like current weak collections, this has to be calculated on the fly." + + ^tally! Item was removed: - ----- Method: WeakIdentityDictionary>>compact (in category 'private') ----- - compact - "Reduce the size of array so that the load factor will be ~75%." - - | newCapacity | - tally := self slowSize. - newCapacity := self class goodPrimeAtLeast: tally * 4 // 3. - self growTo: newCapacity! Item was removed: - ----- Method: WeakKeyDictionary>>compact (in category 'private') ----- - compact - "Reduce the size of array so that the load factor will be ~75%." - - | newCapacity | - newCapacity := self class goodPrimeAtLeast: self slowSize * 4 // 3. - self growTo: newCapacity! Item was removed: - ----- Method: WeakKeyDictionary>>growSize (in category 'private') ----- - growSize - "Answer what my next table size should be. - Note that, it can be less than the current." - - ^self class goodPrimeAtLeast: self slowSize * 2 + 2! Item was removed: - ----- Method: WeakSet>>compact (in category 'private') ----- - compact - "Reduce the size of array so that the load factor will be ~75%." - - | newCapacity | - newCapacity := self class goodPrimeAtLeast: self slowSize * 4 // 3. - self growTo: newCapacity! Item was removed: - ----- Method: WeakSet>>growSize (in category 'private') ----- - growSize - "Answer what my next table size should be. - Note that, it can be less than the current." - - ^self class goodPrimeAtLeast: self slowSize * 2 + 2!

2 1

variable assignments button (again)
by Ralph Boland 05 Feb '20

05 Feb '20

I forgot to add in my previous post that the buttons I added also operate (without crashing) on selected local variables in the debugger. This of course doesn't make any sense and can be considered a bug. But fixing this was too much touble so I didn't try. Ralph Boland

1 0

Jump to page: