Squeak-dev February 2020

squeak-dev@lists.squeakfoundation.org

32 participants
305 discussions

#shouldBeImplemented vs #notYetImplemented
by Thiede, Christoph 08 Feb '20

08 Feb '20

Hi all, what exactly is the intended difference between #shouldBeImplemented and #notYetImplemented? It feels a bit confusing. I have always used #shouldBeImplemented only because it is predefined by the Debugger. But today I met #notYetImplemented and now wonder which one I should use: <http://www.hpi.de/> * Both are detected by the debugger * But #notYetImplemented has its own subclass implementation of NotImplemented which handles #receiverClass and #selector. I like this, it has a bit more object-orientation appeal. * The names don't give me an indication to any semantical difference * They are not in the same message category of Object at all! * #shouldBeImplemented raises a specific error message, while that one of #notYetImplemented is generic and less precise * But why does the #shouldBeImpleemented message mention "or a superclass should implement"? Given the subclass Bar of the superclass Foo and I compile '#baz ^self shouldBeImplemented' on Bar. Why should this indicate that #baz might have to implemented on Foo instead? * Btw, we also have Object >> #required, which looks more Trait specific. Is it a problem that Tools-Debugger depends on Traits via this selector? However, I think we might have some heterogenic duplication here, or at least miss any documentation of the differences. Can you tell me more about the history of both selectors? Should we try to merge them? Best, Christoph

4 6

The Inbox: Protocols-jr.71.mcz
by commits＠source.squeak.org 08 Feb '20

08 Feb '20

A new version of Protocols was added to project The Inbox: http://source.squeak.org/inbox/Protocols-jr.71.mcz ==================== Summary ==================== Name: Protocols-jr.71 Author: jr Time: 8 February 2020, 4:11:06.177789 pm UUID: 705d6a77-0b95-1147-9bd9-68f9cab27c59 Ancestors: Protocols-jr.70 Fix the 'follow' button for inherited methods. =============== Diff against Protocols-jr.70 =============== Item was changed: ----- Method: Lexicon>>selectImplementedMessageAndEvaluate: (in category 'selection') ----- selectImplementedMessageAndEvaluate: aBlock "Allow the user to choose one selector, chosen from the currently selected message's selector, as well as those of all messages sent by it, and evaluate aBlock on behalf of chosen selector. If there is only one possible choice, simply make it; if there are multiple choices, put up a menu, and evaluate aBlock on behalf of the the chosen selector, doing nothing if the user declines to choose any. In this variant, only selectors " | selector method messages | (selector := self selectedMessageName) ifNil: [^ self]. method := (self selectedClassOrMetaClass ifNil: [^ self]) + lookupSelector: selector. - compiledMethodAt: selector - ifAbsent: []. (method isNil or: [(messages := method messages) size = 0]) ifTrue: [^ aBlock value: selector]. (messages size = 1 and: [messages includes: selector]) ifTrue: [^ aBlock value: selector]. "If only one item, there is no choice" messages := messages select: [:aSelector | currentVocabulary includesSelector: aSelector forInstance: self targetObject ofClass: targetClass limitClass: limitClass]. self systemNavigation showMenuOf: messages withFirstItem: selector ifChosenDo: aBlock!

1 0

The Inbox: Protocols-jr.70.mcz
by commits＠source.squeak.org 08 Feb '20

08 Feb '20

A new version of Protocols was added to project The Inbox: http://source.squeak.org/inbox/Protocols-jr.70.mcz ==================== Summary ==================== Name: Protocols-jr.70 Author: jr Time: 8 February 2020, 4:08:08.736789 pm UUID: 928804bd-3a8c-1b44-909f-70f1da3e7814 Ancestors: Protocols-jr.69 Evaluate do-its in Lexicon from the point of view of the browsed class, not the class of the currently selected method. This allows you to use pools or class variables from subclasses while writing code that you will later accept into the browsed class (instead of replacing the method in the selectedClass). =============== Diff against Protocols-jr.69 =============== Item was changed: ----- Method: Lexicon>>doItReceiver (in category 'model glue') ----- doItReceiver "This class's classPool has been jimmied to be the classPool of the class being browsed. A doIt in the code pane will let the user see the value of the class variables. Here, if the receiver is affiliated with a specific instance, we give give that primacy" + ^ self targetObject ifNil: [self targetClass]! - ^ self targetObject ifNil: [self selectedClass]!

1 0

The Inbox: Tools-jr.931.mcz
by commits＠source.squeak.org 08 Feb '20

08 Feb '20

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jr.931.mcz ==================== Summary ==================== Name: Tools-jr.931 Author: jr Time: 8 February 2020, 4:04:49.220789 pm UUID: 0aeedbc2-1c66-254f-aea4-c4ed08d7b753 Ancestors: Tools-jr.930 Also look up icons for selectors in superclasses. This brings back icons for inherited methods in Lexicon if you loaded Protocols-jr.69. =============== Diff against Tools-jr.930 =============== Item was changed: ----- Method: Behavior>>toolIconSelector: (in category '*Tools-icons') ----- toolIconSelector: aSymbol "Tools can annotate the method identified by aSymbol with an icon identified by the symbol this method returns. We customize this for, eg, overriden methods or methods with breaks. Defaults to no icon" self methodDictionary at: aSymbol ifPresent: [ :method | method hasBreakpoint ifTrue: [^ #breakpoint]. method messagesDo: [:messageSelector | (#(halt halt: haltIfNil haltIf: haltOnce haltOnce: haltOnCount: halt:onCount: break) includes: messageSelector) ifTrue: [^ #breakpoint]. (#(flag: needsWork notYetImplemented) includes: messageSelector) ifTrue: [^ #flag]. (#(shouldBeImplemented subclassResponsibility) includes: messageSelector) ifTrue: [ (self isSelectorOverridden: aSymbol) ifTrue: [^ #abstract] ifFalse: [^ #notOverridden]]. messageSelector == #shouldNotImplement ifTrue: [^ #no]]. method hasReportableSlip ifTrue: [^ #breakpoint]]. (self isSelectorOverride: aSymbol) ifTrue: [ (self isSelectorOverridden: aSymbol) ifTrue: [ ^ #arrowUpAndDown ] ifFalse: [ ^ #arrowUp ] ] ifFalse: [ (self isSelectorOverridden: aSymbol) ifTrue: [^ #arrowDown ]]. self methodDictionary at: aSymbol ifPresent: [ :method | (method primitive ~= 0 and: [method isQuick not]) ifTrue: [^ #primitive]]. + (self includesSelector: aSymbol) ifFalse: + [(self lookupSelector: aSymbol) ifNotNil: [ :method | + ^ method methodClass toolIconSelector: method selector]]. ^ #blank!

1 0

The Inbox: Protocols-jr.69.mcz
by commits＠source.squeak.org 08 Feb '20

08 Feb '20

A new version of Protocols was added to project The Inbox: http://source.squeak.org/inbox/Protocols-jr.69.mcz ==================== Summary ==================== Name: Protocols-jr.69 Author: jr Time: 8 February 2020, 4:03:45.579789 pm UUID: 390c7867-e2be-bb4a-b78a-502305ab6c7d Ancestors: Protocols-eem.68 Display test result icons for tests inherited from abstract test superclasses. Try it by browsing protocol (p) of any subclass of ClassTestCase or MCRepositoryTest. =============== Diff against Protocols-eem.68 =============== Item was changed: ----- Method: Lexicon>>messageIconAt: (in category 'message list') ----- messageIconAt: anIndex Browser showMessageIcons ifFalse: [^ nil]. self class parse: (self messageList at: anIndex) toClassAndSelector: [:class :selector | ^ ToolIcons iconNamed: (ToolIcons + iconForClass: targetClass - iconForClass: class selector: selector)]. ^ nil!

1 0

The Inbox: Morphic-kfr.1619.mcz
by commits＠source.squeak.org 08 Feb '20

08 Feb '20

1 0

The Inbox: Morphic-kfr.1619.mcz
by commits＠source.squeak.org 08 Feb '20

08 Feb '20

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-kfr.1619.mcz ==================== Summary ==================== Name: Morphic-kfr.1619 Author: kfr Time: 7 February 2020, 11:38:33.017512 pm UUID: 7e9d5c46-aad5-ed46-b88d-22f30b5f597f Ancestors: Morphic-cmm.1618 Enhancement for PolygonMorph. When a vertex is dropped it will snap if it is close to another PolygonMorphs vertex. It is possible to toggle functionality on/ off in menu. ( With suggestion from Christoph Thiede about basing snapping distance on screen resolution) =============== Diff against Morphic-cmm.1618 =============== Item was changed: BorderedMorph subclass: #PolygonMorph + instanceVariableNames: 'vertices closed filledForm arrows arrowForms smoothCurve curveState borderDashSpec handles borderForm snapToOtherPolygons' - instanceVariableNames: 'vertices closed filledForm arrows arrowForms smoothCurve curveState borderDashSpec handles borderForm' classVariableNames: '' poolDictionaries: '' category: 'Morphic-Basic'! !PolygonMorph commentStamp: 'md 2/24/2006 20:34' prior: 0! This class implements a morph which can behave as four different objects depending on the the following two facts: - is it OPEN or CLOSED? - is it SEGMENTED or SMOOTHED. 1. The OPEN and SEGMENTED variant looks like polyline. 2. The OPEN and SMOOTHED variant looks like spline (kind of curve) 3. The CLOSED and SEGMENTED variant looks like polygon. This is actually what you get when you do PolygonMorph new openInWorld You get a triangle. See below how to manipulate these objects... 4. The CLOSED and SMOOTHED variant looks like blob (???) Prototypes of this morph can also be found in "Object Catalog". Several (different variants) of this object are among "Basic" morphs. Explore the assiciated morph-menu. It enables you - to toggle showing of "handles". They make it possible to - reposition already existing vertices (by moving yellow handles) - create new vertices (by moving green handles) - delete already existing vertices (by dragging and dropping one yellow handle closely nearby the adjacent yellow handle Handles can be made visible/hidden by shift+leftclicking the morph. This way it is possible to quickly show handles, adjust vertices and then again hide handles. - making closed polygon open, i.e. converting it to a curve (and vice versa) - toggle smoothed/segmented line/outline - set up custom dashing (for line, curves or borders of closed polygons - set up custom arrow-heads (for lines resp. curves) ------------------------------------------------------------------------------------------ Implementation notes: This class combines the old Polygon and Curve classes. The 1-bit fillForm to make display and containment tests reasonably fast. However, this functionality is in the process of being supplanted by balloon capabilities, which should eventually provide anti-aliasing as well. wiz 7/18/2004 21:26 s have made some changes to this class to 1) correct some bugs associated with one vertex polygons. 2) prepare for some enhancements with new curves. 3) add shaping items to menu.! Item was changed: ----- Method: PolygonMorph>>addCustomMenuItems:hand: (in category 'menu') ----- addCustomMenuItems: aMenu hand: aHandMorph "Add morph-specific items to the given menu which was invoked by the given hand. This method provides is invoked both from the halo-menu and from the control-menu regimes." super addCustomMenuItems: aMenu hand: aHandMorph. aMenu addUpdating: #handlesShowingPhrase target: self action: #showOrHideHandles. vertices size > 2 ifTrue: [aMenu addUpdating: #openOrClosePhrase target: self action: #makeOpenOrClosed]. aMenu addUpdating: #smoothPhrase target: self action: #toggleSmoothing. + aMenu addUpdating: #snapToOtherPolygonPhrase target: self action: #toggleSnapToOtherPolygons. aMenu addLine. aMenu add: 'specify dashed line' translated action: #specifyDashedLine. self isOpen ifTrue: [aMenu addLine. aMenu addWithLabel: '---' enablement: [self isOpen and: [arrows ~~ #none]] action: #makeNoArrows. aMenu addWithLabel: '-->' enablement: [self isOpen and: [arrows ~~ #forward]] action: #makeForwardArrow. aMenu addWithLabel: '<--' enablement: [self isOpen and: [arrows ~~ #back]] action: #makeBackArrow. aMenu addWithLabel: '<->' enablement: [self isOpen and: [arrows ~~ #both]] action: #makeBothArrows. aMenu add: 'customize arrows' translated action: #customizeArrows:. (self hasProperty: #arrowSpec) ifTrue: [aMenu add: 'standard arrows' translated action: #standardArrows]].! Item was changed: ----- Method: PolygonMorph>>dropVertex:event:fromHandle: (in category 'editing') ----- + dropVertex: ix event: evt fromHandle: handle + "Leave vertex in new position. If dropped ontop another vertex delete + this one. - dropVertex: ix event: evt fromHandle: handle - "Leave vertex in new position. If dropped ontop another vertex delete this one. Check for too few vertices before deleting. The alternative + is not pretty -wiz" + | p nearestOwner distance | - is not pretty -wiz" - | p | p := vertices at: ix. + distance := (3 * RealEstateAgent scaleFactor). + "snap the dropped vertex to a vertex of another PolygonMorph if it is in near proximity" + self isSnappingToOtherPolygons + ifTrue: [nearestOwner := self ownerThatIsA: PasteUpMorph. + nearestOwner submorphs + do: [:each | ((each respondsTo: #vertices) + and: [each ~= self]) + ifTrue: [each vertices + do: [:otherMorphsVertex | (otherMorphsVertex dist: p) + < distance + ifTrue: [vertices at: ix put: otherMorphsVertex]]]]]. (vertices size >= 2 and: ["check for too few vertices before deleting. The alternative is not pretty -wiz" ((vertices atWrap: ix - 1) dist: p) + < distance - < 3 or: [((vertices atWrap: ix + 1) dist: p) + < distance]]) - < 3]]) ifTrue: ["Drag a vertex onto its neighbor means delete" + self deleteVertexAt: ix]. - self deleteVertexAt: ix .]. evt shiftPressed ifTrue: [self removeHandles] ifFalse: [self addHandles "remove then add to recreate"]! Item was changed: ----- Method: PolygonMorph>>initialize (in category 'initialization') ----- initialize "initialize the state of the receiver" super initialize. "" vertices := Array with: 5 @ 0 with: 20 @ 10 with: 0 @ 20. closed := true. smoothCurve := false. arrows := #none. + snapToOtherPolygons := false. self computeBounds! Item was added: + ----- Method: PolygonMorph>>isSnappingToOtherPolygons (in category 'access') ----- + isSnappingToOtherPolygons + ^snapToOtherPolygons ifNil:[ snapToOtherPolygons := false]. + ! Item was added: + ----- Method: PolygonMorph>>snapToOtherPolygonPhrase (in category 'menu') ----- + snapToOtherPolygonPhrase + "Answer a string characterizing whether my vertices should snap to another polygons vertices." + + ^ (self isSnappingToOtherPolygons ifTrue: ['<yes>'] ifFalse: ['<no>']), 'snap to other polygons' translated ! Item was added: + ----- Method: PolygonMorph>>toggleSnapToOtherPolygons (in category 'menu') ----- + toggleSnapToOtherPolygons + ^snapToOtherPolygons := snapToOtherPolygons not!

2 1

variable assignments button/hotkeys (again)
by Ralph Boland 07 Feb '20

07 Feb '20

Not long ago I posted about the variable assignments button. It generated an interesting discussion but I don't think in the end it will result in any change to the operation of Squeak. Let me make a slight variation on this discussion. In the Inspector/Debugger the instance variables of the class being inspected are displayed in a window and any one of these variables can be selected/inspected. Then using a menu or hotkey one can invoke: StringHolder>>browseVariableReferences or StringHolder>>browseVariableAssignments These commands bring up a selection window where one chooses one of the instance variables of the class of the selected variable. Then one of the methods above is invoked on the instance variable you chose. This was counterintuitive to me so I added two new menu-items/hotkeys: ('selected variable references... (u)' browseSelectedVariableReferences) and ('selected variable assignments... (A)' browseSelectedVariableAssignments) These commands act like the cooresponding previous commands except that, instead of bringing up a selection window for the user to select the variable to use, the selected variable of the class being inspected is used (and the class being inspected is used instead of the class of the selected variable). This feature is more intuitive to me and I have found it quite useful. I have attached the necessary code as .st files in case anybody would like to try it out. These are filed out from Linux but I assume they load as is to Windows or Mac. Feel free to make any changes you feel necessary and if it gets added to the next version of Squeak, great! If you try it out let me know what you think. Thanks for reading Ralph Boland rpboland(a)gmail.com

4 6

The Inbox: Collections-ul.874.mcz
by commits＠source.squeak.org 07 Feb '20

07 Feb '20

Levente Uzonyi uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ul.874.mcz ==================== Summary ==================== Name: Collections-ul.874 Author: ul Time: 5 February 2020, 4:40:30.240914 pm UUID: de45f7ed-0176-48ed-b7d5-3811cbc0fcb9 Ancestors: Collections-ul.873 - remove cruft and migration code from HashedCollection class >> #goodPrimeAtLeast: =============== Diff against Collections-ul.873 =============== Item was changed: ----- Method: HashedCollection class>>goodPrimeAtLeast: (in category 'sizing') ----- goodPrimeAtLeast: lowerLimit "Answer the smallest good prime >= lowerlimit. If lowerLimit is larger than the largest known good prime, just make it odd. Use linear search, and exponential search to speed up cases when lowerLimit is small (<2500 and <100000, respectively). Assume that there are goodPrimes greater than 100000." | highIndex midIndex lowIndex prime | - lowerLimit <= 7 ifTrue: [ - lowerLimit <= 3 ifTrue: [ ^3 ]. - lowerLimit <= 5 ifTrue: [ ^5 ]. - ^7 ]. - GoodPrimes ifNil: [ "migration only" - self initializeGoodPrimes ]. lowerLimit < 2500 ifTrue: [ "Use linear search when the limit is small. The boundary is based on measurements." + highIndex := 1. - highIndex := 4. "skip 3 5 and 7" [ (GoodPrimes at: highIndex) < lowerLimit ] whileTrue: [ highIndex := highIndex + 1 ]. ^GoodPrimes at: highIndex ]. lowerLimit < 100000 ifTrue: [ "Use exponential search when the limit is not too large. The boundary is based on measurements." highIndex := 1. [ (GoodPrimes at: highIndex) < lowerLimit ] whileTrue: [ highIndex := highIndex * 2 ]. lowIndex := highIndex // 2 + 1. "highIndex // 2 was smaller than lowerLimit" ] ifFalse: [ "Regular binary search." lowIndex := 1. highIndex := GoodPrimes size. "Check whether the largest prime would fit" (GoodPrimes at: highIndex) < lowerLimit ifTrue: [ ^lowerLimit bitOr: 1 ]. ]. [ highIndex - lowIndex <= 1 ] whileFalse: [ midIndex := highIndex + lowIndex // 2. prime := GoodPrimes at: midIndex. lowerLimit < prime ifTrue: [ highIndex := midIndex ] ifFalse: [ lowerLimit > prime ifTrue: [ lowIndex := midIndex ] ifFalse: [ ^prime ] ] ]. (GoodPrimes at: lowIndex) >= lowerLimit ifTrue: [ ^GoodPrimes at: lowIndex ]. ^GoodPrimes at: highIndex!

3 2

EToys unloading
by tim Rowledge 06 Feb '20

06 Feb '20

Just to put it on the record somewhere - unloading EToys from a 5.2/3 image is currently impossible due to the intrusion of some EToys/OLPC code into DisplayScreen class>checkForNewScreenSize. The attached .cs solves that problem and cleans up a a bit of ugly mvc/morphic fudging. There are a lot of other bits needing cleaning up but at least this lets the unload happen. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful Latin Phrases:- Utinam logica falsa tuam philosophiam totam suffodiant! = May faulty logic undermine your entire philosophy!

2 2

Jump to page: