Squeak-dev January 2020

squeak-dev@lists.squeakfoundation.org

43 participants
227 discussions

The Trunk: Tools-mt.929.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.929.mcz ==================== Summary ==================== Name: Tools-mt.929 Author: mt Time: 6 January 2020, 11:04:06.99743 am UUID: 471886c1-f1a6-164d-95ed-c0847e2a2b4e Ancestors: Tools-cmm.928 Fixes text-scroll behavior for debuggers in too-small windows with too-big fonts. :-) Note that this is just a workaround for the 5.3 release. =============== Diff against Tools-cmm.928 =============== Item was changed: ----- Method: Debugger>>contentsSelection (in category 'code pane') ----- contentsSelection + "Reverse the selection (i.e., point block and mark block) to put the text cursor at the beginning to ensure visibility of the beginning in small windows." + + self flag: #tofix. "mt: See http://forum.world.st/The-Inbox-Morphic-cmm-1615-mcz-td5109271.html and http://forum.world.st/stepping-in-small-panes-td5109239.html." + ^ self pcRange in: [:interval | + interval last + 1 to: interval first - 1]! - - ^ self pcRange!

1 0

The Trunk: PreferenceBrowser-mt.98.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Marcel Taeumel uploaded a new version of PreferenceBrowser to project The Trunk: http://source.squeak.org/trunk/PreferenceBrowser-mt.98.mcz ==================== Summary ==================== Name: PreferenceBrowser-mt.98 Author: mt Time: 6 January 2020, 10:38:28.56543 am UUID: 6a346053-7cb7-7140-a884-4e1440a97e6c Ancestors: PreferenceBrowser-mt.97 Slightly improves the button-bar-layout in the preference browser for small window sizes. It behaves similar to the bars in other browsers now. =============== Diff against PreferenceBrowser-mt.97 =============== Item was changed: ----- Method: PreferenceBrowserMorph>>basicButton (in category 'submorphs - buttons') ----- basicButton ^ PluggableButtonMorph new model: self model; offColor: self paneColor; + hResizing: #spaceFill; + layoutInset: 4; - hResizing: #shrinkWrap; - layoutInset: (15@5 corner: 15@5); yourself!

1 0

5.3 odd mouseDown / mouseOver state crosses widget boundaries now
by Chris Muller 06 Jan '20

06 Jan '20

Some odd behavior not present in 5.2. Not overly serious, but still "feels" odd... 1) browse implementors of #at: 2) with hand in upper pane, click select + drag downward, the hand into the lower pane 3) if traceMessages is on, notice the text selection in the lower pane! 4) with traceMessages off, instead of text selection, it does nothing, but when red button is released, the list continued to scroll "invisibly".

3 2

The Trunk: Morphic-mt.1615.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1615.mcz ==================== Summary ==================== Name: Morphic-mt.1615 Author: mt Time: 6 January 2020, 10:17:52.75843 am UUID: 24a18424-814a-df44-a3d6-d7678f2be6ba Ancestors: Morphic-mt.1614 Fixes two selection bugs lists and alternate-multi-selection lists. =============== Diff against Morphic-mt.1614 =============== Item was added: + ----- Method: AlternatePluggableListMorphOfMany>>mouseLeaveDragging: (in category 'event handling') ----- + mouseLeaveDragging: anEvent + "Dragging means changing the list's multi-selection state. Thus, there is no support for drag-and-drop of elements within a selection." + + self hoverRow: nil. + self resetPotentialDropRow.! Item was changed: ----- Method: PluggableListMorph>>mouseUp: (in category 'event handling') ----- mouseUp: event | row | model okToChange ifFalse: [^ self]. + (self containsPoint: event position) ifFalse: [^ self]. row := self rowAtLocation: event position. row = self selectionIndex ifTrue: [(autoDeselect ifNil: [true]) ifTrue: [row = 0 ifFalse: [self changeModelSelection: 0] ]] ifFalse: [self changeModelSelection: (self modelIndexFor: row)]. event hand newKeyboardFocus: self. hasFocus := true. Cursor normal show.!

1 0

The Trunk: Collections-fn.869.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Fabio Niephaus uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-fn.869.mcz ==================== Summary ==================== Name: Collections-fn.869 Author: fn Time: 3 January 2020, 10:27:08.945712 am UUID: c29ef38b-f152-468e-bac9-74515c099ac4 Ancestors: Collections-nice.868 Add quick-check for identity to String>>sameAs: (similar to Character>>sameAs:). Example: [MenuIcons smallInspectItIconContents sameAs: MenuIcons smallInspectItIconContents] bench Before: 1,740,000 per second. 574 nanoseconds per run. 0 % GC time. After: 94,800,000 per second. 10.5 nanoseconds per run. 0 % GC time. =============== Diff against Collections-nice.868 =============== Item was changed: ----- Method: String>>sameAs: (in category 'comparing') ----- sameAs: aString "Answer whether the receiver sorts equal to aString. The collation sequence is ascii with case differences ignored." + self == aString ifTrue: [ ^true ]. ^(self compare: aString caseSensitive: false) = 2!

7 8

The Trunk: Morphic-mt.1614.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1614.mcz ==================== Summary ==================== Name: Morphic-mt.1614 Author: mt Time: 6 January 2020, 9:50:42.01643 am UUID: b543c96f-fa29-f541-8090-03270590d39b Ancestors: Morphic-mt.1613 Fixes point-size selection bug in FontChooserTool. =============== Diff against Morphic-mt.1613 =============== Item was changed: ----- Method: FontChooserTool>>selectedPointSizeIndex: (in category 'point size') ----- selectedPointSizeIndex: anIndex anIndex = 0 ifTrue: [^self]. pointSize := (self pointSizeList at: anIndex) withBlanksTrimmed asNumber. + self changed: #selectedPointSizeIndex. self changed: #pointSizeList. self changed: #contents.!

1 0

The Trunk: Morphic-mt.1613.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1613.mcz ==================== Summary ==================== Name: Morphic-mt.1613 Author: mt Time: 6 January 2020, 9:41:04.49243 am UUID: 45d4b3c8-b251-2544-9e7e-411c30c1c217 Ancestors: Morphic-mt.1612 Fixes the updating bug in string morph. Clarifies some related code, too. Thanks to Stéphane (spfa), Karl (kfr), and Dave (dtl) for the hints and suggestions! =============== Diff against Morphic-mt.1612 =============== Item was changed: ----- Method: StringMorph>>contents: (in category 'accessing') ----- contents: newContents newContents isText ifTrue: [^ self initializeFromText: newContents]. contents = newContents + ifTrue: [^ self "No substantive change."]. - ifTrue: [^ self "no substantive change"]. contents := newContents. + self changed. "New contents need to be drawn." + + self fitContents. "Resize if necessary."! - - self fitContents.! Item was changed: ----- Method: StringMorph>>fitContents (in category 'layout') ----- fitContents + self extent: self measureContents.! - | newBounds boundsChanged | - newBounds := self measureContents. - boundsChanged := bounds extent ~= newBounds. - self extent: newBounds. "default short-circuits if bounds not changed" - boundsChanged ifFalse: [self changed]! Item was changed: ----- Method: UpdatingStringMorph>>fitContents (in category 'layout') ----- fitContents + "Overridden to respect minimum and maximum widfth." + - | newExtent | + newExtent := self measureContents. + self extent: ((newExtent x max: self minimumWidth) min: self maximumWidth) @ newExtent y.! - newExtent := self measureContents. - newExtent := ((newExtent x max: self minimumWidth) min: self maximumWidth) @ newExtent y. - (self extent = newExtent) ifFalse: - [self extent: newExtent. - self changed] - ! Item was changed: ----- Method: UpdatingStringMorph>>updateContentsFrom: (in category 'stepping') ----- updateContentsFrom: aValue self growable ifTrue: + [self contentsFitted: aValue] - [self contents: aValue] ifFalse: [self contentsClipped: aValue]!

2 1

BUG: UpdatingStringMorph broken in 5.3 (take 2)
by Stéphane Rollandin 06 Jan '20

06 Jan '20

Hello, As I already indicated one week ago, UpdatingStringMorph is currently broken in trunk. If you do (UpdatingStringMorph on: Time selector: #now) openInWorld. you will see that the display is not consistently updated as it should via the #step method. This can be fixed by adding a #changed in StringMorph>>#contents: as follow: StringMorph>>#contents: newContents newContents isText ifTrue: [^ self initializeFromText: newContents]. contents = newContents ifTrue: [^ self "no substantive change"]. contents := newContents. self fitContents; changed Now maybe the #changed should be added to #fitContents itself. Stef

4 4

Just another debugger bug - primitive 19
by Thiede, Christoph 05 Jan '20

05 Jan '20

Hi all, I cannot stop having fun with the debugger & context implementation :D So here is what I found today ... Steps to reproduce: Debug it and step "into" #newProcess : [self yourself] newProcess Expected behavior: You want to see something like this: [cid:c2902b39-4733-465a-aa91-25b25aac1331] Actual behavior: [cid:5d1c5dc0-b65f-43a5-a351-aba397f57327] Explanation: See Context >> #doPrimitive:method:receiver:args: Quote: "Judicious use of primitive 19 (a null primitive that doesn't do anything) prevents the debugger from entering various run-away activities such as spawning a new process, etc. Injudicious use results in the debugger not being able to debug interesting code, such as the debugger itself. Hence use primitive 19 with care :-)" With respect to this statement, #newProcess (which only *creates* an object), should not really use this primitive, should it? Why isn't this simulation error rather raised at primitive 87 (#resume)? Or rather, why does this error need to be raised at all when, for example, you debug the forking of a process? In general, can you tell me any example where primitive 19 is necessary indeed? So far I could not find one. A common scenario in which I stumble upon it is when I try to step "through" the following: [self halt] fork. If I disable primitive 19 in #newProcess, this accident does not occur, instead, the new process just runs asynchronously. Feels more intuitive for me. Even in MVC, everything I could imagine worked fine without the primitive. Is it possible that primitive 19 comes from an age when the debugging mechanism had not yet evolved to today's capabilities? Anyway, I would be glad to hear some story about it :-) Best, Christoph

1 0

The Inbox: Collections-cmm.870.mcz
by commits＠source.squeak.org 05 Jan '20

05 Jan '20

Chris Muller uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-cmm.870.mcz ==================== Summary ==================== Name: Collections-cmm.870 Author: cmm Time: 4 January 2020, 4:08:57.317384 pm UUID: c4bf7594-c44e-4d02-9956-2b727d2eb75b Ancestors: Collections-fn.869, Collections-ul.867 Tweak ul.867 so that: Dictionary new: 3 is not significantly slower than: Dictionary new =============== Diff against Collections-fn.869 =============== Item was changed: ----- Method: HashedCollection class>>goodPrimeAtLeast: (in category 'sizing') ----- goodPrimeAtLeast: lowerLimit + "Answer the smallest good prime >= lowerlimit. + If lowerLimit is larger than the largest known good prime, just make it odd. + Use linear search, and exponential search to speed up cases when lowerLimit is small (<2500 and <100000, respectively)." - "Answer the next good prime >= lowerlimit. - If lowerLimit is larger than the largest known good prime, - just make it odd." + | high mid low prime primes | - | low mid high prime primes | primes := self goodPrimes. + (primes at: primes size) < lowerLimit ifTrue: [ - high := primes size. - lowerLimit > (primes at: high) ifTrue: [ ^lowerLimit bitOr: 1 ]. + lowerLimit < 2500 ifTrue: [ + "Use linear search when the limit is small. The boundary is based on measurements." + high := 1. + [ + (prime := primes at: high) >= lowerLimit ifTrue: [ ^prime ]. + high := high + 1 ] repeat ]. + lowerLimit < 100000 + ifTrue: [ + "Use exponential search when the limit is not too large. The boundary is based on measurements." + high := 1. + [ (primes at: high) < lowerLimit ] whileTrue: [ + high := high * 2 ]. + low := high // 2 + 1. "high // 2 was smaller than lowerLimit" ] + ifFalse: [ + "Regular binary search." + low := 1. + high := primes size ]. - low := 1. [ high - low <= 1 ] whileFalse: [ mid := high + low // 2. prime := primes at: mid. lowerLimit < prime ifTrue: [ high := mid ] ifFalse: [ lowerLimit > prime ifTrue: [ low := mid ] ifFalse: [ ^prime ] ] ]. (primes at: low) >= lowerLimit ifTrue: [ ^primes at: low ]. ^primes at: high! Item was changed: ----- Method: HashedCollection>>compact (in category 'private') ----- compact "Reduce the size of array so that the load factor will be ~75%." | newCapacity | + newCapacity := self class sizeFor: tally. - newCapacity := self class goodPrimeAtLeast: tally * 4 // 3. self growTo: newCapacity!

3 5

Jump to page: