Squeak-dev January 2020

squeak-dev@lists.squeakfoundation.org

43 participants
227 discussions

5.3 font size selection bug
by Chris Muller 06 Jan '20

06 Jan '20

Appearance... | system fonts... | button font... | then click on one of the point sizes in the righthand pane. Although it appears to register the click, the list selection does not update. Arrows too, no effect...

3 4

The Trunk: Installer-Core-cmm.436.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Chris Muller uploaded a new version of Installer-Core to project The Trunk: http://source.squeak.org/trunk/Installer-Core-cmm.436.mcz ==================== Summary ==================== Name: Installer-Core-cmm.436 Author: cmm Time: 29 December 2019, 3:17:54.157994 pm UUID: c3706d14-bd0d-4556-8044-9265bd05e651 Ancestors: Installer-Core-mt.434 Include package-definitions for a GraphQL engine expected in Q1/2020, and targeted for Squeak 5.3. =============== Diff against Installer-Core-mt.434 =============== Item was added: + ----- Method: Installer>>graphQlCore (in category 'package-definitions') ----- + graphQlCore + ^ { #ss -> 'graphql'. + 'GraphQL-Core' }! Item was added: + ----- Method: Installer>>graphQlEngine (in category 'package-definitions') ----- + graphQlEngine + ^ { self graphQlCore. + 'GraphQL-Engine' }! Item was added: + ----- Method: Installer>>graphQlSmalltalkEngine (in category 'package-definitions') ----- + graphQlSmalltalkEngine + ^ { self graphQlEngine. + 'GraphQL-SmalltalkEngine' }! Item was added: + ----- Method: Installer>>graphQlTestsCore (in category 'package-definitions') ----- + graphQlTestsCore + ^ { self graphQlCore. + 'GraphQL-Tests-Core' }! Item was added: + ----- Method: Installer>>graphQlTestsEngine (in category 'package-definitions') ----- + graphQlTestsEngine + ^ { self graphQlEngine. + self graphQlTestsCore. + 'GraphQL-Tests-Engine' }!

3 2

The Trunk: Graphics-mt.406.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.406.mcz ==================== Summary ==================== Name: Graphics-mt.406 Author: mt Time: 17 January 2019, 11:18:39.003727 am UUID: 027d00a7-113d-4b9f-aaec-79e3373339c1 Ancestors: Graphics-mt.405 Adds an informative string representation for LayoutFrame to support layout design and debugging. =============== Diff against Graphics-mt.405 =============== Item was added: + ----- Method: LayoutFrame>>printOn: (in category 'printing') ----- + printOn: aStream + + super printOn: aStream. + + aStream nextPutAll: '( '. + + { {'l'. self leftFraction. self leftOffset}. {'t'. self topFraction. self topOffset}. {'r'. self rightFraction. self rightOffset}. {'b'. self bottomFraction. self bottomOffset} } do: [:spec | + aStream nextPutAll: spec first; space. + + spec second printOn: aStream maxDecimalPlaces: 2. + + aStream nextPutAll: ((spec third ifNil: [0]) >= 0 ifTrue: ['+'] ifFalse: ['-']). + (spec third ifNil: [0]) abs printOn: aStream maxDecimalPlaces: 0] + separatedBy: [aStream space]. + + aStream nextPutAll: ' )'.!

3 2

Obsolete classes
by Nicolas Cellier 06 Jan '20

06 Jan '20

Hi all, I noticed two obsolete classes related to Preferences. They disappear if evaluating: PreferenceViewRegistry removeObsolete. I did not see that in ReleaseBuilder, is it missing? Or should we just put that in package postscript?

3 2

The Inbox: ToolBuilder-Kernel-tpr.135.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

A new version of ToolBuilder-Kernel was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Kernel-tpr.135.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-tpr.135 Author: tpr Time: 31 December 2019, 1:38:05.296265 pm UUID: 85fb4bde-73a1-4dde-b7c2-bec1821f90eb Ancestors: ToolBuilder-Kernel-mt.134 change the default position for progress bars to slightly below the center of the screen. This should at least help with cases where a notifier/conformer/informer pops up during a large package load and gets hidden behind the progress bar morph. The Rectangle method should probably be moved back to Graphics-Primitives but by including it here we can avoid the potential for a dNU whilst loading this. =============== Diff against ToolBuilder-Kernel-mt.134 =============== Item was changed: ----- Method: ProgressInitiationException class>>preferredProgressBarPosition (in category 'accessing') ----- preferredProgressBarPosition + ^ PreferredProgressBarPosition ifNil: [ #belowCenter ]! - ^ PreferredProgressBarPosition ifNil: [ #center ]! Item was added: + ----- Method: Rectangle>>belowCenter (in category '*ToolBuilder-Kernel-accessing') ----- + belowCenter + "Answer the point slightly below the center of the receiver. This is a good candidate spot for progress morphs to default to since it leaves room to see any other dialogues that default to screen center" + + ^self topLeft + self bottomRight // (2(a)1.7)!

2 1

The Inbox: Morphic-tpr.1616.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-tpr.1616.mcz ==================== Summary ==================== Name: Morphic-tpr.1616 Author: tpr Time: 31 December 2019, 1:43:56.638985 pm UUID: 4b649df1-02a9-4b01-a27b-da8e9a9b543a Ancestors: Morphic-nice.1615 prevent the requested position from chaging if the progress bar is already open and in use; this should stop it leapingabout the screen like someone being pursued by angry Bees =============== Diff against Morphic-nice.1615 =============== Item was changed: ----- Method: SystemProgressMorph>>requestedPosition: (in category 'accessing') ----- requestedPosition: anObject + "only change the progress bar position if this is an occasion when the progress bar is opening with a single active bar. After that we don't want to change the position and leap around the screen" + activeSlots < 1 ifTrue:[ requestedPosition := anObject]! - - requestedPosition := anObject!

2 1

Do I really have to configure the inbox repository for each single package?
by Thiede, Christoph 06 Jan '20

06 Jan '20

Hi all, in the meantime, I probably have a really boring question for you: Is there any way to configure the inbox repo once for all Squeak packages? (Of course, there is a way, but I can't find it.) I am strictly following the instructions from the wiki<https://wiki.squeak.org/squeak/6545> to create the repository, but it does not appear for any trunk package: [cid:dd02894b-b726-43d1-a6b6-9815c3e0dc19] (no package selected) [cid:e30f6a1d-ff79-4f7b-ae0c-5c539bc8ba57] (MorphicTests selected) I admit that in all the time, I was too lazy to ask this questions so I added the repository again and again, for each single package I needed ... This probably isn't the right way to do it, is it? How can I enter the inbox repo code once for all packages? Thanks in advance, Christoph

6 11

The Inbox: Morphic-cmm.1614.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Chris Muller uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-cmm.1614.mcz ==================== Summary ==================== Name: Morphic-cmm.1614 Author: cmm Time: 1 January 2020, 8:31:35.610123 pm UUID: 563f11e4-b784-40b6-af72-03338e6069ad Ancestors: Morphic-mt.1612 When a text selection cannot fit into its text pane, show its upper-left, rather than its lower-right, so stepping through code in a small window is possible. =============== Diff against Morphic-mt.1612 =============== Item was changed: ----- Method: PluggableTextMorph>>scrollSelectionIntoView: (in category 'editor access') ----- scrollSelectionIntoView: event "Scroll my text into view. Due to line composition mechanism, we must never use the right of a character block because the lines last character block right value always comes from a global container and is *not* line specific." + self flag: #fixIntervalCache. + "mt: We should find a better design for discarding unused text editors in text morphs and restoring them on demand." - - self flag: #fixIntervalCache. "mt: We should find a better design for discarding unused text editors in text morphs and restoring them on demand." selectionInterval := textMorph editor markIndex to: textMorph editor pointIndex - 1. + self scrollToShow: + (textMorph editor hasSelection + ifTrue: [ textMorph editor startBlock topLeft corner: textMorph editor stopBlock bottomLeft ] + ifFalse: [ textMorph editor startBlock withWidth: 1 ]). - - textMorph editor hasSelection - ifFalse: [self scrollToShow: (textMorph editor startBlock withWidth: 1)] - ifTrue: [ - self scrollToShow: (textMorph editor startBlock topLeft corner: textMorph editor stopBlock bottomLeft). - self scrollToShow: (textMorph editor pointBlock withWidth: 1). "Ensure text cursor visibility."]. - ^ true! Item was changed: ----- Method: ScrollPane>>keyStroke: (in category 'event handling') ----- + keyStroke: aKeyboardEvent + "If pane is not empty, let the last submorph handle the event." + scroller submorphs ifNotEmpty: [ : subs | subs last keyStroke: aKeyboardEvent ]! - keyStroke: evt - "If pane is not empty, pass the event to the last submorph, - assuming it is the most appropriate recipient (!!)" - - scroller submorphs last keyStroke: evt! Item was changed: ----- Method: ScrollPane>>offsetToShow: (in category 'scrolling') ----- offsetToShow: aRectangle "Calculate the offset necessary to show the rectangle." | offset scrollRange target | self fullBounds. "We need updated bounds." offset := scroller offset. scrollRange := self hTotalScrollRange @ self vTotalScrollRange. "Normalize the incoming rectangle." target := + aRectangle left @ aRectangle top - (scroller width < aRectangle width - ifTrue: [offset x < aRectangle left "Coming from left?" - ifTrue: [aRectangle right - scroller width] - ifFalse: [aRectangle left]] - ifFalse: [aRectangle left]) - @ - (scroller height < aRectangle height - ifTrue: [offset y < aRectangle top "Coming from top?" - ifTrue: [aRectangle bottom - scroller height] - ifFalse: [aRectangle top]] - ifFalse: [aRectangle top]) corner: (scroller width < aRectangle width ifTrue: [offset x + scroller width > aRectangle right "Coming from right?" ifTrue: [aRectangle left + scroller width] ifFalse: [aRectangle right]] ifFalse: [aRectangle right]) @ (scroller height < aRectangle height ifTrue: [offset y + scroller height > aRectangle bottom "Coming from bottom?" ifTrue: [aRectangle top + scroller height] ifFalse: [aRectangle bottom]] ifFalse: [aRectangle bottom]). "Vertical Scrolling" - target top < offset y - ifTrue: [offset := offset x @ target top]. target bottom > (offset y + scroller height) ifTrue: [offset := offset x @ (target bottom - scroller height)]. + target top < offset y + ifTrue: [offset := offset x @ target top]. "Horizontal Scrolling" - target left < offset x - ifTrue: [offset := target left @ offset y]. target right > (offset x + scroller width) ifTrue: [offset := (target right - scroller width) @ offset y]. + target left < offset x + ifTrue: [offset := target left @ offset y]. ^ (offset min: scrollRange - scroller extent) max: 0@0!

2 1

The Inbox: Morphic-cmm.1615.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Chris Muller uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-cmm.1615.mcz ==================== Summary ==================== Name: Morphic-cmm.1615 Author: cmm Time: 2 January 2020, 3:55:29.150586 pm UUID: a6947cb4-e842-49ca-a8db-56b7f9f3241a Ancestors: Morphic-mt.1612 When a text selection cannot fit into its text pane, show its upper-left, rather than its lower-right, so stepping through code in a small window is possible. =============== Diff against Morphic-mt.1612 =============== Item was added: + ----- Method: MorphicEvent>>isUserInput (in category 'testing') ----- + isUserInput + ^ false! Item was changed: ----- Method: PluggableTextMorph>>handleEdit: (in category 'editor access') ----- handleEdit: editBlock | result | textMorph editor selectFrom: selectionInterval first to: selectionInterval last; model: model. "For, eg, evaluateSelection" result := textMorph handleEdit: editBlock. "Update selection after edit" + self scrollSelectionIntoView: UserInputEvent new. "Dummy event to control selection scrolling" - self scrollSelectionIntoView. ^ result! Item was changed: ----- Method: PluggableTextMorph>>scrollSelectionIntoView: (in category 'editor access') ----- + scrollSelectionIntoView: event - scrollSelectionIntoView: event "Scroll my text into view. Due to line composition mechanism, we must never use the right of a character block because the lines last character block right value always comes from a global container and is *not* line specific." + self flag: #fixIntervalCache. + "mt: We should find a better design for discarding unused text editors in text morphs and restoring them on demand." - - self flag: #fixIntervalCache. "mt: We should find a better design for discarding unused text editors in text morphs and restoring them on demand." selectionInterval := textMorph editor markIndex to: textMorph editor pointIndex - 1. + self scrollToShow: + (textMorph editor hasSelection + ifTrue: [ textMorph editor startBlock topLeft corner: textMorph editor stopBlock bottomLeft ] + ifFalse: [ textMorph editor startBlock withWidth: 1 ]). + (event notNil and: [ event isUserInput ]) ifTrue: + [ self scrollToShow: (textMorph editor pointBlock withWidth: 1) ]. - - textMorph editor hasSelection - ifFalse: [self scrollToShow: (textMorph editor startBlock withWidth: 1)] - ifTrue: [ - self scrollToShow: (textMorph editor startBlock topLeft corner: textMorph editor stopBlock bottomLeft). - self scrollToShow: (textMorph editor pointBlock withWidth: 1). "Ensure text cursor visibility."]. - ^ true! Item was changed: ----- Method: ScrollPane>>keyStroke: (in category 'event handling') ----- + keyStroke: aKeyboardEvent + "If pane is not empty, let the last submorph handle the event." + scroller submorphs ifNotEmpty: [ : subs | subs last keyStroke: aKeyboardEvent ]! - keyStroke: evt - "If pane is not empty, pass the event to the last submorph, - assuming it is the most appropriate recipient (!!)" - - scroller submorphs last keyStroke: evt! Item was changed: ----- Method: ScrollPane>>offsetToShow: (in category 'scrolling') ----- offsetToShow: aRectangle "Calculate the offset necessary to show the rectangle." | offset scrollRange target | self fullBounds. "We need updated bounds." offset := scroller offset. scrollRange := self hTotalScrollRange @ self vTotalScrollRange. "Normalize the incoming rectangle." target := + aRectangle left @ aRectangle top - (scroller width < aRectangle width - ifTrue: [offset x < aRectangle left "Coming from left?" - ifTrue: [aRectangle right - scroller width] - ifFalse: [aRectangle left]] - ifFalse: [aRectangle left]) - @ - (scroller height < aRectangle height - ifTrue: [offset y < aRectangle top "Coming from top?" - ifTrue: [aRectangle bottom - scroller height] - ifFalse: [aRectangle top]] - ifFalse: [aRectangle top]) corner: (scroller width < aRectangle width ifTrue: [offset x + scroller width > aRectangle right "Coming from right?" ifTrue: [aRectangle left + scroller width] ifFalse: [aRectangle right]] ifFalse: [aRectangle right]) @ (scroller height < aRectangle height ifTrue: [offset y + scroller height > aRectangle bottom "Coming from bottom?" ifTrue: [aRectangle top + scroller height] ifFalse: [aRectangle bottom]] ifFalse: [aRectangle bottom]). "Vertical Scrolling" - target top < offset y - ifTrue: [offset := offset x @ target top]. target bottom > (offset y + scroller height) ifTrue: [offset := offset x @ (target bottom - scroller height)]. + target top < offset y + ifTrue: [offset := offset x @ target top]. "Horizontal Scrolling" - target left < offset x - ifTrue: [offset := target left @ offset y]. target right > (offset x + scroller width) ifTrue: [offset := (target right - scroller width) @ offset y]. + target left < offset x + ifTrue: [offset := target left @ offset y]. ^ (offset min: scrollRange - scroller extent) max: 0@0! Item was changed: ----- Method: TextMorphForEditView>>keyStroke: (in category 'event handling') ----- keyStroke: evt | view | editView deleteBalloon. self editor model: editView model. "For evaluateSelection" view := editView. "Copy into temp for case of a self-mutating doit" (acceptOnCR and: [evt keyCharacter = Character cr]) ifTrue: [^ self editor accept]. view hasUserEdited: false. super keyStroke: evt. + view scrollSelectionIntoView: evt. - view scrollSelectionIntoView. view hasUserEdited ifTrue: [ view textEdited: self contents].! Item was added: + ----- Method: UserInputEvent>>isUserInput (in category 'testing') ----- + isUserInput + ^ true!

2 2

stepping in small panes
by Chris Muller 06 Jan '20

06 Jan '20

Hi all, When debugging on a small screen and a larger font, block expressions can easily overrun the size of the text pane. Currently when stepping, selecting a stack frame, clicking Where -- anything that changes the text selection, it positions you to the bottom. [image: show-bottom-sel.png] Unfortunately, this makes debugging cumbersome, because I need to see the beginning of the selection instead of the end, to know what I'm stepping through. [image: show-top-sel.png] I use soft wrap, so don't face any issue along the horizontal dimension, but for the same principle, Morphic-cmm.1614 treats it similarly. Before: [image: show-right-sel.png] VS [image: show-left-sel.png] What do you think? Preference-worthy? Best, Chris

3 4

Jump to page: