Squeak-dev September 2019

squeak-dev@lists.squeakfoundation.org

38 participants
356 discussions

The Trunk: Morphic-mt.1510.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1510.mcz ==================== Summary ==================== Name: Morphic-mt.1510 Author: mt Time: 26 August 2019, 3:57:09.414394 pm UUID: 1a066b5c-53d2-164a-980b-c331d3616e78 Ancestors: Morphic-dtl.1506, Morphic-kfr.1509 Merges Morphic-dtl.1506 and fixes some docking-bar-layout issues. :-) Note that I changed the wording to "Git Browser (click to install)" as well as the text in the confirmation dialog. Please review. If not automatically done, please update your world-dock instances via TheWorldMainDockingBar updateInstances. =============== Diff against Morphic-kfr.1509 =============== Item was removed: - ----- Method: DockingBarItemMorph>>updateLayoutInDockingBar (in category 'private') ----- - updateLayoutInDockingBar - - owner isVertical - ifTrue: [ - self hResizing: #spaceFill. - self vResizing: #shrinkWrap ] - ifFalse: [ - self hResizing: #shrinkWrap. - self vResizing: #spaceFill ].! Item was added: + ----- Method: DockingBarMorph>>addedMorph: (in category 'change reporting') ----- + addedMorph: aMorph + "Update the new morph's layout properties according to my orientation." + + aMorph isMenuItemMorph ifFalse: [^ self]. + + self isVertical + ifTrue: [ + aMorph hResizing: #spaceFill. + aMorph vResizing: #shrinkWrap ] + ifFalse: [ + aMorph hResizing: #shrinkWrap. + aMorph vResizing: #spaceFill ].! Item was removed: - ----- Method: MenuItemMorph>>ownerChanged (in category 'change reporting') ----- - ownerChanged - "The receiver's owner, some kind of a pasteup, has changed its - layout." - super ownerChanged. - self updateLayoutInDockingBar! Item was changed: ----- Method: TheWorldMainDockingBar>>gitInfrastructureMenuItemOn: (in category 'submenu - tools') ----- + gitInfrastructureMenuItemOn: menu + + menu addItem: [:item | + item + contents: ((Smalltalk hasClassNamed: #SquitBrowser) + ifTrue: ['Git Browser' translated] + ifFalse: ['Git Browser (click to install)' translated]); + help: 'Browse repositories on github.com' translated; + icon: (self colorIcon: ((Smalltalk classNamed: #SquitBrowser) ifNil: Model) + basicNew windowColorToUse); + target: self; + selector: #installAndOpenGitBrowser]! - gitInfrastructureMenuItemOn: menu - menu addItem: - [ : item | item - contents: 'Git Browser' translated ; - help: 'Browse repositories on github.com' translated ; - icon: (self colorIcon: Color lightGray) ; - target: Installer ; - selector: #installAndOpenGitBrowser ]! Item was added: + ----- Method: TheWorldMainDockingBar>>installAndOpenGitBrowser (in category 'menu actions') ----- + installAndOpenGitBrowser + + (Smalltalk hasClassNamed: #SquitBrowser) + ifFalse: [ (UIManager default + confirm: 'The Git infrastructure and browser is not yet installed.\\Do you want to install the Git Browser?\\(Note that this step requires an internet connection and\may take several minutes.)' withCRs translated + title: 'Confirm Installation Request' ) + ifTrue: [ Installer + ensureRecentMetacello; + installGitInfrastructure. + TheWorldMainDockingBar updateInstances ] + ifFalse: [ ^self ] ]. + (Smalltalk classNamed: #SquitBrowser) open. + ! Item was removed: - ----- Method: TheWorldMainDockingBar>>metacelloMenuItemOn: (in category 'submenu - tools') ----- - metacelloMenuItemOn: menu - menu addItem: - [ : item | item - contents: 'Metacello' translated ; - help: 'Install Metacello' translated ; - icon: (self colorIcon: Color lightGray) ; - target: Installer ; - selector: #ensureRecentMetacello ]! Item was changed: ----- Method: TheWorldMainDockingBar>>toolsMenuOn: (in category 'construction') ----- toolsMenuOn: aDockingBar aDockingBar addItem: [ :item | item contents: 'Tools' translated; addSubMenu: [ :menu | self browserMenuItemOn: menu; workspaceMenuItemOn: menu; transcriptMenuItemOn: menu; testRunnerMenuItemOn: menu; methodFinderMenuItemOn: menu; messageNamesMenuItemOn: menu. menu addLine. self simpleChangeSorterMenuItemOn: menu; dualChangeSorterMenuItemOn: menu; monticelloBrowserMenuItemOn: menu; monticelloConfigurationsMenuItemOn: menu ; - metacelloMenuItemOn: menu ; gitInfrastructureMenuItemOn: menu. menu addLine. self processBrowserMenuItemOn: menu; preferenceBrowserMenuItemOn: menu; fileListMenuItemOn: menu. ] ]!

2 1

The Inbox: Collections-ct.852.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.852.mcz ==================== Summary ==================== Name: Collections-ct.852 Author: ct Time: 3 September 2019, 2:10:41.062948 pm UUID: c4cd824f-ff9a-1041-97b4-df402b62e7b1 Ancestors: Collections-ct.851 Do not support Unicode numbers in format strings (see discussion about ancestor) =============== Diff against Collections-ct.851 =============== Item was changed: ----- Method: String>>format: (in category 'formatting') ----- format: arguments "format the receiver with arguments simplest example: 'foo {1} bar' format: {Date today}. complete example: '\{ \} \\ foo {1} bar {2}' format: {12. 'string'}. " ^self class new: self size * 11 // 10 streamContents: [ :output | | lastIndex nextIndex | lastIndex := 1. [ (nextIndex := self indexOfAnyOf: FormatCharacterSet startingAt: lastIndex) = 0 ] whileFalse: [ nextIndex = lastIndex ifFalse: [ output next: nextIndex - lastIndex putAll: self startingAt: lastIndex ]. (self at: nextIndex) caseOf: { [$\] -> [ output nextPut: (self at: (nextIndex := nextIndex + 1)) ]. [${] -> [ "Parse the index - a positive integer in base 10." | character collectionIndex | collectionIndex := 0. + [ (character := self at: (nextIndex := nextIndex + 1)) between: $0 and: $9 ] whileTrue: [ - [ (character := self at: (nextIndex := nextIndex + 1)) isDigit ] whileTrue: [ collectionIndex := collectionIndex * 10 + character digitValue ]. character = $} ifFalse: [ self error: '$} expected' ]. output nextPutAll: (arguments at: collectionIndex) asString ] }. lastIndex := nextIndex + 1 ]. lastIndex <= self size ifTrue: [ output next: self size - lastIndex + 1 putAll: self startingAt: lastIndex ] ]! Item was changed: ----- Method: Text>>format: (in category 'formatting') ----- format: arguments "format the receiver with arguments, respecting the format both of receiver and collection elements" ^self class new: self size * 11 // 10 streamContents: [ :output | | nextIndex | nextIndex := 1. [ nextIndex <= self size ] whileTrue: [ (self at: nextIndex) caseOf: { [$\] -> [ nextIndex := nextIndex + 1. output withAttributes: (runs at: nextIndex) do: [ output nextPut: (self at: nextIndex) ] ]. [${] -> [ "Parse the index - a positive integer in base 10." | character collectionIndex attributes | collectionIndex := 0. attributes := Set new. + [ (character := string at: (nextIndex := nextIndex + 1)) between: $0 and: $9 ] whileTrue: [ - [ (character := string at: (nextIndex := nextIndex + 1)) isDigit ] whileTrue: [ collectionIndex := collectionIndex * 10 + character digitValue. attributes addAll: (runs at: nextIndex) ]. character = $} ifFalse: [ self error: '$} expected' ]. output withAttributes: attributes do: [ output nextPutAll: (arguments at: collectionIndex) asStringOrText ] ] } otherwise: [ output withAttributes: (runs at: nextIndex) do: [ output nextPut: (self at: nextIndex) ] ]. nextIndex := nextIndex + 1 ] ]!

1 0

The Trunk: Tools-mt.881.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.881.mcz ==================== Summary ==================== Name: Tools-mt.881 Author: mt Time: 3 September 2019, 10:31:26.605063 am UUID: fcc8128d-6944-ff49-83b6-9ccd090e9e0f Ancestors: Tools-mt.880 Our lists render only the first character's emphasis for the entire string. Fix that for class-tree formatting. =============== Diff against Tools-mt.880 =============== Item was changed: ----- Method: Browser>>flattenHierarchyTree:on:indent:by:format: (in category 'class list') ----- flattenHierarchyTree: classHierarchy on: col indent: indent by: indentChars format: formatBlock "Recursively add to col the names in classHierarchy indenting to show the hierarchical relationship. Use indentChars to do the indenting: spaces, tabs, etc." | plusIndent | plusIndent := indentChars. classHierarchy do: [:assoc | | class childs label | class := assoc key. label := formatBlock value: class. label isText + ifTrue: [col add: (Text string: indent attributes: (label attributesAt: 1)), label] - ifTrue: [col add: indent asText, label] ifFalse: [col add: indent, label]. childs := assoc value. self flattenHierarchyTree: childs on: col indent: indent , plusIndent by: indentChars format: formatBlock]. ^ col!

1 0

The Trunk: SUnitGUI-mt.72.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Marcel Taeumel uploaded a new version of SUnitGUI to project The Trunk: http://source.squeak.org/trunk/SUnitGUI-mt.72.mcz ==================== Summary ==================== Name: SUnitGUI-mt.72 Author: mt Time: 3 September 2019, 9:04:53.468063 am UUID: 7a1aee8a-d3d3-b749-b2b9-647310559a1a Ancestors: SUnitGUI-mt.71 Fixes the class hierarchy in the test runner. Adds number of tests to the class labels. Needs Tools-mt.880. We might want to find a better place for tree-to-list flattening. Yet, this is not a new dependency from SUnitGUI to the tools package. =============== Diff against SUnitGUI-mt.71 =============== Item was changed: ----- Method: TestRunner>>classList (in category 'accessing-classes') ----- classList + + | helper | - | offset | classes isEmpty ifTrue: [ ^ classes ]. + + helper := Browser new. + ^ helper + flattenHierarchyTree: (helper createHierarchyTreeOf: classes) + on: OrderedCollection new + indent: '' + by: ' ' + format: [:class | class isAbstract + ifTrue: [class name asText addAttribute: TextEmphasis italic; yourself] + ifFalse: ['{1} ({2})' format: {class name. class allTestSelectors size}]]! - offset := classes first allSuperclasses size. - ^ classes collect: [ :each | | ident | - ident := String - new: 2 * (0 max: each allSuperclasses size - offset) - withAll: $ . - each isAbstract - ifFalse: [ ident , each name ] - ifTrue: [ - ident asText , each name asText - addAttribute: TextEmphasis italic; - yourself ] ].!

2 1

The Trunk: TraitsTests-mt.25.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Marcel Taeumel uploaded a new version of TraitsTests to project The Trunk: http://source.squeak.org/trunk/TraitsTests-mt.25.mcz ==================== Summary ==================== Name: TraitsTests-mt.25 Author: mt Time: 3 September 2019, 9:06:04.191063 am UUID: d6fb8946-072f-c94c-9c0b-3f3a1b80f502 Ancestors: TraitsTests-mt.24 Because of how test resources work, they will already be there when the test runs. =============== Diff against TraitsTests-mt.24 =============== Item was changed: ----- Method: TraitSystemTest>>testAllClassesAndTraits (in category 'testing') ----- testAllClassesAndTraits "self debug: #testAllClassesAndTraits" + | trait | - | trait previousClassesAndTraits previousClasses | - previousClassesAndTraits := Smalltalk allClassesAndTraits. - previousClasses := Smalltalk allClasses. trait := self t1. - self deny: (previousClassesAndTraits includes: trait). - self deny: (previousClasses includes: trait). - self assert: (Smalltalk allClassesAndTraits includes: trait). self deny: (Smalltalk allClasses includes: trait). !

1 0

The Trunk: Tools-mt.880.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.880.mcz ==================== Summary ==================== Name: Tools-mt.880 Author: mt Time: 3 September 2019, 9:03:13.138063 am UUID: 334585e8-af9b-db41-b6bf-b8ac4d0a7128 Ancestors: Tools-mt.879 Adds very simple support for formatting the class hierachy labels in the code browser. =============== Diff against Tools-mt.879 =============== Item was changed: ----- Method: Browser>>flattenHierarchyTree:on:indent:by: (in category 'class list') ----- flattenHierarchyTree: classHierarchy on: col indent: indent by: indentChars + ^ self + flattenHierarchyTree: classHierarchy + on: col + indent: indent + by: ' ' + format: [:class | class name]! - "Recursively add to col the names in classHierarchy indenting to show the hierarchical relationship. Use indentChars to do the indenting: spaces, tabs, etc." - | plusIndent | - plusIndent := indentChars. - classHierarchy do: [:assoc | - | class childs | - class := assoc key. - col add: indent , class name. - childs := assoc value. - self - flattenHierarchyTree: childs - on: col - indent: indent , plusIndent - by: indentChars]. - ^ col! Item was added: + ----- Method: Browser>>flattenHierarchyTree:on:indent:by:format: (in category 'class list') ----- + flattenHierarchyTree: classHierarchy on: col indent: indent by: indentChars format: formatBlock + "Recursively add to col the names in classHierarchy indenting to show the hierarchical relationship. Use indentChars to do the indenting: spaces, tabs, etc." + | plusIndent | + plusIndent := indentChars. + classHierarchy do: [:assoc | + | class childs label | + class := assoc key. + label := formatBlock value: class. + label isText + ifTrue: [col add: indent asText, label] + ifFalse: [col add: indent, label]. + childs := assoc value. + self + flattenHierarchyTree: childs + on: col + indent: indent , plusIndent + by: indentChars + format: formatBlock]. + ^ col!

1 0

The Trunk: TraitsTests-mt.24.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Marcel Taeumel uploaded a new version of TraitsTests to project The Trunk: http://source.squeak.org/trunk/TraitsTests-mt.24.mcz ==================== Summary ==================== Name: TraitsTests-mt.24 Author: mt Time: 3 September 2019, 8:32:08.723063 am UUID: 1a70eef8-61da-cb49-b67e-edb7358f5383 Ancestors: TraitsTests-mt.23 Speeds up tests a little bit more. Test resources are usually only set up once before all tests. Cache source files then, too. (Except for some traits tests which make the resource dirty. See TraitsResource class >> #resetIfDirty.) =============== Diff against TraitsTests-mt.23 =============== Item was changed: ----- Method: TraitsResource>>setUp (in category 'running') ----- setUp - "Please note, that most tests rely on this setup of traits and - classes - and that especially the order of the definitions matters." - "SetUpCount := SetUpCount + 1." + super setUp. + dirty := false. + + CurrentReadOnlySourceFiles cacheDuring: [ + SystemChangeNotifier uniqueInstance doSilently: [ + Utilities useAuthorInitials: self className during: [ + self setUpSilently]]].! - Utilities - useAuthorInitials: self className - during: [ - SystemChangeNotifier uniqueInstance doSilently: [ - self t1: (self createTraitNamed: #T1 uses: { }). - self t1 comment: 'I am the trait T1'. - self t2: (self createTraitNamed: #T2 uses: { }). - self t2 compile: 'm21 ^21' classified: #cat1. - self t2 compile: 'm22 ^22' classified: #cat2. - self t2 classSide compile: 'm2ClassSide: a ^a'. - self t3: (self createTraitNamed: #T3 uses: { }). - self t3 compile: 'm31 ^31' classified: #cat1. - self t3 compile: 'm32 ^32' classified: #cat2. - self t3 compile: 'm33 ^33' classified: #cat3. - self t4: (self createTraitNamed: #T4 uses: { (self t1). (self t2) }). - self t4 compile: 'm11 ^41' classified: #catX. "overrides T1>>m11" - self t4 compile: 'm42 ^42' classified: #cat2. - self t5: (self createTraitNamed: #T5 uses: self t1 + self t2). - self t5 compile: 'm51 ^super foo' classified: #cat1. - self t5 compile: 'm52 ^ self class bar' classified: #cat1. - self t5 compile: 'm53 ^ self class bar' classified: #cat1. - self t6: (self - createTraitNamed: #T6 - uses: (self t1 + (self t2 @ { (#m22Alias -> #m22) }))). - self c1: ( - self - createClassNamed: #C1 - superclass: Object - uses: { }). - self c1 compile: 'foo ^true' classified: #accessing. - self t1 compile: 'm11 ^11' classified: #cat1. - self t1 compile: 'm12 ^12' classified: #cat2. - self t1 compile: 'm13 ^self m12' classified: #cat3. - self c2: (self - createClassNamed: #C2 - superclass: self c1 - uses: self t5 - { #m11 }). - self c2 compile: 'foo ^false' classified: #private. - self c2 compile: 'bar ^self foo' classified: #private. - self setUpTrivialRequiresFixture. - self setUpTwoLevelRequiresFixture. - self setUpTranslatingRequiresFixture ] ]. - SystemChangeNotifier uniqueInstance notify: self ofAllSystemChangesUsing: #codeChangedEvent:! Item was added: + ----- Method: TraitsResource>>setUpSilently (in category 'running') ----- + setUpSilently + "Please note, that most tests rely on this setup of traits and + classes - and that especially the order of the definitions matters." + "SetUpCount := SetUpCount + 1." + + self t1: (self createTraitNamed: #T1 uses: { }). + self t1 comment: 'I am the trait T1'. + self t2: (self createTraitNamed: #T2 uses: { }). + self t2 compile: 'm21 ^21' classified: #cat1. + self t2 compile: 'm22 ^22' classified: #cat2. + self t2 classSide compile: 'm2ClassSide: a ^a'. + self t3: (self createTraitNamed: #T3 uses: { }). + self t3 compile: 'm31 ^31' classified: #cat1. + self t3 compile: 'm32 ^32' classified: #cat2. + self t3 compile: 'm33 ^33' classified: #cat3. + self t4: (self createTraitNamed: #T4 uses: { (self t1). (self t2) }). + self t4 compile: 'm11 ^41' classified: #catX. "overrides T1>>m11" + self t4 compile: 'm42 ^42' classified: #cat2. + self t5: (self createTraitNamed: #T5 uses: self t1 + self t2). + self t5 compile: 'm51 ^super foo' classified: #cat1. + self t5 compile: 'm52 ^ self class bar' classified: #cat1. + self t5 compile: 'm53 ^ self class bar' classified: #cat1. + self t6: (self + createTraitNamed: #T6 + uses: (self t1 + (self t2 @ { (#m22Alias -> #m22) }))). + self c1: ( + self + createClassNamed: #C1 + superclass: Object + uses: { }). + self c1 compile: 'foo ^true' classified: #accessing. + self t1 compile: 'm11 ^11' classified: #cat1. + self t1 compile: 'm12 ^12' classified: #cat2. + self t1 compile: 'm13 ^self m12' classified: #cat3. + self c2: (self + createClassNamed: #C2 + superclass: self c1 + uses: self t5 - { #m11 }). + self c2 compile: 'foo ^false' classified: #private. + self c2 compile: 'bar ^self foo' classified: #private. + + self setUpTrivialRequiresFixture. + self setUpTwoLevelRequiresFixture. + self setUpTranslatingRequiresFixture. + + SystemChangeNotifier uniqueInstance notify: self ofAllSystemChangesUsing: #codeChangedEvent:! Item was changed: ----- Method: TraitsResource>>tearDown (in category 'running') ----- tearDown + CurrentReadOnlySourceFiles cacheDuring: [ + SystemChangeNotifier uniqueInstance doSilently: [ + Utilities useAuthorInitials: self className during: [ + self tearDownSilently]]]. - SystemChangeNotifier uniqueInstance noMoreNotificationsFor: self. + super tearDown.! - SystemChangeNotifier uniqueInstance doSilently: [ - self createdClassesAndTraits do: - [:aClassOrTrait | | behaviorName | - behaviorName := aClassOrTrait name. - Smalltalk at: behaviorName - ifPresent: [:classOrTrait | classOrTrait removeFromSystem]. - ChangeSet current removeClassChanges: behaviorName] ]. - - createdClassesAndTraits := self t1: (self - t2: (self t3: (self - t4: (self t5: (self - t6: (self c1: (self - c2: (self c3: (self c4: (self c5: (self c6: (self c7: (self c8: nil)))))))))))))! Item was added: + ----- Method: TraitsResource>>tearDownSilently (in category 'running') ----- + tearDownSilently + + SystemChangeNotifier uniqueInstance noMoreNotificationsFor: self. + + self createdClassesAndTraits do: + [:aClassOrTrait | | behaviorName | + behaviorName := aClassOrTrait name. + Smalltalk at: behaviorName + ifPresent: [:classOrTrait | classOrTrait removeFromSystem]. + ChangeSet current removeClassChanges: behaviorName]. + + createdClassesAndTraits := self t1: (self + t2: (self t3: (self + t4: (self t5: (self + t6: (self c1: (self + c2: (self c3: (self c4: (self c5: (self c6: (self c7: (self c8: nil)))))))))))))!

1 0

CompiledMethod changed in debugger does not get reflected in the browser nor monticello
by tim Rowledge 03 Sep '19

03 Sep '19

OK, weird behaviour of the day - Loaded up the Refectoring tools tests; ran them. One failed because of Symbols not wanting to mutate - see RBSpellingRule>>#normalizeSelector: I fixed this in the debugger to convert the incoming selector to a String and all runs as expected. Yay! But. The change is not reflected in the system browser; RBSpellingRule>>#normalizeSelector: still reads as before. No change is detected in the MC browser. No change was added to the current changeset. In the changelist as accessed by 'Recover changes' my alteration can be found and has my initials and a suitable timestamp. Pretty sure that isn't how we want it. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim ..... REALITY.SYS Corrupted - Unable to recover Universe

2 1

[Squeak5.3a][18828][Test][User] SqueakHelp Metacello Getting Started // ProfStef not known
by H. Hirzel 02 Sep '19

02 Sep '19

Hello I opened a recent Squeak5.3.a-18828 image. There is now a Metacello help together with a tutorial. Nice! I tested the tutorial. In the Getting Started Section after I have done ConfigurationOfMetacello project latestVersion load: #('Tutorial'). I am asked to do ProfStef goOn: MetacelloConfigurationTutorialPart1. Then I get a feedback that ProfStef is not known. Question: How would a fix look like? Regards Hannes

3 6

The Trunk: Morphic-mt.1513.mcz
by commits＠source.squeak.org 02 Sep '19

02 Sep '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1513.mcz ==================== Summary ==================== Name: Morphic-mt.1513 Author: mt Time: 2 September 2019, 7:45:12.260683 pm UUID: 61cca4ac-ac7c-3847-87f2-ae615fd1183d Ancestors: Morphic-mt.1512 Fixes a regression with non-clipping window titles. Also see TextMorph >> #minWidth. Not sure whether StringMorphs should "shrink wrap" horizontally if they are #rigid. Since they do not wrap vertically, it makes sense. =============== Diff against Morphic-mt.1512 =============== Item was changed: ----- Method: StringMorph>>minWidth (in category 'layout') ----- minWidth "Layout specific." + ^ self hResizing = #spaceFill + ifTrue: [0] ifFalse: [super minWidth max: (self fontToUse widthOfString: self contents)]! - ^ super minWidth max: (self fontToUse widthOfString: self contents)!

1 0

Jump to page: