Squeak-dev September 2019

squeak-dev@lists.squeakfoundation.org

38 participants
356 discussions

The Trunk: System-mt.1091.mcz
by commits＠source.squeak.org 04 Sep '19

04 Sep '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1091.mcz ==================== Summary ==================== Name: System-mt.1091 Author: mt Time: 4 September 2019, 7:43:00.370989 pm UUID: c032bb01-3d1e-40c2-a329-3268b1f2284c Ancestors: System-pre.1090 Cherry pick class query for system organization from rb repository. =============== Diff against System-pre.1090 =============== Item was added: + ----- Method: SystemOrganizer>>classesIn: (in category 'query') ----- + classesIn: categoryName + + | classes | + classes := OrderedCollection new. + self categories withIndexCollect: [:cat :idx | + (categoryName match: cat) + ifTrue: [classes addAll: (self listAtCategoryNumber: idx)] + ifFalse: [nil]]. + ^ classes collect: [:clsName | Smalltalk classNamed: clsName]! Item was changed: ----- Method: SystemOrganizer>>uncommentedClassesIn: (in category 'query') ----- uncommentedClassesIn: categoryName "SystemOrganization uncommentedClassesIn: 'Morphic*'" + ^ (self classesIn: categoryName) select: [:cls | cls hasComment not]! - | classes | - classes := OrderedCollection new. - self categories withIndexCollect: [:cat :idx | - (categoryName match: cat) - ifTrue: [classes addAll: (self listAtCategoryNumber: idx)] - ifFalse: [nil]]. - ^ (classes collect: [:clsName | Smalltalk at: clsName] - thenSelect: [:cls | cls hasComment not]) asArray - !

1 0

The Trunk: Tests-mt.415.mcz
by commits＠source.squeak.org 04 Sep '19

04 Sep '19

Marcel Taeumel uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-mt.415.mcz ==================== Summary ==================== Name: Tests-mt.415 Author: mt Time: 4 September 2019, 4:57:55.602738 pm UUID: 9676f86d-11c2-4977-85ad-44c5808ad780 Ancestors: Tests-mt.414 Fixes some compiler tests and cleans up decompiler-tests baseline. I will put a fix for the Decompiler into the inbox right away. :-) =============== Diff against Tests-mt.414 =============== Item was changed: ----- Method: CompilerNotifyingTest>>setUpForErrorsIn: (in category 'initialize-release') ----- setUpForErrorsIn: aTextWithErrorsEnclosedInBackQuote "Extract the expectedErrors, the expectedErrorPositions and set up a TextMorph containing the text without errors. each section separated by % in aTextWithErrorsEnclosedInBackQuote will be evaluated separately. The expected error message should lie in aTextWithErrorsEnclosedInBackQuote at the expected position, and enclosed in back quotes." text := aTextWithErrorsEnclosedInBackQuote. + + "Enclose error messages in double quotes to support syntax highlighting." + text := text copyReplaceAll: '` ' with: '` "'. + text := text copyReplaceAll: '>`' with: '>"`'. + morph := TextMorph new contents: self initializeTextWithoutError asText.! Item was changed: ----- Method: CompilerNotifyingTest>>testMissingExpression (in category 'tests') ----- testMissingExpression + self setUpForErrorsIn: '| x | x := ` Expression expected ->`'. - self setUpForErrorsIn: '| x | x := ` Expression expected ->'. self enumerateAllSelections! Item was added: + ----- Method: DecompilerTestFailuresCollector class>>isAbstract (in category 'as yet unclassified') ----- + isAbstract + + ^ true! Item was changed: ----- Method: DecompilerTests>>basePackagePrefixes (in category 'utilities') ----- basePackagePrefixes + + ^ #( + 'Kernel' "includes KernelTests" + 'Collections' "includes CollectionsTests" + 'Chronology' + 'Compiler' + 'Environments' + 'Traits' + 'PackageInfo' + + 'Graphics' "includes GraphicsTests" + 'Balloon' "includes BalloonTests" + 'TrueType' + + 'Sound' + + 'Network' "includes NetworkTests" + 'WebClient' + 'SqueakSSL' + 'XML' + - ^#("'Balloon'" "AbstractAnimation>>prologue: in Balloon3D-Wonderland-Time breaks the test" - 'Chronology' 'Collections' 'CommandLine' 'Compiler' 'Compression' - 'Environments' 'Exceptions' 'Files' + 'Compression' - 'GetText' 'Graphics' 'Help-' 'HelpSystem-' - 'Installer-Core' - 'Kernel-' 'KernelTests-' - 'Monticello' - 'Morphic-' 'MorphicExtras-' 'MorphicExtrasTests-' 'MorphicTests-' - 'Multilingual' 'MultilingualTests' - 'Nebraska' 'Network' 'NetworkTests' - 'PackageInfo-Base' 'PreferenceBrowser' 'Protocols' 'Regex' + 'System' + + 'ST80' "includes ST80Tests" + 'Morphic' "includes MorphicTests and MorphicExtras" + 'Etoys' + + 'Installer' + 'Monticello' + 'VersionNumber' + 'UpdateStream' + 'SMBase' + 'SMLoader' + 'Squeak-Version' + + 'GetText' + 'Multilingual' "includes MultilingualTests" + 'Help' "includes HelpSystem" + + 'ToolBuilder' + 'Tools' + 'CommandLine' + 'Nebraska' + 'PreferenceBrowser' + 'Protocols' + 'SUnit' + 'ScriptLoader' + 'Services' + 'Shout' + + 'Tests' 'ReleaseBuilder' + )! - 'SMBase' 'SMLoader' 'ST80' 'ST80Tests' 'ST80Tools' 'SUnit' 'ScriptLoader' 'Services-Base' 'Shout' - 'Sound' 'Squeak-Version' 'SqueakSSL' 'System' - 'Tests' 'ToolBuilder' 'Tools' 'Traits' 'TrueType' - 'Universes' 'UpdateStream' 'VersionNumber' - 'WebClient-' - 'XML-')! Item was changed: ----- Method: DecompilerTests>>decompilerFailures (in category 'utilities') ----- decompilerFailures "Here is the list of failures: either a syntax error, a hard error or some failure to decompile correctly. Collected initially via DecompilerTestFailuresCollector new computeFailures. But can be maintained manually." "class name, selector, error class name or nil" ^#( #(BrowserCommentTextMorph showPane SyntaxErrorNotification) #(CodeHolder getSelectorAndSendQuery:to:with: SyntaxErrorNotification) #(DecompilerTests testDecompileUnreachableParameter Error) #(MVCToolBuilder setLayout:in: SyntaxErrorNotification) "same-name block-local temps in optimized blocks" - #(Pen web AssertionFailure) "needs a recompile to compute remote temps correctly (repeat now inlined)" #(PNGReadWriter copyPixelsGray: SyntaxErrorNotification) - #(Random roll: AssertionFailure) "needs a recompile to compute remote temps correctly (repeat now inlined)" #(SHMCClassDefinition withAllSuperclassesDo: SyntaxErrorNotification)), "same-name block-local temps in optimized blocks" (Scanner allowBlockArgumentAssignment ifTrue: [#()] ifFalse: [#( #(NebraskaSenderMorph hideField: SyntaxErrorNotification)) "assigns into block argument"])!

2 1

[Proposal SUnit] Show number of tests and last duration
by Marcel Taeumel 04 Sep '19

04 Sep '19

Can I merge the required changes into Trunk's SUnit package? :-) It's basically a few additions to TestResult and RestTunner. Best, Marcel

5 5

The Trunk: EToys-pre.353.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Patrick Rein uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-pre.353.mcz ==================== Summary ==================== Name: EToys-pre.353 Author: pre Time: 3 September 2019, 5:14:21.865361 pm UUID: 1e430e87-7b49-b042-8aea-67a37f83057f Ancestors: EToys-mt.352 Refactors some methods to not use ChangeSorter class anymore to access changes but ChangeSet class directly. =============== Diff against EToys-mt.352 =============== Item was changed: ----- Method: ChangeSetCategory>>changeSetList (in category 'queries') ----- changeSetList "Answer the list of change-set names in the category" | aChangeSet | self reconstituteList. keysInOrder size == 0 ifTrue: ["don't tolerate emptiness, because ChangeSorters gag when they have no change-set selected" + aChangeSet := ChangeSet assuredChangeSetNamed: 'New Changes'. - aChangeSet := ChangeSorter assuredChangeSetNamed: 'New Changes'. self elementAt: aChangeSet name put: aChangeSet]. ^ keysInOrder reversed! Item was changed: ----- Method: ChangeSetCategory>>fileOutAllChangeSets (in category 'services') ----- fileOutAllChangeSets "File out all the nonempty change sets in the current category, suppressing the checks for slips that might otherwise ensue. Obtain user confirmation before undertaking this possibly prodigious task." | aList | + aList := self elementsInOrder select: [:aChangeSet | aChangeSet notEmpty]. - aList := self elementsInOrder select: - [:aChangeSet | aChangeSet isEmpty not]. aList isEmpty ifTrue: [^ self inform: 'sorry, all the change sets in this category are empty']. (self confirm: 'This will result in filing out ', aList size printString, ' change set(s) Are you certain you want to do this?') ifFalse: [^ self]. Preferences setFlag: #checkForSlips toValue: false during: + [ChangeSet fileOutChangeSetsNamed: (aList collect: [:m | m name]) sort]! - [ChangeSorter fileOutChangeSetsNamed: (aList collect: [:m | m name]) sort]! Item was changed: ----- Method: ChangeSetCategory>>fillAggregateChangeSet (in category 'services') ----- fillAggregateChangeSet "Create a change-set named Aggregate and pour into it all the changes in all the change-sets of the currently-selected category" | aggChangeSet | + aggChangeSet := ChangeSet assuredChangeSetNamed: #Aggregate. - aggChangeSet := ChangeSorter assuredChangeSetNamed: #Aggregate. aggChangeSet clear. aggChangeSet setPreambleToSay: '"Change Set: Aggregate Created at ', Time now printString, ' on ', Date today printString, ' by combining all the changes in all the change sets in the category ', categoryName printString, '"'. (self elementsInOrder copyWithout: aggChangeSet) do: [:aChangeSet | aggChangeSet assimilateAllChangesFoundIn: aChangeSet]. Smalltalk isMorphic ifTrue: [SystemWindow wakeUpTopWindowUponStartup] ! Item was changed: ----- Method: ChangeSetCategory>>reconstituteList (in category 'miscellaneous') ----- reconstituteList "Clear out the receiver's elements and rebuild them" | newMembers | "First determine newMembers and check if they have not changed..." + newMembers := ChangeSet allChangeSets select: - newMembers := ChangeSorter allChangeSets select: [:aChangeSet | ChangeSorter perform: membershipSelector with: aChangeSet]. (newMembers collect: [:cs | cs name]) = keysInOrder ifTrue: [^ self "all current"]. "Things have changed. Need to recompute the whole category" self clear. newMembers do: [:aChangeSet | self fasterElementAt: aChangeSet name asSymbol put: aChangeSet] ! Item was changed: ----- Method: ChangeSetCategoryWithParameters>>reconstituteList (in category 'as yet unclassified') ----- reconstituteList "Clear out the receiver's elements and rebuild them" | newMembers | "First determine newMembers and check if they have not changed..." + newMembers := ChangeSet allChangeSets select: - newMembers := ChangeSorter allChangeSets select: [:aChangeSet | ChangeSorter perform: membershipSelector withArguments: { aChangeSet }, parameters]. (newMembers collect: [:cs | cs name]) = keysInOrder ifTrue: [^ self "all current"]. "Things have changed. Need to recompute the whole category" self clear. newMembers do: [:aChangeSet | self fasterElementAt: aChangeSet name asSymbol put: aChangeSet]! Item was changed: ----- Method: DocLibrary>>saveDocCheck: (in category 'doc pane') ----- saveDocCheck: aMorph "Make sure the document gets attached to the version of the code that the user was looking at. Is there a version of this method in a changeSet beyond the updates we know about? Works even when the user has internal update numbers and the documentation is for external updates (It always is)." | classAndMethod parts selector class lastUp beyond ours docFor unNum ok key verList ext response | classAndMethod := aMorph valueOfProperty: #classAndMethod. classAndMethod ifNil: [ ^ self error: 'need to know the class and method']. "later let user set it" parts := classAndMethod findTokens: ' .'. selector := parts last asSymbol. class := Smalltalk at: (parts first asSymbol) ifAbsent: [^ self saveDoc: aMorph]. parts size = 3 ifTrue: [class := class class]. "Four indexes we are looking for: docFor = highest numbered below lastUpdate that has method. unNum = a higher unnumbered set that has method. lastUp = lastUpdate we know about in methodVersions beyond = any set about lastUp that has the method." + ChangeSet allChangeSets doWithIndex: [:cs :ind | "youngest first" - ChangeSorter allChangeSets doWithIndex: [:cs :ind | "youngest first" (cs name includesSubString: lastUpdateName) ifTrue: [lastUp := ind]. (cs atSelector: selector class: class) ~~ #none ifTrue: [ lastUp ifNotNil: [beyond := ind. ours := cs name] ifNil: [cs name first isDigit ifTrue: [docFor := ind] ifFalse: [unNum := ind. ours := cs name]]]]. "See if version the user sees is the version he is documenting" ok := beyond == nil. unNum ifNotNil: [docFor ifNotNil: [ok := docFor > unNum] ifNil: [ok := false]]. "old changeSets gone" ok ifTrue: [^ self saveDoc: aMorph]. key := DocLibrary properStemFor: classAndMethod. verList := (methodVersions at: key ifAbsent: [#()]), #(0 0). ext := verList first. "external update number we will write to" response := (PopUpMenu labels: 'Cancel\Broadcast Page' withCRs) startUpWithCaption: 'You are documenting a method in External Update ', ext asString, '.\There is a more recent version of that method in ' withCRs, ours, '.\If you are explaining the newer version, please Cancel.\Wait until that version appears in an External Update.' withCRs. response = 2 ifTrue: [self saveDoc: aMorph]. ! Item was changed: ----- Method: ProjectLoading class>>loadImageSegment:fromDirectory:withProjectView:numberOfFontSubstitutes:substituteFont:mgr: (in category '*etoys') ----- loadImageSegment: morphOrList fromDirectory: aDirectoryOrNil withProjectView: existingView numberOfFontSubstitutes: numberOfFontSubstitutes substituteFont: substituteFont mgr: mgr | proj projectsToBeDeleted ef f | (f := (Flaps globalFlapTabWithID: 'Navigator' translated)) ifNotNil: [f hideFlap]. proj := morphOrList arrayOfRoots detect: [:mm | mm isKindOf: Project] ifNone: [^ nil]. numberOfFontSubstitutes > 0 ifTrue: [ proj projectParameterAt: #substitutedFont put: substituteFont]. ef := proj projectParameterAt: #eToysFont. (ef isNil or: [ef ~= substituteFont familySizeFace]) ifTrue: [ proj projectParameterAt: #substitutedFont put: substituteFont. ]. proj projectParameters at: #MultiSymbolInWrongPlace put: false. "Yoshiki did not put MultiSymbols into outPointers in older images!!" morphOrList arrayOfRoots do: [:obj | obj fixUponLoad: proj seg: morphOrList "imageSegment"]. (proj projectParameters at: #MultiSymbolInWrongPlace) ifTrue: [ morphOrList arrayOfRoots do: [:obj | (obj isKindOf: Set) ifTrue: [obj rehash]]]. proj resourceManager: mgr. "proj versionFrom: preStream." proj lastDirectory: aDirectoryOrNil. proj setParent: Project current. projectsToBeDeleted := OrderedCollection new. existingView == #none ifFalse: [ self makeExistingView: existingView project: proj projectsToBeDeleted: projectsToBeDeleted]. + ChangeSet allChangeSets add: proj changeSet. - ChangeSorter allChangeSets add: proj changeSet. Project current projectParameters at: #deleteWhenEnteringNewProject ifPresent: [ :ignored | projectsToBeDeleted add: Project current. Project current removeParameter: #deleteWhenEnteringNewProject. ]. projectsToBeDeleted isEmpty ifFalse: [ proj projectParameters at: #projectsToBeDeleted put: projectsToBeDeleted. ]. proj removeParameter: #eToysFont. ^ proj! Item was changed: ----- Method: ProjectLoading class>>loadSexpProjectDict:stream:fromDirectory:withProjectView: (in category '*etoys') ----- loadSexpProjectDict: dict stream: preStream fromDirectory: aDirectoryOrNil withProjectView: existingView | archive anObject newProj d member memberStream members newSet allNames realName oldSet s | (self checkStream: preStream) ifTrue: [^ nil]. ProgressNotification signal: '0.2'. preStream reset. archive := preStream isZipArchive ifTrue:[ZipArchive new readFrom: preStream] ifFalse:[nil]. members := archive membersMatching: '*.cs'. + members do: [:e | newSet := ChangeSet newChangesFromStream: e contentStream named: 'zzTemp', Time totalSeconds printString]. - members do: [:e | newSet := ChangeSorter newChangesFromStream: e contentStream named: 'zzTemp', Time totalSeconds printString]. member := (archive membersMatching: '*.sexp') first. memberStream := member contentStream. (self checkSecurity: member name preStream: preStream projStream: memberStream) ifFalse: [^nil]. self flag: #tfel. "load all projects and save them again in the new format, then get rid of the error block!!" s := memberStream basicUpToEnd. d := [(DataStream on: memberStream) next] on: Error do: [:e | (Smalltalk at: #MSExpParser) parse: s with: #ksexp]. anObject := d sissReadObjectsAsEtoysProject. preStream close. "anObject := (MSExpParser parse: (archive membersMatching: '*.sexp') first contents with: #ksexp) sissReadObjects." anObject ifNil: [^ nil]. (anObject isKindOf: PasteUpMorph) ifFalse: [^ Project current world addMorph: anObject]. ProgressNotification signal: '0.7'. newProj := MorphicProject new. newProj installPasteUpAsWorld: anObject. + newSet ifNotNil: [oldSet := newProj changeSet. newProj setChangeSet: newSet. ChangeSet removeChangeSet: oldSet]. - newSet ifNotNil: [oldSet := newProj changeSet. newProj setChangeSet: newSet. ChangeSorter removeChangeSet: oldSet]. dict at: 'projectname' ifPresent: [:n | allNames := Project allNames. realName := Utilities keyLike: n satisfying: [:nn | (allNames includes: nn) not]. newProj renameTo: realName. ]. anObject valueOfProperty: #projectVersion ifPresentDo: [:v | newProj version: v]. newProj noteManifestDetailsIn: dict. ProgressNotification signal: '0.8'. ^ newProj.! Item was changed: ----- Method: ProjectLoading class>>makeExistingView:project:projectsToBeDeleted: (in category '*etoys') ----- makeExistingView: existingView project: proj projectsToBeDeleted: projectsToBeDeleted existingView ifNil: [ Smalltalk isMorphic ifTrue: [ proj createViewIfAppropriate. ] ifFalse: [ + ChangeSet allChangeSets add: proj changeSet. - ChangeSorter allChangeSets add: proj changeSet. Project current openProject: proj. "Note: in MVC we get no further than the above" ]. ] ifNotNil: [ (existingView project isKindOf: DiskProxy) ifFalse: [ existingView project changeSet name: ChangeSet defaultName. projectsToBeDeleted add: existingView project. ]. (existingView owner isSystemWindow) ifTrue: [ existingView owner model: proj ]. existingView project: proj. ]. !

1 0

The Trunk: Monticello-pre.700.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Patrick Rein uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-pre.700.mcz ==================== Summary ==================== Name: Monticello-pre.700 Author: pre Time: 3 September 2019, 5:12:25.650361 pm UUID: ff75f1eb-e3c7-2646-b2a0-d7a268675f70 Ancestors: Monticello-cmm.699 Refactors Monticello tools to directly use the ChangeSet class for accessing change sets. =============== Diff against Monticello-cmm.699 =============== Item was changed: ----- Method: MCCodeTool>>findMethodInChangeSets (in category 'menus') ----- findMethodInChangeSets "Find and open a changeSet containing the current method." | aName | (aName := self selectedMessageName) ifNotNil: [ + ChangeSorter + browseChangeSetsWithClass: self selectedClassOrMetaClass + selector: aName]! - ChangeSorter browseChangeSetsWithClass: self selectedClassOrMetaClass - selector: aName]! Item was changed: ----- Method: MCPackageLoader>>useChangeSetNamed:during: (in category 'private') ----- useChangeSetNamed: baseName during: aBlock "Use the named change set, or create one with the given name." | changeHolder oldChanges newChanges | changeHolder := (ChangeSet respondsTo: #newChanges:) ifTrue: [ChangeSet] ifFalse: [Smalltalk]. oldChanges := (ChangeSet respondsTo: #current) ifTrue: [ChangeSet current] ifFalse: [Smalltalk changes]. + newChanges := (ChangeSet named: baseName) ifNil: [ ChangeSet new name: baseName ]. - newChanges := (ChangesOrganizer changeSetNamed: baseName) ifNil: [ ChangeSet new name: baseName ]. changeHolder newChanges: newChanges. aBlock ensure: [changeHolder newChanges: oldChanges]. !

1 0

The Trunk: 60Deprecated-pre.46.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Patrick Rein uploaded a new version of 60Deprecated to project The Trunk: http://source.squeak.org/trunk/60Deprecated-pre.46.mcz ==================== Summary ==================== Name: 60Deprecated-pre.46 Author: pre Time: 3 September 2019, 5:11:23.874361 pm UUID: f4c06e04-fa92-3e46-b4b8-4d8714736eaa Ancestors: 60Deprecated-pre.45 Deprecates unused (and duplicated) methods on ChangeSorter class which now actually reside in ChangeSet. Also refactors some ChangesOrganizer methods to use the implementation on ChangeSet class instead of reimplementing the logic (in the end the changesets already come from ChangeSet class). =============== Diff against 60Deprecated-pre.45 =============== Item was added: + ----- Method: ChangeSorter class>>allChangeSetNames (in category '*60Deprecated-Tools') ----- + allChangeSetNames + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangesOrganizer allChangeSetNames! Item was added: + ----- Method: ChangeSorter class>>allChangeSets (in category '*60Deprecated-Tools') ----- + allChangeSets + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet allChangeSets! Item was added: + ----- Method: ChangeSorter class>>allChangeSetsWithClass:selector: (in category '*60Deprecated-Tools') ----- + allChangeSetsWithClass: class selector: selector + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangesOrganizer allChangeSetsWithClass: class selector: selector! Item was added: + ----- Method: ChangeSorter class>>assuredChangeSetNamed: (in category '*60Deprecated-Tools') ----- + assuredChangeSetNamed: aName + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangesOrganizer assuredChangeSetNamed: aName! Item was added: + ----- Method: ChangeSorter class>>basicNewChangeSet: (in category '*60Deprecated-Tools') ----- + basicNewChangeSet: newName + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangesOrganizer basicNewChangeSet: newName! Item was added: + ----- Method: ChangeSorter class>>belongsInAdditions: (in category '*60Deprecated-Tools') ----- + belongsInAdditions: aChangeSet + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer belongsInAdditions: aChangeSet! Item was added: + ----- Method: ChangeSorter class>>belongsInAll: (in category '*60Deprecated-Tools') ----- + belongsInAll: aChangeSet + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer belongsInAll: aChangeSet! Item was added: + ----- Method: ChangeSorter class>>belongsInMyInitials: (in category '*60Deprecated-Tools') ----- + belongsInMyInitials: aChangeSet + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer belongsInMyInitials: aChangeSet! Item was added: + ----- Method: ChangeSorter class>>belongsInNumbered: (in category '*60Deprecated-Tools') ----- + belongsInNumbered: aChangeSet + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer belongsInNumbered: aChangeSet! Item was added: + ----- Method: ChangeSorter class>>belongsInProjectChangeSets: (in category '*60Deprecated-Tools') ----- + belongsInProjectChangeSets: aChangeSet + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer belongsInProjectChangeSets: aChangeSet! Item was added: + ----- Method: ChangeSorter class>>belongsInProjectsInRelease: (in category '*60Deprecated-Tools') ----- + belongsInProjectsInRelease: aChangeSet + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer belongsInProjectsInRelease: aChangeSet! Item was added: + ----- Method: ChangeSorter class>>belongsInRecentUpdates: (in category '*60Deprecated-Tools') ----- + belongsInRecentUpdates: aChangeSet + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer belongsInRecentUpdates: aChangeSet! Item was added: + ----- Method: ChangeSorter class>>buildAggregateChangeSet (in category '*60Deprecated-Tools') ----- + buildAggregateChangeSet + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangesOrganizer buildAggregateChangeSet + + ! Item was added: + ----- Method: ChangeSorter class>>changeSet:containsClass: (in category '*60Deprecated-Tools') ----- + changeSet: aChangeSet containsClass: aClass + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet changeSet: aChangeSet containsClass: aClass! Item was added: + ----- Method: ChangeSorter class>>changeSetNamed: (in category '*60Deprecated-Tools') ----- + changeSetNamed: aName + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer changeSetNamed: aName! Item was added: + ----- Method: ChangeSorter class>>changeSetNamesInReleaseImage (in category '*60Deprecated-Tools') ----- + changeSetNamesInReleaseImage + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer changeSetNamesInReleaseImage! Item was added: + ----- Method: ChangeSorter class>>changeSetNamesInThreeOh (in category '*60Deprecated-Tools') ----- + changeSetNamesInThreeOh + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer changeSetNamesInThreeOh! Item was added: + ----- Method: ChangeSorter class>>changeSetsNamedSuchThat: (in category '*60Deprecated-Tools') ----- + changeSetsNamedSuchThat: nameBlock + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet changeSetsNamedSuchThat: nameBlock! Item was added: + ----- Method: ChangeSorter class>>countOfChangeSetsWithClass:andSelector: (in category '*60Deprecated-Tools') ----- + countOfChangeSetsWithClass: aClass andSelector: aSelector + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet countOfChangeSetsWithClass: aClass andSelector: aSelector! Item was added: + ----- Method: ChangeSorter class>>deleteChangeSetsNumberedLowerThan: (in category '*60Deprecated-Tools') ----- + deleteChangeSetsNumberedLowerThan: anInteger + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet deleteChangeSetsNumberedLowerThan: anInteger! Item was added: + ----- Method: ChangeSorter class>>doesAnyChangeSetHaveClass:andSelector: (in category '*60Deprecated-Tools') ----- + doesAnyChangeSetHaveClass: aClass andSelector: aSelector + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet doesAnyChangeSetHaveClass: aClass andSelector: aSelector! Item was added: + ----- Method: ChangeSorter class>>existingOrNewChangeSetNamed: (in category '*60Deprecated-Tools') ----- + existingOrNewChangeSetNamed: aName + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet existingOrNewChangeSetNamed: aName! Item was added: + ----- Method: ChangeSorter class>>fileOutChangeSetsNamed: (in category '*60Deprecated-Tools') ----- + fileOutChangeSetsNamed: nameList + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet fileOutChangeSetsNamed: nameList! Item was added: + ----- Method: ChangeSorter class>>gatherChangeSets (in category '*60Deprecated-Tools') ----- + gatherChangeSets + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet gatherChangeSets! Item was added: + ----- Method: ChangeSorter class>>highestNumberedChangeSet (in category '*60Deprecated-Tools') ----- + highestNumberedChangeSet + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet highestNumberedChangeSet + ! Item was added: + ----- Method: ChangeSorter class>>mostRecentChangeSetWithChangeForClass:selector: (in category '*60Deprecated-Tools') ----- + mostRecentChangeSetWithChangeForClass: class selector: selector + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet mostRecentChangeSetWithChangeForClass: class selector: selector! Item was added: + ----- Method: ChangeSorter class>>newChangeSet (in category '*60Deprecated-Tools') ----- + newChangeSet + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet newChangeSet! Item was added: + ----- Method: ChangeSorter class>>newChangeSet: (in category '*60Deprecated-Tools') ----- + newChangeSet: aName + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet newChangeSet: aName! Item was added: + ----- Method: ChangeSorter class>>newChangesFromStream:named: (in category '*60Deprecated-Tools') ----- + newChangesFromStream: aStream named: aName + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet newChangesFromStream: aStream named: aName! Item was added: + ----- Method: ChangeSorter class>>noteChangeSetsInRelease (in category '*60Deprecated-Tools') ----- + noteChangeSetsInRelease + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer noteChangeSetsInRelease! Item was added: + ----- Method: ChangeSorter class>>promoteToTop: (in category '*60Deprecated-Tools') ----- + promoteToTop: aChangeSet + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet promoteToTop: aChangeSet! Item was added: + ----- Method: ChangeSorter class>>recentUpdateMarker (in category '*60Deprecated-Tools') ----- + recentUpdateMarker + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer recentUpdateMarker! Item was added: + ----- Method: ChangeSorter class>>recentUpdateMarker: (in category '*60Deprecated-Tools') ----- + recentUpdateMarker: aNumber + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer recentUpdateMarker: aNumber! Item was added: + ----- Method: ChangeSorter class>>removeChangeSet: (in category '*60Deprecated-Tools') ----- + removeChangeSet: aChangeSet + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet removeChangeSet: aChangeSet! Item was added: + ----- Method: ChangeSorter class>>removeChangeSetsNamedSuchThat: (in category '*60Deprecated-Tools') ----- + removeChangeSetsNamedSuchThat: nameBlock + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet removeChangeSetsNamedSuchThat: nameBlock! Item was added: + ----- Method: ChangeSorter class>>removeEmptyUnnamedChangeSets (in category '*60Deprecated-Tools') ----- + removeEmptyUnnamedChangeSets + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet removeEmptyUnnamedChangeSets! Item was added: + ----- Method: ChangeSorter class>>reorderChangeSets (in category '*60Deprecated-Tools') ----- + reorderChangeSets + + self deprecated: 'This method was moved to ChangesOrganizer'. + ^ ChangesOrganizer reorderChangeSets! Item was added: + ----- Method: ChangeSorter class>>secondaryChangeSet (in category '*60Deprecated-Tools') ----- + secondaryChangeSet + + self deprecated: 'This method was moved to ChangeSet'. + ^ ChangeSet secondaryChangeSet!

1 0

The Trunk: Tools-pre.883.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Patrick Rein uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-pre.883.mcz ==================== Summary ==================== Name: Tools-pre.883 Author: pre Time: 3 September 2019, 5:10:12.037361 pm UUID: ba7b1b34-3fbe-a74a-95d1-7357bd94e8ac Ancestors: Tools-pre.882 Deprecates unused (and duplicated) methods on ChangeSorter class which now actually reside in ChangeSet. Also refactors some ChangesOrganizer methods to use the implementation on ChangeSet class instead of reimplementing the logic (in the end the changesets already come from ChangeSet class). =============== Diff against Tools-pre.882 =============== Item was removed: - ----- Method: ChangeSorter class>>allChangeSetNames (in category 'deprecated') ----- - allChangeSetNames - - ^ ChangesOrganizer allChangeSetNames! Item was removed: - ----- Method: ChangeSorter class>>allChangeSets (in category 'deprecated') ----- - allChangeSets - - ^ ChangesOrganizer allChangeSets! Item was removed: - ----- Method: ChangeSorter class>>allChangeSetsWithClass:selector: (in category 'deprecated') ----- - allChangeSetsWithClass: class selector: selector - - ^ ChangesOrganizer allChangeSetsWithClass: class selector: selector! Item was removed: - ----- Method: ChangeSorter class>>assuredChangeSetNamed: (in category 'deprecated') ----- - assuredChangeSetNamed: aName - - ^ ChangesOrganizer assuredChangeSetNamed: aName! Item was removed: - ----- Method: ChangeSorter class>>basicNewChangeSet: (in category 'deprecated') ----- - basicNewChangeSet: newName - - ^ ChangesOrganizer basicNewChangeSet: newName! Item was removed: - ----- Method: ChangeSorter class>>belongsInAdditions: (in category 'deprecated') ----- - belongsInAdditions: aChangeSet - - ^ ChangesOrganizer belongsInAdditions: aChangeSet! Item was removed: - ----- Method: ChangeSorter class>>belongsInAll: (in category 'deprecated') ----- - belongsInAll: aChangeSet - - ^ ChangesOrganizer belongsInAll: aChangeSet! Item was removed: - ----- Method: ChangeSorter class>>belongsInMyInitials: (in category 'deprecated') ----- - belongsInMyInitials: aChangeSet - - ^ ChangesOrganizer belongsInMyInitials: aChangeSet! Item was removed: - ----- Method: ChangeSorter class>>belongsInNumbered: (in category 'deprecated') ----- - belongsInNumbered: aChangeSet - - ^ ChangesOrganizer belongsInNumbered: aChangeSet! Item was removed: - ----- Method: ChangeSorter class>>belongsInProjectChangeSets: (in category 'deprecated') ----- - belongsInProjectChangeSets: aChangeSet - - ^ ChangesOrganizer belongsInProjectChangeSets: aChangeSet! Item was removed: - ----- Method: ChangeSorter class>>belongsInProjectsInRelease: (in category 'deprecated') ----- - belongsInProjectsInRelease: aChangeSet - - ^ ChangesOrganizer belongsInProjectsInRelease: aChangeSet! Item was removed: - ----- Method: ChangeSorter class>>belongsInRecentUpdates: (in category 'deprecated') ----- - belongsInRecentUpdates: aChangeSet - - ^ ChangesOrganizer belongsInRecentUpdates: aChangeSet! Item was changed: ----- Method: ChangeSorter class>>browseChangeSetsWithClass:selector: (in category 'browse') ----- browseChangeSetsWithClass: class selector: selector "Put up a menu comprising a list of change sets that hold changes for the given class and selector. If the user selects one, open a single change-sorter onto it" | hits index | + hits := ChangeSet allChangeSets select: - hits := self allChangeSets select: [:cs | (cs atSelector: selector class: class) ~~ #none]. hits isEmpty ifTrue: [^ self inform: class name, '.', selector , ' is not in any change set']. index := hits size = 1 ifTrue: [1] ifFalse: [(UIManager default chooseFrom: (hits collect: [:cs | cs name]) lines: #())]. index = 0 ifTrue: [^ self]. (ChangeSorter new myChangeSet: (hits at: index)) open. ! Item was changed: ----- Method: ChangeSorter class>>browseChangeSetsWithSelector: (in category 'browse') ----- browseChangeSetsWithSelector: aSelector "Put up a list of all change sets that contain an addition, deletion, or change of any method with the given selector" | hits index | + hits := ChangeSet allChangeSets select: - hits := self allChangeSets select: [:cs | cs hasAnyChangeForSelector: aSelector]. hits isEmpty ifTrue: [^ self inform: aSelector , ' is not in any change set']. index := hits size = 1 ifTrue: [1] ifFalse: [(UIManager default chooseFrom: (hits collect: [:cs | cs name]) lines: #())]. index = 0 ifTrue: [^ self]. (ChangeSetBrowser new myChangeSet: (hits at: index)) open "ChangeSorter browseChangeSetsWithSelector: #clearPenTrails" ! Item was removed: - ----- Method: ChangeSorter class>>buildAggregateChangeSet (in category 'deprecated') ----- - buildAggregateChangeSet - - ^ ChangesOrganizer buildAggregateChangeSet - - ! Item was removed: - ----- Method: ChangeSorter class>>changeSet:containsClass: (in category 'deprecated') ----- - changeSet: aChangeSet containsClass: aClass - - ^ ChangesOrganizer changeSet: aChangeSet containsClass: aClass! Item was removed: - ----- Method: ChangeSorter class>>changeSetNamed: (in category 'deprecated') ----- - changeSetNamed: aName - - ^ ChangesOrganizer changeSetNamed: aName! Item was removed: - ----- Method: ChangeSorter class>>changeSetNamesInReleaseImage (in category 'deprecated') ----- - changeSetNamesInReleaseImage - - ^ ChangesOrganizer changeSetNamesInReleaseImage! Item was removed: - ----- Method: ChangeSorter class>>changeSetNamesInThreeOh (in category 'deprecated') ----- - changeSetNamesInThreeOh - - ^ ChangesOrganizer changeSetNamesInThreeOh! Item was removed: - ----- Method: ChangeSorter class>>changeSetsNamedSuchThat: (in category 'deprecated') ----- - changeSetsNamedSuchThat: nameBlock - - ^ ChangesOrganizer changeSetsNamedSuchThat: nameBlock! Item was removed: - ----- Method: ChangeSorter class>>countOfChangeSetsWithClass:andSelector: (in category 'deprecated') ----- - countOfChangeSetsWithClass: aClass andSelector: aSelector - - ^ ChangesOrganizer countOfChangeSetsWithClass: aClass andSelector: aSelector! Item was removed: - ----- Method: ChangeSorter class>>deleteChangeSetsNumberedLowerThan: (in category 'deprecated') ----- - deleteChangeSetsNumberedLowerThan: anInteger - - ^ ChangesOrganizer deleteChangeSetsNumberedLowerThan: anInteger! Item was removed: - ----- Method: ChangeSorter class>>doesAnyChangeSetHaveClass:andSelector: (in category 'deprecated') ----- - doesAnyChangeSetHaveClass: aClass andSelector: aSelector - - ^ ChangesOrganizer doesAnyChangeSetHaveClass: aClass andSelector: aSelector! Item was removed: - ----- Method: ChangeSorter class>>existingOrNewChangeSetNamed: (in category 'deprecated') ----- - existingOrNewChangeSetNamed: aName - - ^ ChangesOrganizer existingOrNewChangeSetNamed: aName! Item was removed: - ----- Method: ChangeSorter class>>fileOutChangeSetsNamed: (in category 'deprecated') ----- - fileOutChangeSetsNamed: nameList - - ^ ChangesOrganizer fileOutChangeSetsNamed: nameList! Item was removed: - ----- Method: ChangeSorter class>>gatherChangeSets (in category 'deprecated') ----- - gatherChangeSets - - ^ ChangesOrganizer gatherChangeSets! Item was removed: - ----- Method: ChangeSorter class>>highestNumberedChangeSet (in category 'deprecated') ----- - highestNumberedChangeSet - - ^ ChangesOrganizer highestNumberedChangeSet - ! Item was removed: - ----- Method: ChangeSorter class>>mostRecentChangeSetWithChangeForClass:selector: (in category 'deprecated') ----- - mostRecentChangeSetWithChangeForClass: class selector: selector - - ^ ChangesOrganizer mostRecentChangeSetWithChangeForClass: class selector: selector! Item was removed: - ----- Method: ChangeSorter class>>newChangeSet (in category 'deprecated') ----- - newChangeSet - - ^ ChangesOrganizer newChangeSet! Item was removed: - ----- Method: ChangeSorter class>>newChangeSet: (in category 'deprecated') ----- - newChangeSet: aName - - ^ ChangesOrganizer newChangeSet: aName! Item was removed: - ----- Method: ChangeSorter class>>newChangesFromStream:named: (in category 'deprecated') ----- - newChangesFromStream: aStream named: aName - - ^ ChangesOrganizer newChangesFromStream: aStream named: aName! Item was removed: - ----- Method: ChangeSorter class>>noteChangeSetsInRelease (in category 'deprecated') ----- - noteChangeSetsInRelease - - ^ ChangesOrganizer noteChangeSetsInRelease! Item was removed: - ----- Method: ChangeSorter class>>promoteToTop: (in category 'deprecated') ----- - promoteToTop: aChangeSet - - ^ ChangesOrganizer promoteToTop: aChangeSet! Item was removed: - ----- Method: ChangeSorter class>>recentUpdateMarker (in category 'deprecated') ----- - recentUpdateMarker - - ^ ChangesOrganizer recentUpdateMarker! Item was removed: - ----- Method: ChangeSorter class>>recentUpdateMarker: (in category 'deprecated') ----- - recentUpdateMarker: aNumber - - ^ ChangesOrganizer recentUpdateMarker: aNumber! Item was changed: + ----- Method: ChangeSorter class>>registerInFlapsRegistry (in category 'class initialization') ----- - ----- Method: ChangeSorter class>>registerInFlapsRegistry (in category 'deprecated') ----- registerInFlapsRegistry "Register the receiver in the system's flaps registry" self environment at: #Flaps ifPresent: [:cl | cl registerQuad: {#ChangeSorter. #prototypicalToolWindow. 'Change Set' translatedNoop. 'A tool that allows you to view and manipulate all the code changes in a single change set' translatedNoop} forFlapNamed: 'Tools']! Item was removed: - ----- Method: ChangeSorter class>>removeChangeSet: (in category 'deprecated') ----- - removeChangeSet: aChangeSet - - ^ ChangesOrganizer removeChangeSet: aChangeSet! Item was removed: - ----- Method: ChangeSorter class>>removeChangeSetsNamedSuchThat: (in category 'deprecated') ----- - removeChangeSetsNamedSuchThat: nameBlock - - ^ ChangesOrganizer removeChangeSetsNamedSuchThat: nameBlock! Item was removed: - ----- Method: ChangeSorter class>>removeEmptyUnnamedChangeSets (in category 'deprecated') ----- - removeEmptyUnnamedChangeSets - - ^ ChangesOrganizer removeEmptyUnnamedChangeSets! Item was removed: - ----- Method: ChangeSorter class>>reorderChangeSets (in category 'deprecated') ----- - reorderChangeSets - - ^ ChangesOrganizer reorderChangeSets! Item was removed: - ----- Method: ChangeSorter class>>secondaryChangeSet (in category 'deprecated') ----- - secondaryChangeSet - - ^ ChangesOrganizer secondaryChangeSet! Item was changed: + ----- Method: ChangeSorter class>>unload (in category 'initialize-release') ----- - ----- Method: ChangeSorter class>>unload (in category 'deprecated') ----- unload "Unload the receiver from global registries" self environment at: #FileServices ifPresent: [:cl | cl unregisterFileReader: self]. self environment at: #Flaps ifPresent: [:cl | cl unregisterQuadsWithReceiver: self] ! Item was changed: ----- Method: ChangeSorter>>rename (in category 'changeSet menu') ----- rename "Store a new name string into the selected ChangeSet. reject duplicate name; allow user to back out" | newName | newName := UIManager default request: 'New name for this change set' initialAnswer: myChangeSet name. (newName = myChangeSet name or: [newName size = 0]) ifTrue: [^ Beeper beep]. + (ChangeSet named: newName) ifNotNil: - (self class changeSetNamed: newName) ifNotNil: [^ UIManager default inform: 'Sorry that name is already used']. myChangeSet name: newName. self update. self changed: #mainButtonName. self changed: #relabel.! Item was changed: ----- Method: ChangeSorter>>reorderChangeSets (in category 'changeSet menu') ----- reorderChangeSets "apply a standard reordering -- let the class handle this" + ^ ChangesOrganizer reorderChangeSets! - ^ self class reorderChangeSets! Item was changed: ----- Method: ChangesOrganizer class>>allChangeSetNames (in category 'enumerating') ----- allChangeSetNames + ^ ChangeSet allChangeSetNames! - ^ self allChangeSets collect: [:c | c name]! Item was changed: ----- Method: ChangesOrganizer class>>allChangeSetsWithClass:selector: (in category 'enumerating') ----- allChangeSetsWithClass: class selector: selector + + ^ ChangeSet allChangeSetsWithClass: class selector: selector! - class ifNil: [^ #()]. - ^ self allChangeSets select: - [:cs | (cs atSelector: selector class: class) ~~ #none]! Item was changed: ----- Method: ChangesOrganizer class>>buildAggregateChangeSet (in category 'services') ----- buildAggregateChangeSet + + ^ ChangeSet buildAggregateChangeSet! - "Establish a change-set named Aggregate which bears the union of all the changes in all the existing change-sets in the system (other than any pre-existing Aggregate). This can be useful when wishing to discover potential conflicts between a disk-resident change-set and an image. Formerly very useful, now some of its unique contributions have been overtaken by new features" - - | aggregateChangeSet | - aggregateChangeSet := self existingOrNewChangeSetNamed: 'Aggregate'. - aggregateChangeSet clear. - self allChangeSets do: - [:aChangeSet | aChangeSet == aggregateChangeSet ifFalse: - [aggregateChangeSet assimilateAllChangesFoundIn: aChangeSet]] - - "ChangeSorter buildAggregateChangeSet" - - ! Item was changed: ----- Method: ChangesOrganizer class>>highestNumberedChangeSet (in category 'enumerating') ----- highestNumberedChangeSet + + ^ ChangeSet highestNumberedChangeSet! - "ChangeSorter highestNumberedChangeSet" - | aList | - aList := (ChangeSet allChangeSetNames select: [:aString | aString startsWithDigit] thenCollect: - [:aString | aString initialIntegerOrNil]). - ^ (aList size > 0) - ifTrue: - [aList max] - ifFalse: - [nil] - ! Item was changed: ----- Method: DualChangeSorter>>buildWith: (in category 'toolbuilder') ----- buildWith: builder | windowSpec window | leftCngSorter := ChangeSorter new myChangeSet: ChangeSet current. leftCngSorter parent: self. rightCngSorter := ChangeSorter new myChangeSet: + ChangeSet secondaryChangeSet. - ChangeSorter secondaryChangeSet. rightCngSorter parent: self. windowSpec := builder pluggableWindowSpec new. windowSpec model: self. windowSpec label: 'Change Sorter'. windowSpec children: OrderedCollection new. windowSpec label: #labelString. leftCngSorter buildWith: builder in: windowSpec rect: (0@0 extent: 0.5@1). rightCngSorter buildWith: builder in: windowSpec rect: (0.5@0 extent: 0.5@1). window := builder build: windowSpec. leftCngSorter addDependent: window. "so it will get changed: #relabel" rightCngSorter addDependent: window. "so it will get changed: #relabel" ^window!

1 0

The Trunk: System-pre.1090.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Patrick Rein uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-pre.1090.mcz ==================== Summary ==================== Name: System-pre.1090 Author: pre Time: 3 September 2019, 5:06:59.772361 pm UUID: 77f000d9-683d-d146-89d0-ac2dc4882362 Ancestors: System-mt.1089 Minor refactoring of a ChangeSet enumerating method in the context of a larger refactoring deprecating some organizing methods on ChangeSorter =============== Diff against System-mt.1089 =============== Item was changed: ----- Method: ChangeSet class>>highestNumberedChangeSet (in category 'enumerating') ----- highestNumberedChangeSet + - "ChangeSorter highestNumberedChangeSet" | aList | + aList := self allChangeSetNames + select: [:aString | aString startsWithDigit] + thenCollect: [:aString | aString initialIntegerOrNil]. + ^ aList + ifNotEmpty: [aList max] + ifEmpty: [nil] - aList := (self allChangeSetNames select: [:aString | aString startsWithDigit] thenCollect: - [:aString | aString initialIntegerOrNil]). - ^ (aList size > 0) - ifTrue: - [aList max] - ifFalse: - [nil] !

1 0

The Trunk: 60Deprecated-pre.45.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Patrick Rein uploaded a new version of 60Deprecated to project The Trunk: http://source.squeak.org/trunk/60Deprecated-pre.45.mcz ==================== Summary ==================== Name: 60Deprecated-pre.45 Author: pre Time: 3 September 2019, 4:54:15.647361 pm UUID: df9fca0c-6e72-8d4a-9e2b-a1bd0a236cb8 Ancestors: 60Deprecated-mt.44 Deprecates file reader registration methods on FileList =============== Diff against 60Deprecated-mt.44 =============== Item was added: + ----- Method: FileList class>>allRegisteredServices (in category '*60Deprecated-Tools-file reader registration') ----- + allRegisteredServices + + | col | + self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. + col := OrderedCollection new. + self registeredFileReaderClasses do: [:each | col addAll: (each services)]. + ^ col! Item was added: + ----- Method: FileList class>>detectService:ifNone: (in category '*60Deprecated-Tools-file reader registration') ----- + detectService: aBlock ifNone: anotherBlock + "self detectService: [:each | each selector = #fileIn:] ifNone: [nil]" + + self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. + ^ self allRegisteredServices + detect: aBlock + ifNone: anotherBlock! Item was added: + ----- Method: FileList class>>isReaderNamedRegistered: (in category '*60Deprecated-Tools-file reader registration') ----- + isReaderNamedRegistered: aSymbol + "return if a given reader class has been registered. Note that this is on purpose that the argument is + a symbol and not a class" + + self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. + ^ (self registeredFileReaderClasses collect: [:each | each name]) includes: aSymbol + ! Item was added: + ----- Method: FileList class>>itemsForDirectory: (in category '*60Deprecated-Tools-file reader registration') ----- + itemsForDirectory: aFileDirectory + "Answer a list of services appropriate when no file is selected." + + | services | + self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. + services := OrderedCollection new. + self registeredFileReaderClasses do: [:reader | + reader ifNotNil: [services addAll: (reader fileReaderServicesForDirectory: aFileDirectory) ]]. + ^ services! Item was added: + ----- Method: FileList class>>itemsForFile: (in category '*60Deprecated-Tools-file reader registration') ----- + itemsForFile: fullName + "Answer a list of services appropriate for a file of the given full name" + + | services suffix | + self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. + suffix := self suffixOf: fullName. + services := OrderedCollection new. + self registeredFileReaderClasses do: [:reader | + reader ifNotNil: [services addAll: (reader fileReaderServicesForFile: fullName suffix: suffix)]]. + ^ services! Item was added: + ----- Method: FileList class>>registerFileReader: (in category '*60Deprecated-Tools-file reader registration') ----- + registerFileReader: aProviderClass + "register the given class as providing services for reading files" + + | registeredReaders | + self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. + registeredReaders := self registeredFileReaderClasses. + (registeredReaders includes: aProviderClass) + ifFalse: [ registeredReaders addLast: aProviderClass ]! Item was added: + ----- Method: FileList class>>registeredFileReaderClasses (in category '*60Deprecated-Tools-file reader registration') ----- + registeredFileReaderClasses + + self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. + FileReaderRegistry := nil. "wipe it out" + ^FileServices registeredFileReaderClasses + ! Item was added: + ----- Method: FileList class>>suffixOf: (in category '*60Deprecated-Tools-file reader registration') ----- + suffixOf: aName + "Answer the file extension of the given file" + + self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. + ^ aName + ifNil: + [''] + ifNotNil: + [(FileDirectory extensionFor: aName) asLowercase]! Item was added: + ----- Method: FileList class>>unregisterFileReader: (in category '*60Deprecated-Tools-file reader registration') ----- + unregisterFileReader: aProviderClass + "unregister the given class as providing services for reading files" + + self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. + self registeredFileReaderClasses remove: aProviderClass ifAbsent: [nil]!

1 0

The Trunk: Tools-pre.882.mcz
by commits＠source.squeak.org 03 Sep '19

03 Sep '19

Patrick Rein uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-pre.882.mcz ==================== Summary ==================== Name: Tools-pre.882 Author: pre Time: 3 September 2019, 4:53:34.544361 pm UUID: f593a50e-ceef-8045-b6b7-f36d63cb01dd Ancestors: Tools-mt.881 Deprecates file reader registration methods on FileList =============== Diff against Tools-mt.881 =============== Item was removed: - ----- Method: FileList class>>allRegisteredServices (in category 'file reader registration') ----- - allRegisteredServices - "self allRegisteredServices" - - | col | - col := OrderedCollection new. - self registeredFileReaderClasses do: [:each | col addAll: (each services)]. - ^ col! Item was removed: - ----- Method: FileList class>>detectService:ifNone: (in category 'file reader registration') ----- - detectService: aBlock ifNone: anotherBlock - "self detectService: [:each | each selector = #fileIn:] ifNone: [nil]" - - ^ self allRegisteredServices - detect: aBlock - ifNone: anotherBlock! Item was removed: - ----- Method: FileList class>>isReaderNamedRegistered: (in category 'file reader registration') ----- - isReaderNamedRegistered: aSymbol - "return if a given reader class has been registered. Note that this is on purpose that the argument is - a symbol and not a class" - - ^ (self registeredFileReaderClasses collect: [:each | each name]) includes: aSymbol - ! Item was removed: - ----- Method: FileList class>>itemsForDirectory: (in category 'file reader registration') ----- - itemsForDirectory: aFileDirectory - "Answer a list of services appropriate when no file is selected." - - | services | - services := OrderedCollection new. - self registeredFileReaderClasses do: [:reader | - reader ifNotNil: [services addAll: (reader fileReaderServicesForDirectory: aFileDirectory) ]]. - ^ services! Item was removed: - ----- Method: FileList class>>itemsForFile: (in category 'file reader registration') ----- - itemsForFile: fullName - "Answer a list of services appropriate for a file of the given full name" - - | services suffix | - suffix := self suffixOf: fullName. - services := OrderedCollection new. - self registeredFileReaderClasses do: [:reader | - reader ifNotNil: [services addAll: (reader fileReaderServicesForFile: fullName suffix: suffix)]]. - ^ services! Item was removed: - ----- Method: FileList class>>registerFileReader: (in category 'file reader registration') ----- - registerFileReader: aProviderClass - "register the given class as providing services for reading files" - - | registeredReaders | - registeredReaders := self registeredFileReaderClasses. - (registeredReaders includes: aProviderClass) - ifFalse: [ registeredReaders addLast: aProviderClass ]! Item was removed: - ----- Method: FileList class>>registeredFileReaderClasses (in category 'file reader registration') ----- - registeredFileReaderClasses - FileReaderRegistry := nil. "wipe it out" - ^FileServices registeredFileReaderClasses - ! Item was removed: - ----- Method: FileList class>>suffixOf: (in category 'file reader registration') ----- - suffixOf: aName - "Answer the file extension of the given file" - ^ aName - ifNil: - [''] - ifNotNil: - [(FileDirectory extensionFor: aName) asLowercase]! Item was removed: - ----- Method: FileList class>>unregisterFileReader: (in category 'file reader registration') ----- - unregisterFileReader: aProviderClass - "unregister the given class as providing services for reading files" - - self registeredFileReaderClasses remove: aProviderClass ifAbsent: [nil]! Item was changed: ----- Method: FileList2 class>>endingSpecs (in category 'blue ui') ----- endingSpecs "Answer a collection of specs to build the selective 'find anything' tool called by the Navigator. This version uses the services registry to do so." "FileList2 morphicViewGeneralLoaderInWorld: World" | categories specs rejects | rejects := #(addFileToNewZip: compressFile: openInZipViewer: extractAllFrom: openOn:). categories := #( ('Art' ('bmp' 'gif' 'jpg' 'jpeg' 'form' 'png' 'pcx' 'xbm' 'xpm' 'ppm' 'pbm')) ('Morphs' ('morph' 'morphs' 'sp')) ('Projects' ('extseg' 'project' 'pr')) ('MIDI' ('mid' 'midi')) ('Music' ('mp3')) ('Movies' ('movie' 'mpg' 'mpeg' 'qt' 'mov')) ('Flash' ('swf')) ). "('Books' ('bo'))" "('Code' ('st' 'cs'))" "('TrueType' ('ttf'))" "('3ds' ('3ds'))" "('Tape' ('tape'))" "('Wonderland' ('wrl'))" "('HTML' ('htm' 'html'))" categories first at: 2 put: ImageReadWriter allTypicalFileExtensions. specs := OrderedCollection new. categories do: [ :cat | | catSpecs catServices okExtensions services | services := Dictionary new. catSpecs := Array new: 3. catServices := OrderedCollection new. okExtensions := Set new. + cat second do: [ :ext | (FileServices itemsForFile: (FileDirectory default fullPathFor: ('fred.',ext))) do: [ :i | - cat second do: [ :ext | (FileList itemsForFile: (FileDirectory default fullPathFor: ('fred.',ext))) do: [ :i | (rejects includes: i selector) ifFalse: [ okExtensions add: ext. services at: i label put: i ]]]. services do: [ :svc | catServices add: svc ]. services isEmpty ifFalse: [ catSpecs at: 1 put: cat first; at: 2 put: okExtensions; at: 3 put: catServices. specs add: catSpecs ] ]. ^specs !

1 0

Jump to page: