Squeak-dev July 2019

squeak-dev@lists.squeakfoundation.org

44 participants
160 discussions

The Inbox: ToolBuilder-Morphic-ct.228.mcz
by commits＠source.squeak.org 07 Jul '19

07 Jul '19

A new version of ToolBuilder-Morphic was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Morphic-ct.228.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-ct.228 Author: ct Time: 7 July 2019, 7:57:32.634178 pm UUID: fa6c1281-afb6-d34d-aeb4-ca2428d2c2d8 Ancestors: ToolBuilder-Morphic-pre.227 Add optional parameter for the #aboutToStyle: call You can now, optionally, implement #aboutToStyle:forMorph: instead of #aboutToStyle:. =============== Diff against ToolBuilder-Morphic-pre.227 =============== Item was changed: ----- Method: PluggableTextMorphPlus>>okToStyle (in category 'testing') ----- okToStyle ^ styler ifNil:[false] + ifNotNil: [:s | (model class canUnderstand: #aboutToStyle:forMorph:) + ifTrue: [model aboutToStyle: s forMorph: self] + ifFalse: [model aboutToStyle: s]]! - ifNotNil: [:s | model aboutToStyle: s]!

1 0

The Inbox: Chronology-Core-dtl.48.mcz
by commits＠source.squeak.org 05 Jul '19

05 Jul '19

A new version of Chronology-Core was added to project The Inbox: http://source.squeak.org/inbox/Chronology-Core-dtl.48.mcz ==================== Summary ==================== Name: Chronology-Core-dtl.48 Author: dtl Time: 5 July 2019, 1:08:16.059032 pm UUID: 7f33ce2e-ae95-48ef-a526-63da7ddfd885 Ancestors: Chronology-Core-cmm.47 Fix fallback code for primPosixMicrosecondClockWithOffset: to not allow DateAndTime class>>now to create an instance with nil instance variables. Previous fallback code was a cut and paste error, never worked as intended. Rationale for the fallback handling: Corrupt DateAndTime can quickly lead to a broken image. A default value of the Posix epoch is easily recognized as un uninitialized DateAndTime. To test, evaluate "Time clockPolicy: #acceptPlatformTime" and comment out the primitive call in Time class>>primPosixMicrosecondClockWithOffset: to simulate the case of a VM that does not provide primitiveUtcWithOffset. In this case, DateAndTime now produces 1970-01-01T00:00:00+00:00. After testing, do Time initialze to restore clock policy. =============== Diff against Chronology-Core-cmm.47 =============== Item was changed: ----- Method: Time class>>posixMicrosecondClockWithOffset: (in category 'clock') ----- posixMicrosecondClockWithOffset: aDateAndTime "Initialize aDateAndTime initialized with local microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone." | utcValue | self primPosixMicrosecondClockWithOffset: aDateAndTime. - aDateAndTime utcMicroseconds ifNil: [ ^aDateAndTime]. "primitive failed" ClockPolicy caseOf: { [#acceptPlatformTime] -> [^ aDateAndTime] . [#monotonicAllowDuplicates] -> [ utcValue := aDateAndTime utcMicroseconds. utcValue > LastClockTick ifTrue: [LastClockTick := utcValue] ifFalse: [aDateAndTime utcMicroseconds: LastClockTick]] . [#monotonicForceMicrosecondIncrement] -> [ utcValue := aDateAndTime utcMicroseconds. utcValue > LastClockTick ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + 1. "add one microsecond" aDateAndTime utcMicroseconds: LastClockTick]] . [#monotonicForceNanosecondIncrement] -> [ utcValue := aDateAndTime utcMicroseconds. utcValue > LastClockTick ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + (1 / 1000). "add one nanosecond" aDateAndTime utcMicroseconds: LastClockTick]] } otherwise: []. ^aDateAndTime ! Item was changed: ----- Method: Time class>>primPosixMicrosecondClockWithOffset: (in category 'private') ----- primPosixMicrosecondClockWithOffset: arrayOrObjectWithTwoSlots "Answer an array with UTC microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone. If the primitive is not available, then answer the time and offset of Posix epoch GMT. This enables the image to continue running in the absence of #primitiveUtcWithOffset, thus avoiding the need to fallback code based on the earlier local microsecond clock mechanism. The parameter may be a two element array, or an object whose first two instance variables are expected to be UTC microseconds and seconds offset from GMT." <primitive: 'primitiveUtcWithOffset'> + + (arrayOrObjectWithTwoSlots instVarAt: 1) + ifNil: [arrayOrObjectWithTwoSlots instVarAt: 1 put: 0]. + (arrayOrObjectWithTwoSlots instVarAt: 2) + ifNil: [arrayOrObjectWithTwoSlots instVarAt: 2 put: 0]! - ^{0. 0}!

2 1

The Trunk: Morphic-cmfcmf.1490.mcz
by commits＠source.squeak.org 05 Jul '19

05 Jul '19

David T. Lewis uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-cmfcmf.1490.mcz ==================== Summary ==================== Name: Morphic-cmfcmf.1490 Author: cmfcmf Time: 30 June 2019, 12:04:13.370226 pm UUID: ab2320d7-f8f4-df46-a786-ec28230e912c Ancestors: Morphic-pre.1489 When wrapping a Morph into a flex shell, first add the flex shell to the Morph's owner (and thus to the Morph's world) before making the Morph a submorph of the flex shell. This avoids unnecessarily sending outOfWorld: to the Morph when adding it to the new flex shell (which doesn't have a world after creation) and intoWorld: when adding the flex shell to the Morph's owner right thereafter. =============== Diff against Morphic-pre.1489 =============== Item was changed: ----- Method: Morph>>addFlexShell (in category 'rotate scale and flex') ----- addFlexShell "Wrap a rotating and scaling shell around this morph." | oldHalo myWorld flexMorph anIndex | - oldHalo:= self halo. myWorld := self world. self owner ifNil: [flexMorph := self newTransformationMorph asFlexOf: self] ifNotNil: [:myOwner | anIndex := myOwner submorphIndexOf: self. + "Avoid triggering outOfWorld: on self by first adding flexMorph to myOwner and only then making myself a submorph of flexMorph via asFlexOf:" + flexMorph := self newTransformationMorph. - flexMorph := self newTransformationMorph asFlexOf: self. myOwner addMorph: flexMorph asElementNumber: anIndex. + flexMorph asFlexOf: self. myWorld ifNotNil: [myWorld startSteppingSubmorphsOf: flexMorph]]. self transferStateToRenderer: flexMorph. oldHalo ifNotNil: [oldHalo setTarget: flexMorph]. ^ flexMorph!

1 0

The Inbox: Collections-mt.838.mcz
by commits＠source.squeak.org 05 Jul '19

05 Jul '19

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-mt.838.mcz ==================== Summary ==================== Name: Collections-mt.838 Author: mt Time: 4 July 2019, 4:32:40.854026 pm UUID: ac4ab442-79c0-d246-8dec-914be7ee5356 Ancestors: Collections-pre.837 To String, adds simple analysis of natural language in source code. No word stemming. 1) Refactor #findTokens: to look like #lines (i.e. #linesDo: and #lineIndicesDo:). 2) Add #findFeaturesDo: like #findTokens:do: and #linesDo:. Try this: HTTPDownloadRequest name findFeatures. (Morph >> #drawOn:) getSource asString findFeatures. Where can that be useful? - Automatic insertion of "*" for search terms like "WeakDictionary" to also find WeakIdentityDictionary etc. - Prefix emphasis for names lists of classes in code browsers: MCAddition, MCAncestry, etc. =============== Diff against Collections-pre.837 =============== Item was added: + ----- Method: String>>findFeatureIndicesDo: (in category 'accessing - features') ----- + findFeatureIndicesDo: aBlock + "State machine that separates camelCase, UPPERCase, number/operator combinations and skips colons" + | last state char "0 = start, 1 = a, 2 = A, 3 = AA, 4 = num, 5 = op" | + + state := 0. + last := 1. + + 1 to: self size do: [ :index | + char := self at: index. + "a" + char isLowercase ifTrue: [ + (state < 3) ifTrue: [state := 1]. "*a -> a" + (state == 3) ifTrue: [ + "AAa -> A + Aa (camel case follows uppercase)" + aBlock value: last value: index - 2. + last := index - 1. + state := 2]. + (state > 3) ifTrue: [ + "+a -> + | a (letter follows non-letter)" + aBlock value: last value: index - 1. + last := index. + state := 1]] + ifFalse: [ + char isUppercase ifTrue: [ + (state == 0) + ifTrue: [state := 2] "start -> A" + ifFalse: [ + (state < 2 or: [state > 3]) ifTrue: [ + "*A -> * | A (uppercase begins, flush before)" + aBlock value: last value: index - 1. + last := index. + state := 2] ifFalse: [ + "AA -> AA (uppercase continues)" + state := 3]]] + ifFalse: [ + ("char == $: or:" char isSeparator) ifTrue: [ + "skip colon/whitespace" + (state > 0) ifTrue: [ + aBlock value: last value: index - 1. + state := 0]. + last := index + 1] + ifFalse: [ + char isDigit ifTrue: [ + (state == 0) + ifTrue: [state := 4] + ifFalse: [ + (state ~= 4) ifTrue: [ + aBlock value: last value: index - 1. + last := index. + state := 4]]] + ifFalse: [ + (state == 0) + ifTrue: [state := 5] + ifFalse: [ + (state < 5) ifTrue: [ + aBlock value: last value: index - 1. + last := index. + state := 5]]]]]]]. + last <= self size ifTrue: [ + aBlock value: last value: self size]! Item was added: + ----- Method: String>>findFeatures (in category 'accessing - features') ----- + findFeatures + + ^ Array streamContents: [:features | + self findFeaturesDo: [:feature | features nextPut: feature]]! Item was added: + ----- Method: String>>findFeaturesDo: (in category 'accessing - features') ----- + findFeaturesDo: aBlock + "Simple analysis for natural language in source code. No support for word stemming." + + self findFeatureIndicesDo: [:start :end | + (self at: start) isLetter ifTrue: [ + aBlock value: (self copyFrom: start to: end) asLowercase]].! Item was changed: ----- Method: String>>findTokens: (in category 'accessing') ----- findTokens: delimiters + "Answer the collection of tokens that result from parsing self." + + ^ OrderedCollection streamContents: [:tokens | + self + findTokens: delimiters + do: [:token | tokens nextPut: token]]! - "Answer the collection of tokens that result from parsing self. Return strings between the delimiters. Any character in the Collection delimiters marks a border. Several delimiters in a row are considered as just one separation. Also, allow delimiters to be a single character." - - | tokens keyStart keyStop separators | - - tokens := OrderedCollection new. - separators := delimiters isCharacter - ifTrue: [Array with: delimiters] - ifFalse: [delimiters]. - keyStop := 1. - [keyStop <= self size] whileTrue: - [keyStart := self skipDelimiters: separators startingAt: keyStop. - keyStop := self findDelimiters: separators startingAt: keyStart. - keyStart < keyStop - ifTrue: [tokens add: (self copyFrom: keyStart to: (keyStop - 1))]]. - ^tokens! Item was added: + ----- Method: String>>findTokens:do: (in category 'accessing') ----- + findTokens: delimiters do: aBlock + + self + findTokens: delimiters + indicesDo: [:start :end | aBlock value: (self copyFrom: start to: end)].! Item was added: + ----- Method: String>>findTokens:indicesDo: (in category 'accessing') ----- + findTokens: delimiters indicesDo: aBlock + "Parse self to find tokens between delimiters. Any character in the Collection delimiters marks a border. Several delimiters in a row are considered as just one separation. Also, allow delimiters to be a single character. Similar to #lineIndicesDo:." + + | tokens keyStart keyStop separators | + separators := delimiters isCharacter + ifTrue: [Array with: delimiters] + ifFalse: [delimiters]. + keyStop := 1. + [keyStop <= self size] whileTrue: [ + keyStart := self skipDelimiters: separators startingAt: keyStop. + keyStop := self findDelimiters: separators startingAt: keyStart. + keyStart < keyStop + ifTrue: [aBlock value: keyStart value: keyStop - 1]].!

3 3

The Inbox: CollectionsTests-mt.313.mcz
by commits＠source.squeak.org 05 Jul '19

05 Jul '19

A new version of CollectionsTests was added to project The Inbox: http://source.squeak.org/inbox/CollectionsTests-mt.313.mcz ==================== Summary ==================== Name: CollectionsTests-mt.313 Author: mt Time: 5 July 2019, 4:55:01.111089 pm UUID: a8af1eda-b723-2940-8838-912b24df886a Ancestors: CollectionsTests-pre.312 Adds tests for Collections-mt.839. =============== Diff against CollectionsTests-pre.312 =============== Item was added: + ----- Method: StringTest>>testFindFeatures (in category 'tests - tokenizing') ----- + testFindFeatures + + { + "input . expected features" + 'camelCase' . #('camel' 'Case'). + 'UPPERCase' . #('UPPER' 'Case'). + 'MyModel55' . #('My' 'Model' '55'). + '5 <= 4' . #('5' '<=' '4'). + '[state := 2]' . #('[' 'state' ':=' '2' ']'). + } pairsDo: [:input :features | + | output | + output := features readStream. + input findFeatureIndicesDo: [:start :end | + self + assert: output next + equals: (input copyFrom: start to: end)]].!

1 0

The Inbox: Collections-mt.839.mcz
by commits＠source.squeak.org 05 Jul '19

05 Jul '19

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-mt.839.mcz ==================== Summary ==================== Name: Collections-mt.839 Author: mt Time: 5 July 2019, 4:54:03.194089 pm UUID: 76695fa3-7ed2-cb4e-8c6e-b33c83dd526f Ancestors: Collections-mt.838 Improves code commentary, structure, and performance. Thanks Levente for the tips! (Adds tests for #findFeatures in CollectionsTests-mt.313). =============== Diff against Collections-mt.838 =============== Item was changed: ----- Method: String>>findFeatureIndicesDo: (in category 'accessing - features') ----- findFeatureIndicesDo: aBlock + "Support for simple analysis of natural language in source code. - "State machine that separates camelCase, UPPERCase, number/operator combinations and skips colons" - | last state char "0 = start, 1 = a, 2 = A, 3 = AA, 4 = num, 5 = op" | + In addition to whitespace separation like #findTokens:, also separate features using higher-level rules: + (1) 'camelCase' -> #('camel' 'Case'), + (2) 'UPPERCase' -> #('UPPER' 'Case'), + (3) integer numbers such as 'MyModel55' -> #('My' 'Model' '55'), and + (4) operators such as '5 <= 4' -> #('5' '<=' '4'). + Other kinds of characters are tokenized as operators: '[state := 2]' -> #('[' 'state' ':=' '2' ']'). - state := 0. - last := 1. + This method works like #lineIndicesDo: and provides start/stop indices of tokens to the given aBlock to, for example, extract and normalize features (or tokens)." + + | last state char | + state := 0. "0 = start, 1 = a, 2 = A, 3 = AA, 4 = num, 5 = op" + last := 1. "last character index" + 1 to: self size do: [ :index | char := self at: index. + + char isLowercase + ifTrue: [ "a" + state < 3 ifTrue: [state := 1]. "*a -> a" + state = 3 ifTrue: [ + "AAa -> A + Aa (camel case follows uppercase)" + aBlock value: last value: index - 2. + last := index - 1. + state := 2]. + state > 3 ifTrue: [ + "+a -> + | a (letter follows non-letter)" + aBlock value: last value: index - 1. + last := index. + state := 1]] - "a" - char isLowercase ifTrue: [ - (state < 3) ifTrue: [state := 1]. "*a -> a" - (state == 3) ifTrue: [ - "AAa -> A + Aa (camel case follows uppercase)" - aBlock value: last value: index - 2. - last := index - 1. - state := 2]. - (state > 3) ifTrue: [ - "+a -> + | a (letter follows non-letter)" - aBlock value: last value: index - 1. - last := index. - state := 1]] - ifFalse: [ - char isUppercase ifTrue: [ - (state == 0) - ifTrue: [state := 2] "start -> A" - ifFalse: [ - (state < 2 or: [state > 3]) ifTrue: [ - "*A -> * | A (uppercase begins, flush before)" - aBlock value: last value: index - 1. - last := index. - state := 2] ifFalse: [ - "AA -> AA (uppercase continues)" - state := 3]]] ifFalse: [ + char isUppercase + ifTrue: [ "A" + state = 0 + ifTrue: [state := 2] "start -> A" - ("char == $: or:" char isSeparator) ifTrue: [ - "skip colon/whitespace" - (state > 0) ifTrue: [ - aBlock value: last value: index - 1. - state := 0]. - last := index + 1] - ifFalse: [ - char isDigit ifTrue: [ - (state == 0) - ifTrue: [state := 4] ifFalse: [ + (state < 2) | (state > 3) ifTrue: [ + "*A -> * | A (uppercase begins, flush before)" + aBlock value: last value: index - 1. + last := index. + state := 2] ifFalse: [ + "AA -> AA (uppercase continues)" + state := 3]]] + ifFalse: [ + char isSeparator + ifTrue: [ " " + "skip whitespace" + state > 0 ifTrue: [ + aBlock value: last value: index - 1. + state := 0]. + last := index + 1] + ifFalse: [ + + char isDigit + ifTrue: [ "num" + state = 0 + ifTrue: [state := 4] + ifFalse: [ + state ~= 4 ifTrue: [ + aBlock value: last value: index - 1. + last := index. + state := 4]]] + ifFalse: [ "op" + state = 0 + ifTrue: [state := 5] + ifFalse: [ + state < 5 ifTrue: [ + aBlock value: last value: index - 1. + last := index. + state := 5]] ] ] ] ] ]. - (state ~= 4) ifTrue: [ - aBlock value: last value: index - 1. - last := index. - state := 4]]] - ifFalse: [ - (state == 0) - ifTrue: [state := 5] - ifFalse: [ - (state < 5) ifTrue: [ - aBlock value: last value: index - 1. - last := index. - state := 5]]]]]]]. last <= self size ifTrue: [ aBlock value: last value: self size]! Item was changed: ----- Method: String>>findFeaturesDo: (in category 'accessing - features') ----- findFeaturesDo: aBlock + "Simple analysis of natural language in source code. Select all features that are letters only, normalize them as lowercase. No support for word stemming. + + Example: + 'Transcript show: 123 asString; cr; show: #HelloWorld.' + -> #('transcript' 'show' 'as' 'string' 'cr' 'show' 'hello' 'world') + " - "Simple analysis for natural language in source code. No support for word stemming." self findFeatureIndicesDo: [:start :end | (self at: start) isLetter ifTrue: [ aBlock value: (self copyFrom: start to: end) asLowercase]].! Item was added: + ----- Method: String>>findTokens (in category 'accessing - tokens') ----- + findTokens + + ^ self findTokens: Character separators! Item was changed: ----- Method: String>>findTokens: (in category 'accessing') ----- findTokens: delimiters + "Answer the collection of tokens between delimiters, which results from parsing self." - "Answer the collection of tokens that result from parsing self." + | tokens | + tokens := OrderedCollection new. + self + findTokens: delimiters + do: [:token | tokens addLast: token]. + ^ tokens! - ^ OrderedCollection streamContents: [:tokens | - self - findTokens: delimiters - do: [:token | tokens nextPut: token]]! Item was changed: + ----- Method: String>>findTokens:do: (in category 'accessing - tokens') ----- - ----- Method: String>>findTokens:do: (in category 'accessing') ----- findTokens: delimiters do: aBlock self findTokens: delimiters indicesDo: [:start :end | aBlock value: (self copyFrom: start to: end)].! Item was changed: + ----- Method: String>>findTokens:indicesDo: (in category 'accessing - tokens') ----- + findTokens: oneOrMoreCharacters indicesDo: aBlock + "Parse self to find tokens between delimiters. Any character in the Collection delimiters marks a border. Several delimiters in a row are considered as just one separation. The interface is similar to #lineIndicesDo:." - ----- Method: String>>findTokens:indicesDo: (in category 'accessing') ----- - findTokens: delimiters indicesDo: aBlock - "Parse self to find tokens between delimiters. Any character in the Collection delimiters marks a border. Several delimiters in a row are considered as just one separation. Also, allow delimiters to be a single character. Similar to #lineIndicesDo:." + | keyStart keyStop separators size | + size := self size. + separators := oneOrMoreCharacters isCharacter + ifTrue: [{oneOrMoreCharacters}] + ifFalse: [oneOrMoreCharacters]. - | tokens keyStart keyStop separators | - separators := delimiters isCharacter - ifTrue: [Array with: delimiters] - ifFalse: [delimiters]. keyStop := 1. + [keyStop <= size] whileTrue: [ - [keyStop <= self size] whileTrue: [ keyStart := self skipDelimiters: separators startingAt: keyStop. keyStop := self findDelimiters: separators startingAt: keyStart. keyStart < keyStop ifTrue: [aBlock value: keyStart value: keyStop - 1]].!

1 0

The Trunk: Tests-mt.412.mcz
by commits＠source.squeak.org 05 Jul '19

05 Jul '19

Marcel Taeumel uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-mt.412.mcz ==================== Summary ==================== Name: Tests-mt.412 Author: mt Time: 5 July 2019, 4:19:48.095927 pm UUID: 2c15b9f3-d33e-42b6-b9f5-bab98e2f6d03 Ancestors: Tests-pre.411 Fixes max-literals test for EncoderV3* (i.e., pre-SistaV1). =============== Diff against Tests-pre.411 =============== Item was changed: ----- Method: CompilerTest>>testMaxLiteralsWithClassReferenceInClosure (in category 'limits') ----- testMaxLiteralsWithClassReferenceInClosure "Document the maximum number of literals in a compiled method. A class reference in a closure reduces the maximum literals." | bytecodeSetEncoder maxLiterals stringThatCanBeCompiled stringWithOneTooManyLiterals | bytecodeSetEncoder := CompiledMethod preferredBytecodeSetEncoderClass new. maxLiterals := bytecodeSetEncoder maxNumLiterals - 2 "for selector & methodClass" + - (bytecodeSetEncoder supportsFullBlocks ifTrue: [1] ifFalse: [5 "For this example. See below"]) - - (bytecodeSetEncoder supportsFullBlocks ifTrue: [1] ifFalse: [0]) - 4 "for the implicit stream processing into which the brace construct is compiled: (Array braceStream: size) braceArray". stringThatCanBeCompiled := '[ DateAndTime now. Date today. Time ]. { ', (String streamContents: [:strm | 1 to: maxLiterals do: [:e | strm nextPutAll: '''', e asString, '''', ' . ']]), '}'. stringWithOneTooManyLiterals := '[ DateAndTime now. Date today. Time ]. { ', (String streamContents: [:strm | 1 to: maxLiterals + 1 do: [:e | strm nextPutAll: '''', e asString, '''', ' . ']]), '}'. self assert: maxLiterals equals: (Compiler evaluate: stringThatCanBeCompiled) size. "If the following test fails, it means that the limit has been raised or eliminated, and this test should be updated to reflect the improvement." self should: [Compiler evaluate: stringWithOneTooManyLiterals] raise: Error. !

1 0

Proposal | Remove SystemNavigation class >> #doesNotUnderstand:
by Marcel Taeumel 05 Jul '19

05 Jul '19

Hi, there. I just got really confused by the differences of [SystemNavigation allCallsOn: #drawOn:] bench. and [SystemNavigation default allCallsOn: #drawOn:] bench. because I expected that MNU fallback to kick in to insert "default" automatically. However, #allCallsOn: is actually implemented in Behavior and not just in SystemNavigation. Can we remove SystemNavigation class >> #doesNotUnderstand: so nobody starts relying on that? Best, Marcel

3 3

Tests | #testMaxLiteralsWithClassReferenceInClosure works for SistaV1 bytecode set but not V3PlusClosures
by Marcel Taeumel 05 Jul '19

05 Jul '19

Hi all! The test CompilerTest >> #testMaxLiteralsWithClassReferenceInClosure fails for V3PlusClosures. It is off by 5 literals. Could it be because V3PlusClosures inlines blocks in the same compiled method but SistaV1 extracts them into an extra compiled block? I was wondering whether that "[ DateAndTime now. Date today. Time ]." accounts for 5 literals ... even though I am only seeing 4. :-) Any thoughts? Best, Marcel

2 2

[Please Review] Refactoring for #literalsDo: etc.
by Marcel Taeumel 05 Jul '19

05 Jul '19

Hi, there. Please find attached a change set that (tries to) clean up everything related to enumerating or testing literals in CompiledCode, CompiledMethod, and CompiledBlock. I have three important questions: - The purpose of #hasLiteralThorough is not needed anymore because we enumerate and test always in a "thorough" way? - Are the enumeration boundaries in CompiledCode, CompiledMethod, CompiledBlock in #literalsDo: correct? - What is a literal as expected in #hasLiteral: etc. to answer true? Just symbols or also bindings (symbol-to-class) and classes themselves? Try exploring this result: "(Morph >> #fullDrawOn:) literals" or similar. Best, Marcel

4 10

Jump to page: