Squeak-dev July 2019

squeak-dev@lists.squeakfoundation.org

44 participants
160 discussions

The Trunk: Collections-mt.839.mcz
by commits＠source.squeak.org 11 Jul '19

11 Jul '19

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.839.mcz ==================== Summary ==================== Name: Collections-mt.839 Author: mt Time: 5 July 2019, 4:54:03.194089 pm UUID: 76695fa3-7ed2-cb4e-8c6e-b33c83dd526f Ancestors: Collections-mt.838 Improves code commentary, structure, and performance. Thanks Levente for the tips! (Adds tests for #findFeatures in CollectionsTests-mt.313). =============== Diff against Collections-mt.838 =============== Item was changed: ----- Method: String>>findFeatureIndicesDo: (in category 'accessing - features') ----- findFeatureIndicesDo: aBlock + "Support for simple analysis of natural language in source code. - "State machine that separates camelCase, UPPERCase, number/operator combinations and skips colons" - | last state char "0 = start, 1 = a, 2 = A, 3 = AA, 4 = num, 5 = op" | + In addition to whitespace separation like #findTokens:, also separate features using higher-level rules: + (1) 'camelCase' -> #('camel' 'Case'), + (2) 'UPPERCase' -> #('UPPER' 'Case'), + (3) integer numbers such as 'MyModel55' -> #('My' 'Model' '55'), and + (4) operators such as '5 <= 4' -> #('5' '<=' '4'). + Other kinds of characters are tokenized as operators: '[state := 2]' -> #('[' 'state' ':=' '2' ']'). - state := 0. - last := 1. + This method works like #lineIndicesDo: and provides start/stop indices of tokens to the given aBlock to, for example, extract and normalize features (or tokens)." + + | last state char | + state := 0. "0 = start, 1 = a, 2 = A, 3 = AA, 4 = num, 5 = op" + last := 1. "last character index" + 1 to: self size do: [ :index | char := self at: index. + + char isLowercase + ifTrue: [ "a" + state < 3 ifTrue: [state := 1]. "*a -> a" + state = 3 ifTrue: [ + "AAa -> A + Aa (camel case follows uppercase)" + aBlock value: last value: index - 2. + last := index - 1. + state := 2]. + state > 3 ifTrue: [ + "+a -> + | a (letter follows non-letter)" + aBlock value: last value: index - 1. + last := index. + state := 1]] - "a" - char isLowercase ifTrue: [ - (state < 3) ifTrue: [state := 1]. "*a -> a" - (state == 3) ifTrue: [ - "AAa -> A + Aa (camel case follows uppercase)" - aBlock value: last value: index - 2. - last := index - 1. - state := 2]. - (state > 3) ifTrue: [ - "+a -> + | a (letter follows non-letter)" - aBlock value: last value: index - 1. - last := index. - state := 1]] - ifFalse: [ - char isUppercase ifTrue: [ - (state == 0) - ifTrue: [state := 2] "start -> A" - ifFalse: [ - (state < 2 or: [state > 3]) ifTrue: [ - "*A -> * | A (uppercase begins, flush before)" - aBlock value: last value: index - 1. - last := index. - state := 2] ifFalse: [ - "AA -> AA (uppercase continues)" - state := 3]]] ifFalse: [ + char isUppercase + ifTrue: [ "A" + state = 0 + ifTrue: [state := 2] "start -> A" - ("char == $: or:" char isSeparator) ifTrue: [ - "skip colon/whitespace" - (state > 0) ifTrue: [ - aBlock value: last value: index - 1. - state := 0]. - last := index + 1] - ifFalse: [ - char isDigit ifTrue: [ - (state == 0) - ifTrue: [state := 4] ifFalse: [ + (state < 2) | (state > 3) ifTrue: [ + "*A -> * | A (uppercase begins, flush before)" + aBlock value: last value: index - 1. + last := index. + state := 2] ifFalse: [ + "AA -> AA (uppercase continues)" + state := 3]]] + ifFalse: [ + char isSeparator + ifTrue: [ " " + "skip whitespace" + state > 0 ifTrue: [ + aBlock value: last value: index - 1. + state := 0]. + last := index + 1] + ifFalse: [ + + char isDigit + ifTrue: [ "num" + state = 0 + ifTrue: [state := 4] + ifFalse: [ + state ~= 4 ifTrue: [ + aBlock value: last value: index - 1. + last := index. + state := 4]]] + ifFalse: [ "op" + state = 0 + ifTrue: [state := 5] + ifFalse: [ + state < 5 ifTrue: [ + aBlock value: last value: index - 1. + last := index. + state := 5]] ] ] ] ] ]. - (state ~= 4) ifTrue: [ - aBlock value: last value: index - 1. - last := index. - state := 4]]] - ifFalse: [ - (state == 0) - ifTrue: [state := 5] - ifFalse: [ - (state < 5) ifTrue: [ - aBlock value: last value: index - 1. - last := index. - state := 5]]]]]]]. last <= self size ifTrue: [ aBlock value: last value: self size]! Item was changed: ----- Method: String>>findFeaturesDo: (in category 'accessing - features') ----- findFeaturesDo: aBlock + "Simple analysis of natural language in source code. Select all features that are letters only, normalize them as lowercase. No support for word stemming. + + Example: + 'Transcript show: 123 asString; cr; show: #HelloWorld.' + -> #('transcript' 'show' 'as' 'string' 'cr' 'show' 'hello' 'world') + " - "Simple analysis for natural language in source code. No support for word stemming." self findFeatureIndicesDo: [:start :end | (self at: start) isLetter ifTrue: [ aBlock value: (self copyFrom: start to: end) asLowercase]].! Item was added: + ----- Method: String>>findTokens (in category 'accessing - tokens') ----- + findTokens + + ^ self findTokens: Character separators! Item was changed: ----- Method: String>>findTokens: (in category 'accessing') ----- findTokens: delimiters + "Answer the collection of tokens between delimiters, which results from parsing self." - "Answer the collection of tokens that result from parsing self." + | tokens | + tokens := OrderedCollection new. + self + findTokens: delimiters + do: [:token | tokens addLast: token]. + ^ tokens! - ^ OrderedCollection streamContents: [:tokens | - self - findTokens: delimiters - do: [:token | tokens nextPut: token]]! Item was changed: + ----- Method: String>>findTokens:do: (in category 'accessing - tokens') ----- - ----- Method: String>>findTokens:do: (in category 'accessing') ----- findTokens: delimiters do: aBlock self findTokens: delimiters indicesDo: [:start :end | aBlock value: (self copyFrom: start to: end)].! Item was changed: + ----- Method: String>>findTokens:indicesDo: (in category 'accessing - tokens') ----- + findTokens: oneOrMoreCharacters indicesDo: aBlock + "Parse self to find tokens between delimiters. Any character in the Collection delimiters marks a border. Several delimiters in a row are considered as just one separation. The interface is similar to #lineIndicesDo:." - ----- Method: String>>findTokens:indicesDo: (in category 'accessing') ----- - findTokens: delimiters indicesDo: aBlock - "Parse self to find tokens between delimiters. Any character in the Collection delimiters marks a border. Several delimiters in a row are considered as just one separation. Also, allow delimiters to be a single character. Similar to #lineIndicesDo:." + | keyStart keyStop separators size | + size := self size. + separators := oneOrMoreCharacters isCharacter + ifTrue: [{oneOrMoreCharacters}] + ifFalse: [oneOrMoreCharacters]. - | tokens keyStart keyStop separators | - separators := delimiters isCharacter - ifTrue: [Array with: delimiters] - ifFalse: [delimiters]. keyStop := 1. + [keyStop <= size] whileTrue: [ - [keyStop <= self size] whileTrue: [ keyStart := self skipDelimiters: separators startingAt: keyStop. keyStop := self findDelimiters: separators startingAt: keyStart. keyStart < keyStop ifTrue: [aBlock value: keyStart value: keyStop - 1]].!

1 0

The Trunk: Collections-mt.838.mcz
by commits＠source.squeak.org 11 Jul '19

11 Jul '19

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.838.mcz ==================== Summary ==================== Name: Collections-mt.838 Author: mt Time: 4 July 2019, 4:32:40.854026 pm UUID: ac4ab442-79c0-d246-8dec-914be7ee5356 Ancestors: Collections-pre.837 To String, adds simple analysis of natural language in source code. No word stemming. 1) Refactor #findTokens: to look like #lines (i.e. #linesDo: and #lineIndicesDo:). 2) Add #findFeaturesDo: like #findTokens:do: and #linesDo:. Try this: HTTPDownloadRequest name findFeatures. (Morph >> #drawOn:) getSource asString findFeatures. Where can that be useful? - Automatic insertion of "*" for search terms like "WeakDictionary" to also find WeakIdentityDictionary etc. - Prefix emphasis for names lists of classes in code browsers: MCAddition, MCAncestry, etc. =============== Diff against Collections-pre.837 =============== Item was added: + ----- Method: String>>findFeatureIndicesDo: (in category 'accessing - features') ----- + findFeatureIndicesDo: aBlock + "State machine that separates camelCase, UPPERCase, number/operator combinations and skips colons" + | last state char "0 = start, 1 = a, 2 = A, 3 = AA, 4 = num, 5 = op" | + + state := 0. + last := 1. + + 1 to: self size do: [ :index | + char := self at: index. + "a" + char isLowercase ifTrue: [ + (state < 3) ifTrue: [state := 1]. "*a -> a" + (state == 3) ifTrue: [ + "AAa -> A + Aa (camel case follows uppercase)" + aBlock value: last value: index - 2. + last := index - 1. + state := 2]. + (state > 3) ifTrue: [ + "+a -> + | a (letter follows non-letter)" + aBlock value: last value: index - 1. + last := index. + state := 1]] + ifFalse: [ + char isUppercase ifTrue: [ + (state == 0) + ifTrue: [state := 2] "start -> A" + ifFalse: [ + (state < 2 or: [state > 3]) ifTrue: [ + "*A -> * | A (uppercase begins, flush before)" + aBlock value: last value: index - 1. + last := index. + state := 2] ifFalse: [ + "AA -> AA (uppercase continues)" + state := 3]]] + ifFalse: [ + ("char == $: or:" char isSeparator) ifTrue: [ + "skip colon/whitespace" + (state > 0) ifTrue: [ + aBlock value: last value: index - 1. + state := 0]. + last := index + 1] + ifFalse: [ + char isDigit ifTrue: [ + (state == 0) + ifTrue: [state := 4] + ifFalse: [ + (state ~= 4) ifTrue: [ + aBlock value: last value: index - 1. + last := index. + state := 4]]] + ifFalse: [ + (state == 0) + ifTrue: [state := 5] + ifFalse: [ + (state < 5) ifTrue: [ + aBlock value: last value: index - 1. + last := index. + state := 5]]]]]]]. + last <= self size ifTrue: [ + aBlock value: last value: self size]! Item was added: + ----- Method: String>>findFeatures (in category 'accessing - features') ----- + findFeatures + + ^ Array streamContents: [:features | + self findFeaturesDo: [:feature | features nextPut: feature]]! Item was added: + ----- Method: String>>findFeaturesDo: (in category 'accessing - features') ----- + findFeaturesDo: aBlock + "Simple analysis for natural language in source code. No support for word stemming." + + self findFeatureIndicesDo: [:start :end | + (self at: start) isLetter ifTrue: [ + aBlock value: (self copyFrom: start to: end) asLowercase]].! Item was changed: ----- Method: String>>findTokens: (in category 'accessing') ----- findTokens: delimiters + "Answer the collection of tokens that result from parsing self." + + ^ OrderedCollection streamContents: [:tokens | + self + findTokens: delimiters + do: [:token | tokens nextPut: token]]! - "Answer the collection of tokens that result from parsing self. Return strings between the delimiters. Any character in the Collection delimiters marks a border. Several delimiters in a row are considered as just one separation. Also, allow delimiters to be a single character." - - | tokens keyStart keyStop separators | - - tokens := OrderedCollection new. - separators := delimiters isCharacter - ifTrue: [Array with: delimiters] - ifFalse: [delimiters]. - keyStop := 1. - [keyStop <= self size] whileTrue: - [keyStart := self skipDelimiters: separators startingAt: keyStop. - keyStop := self findDelimiters: separators startingAt: keyStart. - keyStart < keyStop - ifTrue: [tokens add: (self copyFrom: keyStart to: (keyStop - 1))]]. - ^tokens! Item was added: + ----- Method: String>>findTokens:do: (in category 'accessing') ----- + findTokens: delimiters do: aBlock + + self + findTokens: delimiters + indicesDo: [:start :end | aBlock value: (self copyFrom: start to: end)].! Item was added: + ----- Method: String>>findTokens:indicesDo: (in category 'accessing') ----- + findTokens: delimiters indicesDo: aBlock + "Parse self to find tokens between delimiters. Any character in the Collection delimiters marks a border. Several delimiters in a row are considered as just one separation. Also, allow delimiters to be a single character. Similar to #lineIndicesDo:." + + | tokens keyStart keyStop separators | + separators := delimiters isCharacter + ifTrue: [Array with: delimiters] + ifFalse: [delimiters]. + keyStop := 1. + [keyStop <= self size] whileTrue: [ + keyStart := self skipDelimiters: separators startingAt: keyStop. + keyStop := self findDelimiters: separators startingAt: keyStart. + keyStart < keyStop + ifTrue: [aBlock value: keyStart value: keyStop - 1]].!

1 0

Star/Alto emulator
by tim Rowledge 10 Jul '19

10 Jul '19

Just got sent a pointer to an interesting Star emulator; might amuse some of you to learn about and maybe even try out... https://engblg.livingcomputers.org/index.php/tag/xerox/ There's also a pointer to an Alto emulator. T'would be interesting to see running on a Pi! tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful random insult:- People around her are at risk of second hand idiocy.

1 0

Testing PostgresV3
by tim Rowledge 10 Jul '19

10 Jul '19

I've finally got to try out the http://www.squeaksource.com/PostgresV3 package and it's nearly kinda working. I think. Warning - I know very little about databases. I probably don't even know the right words to use... Installing -------- This was a bit more tricky than I'd like because there is no immediately obvious advice on installing. First time I tried to load the "oh that looks a plausible root package" PostgresV3 but it actually locked up my image completely. So that's probably not the thing to load... Loading Core, Help & DBAPI seems to have installed a basic setup ok. It's certainly nice to have the Help package added to the system, but it would need quite a lot of expansion to assist DB-newbies like me. Collectively we could do better with some sort of install guidance for packages on SqueakSource etc; I'm not sure what would really solve it. Perhaps a package called something obvious like 'install' that does loading or at least has a commit message that describes loading or... I know there is the whole 'ConfigurationOfBlah' stuff but how would one be expected to find one starting from SqueakSource? Some info on the package Wiki that SSrc provides would help too; perhaps even mentioning if SqueakMap has a nice installer ready to help? Testing ------ Almost worked! Got back an error saying the pg_hba.conf didn't know my IP, so someone at the office has to do magic. I'd guess that somewhere in PG3Connection>>#processStates one might benefit from checking the received message for error stuff. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim I asked Mom if I was a gifted child ... she said they certainly wouldn't have paid for me.

3 4

The Trunk: ToolBuilder-Morphic-mt.229.mcz
by commits＠source.squeak.org 09 Jul '19

09 Jul '19

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.229.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.229 Author: mt Time: 9 July 2019, 2:08:54.585973 pm UUID: eb513b5e-2448-442a-b8c0-1e5f313610df Ancestors: ToolBuilder-Morphic-mt.228 Addition to ShoutCore-mt.64. Reverts Shout's background-styling callback to the older, much simpler version. SHTextStyler handles UI-process synchronization of callback (again). =============== Diff against ToolBuilder-Morphic-mt.228 =============== Item was changed: ----- Method: PluggableTextMorphPlus>>stylerStyledInBackground: (in category 'styling') ----- stylerStyledInBackground: styledCopyOfText "Sent after the styler completed styling of the text" "It is possible that the text string has changed since the styling began. Disregard the styles if styledCopyOfText's string differs with the current textMorph contents string" + textMorph contents string = styledCopyOfText string + ifTrue: [self stylerStyled: styledCopyOfText]! - Project current addDeferredUIMessage: [ - textMorph contents string = styledCopyOfText string - ifTrue: [self stylerStyled: styledCopyOfText]].!

1 0

The Trunk: ShoutCore-mt.64.mcz
by commits＠source.squeak.org 09 Jul '19

09 Jul '19

Marcel Taeumel uploaded a new version of ShoutCore to project The Trunk: http://source.squeak.org/trunk/ShoutCore-mt.64.mcz ==================== Summary ==================== Name: ShoutCore-mt.64 Author: mt Time: 9 July 2019, 2:07:39.898973 pm UUID: 4a783083-891a-4556-a362-2a401660f5bf Ancestors: ShoutCore-nice.63 Removes the semaphore from Shout's background styling. It is not needed because we can synchronize with the current project's UI process using #addDeferredUIMessage:. =============== Diff against ShoutCore-nice.63 =============== Item was changed: Object subclass: #SHTextStyler + instanceVariableNames: 'backgroundProcess text monitor view stylingEnabled' - instanceVariableNames: 'sem backgroundProcess text monitor view stylingEnabled' classVariableNames: '' poolDictionaries: '' category: 'ShoutCore-Styling'! !SHTextStyler commentStamp: 'tween 8/27/2004 10:54' prior: 0! I am an Abstract class. Subclasses of me can create formatted, coloured, and styled copies of Text that is given to them. They may perform their styling asynchronously, in a background process which I create and manage. My public interface is... view: aViewOrMorph - set the view that will receive notifications when styling has completed. format: aText - modifies aText's string style: aText - modifies the TextAttributes of aText, but does not change the string, then sends #stylerStyled: to the view. styleInBackgroundProcess: aText - performs style: in a background process, then sends #stylerStylednBackground: to the view. styledTextFor: aText - answers a formatted and styled copy of aText unstyledTextFrom: aText - answers a copy of aText with all TextAttributes removed Subclasses of me should re-implement... privateFormat: aText - answer a formatted version of aText; the String may be changed privateStyle: aText - modify the TextAttributes of aText; but do not change the String ! Item was changed: ----- Method: SHTextStyler>>styleInBackgroundProcess: (in category 'styling') ----- styleInBackgroundProcess: aText self terminateBackgroundStylingProcess. + + stylingEnabled ifTrue: [ - stylingEnabled ifTrue:[ text := aText copy. self monitor critical: [ + backgroundProcess := [ + self privateStyle: text. + view ifNotNil: [:v | Project current addDeferredUIMessage: [v stylerStyledInBackground: text]]. + ] forkAt: Processor userBackgroundPriority] ] - sem := Semaphore new. - [sem notNil - ifTrue: [ - sem wait. - view ifNotNil:[view stylerStyledInBackground: text]] - ] forkAt: Processor activePriority. - backgroundProcess := - [self privateStyle: text. - sem signal] - forkAt: Processor userBackgroundPriority] ] ! Item was changed: ----- Method: SHTextStyler>>terminateBackgroundStylingProcess (in category 'private') ----- terminateBackgroundStylingProcess + self monitor critical: [ backgroundProcess ifNotNil: [ backgroundProcess terminate. + backgroundProcess := nil]].! - backgroundProcess := nil]. - sem - ifNotNil:[ - sem terminateProcess. - sem := nil]. - ] ! Item was changed: ----- Method: SHTextStyler>>veryDeepInner: (in category 'copying') ----- veryDeepInner: aDeepCopier super veryDeepInner: aDeepCopier. + backgroundProcess := monitor := nil. - sem := backgroundProcess := monitor := nil. text := text veryDeepCopyWith: aDeepCopier. view := view veryDeepCopyWith: aDeepCopier!

1 0

The Trunk: Chronology-Core-dtl.48.mcz
by commits＠source.squeak.org 09 Jul '19

09 Jul '19

David T. Lewis uploaded a new version of Chronology-Core to project The Trunk: http://source.squeak.org/trunk/Chronology-Core-dtl.48.mcz ==================== Summary ==================== Name: Chronology-Core-dtl.48 Author: dtl Time: 5 July 2019, 1:08:16.059032 pm UUID: 7f33ce2e-ae95-48ef-a526-63da7ddfd885 Ancestors: Chronology-Core-cmm.47 Fix fallback code for primPosixMicrosecondClockWithOffset: to not allow DateAndTime class>>now to create an instance with nil instance variables. Previous fallback code was a cut and paste error, never worked as intended. Rationale for the fallback handling: Corrupt DateAndTime can quickly lead to a broken image. A default value of the Posix epoch is easily recognized as un uninitialized DateAndTime. To test, evaluate "Time clockPolicy: #acceptPlatformTime" and comment out the primitive call in Time class>>primPosixMicrosecondClockWithOffset: to simulate the case of a VM that does not provide primitiveUtcWithOffset. In this case, DateAndTime now produces 1970-01-01T00:00:00+00:00. After testing, do Time initialze to restore clock policy. =============== Diff against Chronology-Core-cmm.47 =============== Item was changed: ----- Method: Time class>>posixMicrosecondClockWithOffset: (in category 'clock') ----- posixMicrosecondClockWithOffset: aDateAndTime "Initialize aDateAndTime initialized with local microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone." | utcValue | self primPosixMicrosecondClockWithOffset: aDateAndTime. - aDateAndTime utcMicroseconds ifNil: [ ^aDateAndTime]. "primitive failed" ClockPolicy caseOf: { [#acceptPlatformTime] -> [^ aDateAndTime] . [#monotonicAllowDuplicates] -> [ utcValue := aDateAndTime utcMicroseconds. utcValue > LastClockTick ifTrue: [LastClockTick := utcValue] ifFalse: [aDateAndTime utcMicroseconds: LastClockTick]] . [#monotonicForceMicrosecondIncrement] -> [ utcValue := aDateAndTime utcMicroseconds. utcValue > LastClockTick ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + 1. "add one microsecond" aDateAndTime utcMicroseconds: LastClockTick]] . [#monotonicForceNanosecondIncrement] -> [ utcValue := aDateAndTime utcMicroseconds. utcValue > LastClockTick ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + (1 / 1000). "add one nanosecond" aDateAndTime utcMicroseconds: LastClockTick]] } otherwise: []. ^aDateAndTime ! Item was changed: ----- Method: Time class>>primPosixMicrosecondClockWithOffset: (in category 'private') ----- primPosixMicrosecondClockWithOffset: arrayOrObjectWithTwoSlots "Answer an array with UTC microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone. If the primitive is not available, then answer the time and offset of Posix epoch GMT. This enables the image to continue running in the absence of #primitiveUtcWithOffset, thus avoiding the need to fallback code based on the earlier local microsecond clock mechanism. The parameter may be a two element array, or an object whose first two instance variables are expected to be UTC microseconds and seconds offset from GMT." <primitive: 'primitiveUtcWithOffset'> + + (arrayOrObjectWithTwoSlots instVarAt: 1) + ifNil: [arrayOrObjectWithTwoSlots instVarAt: 1 put: 0]. + (arrayOrObjectWithTwoSlots instVarAt: 2) + ifNil: [arrayOrObjectWithTwoSlots instVarAt: 2 put: 0]! - ^{0. 0}!

1 0

Semaphore >> #terminateProcess
by Marcel Taeumel 08 Jul '19

08 Jul '19

Hi, there. Is there a way to change Semaphore >> #terminateProcess that it would also terminate a process that has not run yet? Shout's background styling can leave many processes behind, waiting for semaphores that have long been forgotten. Here is a minimal example, extracted from Shout: | m s | m := Monitor new. s := nil. 1000 timesRepeat: [ m critical: [ s ifNotNil: [s terminateProcess. s := nil] ]. m critical: [ s := Semaphore new. [s wait] fork. Processor yield "Important!"]. ]. s terminateProcess. *** After this code snipped, shouldn't be any new processes waiting for those semaphores... "Processor yield" is really necessary here... Best, Marcel

1 0

The Inbox: Morphic-pre.1491.mcz
by commits＠source.squeak.org 08 Jul '19

08 Jul '19

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-pre.1491.mcz ==================== Summary ==================== Name: Morphic-pre.1491 Author: pre Time: 27 June 2019, 2:15:55.295956 pm UUID: 4b4c32a0-1907-0046-8d95-0b8adf1dcf6b Ancestors: Morphic-pre.1489 Fixes a defect preventing colored line items in pluggable tree morphs. The infrastructure was already in place (see StringMorph>>#contents:), however, the ListMorph overrides the determined color later. This changes this overriding to be more conservative to preserve any pre-determined color. =============== Diff against Morphic-pre.1489 =============== Item was changed: ----- Method: SimpleHierarchicalListMorph>>addMorphsTo:from:allowSorting:withExpandedItems:atLevel: (in category 'private') ----- addMorphsTo: morphList from: aCollection allowSorting: sortBoolean withExpandedItems: expandedItems atLevel: newIndent | priorMorph newCollection firstAddition | priorMorph := nil. newCollection := (sortBoolean and: [sortingSelector notNil]) ifTrue: [ aCollection sorted: [ :a :b | (a perform: sortingSelector) <= (b perform: sortingSelector)] ] ifFalse: [ aCollection ]. firstAddition := nil. newCollection do: [:item | priorMorph := self indentingItemClass basicNew initWithContents: item prior: priorMorph forList: self indentLevel: newIndent. priorMorph + color: (priorMorph color ifNil: [self textColor]); - color: self textColor; font: self font; selectionColor: self selectionColor; selectionTextColor: self selectionTextColor; hoverColor: self hoverColor; highlightTextColor: self highlightTextColor; filterColor: self filterColor; filterTextColor: self filterTextColor. firstAddition ifNil: [firstAddition := priorMorph]. morphList add: priorMorph. ((item hasEquivalentIn: expandedItems) or: [priorMorph isExpanded]) ifTrue: [ priorMorph isExpanded: true. priorMorph addChildrenForList: self addingTo: morphList withExpandedItems: expandedItems. ]. ]. ^firstAddition ! Item was changed: ----- Method: SimpleHierarchicalListMorph>>addSubmorphsAfter:fromCollection:allowSorting: (in category 'private') ----- addSubmorphsAfter: parentMorph fromCollection: aCollection allowSorting: sortBoolean | priorMorph morphList newCollection | priorMorph := nil. newCollection := (sortBoolean and: [sortingSelector notNil]) ifTrue: [ aCollection sorted: [ :a :b | (a perform: sortingSelector) <= (b perform: sortingSelector)] ] ifFalse: [ aCollection ]. morphList := OrderedCollection new. newCollection do: [:item | priorMorph := self indentingItemClass basicNew initWithContents: item prior: priorMorph forList: self indentLevel: parentMorph indentLevel + 1. priorMorph + color: (priorMorph color ifNil: [self textColor]); - color: self textColor; font: self font; selectionColor: self selectionColor; selectionTextColor: self selectionTextColor; hoverColor: self hoverColor; highlightTextColor: self highlightTextColor; filterColor: self filterColor; filterTextColor: self filterTextColor. morphList add: priorMorph. ]. scroller addAllMorphs: morphList after: parentMorph. ^morphList !

4 4

The Inbox: Tools-ct.853.mcz
by commits＠source.squeak.org 08 Jul '19

08 Jul '19

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.853.mcz ==================== Summary ==================== Name: Tools-ct.853 Author: ct Time: 7 July 2019, 7:58:37.726178 pm UUID: a11f70d4-3f36-894a-89e7-78011f6ab2e2 Ancestors: Tools-ct.852 Refine styling in Inspector & Debugger This commit is based on ToolBuilder-Morphic-ct.228 (#aboutToStyle:forMorph:). - Introduce a state for Inspector (shouldStyleValuePane) that indicates whether to style the value pane - Name the value pane to identify it - Allow styling in every inspector window - Refactor the debugger toolbuilding and refer to inspector's building methods (they shared many common properties) Also see the following thread: http://forum.world.st/The-Inbox-Tools-ct-852-mcz-td5100784.html =============== Diff against Tools-ct.852 =============== Item was changed: ----- Method: Debugger>>buildFullWith: (in category 'toolbuilder') ----- buildFullWith: builder | windowSpec listSpec textSpec | windowSpec := builder pluggableWindowSpec new model: self; label: 'Debugger'; children: OrderedCollection new. listSpec := builder pluggableListSpec new. listSpec model: self; list: #contextStackList; getIndex: #contextStackIndex; setIndex: #toggleContextStackIndex:; menu: #contextStackMenu:shifted:; icon: #messageIconAt:; helpItem: #messageHelpAt:; keyPress: #contextStackKey:from:; frame: (0@0 corner: 1(a)0.22). windowSpec children add: listSpec. textSpec := self buildCodePaneWith: builder. textSpec frame: (0(a)0.22corner: 1(a)0.8). windowSpec children add: textSpec. + listSpec := self receiverInspector buildFieldListWith: builder. - listSpec := builder pluggableListSpec new. listSpec - model: self receiverInspector; - list: #fieldList; - getIndex: #selectionIndex; - setIndex: #toggleIndex:; - menu: #fieldListMenu:; - keyPress: #inspectorKey:from:; frame: (0(a)0.8 corner: 0.2@1); help: 'Receiver''s\Instance\Variables' withCRs. windowSpec children add: listSpec. + textSpec := self receiverInspector buildValuePaneWith: builder. - textSpec := builder pluggableCodePaneSpec new. textSpec - model: self receiverInspector; - getText: #contents; - setText: #accept:; help: '<- Select receiver''s field' translated; - selection: #contentsSelection; - menu: #codePaneMenu:shifted:; frame: (0.2(a)0.8 corner: 0.5@1). windowSpec children add: textSpec. + listSpec := self contextVariablesInspector buildFieldListWith: builder. - listSpec := builder pluggableListSpec new. listSpec - model: self contextVariablesInspector; - list: #fieldList; - getIndex: #selectionIndex; - setIndex: #toggleIndex:; - menu: #fieldListMenu:; - keyPress: #inspectorKey:from:; frame: (0.5(a)0.8 corner: 0.7@1); help: 'Other\Context\Bindings' withCRs. windowSpec children add: listSpec. + textSpec := self contextVariablesInspector buildValuePaneWith: builder. - textSpec := builder pluggableCodePaneSpec new. textSpec - model: self contextVariablesInspector; - getText: #contents; - setText: #accept:; help: '<- Select context''s field' translated; - selection: #contentsSelection; - menu: #codePaneMenu:shifted:; frame: (0.7(a)0.8 corner: 1@1). windowSpec children add: textSpec. ^builder build: windowSpec! Item was changed: StringHolder subclass: #Inspector + instanceVariableNames: 'object selectionIndex timeOfLastListUpdate selectionUpdateTime context expression shouldStyleValuePane' - instanceVariableNames: 'object selectionIndex timeOfLastListUpdate selectionUpdateTime context expression' classVariableNames: '' poolDictionaries: '' category: 'Tools-Inspector'! !Inspector commentStamp: '<historical>' prior: 0! I represent a query path into the internal representation of an object. As a StringHolder, the string I represent is the value of the currently selected variable of the observed object.! Item was removed: - ----- Method: Inspector>>aboutToStyle: (in category 'styling') ----- - aboutToStyle: aStyler - - aStyler - classOrMetaClass: object class; - parseAMethod: false. - ^true! Item was added: + ----- Method: Inspector>>aboutToStyle:forMorph: (in category 'styling') ----- + aboutToStyle: aStyler forMorph: aMorph + + (aMorph knownName = #valuePane and: [shouldStyleValuePane not]) + ifTrue: [^ false]. + + aStyler + classOrMetaClass: object class; + parseAMethod: false. + ^true! Item was changed: ----- Method: Inspector>>buildValuePaneWith: (in category 'toolbuilder') ----- buildValuePaneWith: builder | textSpec | + textSpec := builder pluggableCodePaneSpec new. - textSpec := builder pluggableTextSpec new. textSpec model: self; + name: #valuePane; getText: #contents; setText: #accept:; + editText: #typeValue:; help: 'Selection details.'; selection: #contentsSelection; menu: #codePaneMenu:shifted:. ^textSpec! Item was changed: ----- Method: Inspector>>initialize (in category 'initialize-release') ----- initialize selectionIndex := 0. + shouldStyleValuePane := true. super initialize! Item was changed: ----- Method: Inspector>>toggleIndex: (in category 'selecting') ----- toggleIndex: anInteger "The receiver has a list of variables of its inspected object. One of these is selected. If anInteger is the index of this variable, then deselect it. Otherwise, make the variable whose index is anInteger be the selected item." selectionUpdateTime := 0. selectionIndex = anInteger ifTrue: ["same index, turn off selection" selectionIndex := 0. contents := ''] ifFalse: ["different index, new selection" + shouldStyleValuePane := false. selectionIndex := anInteger. self contentsIsString ifTrue: [contents := self selection] ifFalse: [contents := self selectionPrintString]]. self changed: #selection. self changed: #contents. self changed: #selectionIndex.! Item was added: + ----- Method: Inspector>>typeValue: (in category 'selecting') ----- + typeValue: aTextOrString + + shouldStyleValuePane := true. + self changed: #style!

3 2

Jump to page: