Squeak-dev June 2019

squeak-dev@lists.squeakfoundation.org

40 participants
97 discussions

Re: [squeak-dev] Proposal: Morphs in Text
by karl ramberg 22 Aug '19

22 Aug '19

I'm a little late here. TextMorph does not really need TextAnchor I think. You can just drop morphs on the text and select avoid occlusions in the menu. What are the use of text anchors instead just dropped in morphs ? I filed in TextAnchorPlacement change set and it interferes somewhat with the avoid occlusions functions. Best, Karl On Fri, Jun 28, 2019 at 4:42 PM <patrick.rein(a)hpi.uni-potsdam.de> wrote: > Hi everyone, > > please find attached a new version of the change including an improved > protocol for setting the alignment added by Chris (basically as discussed > below). :) > > Bests > Patrick > > >Hi Chris, > > > >thanks for the recommendations! > > > >>The only thing that gave me pause was that API for #verticalAlignment:. > Initially, I just saw the selector and thought about it the same as the API > for regular horizontal text alignment (e.g., #left, #center, #right, > justified), and so tried: > >> self verticalAlignment: #bottom > >>but this informed me that this single-argument selector is actually > looking for two arguments. That's some great flexibility that I didn't > even consider, but I wonder whether this detracts from the usability of the > common cases: > >> #bottom, expected to do what #(#bottom #bottom) does, #center, to > do what, uh, #(#middle #middle) does, and #top, would do what, #top #top > does. > >>#verticalAlignment: handle the above, while #verticalAlignmentMorph: and > #verticalAlignmentLine: could be used for advanced customizations. Even > once I figured out it wanted a two-element Array for input, I had to go > back look at the method to remind myself which is first and which is > second. Separate attributes would be more readable. > > > >That is a good point. I myself had some difficulties remembering which > way they have to go... I have added a convenience case which now allows for > just sending a symbol and the method takes care of converting it to the > array internally (so #top results in #(top top)). > > > >>Lastly, #middle vs. #center. #center is what we have _everywhere_ to > refer to geometric centers, all over the image, including even for > horizontal text-alignment. The only #middle in the whole image relates to > a Collection element access. Could we use #center? > > > >Yes, that makes sense :) I renamed #middle to #center. > > > >The new changeset includes these changes. > > > >Bests > >Patrick > > > > > >["TextAnchorPlacement.cs"] > > > > > >[TextAnchorPlacement.cs] > ["TextAnchorPlacement.cs"] >

9 20

Re: [squeak-dev] The Trunk: Collections-pre.822.mcz
by Chris Muller 21 Aug '19

21 Aug '19

My main objection is about growing the "mutator" nomenclature further instead of trimming it back. I'm working on a GraphQL framework. GraphQL has a first-class notion of "mutations". https://graphql.org/learn/queries/ Currently, we have almost zero mention of the word "mutator" in the image. I would appreciate if, instead of germinating the overloading the word, we uproot it and keep the nomenclature for this Smalltalk tooling confined to "getter" and "setter" that we have now. So, instead of #asMutator and #isMutator, how about #asSimpleSetter and #isSimpleSetter? We can end up removing a method instead of adding one. We already have many existing methods which are dealing with this conversion, all of which use the traditional Smalltalk / developer linguisitic of "setter". Browsing through all the "setter" nomenclature we have in a message names browser, including Utilities class>>#getterSelectorFor: Utilities class>>#setterSelectorFor: Utilities class>>#simpleSetterFor: which instruct Etoys users to use existing methods on String, #asSetterSelector or #asSimpleSetter. Of special note is SyntaxMorph>>#isStandardSetterKeyword: which, by its use of a utility-method implementation, acknowledges that this behavior is _application-specific_. I, myself, would just write: someSelector asSimpleSetter = someSelector "same as isMutator / isSimpleSetter" instead of #isSimpleSetter, but can appreciate both styles. They both better avoid the awkwardness of "mutator" as a general, reliable behavior when: #at: isMutator "true" while #at:put: isMutator "false" Best, Chris On Thu, Mar 21, 2019 at 1:16 AM <patrick.rein(a)hpi.uni-potsdam.de> wrote: > > Which one are you refering to? I only see Symbol>>#asMutator in Collections in the method category converting. It is also used in a few other places beyond generating instance variable accessors. > > Bests, > Patrick > > >#asMutator: is for "generate instVar accessors" code-generation, and > >that's why it's in the Tools package. > > > >IMHO, if #isMutator belongs anywhere, it isn't in Collections. > > > >Regards, > > Chris > > > > > > > >On Wed, Mar 20, 2019 at 3:08 PM Chris Muller <asqueaker(a)gmail.com> wrote: > >> > >> Assuming a single-keyword is a mutator? Object>>#at: is not a > >> mutator. #indexOf: is not. #first: is not. Obviously many more.. > >> > >> If API balance is the goal of this, perhaps #asMutator should be > >> removed instead. This feels application-specific... > >> > >> On Wed, Mar 20, 2019 at 2:05 PM <commits(a)source.squeak.org> wrote: > >> > > >> > Patrick Rein uploaded a new version of Collections to project The Trunk: > >> > http://source.squeak.org/trunk/Collections-pre.822.mcz > >> > > >> > ==================== Summary ==================== > >> > > >> > Name: Collections-pre.822 > >> > Author: pre > >> > Time: 20 March 2019, 8:05:20.383677 pm > >> > UUID: 483c4461-cee4-4a4f-82d3-fbc03e7201cc > >> > Ancestors: Collections-dtl.821 > >> > > >> > Adds #isMutator to Symbol which is analogous to asMutator. > >> > > >> > =============== Diff against Collections-dtl.821 =============== > >> > > >> > Item was added: > >> > + ----- Method: Symbol>>isMutator (in category 'testing') ----- > >> > + isMutator > >> > + > >> > + ^ self isKeyword and: [self numArgs = 1]! > >> > > >> > > > >

6 12

The Trunk: Kernel-fn.1223.mcz
by commits＠source.squeak.org 23 Jul '19

23 Jul '19

Fabio Niephaus uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-fn.1223.mcz ==================== Summary ==================== Name: Kernel-fn.1223 Author: fn Time: 29 April 2019, 12:52:13.424813 pm UUID: 910aa151-72fe-4f6c-9645-fa735fb17f63 Ancestors: Kernel-nice.1222 SmallInteger and SmallFloat64 shouldNotImplement postCopy. =============== Diff against Kernel-nice.1222 =============== Item was added: + ----- Method: SmallFloat64>>postCopy (in category 'copying') ----- + postCopy + "I will never be copied" + ^self shouldNotImplement! Item was added: + ----- Method: SmallInteger>>postCopy (in category 'copying') ----- + postCopy + "I will never be copied" + ^self shouldNotImplement!

5 5

The Inbox: ShoutCore-nice.63.mcz
by commits＠source.squeak.org 19 Jul '19

19 Jul '19

Nicolas Cellier uploaded a new version of ShoutCore to project The Inbox: http://source.squeak.org/inbox/ShoutCore-nice.63.mcz ==================== Summary ==================== Name: ShoutCore-nice.63 Author: nice Time: 7 April 2019, 3:24:31.721529 pm UUID: 7440b898-b497-493b-adfa-67aef04e0980 Ancestors: ShoutCore-eem.62 Attempt to fix highlighting of 1to:-1 I don't see the point of testing the presence of a binary selector character after a colon $:, except maybe the case of assignment :=, so only test that case. =============== Diff against ShoutCore-eem.62 =============== Item was changed: ----- Method: SHParserST80>>scanIdentifier (in category 'scan') ----- scanIdentifier | c start | start := sourcePosition. [ (c := self nextChar) isAlphaNumeric or: [ allowUnderscoreSelectors and: [ c == $_ ] ] ] whileTrue. + (c == $: and: [ self peekChar ~= $= ]) - (c == $: and: [ (self isSelectorCharacter: self peekChar) not ]) ifTrue: [ self nextChar ]. currentToken := source copyFrom: start to: sourcePosition - 1. currentTokenSourcePosition := start!

3 3

The Inbox: Morphic-pre.1491.mcz
by commits＠source.squeak.org 08 Jul '19

08 Jul '19

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-pre.1491.mcz ==================== Summary ==================== Name: Morphic-pre.1491 Author: pre Time: 27 June 2019, 2:15:55.295956 pm UUID: 4b4c32a0-1907-0046-8d95-0b8adf1dcf6b Ancestors: Morphic-pre.1489 Fixes a defect preventing colored line items in pluggable tree morphs. The infrastructure was already in place (see StringMorph>>#contents:), however, the ListMorph overrides the determined color later. This changes this overriding to be more conservative to preserve any pre-determined color. =============== Diff against Morphic-pre.1489 =============== Item was changed: ----- Method: SimpleHierarchicalListMorph>>addMorphsTo:from:allowSorting:withExpandedItems:atLevel: (in category 'private') ----- addMorphsTo: morphList from: aCollection allowSorting: sortBoolean withExpandedItems: expandedItems atLevel: newIndent | priorMorph newCollection firstAddition | priorMorph := nil. newCollection := (sortBoolean and: [sortingSelector notNil]) ifTrue: [ aCollection sorted: [ :a :b | (a perform: sortingSelector) <= (b perform: sortingSelector)] ] ifFalse: [ aCollection ]. firstAddition := nil. newCollection do: [:item | priorMorph := self indentingItemClass basicNew initWithContents: item prior: priorMorph forList: self indentLevel: newIndent. priorMorph + color: (priorMorph color ifNil: [self textColor]); - color: self textColor; font: self font; selectionColor: self selectionColor; selectionTextColor: self selectionTextColor; hoverColor: self hoverColor; highlightTextColor: self highlightTextColor; filterColor: self filterColor; filterTextColor: self filterTextColor. firstAddition ifNil: [firstAddition := priorMorph]. morphList add: priorMorph. ((item hasEquivalentIn: expandedItems) or: [priorMorph isExpanded]) ifTrue: [ priorMorph isExpanded: true. priorMorph addChildrenForList: self addingTo: morphList withExpandedItems: expandedItems. ]. ]. ^firstAddition ! Item was changed: ----- Method: SimpleHierarchicalListMorph>>addSubmorphsAfter:fromCollection:allowSorting: (in category 'private') ----- addSubmorphsAfter: parentMorph fromCollection: aCollection allowSorting: sortBoolean | priorMorph morphList newCollection | priorMorph := nil. newCollection := (sortBoolean and: [sortingSelector notNil]) ifTrue: [ aCollection sorted: [ :a :b | (a perform: sortingSelector) <= (b perform: sortingSelector)] ] ifFalse: [ aCollection ]. morphList := OrderedCollection new. newCollection do: [:item | priorMorph := self indentingItemClass basicNew initWithContents: item prior: priorMorph forList: self indentLevel: parentMorph indentLevel + 1. priorMorph + color: (priorMorph color ifNil: [self textColor]); - color: self textColor; font: self font; selectionColor: self selectionColor; selectionTextColor: self selectionTextColor; hoverColor: self hoverColor; highlightTextColor: self highlightTextColor; filterColor: self filterColor; filterTextColor: self filterTextColor. morphList add: priorMorph. ]. scroller addAllMorphs: morphList after: parentMorph. ^morphList !

4 4

[Please Review] Refactoring for #literalsDo: etc.
by Marcel Taeumel 05 Jul '19

05 Jul '19

Hi, there. Please find attached a change set that (tries to) clean up everything related to enumerating or testing literals in CompiledCode, CompiledMethod, and CompiledBlock. I have three important questions: - The purpose of #hasLiteralThorough is not needed anymore because we enumerate and test always in a "thorough" way? - Are the enumeration boundaries in CompiledCode, CompiledMethod, CompiledBlock in #literalsDo: correct? - What is a literal as expected in #hasLiteral: etc. to answer true? Just symbols or also bindings (symbol-to-class) and classes themselves? Try exploring this result: "(Morph >> #fullDrawOn:) literals" or similar. Best, Marcel

4 10

The Inbox: Morphic-cmfcmf.1490.mcz
by commits＠source.squeak.org 04 Jul '19

04 Jul '19

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-cmfcmf.1490.mcz ==================== Summary ==================== Name: Morphic-cmfcmf.1490 Author: cmfcmf Time: 30 June 2019, 12:04:13.370226 pm UUID: ab2320d7-f8f4-df46-a786-ec28230e912c Ancestors: Morphic-pre.1489 When wrapping a Morph into a flex shell, first add the flex shell to the Morph's owner (and thus to the Morph's world) before making the Morph a submorph of the flex shell. This avoids unnecessarily sending outOfWorld: to the Morph when adding it to the new flex shell (which doesn't have a world after creation) and intoWorld: when adding the flex shell to the Morph's owner right thereafter. =============== Diff against Morphic-pre.1489 =============== Item was changed: ----- Method: Morph>>addFlexShell (in category 'rotate scale and flex') ----- addFlexShell "Wrap a rotating and scaling shell around this morph." | oldHalo myWorld flexMorph anIndex | - oldHalo:= self halo. myWorld := self world. self owner ifNil: [flexMorph := self newTransformationMorph asFlexOf: self] ifNotNil: [:myOwner | anIndex := myOwner submorphIndexOf: self. + "Avoid triggering outOfWorld: on self by first adding flexMorph to myOwner and only then making myself a submorph of flexMorph via asFlexOf:" + flexMorph := self newTransformationMorph. - flexMorph := self newTransformationMorph asFlexOf: self. myOwner addMorph: flexMorph asElementNumber: anIndex. + flexMorph asFlexOf: self. myWorld ifNotNil: [myWorld startSteppingSubmorphsOf: flexMorph]]. self transferStateToRenderer: flexMorph. oldHalo ifNotNil: [oldHalo setTarget: flexMorph]. ^ flexMorph!

5 5

The Inbox: Collections-pre.838.mcz
by commits＠source.squeak.org 03 Jul '19

03 Jul '19

Patrick Rein uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-pre.838.mcz ==================== Summary ==================== Name: Collections-pre.838 Author: pre Time: 28 June 2019, 12:11:16.302033 pm UUID: db29f1b2-09b5-f045-aa21-9379185664df Ancestors: Collections-pre.837 Two method additions to Collection. The first adds ordered printing to OrderedDictionaries, to allow users to actually see the ordering. The second adds a method to convert a run array into an expanded version of the runs. =============== Diff against Collections-pre.837 =============== Item was added: + ----- Method: OrderedDictionary>>printElementsOn: (in category 'printing') ----- + printElementsOn: aStream + "Based on Dictionary>>#printElementsOn:" + + aStream nextPut: $(. + self size > 100 + ifTrue: [aStream nextPutAll: 'size '. + self size printOn: aStream] + ifFalse: [order do: [:assoc | assoc ifNotNil: [ + assoc printOn: aStream. aStream space]]]. + aStream nextPut: $)! Item was added: + ----- Method: RunArray>>asValuesAndIntervals (in category 'converting') ----- + asValuesAndIntervals + + | interval result | + result := OrderedDictionary new. + 1 to: self size do: [:i | + (self at: i) do: [:value | + interval := result at: value ifAbsentPut: (i to: i). + result at: value put: (interval start to: i)]]. + ^ result + !

4 6

The Inbox: Tools-ct.852.mcz
by commits＠source.squeak.org 02 Jul '19

02 Jul '19

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.852.mcz ==================== Summary ==================== Name: Tools-ct.852 Author: ct Time: 30 June 2019, 1:53:09.36343 pm UUID: 24bcf5d5-2d7f-2c47-a3c3-f80b0bd5241e Ancestors: Tools-ct.851 Activate code styling for inspector panes in Debugger =============== Diff against Tools-ct.851 =============== Item was changed: ----- Method: Debugger>>buildFullWith: (in category 'toolbuilder') ----- buildFullWith: builder | windowSpec listSpec textSpec | windowSpec := builder pluggableWindowSpec new model: self; label: 'Debugger'; children: OrderedCollection new. listSpec := builder pluggableListSpec new. listSpec model: self; list: #contextStackList; getIndex: #contextStackIndex; setIndex: #toggleContextStackIndex:; menu: #contextStackMenu:shifted:; icon: #messageIconAt:; helpItem: #messageHelpAt:; keyPress: #contextStackKey:from:; frame: (0@0 corner: 1(a)0.22). windowSpec children add: listSpec. textSpec := self buildCodePaneWith: builder. textSpec frame: (0(a)0.22corner: 1(a)0.8). windowSpec children add: textSpec. listSpec := builder pluggableListSpec new. listSpec model: self receiverInspector; list: #fieldList; getIndex: #selectionIndex; setIndex: #toggleIndex:; menu: #fieldListMenu:; keyPress: #inspectorKey:from:; frame: (0(a)0.8 corner: 0.2@1); help: 'Receiver''s\Instance\Variables' withCRs. windowSpec children add: listSpec. + textSpec := builder pluggableCodePaneSpec new. - textSpec := builder pluggableTextSpec new. textSpec model: self receiverInspector; getText: #contents; setText: #accept:; help: '<- Select receiver''s field' translated; selection: #contentsSelection; menu: #codePaneMenu:shifted:; frame: (0.2(a)0.8 corner: 0.5@1). windowSpec children add: textSpec. listSpec := builder pluggableListSpec new. listSpec model: self contextVariablesInspector; list: #fieldList; getIndex: #selectionIndex; setIndex: #toggleIndex:; menu: #fieldListMenu:; keyPress: #inspectorKey:from:; frame: (0.5(a)0.8 corner: 0.7@1); help: 'Other\Context\Bindings' withCRs. windowSpec children add: listSpec. + textSpec := builder pluggableCodePaneSpec new. - textSpec := builder pluggableTextSpec new. textSpec model: self contextVariablesInspector; getText: #contents; setText: #accept:; help: '<- Select context''s field' translated; selection: #contentsSelection; menu: #codePaneMenu:shifted:; frame: (0.7(a)0.8 corner: 1@1). windowSpec children add: textSpec. ^builder build: windowSpec!

4 6

Problems with Browse revisions in System package
by Eliot Miranda 01 Jul '19

01 Jul '19

Hi Chris, Hi All, I tried browse revisions for SmalltalkImage>>recreateSpecialObjectsArray and this was the reply: HTTP/1.1 414 Request-URI Too Large server: nginx/1.16.0 date: Sat, 29 Jun 2019 00:18:02 GMT content-type: text/html content-length: 177 connection: close <html> <head><title>414 Request-URI Too Large</title></head> <body> <center><h1>414 Request-URI Too Large</h1></center> <hr><center>nginx/1.16.0</center> </body> </html> Just an FYI. I can live without this but it is really nice to have. _,,,^..^,,,_ best, Eliot

4 3

← Newer
1
2
3
4
5
6
7
8
9
10
Older →