Squeak-dev July 2018

squeak-dev@lists.squeakfoundation.org

28 participants
119 discussions

The Inbox: Collections-kks.803.mcz
by commits＠source.squeak.org 14 Jul '18

14 Jul '18

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-kks.803.mcz ==================== Summary ==================== Name: Collections-kks.803 Author: kks Time: 14 July 2018, 11:14:34.247017 pm UUID: c6ea08ba-fcdd-46f8-89c0-c61d0d524531 Ancestors: Collections-dtl.802 Attempt to retain as much styling as possible while filing in text from streams where the runs may fall short or extend beyond the string. Based on Bob's suggestions at http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-July/199530.html =============== Diff against Collections-dtl.802 =============== Item was changed: ----- Method: Text>>setString:setRunsChecking: (in category 'private') ----- setString: aString setRunsChecking: aRunArray + | stringSize runsSize | - "Check runs and do the best you can to make them fit..." - string := aString. - "check the runs" aRunArray ifNil: [^ aString asText]. - (aRunArray isKindOf: RunArray) ifFalse: [^ aString asText]. - aRunArray runs size = aRunArray values size ifFalse: [^ aString asText]. - aRunArray size = aString size ifFalse: [^ aString asText]. + "Check runs and do the best you can to make them fit..." + aRunArray runs size = aRunArray values size ifFalse: [^ aString asText]. "raise error here?" + runsSize := aRunArray size. + stringSize := string size. + runs := stringSize = runsSize + ifTrue: [aRunArray] + ifFalse: [ stringSize > runsSize + ifTrue: [aRunArray addLast: {} times: stringSize - runsSize] + ifFalse: [aRunArray copyFrom: 1 to: stringSize]].! - runs := aRunArray.!

1 0

ProvideAnswerNotification and UIManager
by Rein, Patrick 14 Jul '18

14 Jul '18

Hi everyone, recently I noticed that the method BlockClosure>>valueSupplyingAnswer: (and related ones) do not work on all method of UIManager. When I looked into the issue I noticed that the signaling of ProvideAnswerNotification is not done in the UIManagers but in the classes implementing the actual user interfaces for the corresponding queries (e.g. MenuMorph and PopUpMenu). This scattered the ProvideAnswerNotification logic throughout different packages and classes and might have lead to the oversights. The attached changeset is a refactoring of this mechanism which moves the corresponding logic into the UIManagers. Unfortunately, this required some code duplication but at least it is contained with the UIManager. On the plus side the code is contained in the UIManagers and all methods should be covered now. As I am not very familiar with the original intend and responsibilities of the UIManagers I wanted to ask whether anyone has any thoughts on that change. Thanks and bests Patrick P.S.: There are other minor changes related to the refactoring in the changeset such as extending the BlockClosureTests to test all UIManager subclasses

2 1

The Trunk: Collections-dtl.802.mcz
by commits＠source.squeak.org 14 Jul '18

14 Jul '18

David T. Lewis uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-dtl.802.mcz ==================== Summary ==================== Name: Collections-dtl.802 Author: dtl Time: 14 July 2018, 1:05:13.618064 pm UUID: 0dc423d0-032d-4f0c-8b93-97f32605c1ea Ancestors: Collections-ul.800 Bypass Collections.kks.801.mcz for now because it leads to a problem opening the help browser. =============== Diff against Collections-ul.800 ===============

1 0

The Trunk: MorphicExtras-pre.242.mcz
by commits＠source.squeak.org 12 Jul '18

12 Jul '18

Patrick Rein uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-pre.242.mcz ==================== Summary ==================== Name: MorphicExtras-pre.242 Author: pre Time: 10 July 2018, 2:20:31.299227 pm UUID: faafe72b-0932-ae48-86bb-38dd0e666b0d Ancestors: MorphicExtras-bf.241 Makes the objects tool themeable (at least parts of it) =============== Diff against MorphicExtras-bf.241 =============== Item was added: + ----- Method: ObjectsTool>>baseBackgroundColor (in category 'constants') ----- + baseBackgroundColor + + ^ self userInterfaceTheme borderColor ifNil: [Color veryLightGray] ! Item was added: + ----- Method: ObjectsTool>>baseBorderColor (in category 'constants') ----- + baseBorderColor + + ^ self userInterfaceTheme borderColor ifNil: [Color veryLightGray] ! Item was changed: ----- Method: ObjectsTool>>buttonActiveColor (in category 'constants') ----- buttonActiveColor + ^ self userInterfaceTheme selectionTextColor ifNil: [Color white]! - ^ Color white! Item was changed: ----- Method: ObjectsTool>>buttonColor (in category 'constants') ----- buttonColor + ^ self userInterfaceTheme textColor ifNil: [Color black]! - ^ Color black! Item was changed: ----- Method: ObjectsTool>>extent: (in category 'layout') ----- extent: anExtent "The user has dragged the grow box such that the receiver's extent would be anExtent. Do what's needed" - self extent = anExtent ifTrue: [ ^self ]. super extent: anExtent. + self submorphsDo: [:m | + m width: anExtent x]! - self fixLayoutFrames.! Item was changed: ----- Method: ObjectsTool>>fixLayoutFrames (in category 'layout') ----- fixLayoutFrames "Adjust the boundary between the tabs or search pane and the parts bin, giving preference to the tabs." + | oldY newY aTabsPane aTabsPaneHeight | + oldY := ((aTabsPane := self tabsPane - | oldY newY tp tpHeight | - oldY := ((tp := self tabsPane ifNil: [self searchPane]) ifNil: [^ self]) layoutFrame bottomOffset. + aTabsPaneHeight := aTabsPane hasSubmorphs + ifTrue: [(aTabsPane submorphBounds outsetBy: aTabsPane layoutInset) height] + ifFalse: [aTabsPane height]. + newY := (self buttonPane ifNil: [^ self]) height + aTabsPaneHeight. + oldY = newY ifTrue: [^ self]. + aTabsPane layoutFrame bottomOffset: newY. + (self partsBin ifNil: [^ self]) layoutFrame topOffset: newY. + submorphs do: [:m | m layoutChanged]! - tpHeight := tp hasSubmorphs - ifTrue: [(tp submorphBounds outsetBy: tp layoutInset) height] - ifFalse: [tp height]. - newY := (self buttonPane - ifNil: [^ self]) height + tpHeight. - oldY = newY - ifTrue: [^ self]. - tp layoutFrame bottomOffset: newY. - (self partsBin - ifNil: [^ self]) layoutFrame topOffset: newY. - submorphs - do: [:m | m layoutChanged ]! Item was changed: ----- Method: ObjectsTool>>initializeToStandAlone (in category 'initialization') ----- initializeToStandAlone "Initialize the receiver so that it can live as a stand-alone morph" | buttonPane aBin aColor heights tabsPane | self basicInitialize. + - self layoutInset: 0; layoutPolicy: ProportionalLayout new; useRoundedCorners; hResizing: #rigid; vResizing: #rigid; extent: (self minimumWidth @ self minimumHeight). "mode buttons" buttonPane := self paneForTabs: self modeTabs. + buttonPane color: self baseBackgroundColor. - buttonPane color: (Color r: 1 g: 0.85 b: 0.975). buttonPane vResizing: #shrinkWrap; setNameTo: 'ButtonPane'; addMorphFront: self dismissButton; addMorphBack: self helpButton; color: (aColor := buttonPane color) darker; layoutInset: 5; wrapDirection: nil; width: self width; layoutChanged; fullBounds. "Place holder for a tabs or text pane" tabsPane := Morph new. tabsPane + color: self baseBackgroundColor; - color: (Color r: 1 g: 0.85 b: 0.975); setNameTo: 'TabPane'; hResizing: #spaceFill. heights := { buttonPane height. 40 }. buttonPane vResizing: #spaceFill. self addMorph: buttonPane fullFrame: (LayoutFrame fractions: (0 @ 0 corner: 1 @ 0) offsets: (0 @ 0 corner: 0 @ heights first)). self addMorph: tabsPane fullFrame: (LayoutFrame fractions: (0 @ 0 corner: 1 @ 0) offsets: (0 @ heights first corner: 0 @ (heights first + heights second))). aBin := (PartsBin newPartsBinWithOrientation: #leftToRight from: #()) + changeTableLayout; listDirection: #leftToRight; wrapDirection: #topToBottom; color: aColor lighter lighter; + borderColor: aColor lighter lighter; setNameTo: 'Parts'; dropEnabled: false; vResizing: #spaceFill; yourself. self addMorph: aBin fullFrame: (LayoutFrame fractions: (0 @ 0 corner: 1 @ 1) offsets: (0 @ (heights first + heights second) corner: 0 @ 0)). self borderWidth: 1; + borderColor: self baseBorderColor; + color: self baseBackgroundColor; - borderColor: (Color r: 0.9 g: 0.801 b: 0.2); - color: (Color r: 1 g: 0.85 b: 0.975); setNameTo: 'Objects' translated; showCategories. ! Item was changed: ----- Method: ObjectsTool>>paneForTabs: (in category 'tabs') ----- paneForTabs: tabList "Answer a pane bearing tabs for the given list" | aPane | tabList do: [:t | t color: Color transparent. t borderWidth: 1; borderColor: Color black]. + aPane := Morph new + changeTableLayout; + color: self baseBackgroundColor; - aPane := AlignmentMorph newRow - color: (Color r: 1 g: 0.85 b: 0.975); listDirection: #leftToRight; wrapDirection: #topToBottom; vResizing: #spaceFill; hResizing: #spaceFill; cellInset: 6; layoutInset: 4; listCentering: #center; listSpacing: #equal; addAllMorphs: tabList; yourself. aPane width: self layoutBounds width. ^ aPane! Item was changed: ----- Method: PartsBin>>listDirection:quadList:buttonClass: (in category 'initialization') ----- listDirection: aListDirection quadList: quadList buttonClass: buttonClass "Initialize the receiver to run horizontally or vertically, obtaining its elements from the list of tuples of the form: (<receiver> <selector> <label> <balloonHelp>) Used by external package Connectors." self layoutPolicy: TableLayout new. self listDirection: aListDirection. self wrapCentering: #topLeft. self layoutInset: 2. self cellPositioning: #bottomCenter. aListDirection == #leftToRight ifTrue: [self vResizing: #rigid. self hResizing: #spaceFill. self wrapDirection: #topToBottom] ifFalse: [self hResizing: #rigid. self vResizing: #spaceFill. self wrapDirection: #leftToRight]. quadList do: [:tuple | | aButton aClass | aClass := Smalltalk at: tuple first. + aButton := buttonClass new + initializeWithThumbnail: (self class thumbnailForQuad: tuple color: self color) withLabel: tuple third + andColor: self color + andSend: tuple second + to: aClass. - aButton := buttonClass new initializeWithThumbnail: (self class thumbnailForQuad: tuple color: self color) withLabel: tuple third andColor: self color andSend: tuple second to: aClass. (tuple size > 3 and: [tuple fourth isEmptyOrNil not]) ifTrue: [aButton setBalloonText: tuple fourth]. self addMorphBack: aButton]!

2 1

The Trunk: MorphicExtras-pre.243.mcz
by commits＠source.squeak.org 10 Jul '18

10 Jul '18

Patrick Rein uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-pre.243.mcz ==================== Summary ==================== Name: MorphicExtras-pre.243 Author: pre Time: 10 July 2018, 3:31:38.952363 pm UUID: 38e65aea-ec4c-f34b-8c99-417bc929e15c Ancestors: MorphicExtras-pre.242 Adds theme properties to the tool =============== Diff against MorphicExtras-pre.242 =============== Item was added: + ----- Method: ObjectsTool class>>themeProperties (in category 'preferences') ----- + themeProperties + + ^ super themeProperties, { + { #borderColor. 'Colors'. 'Color of the tools'' border.' }. + { #borderWidth. 'Borders'. 'Width of the tools'' border.' }. + { #borderStyle. 'Borders'. 'Whether to use a plain border, inset, or outset.' }. + { #color. 'Colors'. 'Background color of the tool.' }. + { #textColor. 'Colors'. 'Color for the category button labels.' }. + { #selectionTextColor. 'Colors'. 'Color used for the button of the selected category.' }. + }!

1 0

The Trunk: MorphicExtras-pre.243.mcz
by commits＠source.squeak.org 10 Jul '18

10 Jul '18

1 0

The Trunk: System-pre.1038.mcz
by commits＠source.squeak.org 10 Jul '18

10 Jul '18

Patrick Rein uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-pre.1038.mcz ==================== Summary ==================== Name: System-pre.1038 Author: pre Time: 10 July 2018, 2:26:49.603227 pm UUID: 53fb8e38-d4f4-0f4c-b269-68ca4ffbc2c0 Ancestors: System-eem.1037 Adds theme properties for the objects tool =============== Diff against System-eem.1037 =============== Item was changed: ----- Method: SqueakTheme class>>addToolColors: (in category 'instance creation') ----- addToolColors: theme "Tool-specific colors." "SUnit's TestRunner." theme set: #failureColor for: #TestRunner to: Color yellow; set: #errorColor for: #TestRunner to: Color red; set: #passColor for: #TestRunner to: Color green; derive: #failureTextColor for: #TestRunner from: #PluggableTextMorph at: #textColor; derive: #errorTextColor for: #TestRunner from: #PluggableTextMorph at: #textColor; derive: #passTextColor for: #TestRunner from: #PluggableTextMorph at: #textColor. "Monticello Tools." theme set: #revertedOperationAttributes for: #MCOperationsBrowser to: {TextEmphasis struckOut}; set: #ignoredOperationAttributes for: #MCOperationsBrowser to: {TextColor color: Color gray}. "set: #rejectedOperationAttributes for: #MCOperationsBrowser to: {TextEmphasis struckOut}; set: #acceptedOperationAttributes for: #MCOperationsBrowser to: {TextEmphasis underlined}; set: #conflictingOperationAttributes for: #MCOperationsBrowser to: {TextEmphasis bold}." "Halos." theme derive: #borderColor for: #HaloMorph from: #MenuItemMorph at: #selectionColor do: [:c | c alpha: 0.8]; derive: #borderColor for: #SelectionMorph from: #MenuItemMorph at: #selectionColor do: [:c | c twiceDarker alpha: 0.75]; derive: #color for: #SelectionMorph from: #MenuItemMorph at: #selectionColor do: [:c | c alpha: 0.08]. "Browser." theme set: #noClassCommentColor for: #Browser to: Color red. "Objects Tool." theme derive: #borderWidth for: #ObjectsTool from: #MenuMorph; derive: #borderColor for: #ObjectsTool from: #MenuMorph; derive: #borderStyle for: #ObjectsTool from: #MenuMorph; + derive: #color for: #ObjectsTool from: #MenuMorph; + derive: #textColor for: #ObjectsTool from: #MenuItemMorph; + derive: #selectionTextColor for: #ObjectsTool from: #MenuItemMorph.! - derive: #color for: #ObjectsTool from: #MenuMorph.!

1 0

The Inbox: Collections-kks.798.mcz
by commits＠source.squeak.org 09 Jul '18

09 Jul '18

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-kks.798.mcz ==================== Summary ==================== Name: Collections-kks.798 Author: kks Time: 6 July 2018, 3:20:06.403752 pm UUID: 151011b4-ef92-409b-9078-bdd1be01ce87 Ancestors: Collections-cmm.797 Attempt to retain as much styling as possible while filing in text from streams where the runs may fall short or extend beyond the string. Based on Bob's suggestions at http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-July/199530.html =============== Diff against Collections-cmm.797 =============== Item was changed: ----- Method: Text>>setString:setRunsChecking: (in category 'private') ----- setString: aString setRunsChecking: aRunArray + | stringSize runsSize | - "Check runs and do the best you can to make them fit..." - string := aString. - "check the runs" - aRunArray ifNil: [^ aString asText]. (aRunArray isKindOf: RunArray) ifFalse: [^ aString asText]. - aRunArray runs size = aRunArray values size ifFalse: [^ aString asText]. - aRunArray size = aString size ifFalse: [^ aString asText]. + "Check runs and do the best you can to make them fit..." + runsSize := aRunArray runs size. + runsSize = aRunArray values size ifFalse: [^ aString asText]. "raise error here?" + stringSize := string size. + runs := stringSize = runsSize + ifTrue: [aRunArray] + ifFalse: [ stringSize > runsSize + ifTrue: [aRunArray addLast: {} times: stringSize - runsSize] + ifFalse: [aRunArray copyFrom: 1 to: stringSize]].! - runs := aRunArray.!

3 2

The Inbox: Collections-kks.801.mcz
by commits＠source.squeak.org 09 Jul '18

09 Jul '18

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-kks.801.mcz ==================== Summary ==================== Name: Collections-kks.801 Author: kks Time: 9 July 2018, 8:20:57.318092 pm UUID: ad558efb-0fea-41e7-9f20-ef7477b20704 Ancestors: Collections-ul.800 Attempt to retain as much styling as possible while filing in text from streams where the runs may fall short or extend beyond the string. Based on Bob's suggestions at http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-July/199530.html =============== Diff against Collections-ul.800 =============== Item was changed: ----- Method: Text>>setString:setRunsChecking: (in category 'private') ----- setString: aString setRunsChecking: aRunArray + | stringSize runsSize | - "Check runs and do the best you can to make them fit..." - string := aString. - "check the runs" aRunArray ifNil: [^ aString asText]. - (aRunArray isKindOf: RunArray) ifFalse: [^ aString asText]. - aRunArray runs size = aRunArray values size ifFalse: [^ aString asText]. - aRunArray size = aString size ifFalse: [^ aString asText]. + "Check runs and do the best you can to make them fit..." + runsSize := aRunArray runs size. + runsSize = aRunArray values size ifFalse: [^ aString asText]. "raise error here?" + stringSize := string size. + runs := stringSize = runsSize + ifTrue: [aRunArray] + ifFalse: [ stringSize > runsSize + ifTrue: [aRunArray addLast: {} times: stringSize - runsSize] + ifFalse: [aRunArray copyFrom: 1 to: stringSize]].! - runs := aRunArray.!

1 0

The Trunk: CollectionsTests-dtl.291.mcz
by commits＠source.squeak.org 08 Jul '18

08 Jul '18

David T. Lewis uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-dtl.291.mcz ==================== Summary ==================== Name: CollectionsTests-dtl.291 Author: dtl Time: 8 July 2018, 2:00:27.93338 pm UUID: 95a16aef-4140-4539-8314-6a86a5bf8fef Ancestors: CollectionsTests-cmm.290 Add tests to cover some basic string and character operations =============== Diff against CollectionsTests-cmm.290 =============== Item was added: + ----- Method: CharacterTest>>testDigitValue (in category 'tests - creation') ----- + testDigitValue + "Answer the Character whose digit value is x. For example, + answer $9 for x=9, $0 for x=0, $A for x=10, $Z for x=35. + Results outside this range are undefined." + + self assert: $0 = (Character digitValue: 0). + self assert: $1 = (Character digitValue: 1). + self assert: $9 = (Character digitValue: 9). + self assert: $A = (Character digitValue: 10). + self assert: $B = (Character digitValue: 11). + self assert: $F = (Character digitValue: 15). + self assert: $G = (Character digitValue: 16). + self assert: $P = (Character digitValue: 25). + self assert: $Z = (Character digitValue: 35). + + ! Item was added: + ----- Method: StringTest>>testIsAllDigits (in category 'tests - testing') ----- + testIsAllDigits + self assert: '0123456789' isAllDigits. + self assert: '0123456789' asWideString isAllDigits. + self assert: '1' isAllDigits. + self assert: '1' asWideString isAllDigits. + self assert: '' isAllDigits. + self assert: '' asWideString isAllDigits. + self deny: '012345 6789' isAllDigits. + self deny: '012345 6789' asWideString isAllDigits. + self deny: ('12345', String cr) isAllDigits. + self deny: ('12345', String cr) asWideString isAllDigits. + ! Item was added: + ----- Method: StringTest>>testIsAllSeparators (in category 'tests - testing') ----- + testIsAllSeparators + self assert: ('', Character cr, Character tab, Character space) isAllSeparators. + self assert: ('', Character cr, Character tab, Character space) asWideString isAllSeparators. + self assert: ' ' isAllSeparators. + self assert: ' ' asWideString isAllSeparators. + self assert: '' isAllSeparators. + self assert: '' asWideString isAllSeparators. + self deny: '1 2' isAllSeparators. + self deny: '1 2' asWideString isAllSeparators. + self deny: ' X ' isAllSeparators. + self deny: ' X ' asWideString isAllSeparators. + + ! Item was added: + ----- Method: StringTest>>testIsAsciiString (in category 'tests - testing') ----- + testIsAsciiString + self assert: 'this is a string' isAsciiString. + self assert: 'this is a string' asWideString isAsciiString. + self assert: '' isAsciiString. + self assert: '' asWideString isAsciiString. + self deny: ('this is', (Character value: 256), 'a string') isAsciiString. + self deny: ('this is', (Character value: 128), 'a string') isAsciiString. + self assert: ('this is', (Character value: 127), 'a string') isAsciiString. + ! Item was added: + ----- Method: StringTest>>testIsOctetString (in category 'tests - testing') ----- + testIsOctetString + self assert: 'this is a string' isOctetString. + self assert: 'this is a string' asWideString isOctetString. + self assert: '' isOctetString. + self assert: '' asWideString isOctetString. + self deny: ('this is', (Character value: 256), 'a string') isOctetString. + !

1 0

← Newer
1
...
5
6
7
8
9
10
11
12
Older →