Squeak-dev July 2018

squeak-dev@lists.squeakfoundation.org

28 participants
119 discussions

The Trunk: Graphics-tpr.400.mcz
by commits＠source.squeak.org 23 Jul '18

23 Jul '18

tim Rowledge uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-tpr.400.mcz ==================== Summary ==================== Name: Graphics-tpr.400 Author: tpr Time: 23 July 2018, 11:09:20.311791 am UUID: 83d0ab30-01d7-4753-9fee-577471f5cd22 Ancestors: Graphics-eem.399 Update the font summary string to a Text with appropriate font settings that match the name of the font being described. It doesn't show up in the help browser correctly because of problems as described in http://forum.world.st/Improving-SqueakToolsHelp-class-fontSizeSummary-revea… When we fix that, the fonts summary will magically look better. =============== Diff against Graphics-eem.399 =============== Item was changed: ----- Method: TextStyle class>>fontSizeSummaryContents (in category 'utilities') ----- fontSizeSummaryContents + ^ Text streamContents: - ^ String streamContents: [:aStream | self knownTextStyles do: [:aStyleName | aStream nextPutAll: + (aStyleName asText addAttribute: (TextFontReference toFont: (TextStyle named: aStyleName) defaultFont)), ' ', - aStyleName, ' ', (self fontPointSizesFor: aStyleName) asArray storeString. aStream cr]].!

1 0

The Trunk: Graphics-tpr.400.mcz
by commits＠source.squeak.org 23 Jul '18

23 Jul '18

1 0

Dr .Geo under Dynabook perspective
by Hilaire 23 Jul '18

23 Jul '18

Hello, Some reflexions I want to share when looking at Dr. Geo under the Dynabook perspective http://blog.drgeo.eu/post/2018/Dr.-Geo-and-Dynamic-media I am looking at more though on the Dynabook concept in the future. Hilaire -- Dr. Geo http://drgeo.eu

2 2

The Trunk: Morphic-kfr.1460.mcz
by commits＠source.squeak.org 22 Jul '18

22 Jul '18

Karl Ramberg uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-kfr.1460.mcz ==================== Summary ==================== Name: Morphic-kfr.1460 Author: kfr Time: 22 July 2018, 10:25:54.130642 am UUID: de03a3c8-ca7e-3e44-b5f1-8cb9dc1a576f Ancestors: Morphic-dtl.1459 Fix TheWorldMainDockingBar preferences showing menus. Add 'collapse all windows' to Windows menu Add MethodFinder to Tools Menu =============== Diff against Morphic-dtl.1459 =============== Item was changed: ----- Method: TheWorldMainDockingBar class>>setMenuPreference:to: (in category 'preferences') ----- setMenuPreference: aPreferenceSymbol to: aBoolean | project | (project := Project current) isMorphic ifTrue: [ project projectPreferenceFlagDictionary at: aPreferenceSymbol put: aBoolean. + (aBoolean ~= (Preferences preferenceAt: aPreferenceSymbol)) - (aBoolean ~= (Preferences perform: aPreferenceSymbol)) ifTrue: [Preferences setPreference: aPreferenceSymbol toValue: aBoolean]]. self updateInstances.! Item was changed: ----- Method: TheWorldMainDockingBar>>listWindowsOn: (in category 'submenu - windows') ----- listWindowsOn: menu | windows | windows := self allVisibleWindows sorted: [:winA :winB | ((winA model isNil or: [winB model isNil]) or: [winA model name = winB model name]) ifTrue: [winA label < winB label] ifFalse: [winA model name < winB model name]]. windows ifEmpty: [ menu addItem: [ :item | item contents: 'No Windows' translated; isEnabled: false ] ]. windows do: [ :each | | windowColor | windowColor := (each model respondsTo: #windowColorToUse) ifTrue: [each model windowColorToUse] ifFalse: [UserInterfaceTheme current get: #uniformWindowColor for: Model]. menu addItem: [ :item | item contents: (self windowMenuItemLabelFor: each); icon: (self colorIcon: windowColor); target: each; selector: #comeToFront; subMenuUpdater: self selector: #windowMenuFor:on: arguments: { each }; action: [ each beKeyWindow; expand ] ] ]. menu addLine; + add: 'Collapse all windows' target: (Project current world) selector: #collapseAllWindows; add: 'Close all windows' target: self selector: #closeAllWindowsUnsafe; addItem: [:item | item contents: 'Close all windows without changes'; target: self; icon: MenuIcons smallBroomIcon; selector: #closeAllWindows]; add: 'Close all windows but workspaces' target: self selector: #closeAllWindowsButWorkspaces.! Item was added: + ----- Method: TheWorldMainDockingBar>>messageNamesMenuItemOn: (in category 'submenu - tools') ----- + messageNamesMenuItemOn: menu + + menu addItem: [:item | + item + contents: 'Message Names' translated; + help: 'Open the Message Names tool' translated; + icon: (self colorIcon: MessageNames basicNew windowColorToUse); + target: StandardToolSet; + selector: #openMessageNames]! Item was changed: ----- Method: TheWorldMainDockingBar>>toolsMenuOn: (in category 'construction') ----- toolsMenuOn: aDockingBar aDockingBar addItem: [ :item | item contents: 'Tools' translated; addSubMenu: [ :menu | self browserMenuItemOn: menu; workspaceMenuItemOn: menu; transcriptMenuItemOn: menu; testRunnerMenuItemOn: menu; + methodFinderMenuItemOn: menu; + messageNamesMenuItemOn: menu. - methodFinderMenuItemOn: menu. menu addLine. self monticelloBrowserMenuItemOn: menu; monticelloConfigurationsMenuItemOn: menu; simpleChangeSorterMenuItemOn: menu; dualChangeSorterMenuItemOn: menu. menu addLine. self processBrowserMenuItemOn: menu; preferenceBrowserMenuItemOn: menu; fileListMenuItemOn: menu. ] ]!

1 0

Feliz día del amigo
by Edgar De Cleene 21 Jul '18

21 Jul '18

To all far away friends Sent from my iPhone

1 0

The Trunk: Collections-dtl.802.mcz
by commits＠source.squeak.org 19 Jul '18

19 Jul '18

David T. Lewis uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-dtl.802.mcz ==================== Summary ==================== Name: Collections-dtl.802 Author: dtl Time: 19 July 2018, 12:40:11.186143 am UUID: 95497d30-f52f-4f82-ac8c-3e65cfa30df1 Ancestors: Collections-cmm.801 Change Text class>>string:runs: to call setString:setRunsChecking: instead of setString:setRuns: to prevent creating a Text with run length not matching string length. This fixes the problem originally reported by Tim Johnson in http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-July/199461.html Add patch by K K Subbu to fix instantiating text when the string and the runarray are of mismatched lengths. This allows a filein to retain text attributes even if the runarray does not match the string length, as may be the case for a fileIn that had been edited externally (otherwise the text will be converted to a string without the intended attributes). Name: Collections-kks.803 Author: kks Time: 14 July 2018, 11:14:34.247017 pm UUID: c6ea08ba-fcdd-46f8-89c0-c61d0d524531 Ancestors: Collections-dtl.802 Attempt to retain as much styling as possible while filing in text from streams where the runs may fall short or extend beyond the string. Based on Bob's suggestions at http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-July/199530.html =============== Diff against Collections-cmm.801 =============== Item was changed: ----- Method: Text class>>string:runs: (in category 'private') ----- string: aString runs: anArray + ^self basicNew setString: aString setRunsChecking: anArray! - ^self basicNew setString: aString setRuns: anArray! Item was changed: ----- Method: Text>>setString:setRunsChecking: (in category 'private') ----- setString: aString setRunsChecking: aRunArray + | stringSize runsSize | - "Check runs and do the best you can to make them fit..." - string := aString. - "check the runs" aRunArray ifNil: [^ aString asText]. - (aRunArray isKindOf: RunArray) ifFalse: [^ aString asText]. - aRunArray runs size = aRunArray values size ifFalse: [^ aString asText]. - aRunArray size = aString size ifFalse: [^ aString asText]. + "Check runs and do the best you can to make them fit..." + aRunArray runs size = aRunArray values size ifFalse: [^ aString asText]. "raise error here?" + runsSize := aRunArray size. + stringSize := string size. + runs := stringSize = runsSize + ifTrue: [aRunArray] + ifFalse: [ stringSize > runsSize + ifTrue: [aRunArray addLast: {} times: stringSize - runsSize] + ifFalse: [aRunArray copyFrom: 1 to: stringSize]].! - runs := aRunArray.!

2 1

[BUG] Again in FileList
by Edgar De Cleene 19 Jul '18

19 Jul '18

FileServices unregisterFileReader: CornerGripMorph solve this, but why is again in trunk ?

3 2

The Trunk: CollectionsTests-dtl.293.mcz
by commits＠source.squeak.org 19 Jul '18

19 Jul '18

David T. Lewis uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-dtl.293.mcz ==================== Summary ==================== Name: CollectionsTests-dtl.293 Author: dtl Time: 19 July 2018, 12:41:00.027981 am UUID: 4671abff-5dac-4ad8-b907-7afbbdf39fe6 Ancestors: CollectionsTests-cmm.292 Unit tests to cover text creation from a fileIn or from parameters when the length of the text string does not match the length of the associated runarray. These tests cover the enhancement from Collections-kks.803 (treated inbox, and included in Collections-dtl.802 in trunk). =============== Diff against CollectionsTests-cmm.292 =============== Item was added: + ----- Method: TextTest>>testSetStringSetRunsChecking (in category 'tests runs checking') ----- + testSetStringSetRunsChecking + "Normal case of creating a Text from a string and a run array with matching size" + + | aString runs aText newText | + aString := 'The best way to predict the future'. + runs := (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self assert: aString size = runs size. + + aText := (Text string: 'The best way to predict the future' runs: (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself))). + + newText := Text basicNew setString: aString setRunsChecking: runs. + self assert: newText equals: aText. + self assert: newText runs size = aString size. + self assert: runs equals: newText runs. + self assert: 6 equals: aText runs values size. + self assert: 6 equals: newText runs values size. + + + ! Item was added: + ----- Method: TextTest>>testSetStringSetRunsCheckingLongRuns (in category 'tests runs checking') ----- + testSetStringSetRunsCheckingLongRuns + "Creating text from a string and a long run array should create a valid Text instance, + and should retain text styling if possible." + + | aString aText newText lastRunTooLong oneRunTooMany | + aString := 'The best way to predict the future'. + lastRunTooLong := (RunArray runs: #(4 4 8 7 5 100) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self deny: aString size = lastRunTooLong size. + + oneRunTooMany := (RunArray runs: #(4 4 8 7 5 6 4) values: ((Array new: 7) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 7 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself)). + + self deny: aString size = oneRunTooMany size. + + aText := (Text string: 'The best way to predict the future' runs: (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself))). + + self assert: 6 equals: aText runs values size. + + newText := Text basicNew setString: aString setRunsChecking: lastRunTooLong. + self assert: newText equals: aText. + self assert: newText runs size = aString size. + self assert: 6 equals: newText runs values size. + + newText := Text basicNew setString: aString setRunsChecking: oneRunTooMany. + self assert: newText equals: aText. + self assert: newText runs size = aString size. + self assert: 6 equals: newText runs values size. + + + + ! Item was added: + ----- Method: TextTest>>testSetStringSetRunsCheckingShortRuns (in category 'tests runs checking') ----- + testSetStringSetRunsCheckingShortRuns + "Creating text from a string and a short run array should create a valid Text instance, + and should retain text styling if possible." + + | aString aText newText lastRunTooShort missingLastRun | + aString := 'The best way to predict the future'. + lastRunTooShort := (RunArray runs: #(4 4 8 7 5 1) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self deny: aString size = lastRunTooShort size. + + missingLastRun := (RunArray runs: #(4 4 8 7 5) values: ((Array new: 5) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); yourself)). + + self deny: aString size = missingLastRun size. + + aText := (Text string: 'The best way to predict the future' runs: (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself))). + + self assert: 6 equals: aText runs values size. + + "Compensate for short run array, either by adding a run or by extending length + of the last run. In either case, the run array should have size of 6 or greater, not + size 1 as would be the case if the text formatting had been discarded." + newText := Text basicNew setString: aString setRunsChecking: lastRunTooShort. + self assert: newText equals: aText. + self assert: newText runs size = aString size. + self assert: newText runs values size >= 6. + self assert: 7 equals: newText runs values size. "add one run to account for missing run length" + + newText := Text basicNew setString: aString setRunsChecking: missingLastRun. + self assert: newText equals: aText. "n.b. Two Texts are considered equal if they have the same characters" + self assert: newText runs size = aString size. + self assert: 6 equals: newText runs values size. + + + ! Item was added: + ----- Method: TextTest>>testWriteReadChunk (in category 'tests fileIn/Out') ----- + testWriteReadChunk + "Create a text from string and runs with matching lenghts. Verify that writing to + chunk format and reading from that chunk results in a copy of the original text." + + | aString runs aText chunk readFromChunk | + aString := 'The best way to predict the future'. + runs := (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self assert: aString size = runs size. + aText := Text basicNew setString: aString setRunsChecking: runs. + chunk := '' writeStream nextChunkPutWithStyle: aText; yourself; contents. + readFromChunk := UTF8TextConverter new nextChunkTextFromStream: (ReadStream on: chunk). + + self assert: readFromChunk equals: aText. + self assert: readFromChunk runs size = aString size. + self assert: runs equals: readFromChunk runs. + self assert: 6 equals: aText runs values size. + self assert: 6 equals: readFromChunk runs values size. + ! Item was added: + ----- Method: TextTest>>testWriteReadChunkShortRunCount (in category 'tests fileIn/Out') ----- + testWriteReadChunkShortRunCount + "Create a text from string and runs, where the string length is less than the + runs length. This is a condition that might occur if a chunk fileout was edited + by hand, leaving runs that extend beyond the bounds of the run array. In this + case, the fileIn should result in a reasonable Text instance without errors related + to the runs that exceed the string length." + + | aString runs aText chunk readFromChunk | + aString := 'The best way to predict'. " the future". + runs := (RunArray runs: #(4 4 8 7 5) values: ((Array new: 5) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); yourself)). + + self deny: aString size = runs size. + aText := Text basicNew setString: aString setRunsChecking: runs. + chunk := '' writeStream nextChunkPutWithStyle: aText; yourself; contents. + readFromChunk := UTF8TextConverter new nextChunkTextFromStream: (ReadStream on: chunk). + + self assert: readFromChunk equals: aText. + self assert: readFromChunk runs size = aString size. + self assert: readFromChunk runs size > 1. + self assert: 4 equals: aText runs values size. + self assert: 4 equals: readFromChunk runs values size. + ! Item was added: + ----- Method: TextTest>>testWriteReadChunkShortRunLength (in category 'tests fileIn/Out') ----- + testWriteReadChunkShortRunLength + "Create a text from string and runs, where the run length is less than the string + length. The fileIn should result in a reasonable Text instance without errors related + to the run length mismatch." + + | aString runs aText chunk readFromChunk | + aString := 'The best way to predict the future'. + runs := (RunArray runs: #(4 4 8 7 5 1) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self deny: aString size = runs size. + aText := Text basicNew setString: aString setRunsChecking: runs. + chunk := '' writeStream nextChunkPutWithStyle: aText; yourself; contents. + readFromChunk := UTF8TextConverter new nextChunkTextFromStream: (ReadStream on: chunk). + + self assert: readFromChunk equals: aText. + self assert: readFromChunk runs size = aString size. + self assert: readFromChunk runs size > 1. + self assert: aText runs values size equals: readFromChunk runs values size. + ! Item was added: + ----- Method: TextTest>>testWriteReadChunkShortString (in category 'tests fileIn/Out') ----- + testWriteReadChunkShortString + "Create a text from string and runs, where the run entries are fewer than required + to match the string length. The fileIn should result in a reasonable Text instance + without errors related to the run length mismatch." + + | aString runs aText chunk readFromChunk | + aString := 'The best way to predict the future'. + runs := (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self assert: aString size = runs size. + aText := Text basicNew setString: aString setRunsChecking: runs. + chunk := '' writeStream nextChunkPutWithStyle: aText; yourself; contents. + readFromChunk := UTF8TextConverter new nextChunkTextFromStream: (ReadStream on: chunk). + + self assert: readFromChunk equals: aText. + self assert: readFromChunk runs size = aString size. + self assert: readFromChunk runs size > 1. + self assert: aText runs values size equals: readFromChunk runs values size. + !

1 0

Please keep a clean and dense history (was: The Trunk: Collections-dtl.802.mcz)
by Chris Muller 19 Jul '18

19 Jul '18

I moved this and Collections-kks.801 to The Treated Inbox. You may wish to "flush cached versions" on the menu of the Monticello repository list. No further action should be required unless you plan to submit a new version of Collections, in which case, you'll know what to do. I prefer a clean and dense history of chunky changes, but I also understand the appeal of spasmodic rapid-fire micro-commits prevalent in git culture. But as the primary developer, maintainer and support contact for source.squeak.org, I respectfully request the community to remember and respect the current unscalable nature of our Monticello model. There are several ideas for fixing it, but as its a crucial part of our infrastructure, upgrades require careful, concerted and coordinated effort that no one currently has time for. Looking forward, please consider some guidelines for Trunk submissions: - Live with the code for a few days first. - Consider sharing it via the Inbox for extra review eyes. - When saving the MCZ version, arrow through every single change and review it. - When saving the MCZ version, describe why the change is being made rather than what. - When saving the MCZ version the use the description to explain why the change is being made rather than what. - When saving the MCZ version, remember to consider all the other "objects" of the MCZ besides just the code and description, specifically, there are the pre and post scripts, as well as the MCZ name. - Consider batching up trivial improvements (i.e., a fixed misspelling of a comment) together and/or piggy-backed with other non-trvial change within that same package. This is our collective creation, our names are on it. I hope y'all share my pride about the great system we've built. Regards, Chris On Sat, Jul 14, 2018 at 12:05 PM, <commits(a)source.squeak.org> wrote: > David T. Lewis uploaded a new version of Collections to project The Trunk: > http://source.squeak.org/trunk/Collections-dtl.802.mcz > > ==================== Summary ==================== > > Name: Collections-dtl.802 > Author: dtl > Time: 14 July 2018, 1:05:13.618064 pm > UUID: 0dc423d0-032d-4f0c-8b93-97f32605c1ea > Ancestors: Collections-ul.800 > > Bypass Collections.kks.801.mcz for now because it leads to a problem opening the help browser. > > =============== Diff against Collections-ul.800 =============== > >

3 3

Bug: SoundService default is not a class
by Nicolas Cellier 19 Jul '18

19 Jul '18

Hi Marcel, Tobias, I encountered a bug, when playing a sound, the default SoundService (class inst var) was not a class (BasedSoundService) but an instance (a BasedSoundService). Why? Because, there is a TileMorphTest>>setUp that remember which is the default, then tries to restore it in tearDown. It used to work. But, in between, SoundService default and defaultOrNil have been re-defined so as to answer an instance rather than a class. Thus, when we play the tests, we can no more play the sounds... I hesitate to open a Mantis issue, no one read nor close them, so the bug report is only here for the moment.

8 21

← Newer
1
2
3
4
5
6
7
8
9
...
12
Older →