Squeak-dev December 2018

squeak-dev@lists.squeakfoundation.org

30 participants
115 discussions

When did it become a good idea for selected text to be enclosed by () instead of replaced by 9 ?
by tim Rowledge 06 Nov '19

06 Nov '19

In trying to see if anything had changed re WaveEditor etc I updated an image to update 16963. When I went to save this image a Squeak5.1-16963… I selected the last thre digits of the prior name (Squeak5.1-16549…) intending to type 963. Imagine my surprise - nay, alarm! - when I got ‘Squeak5.1-16(963) instead. Oh my, I said to myself, what has Pooh done now. As best I can work out this is a result of the change in TextEditor>enclose: that added ‘9’ some time ago (and which did not affect me since I normally turn off the annoying enclose stuff in preferences) combined with a more recent change to TextEditor>dispatchOnKeyboardEvent: wherein a use of TextEditor>enclose: was added near the end. I see two obviously related Preferences for enclosing text. I see this as a dangerous thing, because multiple preferences interacting on the same issue can cause chaos, not to say confusion. And every time a preference is added it is yet another sheaf of potential problems to test. So, yes, I can turn it off easily enough. But how could it ever be unsurprising to a user to get a(bc)d instead of the expected a9d ? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful random insult:- Fell out of the family tree.

6 6

The Inbox: Collections-mt.812.mcz
by commits＠source.squeak.org 25 Jan '19

25 Jan '19

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-mt.812.mcz ==================== Summary ==================== Name: Collections-mt.812 Author: mt Time: 18 December 2018, 11:58:09.289023 am UUID: 64ff5a45-61b5-5642-aa46-9fbeac0215dd Ancestors: Collections-eem.811 Adds a small scripting/debugging interface to evaluate code on a heterogeneous collection. Ignore errors on the way. 1. Example: A bunch of morphs whose n-th submorph should be made yellow. Would raise errors for morphs with less than n submorphs. ActiveWorld submorphs try: [:ea | ea submorphs fifth color: Color yellow]. 2. Example: Fetch the selected classes of all code browsers through the submorph interface. | results | results := OrderedCollection new. ActiveWorld submorphs try: [:ea | results add: ea model selectedClass]. results explore. =============== Diff against Collections-eem.811 =============== Item was added: + ----- Method: Collection>>try: (in category 'enumerating') ----- + try: aBlock + "Evaluate aBlock with each of the receiver's elements as the argument. On error, skip that element and continue." + + ^ self try: aBlock ignore: Error! Item was added: + ----- Method: Collection>>try:ignore: (in category 'enumerating') ----- + try: aBlock ignore: exceptionOrExceptionSet + "Evaluate aBlock with each of the receiver's elements as the argument. On error, skip that element and continue." + + ^ self + try: aBlock + ignore: exceptionOrExceptionSet + logged: false! Item was added: + ----- Method: Collection>>try:ignore:logged: (in category 'enumerating') ----- + try: aBlock ignore: exceptionOrExceptionSet logged: aBoolean + "Evaluate aBlock with each of the receiver's elements as the argument. On error, skip that element and continue." + + ^ self do: [:ea | + [aBlock value: ea] + on: exceptionOrExceptionSet + do: [:err | aBoolean ifTrue: [Transcript showln: err messageText]]]!

4 3

Update on source.squeak.org upgrade
by Chris Muller 06 Jan '19

06 Jan '19

Well, I've been running the latest code and VM every day on my laptop as a Personal Squeaksource server and using it for all of my development these last weeks. It went so smoothly I also decided push on it by downloading the entire squeaksource.com (17GB!) and starting it locally using this same new code, but with different Repository combination more suitable to that application (ImagePersistence + FileSystem). That exposed a couple of minor bugs which are now fixed and committed to the /ss repository. I'm going to bang on it one more time but I believe that guy is ready to upgrade too! If you happened to try Personal SqueakSource and have any negative feedback, please let me know soon, otherwise I'll start thinking about upgrading it on the server and kissing the timeouts goodbye. - Chris

7 8

Rendering a text along an arc
by Eliot Miranda 03 Jan '19

03 Jan '19

Hi, anyone have any code to display text in a nice font along an arc or a spiral? _,,,^..^,,,_ best, Eliot

5 15

The Trunk: Morphic-cmm.1454.mcz
by commits＠source.squeak.org 31 Dec '18

31 Dec '18

Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-cmm.1454.mcz ==================== Summary ==================== Name: Morphic-cmm.1454 Author: cmm Time: 23 June 2018, 4:23:51.324266 pm UUID: 7bd5a7a9-4493-4cf4-849f-be6d8f8bb991 Ancestors: Morphic-hjh.1453 - Fix ability of border styles of veryDeepCopied Morphs to be independently set. - Fix dispatch regression for Morphs that leave world based on mouseLeave. - Fix three UI-gesture inconsistencies related to invoking halos, depending on the position of existing halos: 1) halo activation was sometimes on mouseUp instead of mouseDown, 2) blue move/resize gestures sometimes operated on the background window instead of the foreground, and, 3) even with the (Shift) modifier key, it was sometimes selecting the outermost instead of the innermost. All three are fixed while reverting the increased dependence on #transferHalo:, putting us closer to considerations like multiple, independent, and custom halos. - Restore splitter bar thicknesses from 2 back to 4 pixels. - Restore blue-click functionality of splitters when Smart Splitters is off. - Let SystemWindows dismiss halos with any button, mouse or keyboard. =============== Diff against Morphic-hjh.1453 =============== Item was added: + ----- Method: ComplexBorder>>veryDeepInner: (in category 'copying') ----- + veryDeepInner: aDeepCopier + super veryDeepInner: aDeepCopier. + style := style veryDeepCopyWith: aDeepCopier. + colors := colors veryDeepCopyWith: aDeepCopier. + lineStyles := lineStyles veryDeepCopyWith: aDeepCopier.! Item was changed: ----- Method: Editor class>>dumbbellCursor (in category 'preferences') ----- dumbbellCursor + <preference: 'Dumbbell Text Cursor' - <preference: 'Dumbbell-shaped Text Cursor' category: 'Morphic' + description: 'When enabled, the text cursor assumes the shape of a dumbbell, otherwise a vertical bar.' - description: 'When true, the text cursor assumes the shape of a dumbbell, otherwise a vertical bar..' type: #Boolean> ^ DumbbellCursor ifNil: [ false ]! Item was changed: ----- Method: MorphicEventDispatcher>>dispatchFocusEventAllOver:with: (in category 'focus events') ----- dispatchFocusEventAllOver: evt with: focusMorph "Like a full event dispatch BUT adds regular dispatch if the focus morph did nothing with the event. This is useful for letting the focusMorph's siblings handle the events instead. Take halo invocation as an example. See senders of me." | result hand mouseFocus | result := self dispatchFocusEventFully: evt with: focusMorph. result == #rejected ifTrue: [^ result]. result wasIgnored ifTrue: [^ result]. result wasHandled ifTrue: [^ result]. + focusMorph world ifNil: [ ^ result ]. hand := evt hand. mouseFocus := hand mouseFocus. [ "Avoid re-dispatching the event to the focus morph. See Morph >> #rejectsEvent:." focusMorph lock. "Handle side effect for mouse-enter and mouse-leave events." self flag: #hacky. "mt: Maybe we find a better way to synthesize enter/leave events in the future." hand newMouseFocus: nil. hand mouseOverHandler processMouseOver: hand lastEvent. "Give the morph's world a chance to normally dispatch the event." + ^ focusMorph world ifNotNil: [ : world | world processEvent: evt using: self] - ^ focusMorph world processEvent: evt using: self ] ensure: [ focusMorph unlock. evt hand newMouseFocus: mouseFocus].! Item was changed: ----- Method: PasteUpMorph>>tryInvokeHalo: (in category 'events-processing') ----- + tryInvokeHalo: aUserInputEvent + "Invoke halos around the top-most world container at aUserInputEvent's #position. If it was already halo'd, zero-in on its next inward component morph at that position. Holding Shift during the click reverses this traversal order." + | stack innermost haloTarget | + Preferences noviceMode ifTrue: [ ^ self ]. + Morph haloForAll ifFalse: [ ^ self ]. + "the stack is the top-most morph to bottom-most." + stack := (self morphsAt: aUserInputEvent position unlocked: true) select: + [ : each | each wantsHaloFromClick or: [ each handlesMouseDown: aUserInputEvent ] ]. + innermost := aUserInputEvent hand halo + ifNil: [ stack first ] + ifNotNil: + [ : existingHalo | stack allButFirst "existingHalo is first on the stack, not a target" + detect: [ : each | each owner == self ] + ifFound: + [ : worldContainer | "Is existingHalo's target part of the same worldContainer as the morph clicked?" + (existingHalo target withAllOwners includes: worldContainer) + ifTrue: [ "same hierarchy, let #transferHalo: continue to handle it for now." ^ self ] + ifFalse: + [ "different hierarchy, remove + add." + aUserInputEvent hand removeHalo. + aUserInputEvent shiftPressed + ifTrue: [ stack second "first is still the just removed halo" ] + ifFalse: [ worldContainer ] ] ] + ifNone: [ "Shouldn't get here, but defensive code." self ] ]. + "If modifier key is pressed, start at innermost (the target), otherwise the outermost (direct child of the world (self))." + haloTarget := aUserInputEvent shiftPressed + ifTrue: [ innermost ] + ifFalse: [ innermost == self ifTrue: [innermost] ifFalse: [(innermost withAllOwners copyWithout: self) last] ]. + haloTarget wantsHaloFromClick ifFalse: [ "haloTarget has its own event handler." ^ self ]. + "Now that we have the haloTarget, show the halo." + aUserInputEvent hand + newMouseFocus: haloTarget + event: aUserInputEvent. + haloTarget invokeHaloOrMove: aUserInputEvent. + "aUserInputEvent has been consumed, don't let it cause any further side-effects." + aUserInputEvent ignore! - tryInvokeHalo: anEvent - - | innerMost target | - anEvent hand halo ifNotNil: [^ self "No invocation needed. Halo will handle transfer itself."]. - Preferences noviceMode ifTrue: [^ self "No halo in novice mode."]. - Morph haloForAll ifFalse: [^ self]. - - innerMost := (self morphsAt: anEvent position unlocked: true) first. - - "1) Try to use innermost morph but skip all the ones that do not want to show a halo along the owner chain." - target := innerMost. - [target isNil or: [target wantsHaloFromClick]] - whileFalse: [target := target owner]. - target ifNil: [^ self]. - - "2) Without a modifier, which is normal, find the outermost container for that inner morph." - (innerMost == self or: [anEvent shiftPressed]) ifFalse: [ - | previousTargets | - previousTargets := OrderedCollection new. - [target notNil and: [target owner ~~ self]] whileTrue: [ - previousTargets add: target. - target := target owner]. - target ifNil: [^ self]. - [previousTargets isEmpty or: [target wantsHaloFromClick]] whileFalse: [ - target := previousTargets removeLast]. - target wantsHaloFromClick ifFalse: [^ self]]. - - "3) Now that we have the target, show the halo. Abort event dispatching, too, to avoid confusion." - anEvent hand newMouseFocus: target event: anEvent. - target invokeHaloOrMove: anEvent. - anEvent ignore.! Item was changed: ----- Method: ProportionalSplitterMorph>>balanceOffsets (in category 'layout') ----- balanceOffsets + | fdx fdy | + (self hasProperty: #fullDelta) ifFalse: [^ self]. + fdx := (self valueOfProperty: #fullDelta) x. + fdy := (self valueOfProperty: #fullDelta) y. + self layoutFrame hasFixedHeight ifTrue: [ | otop obot ctop cbot topf | otop := (owner submorphs detect: [:m | m layoutFrame topFraction isZero] ifNone: [^ self]) in: [:tm | tm top - (tm layoutFrame topOffset ifNil: [0])]. obot := (owner submorphs detect: [:m | m layoutFrame bottomFraction = 1] ifNone: [^ self]) in: [:tm | tm bottom - (tm layoutFrame bottomOffset ifNil: [0])]. ctop := (self layoutFrame topFraction * (obot - otop)) rounded + otop + (self layoutFrame topOffset ifNil: [0]). cbot := (self layoutFrame bottomFraction * (obot - otop)) rounded + otop + (self layoutFrame bottomOffset ifNil: [0]). topf := self layoutFrame topFraction. self layoutFrame topFraction: ((ctop + cbot) * 0.5 - otop) / (obot - otop) asFloat. self layoutFrame bottomFraction: self layoutFrame topFraction. + self layoutFrame topOffset: self layoutFrame topOffset - fdy. + self layoutFrame bottomOffset: self layoutFrame bottomOffset - fdy. - self layoutFrame topOffset: ctop - - (self layoutFrame topFraction * (obot - otop) + otop) truncated. - self layoutFrame bottomOffset: cbot - - (self layoutFrame bottomFraction * (obot - otop) + otop) rounded. (leftOrTop copy union: rightOrBottom) do: [:m | (m layoutFrame topFraction closeTo: topf) ifTrue: [ m layoutFrame topFraction: self layoutFrame topFraction. + m layoutFrame topOffset: m layoutFrame topOffset - fdy]. - m layoutFrame topOffset: - m layoutFrame topOffset - (self valueOfProperty: #fullDelta) y]. (m layoutFrame bottomFraction closeTo: topf) ifTrue: [ m layoutFrame bottomFraction: self layoutFrame topFraction. + m layoutFrame bottomOffset: m layoutFrame bottomOffset - fdy]]] . - m layoutFrame bottomOffset: - m layoutFrame bottomOffset - (self valueOfProperty: #fullDelta) y.]]] . self layoutFrame hasFixedWidth ifTrue: [ | oleft oright cleft cright leftf | oleft := (owner submorphs detect: [:m | m layoutFrame leftFraction isZero] ifNone: [^ self]) in: [:tm | tm left - (tm layoutFrame leftOffset ifNil: [0])]. oright := (owner submorphs detect: [:m | m layoutFrame rightFraction = 1] ifNone: [^ self]) in: [:tm | tm right - (tm layoutFrame rightOffset ifNil: [0])]. cleft := (self layoutFrame leftFraction * (oright - oleft)) rounded + oleft + (self layoutFrame leftOffset ifNil: [0]). cright := (self layoutFrame rightFraction * (oright - oleft)) rounded + oleft + (self layoutFrame rightOffset ifNil: [0]). leftf := self layoutFrame leftFraction. self layoutFrame leftFraction: ((cleft + cright) * 0.5 - oleft) / (oright - oleft) asFloat. self layoutFrame rightFraction: self layoutFrame leftFraction. - self layoutFrame leftOffset: cleft - - (self layoutFrame leftFraction * (oright - oleft) + oleft) truncated. - self layoutFrame rightOffset: cright - - (self layoutFrame rightFraction * (oright - oleft) + oleft) rounded. + self layoutFrame leftOffset: self layoutFrame leftOffset - fdx. + self layoutFrame rightOffset: self layoutFrame rightOffset - fdx. + (leftOrTop copy union: rightOrBottom) do: [:m | (m layoutFrame leftFraction closeTo: leftf) ifTrue: [ m layoutFrame leftFraction: self layoutFrame leftFraction. + m layoutFrame leftOffset: m layoutFrame leftOffset - fdx]. - m layoutFrame leftOffset: - m layoutFrame leftOffset - (self valueOfProperty: #fullDelta) x]. (m layoutFrame rightFraction closeTo: leftf) ifTrue: [ m layoutFrame rightFraction: self layoutFrame leftFraction. + m layoutFrame rightOffset: m layoutFrame rightOffset - fdx.]]] . + - m layoutFrame rightOffset: - m layoutFrame rightOffset - (self valueOfProperty: #fullDelta) x.]]] . - self removeProperty: #fullDelta. owner layoutChanged ! Item was added: + ----- Method: ProportionalSplitterMorph>>stopStepping (in category 'events') ----- + stopStepping + super stopStepping. + (self class smartVerticalSplitters or: [ self class smartHorizontalSplitters ]) ifFalse: [ self balanceOffsets ]! Item was changed: ----- Method: SimpleHaloMorph>>transferHalo: (in category 'pop up') ----- transferHalo: event + "Transfer the halo to the next likely recipient" - "Transfer the halo to the next likely recipient. Switch between siblings if overlapping." - (self target world morphsAt: event position) allButFirst "... the halo itself" - detect: [:morph | - "Sibling found?" - (morph owner == self target owner - and: [morph ~~ self target]) - ifTrue: [ - ^ morph invokeHaloOrMove: event]. - "No sibling possible anymore?" - morph == self target]. - self target transferHalo: (event transformedBy: (self target transformedFrom: self)) from: self target.! Item was changed: ----- Method: SystemWindow>>filterEvent:for: (in category 'events') ----- filterEvent: aKeyboardEvent for: anObject "Provide keyboard shortcuts." + - aKeyboardEvent isKeystroke ifFalse: [^ aKeyboardEvent]. + + aKeyboardEvent hand halo ifNotNil: [ : halo | halo target isSystemWindow ifTrue: [ aKeyboardEvent hand removeHalo ] ]. aKeyboardEvent commandKeyPressed ifTrue: [ + aKeyboardEvent keyCharacter caseOf: { - aKeyboardEvent keyCharacter caseOf: { [$\] -> [self class sendTopWindowToBack]. [Character escape] -> [self class deleteTopWindow]. [$/] -> [self class bringWindowUnderHandToFront]. } otherwise: [^ aKeyboardEvent "no hit"]. ^ aKeyboardEvent ignore "hit!!"]. aKeyboardEvent controlKeyPressed ifTrue: [ aKeyboardEvent keyCharacter caseOf: { [Character escape] -> [self world findWindow: aKeyboardEvent]. } otherwise: [^ aKeyboardEvent "no hit"]. ^ aKeyboardEvent ignore "hit!!"]. ^ aKeyboardEvent "no hit"!

3 6

The Trunk: MorphicExtras-kfr.249.mcz
by commits＠source.squeak.org 31 Dec '18

31 Dec '18

Karl Ramberg uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-kfr.249.mcz ==================== Summary ==================== Name: MorphicExtras-kfr.249 Author: kfr Time: 31 December 2018, 9:35:25.929461 pm UUID: 6205084e-5509-5840-a32a-1346e335ff5e Ancestors: MorphicExtras-pre.248 Make TextOnCurve work again. Bounds in TextOnCurve are computed differently than in NewParagraph =============== Diff against MorphicExtras-pre.248 =============== Item was added: + ----- Method: TextOnCurve>>adjustRightX (in category 'private') ----- + adjustRightX + "No-op for this class. TextOnCurve have computes bounds differently"!

1 0

Primitives 34-37 for LargeIntegers bit operations not in use?
by Fabio Niephaus 31 Dec '18

31 Dec '18

Hi all, I just noticed that Squeak-trunk does not use the primitives for LargeIntegers bit operations (#34 to #37). Is there are good reason for this (disabled in the VM?) or is this just a mistake? See: SystemNavigation default browseAllSelect: [:cm | cm primitive between: 34 and: 37] Fabio

3 4

minor errors in tests during socket timeouts
by Ben Coman 31 Dec '18

31 Dec '18

An Opensmalltalk-vm Travis build job https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/473535608 looks like it failed with a socket error, probably external network. A bundle of failures look like this... SocketStreamTest 7041f6_0fb1 ✗ #testClassComment (10003ms) TestFailure: Test timed out Process>>pvtSignal:list: [] in DelayWaitTimeout>>wait <snip> which is okay, but the following three with similar >10000ms timeout did not produce "TestFailure: Test timed out " but instead "MessageNotUnderstood" errors. StringSocketTestCase c43ad5_0fb1 ✗ #testBasics (10001ms) MessageNotUnderstood: UndefinedObject>>destroy UndefinedObject(Object)>>doesNotUnderstand: #destroy StringSocketTestCase>>tearDown e360b0_0fb1 ✗ #testBogusInput1 (10000ms) MessageNotUnderstood: UndefinedObject>>destroy UndefinedObject(Object)>>doesNotUnderstand: #destroy StringSocketTestCase>>tearDown e4f711_0fb1 ✗ #testBogusInput2 (10002ms) MessageNotUnderstood: UndefinedObject>>destroy UndefinedObject(Object)>>doesNotUnderstand: #destroy StringSocketTestCase>>tearDown I'm not currently running Squeak, so I'm just reporting was I see in the CI log in case anyone was interested in touching-up such a corner case. Is it preferable to report on Mantis? Or not important :) cheers -ben

3 4

The Trunk: Nebraska-ul.54.mcz
by commits＠source.squeak.org 30 Dec '18

30 Dec '18

Levente Uzonyi uploaded a new version of Nebraska to project The Trunk: http://source.squeak.org/trunk/Nebraska-ul.54.mcz ==================== Summary ==================== Name: Nebraska-ul.54 Author: ul Time: 30 December 2018, 6:25:51.061867 pm UUID: 3b205aca-b10c-4acd-8ef6-c5cbe7101522 Ancestors: Nebraska-mt.53 - make sure StringSocketTestCase >> #tearDown works even if #setUp fails. =============== Diff against Nebraska-mt.53 =============== Item was changed: ----- Method: StringSocketTestCase>>tearDown (in category 'running') ----- tearDown + + end1 ifNotNil: [ + end1 destroy. + end1 := nil ]. + end2 ifNotNil: [ + end2 destroy. + end2 := nil ]. + "StringSocket >> #destroy is expected to destroy the tcp socket. The code below will just ensure that." + socket1 ifNotNil: [ + socket1 destroy. + socket1 := nil ]. + socket2 ifNotNil: [ + socket2 destroy. + socket2 := nil ] - end1 destroy. - end2 destroy. !

1 0

The Trunk: Chronology-Core-dtl.17.mcz
by commits＠source.squeak.org 29 Dec '18

29 Dec '18

David T. Lewis uploaded a new version of Chronology-Core to project The Trunk: http://source.squeak.org/trunk/Chronology-Core-dtl.17.mcz ==================== Summary ==================== Name: Chronology-Core-dtl.17 Author: dtl Time: 15 December 2018, 6:44:08.809994 pm UUID: 9d9b49d4-46f4-496f-bfd1-70fdb1641e43 Ancestors: Chronology-Core-dtl.16 Bootstrap UTCDateAndTime, step 2 of 5 Start using LXDateAndTime instead of DateAndTime. Change instance creation in DateAndTime to create LXDateAndTime instances instead. In the postscript, have all DateAndTime instances become LXDateAndTime. =============== Diff against Chronology-Core-dtl.16 =============== Item was changed: ----- Method: DateAndTime class>>fromSeconds: (in category 'smalltalk-80') ----- fromSeconds: seconds "Answer a DateAndTime since the Squeak epoch: 1 January 1901" + ^ LXDateAndTime fromSeconds: seconds + " | integerSeconds nanos | - | integerSeconds nanos | integerSeconds := seconds truncated. integerSeconds = seconds ifTrue: [nanos := 0] ifFalse: [nanos := (seconds - integerSeconds * NanosInSecond) asInteger]. ^ self basicNew ticks: (Array with: SqueakEpoch with: integerSeconds with: nanos) + offset: self localOffset"! - offset: self localOffset! Item was changed: ----- Method: DateAndTime class>>julianDayNumber:offset: (in category 'squeak protocol') ----- + julianDayNumber: anInteger offset: aDuration + ^ LXDateAndTime julianDayNumber: anInteger offset: aDuration + " ^ self basicNew + ticks: anInteger days ticks + offset: aDuration ; + yourself"! - julianDayNumber: anInteger offset: aDuration - - ^self basicNew - setJdn: anInteger - seconds: 0 - nano: 0 - offset: aDuration! Item was changed: ----- Method: DateAndTime class>>now (in category 'ansi protocol') ----- now + + ^LXDateAndTime now. + " [ | timeArray | + timeArray := self primPosixMicrosecondClockWithOffset. + ^ self utcMicroseconds: timeArray first offset: timeArray second] + on: Error + do: [ ""Use old style primitive support"" + ^self nowWithOffset: self localOffset]"! - | clockAndOffset | - clockAndOffset := self clock localMicrosecondClockWithOffset. - (self automaticTimezone and: - [self localOffset asSeconds ~= clockAndOffset second]) - ifTrue: [self localOffset: (Duration seconds: clockAndOffset second)]. - ^self now: clockAndOffset first offset: self localOffset! Item was changed: ----- Method: DateAndTime class>>year:month:day:hour:minute:second:nanoSecond:offset: (in category 'squeak protocol') ----- year: year month: month day: day hour: hour minute: minute second: second nanoSecond: nanoCount offset: offset "Return a DateAndTime" + ^ LXDateAndTime year: year month: month day: day hour: hour minute: minute second: second nanoSecond: nanoCount offset: offset + " | monthIndex daysInMonth p q r s julianDayNumber | - | monthIndex daysInMonth p q r s julianDayNumber | monthIndex := month isInteger ifTrue: [month] ifFalse: [Month indexOfMonth: month]. daysInMonth := Month daysInMonth: monthIndex forYear: year. day < 1 ifTrue: [self error: 'day may not be zero or negative']. day > daysInMonth ifTrue: [self error: 'day is after month ends']. p := (monthIndex - 14) quo: 12. q := year + 4800 + p. r := monthIndex - 2 - (12 * p). s := (year + 4900 + p) quo: 100. julianDayNumber := ( (1461 * q) quo: 4 ) + ( (367 * r) quo: 12 ) - ( (3 * s) quo: 4 ) + ( day - 32075 ). ^self basicNew setJdn: julianDayNumber seconds: hour * 60 + minute * 60 + second nano: nanoCount offset: offset; + yourself"! - yourself! Item was added: + ----- Method: LXDateAndTime>>floor (in category 'squeak protocol') ----- + floor + "Answer a copy with magnitude rounded down to the nearest whole second" + ^self class + utcMicroseconds: utcMicroseconds - (utcMicroseconds \\ 1000000) + offset: localOffsetSeconds! Item was changed: ----- Method: TimeStamp class>>current (in category 'squeak protocol') ----- current + ^self now! - | ts ticks | - ts := super now asTimeStamp. - ticks := ts ticks. - ticks at: 3 put: 0. - ts ticks: ticks offset: ts offset. - ^ ts - ! Item was removed: - ----- Method: TimeStamp class>>now (in category 'ansi protocol') ----- - now - "Answer the current date and time as a TimeStamp." - - ^self current! Item was changed: ----- Method: Timespan class>>defaultOffset (in category 'configuring') ----- defaultOffset + "Timespans created in the context of an offset will start in that offset. When no context is available, the defaultOffset for Timespans must be zero. For example, two ways to make a Date for today: + Date today. 'start is midnight at offset zero. Will compare successfully to other Date today results.' + DateAndTime now asDate. 'In this case, the start is midnight of the local time-zone. It can only compare equally to Dates of its time-zone.'" + ^ Duration zero! - "Timespans created in the context of an offset will start in that offset. When no context is available, the defaultOffset for Timespans must be nil. For example, two ways to make a Date for today: - Date today. 'start is midnight without offset. Will compare successfully to other Date today results.' - DateAndTime now asDate. 'In this case, the start is midnight of the local time-zone. It can only compare equally to Dates of its time-zone or Dates without timezone.'" - ^ nil! Item was changed: + (PackageInfo named: 'Chronology-Core') postscript: '"Convert all instances of DateAndTime and TimeStamp to the equivalent LXDateAndTime and LXTimeStamp." - (PackageInfo named: 'Chronology-Core') postscript: '"Ensure that the object history mark process uses DateAndTime>>floor rather than an earlier implementation that relied on a named instance variable." + | oldInstances newInstances | + Smalltalk garbageCollect. + oldInstances := DateAndTime allInstances, TimeStamp allInstances. + newInstances := oldInstances collect: [ :each | + each class == DateAndTime + ifTrue: [ each asLXDateAndTime ] + ifFalse: [ each asLXTimeStamp ] ]. + oldInstances elementsForwardIdentityTo: newInstances. + Smalltalk garbageCollect. + + "Ensure that the object history mark process uses DateAndTime>>floor rather than an earlier implementation that relied on a named instance variable." + Smalltalk at: #ObjectHistory ifPresent: [ :cls | cls current restartMarkProcess ]. '!

2 2