Squeak-dev December 2018

squeak-dev@lists.squeakfoundation.org

30 participants
115 discussions

The Trunk: ToolsTests-pre.88.mcz
by commits＠source.squeak.org 01 Dec '18

01 Dec '18

Patrick Rein uploaded a new version of ToolsTests to project The Trunk: http://source.squeak.org/trunk/ToolsTests-pre.88.mcz ==================== Summary ==================== Name: ToolsTests-pre.88 Author: pre Time: 1 December 2018, 5:30:40.389597 pm UUID: e09a182b-d053-484f-a21d-089e43b4ee45 Ancestors: ToolsTests-pre.87 Recategorized tests into the tests category (sorry could not resist). No other changes. =============== Diff against ToolsTests-pre.87 =============== Item was changed: + ----- Method: BrowseTest>>testBrowseClass (in category 'tests') ----- - ----- Method: BrowseTest>>testBrowseClass (in category 'testing') ----- testBrowseClass "self debug: #testBrowseClass" | browsersBefore browsersAfter opened | self ensureMorphic. browsersBefore := self currentBrowsers. self withImmediatelyOpeningWindowsDo: [1 class browse]. browsersAfter := self currentBrowsers. self assert: (browsersAfter size = (browsersBefore size + 1)). opened := browsersAfter removeAll: browsersBefore; yourself. self assert: (opened size = 1). opened := opened asArray first. self assert: (opened model selectedClass == SmallInteger). opened delete ! Item was changed: + ----- Method: BrowseTest>>testBrowseHierarchyClass (in category 'tests') ----- - ----- Method: BrowseTest>>testBrowseHierarchyClass (in category 'testing') ----- testBrowseHierarchyClass "self debug: #testBrowseHierarchyClass" | browsersBefore browsersAfter opened | self ensureMorphic. browsersBefore := self currentHierarchyBrowsers. self withImmediatelyOpeningWindowsDo: [1 class browseHierarchy]. browsersAfter := self currentHierarchyBrowsers. self assert: (browsersAfter size = (browsersBefore size + 1)). opened := browsersAfter removeAll: browsersBefore; yourself. self assert: (opened size = 1). opened := opened asArray first. self assert: (opened model selectedClass == SmallInteger). opened delete ! Item was changed: + ----- Method: BrowseTest>>testBrowseHierarchyInstance (in category 'tests') ----- - ----- Method: BrowseTest>>testBrowseHierarchyInstance (in category 'testing') ----- testBrowseHierarchyInstance "self debug: #testBrowseHierarchyInstance" | browsersBefore browsersAfter opened | self ensureMorphic. browsersBefore := self currentHierarchyBrowsers. self withImmediatelyOpeningWindowsDo: [1 browseHierarchy]. browsersAfter := self currentHierarchyBrowsers. self assert: (browsersAfter size = (browsersBefore size + 1)). opened := browsersAfter removeAll: browsersBefore; yourself. self assert: (opened size = 1). opened := opened asArray first. self assert: (opened model selectedClass == SmallInteger). opened delete ! Item was changed: + ----- Method: BrowseTest>>testBrowseHierarchyMetaclass (in category 'tests') ----- - ----- Method: BrowseTest>>testBrowseHierarchyMetaclass (in category 'testing') ----- testBrowseHierarchyMetaclass "self debug: #testBrowseHierarchyMetaclass" | browsersBefore browsersAfter opened | self ensureMorphic. browsersBefore := self currentHierarchyBrowsers. self withImmediatelyOpeningWindowsDo: [1 class class browseHierarchy]. browsersAfter := self currentHierarchyBrowsers. self assert: (browsersAfter size = (browsersBefore size + 1)). opened := browsersAfter removeAll: browsersBefore; yourself. self assert: (opened size = 1). opened := opened asArray first. self assert: (opened model selectedClass == Metaclass). opened delete ! Item was changed: + ----- Method: BrowseTest>>testBrowseInstance (in category 'tests') ----- - ----- Method: BrowseTest>>testBrowseInstance (in category 'testing') ----- testBrowseInstance "self debug: #testBrowseInstance" | browsersBefore browsersAfter opened | self ensureMorphic. browsersBefore := self currentBrowsers. self withImmediatelyOpeningWindowsDo: [1 browse]. browsersAfter := self currentBrowsers. self assert: (browsersAfter size = (browsersBefore size + 1)). opened := browsersAfter removeAll: browsersBefore; yourself. self assert: (opened size = 1). opened := opened asArray first. self assert: (opened model selectedClass == SmallInteger). opened delete ! Item was changed: + ----- Method: BrowseTest>>testBrowseMetaclass (in category 'tests') ----- - ----- Method: BrowseTest>>testBrowseMetaclass (in category 'testing') ----- testBrowseMetaclass "self debug: #testBrowseMetaclass" | browsersBefore browsersAfter opened | self ensureMorphic. browsersBefore := self currentBrowsers. self withImmediatelyOpeningWindowsDo: [1 class class browse]. browsersAfter := self currentBrowsers. self assert: (browsersAfter size = (browsersBefore size + 1)). opened := browsersAfter removeAll: browsersBefore; yourself. self assert: (opened size = 1). opened := opened asArray first. self assert: (opened model selectedClass == SmallInteger). opened delete ! Item was changed: + ----- Method: BrowseTest>>testFindReferencesToFloatNaN (in category 'tests') ----- - ----- Method: BrowseTest>>testFindReferencesToFloatNaN (in category 'testing') ----- testFindReferencesToFloatNaN self assert: (SystemNavigation new allCallsOn: (Float bindingOf: #NaN)) notEmpty! Item was changed: + ----- Method: BrowseTest>>testSystemNavigationAllBehaviorsDo (in category 'tests') ----- - ----- Method: BrowseTest>>testSystemNavigationAllBehaviorsDo (in category 'testing') ----- testSystemNavigationAllBehaviorsDo | oc | oc := OrderedCollection new. SystemNavigation new allBehaviorsDo: [:c| oc add: c]. self assert: oc size = oc asSet size! Item was changed: + ----- Method: DebuggerExtensionsTest>>testBooleansGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testBooleansGeneralise (in category 'testing - canonical argument names') ----- testBooleansGeneralise self assert: Boolean name equals: true canonicalArgumentName. self assert: Boolean name equals: false canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testByteStringsGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testByteStringsGeneralise (in category 'testing - canonical argument names') ----- testByteStringsGeneralise self assert: String name equals: ByteString new canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testClassesGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testClassesGeneralise (in category 'testing - canonical argument names') ----- testClassesGeneralise self assert: Class name equals: Class new canonicalArgumentName. self assert: Class name equals: 1 class canonicalArgumentName. self assert: Class name equals: true class canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testCollectionsGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testCollectionsGeneralise (in category 'testing - canonical argument names') ----- testCollectionsGeneralise "ArrayedCollection and subclasses answer 'Array' " self assert: Array name equals: Array new canonicalArgumentName. "Otherwise answer the more general 'Collection' " self assert: Collection name equals: OrderedCollection new canonicalArgumentName. self assert: Collection name equals: LinkedList new canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testFloatsGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testFloatsGeneralise (in category 'testing - canonical argument names') ----- testFloatsGeneralise self assert: Number name equals: 1.0 canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testFractionsGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testFractionsGeneralise (in category 'testing - canonical argument names') ----- testFractionsGeneralise self assert: Number name equals: (1 / 2) canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testIntegersDontGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testIntegersDontGeneralise (in category 'testing - canonical argument names') ----- testIntegersDontGeneralise self assert: Integer name equals: 1 canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testLargeNegativeIntegersGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testLargeNegativeIntegersGeneralise (in category 'testing - canonical argument names') ----- testLargeNegativeIntegersGeneralise self assert: Integer name equals: LargeNegativeInteger initializedInstance canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testLargePositiveIntegersGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testLargePositiveIntegersGeneralise (in category 'testing - canonical argument names') ----- testLargePositiveIntegersGeneralise self assert: Integer name equals: LargePositiveInteger initializedInstance canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testOtherObjectsDontGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testOtherObjectsDontGeneralise (in category 'testing - canonical argument names') ----- testOtherObjectsDontGeneralise self assert: Behavior name equals: Behavior new canonicalArgumentName. self assert: UndefinedObject name equals: nil canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testScaledDecimalsGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testScaledDecimalsGeneralise (in category 'testing - canonical argument names') ----- testScaledDecimalsGeneralise self assert: Number name equals: 2.00s2 canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testStringsDontGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testStringsDontGeneralise (in category 'testing - canonical argument names') ----- testStringsDontGeneralise self assert: String name equals: String new canonicalArgumentName! Item was changed: + ----- Method: DebuggerExtensionsTest>>testWideStringsGeneralise (in category 'tests - canonical argument names') ----- - ----- Method: DebuggerExtensionsTest>>testWideStringsGeneralise (in category 'testing - canonical argument names') ----- testWideStringsGeneralise self assert: String name equals: WideString new canonicalArgumentName! Item was changed: + ----- Method: DebuggerUnwindBug>>testUnwindBlock (in category 'tests') ----- - ----- Method: DebuggerUnwindBug>>testUnwindBlock (in category 'testing') ----- testUnwindBlock "test if unwind blocks work properly" | sema process | sema := Semaphore forMutualExclusion. self assert: sema isSignaled. "deadlock on the semaphore" process := [sema critical:[sema wait]] forkAt: Processor userInterruptPriority. self deny: sema isSignaled. "terminate process" process terminate. self assert: sema isSignaled. ! Item was changed: + ----- Method: DebuggerUnwindBug>>testUnwindDebugger (in category 'tests') ----- - ----- Method: DebuggerUnwindBug>>testUnwindDebugger (in category 'testing') ----- testUnwindDebugger "test if unwind blocks work properly when a debugger is closed" | sema process debugger top | sema := Semaphore forMutualExclusion. self assert: sema isSignaled. process := [sema critical:[sema wait]] forkAt: Processor userInterruptPriority. self deny: sema isSignaled. "everything set up here - open a debug notifier" debugger := Debugger openInterrupt: 'test' onProcess: process. "get into the debugger" debugger debug. top := debugger topView. "set top context" debugger toggleContextStackIndex: 1. "close debugger" top delete. "and see if unwind protection worked" self assert: sema isSignaled.! Item was changed: + ----- Method: DependencyBrowserTest>>testBrowse (in category 'tests - buttons') ----- - ----- Method: DependencyBrowserTest>>testBrowse (in category 'testing - buttons') ----- testBrowse | b | browser packageListIndex: (browser packageList indexOf: #Collections). browser packageDepsIndex: (browser packageDeps indexOf: #Compiler). browser classDepsIndex: (browser classDeps indexOf: #Scanner). browser classListIndex: (browser classList indexOf: #Symbol). browser messageListIndex: 1. b := browser browseMethodFull. self assert: b notNil. [self assert: b selectedMessageName = (browser messageList at: browser messageListIndex) ] ensure: [ToolBuilder default close: b topView]! Item was changed: + ----- Method: DependencyBrowserTest>>testClassList (in category 'tests - class list') ----- - ----- Method: DependencyBrowserTest>>testClassList (in category 'testing - class list') ----- testClassList "Warning!! When Collections' dependencies change, this test may start to fail!!" self assert: #() equals: browser classList description: 'classList before package selection'. browser packageListIndex: (browser packageList indexOf: #Collections). self assert: #() equals: browser classList description: 'classList after selecting Collections'. browser packageDepsIndex: (browser packageDeps indexOf: #Compiler). self assert: #() equals: browser classList description: 'classList after selecting Compiler'. browser classDepsIndex: (browser classDeps indexOf: #Scanner). self assert: #(Character String Symbol 'Symbol class') equals: browser classList description: 'classList after selecting Scanner class'. browser classListIndex: (browser classList indexOf: #Symbol). self assert: #(Character String Symbol 'Symbol class') equals: browser classList description: 'classList after selecting Symbol class'.! Item was changed: + ----- Method: DependencyBrowserTest>>testHasPackageSelected (in category 'tests - metaclass') ----- - ----- Method: DependencyBrowserTest>>testHasPackageSelected (in category 'testing - metaclass') ----- testHasPackageSelected self deny: browser hasPackageSelected. browser packageListIndex: 1. self assert: browser hasPackageSelected. browser packageListIndex: 0. self deny: browser hasPackageSelected.! Item was changed: + ----- Method: DependencyBrowserTest>>testSelectedClassOrMetaClass (in category 'tests - metaclass') ----- - ----- Method: DependencyBrowserTest>>testSelectedClassOrMetaClass (in category 'testing - metaclass') ----- testSelectedClassOrMetaClass "Warning!! When Collections' dependencies change, this test may start to fail!!" self assert: browser selectedClassOrMetaClass isNil. browser packageListIndex: (browser packageList indexOf: #Collections). self assert: browser selectedClassOrMetaClass isNil. browser packageDepsIndex: (browser packageDeps indexOf: #Compiler). self assert: browser selectedClassOrMetaClass isNil. browser classDepsIndex: (browser classDeps indexOf: #Scanner). self assert: browser selectedClassOrMetaClass isNil. browser classListIndex: (browser classList indexOf: #Symbol). self deny: browser selectedClassOrMetaClass isNil. self assert: browser selectedClassOrMetaClass == Symbol.! Item was changed: + ----- Method: DependencyBrowserTest>>testSelectedMessageClassSideShowsSource (in category 'tests - message list') ----- - ----- Method: DependencyBrowserTest>>testSelectedMessageClassSideShowsSource (in category 'testing - message list') ----- testSelectedMessageClassSideShowsSource "Warning!! When Collections' dependencies change, this test may start to fail!!" browser packageListIndex: (browser packageList indexOf: #'Chronology-Core'). browser packageDepsIndex: (browser packageDeps indexOf: #Collections). browser classDepsIndex: (browser classDeps indexOf: #'Array'). browser classListIndex: (browser classList indexOf: #'DateAndTime class'). browser messageListIndex: 1. self assert: browser selectedMessageName == #fromSeconds:. self assert: browser contents = (DateAndTime class sourceCodeAt: #fromSeconds:) ! Item was changed: + ----- Method: DependencyBrowserTest>>testSelectedMessageName (in category 'tests - message list') ----- - ----- Method: DependencyBrowserTest>>testSelectedMessageName (in category 'testing - message list') ----- testSelectedMessageName "Warning!! When Collections' dependencies change, this test may start to fail!!" self assert: browser selectedMessageName isNil. browser packageListIndex: (browser packageList indexOf: #Collections). self assert: browser selectedMessageName isNil. browser packageDepsIndex: (browser packageDeps indexOf: #Compiler). self assert: browser selectedMessageName isNil. browser classDepsIndex: (browser classDeps indexOf: #Scanner). self assert: browser selectedMessageName isNil. browser classListIndex: (browser classList indexOf: #Symbol). self assert: browser selectedMessageName isNil. browser messageListIndex: 1. self assert: browser selectedMessageName == #storeOn:. browser messageListIndex: 0. self assert: browser selectedMessageName isNil.! Item was changed: + ----- Method: DependencyBrowserTest>>testSelectedMessageNameClassSide (in category 'tests - message list') ----- - ----- Method: DependencyBrowserTest>>testSelectedMessageNameClassSide (in category 'testing - message list') ----- testSelectedMessageNameClassSide "Warning!! When Collections' dependencies change, this test may start to fail!!" self assert: browser selectedMessageName isNil. browser packageListIndex: (browser packageList indexOf: #'Chronology-Core'). self assert: browser selectedMessageName isNil. browser packageDepsIndex: (browser packageDeps indexOf: #Collections). self assert: browser selectedMessageName isNil. browser classDepsIndex: (browser classDeps indexOf: #Array). self assert: browser selectedMessageName isNil. browser classListIndex: (browser classList indexOf: #'DateAndTime class'). self assert: browser selectedMessageName isNil. browser messageListIndex: 1. self assert: browser selectedMessageName == #fromSeconds:. ! Item was changed: + ----- Method: FileList2ModalDialogsTest>>testModalFileSelector (in category 'tests') ----- - ----- Method: FileList2ModalDialogsTest>>testModalFileSelector (in category 'running') ----- testModalFileSelector | window fileList2 | window := FileList2 morphicViewFileSelector. window openCenteredInWorld. fileList2 := window valueOfProperty: #fileListModel. fileList2 fileListIndex: 1. window delete. self assert: fileList2 getSelectedFile isNil. fileList2 okHit. self deny: fileList2 getSelectedFile isNil ! Item was changed: + ----- Method: FileList2ModalDialogsTest>>testModalFileSelectorForSuffixes (in category 'tests') ----- - ----- Method: FileList2ModalDialogsTest>>testModalFileSelectorForSuffixes (in category 'running') ----- testModalFileSelectorForSuffixes | window fileList2 | window := FileList2 morphicViewFileSelectorForSuffixes: nil. window openCenteredInWorld. fileList2 := window valueOfProperty: #fileListModel. fileList2 fileListIndex: 1. window delete. self assert: fileList2 getSelectedFile isNil. fileList2 okHit. self deny: fileList2 getSelectedFile isNil ! Item was changed: + ----- Method: FileList2ModalDialogsTest>>testModalFolderSelector (in category 'tests') ----- - ----- Method: FileList2ModalDialogsTest>>testModalFolderSelector (in category 'running') ----- testModalFolderSelector | window fileList2 | window := FileList2 morphicViewFolderSelector. fileList2 := window model. window openInWorld: self currentWorld extent: 300@400. fileList2 fileListIndex: 1. window delete. self assert: fileList2 getSelectedDirectory withoutListWrapper isNil. fileList2 okHit. self deny: fileList2 getSelectedDirectory withoutListWrapper isNil ! Item was changed: + ----- Method: FileList2ModalDialogsTest>>testModalFolderSelectorForProjectLoad (in category 'tests') ----- - ----- Method: FileList2ModalDialogsTest>>testModalFolderSelectorForProjectLoad (in category 'running') ----- testModalFolderSelectorForProjectLoad | window fileList2 w | window := FileList2 morphicViewProjectLoader2InWorld: self currentWorld reallyLoad: false. fileList2 := window valueOfProperty: #FileList. w := self currentWorld. window position: w topLeft + (w extent - window extent // 2). window openInWorld: w. window delete. self assert: fileList2 getSelectedDirectory withoutListWrapper isNil. fileList2 okHit. self deny: fileList2 getSelectedDirectory withoutListWrapper isNil ! Item was changed: + ----- Method: FileListTest>>testAllRegisteredServices (in category 'tests') ----- - ----- Method: FileListTest>>testAllRegisteredServices (in category 'test') ----- testAllRegisteredServices "(self selector: #testAllRegisteredServices) debug" "This should not throw an exception." FileList allRegisteredServices.! Item was changed: + ----- Method: FileListTest>>testMenuReturned (in category 'tests') ----- - ----- Method: FileListTest>>testMenuReturned (in category 'test') ----- testMenuReturned "(self selector: #testToolRegistered) debug" self assert: (FileList registeredFileReaderClasses includes: DummyToolWorkingWithFileList)! Item was changed: + ----- Method: FileListTest>>testService (in category 'tests') ----- - ----- Method: FileListTest>>testService (in category 'test') ----- testService "a stupid test to check that the class returns a service" "(self selector: #testService) debug" | service | service := (DummyToolWorkingWithFileList fileReaderServicesForFile: 'abab.kkk' suffix: 'kkk') first. self assert: (self checkIsServiceIsFromDummyTool: service). service := (DummyToolWorkingWithFileList fileReaderServicesForFile: 'zkk.gz' suffix: 'gz'). self assert: service isEmpty! Item was changed: + ----- Method: FileListTest>>testServicesForFileEnding (in category 'tests') ----- - ----- Method: FileListTest>>testServicesForFileEnding (in category 'test') ----- testServicesForFileEnding "(self selector: #testServicesForFileEnding) debug" | items | items := (FileList new directory: FileDirectory default; yourself) itemsForFile: (FileDirectory default fullNameFor: 'aaa.kkk'). self assert: (items anySatisfy: [ :ea | self checkIsServiceIsFromDummyTool: ea ]). ! Item was changed: + ----- Method: FileListTest>>testToolRegistered (in category 'tests') ----- - ----- Method: FileListTest>>testToolRegistered (in category 'test') ----- testToolRegistered "(self selector: #testToolRegistered) debug" self assert: (FileList registeredFileReaderClasses includes: DummyToolWorkingWithFileList)! Item was changed: + ----- Method: FileListTest>>testToolRegisteredUsingInterface (in category 'tests') ----- - ----- Method: FileListTest>>testToolRegisteredUsingInterface (in category 'test') ----- testToolRegisteredUsingInterface "(self selector: #testToolRegisteredUsingInterface) debug" self assert: (FileList isReaderNamedRegistered: #DummyToolWorkingWithFileList)! Item was changed: + ----- Method: HierarchyBrowserTest>>setUp (in category 'running') ----- - ----- Method: HierarchyBrowserTest>>setUp (in category 'as yet unclassified') ----- setUp browser := HierarchyBrowser new.! Item was changed: + ----- Method: HierarchyBrowserTest>>testClassList (in category 'tests') ----- - ----- Method: HierarchyBrowserTest>>testClassList (in category 'as yet unclassified') ----- testClassList | c displayedClasses hierarchy | browser initHierarchyForClass: browser class. c := browser class theNonMetaClass. displayedClasses := browser classList collect: [:each | each withoutLeadingBlanks ]. hierarchy := (c allSuperclasses reversed, {browser class}, c allSubclasses) collect: [ :each | each name ]. self assert: displayedClasses = hierarchy.! Item was changed: + ----- Method: HierarchyBrowserTest>>testClassListIndex (in category 'tests') ----- - ----- Method: HierarchyBrowserTest>>testClassListIndex (in category 'as yet unclassified') ----- testClassListIndex | expectedCat | expectedCat := [:i | (Smalltalk at: (browser classList at: i) withoutLeadingBlanks asSymbol) category ]. browser initHierarchyForClass: browser class. self deny: browser classListIndex = 0. 1 to: 3 do: [:n | browser classListIndex: n. self assert: browser classListIndex = n. self assert: browser selectedSystemCategory = (expectedCat value: n)]! Item was changed: + ----- Method: HierarchyBrowserTest>>testClassListSansWhitespace (in category 'tests') ----- - ----- Method: HierarchyBrowserTest>>testClassListSansWhitespace (in category 'as yet unclassified') ----- testClassListSansWhitespace | c displayedClasses hierarchy | browser initHierarchyForClass: browser class. c := browser class theNonMetaClass. displayedClasses := browser classList collect: [:each | each withoutLeadingBlanks ]. hierarchy := (c allSuperclasses reversed, {browser class}, c allSubclasses) collect: [ :each | each name ]. self assert: displayedClasses = hierarchy.! Item was changed: + ----- Method: HierarchyBrowserTest>>testInitHierarchyForClass (in category 'tests') ----- - ----- Method: HierarchyBrowserTest>>testInitHierarchyForClass (in category 'as yet unclassified') ----- testInitHierarchyForClass | b | b := HierarchyBrowser new initHierarchyForClass: browser class. self assert: b selectedClassName = browser class name.! Item was changed: + ----- Method: HierarchyBrowserTest>>testSelectClass (in category 'tests') ----- - ----- Method: HierarchyBrowserTest>>testSelectClass (in category 'as yet unclassified') ----- testSelectClass browser initHierarchyForClass: browser class. browser selectClass: ProtoObject. self assert: browser selectedClass = ProtoObject. browser selectClass: CodeHolder. self assert: browser selectedClass = CodeHolder.! Item was changed: + ----- Method: HierarchyBrowserTest>>testSelectedClassName (in category 'tests') ----- - ----- Method: HierarchyBrowserTest>>testSelectedClassName (in category 'as yet unclassified') ----- testSelectedClassName browser initHierarchyForClass: browser class. self assert: browser selectedClassName = browser class name. browser classListIndex: 0. self assert: browser selectedClassName isNil.! Item was changed: + ----- Method: MessageNamesTest>>setUp (in category 'running') ----- - ----- Method: MessageNamesTest>>setUp (in category 'as yet unclassified') ----- setUp browser := MessageNames openMessageNames.! Item was changed: + ----- Method: MessageNamesTest>>tearDown (in category 'running') ----- - ----- Method: MessageNamesTest>>tearDown (in category 'as yet unclassified') ----- tearDown browser topView ifNotNil: [:v | ToolBuilder default close: v].! Item was changed: + ----- Method: MessageNamesTest>>testCannotUnselectCategory (in category 'tests') ----- - ----- Method: MessageNamesTest>>testCannotUnselectCategory (in category 'as yet unclassified') ----- testCannotUnselectCategory | selectorList | browser searchString: 'cull'. browser selectorListIndex: 1. selectorList := browser selectorList copy. browser selectorListIndex: 0. self assert: selectorList = browser selectorList.! Item was changed: + ----- Method: MessageNamesTest>>testOpenMessageNames (in category 'tests') ----- - ----- Method: MessageNamesTest>>testOpenMessageNames (in category 'as yet unclassified') ----- testOpenMessageNames | b | b := MessageNames openMessageNames. [self assert: (b isKindOf: MessageNames)] ensure: [ToolBuilder default close: b topView].! Item was changed: + ----- Method: MessageNamesTest>>testSearchString (in category 'tests') ----- - ----- Method: MessageNamesTest>>testSearchString (in category 'as yet unclassified') ----- testSearchString | cCount cullCount cullCullCount | browser searchString: 'c'. cCount := browser selectorList size. browser searchString: 'cull:'. cullCount := browser selectorList size. self assert: cullCount < cCount. browser searchString: 'cull:cull:'. cullCullCount := browser selectorList size. self assert: cullCullCount < cullCount.! Item was changed: + ----- Method: MessageNamesTest>>testSelectedClassOrMetaClass (in category 'tests') ----- - ----- Method: MessageNamesTest>>testSelectedClassOrMetaClass (in category 'as yet unclassified') ----- testSelectedClassOrMetaClass | firstClass | browser searchString: 'cull'. firstClass := browser messageList first actualClass. browser messageListIndex: 1. self assert: browser selectedClassOrMetaClass = firstClass. browser messageListIndex: 0. self assert: browser selectedClassOrMetaClass isNil. "And just to be sure:" browser messageListIndex: 1. self assert: browser selectedClassOrMetaClass = firstClass.! Item was changed: + ----- Method: MessageNamesTest>>testSelectedMessageCategoryName (in category 'tests') ----- - ----- Method: MessageNamesTest>>testSelectedMessageCategoryName (in category 'as yet unclassified') ----- testSelectedMessageCategoryName browser searchString: 'cull'. browser selectorListIndex: 1. browser messageListIndex: 1. self deny: browser selectedMessageCategoryName isNil. browser messageListIndex: 0. self assert: browser selectedMessageCategoryName isNil.! Item was changed: + ----- Method: MessageNamesTest>>testSelection (in category 'tests') ----- - ----- Method: MessageNamesTest>>testSelection (in category 'as yet unclassified') ----- testSelection browser searchString: 'cull'. browser selectorListIndex: 1. browser messageListIndex: 1. self assert: (browser selection isKindOf: MethodReference). browser messageListIndex: 0. self assert: browser selection isNil.! Item was changed: + ----- Method: MessageSetTest>>testAutoSelectString (in category 'tests') ----- - ----- Method: MessageSetTest>>testAutoSelectString (in category 'testing') ----- testAutoSelectString browser autoSelectString: 'browseAllImplementorsOf:'. self assert: browser autoSelectString = 'browseAllImplementorsOf:'. browser messageListIndex: 2. self assert: (updates includes: #autoSelect).! Item was changed: + ----- Method: MessageSetTest>>testContents (in category 'tests') ----- - ----- Method: MessageSetTest>>testContents (in category 'testing') ----- testContents browser messageListIndex: 0. self assert: browser contents = ''. browser messageListIndex: 1. self deny: browser contents = ''. ! Item was changed: + ----- Method: MessageSetTest>>testHasMessageSelected (in category 'tests') ----- - ----- Method: MessageSetTest>>testHasMessageSelected (in category 'testing') ----- testHasMessageSelected browser messageListIndex: 1. self assert: browser hasMessageSelected. browser messageListIndex: 0. self deny: browser hasMessageSelected. "And just to be sure:" browser messageListIndex: 1. self assert: browser hasMessageSelected.! Item was changed: + ----- Method: MessageSetTest>>testRemoveMessageFromBrowser (in category 'tests') ----- - ----- Method: MessageSetTest>>testRemoveMessageFromBrowser (in category 'testing') ----- testRemoveMessageFromBrowser | count sel | browser messageListIndex: 1. sel := browser selection. browser removeMessageFromBrowser. self deny: (browser messageList includes: sel) description: 'Method not removed'. browser messageListIndex: 0. count := browser messageList size. browser removeMessageFromBrowser. self assert: count = browser messageList size description: 'Some method was removed'.! Item was changed: + ----- Method: MessageSetTest>>testSelectedClassOrMetaClass (in category 'tests') ----- - ----- Method: MessageSetTest>>testSelectedClassOrMetaClass (in category 'testing') ----- testSelectedClassOrMetaClass | firstClass | firstClass := browser messageList first actualClass. browser messageListIndex: 1. self assert: browser selectedClassOrMetaClass = firstClass. browser messageListIndex: 0. self assert: browser selectedClassOrMetaClass isNil. "And just to be sure:" browser messageListIndex: 1. self assert: browser selectedClassOrMetaClass = firstClass.! Item was changed: + ----- Method: MessageSetTest>>testSelectedMessageCategoryName (in category 'tests') ----- - ----- Method: MessageSetTest>>testSelectedMessageCategoryName (in category 'testing') ----- testSelectedMessageCategoryName | firstCat methodRef | methodRef := browser messageList first. firstCat := methodRef actualClass organization categoryOfElement: methodRef selector. browser messageListIndex: 1. self assert: browser selectedMessageCategoryName = firstCat. browser messageListIndex: 0. self assert: browser selectedMessageCategoryName isNil. "And just to be sure:" browser messageListIndex: 1. self assert: browser selectedMessageCategoryName = firstCat.! Item was changed: + ----- Method: MessageSetTest>>testSelectedMessageName (in category 'tests') ----- - ----- Method: MessageSetTest>>testSelectedMessageName (in category 'testing') ----- testSelectedMessageName | firstSel | firstSel := browser messageList first selector. browser messageListIndex: 1. self assert: browser selectedMessageName = firstSel. browser messageListIndex: 0. self assert: browser selectedMessageName isNil. "And just to be sure:" browser messageListIndex: 1. self assert: browser selectedMessageName = firstSel.! Item was changed: + ----- Method: MessageSetTest>>testSelection (in category 'tests') ----- - ----- Method: MessageSetTest>>testSelection (in category 'testing') ----- testSelection | firstRef | firstRef := browser messageList first. browser messageListIndex: 1. self assert: browser selection = firstRef. browser messageListIndex: 0. self assert: browser selection isNil. "And just to be sure:" browser messageListIndex: 1. self assert: browser selection = firstRef.! Item was changed: + ----- Method: MessageTraceTest>>setUp (in category 'running') ----- - ----- Method: MessageTraceTest>>setUp (in category 'as yet unclassified') ----- setUp browser := (MessageTrace openMessageList: (SystemNavigation default allImplementorsOf: #browseAllImplementorsOf:) name: 'Test MessageSet' autoSelect: nil) model. browser addDependent: self.! Item was changed: + ----- Method: MessageTraceTest>>testRemoveMessageFromBrowser (in category 'tests') ----- - ----- Method: MessageTraceTest>>testRemoveMessageFromBrowser (in category 'as yet unclassified') ----- testRemoveMessageFromBrowser | count sel | browser messageListIndex: 1. sel := browser selection. browser removeMessageFromBrowser. self deny: (browser messageList includes: sel) description: 'Method not removed'. "In a MessageTrace, having an unselected message and then removing it means 'remove the first message'." browser messageListIndex: 0. count := browser messageList size. browser removeMessageFromBrowser. self assert: count - 1 = browser messageList size description: 'Method not removed'.! Item was changed: + ----- Method: OrderedCollectionInspectorTest>>testUninitialized (in category 'tests') ----- - ----- Method: OrderedCollectionInspectorTest>>testUninitialized (in category 'as yet unclassified') ----- testUninitialized "Single stepping through a debugger can observe the object state after creation but before initiialisation." "Thus 'object size' may throw an axception for trying to do arithmetic on nil." "Modified OrderedCollectionInspector>>fieldList to call 'self objectSize' to handle this exception." "Original error reproduction: [ self halt. OrderedCollectionInspector openOn: (OrderedCollection new: 5) ] " "This should not throw an exception." (OrderedCollectionInspector openOn: OrderedCollection basicNew) delete.! Item was changed: + ----- Method: PackagePaneBrowserTest>>setUp (in category 'running') ----- - ----- Method: PackagePaneBrowserTest>>setUp (in category 'as yet unclassified') ----- setUp browser := PackagePaneBrowser new.! Item was changed: + ----- Method: PackagePaneBrowserTest>>testClassList (in category 'tests') ----- - ----- Method: PackagePaneBrowserTest>>testClassList (in category 'as yet unclassified') ----- testClassList browser selectSystemCategory: browser class category. self assert: browser classList = (SystemOrganization listAtCategoryNamed: browser class category). browser selectSystemCategory: nil. self assert: browser classList isEmpty.! Item was changed: + ----- Method: PackagePaneBrowserTest>>testPackageListIndex (in category 'tests') ----- - ----- Method: PackagePaneBrowserTest>>testPackageListIndex (in category 'as yet unclassified') ----- testPackageListIndex browser packageListIndex: 0. self assert: browser selectedClass isNil. browser selectCategoryForClass: browser class. "Clicking the selected package unselects the selected class." browser packageListIndex: browser packageListIndex. self assert: browser selectedClass isNil.! Item was changed: + ----- Method: PackagePaneBrowserTest>>testSelectCategoryForClass (in category 'tests') ----- - ----- Method: PackagePaneBrowserTest>>testSelectCategoryForClass (in category 'as yet unclassified') ----- testSelectCategoryForClass | pkgName | pkgName := browser class category copyUpTo: $-. browser selectCategoryForClass: browser class. self assert: browser selectedSystemCategory = browser class category. self assert: browser packageListIndex = (browser packageList indexOf: pkgName). browser selectSystemCategory: nil. self assert: browser classList isEmpty.! Item was changed: + ----- Method: WeakSetInspectorTest>>testSymbolTableM6812 (in category 'tests') ----- - ----- Method: WeakSetInspectorTest>>testSymbolTableM6812 (in category 'testing') ----- testSymbolTableM6812 "this test is related to http://bugs.squeak.org/view.php?id=6812" | aWeakSet anInspector fieldSize | aWeakSet := (Symbol classPool at: #SymbolTable). anInspector := aWeakSet inspectorClass inspect: aWeakSet. fieldSize := anInspector fieldList size. Smalltalk garbageCollect. self assert: fieldSize = anInspector fieldList size. !

2 1

The Trunk: ShoutCore-eem.62.mcz
by commits＠source.squeak.org 01 Dec '18

01 Dec '18

Eliot Miranda uploaded a new version of ShoutCore to project The Trunk: http://source.squeak.org/trunk/ShoutCore-eem.62.mcz ==================== Summary ==================== Name: ShoutCore-eem.62 Author: eem Time: 29 November 2018, 2:00:34.775887 pm UUID: 45629ac9-52a5-412c-9bf1-493a0ac2ea36 Ancestors: ShoutCore-tpr.61 Fix a bug in SHMCClassDefinition>>sharedPools that answered nil as the pool for a missing pool, and hence broke khighlighting in the Monticello package browser when browsing older version s with different pool dictionary definitions. =============== Diff against ShoutCore-tpr.61 =============== Item was changed: ----- Method: SHMCClassDefinition>>sharedPools (in category 'act like a class') ----- sharedPools | d | d := Set new. + classDefinition poolDictionaries do: + [:poolName| + (Smalltalk at: poolName asSymbol ifAbsent:[nil]) ifNotNil: [:pool| d add: pool]]. - classDefinition poolDictionaries do:[:each | - d add: (Smalltalk at: each asSymbol ifAbsent:[nil]) ]. ^d!

4 3

sends of #class and #== considered harmful, may we please stop?
by Chris Muller 01 Dec '18

01 Dec '18

Hi guys, Something I've been wanting to ask the community for years, but never had the gumption, was about changing how we write our #= and #hash methods, but now that we're combing through them anyway, I must! Basically, it comes down to Proxy's. I want them to work better in Squeak. But every time we put another send to #class or #== in an implementation of #=, since those methods are inlined, they're too brittle to work with Proxy's. This causes hard-to-trackdown bugs in applications and mini-messes to deal with them since the app is forced to change its code to become "aware" of potential Proxy'iness of an object before comparing it with #=. This is no surprise, since writing a send to #== instead of #= for no more than "performance" is actually breaking encapsulation in the first place... There is an easy solution. When writing #= and #hash implementations, use (#species or #xxxClass or #isKindOf: instead of #class) and #= instead #==. So, for example, Eliot, I want to upgrade your new Message>>#= to something like: = anObject ^self xxxClass = anObject xxxClass and: [selector = anObject selector "selector lookup is by identity" and: [lookupClass = anObject lookupClass and: [args literalEqual: anObject arguments]]] Or #species or #isKindOf:, like we do in many other methods. Now the method is Proxy-compatible. What do you think?

6 13

The Trunk: ToolsTests-pre.87.mcz
by commits＠source.squeak.org 01 Dec '18

01 Dec '18

Patrick Rein uploaded a new version of ToolsTests to project The Trunk: http://source.squeak.org/trunk/ToolsTests-pre.87.mcz ==================== Summary ==================== Name: ToolsTests-pre.87 Author: pre Time: 1 December 2018, 5:23:30.302597 pm UUID: 6799f95b-3e35-6246-9529-e67e1f2cd433 Ancestors: ToolsTests-pre.86 Refactors the FileContentsBrowserTest to not copy the browser creation and adds a test case for browsing change sets which does not yet show the problematic behavior. =============== Diff against ToolsTests-pre.86 =============== Item was changed: + ----- Method: FileContentsBrowserTest>>expectedFailures (in category 'failures') ----- - ----- Method: FileContentsBrowserTest>>expectedFailures (in category 'as yet unclassified') ----- expectedFailures ^ #(testChangeMessageCategoriesLeavesClassSelected) "See Mantis #7615"! Item was changed: + ----- Method: FileContentsBrowserTest>>setUp (in category 'running') ----- - ----- Method: FileContentsBrowserTest>>setUp (in category 'as yet unclassified') ----- setUp + | fileout testCat | - | fileout testCat package packageDict organizer | testCat := self class category. fileout := WriteStream on: (String new: 10000). SystemOrganization fileOutCategory: testCat on: fileout. + browser := FileContentsBrowser createBrowserForStream: fileout readStream named: testCat.! - - packageDict := Dictionary new. - browser := FileContentsBrowser new. - organizer := SystemOrganizer defaultList: Array new. - package := (FilePackage new fullName: testCat; fileInFrom: fileout readStream). - packageDict - at: package packageName - put: package. - organizer - classifyAll: package classes keys - under: package packageName. - (browser := FileContentsBrowser systemOrganizer: organizer) - packages: packageDict.! Item was added: + ----- Method: FileContentsBrowserTest>>testBrowsingAChangesetShowsMethods (in category 'tests') ----- + testBrowsingAChangesetShowsMethods + + | newChangeSet fileContents internalStream | + newChangeSet := ChangeSet basicNewNamed: 'fooTestSet' , (Random new nextLargeInt: 10000) asString. + self class compileSilently: 'theTestMethod ^ false'. + newChangeSet adoptSelector: #theTestMethod forClass: self class. + + internalStream := WriteStream on: (String new: 10000). + newChangeSet fileOutOn: internalStream. + fileContents := internalStream contents. + self class removeSelector: #theTestMethod. + + browser := FileContentsBrowser createBrowserForStream: (MultiByteBinaryOrTextStream with: fileContents) named: 'testFoo'. + + browser selectSystemCategory: browser systemCategoryList first. + browser selectClassNamed: browser classList first. + + self assert: browser messageList size = 1.! Item was changed: + ----- Method: FileContentsBrowserTest>>testChangeMessageCategoriesLeavesClassSelected (in category 'tests') ----- - ----- Method: FileContentsBrowserTest>>testChangeMessageCategoriesLeavesClassSelected (in category 'as yet unclassified') ----- testChangeMessageCategoriesLeavesClassSelected browser selectSystemCategory: browser systemCategoryList first. browser selectClassNamed: browser classList first. "This is a no-op." browser changeMessageCategories: browser classOrMetaClassOrganizer printString. self assert: browser selectedClassName = browser class name.!

1 0

The Trunk: Tools-pre.834.mcz
by commits＠source.squeak.org 01 Dec '18

01 Dec '18

Patrick Rein uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-pre.834.mcz ==================== Summary ==================== Name: Tools-pre.834 Author: pre Time: 1 December 2018, 5:17:57.588597 pm UUID: 39cd80ab-f62a-df4d-a3c7-20a859de9005 Ancestors: Tools-eem.833 A minor refactoring of FileContentsBrowser instance creation methods in preparation of a testing and debugging of missing methods when browsing change set files. =============== Diff against Tools-eem.833 =============== Item was changed: ----- Method: FileContentsBrowser class>>browseFiles: (in category 'instance creation') ----- browseFiles: fileList "Open a browser on the packages found within the files in the list; we expect the list to contain acceptable filename strings. If there is more than one package found the browser will be a full system browser, otherwise it will be a category browser" + | browser organizerAndPackageDict | + Cursor wait showWhile: [ + organizerAndPackageDict := self buildOrganizerWithPackagesFrom: fileList withEach: [:fileName | + FilePackage fromFileNamed: fileName]. + (browser := self systemOrganizer: organizerAndPackageDict first) + packages: organizerAndPackageDict second]. - | browser | - Cursor wait showWhile: [ | organizer packageDict | - packageDict := Dictionary new. - organizer := SystemOrganizer defaultList: Array new. - fileList do: [:fileName | | package | - package := FilePackage fromFileNamed: fileName. - packageDict - at: package packageName - put: package. - organizer - classifyAll: package classes keys - under: package packageName]. - (browser := self systemOrganizer: organizer) - packages: packageDict]. ^ browser buildAndOpenBrowser ! Item was changed: ----- Method: FileContentsBrowser class>>browseStream: (in category 'instance creation') ----- browseStream: aStream aStream setConverterForCode. + ^ self browseStream: aStream named: aStream name! - self browseStream: aStream named: aStream name! Item was changed: ----- Method: FileContentsBrowser class>>browseStream:named: (in category 'instance creation') ----- browseStream: aStream named: aString "Read an already opened file stream into a browser" + ^ (self createBrowserForStream: aStream named: aString) buildAndOpenBrowser + ! - | browser | - Cursor wait showWhile: [ | package packageDict organizer | - packageDict := Dictionary new. - browser := self new. - organizer := SystemOrganizer defaultList: Array new. - package := (FilePackage new fullName: aString; fileInFrom: aStream). - packageDict - at: package packageName - put: package. - organizer - classifyAll: package classes keys - under: package packageName. - (browser := self systemOrganizer: organizer) - packages: packageDict]. - ^ browser buildAndOpenBrowser - ! Item was added: + ----- Method: FileContentsBrowser class>>buildOrganizerWithPackagesFrom:withEach: (in category 'private') ----- + buildOrganizerWithPackagesFrom: collectionOfPackageSources withEach: filePackageCreation + + | organizer packageDict | + packageDict := Dictionary new. + organizer := SystemOrganizer defaultList: Array new. + + collectionOfPackageSources do: [:src | | package | + package := filePackageCreation value: src. + packageDict + at: package packageName + put: package. + organizer + classifyAll: package classes keys + under: package packageName]. + + ^ {organizer . packageDict}! Item was added: + ----- Method: FileContentsBrowser class>>createBrowserForStream:named: (in category 'private') ----- + createBrowserForStream: aStream named: aString + + | browser organizerAndPackageDict | + Cursor wait showWhile: [ + browser := self new. + organizerAndPackageDict := self buildOrganizerWithPackagesFrom: {aStream} withEach: [:stream | + (FilePackage new fullName: aString; fileInFrom: aStream)]. + (browser := self systemOrganizer: organizerAndPackageDict first) + packages: organizerAndPackageDict second]. + ^ browser!

1 0