Squeak-dev September 2016

squeak-dev@lists.squeakfoundation.org

46 participants
175 discussions

The Trunk: EToys-tfel.255.mcz
by commits＠source.squeak.org 27 Sep '16

27 Sep '16

Tim Felgentreff uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-tfel.255.mcz ==================== Summary ==================== Name: EToys-tfel.255 Author: tfel Time: 27 September 2016, 3:44:53.921268 pm UUID: 76eaa9ec-bd5b-7c48-b15a-fff14d6af1ee Ancestors: EToys-tfel.254 pretend uniclasses have an environment, to make the compilation paths work =============== Diff against EToys-tfel.254 =============== Item was removed: - ----- Method: Player class>>category (in category 'organization') ----- - category - - ^ super category ifNil: [self categoryForUniclasses]! Item was added: + ----- Method: Player class>>environment (in category 'organization') ----- + environment + + ^ self isUniClass + ifTrue: [(Environment withName: 'EtoysUserDefinedTempEnvironment') + at: self name put: self; + yourself] + ifFalse: [super environment]!

1 0

The Trunk: Kernel-tfel.1041.mcz
by commits＠source.squeak.org 27 Sep '16

27 Sep '16

Tim Felgentreff uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-tfel.1041.mcz ==================== Summary ==================== Name: Kernel-tfel.1041 Author: tfel Time: 27 September 2016, 3:41:40.508268 pm UUID: 31da1f70-2af0-e74e-b46c-74f1c7b615b7 Ancestors: Kernel-tfel.1040 uniclasses might not have a category =============== Diff against Kernel-tfel.1040 =============== Item was changed: ----- Method: ClassBuilder>>name:inEnvironment:subclassOf:type:instanceVariableNames:classVariableNames:poolDictionaries:category:unsafe: (in category 'class definition') ----- name: className inEnvironment: env subclassOf: newSuper type: type instanceVariableNames: instVarString classVariableNames: classVarString poolDictionaries: poolString category: category unsafe: unsafe "Define a new class in the given environment. If unsafe is true do not run any validation checks. This facility is provided to implement important system changes." | oldClass instVars classVars copyOfOldClass newClass | environ := env. instVars := Scanner new scanFieldNames: instVarString. classVars := (Scanner new scanFieldNames: classVarString) collect: [:x | x asSymbol]. "Validate the proposed name" unsafe ifFalse:[(self validateClassName: className) ifFalse:[^nil]]. oldClass := env at: className ifAbsent:[nil]. oldClass isBehavior ifFalse: [oldClass := nil] "Already checked in #validateClassName:" ifTrue: [ copyOfOldClass := oldClass copy. copyOfOldClass superclass addSubclass: copyOfOldClass]. [ | newCategory needNew force organization oldCategory | unsafe ifFalse:[ "Run validation checks so we know that we have a good chance for recompilation" (self validateSuperclass: newSuper forSubclass: oldClass) ifFalse:[^nil]. (self validateInstvars: instVars from: oldClass forSuper: newSuper) ifFalse:[^nil]. (self validateClassvars: classVars from: oldClass forSuper: newSuper) ifFalse:[^nil]. (self validateSubclassFormat: type from: oldClass forSuper: newSuper extra: instVars size) ifFalse:[^nil]]. "See if we need a new subclass" needNew := self needsSubclassOf: newSuper type: type instanceVariables: instVars from: oldClass. needNew == nil ifTrue:[^nil]. "some error" (needNew and:[unsafe not]) ifTrue:[ "Make sure we don't redefine any dangerous classes" (self tooDangerousClasses includes: oldClass name) ifTrue:[ self error: oldClass name, ' cannot be changed'. ]. "Check if the receiver should not be redefined" (oldClass ~~ nil and:[oldClass shouldNotBeRedefined]) ifTrue:[ self notify: oldClass name asText allBold, ' should not be redefined. \Proceed to store over it.' withCRs]]. needNew ifTrue:[ "Create the new class" newClass := self newSubclassOf: newSuper type: type instanceVariables: instVars from: oldClass. newClass == nil ifTrue:[^nil]. "Some error" newClass setName: className. newClass environment: environ. ] ifFalse:[ "Reuse the old class" newClass := oldClass. ]. "Install the class variables and pool dictionaries... " force := (newClass declare: classVarString) | (newClass sharing: poolString). "... classify ..." + category ifNotNil: [ + newCategory := category asSymbol. + organization := environ ifNotNil:[environ organization]. + oldClass isNil ifFalse: [oldCategory := (organization categoryOfElement: oldClass name) asSymbol]. + organization classify: newClass name under: newCategory suppressIfDefault: true]. + - newCategory := category asSymbol. - organization := environ ifNotNil:[environ organization]. - oldClass isNil ifFalse: [oldCategory := (organization categoryOfElement: oldClass name) asSymbol]. - organization classify: newClass name under: newCategory suppressIfDefault: true. - "... recompile ..." newClass := self recompile: force from: oldClass to: newClass mutate: false. "... export if not yet done ..." (environ at: newClass name ifAbsent:[nil]) == newClass ifFalse:[ [environ at: newClass name put: newClass] on: AttemptToWriteReadOnlyGlobal do:[:ex| ex resume: true]. environ flushClassNameCache. ]. newClass doneCompiling. "... notify interested clients ..." oldClass isNil ifTrue: [ SystemChangeNotifier uniqueInstance classAdded: newClass inCategory: newCategory. ^ newClass]. newCategory ~= oldCategory ifTrue: [SystemChangeNotifier uniqueInstance class: newClass recategorizedFrom: oldCategory to: category] ifFalse: [SystemChangeNotifier uniqueInstance classDefinitionChangedFrom: copyOfOldClass to: newClass.]. ] ensure: [copyOfOldClass ifNotNil: [copyOfOldClass superclass removeSubclass: copyOfOldClass]. Behavior flushObsoleteSubclasses. ]. ^newClass!

1 0

The Trunk: Kernel-tfel.1040.mcz
by commits＠source.squeak.org 27 Sep '16

27 Sep '16

Tim Felgentreff uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-tfel.1040.mcz ==================== Summary ==================== Name: Kernel-tfel.1040 Author: tfel Time: 27 September 2016, 2:57:29.665629 pm UUID: e6781812-fc7b-a546-818b-0b16c5d62e88 Ancestors: Kernel-tfel.1039 refactor newSubclass to go through the more general newUniqueClassInstVars:classInstVars: method. =============== Diff against Kernel-tfel.1039 =============== Item was changed: ----- Method: Class>>newSubclass (in category 'subclass creation') ----- newSubclass - | i className | - i := 1. - [className := (self name , i printString) asSymbol. - self environment includesKey: className] - whileTrue: [i := i + 1]. + ^ self newUniqueClassInstVars: '' classInstVars: '' - ^ self subclass: className - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: Object categoryForUniclasses "Point newSubclass new"! Item was changed: ----- Method: Object class>>newUniqueClassInstVars:classInstVars: (in category 'instance creation') ----- newUniqueClassInstVars: instVarString classInstVars: classInstVarString "Create a unique class for the receiver" | aName aClass | self isSystemDefined ifFalse: [^ superclass newUniqueClassInstVars: instVarString classInstVars: classInstVarString]. aName := self chooseUniqueClassName. aClass := self subclass: aName instanceVariableNames: instVarString classVariableNames: '' poolDictionaries: '' category: self categoryForUniclasses. + classInstVarString size > 0 ifTrue: + [aClass class instanceVariableNames: classInstVarString]. self flag: #todo. self flag: #uniclasses. "Discuss if we really want to hide uniclasses again" aClass environment forgetClass: aClass logged: false. self removeSubclass: aClass. - classInstVarString size > 0 ifTrue: - [aClass class instanceVariableNames: classInstVarString]. ^ aClass!

1 0

The Trunk: MorphicExtras-tfel.199.mcz
by commits＠source.squeak.org 27 Sep '16

27 Sep '16

Tim Felgentreff uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-tfel.199.mcz ==================== Summary ==================== Name: MorphicExtras-tfel.199 Author: tfel Time: 27 September 2016, 2:55:01.185629 pm UUID: 654861ec-a93d-7b42-b2bc-f57bdbc9647f Ancestors: MorphicExtras-tfel.198 Force re-drawing of the main hand after the EventRecorder finishes =============== Diff against MorphicExtras-tfel.198 =============== Item was changed: ----- Method: EventRecorderMorph>>pauseIn: (in category 'pause/resume') ----- pauseIn: aWorld "Suspend playing or recording, either as part of a stop command, or as part of a project switch, after which it will be resumed." self setStatusLight: #ready. state = #play ifTrue: [state := #suspendedPlay. playHand halo ifNotNil: [playHand halo delete]. playHand delete. aWorld removeHand: playHand. + aWorld firstHand showHardwareCursor: true. playHand := nil]. state = #record ifTrue: [state := #suspendedRecord. recHand removeEventListener: self. recHand := nil]. voiceRecorder ifNotNil: [voiceRecorder pause. startSoundEvent ifNotNil: [startSoundEvent argument: voiceRecorder recordedSound. voiceRecorder clearRecordedSound. startSoundEvent := nil]]. !

1 0

The Trunk: System-tfel.917.mcz
by commits＠source.squeak.org 27 Sep '16

27 Sep '16

Tim Felgentreff uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-tfel.917.mcz ==================== Summary ==================== Name: System-tfel.917 Author: tfel Time: 27 September 2016, 2:52:54.264629 pm UUID: 6436c2ff-4a02-d845-9b8e-45b8130a609c Ancestors: System-bf.916 when trying to load a project from my local server when that is not set, at least try to fall back to the default directory =============== Diff against System-bf.916 =============== Item was changed: ----- Method: Project>>fromMyServerLoad: (in category 'file in/out') ----- fromMyServerLoad: otherProjectName | pair pr dirToUse | "If a newer version of me is on the server, load it." (pr := Project named: otherProjectName) ifNotNil: ["it appeared" ^ pr enter ]. + dirToUse := self primaryServerIfNil: [ + lastDirectory + ifNil: [FileDirectory default] + ifNotNil: [lastDirectory]]. - lastDirectory ifNil: [ - self inform: 'Current project does not know a server either.'. - ^nil]. - lastDirectory]. pair := self class mostRecent: otherProjectName onServer: dirToUse. pair first ifNil: [^self decideAboutCreatingBlank: otherProjectName]. "nothing to load" ^ProjectLoading installRemoteNamed: pair first from: dirToUse named: otherProjectName in: self !

1 0

Daily Commit Log
by commits＠source.squeak.org 26 Sep '16

26 Sep '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-September/068963.… Name: EToys-tfel.252 Ancestors: EToys-tfel.251 fix a potential bug when the info dictionary for kedama turtle vector players was restored from siss ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-September/068964.… Name: EToys-tfel.253 Ancestors: EToys-tfel.252 delete the project saving morph before saving ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-September/068965.… Name: EToys-tfel.254 Ancestors: EToys-tfel.253 fix the mouse over highlights for tiles in the viewer =============================================

1 0

Re: [Pharo-dev] [Vm-dev] Re: Nuking VM ImageSegment support (was Re: [squeak-dev] Daily Commit Log; System-bf.916)
by Max Leske 26 Sep '16

26 Sep '16

Hi Bert, No, we use ImageSegment directly (we’ve subclassed ImageSegment). Here’s the short version: 1. we copy the roots: self copyFromRoots: (Array with: anObject) sizeHint: self fileSize // 2 areUnique: true. 2. we write the segment onto a MutliByteFileStream (which we’ve subclassed): NSSegmentStream forceNewFileNamed: fileName do: [ :stream | stream writeObject: self ]. where #writeObject: is implemented as: writeObject: anObject (SmartRefStream on: self) nextPutObjOnly: anObject We load the segment back by: 1. opening a MultiByteFileStream and sending the installation message: NSSegmentStream readOnlyFileNamed: (aDirectory fullNameFor: filename) do: [ :stream | self installSegmentFrom: stream andDo: aBlock ] 2. #installSegmentFrom:andDo: basically sends #readObject to the file stream: readObject "This is a hack to allow for the old segments (mixed code and objects) to be loaded without the #inform: in #nextAndClose opening a UI element." ^ self binary peek = ReferenceStream versionCode ifTrue: [ (SmartRefStream on: self) nextAndClose ] ifFalse: [ | object | self ascii; fileIn. object := SmartRefStream scannedObject. SmartRefStream scannedObject: nil. object ] 3. and once we have the segment we send #install to it We’ve made some modifications here and there (e.g. to suppress UI elements) but the above is the gist of it. I can give you the full source if you need it. It’s possible that this is all overkill or parallels functionality found in other places. I’ve inherited the code and haven’t spent the time exploring improvements in that area. Cheers, Max > On 26 Sep 2016, at 19:39, squeak-dev-request(a)lists.squeakfoundation.org wrote: > > Hi Max, > > I'd be interested to learn how you are using ImageSegments. Is it > using CodeLoader? > > - Bert -

1 0

Re: [squeak-dev] The Trunk: EToys-tfel.253.mcz
by Kjell Godo 26 Sep '16

26 Sep '16

M>>doesNotUnderstand: aMessage ^aMessage asMessageSend ! ( M handUserSorterMorphForProjectNamed: nil )"<---[ easy way to make a MessageSend ]" ... sendTo: obj On Monday, September 26, 2016, <commits(a)source.squeak.org> wrote: > Tim Felgentreff uploaded a new version of EToys to project The Trunk: > http://source.squeak.org/trunk/EToys-tfel.253.mcz > > ==================== Summary ==================== > > Name: EToys-tfel.253 > Author: tfel > Time: 26 September 2016, 11:40:48.856552 am > UUID: a00694aa-7017-b444-a8d0-6671ec171efd > Ancestors: EToys-tfel.252 > > delete the project saving morph before saving > > =============== Diff against EToys-tfel.252 =============== > > Item was changed: > ----- Method: EToyProjectDetailsMorph>>doOK (in category 'utilities') > ----- > doOK > "User hit the ok button in the project-info dialog. Store the > updated project-info back in the project. Call the message-send residing in > the receiver's actionBlock to carry out any subsequent desired task. Note > that this method sets the 'arguments' of the message-send in the > actionBlock" > > | args actionSelector | > self validateTheProjectName ifFalse: [^false]. > projectDetails := self copyOutDetails. > > theProject acceptProjectDetails: projectDetails. "Make sure > project & world feel the changes" > + > + self delete. > - > actionBlock isMessageSend "new way -- hopefully all cases" > ifTrue: "please excuse this ugly, non-modular code..." > [actionSelector := actionBlock selector. > args := (actionSelector = # > handUserSorterMorphForProjectNamed:) > ifTrue: > [{theProject name}] > ifFalse: > [actionSelector numArgs = 0 > ifTrue: > [nil] > ifFalse: > [Array with: > projectDetails]]. > actionBlock arguments: args. > actionBlock value] > > ifFalse: "Old way, with actionBlock actually a block of > one argument. This should no longer occur." > + [actionBlock value: projectDetails].! > - [actionBlock value: projectDetails]. > - > - self delete! > > Item was changed: > ----- Method: EToyProjectQueryMorph>>doOK (in category 'ok button hit') > ----- > doOK > "User hit the ok button in the project-query dialog." > > | details | > details := self copyOutDetails. > > + self delete. > actionBlock isMessageSend "new way -- hopefully all cases" > ifTrue: > [actionBlock arguments: {details. actionBlock > arguments second}. > actionBlock value] > > ifFalse: "Old way, with actionBlock actually a block of > one argument. This should no longer occur." > + [actionBlock value: details].! > - [actionBlock value: details]. > - > - self delete! > > >

1 4

The Trunk: EToys-tfel.254.mcz
by commits＠source.squeak.org 26 Sep '16

26 Sep '16

Tim Felgentreff uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-tfel.254.mcz ==================== Summary ==================== Name: EToys-tfel.254 Author: tfel Time: 26 September 2016, 3:08:19.655594 pm UUID: d6ca728e-ca89-5043-a50c-d8a505760da6 Ancestors: EToys-tfel.253 fix the mouse over highlights for tiles in the viewer =============== Diff against EToys-tfel.253 =============== Item was added: + ----- Method: PhraseTileMorph>>handlesMouseOver: (in category 'event handling') ----- + handlesMouseOver: evt + + ^ true + ! Item was added: + ----- Method: PhraseTileMorph>>mouseEnter: (in category 'event handling') ----- + mouseEnter: evt + + self removeHighlightFeedback. + self addCommandFeedback: evt. + ! Item was added: + ----- Method: PhraseTileMorph>>mouseLeave: (in category 'event handling') ----- + mouseLeave: evt + "Resume drop-tracking in enclosing editor" + | ed | + self removeHighlightFeedback. + (ed := self enclosingTestTile) ifNotNil: [ed mouseEnter: evt].! Item was changed: ----- Method: ViewerLine>>addGetterFeedback (in category 'slot') ----- addGetterFeedback "Add feedback during mouseover of a getter" + | aMorph | + aMorph := RectangleMorph new + bounds: (self firstTileMorph topLeft corner: + (self firstAlignmentMorph ifNil: [self submorphs last bottomRight] ifNotNil: [:m | m bottomLeft])). - | aMorph endMorph | - - endMorph _ - (#(touchesA: #seesColor: #overlaps: color:sees: overlapsAny: bearingTo: bearingFrom: distanceToPlayer:) includes: self elementSymbol) - ifTrue: - [submorphs seventh] - ifFalse: - [submorphs fifth]. - aMorph := RectangleMorph new bounds: ((submorphs third topLeft - (2@1)) corner: ((endMorph right @ submorphs third bottom) + (2@1))). aMorph beTransparent; borderWidth: 2; borderColor: ScriptingSystem getterFeedback; lock. ActiveWorld addHighlightMorph: aMorph for: nil. " Color fromUser (Color r: 1.0 g: 0.355 b: 0.839) "! Item was changed: ----- Method: ViewerLine>>addSetterFeedback (in category 'slot') ----- addSetterFeedback "Add screen feedback showing what would be torn off to make a setter" | aMorph | + aMorph := RectangleMorph new bounds: (self firstTileMorph topLeft corner: self bounds bottomRight). - aMorph := RectangleMorph new bounds: ((submorphs third topLeft - (2@1)) corner: ((submorphs last right @ submorphs third bottom) + (2@1))). aMorph beTransparent; borderWidth: 2; borderColor: ScriptingSystem setterFeedback; lock. ActiveWorld addHighlightMorph: aMorph for: nil! Item was added: + ----- Method: ViewerLine>>firstAlignmentMorph (in category 'slot') ----- + firstAlignmentMorph + + ^ self submorphs reverse detect: [:m | m isAlignmentMorph] ifNone: []! Item was added: + ----- Method: ViewerLine>>firstTileMorph (in category 'slot') ----- + firstTileMorph + + ^ self submorphs detect: [:m | m isTileMorph]!

1 0

The Trunk: EToys-tfel.253.mcz
by commits＠source.squeak.org 26 Sep '16

26 Sep '16

Tim Felgentreff uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-tfel.253.mcz ==================== Summary ==================== Name: EToys-tfel.253 Author: tfel Time: 26 September 2016, 11:40:48.856552 am UUID: a00694aa-7017-b444-a8d0-6671ec171efd Ancestors: EToys-tfel.252 delete the project saving morph before saving =============== Diff against EToys-tfel.252 =============== Item was changed: ----- Method: EToyProjectDetailsMorph>>doOK (in category 'utilities') ----- doOK "User hit the ok button in the project-info dialog. Store the updated project-info back in the project. Call the message-send residing in the receiver's actionBlock to carry out any subsequent desired task. Note that this method sets the 'arguments' of the message-send in the actionBlock" | args actionSelector | self validateTheProjectName ifFalse: [^false]. projectDetails := self copyOutDetails. theProject acceptProjectDetails: projectDetails. "Make sure project & world feel the changes" + + self delete. - actionBlock isMessageSend "new way -- hopefully all cases" ifTrue: "please excuse this ugly, non-modular code..." [actionSelector := actionBlock selector. args := (actionSelector = #handUserSorterMorphForProjectNamed:) ifTrue: [{theProject name}] ifFalse: [actionSelector numArgs = 0 ifTrue: [nil] ifFalse: [Array with: projectDetails]]. actionBlock arguments: args. actionBlock value] ifFalse: "Old way, with actionBlock actually a block of one argument. This should no longer occur." + [actionBlock value: projectDetails].! - [actionBlock value: projectDetails]. - - self delete! Item was changed: ----- Method: EToyProjectQueryMorph>>doOK (in category 'ok button hit') ----- doOK "User hit the ok button in the project-query dialog." | details | details := self copyOutDetails. + self delete. actionBlock isMessageSend "new way -- hopefully all cases" ifTrue: [actionBlock arguments: {details. actionBlock arguments second}. actionBlock value] ifFalse: "Old way, with actionBlock actually a block of one argument. This should no longer occur." + [actionBlock value: details].! - [actionBlock value: details]. - - self delete!

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
18
Older →

Jump to page: