Squeak-dev September 2016

squeak-dev@lists.squeakfoundation.org

46 participants
175 discussions

The Inbox: Tools-jl.725.mcz
by commits＠source.squeak.org 01 Sep '16

01 Sep '16

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jl.725.mcz ==================== Summary ==================== Name: Tools-jl.725 Author: jl Time: 1 September 2016, 3:38:08.183565 pm UUID: c1f63020-54e3-3d46-bef0-958eef4c73ae Ancestors: Tools-tfel.724 fixed project load dialog in etoys =============== Diff against Tools-tfel.724 =============== Item was changed: ----- Method: FileList2 class>>morphicViewProjectLoader2InWorld:reallyLoad:dirFilterType: (in category 'blue ui') ----- morphicViewProjectLoader2InWorld: aWorld reallyLoad: aBoolean dirFilterType: aSymbol | window aFileList buttons treePane textColor1 fileListPane pane2a pane2b treeExtent filesExtent | window := AlignmentMorphBob1 newColumn. window hResizing: #shrinkWrap; vResizing: #shrinkWrap. textColor1 := Color r: 0.742 g: 0.839 b: 1.0. + aFileList := self new. - aFileList := self new directory: FileDirectory default. aFileList optionalButtonSpecs: aFileList servicesForProjectLoader; fileSelectionBlock: ( aSymbol == #limitedSuperSwikiDirectoryList ifTrue: [ MessageSend receiver: self selector: #projectOnlySelectionMethod: ] ifFalse: [ self projectOnlySelectionBlock ] ); "dirSelectionBlock: self hideSqueakletDirectoryBlock;" modalView: window. + aFileList directory: FileDirectory default. window setProperty: #FileList toValue: aFileList; wrapCentering: #center; cellPositioning: #topCenter; borderWidth: 1; borderColor: (Color r: 0.9 g: 0.801 b: 0.2); useRoundedCorners. buttons := {{'OK'. Color lightGreen}. {'Cancel'. Color lightRed}} collect: [ :each | self blueButtonText: each first textColor: textColor1 color: each second inWindow: window ]. aWorld width < 800 ifTrue: [ treeExtent := 150@300. filesExtent := 350@300. ] ifFalse: [ + treeExtent := 350@500. + filesExtent := 550@500. - treeExtent := 250@300. - filesExtent := 350@300. ]. (treePane := aFileList morphicDirectoryTreePaneFiltered: aSymbol) extent: treeExtent; retractable: false; borderWidth: 0. fileListPane := aFileList morphicFileListPane extent: filesExtent; retractable: false; borderWidth: 0. window addARow: { window fancyText: 'Load A Project' translated font: Preferences standardEToysTitleFont color: textColor1 }; addARowCentered: { buttons first. (Morph new extent: 30@5) color: Color transparent. buttons second }; addARow: { window fancyText: 'Please select a project' translated font: Preferences standardEToysFont color: textColor1 }; addARow: { (window inAColumn: {(pane2a := window inARow: {window inAColumn: {treePane}}) useRoundedCorners; layoutInset: 0; borderWidth: 1; borderColor: (Color r: 0.6 g: 0.7 b: 1) }) layoutInset: 10. (window inAColumn: {(pane2b := window inARow: {window inAColumn: {fileListPane}}) useRoundedCorners; layoutInset: 0; borderWidth: 1; borderColor: (Color r: 0.6 g: 0.7 b: 1) }) layoutInset: 10. }. window fullBounds. window fillWithRamp: (Color r: 1 g: 0.85 b: 0.975) oriented: 0.65. pane2a fillWithRamp: (Color r: 0.85 g: 0.9 b: 1) oriented: (0.7 @ 0.35). pane2b fillWithRamp: (Color r: 0.85 g: 0.9 b: 1) oriented: (0.7 @ 0.35). " buttons do: [ :each | each fillWithRamp: ColorTheme current dialogButtonsRampOrColor oriented: (0.75 @ 0). ]. " buttons first on: #mouseUp send: (aBoolean ifTrue: [#okHitForProjectLoader] ifFalse: [#okHit]) to: aFileList. buttons second on: #mouseUp send: #cancelHit to: aFileList. aFileList postOpen. window position: aWorld topLeft + (aWorld extent - window extent // 2). window adoptPaneColor: (Color r: 0.548 g: 0.677 b: 1.0). window becomeModal. ^ window openInWorld: aWorld.!

1 0

The Inbox: EToys-jl.231.mcz
by commits＠source.squeak.org 01 Sep '16

01 Sep '16

A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-jl.231.mcz ==================== Summary ==================== Name: EToys-jl.231 Author: jl Time: 1 September 2016, 2:23:37.830565 pm UUID: 9217d357-f7a9-e04f-bab3-a98d904576ac Ancestors: EToys-jl.230 fixed test tiles in kedama for new block generation =============== Diff against EToys-jl.230 =============== Item was changed: ----- Method: KedamaTurtleVectorPlayer2>>test:ifTrue:ifFalse: (in category 'command execution') ----- test: cond ifTrue: trueBlock ifFalse: falseBlock + | origPredicate c actualCond condValue | + - | origPredicate c actualCond | (cond == true or: [cond == false]) ifTrue: [ ^ cond ifTrue: [trueBlock value: self] ifFalse: [falseBlock value: self]. ]. actualCond := cond. cond isBlock ifTrue: [ actualCond := ByteArray new: predicate size. + condValue := cond value. + condValue isCollection + ifTrue: [ + actualCond := condValue. + ] ifFalse: [ + 1 to: predicate size do: [:i | actualCond at: i put: (cond value ifTrue: [1] ifFalse: [0])] + ] - 1 to: predicate size do: [:i | actualCond at: i put: (cond value ifTrue: [1] ifFalse: [0])] ]. origPredicate := predicate clone. predicate bytesAnd: actualCond. trueBlock value: self. c := actualCond clone. c not. predicate replaceFrom: 1 to: (predicate size min: origPredicate size) with: origPredicate startingAt: 1. predicate bytesAnd: c. falseBlock value: self. predicate replaceFrom: 1 to: (predicate size min: origPredicate size) with: origPredicate startingAt: 1.! Item was changed: ----- Method: Object>>test:ifTrue:ifFalse: (in category '*Etoys-Squeakland-Tweak-Kedama') ----- test: cond ifTrue: trueBlock ifFalse: falseBlock + cond value ifTrue: [trueBlock value: self] ifFalse: [falseBlock value: self]. - cond ifTrue: [trueBlock value: self] ifFalse: [falseBlock value: self]. !

1 0

Re: Does anyone recognize this glitch in our trunk update processing? (was: [Vm-dev] buildspurtrunkvmmakerimage.sh fails on Mac)
by Chris Muller 01 Sep '16

01 Sep '16

I've definitely experienced the exact same problem, and got around it the same way, restarting the method and proceeding. Very strange. On Sun, Aug 21, 2016 at 3:13 PM, David T. Lewis <lewis(a)mail.msen.com> wrote: > > Moving from vm-dev to squeak-dev because it is a trunk update stream question. > Follow ups to squeak-dev please. > > Does anyone recognize this problem? > > We have an issue in trunk update processing that prevents a full update > without manual intervention. This does not affect the 5.1 release, but > it would be good to fix it so that the update from 5.0 to 5.1 can be > reproduced in a continuous integration test. > > To reproduce: Start with Squeak5.0-15113.image, set the update URL preference > to http://source.squeak.org/trunk, and do an "update from server". > > The error first appears when beginning to process the update-mt.378.mcm > update map. The problem is related to updating the progress bar with > ProgressInitiationException. > > When the failure occurs, the debugger (see attached image) seems to > show an array access being interpreted as if the array was an instance > of StrikeFont. Per Nicolas' note below, it may be related to showing > the progress bar while updating it. > > I can restart the update process from the debugger from > SystemProgressMorph>>position:label:min:max: in the stack frame, and the > update proceeds. The error happens several more times, then at some point > it seems to go away, so apparently the problem was fixed at some later > point in the update stream. > > Does anyone recognize this problem? Can we work around it by changing one > or more of the update maps? > > Thanks, > Dave > > > On Fri, Aug 19, 2016 at 10:30:30PM +0200, Nicolas Cellier wrote: >> >> yes, this is a problem I encountered both in 32 and 64 bits squeak while >> updating. >> >> I think it's related to showing the progress bar while updating the >> progress bar. It's a Squeak trunk update problem, not a VM problem. >> >> If some class layout change, but some block is still active (yeah, did you >> see how many blocks we traverse just to change display of a bar...), then >> the old block has invalid inst var offsets (offsets to the old object that >> now has become a new object with new layout). >> >> In an interactive image, just close the debugger and relaunch the update. >> In an headless automated process, well... We should have fixed the update >> or start from a newer artifact... >> >> 2016-08-19 21:32 GMT+02:00 tim Rowledge <tim(a)rowledge.org>: >> > >> > I just tried running the vmmaker-build script on my iMac with weirdly bad >> > results. >> > >> > The vm it downloads is the CogSpur.app-16.18.3692 version. Whilst trying >> > to do the update part of the process I had several *very* odd failures >> > where an object in a block was mistaken for nil during a message send. For >> > example in a progress bar update (which I can???t provide a log for since the >> > log got overwritten later) a line >> > (bars at: index) >> > lead to a nil is not indexable halt. Yet in inspecting the prior >> > stackframe the bars object was a perfectly normal array of progress bars. A >> > similar but not identical problem happened during another attempt. >> > >> > Attempting to filein the BuildSqueakSpurTrunkVMMaker.st file failed when >> > the vm exploded with no visible log. >> > >> > Now I???m attempting to repeat that with a new 5.1rc1 vm & already up to >> > date 5.1rc1 image. Which has sorta-worked, in a rather odd manner. It got >> > to the final save and quit but when I start the supposedly prepared image >> > there is a problem with it trying to filein that file. I can???t tell right >> > now if it relates to the manual filein I started or if something got added >> > as a deferred action? Or maybe it???s a side-effect of the filein having a >> > save & quit? Not come across this before. >> > >> > >> > >> > So far as I can tell it did complete the filein, so maybe all is well. >> > >

7 16

The Inbox: EToys-jl.230.mcz
by commits＠source.squeak.org 01 Sep '16

01 Sep '16

A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-jl.230.mcz ==================== Summary ==================== Name: EToys-jl.230 Author: jl Time: 1 September 2016, 10:59:46.740946 am UUID: 06b0aa06-1a5f-f64b-a0fa-d9b063894041 Ancestors: EToys-jl.226, EToys-nice.229 merged again =============== Diff against EToys-jl.226 =============== Item was changed: ----- Method: ChessBoard class>>initializeHashKeys (in category 'class initialization') ----- initializeHashKeys "ChessGame initialize" | random | HashKeys := Array new: 12. 1 to: HashKeys size do:[:i| HashKeys at: i put: (WordArray new: 64)]. HashLocks := Array new: 12. 1 to: HashLocks size do:[:i| HashLocks at: i put: (WordArray new: 64)]. random := Random seed: 23648646. 1 to: 12 do:[:i| 1 to: 64 do:[:j| + (HashKeys at: i) at: j put: (random nextInt: 16r3FFFFFFF "SmallInteger maxVal on 32bits VM")- 1. + (HashLocks at: i) at: j put: (random nextInt: 16r3FFFFFFF "SmallInteger maxVal on 32bits VM") - 1. - (HashKeys at: i) at: j put: (random nextInt: SmallInteger maxVal) - 1. - (HashLocks at: i) at: j put: (random nextInt: SmallInteger maxVal) - 1. ]. ]. ! Item was changed: ----- Method: KedamaExamplerPlayer>>containsSequentialSelector: (in category '*Etoys-Squeakland-private') ----- containsSequentialSelector: aSymbol + ^ (#(random random: atRandom) includes: aSymbol)! - ^ (#(random random:) includes: aSymbol)! Item was changed: ----- Method: KedamaMorph>>dimensions: (in category 'accessing') ----- dimensions: anExtent dimensions := anExtent. wrapX := dimensions x asFloat. wrapY := dimensions y asFloat. patchVarDisplayForm := Form extent: dimensions depth: 32. patchesToDisplay ifNotNil: [ patchesToDisplay do: [ :ea | ea newExtent: anExtent. ]. ]. self pixelsPerPatch: self pixelsPerPatch.! Item was changed: ----- Method: KedamaMorph>>drawTurtlesOnForm: (in category 'drawing') ----- drawTurtlesOnForm: aForm turtlesToDisplay do: [:exampler | (self isVisible: exampler) ifTrue: [ turtlesDictSemaphore critical: [ exampler turtles drawOn: aForm. + ] ifLocked: [] - ]. ]. ]. ! Item was changed: ----- Method: KedamaTurtleMethodAttributionDefinition2 class>>determineStatementType:fromDict:primaryBreedPair:messageType:isStatement:receiverObject: (in category 'rules') ----- determineStatementType: parentStmtType fromDict: dict primaryBreedPair: myPrimaryBreedPair messageType: myMessageType isStatement: myIsStatement receiverObject: myReceiverObject | vectorTurtle turtleSelectors participants reads writes unknownReceiverSelectors | "Do the calculation only at the statement level." myIsStatement ifFalse: [^ parentStmtType]. "If there is a doSequentially: block, the block is sequential." participants := dict at: self. (participants select: [:e | (e first notNil and: [e first isPrototypeTurtlePlayer])]) size = 0 ifTrue: [^ #none]. myMessageType = #sequential ifTrue: [^ #sequential]. parentStmtType = #sequential ifTrue: [^ #sequential]. "If there is not turtle involved in the statement, it is not transformed." myPrimaryBreedPair ifNil: [^ #none]. vectorTurtle := myPrimaryBreedPair first. myMessageType = #condition ifTrue: [ reads := IdentitySet new. writes := IdentitySet new. participants do: [:list | (((list at: 5) = #testBody or: [(list at: 5) = #testCond]) and: [(list at: 4) ~= #read]) ifTrue: [list first ifNotNil: [writes add: list first]]. (((list at: 5) = #testBody or: [(list at: 5) = #testCond]) and: [(list at: 4) = #read]) ifTrue: [list first ifNotNil: [reads add: list first]]. ]. ((writes intersection: reads) copyWithout: vectorTurtle) ifNotEmpty: [ ^ #sequential ]. ^ #parallel. ]. reads := IdentitySet new. writes := IdentitySet new. turtleSelectors := OrderedCollection new. unknownReceiverSelectors := OrderedCollection new. participants do: [:list | list first = vectorTurtle ifTrue: [ ((vectorTurtle isBreedSelector: list second) or: [ (vectorTurtle isUserDefinedSelector: list second)]) ifFalse: [ turtleSelectors add: list second ]. ]. list first ifNil: [unknownReceiverSelectors add: list second] ifNotNil: [ ((list at: 4) == #read) ifTrue: [reads add: list first]. ((list at: 4) == #read) ifFalse: [writes add: list first]. ]. (vectorTurtle containsSequentialSelector: list second) ifTrue: [^ #sequential]. ]. (turtleSelectors includes: #die) ifTrue: [^ #die]. (((self isKindOf: AssignmentNode) and: [myReceiverObject = vectorTurtle]) and: [vectorTurtle isBreedSelector: self property property]) ifTrue: [^ #none]. (vectorTurtle areOkaySelectors: unknownReceiverSelectors) ifFalse: [ ^ #sequential. ]. (vectorTurtle vectorizableTheseSelectors: turtleSelectors) ifFalse: [^ #sequential]. ((reads intersection: writes) copyWithout: vectorTurtle) ifNotEmpty: [^ #sequential]. + + "Check the hard way. If any leaf nodes" + self nodesDo: [:node | + (node isMessageNode and: [vectorTurtle containsSequentialSelector: node selector]) + ifTrue: [^ #sequential]]. + ^ #parallel. ! Item was changed: ----- Method: KedamaTurtleVectorPlayer2>>test:ifTrue:ifFalse: (in category 'command execution') ----- test: cond ifTrue: trueBlock ifFalse: falseBlock + | origPredicate c actualCond | - | origPredicate c | (cond == true or: [cond == false]) ifTrue: [ ^ cond ifTrue: [trueBlock value: self] ifFalse: [falseBlock value: self]. ]. + actualCond := cond. + cond isBlock ifTrue: [ + actualCond := ByteArray new: predicate size. + 1 to: predicate size do: [:i | actualCond at: i put: (cond value ifTrue: [1] ifFalse: [0])] + ]. origPredicate := predicate clone. + predicate bytesAnd: actualCond. - predicate bytesAnd: cond. trueBlock value: self. + c := actualCond clone. - c := cond clone. c not. predicate replaceFrom: 1 to: (predicate size min: origPredicate size) with: origPredicate startingAt: 1. predicate bytesAnd: c. falseBlock value: self. predicate replaceFrom: 1 to: (predicate size min: origPredicate size) with: origPredicate startingAt: 1.! Item was changed: ----- Method: KedamaVectorParseTreeRewriter>>visit:andParent: (in category 'entry point') ----- visit: node andParent: parent | newNode possibleSelector selIndex parentRewriterBlock newNodeBlock | node isLeaf not ifTrue: [ node getAllChildren do: [:child | self visit: child andParent: node. ]. ]. (node rewriteInfoOut notNil) ifTrue: [ ((node isMemberOf: VariableNode) or: [node isMemberOf: LiteralVariableNode]) ifTrue: [ newNode := TempVariableNode new name: node rewriteInfoOut second index: 0 type: 2. parent replaceNode: node with: newNode. ]. ]. (node isMemberOf: MessageNode) ifTrue: [ (node statementType = #sequential) ifTrue: [ node selector key = #doSequentialCommand: ifTrue: [ (node isStatement) ifTrue: [ node receiver: node primaryBreedPair second. ]. ] ]. ]. (node isMemberOf: MessageNode) ifTrue: [ newNodeBlock := [:selector :args | self createMessageNode: node inParentNode: parent receiverNode: (TempVariableNode new name: node rewriteInfoOut second index: 0 type: 2) selector: selector arguments: args]. ((selIndex := #(parallel sequential die) indexOf: node statementType) > 0) ifTrue: [ possibleSelector := #(doCommand: doSequentialCommand: doDieCommand:) at: selIndex. parentRewriterBlock := [:newNod | self rewriteMessageNode: node inParentNode: parent receiverNode: node rewriteInfoIn second selector: possibleSelector arguments: {self makeBlockNodeArguments: {node rewriteInfoOut second} statements: {newNod} returns: false}]. (node messageType = #condition) ifTrue: [ newNode := newNodeBlock value: #test:ifTrue:ifFalse: + value: {BlockNode withJust: node receiver. node arguments first. node arguments second}. - value: {node receiver. node arguments first. node arguments second}. (node isStatement) ifFalse: [ parent replaceNode: node with: newNode. ] ifTrue: [ parentRewriterBlock value: newNode. ]. ] ifFalse: [ node selector key = #timesRepeat: ifTrue: [ newNode := newNodeBlock value: #times:repeat: value: {node receiver. node arguments first}. (node isStatement) ifFalse: [ parent replaceNode: node with: newNode. ] ifTrue: [ parentRewriterBlock value: newNode. ]. ] ifFalse: [(node isStatement) ifTrue: [ parentRewriterBlock value: node ]. ]. ] ]. ]. (node isMemberOf: BlockNode) ifTrue: [ (node rewriteInfoOut notNil) ifTrue: [ self rewriteBlockNode: node inParentNode: parent arguments: (Array with: (TempVariableNode new name: node rewriteInfoOut second index: 0 type: 2)) statements: node statements returns: false. ]. ]. ! Item was changed: ----- Method: MessageAsTempNode>>determineStatementType:fromDict:primaryBreedPair:messageType:isStatement:receiverObject: (in category '*Etoys-Tweak-Kedama-Generated') ----- determineStatementType: t1 fromDict: t2 primaryBreedPair: t3 messageType: t4 isStatement: t5 receiverObject: t6 | t7 t8 t9 t10 t11 t13 | t5 ifFalse: [^ t1]. t9 := t2 at: self. (t9 select: [:t14 | t14 first notNil and: [t14 first isPrototypeTurtlePlayer]]) size = 0 ifTrue: [^ #none]. t4 = #sequential ifTrue: [^ #sequential]. t1 = #sequential ifTrue: [^ #sequential]. t3 ifNil: [^ #none]. t7 := t3 first. t4 = #condition ifTrue: [t11 := IdentitySet new. t13 := IdentitySet new. t9 do: [:t14 | (((t14 at: 5) = #testBody or: [(t14 at: 5) = #testCond]) and: [(t14 at: 4) ~= #read]) ifTrue: [t14 first ifNotNil: [t13 add: t14 first]]. (((t14 at: 5) = #testBody or: [(t14 at: 5) = #testCond]) and: [(t14 at: 4) = #read]) ifTrue: [t14 first ifNotNil: [t11 add: t14 first]]]. ((t13 intersection: t11) copyWithout: t7) ifNotEmpty: [^ #sequential]. ^ #parallel]. t11 := IdentitySet new. t13 := IdentitySet new. t8 := OrderedCollection new. t10 := OrderedCollection new. t9 do: [:t14 | t14 first = t7 ifTrue: [((t7 isBreedSelector: t14 second) or: [t7 isUserDefinedSelector: t14 second]) ifFalse: [t8 add: t14 second]]. t14 first ifNil: [t10 add: t14 second] ifNotNil: [(t14 at: 4) == #read ifTrue: [t11 add: t14 first]. (t14 at: 4) == #read ifFalse: [t13 add: t14 first]]. (t7 containsSequentialSelector: t14 second) ifTrue: [^ #sequential]]. (t8 includes: #die) ifTrue: [^ #die]. (((self isKindOf: AssignmentNode) and: [t6 = t7]) and: [t7 isBreedSelector: self property property]) ifTrue: [^ #none]. (t7 areOkaySelectors: t10) ifFalse: [^ #sequential]. (t7 vectorizableTheseSelectors: t8) ifFalse: [^ #sequential]. ((t11 intersection: t13) copyWithout: t7) ifNotEmpty: [^ #sequential]. + self + nodesDo: [:t14 | (t14 isLeaf + and: [t7 containsSequentialSelector: t14 key]) + ifTrue: [^ #sequential]]. ^ #parallel! Item was changed: ----- Method: MessageNode>>determineStatementType:fromDict:primaryBreedPair:messageType:isStatement:receiverObject: (in category '*Etoys-Tweak-Kedama-Generated') ----- determineStatementType: t1 fromDict: t2 primaryBreedPair: t3 messageType: t4 isStatement: t5 receiverObject: t6 | t7 t8 t9 t10 t11 t13 | t5 ifFalse: [^ t1]. t9 := t2 at: self. (t9 select: [:t14 | t14 first notNil and: [t14 first isPrototypeTurtlePlayer]]) size = 0 ifTrue: [^ #none]. t4 = #sequential ifTrue: [^ #sequential]. t1 = #sequential ifTrue: [^ #sequential]. t3 ifNil: [^ #none]. t7 := t3 first. t4 = #condition ifTrue: [t11 := IdentitySet new. t13 := IdentitySet new. t9 do: [:t14 | (((t14 at: 5) = #testBody or: [(t14 at: 5) = #testCond]) and: [(t14 at: 4) ~= #read]) ifTrue: [t14 first ifNotNil: [t13 add: t14 first]]. (((t14 at: 5) = #testBody or: [(t14 at: 5) = #testCond]) and: [(t14 at: 4) = #read]) ifTrue: [t14 first ifNotNil: [t11 add: t14 first]]]. ((t13 intersection: t11) copyWithout: t7) ifNotEmpty: [^ #sequential]. ^ #parallel]. t11 := IdentitySet new. t13 := IdentitySet new. t8 := OrderedCollection new. t10 := OrderedCollection new. t9 do: [:t14 | t14 first = t7 ifTrue: [((t7 isBreedSelector: t14 second) or: [t7 isUserDefinedSelector: t14 second]) ifFalse: [t8 add: t14 second]]. t14 first ifNil: [t10 add: t14 second] ifNotNil: [(t14 at: 4) == #read ifTrue: [t11 add: t14 first]. (t14 at: 4) == #read ifFalse: [t13 add: t14 first]]. (t7 containsSequentialSelector: t14 second) ifTrue: [^ #sequential]]. (t8 includes: #die) ifTrue: [^ #die]. (((self isKindOf: AssignmentNode) and: [t6 = t7]) and: [t7 isBreedSelector: self property property]) ifTrue: [^ #none]. (t7 areOkaySelectors: t10) ifFalse: [^ #sequential]. (t7 vectorizableTheseSelectors: t8) ifFalse: [^ #sequential]. ((t11 intersection: t13) copyWithout: t7) ifNotEmpty: [^ #sequential]. + self + nodesDo: [:t14 | (t14 isLeaf + and: [t7 containsSequentialSelector: t14 key]) + ifTrue: [^ #sequential]]. ^ #parallel! Item was added: + ----- Method: Morph>>boundsSignatureHash (in category '*Etoys') ----- + boundsSignatureHash + "Answer a hash value that can be used to see if I've moved or been changed significantly" + ^self boundsInWorld hash + ! Item was changed: ----- Method: SpeechBubbleMorph>>balloon (in category 'accessing') ----- balloon ^balloon ifNil: [ | balloonForm | + balloonForm := Form extent: (self extent - (0 @ self tailHeight) max: 1@1) depth: 16. - balloonForm := Form extent: self extent - (0 @ self tailHeight) depth: 16. self drawBalloonOn: balloonForm getCanvas in: balloonForm boundingBox. balloonForm floodFill: self color at: balloonForm center. balloon := (SketchMorph withForm: balloonForm). ]!

1 0

Re: [squeak-dev] The Trunk: System-cmm.913.mcz
by Tobias Pape 01 Sep '16

01 Sep '16

Hi Where's the problem with calling the image with 'patch.st' in the first place? It looks a little bit out of place for me here. Also, Why Kill MNU and Halt from the list? I'm a bit confused about this part of the pathc… Best regards -tobias On 31.08.2016, at 23:33, commits(a)source.squeak.org wrote: > Item was added: > + ----- Method: SmalltalkImage>>patchSystem (in category 'command line') ----- > + patchSystem > + (FileDirectory default fileExists: 'patch.st') ifTrue: > + [Notification signal: 'Patching system...'. > + FileStream > + fileNamed: 'patch.st' > + do: [ : stream | stream fileIn ] ]! > > Item was changed: > ----- Method: SmalltalkImage>>run: (in category 'command line') ----- > run: aBlock > + [ [ self patchSystem. > + (aBlock numArgs = 1 and: [ self arguments size > 1 ]) > - [ [ (aBlock numArgs = 1 and: [ self arguments size > 1 ]) > ifTrue: [ "Allow a large, variable number of arguments to be passed as an Array to aBlock." > aBlock value: self arguments ] > ifFalse: [ aBlock valueWithEnoughArguments: self arguments ] ] > on: ProgressInitiationException > do: > + [ : pie | "Don't want to log this notification." > - [ : pie | "Don't want to log these notifications." > pie defaultAction ] ] > on: Notification , Warning > do: > [ : noti | FileStream stdout > nextPutAll: DateAndTime now asString ; > space ; > nextPutAll: noti description ; > cr. > noti resume ] > on: SyntaxErrorNotification > do: > [ : err | FileStream stdout > nextPutAll: err errorCode ; > cr; flush. > self isHeadless > ifTrue: [ self snapshot: false andQuit: true ] > ifFalse: [ err pass ] ] > + on: Error > - on: Error, MessageNotUnderstood, Halt > do: > [ : err | err printVerboseOn: FileStream stderr. > FileStream stderr flush. > self isHeadless > ifTrue: [ self snapshot: false andQuit: true ] > ifFalse: [ err pass ] ]!

2 2

Jump to page: