Squeak-dev September 2016

squeak-dev@lists.squeakfoundation.org

46 participants
175 discussions

EToys in the Trunk
by Levente Uzonyi 05 Sep '16

05 Sep '16

Hi All, With the recent updates, we have the full EToys package in the Trunk, which has more than 78k LoC. That's almost 1.5x what Morphic has, and it's more than Kernel, System and Collections together. Do we want to keep it in the Trunk? Levente

9 13

Daily Commit Log
by commits＠source.squeak.org 04 Sep '16

04 Sep '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-September/068917.… Name: EToys-dtl.230 Ancestors: EToys-nice.229 Remove the Character>>setValue: EToys extension because it is unreferenced in Spur and it breaks Character in a V3 image. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-September/068918.… Name: EToys-dtl.231 Ancestors: EToys-dtl.230 Remove Etoys extension for ImageSegment>>cc:new:current:fake:refStrm: because there are no senders in a Spur image and extension is not required in a V3 image. =============================================

1 0

The Inbox: Tools-nice.725.mcz
by commits＠source.squeak.org 04 Sep '16

04 Sep '16

Nicolas Cellier uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-nice.725.mcz ==================== Summary ==================== Name: Tools-nice.725 Author: nice Time: 4 September 2016, 9:31:23.175175 pm UUID: 7009e733-b45e-403a-9469-6106ad6f747a Ancestors: Tools-tfel.724 Recognize Cuis #classDefinition: when scanning a cuis change file. =============== Diff against Tools-tfel.724 =============== Item was changed: ----- Method: ChangeList>>scanCategory (in category 'scanning') ----- scanCategory "Scan anything that involves more than one chunk; method name is historical only" + | itemPosition item tokens stamp anIndex class meta | - | itemPosition item tokens stamp anIndex | itemPosition := file position. item := file nextChunk. ((item includesSubstring: 'commentStamp:') or: [(item includesSubstring: 'methodsFor:') + or: [(item includesSubstring: 'classDefinition:') + or: [item endsWith: 'reorganize']]]) ifFalse: - or: [item endsWith: 'reorganize']]) ifFalse: ["Maybe a preamble, but not one we recognize; bail out with the preamble trick" ^ self addItem: (ChangeRecord new file: file position: itemPosition type: #preamble) text: ('preamble: ' , item contractTo: 50)]. tokens := Scanner new scanTokens: item. tokens size >= 3 ifTrue: [stamp := ''. anIndex := tokens indexOf: #stamp: ifAbsent: [nil]. anIndex ifNotNil: [stamp := tokens at: (anIndex + 1)]. tokens second == #methodsFor: ifTrue: [^ self scanCategory: tokens third class: tokens first meta: false stamp: stamp]. tokens third == #methodsFor: ifTrue: [^ self scanCategory: tokens fourth class: tokens first meta: true stamp: stamp]]. tokens second == #commentStamp: ifTrue: [stamp := tokens third. self addItem: (ChangeRecord new file: file position: file position type: #classComment class: tokens first category: nil meta: false stamp: stamp) text: 'class comment for ' , tokens first, (stamp isEmpty ifTrue: [''] ifFalse: ['; ' , stamp]). file nextChunk. ^ file skipStyleChunk]. + + tokens first == #classDefinition: + ifTrue: + [class := tokens second. + meta := tokens size >= 3 and: [tokens third = 'class']. + stamp := ''. + self addItem: + (ChangeRecord new file: file position: file position type: #classDefinition + class: class category: nil meta: meta stamp: stamp) + text: 'class definition for ' , class, + (stamp isEmpty ifTrue: [''] ifFalse: ['; ' , stamp]). + file nextChunk. + ^ file skipStyleChunk]. self assert: tokens last == #reorganize. self addItem: (ChangeRecord new file: file position: file position type: #reorganize class: tokens first category: nil meta: false stamp: stamp) text: 'organization for ' , tokens first, (tokens second == #class ifTrue: [' class'] ifFalse: ['']). file nextChunk!

1 0

The Inbox: Files-dtl.166.mcz
by commits＠source.squeak.org 04 Sep '16

04 Sep '16

David T. Lewis uploaded a new version of Files to project The Inbox: http://source.squeak.org/inbox/Files-dtl.166.mcz ==================== Summary ==================== Name: Files-dtl.166 Author: dtl Time: 4 September 2016, 3:09:29.495898 pm UUID: 85945e53-39b3-4300-a08c-d189a4b9960d Ancestors: Files-tfel.165 Let the Files package be identical for Spur and V3 images by adding error handling in StandardFileStream>>binary and StandardFileStream>>ascii =============== Diff against Files-tfel.165 =============== Item was changed: ----- Method: StandardFileStream>>ascii (in category 'properties-setting') ----- ascii "Read and/or write in ASCII mode." buffer1 ifNil: [ buffer1 := ByteString new: 1 ] + ifNotNil: [ [ ByteString adoptInstance: buffer1 ] + on: Error "V3 image" + do: [ buffer1 := ByteString new: 1 ] ]. + collection ifNotNil: [ [ ByteString adoptInstance: collection ] + on: Error + do: [ collection := collection asString ] ]. - ifNotNil: [ ByteString adoptInstance: buffer1 ]. - collection ifNotNil: [ ByteString adoptInstance: collection ]. lastWritten ifNotNil: [ lastWritten isInteger ifTrue: [ lastWritten := lastWritten asCharacter ] ]! Item was changed: ----- Method: StandardFileStream>>binary (in category 'properties-setting') ----- binary "Read and/or write in binary mode." buffer1 ifNil: [ buffer1 := ByteArray new: 1 ] + ifNotNil: [ [ ByteArray adoptInstance: buffer1 ] + on: Error "V3 image" + do: [ buffer1 := ByteArray new: 1 ] ]. + collection ifNotNil: [ [ ByteArray adoptInstance: collection ] + on: Error + do: [ collection := collection asByteArray ] ]. - ifNotNil: [ ByteArray adoptInstance: buffer1 ]. - collection ifNotNil: [ ByteArray adoptInstance: collection ]. lastWritten ifNotNil: [ lastWritten isCharacter ifTrue: [ lastWritten := lastWritten asInteger ] ]!

1 0

The Trunk: EToys-dtl.231.mcz
by commits＠source.squeak.org 04 Sep '16

04 Sep '16

David T. Lewis uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-dtl.231.mcz ==================== Summary ==================== Name: EToys-dtl.231 Author: dtl Time: 4 September 2016, 2:27:44.612203 pm UUID: f2322433-6226-4dbd-8a88-0ca15e6b917b Ancestors: EToys-dtl.230 Remove Etoys extension for ImageSegment>>cc:new:current:fake:refStrm: because there are no senders in a Spur image and extension is not required in a V3 image. =============== Diff against EToys-dtl.230 =============== Item was removed: - ----- Method: ImageSegment>>cc:new:current:fake:refStrm: (in category '*Etoys-Squeakland-compact classes') ----- - cc: ind new: inTheSeg current: inTheImage fake: fakeCls refStrm: smartRefStream - "Sort out all the cases and decide what to do. Every Fake class is uncompacted before having insts converted. As the segment is installed, instances of reshaped compact classes will have the wrong class. Trouble cases: - 1) Existing class is compact in the segment and not compact here. Make that compact, (error if that slot is used), load the segment. If an class was just filed in, it is an existing class as far as we are concerned. - 2) A compact class has a different shape. We created a Fake class. Load the segment, with instances in the seg having the Wrong Class!!!! Find the bad instancees, and copy them over to being the real class. - 3) An existing class is not compact in the segment, but is in the image. Just let the new instance be uncompact. That is OK, and never reaches this code. - A class that is a root in this segment cannot be compact. That is not allowed." - - (inTheImage == nil) & (fakeCls == nil) ifTrue: ["case 1 and empty slot" - inTheSeg becomeCompactSimplyAt: ind. ^ true]. - - (inTheImage == inTheSeg) & (fakeCls == nil) ifTrue: ["everything matches" - ^ true]. - - inTheImage ifNil: ["reshaped and is an empty slot" - fakeCls becomeCompactSimplyAt: ind. ^ true]. - "comeFullyUpOnReload: will clean up" - - (inTheSeg == String and:[inTheImage == ByteString]) ifTrue:[ - "ar 4/10/2005: Workaround after renaming String to ByteString" - ^true - ]. - - "Is the image class really the class we are expecting? inTheSeg came in as a DiskProxy, and was mapped if it was renamed!!" - inTheImage == inTheSeg ifFalse: [ - self inform: 'The incoming class ', inTheSeg name, ' wants compact class \location ', ind printString, ', but that is occupied by ', inTheImage name, '. \This file cannot be read into this system. The author of the file \should make the class uncompact and create the file again.' withCRs. - ^ false]. - - "Instances of fakeCls think they are compact, and thus will say they are instances of the class inTheImage, which is a different shape. Just allow this to happen. Collect them and remap them as soon as the segment is installed." - ^ true!

1 0

The Trunk: EToys-dtl.230.mcz
by commits＠source.squeak.org 04 Sep '16

04 Sep '16

David T. Lewis uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-dtl.230.mcz ==================== Summary ==================== Name: EToys-dtl.230 Author: dtl Time: 4 September 2016, 12:50:29.050862 pm UUID: 9298ab92-7fcb-46f8-b39d-2b242fda0f2f Ancestors: EToys-nice.229 Remove the Character>>setValue: EToys extension because it is unreferenced in Spur and it breaks Character in a V3 image. =============== Diff against EToys-nice.229 =============== Item was removed: - ----- Method: Character>>setValue: (in category '*Etoys-Squeakland-private') ----- - setValue: newValue - ^self error:'Characters are immutable' - !

1 0

[Please Review] Map CTRL+red to CTRL+yellow and CMD+red to CMD+blue
by marcel.taeumel 02 Sep '16

02 Sep '16

Hi, there. Here is a change set that adds an (optional) event filter to the hand morph to convert CTRL+red click to CTRL+yellow click and CMD+red click to CMD+blue click. If there are no objections, we can then prepare the image to remove that conversion from the VM sources into the image level. mouse-button-filter.cs <http://forum.world.st/file/n4913716/mouse-button-filter.cs> Note that current VMs will never provide CTRL+red events or CMD+red click events. Best, Marcel -- View this message in context: http://forum.world.st/Please-Review-Map-CTRL-red-to-CTRL-yellow-and-CMD-red… Sent from the Squeak - Dev mailing list archive at Nabble.com.

4 3

Daily Commit Log
by commits＠source.squeak.org 01 Sep '16

01 Sep '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-August/068914.html Name: EToys-nice.214 Ancestors: EToys-tfel.213 Avoid using SmallInteger maxVal for 64bits compatibility. Indeed, the maxVal would not fit in a WordArray in 64bits VM ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068915.html Name: EToys-nice.229 Ancestors: EToys-tfel.228, EToys-nice.214 Merge EToys-nice.214 for 64bits image compatibility ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068916.html Name: System-cmm.913 Ancestors: System-tfel.912 - Don't use colored parentheses and brackets in the Community dark theme, and intensify #dbRed a bit, it was too washed out. - A new hook in Smalltalk run: to allow temporarily patched production systems running to be re-patched in the event of a restart. =============================================

1 0

Re: The Trunk: System-cmm.913.mcz
by marcel.taeumel 01 Sep '16

01 Sep '16

Hi Chris, here are some thoughts on this commit: - Please refrain from committing unrelated changes that are easily to separate. If you have troubles uploading the 1000K MCZ for the System package twice, consider upgrading your ISP. :-) *scnr* - That "patch.st" hack seems like an indication that there are several situations where you cannot cope with the .image characteristics of the Smalltalk system. Please think about a better solution because the .image file should usually not be read-only. It impedes Smalltalk-style maintenance of such an image. While there have been good reasons in the past for treating the .image in the Etoys bundles as read-only and relying on project import/explort, I do not agree that we should make such a specific case common practice. This "patch.st" feels like a first step towards yet another CI/build system, which we already have with smalltalkCI and TravisCI. - This commit message would benefit from a little more explanation. There is plenty "what you did" but too little "why you did it". For example, the words "... to be re-patched in the event of a restart" really need an explanation of why you cannot just supply a start-up script to do that patching like "./vm some.image patch.st". Please invest more time in more elaborate commit messages. :) Best, Marcel -- View this message in context: http://forum.world.st/The-Trunk-System-cmm-913-mcz-tp4913525p4913539.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

3 2

The Inbox: MorphicExtras-jl.196.mcz
by commits＠source.squeak.org 01 Sep '16

01 Sep '16

A new version of MorphicExtras was added to project The Inbox: http://source.squeak.org/inbox/MorphicExtras-jl.196.mcz ==================== Summary ==================== Name: MorphicExtras-jl.196 Author: jl Time: 1 September 2016, 3:59:47.545565 pm UUID: f54f2528-43a4-cf49-beb9-42b4ab57aebf Ancestors: MorphicExtras-tfel.195 added Kedama (Particles) to default flap =============== Diff against MorphicExtras-tfel.195 =============== Item was changed: ----- Method: Flaps class>>defaultsQuadsDefiningPlugInSuppliesFlap (in category 'predefined flaps') ----- defaultsQuadsDefiningPlugInSuppliesFlap "Answer a list of quads which define the objects to appear in the default Supplies flap used in the Plug-in image" + "PartsBin reconstructAllPartsIcons" + ^ #( (ObjectsTool newStandAlone 'Object Catalog' 'A tool that lets you browse the catalog of available objects') "(AllScriptsTool allScriptsToolForActiveWorld 'All Scripts' 'Stop, Step, and Go buttons for controlling all your scripts at once. The tool can also be "opened up" to control each script in your project individually.')" (TrashCanMorph new 'Trash' 'A tool for discarding objects') (GrabPatchMorph new 'Grab Patch' 'Allows you to create a new Sketch by grabbing a rectangular patch from the screen') (LassoPatchMorph new 'Lasso' 'Allows you to create a new Sketch by lassoing an area from the screen') (StickyPadMorph newStandAlone 'Sticky Pad' 'Each time you obtain one of these pastel, translucent, borderless rectangles, it will be a different color from the previous time.') "(PaintInvokingMorph new 'Paint' 'Drop this into an area to start making a fresh painting there')" (TextMorph boldAuthoringPrototype 'Text' 'Text that you can edit into anything you desire.') (RecordingControlsMorph authoringPrototype 'Sound' 'A device for making sound recordings.') (RectangleMorph authoringPrototype 'Rectangle' 'A rectangle') (RectangleMorph roundRectPrototype 'RoundRect' 'A rectangle with rounded corners') (EllipseMorph authoringPrototype 'Ellipse' 'An ellipse or circle') (StarMorph authoringPrototype 'Star' 'A star') (CurveMorph authoringPrototype 'Curve' 'A curve') (PolygonMorph authoringPrototype 'Polygon' 'A straight-sided figure with any number of sides') (ScriptableButton authoringPrototype 'Button' 'A Scriptable button') (BookMorph nextPageButton 'NextPage' 'A button that takes you to the next page') (BookMorph previousPageButton 'PreviousPage' 'A button that takes you to the previous page') "(ScriptingSystem prototypicalHolder 'Holder' 'A place for storing alternative pictures in an animation, etc.')" (PasteUpMorph authoringPrototype 'Playfield' 'A place for assembling parts or for staging animations') (SimpleSliderMorph authoringPrototype 'Slider' 'A slider for showing and setting numeric values.') (JoystickMorph authoringPrototype 'Joystick' 'A joystick-like control') (BookMorph authoringPrototype 'Book' 'A multi-paged structure') "(ClockMorph authoringPrototype 'Clock' 'A simple digital clock')" + (KedamaMorph authoringPrototype 'Particles' 'A Kedama World with pre-made components') (RandomNumberTile new 'Random' 'A random-number tile for use with tile scripting')) asOrderedCollection!

1 0

Jump to page: