Squeak-dev June 2016

squeak-dev@lists.squeakfoundation.org

39 participants
202 discussions

Dark background colors for system windows
by karl ramberg 03 Jun '16

03 Jun '16

Hi, Here is latest change set for trunk image with dark background colors for system windows. Screen shot:http://i.imgur.com/lJolfc2.png Install change set. Select in menu: Extras/ Window Colors/ Dark Background Colors Best, Karl

2 3

Files-ul.154 seems dangerous, is it needed?
by David T. Lewis 03 Jun '16

03 Jun '16

We did this change recently: Name: Files-ul.154 Time: 15 May 2016, 11:17:08.015805 pm - use #adoptInstance: to convert between binary and ascii mode instead of creating new collections This assumes that we can convert a ByteString to a ByteArray using Behavior>>adoptInstance. If the conversion does not work, as it the case with a V3 image and Cog or interpreter VM, then we end up with a corrupt image after trying to save the image as new version (and maybe other cases as well). It does not seem that #ascii and #binary are called frequently, even when doing Monticello updates, so I suspect that the optimization is not very important. Do we need the #ascii and #binary optimizations in Files-ul.154? Dave

4 8

Formatting? was: Re: [squeak-dev] The Trunk: ToolBuilder-Morphic-cmm.164.mcz
by Tobias Pape 03 Jun '16

03 Jun '16

On 31.05.2016, at 21:26, commits(a)source.squeak.org wrote: > Item was changed: > ----- Method: PluggableTextMorphPlus>>drawBalloonTextOn: (in category 'drawing') ----- > + drawBalloonTextOn: aCanvas > - drawBalloonTextOn: aCanvas > "Show balloon text in the text morph if it has no contents." > + textMorph contents ifNotEmpty: [ ^ self ]. > + ([ self balloonText ] > + on: Error > + do: [ : err | 'error in balloonText' ]) ifNotNil: > + [ : text | aCanvas > - > - textMorph contents ifNotEmpty: [^ self]. > - > - self balloonText ifNotNil: [:text | > - aCanvas > drawString: text > + in: (self innerBounds insetBy: (5 @ 2 corner: 0 @ 0)) > + font: textMorph textStyle defaultFont "I want italic here" > + color: (Color gray: 0.7) ]! > - in: (self innerBounds insetBy: (5@2 corner: 0@0)) > - font: textMorph textStyle defaultFont > - color: (Color gray: 0.7)].! Just curious, why are you adding spaces everywhere? :) Best regards -toibas

11 23

Re: [squeak-dev] The Trunk: Tools-cmm.703.mcz
by Chris Muller 03 Jun '16

03 Jun '16

Not sure if Lexicon needs any changes, its menu is broken right now, and I didn't have time to investigate that. On Thu, Jun 2, 2016 at 5:42 PM, <commits(a)source.squeak.org> wrote: > Chris Muller uploaded a new version of Tools to project The Trunk: > http://source.squeak.org/trunk/Tools-cmm.703.mcz > > ==================== Summary ==================== > > Name: Tools-cmm.703 > Author: cmm > Time: 2 June 2016, 5:41:56.679756 pm > UUID: 9e4c33b5-dae7-4884-9e46-22a4833bebd7 > Ancestors: Tools-eem.702 > > - Corrected menu hot-key indication for 'show category' -- it's (Y) not (C). > - Upgraded it to 'toggle category selection', which is really useful given that browsers spawned via Cmd+b come with category automatically selected. > > =============== Diff against Tools-eem.702 =============== > > Item was removed: > - ----- Method: Browser>>selectOriginalCategoryForCurrentMethod (in category 'message category list') ----- > - selectOriginalCategoryForCurrentMethod > - "private - Select the message category for the current method. > - > - Note: This should only be called when somebody tries to save > - a method that they are modifying while ALL is selected. > - > - Returns: true on success, false on failure." > - | aSymbol selectorName | > - aSymbol := self categoryOfCurrentMethod. > - selectorName := self selectedMessageName. > - (aSymbol notNil and: [aSymbol ~= ClassOrganizer allCategory]) > - ifTrue: > - [selectedMessageCategoryName := aSymbol. > - selectedMessageName := selectorName. > - self changed: #messageCategorySelectionChanged. > - self changed: #messageCategoryListIndex. "update my selection" > - self changed: #messageList. > - self changed: #messageListIndex. > - ^ true]. > - ^ false! > > Item was changed: > ----- Method: Browser>>shiftedMessageListMenu: (in category 'message functions') ----- > shiftedMessageListMenu: aMenu > <messageListMenuShifted: true> > "Fill aMenu with the items appropriate when the shift key is held down" > > aMenu addStayUpItem. > aMenu addList: #( > ('toggle diffing (D)' toggleDiffing) > ('implementors of sent messages' browseAllMessages) > - > ('local senders of...' browseLocalSendersOfMessages) > ('local implementors of...' browseLocalImplementors) > - > ('spawn sub-protocol' spawnProtocol) > ('spawn full protocol' spawnFullProtocol) > - > ('sample instance' makeSampleInstance) > ('inspect instances' inspectInstances) > ('inspect subinstances' inspectSubInstances)). > > self addExtraShiftedItemsTo: aMenu. > aMenu addList: #( > - > ('change category...' changeCategory)). > > self canShowMultipleMessageCategories ifTrue: [aMenu addList: > + #(('toggle category selection (Y)' showHomeCategory))]. > - #(('show category (C)' showHomeCategory))]. > aMenu addList: #( > - > ('change sets with this method' findMethodInChangeSets) > ('revert to previous version' revertToPreviousVersion) > ('remove from current change set' removeFromCurrentChanges) > ('revert & remove from changes' revertAndForget) > ('add to current change set' adoptMessageInCurrentChangeset) > ('copy up or copy down...' copyUpOrCopyDown)). > ^ aMenu > ! > > Item was changed: > ----- Method: Browser>>showHomeCategory (in category 'message category functions') ----- > showHomeCategory > "Show the home category of the selected method. This is only really useful if one is in a tool that supports the showing of categories. Thus, it's good in browsers and hierarchy browsers but not in message-list browsers" > > | aSelector | > self okToChange ifTrue: > [(aSelector := self selectedMessageName) ifNotNil: > + [self toggleCategorySelectionForCurrentMethod. > - [self selectOriginalCategoryForCurrentMethod. > self selectedMessageName: aSelector]]! > > Item was added: > + ----- Method: Browser>>toggleCategorySelectionForCurrentMethod (in category 'message category list') ----- > + toggleCategorySelectionForCurrentMethod > + | methodCategory selectorName | > + methodCategory := self categoryOfCurrentMethod. > + selectorName := self selectedMessageName. > + (methodCategory notNil and: > + [ methodCategory ~= ClassOrganizer allCategory and: [ methodCategory ~= selectedMessageCategoryName ] ]) > + ifTrue: > + [ selectedMessageCategoryName := methodCategory. > + selectedMessageName := selectorName. > + self changed: #messageCategorySelectionChanged. > + self changed: #messageCategoryListIndex. > + "update my selection" > + self changed: #messageList. > + self changed: #messageListIndex ] > + ifFalse: > + [ methodCategory = selectedMessageCategoryName ifTrue: > + [ selectedMessageCategoryName := nil. > + self > + changed: #messageCategorySelectionChanged ; > + changed: #messageCategoryListIndex ; > + changed: #messageList ] ]! > >

1 0

The Trunk: Tools-cmm.703.mcz
by commits＠source.squeak.org 03 Jun '16

03 Jun '16

Chris Muller uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-cmm.703.mcz ==================== Summary ==================== Name: Tools-cmm.703 Author: cmm Time: 2 June 2016, 5:41:56.679756 pm UUID: 9e4c33b5-dae7-4884-9e46-22a4833bebd7 Ancestors: Tools-eem.702 - Corrected menu hot-key indication for 'show category' -- it's (Y) not (C). - Upgraded it to 'toggle category selection', which is really useful given that browsers spawned via Cmd+b come with category automatically selected. =============== Diff against Tools-eem.702 =============== Item was removed: - ----- Method: Browser>>selectOriginalCategoryForCurrentMethod (in category 'message category list') ----- - selectOriginalCategoryForCurrentMethod - "private - Select the message category for the current method. - - Note: This should only be called when somebody tries to save - a method that they are modifying while ALL is selected. - - Returns: true on success, false on failure." - | aSymbol selectorName | - aSymbol := self categoryOfCurrentMethod. - selectorName := self selectedMessageName. - (aSymbol notNil and: [aSymbol ~= ClassOrganizer allCategory]) - ifTrue: - [selectedMessageCategoryName := aSymbol. - selectedMessageName := selectorName. - self changed: #messageCategorySelectionChanged. - self changed: #messageCategoryListIndex. "update my selection" - self changed: #messageList. - self changed: #messageListIndex. - ^ true]. - ^ false! Item was changed: ----- Method: Browser>>shiftedMessageListMenu: (in category 'message functions') ----- shiftedMessageListMenu: aMenu <messageListMenuShifted: true> "Fill aMenu with the items appropriate when the shift key is held down" aMenu addStayUpItem. aMenu addList: #( ('toggle diffing (D)' toggleDiffing) ('implementors of sent messages' browseAllMessages) - ('local senders of...' browseLocalSendersOfMessages) ('local implementors of...' browseLocalImplementors) - ('spawn sub-protocol' spawnProtocol) ('spawn full protocol' spawnFullProtocol) - ('sample instance' makeSampleInstance) ('inspect instances' inspectInstances) ('inspect subinstances' inspectSubInstances)). self addExtraShiftedItemsTo: aMenu. aMenu addList: #( - ('change category...' changeCategory)). self canShowMultipleMessageCategories ifTrue: [aMenu addList: + #(('toggle category selection (Y)' showHomeCategory))]. - #(('show category (C)' showHomeCategory))]. aMenu addList: #( - ('change sets with this method' findMethodInChangeSets) ('revert to previous version' revertToPreviousVersion) ('remove from current change set' removeFromCurrentChanges) ('revert & remove from changes' revertAndForget) ('add to current change set' adoptMessageInCurrentChangeset) ('copy up or copy down...' copyUpOrCopyDown)). ^ aMenu ! Item was changed: ----- Method: Browser>>showHomeCategory (in category 'message category functions') ----- showHomeCategory "Show the home category of the selected method. This is only really useful if one is in a tool that supports the showing of categories. Thus, it's good in browsers and hierarchy browsers but not in message-list browsers" | aSelector | self okToChange ifTrue: [(aSelector := self selectedMessageName) ifNotNil: + [self toggleCategorySelectionForCurrentMethod. - [self selectOriginalCategoryForCurrentMethod. self selectedMessageName: aSelector]]! Item was added: + ----- Method: Browser>>toggleCategorySelectionForCurrentMethod (in category 'message category list') ----- + toggleCategorySelectionForCurrentMethod + | methodCategory selectorName | + methodCategory := self categoryOfCurrentMethod. + selectorName := self selectedMessageName. + (methodCategory notNil and: + [ methodCategory ~= ClassOrganizer allCategory and: [ methodCategory ~= selectedMessageCategoryName ] ]) + ifTrue: + [ selectedMessageCategoryName := methodCategory. + selectedMessageName := selectorName. + self changed: #messageCategorySelectionChanged. + self changed: #messageCategoryListIndex. + "update my selection" + self changed: #messageList. + self changed: #messageListIndex ] + ifFalse: + [ methodCategory = selectedMessageCategoryName ifTrue: + [ selectedMessageCategoryName := nil. + self + changed: #messageCategorySelectionChanged ; + changed: #messageCategoryListIndex ; + changed: #messageList ] ]!

1 0

Daily Commit Log
by commits＠source.squeak.org 02 Jun '16

02 Jun '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-June/068168.html Name: Collections-ul.695 Ancestors: Collections-topa.694 Heap revamp #1: class side: - Heaps can be created on an existing array with #on: #on:size: and #on:size:sortBlock: - #withAll: and #withAll:sortBlock: avoid creating an extra copy if the argument is already an Array instance side: - imported and improved #= from Pharo - #growTo: won't raise an error when newSize is less than array size (e.g. during compaction) - #sortBlock: restores the heap invariant on its own - improved #select:, #collect, #at:, #removeAt:, #add: - added #sort and #compact; compatible with other collections - #capacity returns the real capacity - inlined #sorts:before: and #indexUpdateBlock: for performance - improved performance and legibility of the heap operations #upHeap: #downHeap: and #downHeapSingle: - added #isValidHeap - added some comments ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068169.html Name: Collections-ul.696 Ancestors: Collections-ul.695 - added #quickSort and #quickSort: to ArrayedCollection ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068170.html Name: CollectionsTests-ul.263 Ancestors: CollectionsTests-mt.262 - added a few more heap tests ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068171.html Name: ToolBuilder-Morphic-mt.166 Ancestors: ToolBuilder-Morphic-mt.165 Fixes tool opening for non-windows. Fixes debugger opening for errors that occur in invisible worlds' event processing chain. Required for writing tests for user input event processing. Always use the project's world to show debuggers. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068172.html Name: Morphic-ul.1158 Ancestors: Morphic-mt.1157 - use #sort instead of #fullySort ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068173.html Name: 51Deprecated-ul.30 Ancestors: 51Deprecated-mt.29 Deprecated the now unused methods of Heap. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068174.html Name: Collections-ul.697 Ancestors: Collections-ul.696 Heap revamp #2. Deprecated the now unusued #fullySort, #reSort, #sorts:before:, #trim and #updateObjectIndex: Bonus: do not re-sort the receiver of SortedCollection >> #sortBlock: when it only has one element. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068175.html Name: CollectionsTests-ul.264 Ancestors: CollectionsTests-ul.263 #sortBlock: will re-sort the SortedCollection, so there's no need to send #reSort to it afterwards in SortedCollectionTest >> #testShouldPrecede. =============================================

1 0

The Inbox: Collections-ul.698.mcz
by commits＠source.squeak.org 02 Jun '16

02 Jun '16

Levente Uzonyi uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ul.698.mcz ==================== Summary ==================== Name: Collections-ul.698 Author: ul Time: 2 June 2016, 11:47:32.688405 pm UUID: cf02bd5c-5cfa-499c-88df-c00ae1760a38 Ancestors: Collections-ul.697 Heap revamp #3: - Heap is a subclass of Collection instead of SequenceableCollection. - Heap has it's own category Collections-Heap; just like how it is with Stack. - Updated class comment. =============== Diff against Collections-ul.697 =============== Item was changed: SystemOrganization addCategory: #'Collections-Abstract'! SystemOrganization addCategory: #'Collections-Arrayed'! SystemOrganization addCategory: #'Collections-Cache'! SystemOrganization addCategory: #'Collections-Exceptions'! SystemOrganization addCategory: #'Collections-Sequenceable'! SystemOrganization addCategory: #'Collections-Stack'! SystemOrganization addCategory: #'Collections-Streams'! SystemOrganization addCategory: #'Collections-Strings'! SystemOrganization addCategory: #'Collections-Support'! SystemOrganization addCategory: #'Collections-Text'! SystemOrganization addCategory: #'Collections-Unordered'! SystemOrganization addCategory: #'Collections-Weak'! + SystemOrganization addCategory: #'Collections-Heap'! Item was changed: + Collection subclass: #Heap - SequenceableCollection subclass: #Heap instanceVariableNames: 'array tally sortBlock indexUpdateBlock' classVariableNames: '' poolDictionaries: '' + category: 'Collections-Heap'! - category: 'Collections-Sequenceable'! + !Heap commentStamp: 'ul 6/2/2016 23:45' prior: 0! + I implement a special data structure called Binary Heap [ https://en.wikipedia.org/wiki/Binary_heap ], which is the most commonly used variant of the Heap data structure [ https://en.wikipedia.org/wiki/Heap_%28data_structure%29 ]. - !Heap commentStamp: 'nice 9/30/2010 23:22' prior: 0! - Class Heap implements a special data structure commonly referred to as 'heap' [ http://en.wikipedia.org/wiki/Heap_%28data_structure%29 ] A Heap is a kind of binary tree stored in a linear array - see details after the instance variables description. Heaps are good at handling priority queues because: 1) greatest priority element according to the sort block will be stored in first position and thus accessed in O(1) operations 2) worse time for inserting or removing an element is in O(log n) operations, where n is the size of the Heap Insertion/Removal times are more efficient than above upper bound, provided that: a) Elements are only removed at the beginning b) Elements are added with arbitrary sort order. 3) there is no need to fully sort the Heap, which makes it more efficient than a SortedCollection + The heap can be fully sorted by sending the message #sort. - The heap can be fully sorted by sending the message #fullySort. Worse time for fully sorting the Heap is in O(n log n) operations, but this is rarely used a feature. Remind that the Heap does not fully sort the collection if you don't ask. Thus don't expect #do: and other iterators to enumerate elements according to the sortBlock order. Instance variables: + array <Array> The data repository - array <Array> The data repository tally <Integer> The number of elements in the heap sortBlock <Block|nil> A two-argument block defining the sort order, or nil in which case the default sort order is [:element1 :element2| element1 <= element2] indexUpdateBlock <Block|nil> A two-argument block of the form [:data :index | ... ] which allows an application object to keep track of its index within the heap. Useful for quick heap update when object's sort value changes (for example, when an object in a priority queue has its priority increased by an external event, you don't want to have to search through the whole heap to find the index before fixing the heap). No update occurs if nil. The Heap can be viewed as a binary tree (every node in the tree has at most two children). The root is stored in first slot of internal array. The children are stored in next two slots. The children of children in next four slots. etc... For a node A of index i (1 based), the two children B1 and B2 are thus stored in indices (2*i) and (2*i+1). Of course, the children indices must be less than the tally otherwise they are considered inexistent. The Heap does arrange to preserve the following invariant: + For any children B of a node A, A is sorted before B, in other words, (sortBlock value: A value: B) = true - For any children B of a node A, A is sorted before B, in other words, (self sort: A before: B) = true This implies that the root is always the first element according to sort order. !

1 0

The Trunk: CollectionsTests-ul.264.mcz
by commits＠source.squeak.org 02 Jun '16

02 Jun '16

Levente Uzonyi uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-ul.264.mcz ==================== Summary ==================== Name: CollectionsTests-ul.264 Author: ul Time: 2 June 2016, 8:33:36.59299 pm UUID: 8b363f56-526e-4bea-b997-56008d7e270f Ancestors: CollectionsTests-ul.263 #sortBlock: will re-sort the SortedCollection, so there's no need to send #reSort to it afterwards in SortedCollectionTest >> #testShouldPrecede. =============== Diff against CollectionsTests-ul.263 =============== Item was changed: ----- Method: SortedCollectionTest>>testShouldPrecede (in category 'basic') ----- testShouldPrecede "self run: #testShouldPrecede" |aSortedCollection| aSortedCollection := SortedCollection new. self assert: (aSortedCollection should: 'za' precede: 'zb'). self assert: (aSortedCollection isEmpty). self assert: (aSortedCollection should: 1 precede: 2). aSortedCollection sortBlock: [:a :b | a > b]. + - aSortedCollection reSort. self assert: (aSortedCollection should: 'zb' precede: 'za'). self assert: (aSortedCollection isEmpty). self assert: (aSortedCollection should: 2 precede: 1). !

1 0

The Trunk: Collections-ul.697.mcz
by commits＠source.squeak.org 02 Jun '16

02 Jun '16

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.697.mcz ==================== Summary ==================== Name: Collections-ul.697 Author: ul Time: 2 June 2016, 8:31:09.211811 pm UUID: 4d7d52f4-cdbb-423f-9923-aee902c885b0 Ancestors: Collections-ul.696 Heap revamp #2. Deprecated the now unusued #fullySort, #reSort, #sorts:before:, #trim and #updateObjectIndex: Bonus: do not re-sort the receiver of SortedCollection >> #sortBlock: when it only has one element. =============== Diff against Collections-ul.696 =============== Item was removed: - ----- Method: Heap>>fullySort (in category 'accessing') ----- - fullySort - "Fully sort the heap. - This method preserves the heap invariants and can thus be sent safely" - self privateReverseSort. - 1 to: tally // 2 do: [:i | array swap: i with: 1 + tally - i]! Item was removed: - ----- Method: Heap>>reSort (in category 'accessing') ----- - reSort - "Resort the entire heap" - self isEmpty ifTrue:[^self]. - tally // 2 to: 1 by: -1 do:[:i| self downHeap: i].! Item was removed: - ----- Method: Heap>>sorts:before: (in category 'testing') ----- - sorts: element1 before: element2 - "Return true if element1 should be sorted before element2. - This method defines the sort order in the receiver" - ^sortBlock == nil - ifTrue:[element1 <= element2] - ifFalse:[sortBlock value: element1 value: element2].! Item was removed: - ----- Method: Heap>>trim (in category 'growing') ----- - trim - "Remove any empty slots in the receiver." - self growTo: self size.! Item was removed: - ----- Method: Heap>>updateObjectIndex: (in category 'private') ----- - updateObjectIndex: index - "If indexUpdateBlock is not nil, notify the object at index of its new position in the heap array." - indexUpdateBlock ifNotNil: [ - indexUpdateBlock value: (array at: index) value: index]! Item was changed: ----- Method: SortedCollection>>sortBlock: (in category 'accessing') ----- sortBlock: aBlock "Make the argument, aBlock, be the criterion for ordering elements of the receiver." sortBlock := aBlock. "sortBlocks with side effects may not work right" + self size > 1 ifTrue: [self reSort]! - self size > 0 ifTrue: [self reSort]!

1 0

The Trunk: 51Deprecated-ul.30.mcz
by commits＠source.squeak.org 02 Jun '16

02 Jun '16

Levente Uzonyi uploaded a new version of 51Deprecated to project The Trunk: http://source.squeak.org/trunk/51Deprecated-ul.30.mcz ==================== Summary ==================== Name: 51Deprecated-ul.30 Author: ul Time: 2 June 2016, 8:28:00.97666 pm UUID: 2a30b91d-0870-412d-8c10-ee96c3c48065 Ancestors: 51Deprecated-mt.29 Deprecated the now unused methods of Heap. =============== Diff against 51Deprecated-mt.29 =============== Item was added: + ----- Method: Heap>>fullySort (in category '*51Deprecated') ----- + fullySort + "Fully sort the heap. + This method preserves the heap invariants and can thus be sent safely" + + self deprecated: 'Use #sort'. + self sort! Item was added: + ----- Method: Heap>>reSort (in category '*51Deprecated') ----- + reSort + "Resort the entire heap" + + self deprecated: 'This method should not be used anymore. Use #sortBlock: if you want to change the sort order.'. + tally <= 1 ifTrue: [ ^self ]. + (tally bitShift: -1) to: 1 by: -1 do: [ :index | self downHeap: index ]! Item was added: + ----- Method: Heap>>sorts:before: (in category '*51Deprecated') ----- + sorts: element1 before: element2 + "Return true if element1 should be sorted before element2. + This method defines the sort order in the receiver" + + self deprecated: 'This method has been inlined for performance.'. + ^sortBlock == nil + ifTrue:[element1 <= element2] + ifFalse:[sortBlock value: element1 value: element2].! Item was added: + ----- Method: Heap>>trim (in category '*51Deprecated') ----- + trim + "Remove any empty slots in the receiver." + + self deprecated: 'Use #compact'. + self compact! Item was added: + ----- Method: Heap>>updateObjectIndex: (in category '*51Deprecated') ----- + updateObjectIndex: index + "If indexUpdateBlock is not nil, notify the object at index of its new position in the heap array." + + self deprecated: 'This method has been inlined for performance.'. + indexUpdateBlock ifNotNil: [ + indexUpdateBlock value: (array at: index) value: index]!

1 0

Jump to page: