Squeak-dev June 2016

squeak-dev@lists.squeakfoundation.org

39 participants
202 discussions

The Trunk: Morphic-mt.1160.mcz
by commits＠source.squeak.org 04 Jun '16

04 Jun '16

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1160.mcz ==================== Summary ==================== Name: Morphic-mt.1160 Author: mt Time: 4 June 2016, 4:57:05.250373 pm UUID: 42f04455-424e-3545-9fe9-7d71a1e77383 Ancestors: Morphic-mt.1159 Moves automatic keyboard focus grabbing from KeyboardEvent into the Morph's key-stroke-handler. More robust when events bubble up again. No accidential focus grab anymore. =============== Diff against Morphic-mt.1159 =============== Item was changed: ----- Method: KeyboardEvent>>sentTo: (in category 'dispatching') ----- + sentTo: anObject + "Dispatch the receiver into anObject" + type == #keystroke ifTrue:[^anObject handleKeystroke: self]. + type == #keyDown ifTrue:[^anObject handleKeyDown: self]. + type == #keyUp ifTrue:[^anObject handleKeyUp: self]. + ^super sentTo: anObject.! - sentTo: aMorph - "Dispatch the receiver into the given morph or another one if keyboard focus changes." - - | receivingMorph | - receivingMorph := aMorph. - aMorph wantsKeyboardFocus ifTrue: [ - receivingMorph := (self hand newKeyboardFocus: aMorph) ifNil: [aMorph]]. - - type == #keystroke ifTrue:[^receivingMorph handleKeystroke: self]. - type == #keyDown ifTrue:[^receivingMorph handleKeyDown: self]. - type == #keyUp ifTrue:[^receivingMorph handleKeyUp: self]. - - ^super sentTo: receivingMorph! Item was changed: ----- Method: Morph>>handleKeystroke: (in category 'events-processing') ----- handleKeystroke: anEvent + "System level event handling. Has support for automatically grabbing the keyboard focus considering the keyboard focus delegate. See #newKeyboardFocus:" - "System level event handling." + | handler | + anEvent wasHandled ifTrue: [^ self]. + (self handlesKeyboard: anEvent) ifFalse: [^ self]. + + handler := self wantsKeyboardFocus + ifFalse: [self] + ifTrue: [(anEvent hand newKeyboardFocus: self) ifNil: [self]]. + anEvent handler: handler. + - anEvent wasHandled - ifTrue: [^ self]. - (self handlesKeyboard: anEvent) - ifFalse: [^ self]. anEvent wasHandled: true. + ^ handler keyStroke: anEvent! - ^ self keyStroke: anEvent! Item was changed: ----- Method: TextMorph>>handleKeystroke: (in category 'events-processing') ----- handleKeystroke: anEvent + "Overwritten to support tab-among-fields preference." - "System level event handling." | pasteUp | anEvent wasHandled ifTrue:[^self]. + (self handlesKeyboard: anEvent) ifFalse: [^ self]. + + anEvent keyCharacter = Character tab ifTrue: [ + "Allow passing through text morph inside pasteups" + (self wouldAcceptKeyboardFocusUponTab + and: [(pasteUp := self pasteUpMorphHandlingTabAmongFields) notNil]) + ifTrue: [ + anEvent wasHandled: true. + ^ pasteUp tabHitWithEvent: anEvent]]. + + ^ super handleKeystroke: anEvent! - (self handlesKeyboard: anEvent) ifFalse: [^ self]. - anEvent wasHandled: true. - anEvent keyCharacter = Character tab ifTrue: - ["Allow passing through text morph inside pasteups" - (self wouldAcceptKeyboardFocusUponTab and: - [(pasteUp := self pasteUpMorphHandlingTabAmongFields) notNil]) - ifTrue:[^ pasteUp tabHitWithEvent: anEvent]]. - self keyStroke: anEvent! Item was added: + ----- Method: TextMorph>>wantsKeyboardFocus (in category 'event handling') ----- + wantsKeyboardFocus + + ^ true!

1 0

The Trunk: Morphic-mt.1159.mcz
by commits＠source.squeak.org 04 Jun '16

04 Jun '16

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1159.mcz ==================== Summary ==================== Name: Morphic-mt.1159 Author: mt Time: 4 June 2016, 4:27:58.511373 pm UUID: 6304c02e-91f9-7840-94b6-008e68d296d2 Ancestors: Morphic-ul.1158 Fixes a small regression bug where freshly opened tool windows were not raised to the front. Was especially annoying when clicking some button in the code browsers. =============== Diff against Morphic-ul.1158 =============== Item was removed: - ----- Method: SystemWindow>>activateIfNeeded: (in category 'focus') ----- - activateIfNeeded: evt - "Make me the new key window if needed. Ensure that the focus look matches the keyboard focus." - - (self isKeyWindow not - and: [self class windowsRaiseOnClick - or: [self windowDecorations anySatisfy: [:morph | morph bounds containsPoint: evt position]] ]) - ifTrue: [self beKeyWindow] - ifFalse: [self updateFocusLookForKeyboardFocus].! Item was added: + ----- Method: SystemWindow>>beKeyWindowIfNeeded: (in category 'top window') ----- + beKeyWindowIfNeeded: evt + "Make me the new key window if needed. Ensure that the focus look matches the keyboard focus." + + (self isKeyWindow not + and: [self class windowsRaiseOnClick + or: [self windowDecorations anySatisfy: [:morph | morph bounds containsPoint: evt position]] ]) + ifTrue: [self beKeyWindow] + ifFalse: [self updateFocusLookForKeyboardFocus].! Item was changed: ----- Method: SystemWindow>>handleMouseDown: (in category 'events') ----- handleMouseDown: evt + self beKeyWindowIfNeeded: evt. - self activateIfNeeded: evt. ^ super handleMouseDown: evt! Item was changed: ----- Method: SystemWindow>>handleMouseUp: (in category 'events') ----- handleMouseUp: evt + "Some widgets grab the keyboard focus only on mouse-up. Hence, we need to update our looks." + + self updateFocusLookForKeyboardFocus. - - self activateIfNeeded: evt. ^ super handleMouseUp: evt!

1 0

How/when should tools grab the keyboard?
by marcel.taeumel 04 Jun '16

04 Jun '16

Hi, there. If you enable the following preferences. [x] mouseOverForKeyboardFocus [x] Windows' Contents Are Always Active You might be suprised that, for example, CMD+I opens an inspector but the keyboard focus is still in the current tool, maybe a workspace. Even if you disable "mouseOverForKeyboardFocus", the workspace will keep its keyboard focus. If you also disable "Window's Contents Are Always Active", at least the new window looks focused, although no widget insided grabbed the focus. Actually, no widget will have the keyboard focus then. So, I added focus grabbing for lists and text morphs. I used it for our list chooser: http://forum.world.st/The-Trunk-Morphic-mt-1157-mcz-tp4898664.html http://forum.world.st/The-Trunk-ToolBuilder-Morphic-mt-165-mcz-tp4898662.ht… It is quite simple. Models can say "self changed: #inputRequested with: #someSelector" and the correct widget will grab the keyboard. Easy for the list chooser because you want to type in a filter and hit return to choose. (Try it out in the code browser category list via CMD+F to find a class.) But what about other tools? System Browser Inspector Object Explorer ... Any idea which widgets should grab the keyboard focus if opened? The first list? The code widget? We can make different choices for each tool. Suggestions are welcome. This discussion affects general keyboard interaction in Squeak. Passionate mouse users will not notice any problem, though. ;o) Best, Marcel -- View this message in context: http://forum.world.st/How-when-should-tools-grab-the-keyboard-tp4898814.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

2 2

Sending HTML message with SecureSMTPClient
by Max Leske 04 Jun '16

04 Jun '16

Hi, I tried to answer this question on StackOverflow: http://stackoverflow.com/questions/37619992/squeak-securesmtpclient-to-send… Maybe someone here has a better explanation or can even fix the problem. Cheers, Max

1 0

Sanity check r.e. Files-tpr.156
by David T. Lewis 04 Jun '16

04 Jun '16

If StandardFileStream>>flush is meant to flush everything from the Squeak stream out of the VM and into the operating system buffers, whatever that might happen to mean, and if StandardFileStream>>primSync: is supposed to instruct the operating system to write everything that it knows about in its buffers out to some physical storage medium, whatever that might happen to mean, then I have to think that StandardFileStream>>sync should do a #flush prior to #primSync:, otherwise we might expect that things in the VM (C runtime stdio library) might still be unflushed, and that the #sync on the low level descriptor might apply to stale data. If we need to mix up the higher level stdio flush with the lowever level file descriptor sync (and yes, we apparently do need to do that), then we should probably be forcing a flush before primSync: StandardFileStream>>sync "Really, really, flush pending changes" ^self flush; primSync: fileID Does that sound right? Dave

2 2

The Trunk: Files-dtl.157.mcz
by commits＠source.squeak.org 04 Jun '16

04 Jun '16

David T. Lewis uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-dtl.157.mcz ==================== Summary ==================== Name: Files-dtl.157 Author: dtl Time: 3 June 2016, 11:15:12.62641 pm UUID: 66c41d04-aff3-414b-8e48-8db1829db0f6 Ancestors: Files-tpr.156 Flush before sync, unsure streams are flushed before sync to disk. =============== Diff against Files-tpr.156 =============== Item was changed: ----- Method: StandardFileStream>>sync (in category 'read, write, position') ----- sync "Really, really, flush pending changes" + ^self flush; primSync: fileID! - ^self primSync: fileID!

1 0

Daily Commit Log
by commits＠source.squeak.org 03 Jun '16

03 Jun '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-June/068176.html Name: Tools-cmm.703 Ancestors: Tools-eem.702 - Corrected menu hot-key indication for 'show category' -- it's (Y) not (C). - Upgraded it to 'toggle category selection', which is really useful given that browsers spawned via Cmd+b come with category automatically selected. =============================================

1 0

update 354 Tools-mt.684 introduces the Morphic bug...
by gettimothy 03 Jun '16

03 Jun '16

Hi all. This bug... https://timmydosmalltalk.files.wordpress.com/2016/05/squeak64x64debuggerpro… is introduced at update 354 when I merge in Tools-mt.684. My methodology was to "merge" and at every prompt see if the bug was introduced. I will poke around some more. cheers. tty

1 0

http://source.squeak.org/trunk/update-mt-354 is where the breakage occurs
by gettimothy 03 Jun '16

03 Jun '16

Hi all. I am tracking down that Morphic bug on my 64 linux spur install This bug https://timmydosmalltalk.files.wordpress.com/2016/05/squeak64x64debuggerpro… introduces itself on update-mt-354 If anybody has a hunch what/why it happens here, let me know. For debugging this... If I update up to 353, is there a way during the upgrade to 354 to look for suspects ? I am going to try the 'merge' stuff and see if prompts me for conflicts cheers. tty

1 0

`2 raisedTo: 100000000` crashes VM
by Fabio Niephaus 03 Jun '16

03 Jun '16

Hi all, We just found out that the VM crashes when trying to build very large integers. I'm not sure what could cause the problem... Best, Fabio

5 11

← Newer
1
...
14
15
16
17
18
19
20
21
Older →

Jump to page: