Squeak-dev May 2014

squeak-dev@lists.squeakfoundation.org

43 participants
219 discussions

The Trunk: Collections-dtl.568.mcz
by commits＠source.squeak.org 07 May '14

07 May '14

David T. Lewis uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-dtl.568.mcz ==================== Summary ==================== Name: Collections-dtl.568 Author: dtl Time: 5 May 2014, 12:39:30.026 pm UUID: a7bc6178-b9ac-4b87-bf97-478cc4927158 Ancestors: Collections-eem.567 Add a flush to WriteStream>>nextChunkPut: This is a workaround for a bug in the runtime library of some versions of Ubuntu. The symptom is that creation of a class comment for a class that previously had no comment leads to a file size error in the new RemoteStream that points to the class comment. Actual file size and contents of the changes file are not affected by this bug, and the error occurs when reading contents of the changes file immediately following the initial save, Flushing the stream after writing a chunk to the changes file prevents the problem. =============== Diff against Collections-eem.567 =============== Item was changed: ----- Method: WriteStream>>nextChunkPut: (in category 'fileIn/Out') ----- nextChunkPut: aString "Append the argument, aString, to the receiver, doubling embedded terminators." | i remainder terminator | terminator := $!!. remainder := aString. [(i := remainder indexOf: terminator) = 0] whileFalse: [self nextPutAll: (remainder copyFrom: 1 to: i). self nextPut: terminator. "double imbedded terminators" remainder := remainder copyFrom: i+1 to: remainder size]. self nextPutAll: remainder. aString includesUnifiedCharacter ifTrue: [ self nextPut: terminator. self nextPutAll: ']lang['. aString writeLeadingCharRunsOn: self. ]. self nextPut: terminator. + self flush. "workaround for clib runtime bug on some platforms, affecting initial class comment creation" !

1 0

The Trunk: Compression-eem.41.mcz
by commits＠source.squeak.org 07 May '14

07 May '14

Eliot Miranda uploaded a new version of Compression to project The Trunk: http://source.squeak.org/trunk/Compression-eem.41.mcz ==================== Summary ==================== Name: Compression-eem.41 Author: eem Time: 6 May 2014, 3:03:07.032 pm UUID: 331a0bb5-cbf5-4a72-9b2b-f4a5ab92e6c2 Ancestors: Compression-fbs.40 Fix a bug in [Fast]InflateStream, thanks to Yoshiki Oshima: This can be a nitpick of the year, but there is a bug in InflateStream>>decompressBlock:with: There is a part that reads (toward the end): ------------------------ collection replaceFrom: readLimit+1 to: readLimit + length + 1 with: collection startingAt: readLimit - distance + 1. ------------------------ but here we want to replace "length" bytes in collection, as opposed to length + 1 bytes, so it has to say: ------------------------ collection replaceFrom: readLimit+1 to: readLimit + length with: collection startingAt: readLimit - distance + 1. ------------------------ (So is the non-primitive version in FastInflateStream.) The reason it does not matter is that replaceFrom:to:with:startingAt: does not care about the source and destination being the same and overlap between them. Even when the above bug puts one extra bytes in collection temporarily, the extra byte will be wiped out in the next iteration of the loop surrounding it. However, if you try to port this to a language that does the "right thing" when there is an overlap, it manifests as a bug. -- Yoshiki P.S. It was a "rare" delight to point out a bug in Andreas' code^^; We miss you. =============== Diff against Compression-fbs.40 =============== Item was changed: ----- Method: FastInflateStream>>decompressBlock:with: (in category 'inflating') ----- decompressBlock: llTable with: dTable "Process the compressed data in the block. llTable is the huffman table for literal/length codes and dTable is the huffman table for distance codes." | value extra length distance oldPos oldBits oldBitPos | <primitive: 'primitiveInflateDecompressBlock' module: 'ZipPlugin'> [readLimit < collection size and:[sourcePos <= sourceLimit]] whileTrue:[ "Back up stuff if we're running out of space" oldBits := bitBuf. oldBitPos := bitPos. oldPos := sourcePos. value := self decodeValueFrom: llTable. value < 256 ifTrue:[ "A literal" collection byteAt: (readLimit := readLimit + 1) put: value. ] ifFalse:["length/distance or end of block" value = 256 ifTrue:["End of block" state := state bitAnd: StateNoMoreData. ^self]. "Compute the actual length value (including possible extra bits)" extra := (value bitShift: -16) - 1. length := value bitAnd: 16rFFFF. extra > 0 ifTrue:[length := length + (self nextBits: extra)]. "Compute the distance value" value := self decodeValueFrom: dTable. extra := (value bitShift: -16). distance := value bitAnd: 16rFFFF. extra > 0 ifTrue:[distance := distance + (self nextBits: extra)]. (readLimit + length >= collection size) ifTrue:[ bitBuf := oldBits. bitPos := oldBitPos. sourcePos := oldPos. ^self]. collection replaceFrom: readLimit+1 + to: readLimit + length - to: readLimit + length + 1 with: collection startingAt: readLimit - distance + 1. readLimit := readLimit + length. ]. ].! Item was changed: ----- Method: InflateStream>>decompressBlock:with: (in category 'inflating') ----- decompressBlock: llTable with: dTable "Process the compressed data in the block. llTable is the huffman table for literal/length codes and dTable is the huffman table for distance codes." | value extra length distance oldPos oldBits oldBitPos | [readLimit < collection size and:[sourcePos <= sourceLimit]] whileTrue:[ "Back up stuff if we're running out of space" oldBits := bitBuf. oldBitPos := bitPos. oldPos := sourcePos. value := self decodeValueFrom: llTable. value < 256 ifTrue:[ "A literal" collection byteAt: (readLimit := readLimit + 1) put: value. ] ifFalse:["length/distance or end of block" value = 256 ifTrue:["End of block" state := state bitAnd: StateNoMoreData. ^self]. "Compute the actual length value (including possible extra bits)" extra := #(0 0 0 0 0 0 0 0 1 1 1 1 2 2 2 2 3 3 3 3 4 4 4 4 5 5 5 5 0) at: value - 256. length := #(3 4 5 6 7 8 9 10 11 13 15 17 19 23 27 31 35 43 51 59 67 83 99 115 131 163 195 227 258) at: value - 256. extra > 0 ifTrue:[length := length + (self nextBits: extra)]. "Compute the distance value" value := self decodeValueFrom: dTable. extra := #(0 0 0 0 1 1 2 2 3 3 4 4 5 5 6 6 7 7 8 8 9 9 10 10 11 11 12 12 13 13) at: value+1. distance := #(1 2 3 4 5 7 9 13 17 25 33 49 65 97 129 193 257 385 513 769 1025 1537 2049 3073 4097 6145 8193 12289 16385 24577) at: value+1. extra > 0 ifTrue:[distance := distance + (self nextBits: extra)]. (readLimit + length >= collection size) ifTrue:[ bitBuf := oldBits. bitPos := oldBitPos. sourcePos := oldPos. ^self]. collection replaceFrom: readLimit+1 + to: readLimit + length - to: readLimit + length + 1 with: collection startingAt: readLimit - distance + 1. readLimit := readLimit + length. ]. ].!

1 0

Re: [squeak-dev] Squeak 4.5: Environments-cwp.47.mcz
by Tobias Pape 06 May '14

06 May '14

Woulnd't it be better to make that a dynamic variable? Because it is used as such? I think this would save some stackwalking. (why do I think so? I looks too similar to Seaside’s use of Dynamic variables) Best -Tobias On 06.05.2014, at 17:54, commits(a)source.squeak.org wrote: > Chris Muller uploaded a new version of Environments to project Squeak 4.5: > http://source.squeak.org/squeak45/Environments-cwp.47.mcz > > ==================== Summary ==================== > > Name: Environments-cwp.47 > Author: cwp > Time: 22 March 2014, 7:53:17.666 pm > UUID: 12e68b45-ec35-4eff-985b-8008d6f03339 > Ancestors: Environments-ul.46 > > Rename EnvironmentRequest to CurrentEnvironment and use it to implement Environment class>>current. > > =============== Diff against Environments-ul.46 =============== > > Item was added: > + Notification subclass: #CurrentEnvironment > + instanceVariableNames: '' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'Environments-Loading'! > > Item was added: > + ----- Method: Environment class>>current (in category 'accessing') ----- > + current > + ^ CurrentEnvironment signal ifNil: [self default]! > > Item was changed: > ----- Method: EnvironmentLoader>>evaluate: (in category 'as yet unclassified') ----- > evaluate: chunk > ^ [Compiler evaluate: chunk environment: environment] > + on: CurrentEnvironment > - on: EnvironmentRequest > do: [:req | req resume: environment]! > > Item was changed: > ----- Method: EnvironmentLoader>>evaluate:logged: (in category 'as yet unclassified') ----- > evaluate: chunk logged: aBoolean > ^ [Compiler evaluate: chunk environment: environment logged: aBoolean] > + on: CurrentEnvironment > - on: EnvironmentRequest > do: [:req | req resume: environment]! > > Item was removed: > - Notification subclass: #EnvironmentRequest > - instanceVariableNames: '' > - classVariableNames: '' > - poolDictionaries: '' > - category: 'Environments-Loading'! > >

2 2

The Trunk: Morphic-eem.724.mcz
by commits＠source.squeak.org 06 May '14

06 May '14

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.724.mcz ==================== Summary ==================== Name: Morphic-eem.724 Author: eem Time: 6 May 2014, 2:08:42.514 pm UUID: ac55df18-9658-41ea-9c84-8a0e38a3064a Ancestors: Morphic-eem.723 Fix displaying the project name in the middle of the docking bar. =============== Diff against Morphic-eem.723 =============== Item was changed: ----- Method: TheWorldMainDockingBar>>fillDockingBar: (in category 'construction') ----- fillDockingBar: aDockingBar "Private - fill the given docking bar" aDockingBar addSpace: 6. self menusOn: aDockingBar. aDockingBar addSpacer. + self projectNameOn: aDockingBar. + aDockingBar addSpacer. self rightSideOn: aDockingBar. aDockingBar setProperty: #mainDockingBarTimeStamp toValue: self class timeStamp.! Item was changed: ----- Method: TheWorldMainDockingBar>>menusOn: (in category 'construction') ----- menusOn: aDockingBar self squeakMenuOn: aDockingBar; projectsMenuOn: aDockingBar; toolsMenuOn: aDockingBar; appsMenuOn: aDockingBar; extrasMenuOn: aDockingBar; windowsMenuOn: aDockingBar; + helpMenuOn: aDockingBar! - helpMenuOn: aDockingBar.. - aDockingBar addSpacer. - self projectNameOn: aDockingBar. - aDockingBar addSpacer! Item was changed: ----- Method: TheWorldMainDockingBar>>projectNameOn: (in category 'right side') ----- projectNameOn: aDockingBar | morph | morph := StringMorph contents: ''. morph setProperty: #projectNameMorph toValue: #projectNameMorph. + aDockingBar addMorphBack: morph. + self labelIfNeeded: aDockingBar! - aDockingBar addMorphBack: morph! Item was changed: ----- Method: TheWorldMainDockingBar>>updateIfNeeded: (in category 'private') ----- updateIfNeeded: aDockingBar "Update the given docking bar if needed" | timeStamp | timeStamp := aDockingBar valueOfProperty: #mainDockingBarTimeStamp ifAbsent: []. + timeStamp ~= self class timeStamp + ifTrue: + [aDockingBar + release; + removeAllMorphs. + self fillDockingBar: aDockingBar] + ifFalse: + [self labelIfNeeded: aDockingBar]! - timeStamp ~= self class timeStamp ifTrue: - [aDockingBar - release; - removeAllMorphs. - self fillDockingBar: aDockingBar]!

1 0

Is it just me or is class comment editing totally broken in 4.5?
by David T. Lewis 06 May '14

06 May '14

Create a new class, attempt to edit the class comment ==> Error: RemoteString past end of file Surely I cannot be the first person to have edited a class comment in the last month or so ... I hope. Dave

11 27

How to find Undeclareds?
by Chris Muller 06 May '14

06 May '14

After updating a Squeak4.5-13680 image from the 'squeak45' repository, I'm left with one "EnvironmentRequest" in Undeclared. What is the best way to track this down and remove it?

2 1

Squeak 4.5: Environments-cwp.50.mcz
by commits＠source.squeak.org 06 May '14

06 May '14

Chris Muller uploaded a new version of Environments to project Squeak 4.5: http://source.squeak.org/squeak45/Environments-cwp.50.mcz ==================== Summary ==================== Name: Environments-cwp.50 Author: cwp Time: 31 March 2014, 1:26:54.758 pm UUID: c5bc1620-6918-4480-84b2-b3a2c167e534 Ancestors: Environments-cwp.49 Create a new binding when renaming classes. =============== Diff against Environments-cwp.49 =============== Item was changed: ----- Method: Environment>>renameClass:from:to: (in category 'classes and traits') ----- renameClass: aClass from: oldName to: newName "Rename the class, aClass, to have the title newName." | binding category | category := self organization categoryOfElement: oldName. self organization classify: newName under: category suppressIfDefault: true. self organization removeElement: oldName. + binding := self declarationOf: oldName. - binding := self associationAt: oldName. declarations removeKey: oldName. self binding: binding removedFrom: self. + binding := newName => aClass. - binding key: newName. declarations add: binding. self binding: binding addedTo: self. Smalltalk renamedClass: aClass from: oldName to: newName. SystemChangeNotifier uniqueInstance classRenamed: aClass from: oldName to: newName inCategory: category!

1 0

Squeak 4.5: Environments-cwp.49.mcz
by commits＠source.squeak.org 06 May '14

06 May '14

Chris Muller uploaded a new version of Environments to project Squeak 4.5: http://source.squeak.org/squeak45/Environments-cwp.49.mcz ==================== Summary ==================== Name: Environments-cwp.49 Author: cwp Time: 29 March 2014, 9:51:18.227 pm UUID: 5f13ecd1-6908-4d47-ae16-deb2308cd0dc Ancestors: Environments-cwp.48 Make sure globals are properly destroyed along with their environment. =============== Diff against Environments-cwp.48 =============== Item was changed: + ----- Method: BindingPolicy>>environment (in category 'accessing') ----- - ----- Method: BindingPolicy>>environment (in category 'as yet unclassified') ----- environment ^ environment! Item was changed: ----- Method: Environment>>destroy (in category 'initialize-release') ----- destroy self allClasses do: [:ea | ea removeFromSystem]. + declarations keys do: [:ea | self unbind: ea]. policies do: [:ea | ea removeObserver: self]. observers do: [:ea | ea stopObserving: self].! Item was changed: ----- Method: Environment>>exportSelf (in category 'configuring') ----- exportSelf | policy | policy := BindingPolicy environment: self policy: (AllNamePolicy new) addSelector: #notifyObserversOfBindingAdded: + removeSelector: #notifyObserversOfBindingRemoved:. - removeSelector: #notifyObserversOfBindingAdded:. policies := policies copyWith: policy! Item was changed: ----- Method: Environment>>forgetClass:logged: (in category 'classes and traits') ----- forgetClass: aClass logged: aBool + (self hasBindingOf: aClass name) ifFalse: [ ^ self ]. - | binding | - self flag: #review. - "The class might not bound to its name" - aBool ifTrue: [SystemChangeNotifier uniqueInstance classRemoved: aClass fromCategory: aClass category]. + self organization removeElement: aClass name. + Smalltalk removeFromStartUpList: aClass. + Smalltalk removeFromShutDownList: aClass. + self unbind: aClass name! - - binding := declarations bindingOf: aClass name. - binding ifNotNil: - [self organization removeElement: aClass name. - Smalltalk removeFromStartUpList: aClass. - Smalltalk removeFromShutDownList: aClass. - - undeclared declare: aClass name from: declarations. - declarations removeKey: aClass name ifAbsent: []. - [undeclared at: aClass name put: nil] - on: AttemptToWriteReadOnlyGlobal - do: [:n | n resume: true]. - self binding: binding removedFrom: self] - ! Item was added: + ----- Method: Environment>>hasBindingOf: (in category 'binding') ----- + hasBindingOf: aSymbol + ^ declarations includesKey: aSymbol! Item was changed: ----- Method: Environment>>hideBinding: (in category 'binding') ----- hideBinding: aBinding + self undeclare: aBinding key from: bindings! - bindings removeKey: aBinding key! Item was added: + ----- Method: Environment>>unbind: (in category 'binding') ----- + unbind: aSymbol + | binding | + binding := declarations bindingOf: aSymbol ifAbsent: [^ self]. + undeclared declare: aSymbol from: declarations. + declarations removeKey: aSymbol ifAbsent: [ ]. + [ undeclared at: aSymbol put: nil ] + on: AttemptToWriteReadOnlyGlobal + do: [ :n | n resume: true ]. + self binding: binding removedFrom: self!

1 0

Squeak 4.5: Environments-cwp.48.mcz
by commits＠source.squeak.org 06 May '14

06 May '14

Chris Muller uploaded a new version of Environments to project Squeak 4.5: http://source.squeak.org/squeak45/Environments-cwp.48.mcz ==================== Summary ==================== Name: Environments-cwp.48 Author: cwp Time: 29 March 2014, 12:42:00.257 pm UUID: 59039bca-7da2-4495-a5d8-8e962783c828 Ancestors: Environments-cwp.47 Clean up observers when destroying an environment. =============== Diff against Environments-cwp.47 =============== Item was changed: Object subclass: #BindingPolicy + instanceVariableNames: 'policy environment addSelector removeSelector' - instanceVariableNames: 'namespace policy next environment addSelector removeSelector' classVariableNames: '' poolDictionaries: '' category: 'Environments-Policies'! Item was added: + ----- Method: BindingPolicy>>environment (in category 'as yet unclassified') ----- + environment + ^ environment! Item was added: + ----- Method: BindingPolicy>>removeObserver: (in category 'initialize-release') ----- + removeObserver: anEnvironment + environment removeObserver: anEnvironment ! Item was changed: + ----- Method: Environment>>addObserver: (in category 'observing') ----- - ----- Method: Environment>>addObserver: (in category 'accessing') ----- addObserver: anObject observers add: anObject! Item was added: + ----- Method: Environment>>declarations (in category 'declaring') ----- + declarations + ^ Array streamContents: + [:out | declarations associationsDo: + [:ea | out nextPut: ea]]! Item was changed: ----- Method: Environment>>destroy (in category 'initialize-release') ----- destroy + + self allClasses do: [:ea | ea removeFromSystem]. + policies do: [:ea | ea removeObserver: self]. + observers do: [:ea | ea stopObserving: self].! - self allClasses do: [:ea | ea removeFromSystem]! Item was changed: + ----- Method: Environment>>isUndeclared: (in category 'declaring') ----- - ----- Method: Environment>>isUndeclared: (in category 'undeclared') ----- isUndeclared: aSymbol ^ undeclared includesKey: aSymbol! Item was changed: + ----- Method: Environment>>purgeUndeclared (in category 'declaring') ----- - ----- Method: Environment>>purgeUndeclared (in category 'undeclared') ----- purgeUndeclared undeclared removeUnreferencedKeys! Item was changed: + ----- Method: Environment>>removeObserver: (in category 'observing') ----- - ----- Method: Environment>>removeObserver: (in category 'accessing') ----- removeObserver: anObject + observers remove: anObject ifAbsent: []! - observers remove: anObject! Item was added: + ----- Method: Environment>>stopObserving: (in category 'observing') ----- + stopObserving: anEnvironment + policies := policies reject: [:ea | ea environment == anEnvironment].! Item was changed: + ----- Method: Environment>>undeclare: (in category 'declaring') ----- - ----- Method: Environment>>undeclare: (in category 'undeclared') ----- undeclare: aSymbol ^ (undeclared bindingOf: aSymbol) ifNil: [undeclared add: aSymbol => nil]! Item was changed: + ----- Method: Environment>>undeclare:from: (in category 'declaring') ----- - ----- Method: Environment>>undeclare:from: (in category 'undeclared') ----- undeclare: aSymbol from: aNamespace | binding | binding := self undeclare: aSymbol. (aNamespace bindingOf: aSymbol) ifNotNil: [:old | aNamespace removeKey: aSymbol. old becomeForward: binding]. ^ binding!

1 0

Squeak 4.5: Environments-cwp.47.mcz
by commits＠source.squeak.org 06 May '14

06 May '14

Chris Muller uploaded a new version of Environments to project Squeak 4.5: http://source.squeak.org/squeak45/Environments-cwp.47.mcz ==================== Summary ==================== Name: Environments-cwp.47 Author: cwp Time: 22 March 2014, 7:53:17.666 pm UUID: 12e68b45-ec35-4eff-985b-8008d6f03339 Ancestors: Environments-ul.46 Rename EnvironmentRequest to CurrentEnvironment and use it to implement Environment class>>current. =============== Diff against Environments-ul.46 =============== Item was added: + Notification subclass: #CurrentEnvironment + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Environments-Loading'! Item was added: + ----- Method: Environment class>>current (in category 'accessing') ----- + current + ^ CurrentEnvironment signal ifNil: [self default]! Item was changed: ----- Method: EnvironmentLoader>>evaluate: (in category 'as yet unclassified') ----- evaluate: chunk ^ [Compiler evaluate: chunk environment: environment] + on: CurrentEnvironment - on: EnvironmentRequest do: [:req | req resume: environment]! Item was changed: ----- Method: EnvironmentLoader>>evaluate:logged: (in category 'as yet unclassified') ----- evaluate: chunk logged: aBoolean ^ [Compiler evaluate: chunk environment: environment logged: aBoolean] + on: CurrentEnvironment - on: EnvironmentRequest do: [:req | req resume: environment]! Item was removed: - Notification subclass: #EnvironmentRequest - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: 'Environments-Loading'!

1 0

Jump to page: