Squeak-dev December 2014

squeak-dev@lists.squeakfoundation.org

35 participants
112 discussions

Does Monticello try to install shared pools before methods using them?
by Craig Latta 10 Dec '14

10 Dec '14

Hoi-- I'm attempting to create a Monticello package which provides a shared pool (as a subclass of SharedPool) and methods which use its variables. On installation, does Monticello try to ensure that a pool is installed before methods which use it? When I install the package in a fresh system, I get messages on the Transcript complaining that shared variables are undefined. Is there some way one fiddles with the writing process, or with the package after it is written, to avoid ordering problems? thanks! -C -- Craig Latta netjam.org +31 6 2757 7177 (SMS ok) + 1 415 287 3547 (no SMS)

5 11

Daily Commit Log
by commits＠source.squeak.org 09 Dec '14

09 Dec '14

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2014-December/007394.h… Name: Balloon-bf.25 Ancestors: Balloon-nice.24 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007395.h… Name: Collections-bf.588 Ancestors: Collections-ul.587 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007396.h… Name: CollectionsTests-bf.225 Ancestors: CollectionsTests-eem.224 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007397.h… Name: Compression-bf.46 Ancestors: Compression-nice.45 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007398.h… Name: EToys-bf.119 Ancestors: EToys-dtl.118 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007399.h… Name: Files-bf.142 Ancestors: Files-ul.141 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007400.h… Name: Graphics-bf.303 Ancestors: Graphics-topa.302 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007401.h… Name: Kernel-bf.890 Ancestors: Kernel-eem.889 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007402.h… Name: KernelTests-bf.284 Ancestors: KernelTests-eem.283 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007403.h… Name: Monticello-bf.607 Ancestors: Monticello-eem.606 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007404.h… Name: Morphic-bf.753 Ancestors: Morphic-eem.752 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007405.h… Name: MorphicExtras-bf.154 Ancestors: MorphicExtras-nice.153 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007406.h… Name: Nebraska-bf.39 Ancestors: Nebraska-ul.38 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007407.h… Name: Network-bf.157 Ancestors: Network-cmm.156 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007408.h… Name: SMBase-bf.133 Ancestors: SMBase-nice.132 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007409.h… Name: SMLoader-bf.80 Ancestors: SMLoader-fbs.79 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007410.h… Name: ST80-bf.175 Ancestors: ST80-nice.174 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007411.h… Name: ST80Tools-bf.4 Ancestors: ST80Tools-eem.3 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007412.h… Name: SUnit-bf.101 Ancestors: SUnit-fbs.100 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007413.h… Name: Sound-bf.42 Ancestors: Sound-ul.41 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007414.h… Name: Tests-bf.305 Ancestors: Tests-ul.304 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007415.h… Name: ToolBuilder-Kernel-bf.64 Ancestors: ToolBuilder-Kernel-eem.63 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007416.h… Name: Protocols-bf.47 Ancestors: Protocols-nice.46 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007417.h… Name: Tools-bf.531 Ancestors: Tools-eem.530 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007418.h… Name: ToolsTests-bf.70 Ancestors: ToolsTests-nice.69 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007419.h… Name: TrueType-bf.29 Ancestors: TrueType-nice.28 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007420.h… Name: XML-Parser-bf.37 Ancestors: XML-Parser-fbs.36 Restore timestamps lost in assignment conversion. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007421.h… Name: System-bf.692 Ancestors: System-eem.691 Restore timestamps lost in assignment conversion. =============================================

1 0

New Cog VMs available
by Eliot Miranda 08 Dec '14

08 Dec '14

... at http://www.mirandabanda.org/files/Cog/VM/VM.r3163/. CogVM binaries as per VMMaker.oscog-eem.972/r3163 Fix a devilishly tricky bug with 32-bit Spur and PICs in the Cogit. In 32-bit Spur only zero is a valid cache tag, that for Characters, due to SmallIntegers having both 2r11 and 2r01 as valid tags. The cache check prolog collapses these down onto 1 by anding with 1 and hence collapses Character's 2r10 to 0. The cache tag is also tested in the PIC abort routine to distinguish between an MNU abort and an interpret abort. A PIC MNU entry jumps to code that first zeros the cache tag (held in ClassReg) before calling the abort routine, which tests ClassReg and selects the relevant abort processing. Hence in 32-bit Spur if a send site is linked for Character and later extended to a PIC with an interpret case, that interpret case will instead invoke MNU processing. This is rare; first there needs to be a send to a CHaracter, then a send to something else which binds to something that must be interpreted. Ouch. The fix is simple; if a send site that was linked with a zero cache tag (which can only happen in 32-bit Spur) link to an open PIC instead of to a closed PIC, or in the case of an MNU do not link. Add a debug lookup routine that only looks up (and follows forwarding pointers). Add a -breakmnu vm argument that calls warning on an mnu of a specific selector. Fix SmartSyntaxPlugin code generation for Spur of - asOop: old code assumed 4 byte oops & headers - Unsigned old code assumed 32-bit oops Affects AsyncFilePlugin, BochsIA32Plugin & FT2Plgin. Avoid duplication of effort in special selector send forwarding fault handling. Improve stack trace printing for Newspeak and Glue by providing something that assumes the penultimate literal is the selector or an AdditionalMethodState-like thing containing it. Reimplement primitiveCopyObject to work for both pointer and bits objects. This to support a good Object>>clone for Spur. Fix Spur's isWordsOrBytes[NonImm]:. Old code answered true for CompiledMethods. -- best, Eliot

3 4

4.5 compiler
by Trygve Reenskaug 08 Dec '14

08 Dec '14

I'm still trying to port my BabyIDE (my DCI programming environment) from 3.10.2 to 4.5. The stumbling block is that my 3.10.2 compiler hacks do not work in 4.5. I posted a request for help on 2014.11.29. For some reason, that message got garbled and was hard to understand. Since then, I have isolated the problem into the attached files that reconstruct the problem independently of the rest of BabyIDE. *The files should be filed in in sequence: **/RoleMethods.st, /**/BB1RoleNode-3.5.st, /*/*Encoder-#BabyIDE-4.5.st.* / /RoleMethods.st / is the class with the method that shall be compiled: |RoleMethods>>transferFrom || || self increase: AMOUNT. || || ^true| An extension makes the Encoder understand that |AMOUNT |is a very special variable and adds it as a |BB1RoleNode |to the parse tree: / // BB1RoleNode-3.5.st// // Encoder-#BabyIDE-4.5.st/ |BB1RoleNode |is a new |VariableNode.| It acts a kind of preprocessor that translates the reference to AMOUNT into a runtime lookup. This lookup can be seen by decompiling the CompiledMethod. This is what makes DCI master the runtime. The 3.10.2 versions work in 3.10.2. The 4.5 versions compile the source with a couple of old halts. (May be they are warnings because the BB1RoleNode is a mixture of VariableNode and MessageNode). The result after proceeds is a CompiledMethod. It's faulty and cannot be decompiled. The decompiled code should read |RoleMethods>>transferFrom|| || self increase: (BB1ContextStack playerForRole: #AMOUNT)|| || ^true| I hope the above is sufficient for you to find my bug(s). Thanks --Trygve

2 2

Sound playing can break in odd manner
by tim Rowledge 08 Dec '14

08 Dec '14

(Stephane added explicitly since the code has his initials) This is bit puzzling. I’ve just had a case of sound failing on a Pi that looks like it shouldn’t be possible. So far the best I can up with is a thread-safety violation. The stacktrace shows that it was the FMSound>organ1 sound being played and that whilst handling #doControl (method that deals with the envelopes) we had a case where VolumeEnvelope>computeSlopeAtMSecs: hit a problem right at the end - nextRecomputeTime := (mSecs + mSecsForChange) min: loopEndMSecs. At this point the loopEndMSecs value was nil, which isn’t going to make for a happy execution of #min:. The only method I can find that sets loopEndMSecs is Envelope>sustainEnd: and it does A Funny Thing. Initially the ivar is set to nil, then some work is done, including #computeValueAtMSecs: before the ivar is actually set to the value needed. Looking at Enveleope>computeValueAtMSecs: it seems that loopEndMSecs gets set to nil in order to fake out the testing for ‘decay phase’ at the beginning of the code. Now it happens that #sustainEnd: is only meaningfully used by Envelope>duration: and that happens to be used by AbstractSound>stopGracefully which in turn is used by the Scratch stuff to stop a sound. So my suspicion is that we just managed to hit a tick where the SoundPlayer was triggered to Do Its Thing precisely where #sustainEnd: was between setting loopEndMSecs to nil and setting it ‘correctly’. Not likely to happen terribly often but I think we have evidence that happen it can. I know we’ve got a lot of stuff in the image that is not thread safe but SoundPlayer is one of the cases that has a pretty good chance of being hit. I’m honestly not sure what the best way to fix this would be; probably one should argue that a sound being played and simultaneously altered requires that semaphores get involved. I can also see that probably a fairly simple change to Envelope>computeValueAtMSecs: to add a flag for ‘ignore decay phase code’ would solve this particular case. What do you think Steph? Anyone? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Common sense – so rare it’s a goddam superpower

7 12

Re: [squeak-dev] The Trunk: XML-Parser-bf.37.mcz
by Chris Muller 08 Dec '14

08 Dec '14

Woo hooo! THANK YOU Bert! This totally the right thing to do. On Sun, Dec 7, 2014 at 7:16 PM, <commits(a)source.squeak.org> wrote: > Bert Freudenberg uploaded a new version of XML-Parser to project The Trunk: > http://source.squeak.org/trunk/XML-Parser-bf.37.mcz > > ==================== Summary ==================== > > Name: XML-Parser-bf.37 > Author: bf > Time: 8 December 2014, 2:16:57.135 am > UUID: 47f3a2f8-de17-43b8-96f8-beef7a7c8200 > Ancestors: XML-Parser-fbs.36 > > Restore timestamps lost in assignment conversion. > > =============== Diff against XML-Parser-fbs.36 =============== > > Item was changed: > ----- Method: XMLDOMParser>>documentAttributes: (in category 'content') ----- > documentAttributes: attributeList > self document version: (attributeList at: 'version' ifAbsent: [nil]). > self document encoding: (attributeList at: 'encoding' ifAbsent: [nil]). > self document requiredMarkup: (attributeList at: 'requiredMarkup' ifAbsent: [nil]). > ! > > Item was changed: > ----- Method: XMLWriter>>xmlDeclaration:encoding: (in category 'writing xml') ----- > xmlDeclaration: versionString encoding: encodingString > self canonical > ifFalse: [ > self > startPI: 'xml'; > attribute: 'version' value: versionString; > attribute: 'encoding' value: encodingString; > endPI. > self stream flush]! > >

1 0

The Trunk: System-bf.692.mcz
by commits＠source.squeak.org 08 Dec '14

08 Dec '14

Bert Freudenberg uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-bf.692.mcz ==================== Summary ==================== Name: System-bf.692 Author: bf Time: 8 December 2014, 2:22:24.792 am UUID: 2531e010-26d8-49d0-83c7-e81609411c3b Ancestors: System-eem.691 Restore timestamps lost in assignment conversion. =============== Diff against System-eem.691 =============== Item was changed: ----- Method: FileDirectory class>>openChanges:forImage: (in category '*System-Files') ----- openChanges: changesName forImage: imageName "find the changes file by looking in a) the directory derived from the image name b) the DefaultDirectory (which will normally be the directory derived from the image name or the SecurityManager's choice) If an old file is not found in either place, check for a read-only file in the same places. If that fails, return nil" | changes fd | "look for the changes file or an alias to it in the image directory" fd := FileDirectory on: (FileDirectory dirPathFor: imageName). (fd fileExists: changesName) ifTrue: [changes := fd oldFileNamed: changesName]. changes ifNotNil:[^changes]. "look for the changes in the default directory" fd := DefaultDirectory. (fd fileExists: changesName) ifTrue: [changes := fd oldFileNamed: changesName]. changes ifNotNil:[^changes]. "look for read-only changes in the image directory" fd := FileDirectory on: (FileDirectory dirPathFor: imageName). (fd fileExists: changesName) ifTrue: [changes := fd readOnlyFileNamed: changesName]. changes ifNotNil:[^changes]. "look for read-only changes in the default directory" fd := DefaultDirectory. (fd fileExists: changesName) ifTrue: [changes := fd readOnlyFileNamed: changesName]. "this may be nil if the last try above failed to open a file" ^changes ! Item was changed: ----- Method: FileDirectory class>>setDefaultDirectory: (in category '*System-Files') ----- setDefaultDirectory: directoryName "Initialize the default directory to the directory supplied. This method is called when the image starts up." | dirName | DirectoryClass := self activeDirectoryClass. dirName := (FilePath pathName: directoryName) asSqueakPathName. [dirName endsWith: self slash] whileTrue:[ dirName := dirName copyFrom: 1 to: dirName size - self slash size. ]. DefaultDirectory := self on: dirName.! Item was changed: ----- Method: FileStream class>>fileIn: (in category '*System-Files') ----- fileIn: fullName "File in the entire contents of the file specified by the name provided" | ff | fullName ifNil: [^ Beeper beep]. ff := self readOnlyFileNamed: (GZipReadStream uncompressedFileName: fullName). ff fileIn. ! Item was changed: ----- Method: ImageSegment class>>folder (in category 'fileIn/Out') ----- folder | im | "Full path name of segments folder. Be sure to duplicate and rename the folder when you duplicate and rename an image. Is $_ legal in all file systems?" im := Smalltalk imageName. ^ (im copyFrom: 1 to: im size - 6 "'.image' size"), '_segs'! Item was changed: ----- Method: NaturalLanguageTranslator>>localeID (in category 'accessing') ----- localeID ^id! Item was changed: ----- Method: NaturalLanguageTranslator>>printOn: (in category 'printing') ----- printOn: aStream aStream nextPutAll: self class name; nextPut: $(; print: self localeID; nextPut: $)! Item was changed: ----- Method: PrettyTextDiffBuilder class>>from:to:inClass: (in category 'instance creation') ----- from: srcString to: dstString inClass: srcClass ^ (self new sourceClass: srcClass) from: srcString to: dstString ! Item was changed: ----- Method: PrettyTextDiffBuilder>>sourceClass: (in category 'initialize') ----- sourceClass: aClass sourceClass := aClass.! Item was changed: ----- Method: WeakRegistry>>species (in category 'private') ----- species ^Set!

1 0

The Trunk: XML-Parser-bf.37.mcz
by commits＠source.squeak.org 08 Dec '14

08 Dec '14

Bert Freudenberg uploaded a new version of XML-Parser to project The Trunk: http://source.squeak.org/trunk/XML-Parser-bf.37.mcz ==================== Summary ==================== Name: XML-Parser-bf.37 Author: bf Time: 8 December 2014, 2:16:57.135 am UUID: 47f3a2f8-de17-43b8-96f8-beef7a7c8200 Ancestors: XML-Parser-fbs.36 Restore timestamps lost in assignment conversion. =============== Diff against XML-Parser-fbs.36 =============== Item was changed: ----- Method: XMLDOMParser>>documentAttributes: (in category 'content') ----- documentAttributes: attributeList self document version: (attributeList at: 'version' ifAbsent: [nil]). self document encoding: (attributeList at: 'encoding' ifAbsent: [nil]). self document requiredMarkup: (attributeList at: 'requiredMarkup' ifAbsent: [nil]). ! Item was changed: ----- Method: XMLWriter>>xmlDeclaration:encoding: (in category 'writing xml') ----- xmlDeclaration: versionString encoding: encodingString self canonical ifFalse: [ self startPI: 'xml'; attribute: 'version' value: versionString; attribute: 'encoding' value: encodingString; endPI. self stream flush]!

1 0

The Trunk: TrueType-bf.29.mcz
by commits＠source.squeak.org 08 Dec '14

08 Dec '14

Bert Freudenberg uploaded a new version of TrueType to project The Trunk: http://source.squeak.org/trunk/TrueType-bf.29.mcz ==================== Summary ==================== Name: TrueType-bf.29 Author: bf Time: 8 December 2014, 2:15:45.524 am UUID: 87a9ae42-b3df-43c6-9ded-a51e5af8ef3a Ancestors: TrueType-nice.28 Restore timestamps lost in assignment conversion. =============== Diff against TrueType-nice.28 =============== Item was changed: ----- Method: TTCFont>>lineGrid (in category 'accessing') ----- lineGrid "Answer the relative space between lines" ^ self ascent + self descent!

1 0

The Trunk: ToolsTests-bf.70.mcz
by commits＠source.squeak.org 08 Dec '14

08 Dec '14

Bert Freudenberg uploaded a new version of ToolsTests to project The Trunk: http://source.squeak.org/trunk/ToolsTests-bf.70.mcz ==================== Summary ==================== Name: ToolsTests-bf.70 Author: bf Time: 8 December 2014, 2:14:44.962 am UUID: b5b69749-b461-4a51-80c4-24ff602e5202 Ancestors: ToolsTests-nice.69 Restore timestamps lost in assignment conversion. =============== Diff against ToolsTests-nice.69 =============== Item was changed: ----- Method: FileList2ModalDialogsTest>>testModalFileSelector (in category 'running') ----- testModalFileSelector | window fileList2 | window := FileList2 morphicViewFileSelector. window openCenteredInWorld. fileList2 := window valueOfProperty: #fileListModel. fileList2 fileListIndex: 1. window delete. self assert: fileList2 getSelectedFile isNil. fileList2 okHit. self deny: fileList2 getSelectedFile isNil ! Item was changed: ----- Method: FileList2ModalDialogsTest>>testModalFileSelectorForSuffixes (in category 'running') ----- testModalFileSelectorForSuffixes | window fileList2 | window := FileList2 morphicViewFileSelectorForSuffixes: nil. window openCenteredInWorld. fileList2 := window valueOfProperty: #fileListModel. fileList2 fileListIndex: 1. window delete. self assert: fileList2 getSelectedFile isNil. fileList2 okHit. self deny: fileList2 getSelectedFile isNil ! Item was changed: ----- Method: FileList2ModalDialogsTest>>testModalFolderSelector (in category 'running') ----- testModalFolderSelector | window fileList2 | window := FileList2 morphicViewFolderSelector. fileList2 := window model. window openInWorld: self currentWorld extent: 300@400. fileList2 fileListIndex: 1. window delete. self assert: fileList2 getSelectedDirectory withoutListWrapper isNil. fileList2 okHit. self deny: fileList2 getSelectedDirectory withoutListWrapper isNil ! Item was changed: ----- Method: FileList2ModalDialogsTest>>testModalFolderSelectorForProjectLoad (in category 'running') ----- testModalFolderSelectorForProjectLoad | window fileList2 w | window := FileList2 morphicViewProjectLoader2InWorld: self currentWorld reallyLoad: false. fileList2 := window valueOfProperty: #FileList. w := self currentWorld. window position: w topLeft + (w extent - window extent // 2). window openInWorld: w. window delete. self assert: fileList2 getSelectedDirectory withoutListWrapper isNil. fileList2 okHit. self deny: fileList2 getSelectedDirectory withoutListWrapper isNil !

1 0

← Newer
1
...
4
5
6
7
8
9
10
11
12
Older →