Squeak-dev December 2014

squeak-dev@lists.squeakfoundation.org

35 participants
112 discussions

The Trunk: CollectionsTests-bf.225.mcz
by commits＠source.squeak.org 08 Dec '14

08 Dec '14

Bert Freudenberg uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-bf.225.mcz ==================== Summary ==================== Name: CollectionsTests-bf.225 Author: bf Time: 8 December 2014, 1:33:54.357 am UUID: f5cc8617-fe9b-48a4-8a4a-6768918a0e36 Ancestors: CollectionsTests-eem.224 Restore timestamps lost in assignment conversion. =============== Diff against CollectionsTests-eem.224 =============== Item was changed: ----- Method: AssociationTest>>setUp (in category 'setup') ----- setUp a := 1 -> 'one'. b := 1 -> 'een'.! Item was changed: ----- Method: ReadStreamTest>>testUpToAll (in category 'tests - accessing') ----- testUpToAll self assert: (self streamOn: 'abcdefgh' upToAll: 'cd') = 'ab'. self assert: (self streamOn: 'abcdefgh' upToAll: 'cd' upToAll: 'gh') = 'ef'. self assert: (self streamOn: '' upToAll: '') = ''. self assert: (self streamOn: 'a' upToAll: '') = ''. self assert: (self streamOn: 'a' upToAll: 'a') = ''. self assert: (self streamOn: 'a' upToAll: 'b') = 'a'. self assert: (self streamOn: 'ab' upToAll: '') = ''. self assert: (self streamOn: 'ab' upToAll: 'a') = ''. self assert: (self streamOn: 'ab' upToAll: 'b') = 'a'. self assert: (self streamOn: 'ab' upToAll: 'c') = 'ab'. self assert: (self streamOn: 'ab' upToAll: 'ab') = ''. self assert: (self streamOn: 'abc' upToAll: '') = ''. self assert: (self streamOn: 'abc' upToAll: 'a') = ''. self assert: (self streamOn: 'abc' upToAll: 'b') = 'a'. self assert: (self streamOn: 'abc' upToAll: 'c') = 'ab'. self assert: (self streamOn: 'abc' upToAll: 'd') = 'abc'. self assert: (self streamOn: 'abc' upToAll: 'ab') = ''. self assert: (self streamOn: 'abc' upToAll: 'bc') = 'a'. self assert: (self streamOn: 'abc' upToAll: 'cd') = 'abc'. ! Item was changed: ----- Method: TextFontChangeTest>>testHash (in category 'tests') ----- testHash "test that different instances of the same TextFontChange hash to the same value" | hashes hash | hashes := OrderedCollection new. 1 to: 100 do: [:i | hashes add: TextFontChange defaultFontChange hash]. hash := hashes at: 1. 2 to: 100 do: [:i | self assert: (hashes at: i) = hash]!

1 0

The Trunk: Collections-bf.588.mcz
by commits＠source.squeak.org 08 Dec '14

08 Dec '14

Bert Freudenberg uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-bf.588.mcz ==================== Summary ==================== Name: Collections-bf.588 Author: bf Time: 8 December 2014, 1:30:10.896 am UUID: fa77c95e-6dc5-4ae1-acdc-2d1478d62476 Ancestors: Collections-ul.587 Restore timestamps lost in assignment conversion. =============== Diff against Collections-ul.587 =============== Item was changed: ----- Method: Set>>occurrencesOf: (in category 'testing') ----- occurrencesOf: anObject ^ (self includes: anObject) ifTrue: [1] ifFalse: [0]! Item was changed: ----- Method: String class>>cr (in category 'instance creation') ----- cr "Answer a string containing a single carriage return character." ^ self with: Character cr ! Item was changed: ----- Method: String class>>crlf (in category 'instance creation') ----- crlf "Answer a string containing a carriage return and a linefeed." ^ self with: Character cr with: Character lf ! Item was changed: ----- Method: String class>>fromByteArray: (in category 'instance creation') ----- fromByteArray: aByteArray ^ aByteArray asString ! Item was changed: ----- Method: String class>>fromString: (in category 'instance creation') ----- fromString: aString "Answer an instance of me that is a copy of the argument, aString." ^ aString copyFrom: 1 to: aString size! Item was changed: ----- Method: String class>>tab (in category 'instance creation') ----- tab "Answer a string containing a single tab character." ^ self with: Character tab ! Item was changed: ----- Method: String>>* (in category 'arithmetic') ----- * arg ^ arg adaptToString: self andSend: #*! Item was changed: ----- Method: String>>+ (in category 'arithmetic') ----- + arg ^ arg adaptToString: self andSend: #+! Item was changed: ----- Method: String>>- (in category 'arithmetic') ----- - arg ^ arg adaptToString: self andSend: #-! Item was changed: ----- Method: String>>/ (in category 'arithmetic') ----- / arg ^ arg adaptToString: self andSend: #/! Item was changed: ----- Method: String>>// (in category 'arithmetic') ----- // arg ^ arg adaptToString: self andSend: #//! Item was changed: ----- Method: String>>< (in category 'comparing') ----- < aString "Answer whether the receiver sorts before aString. The collation order is simple ascii (with case differences)." ^ (self compare: self with: aString collated: AsciiOrder) = 1! Item was changed: ----- Method: String>>> (in category 'comparing') ----- > aString "Answer whether the receiver sorts after aString. The collation order is simple ascii (with case differences)." ^ (self compare: self with: aString collated: AsciiOrder) = 3! Item was changed: ----- Method: String>>>= (in category 'comparing') ----- >= aString "Answer whether the receiver sorts after or equal to aString. The collation order is simple ascii (with case differences)." ^ (self compare: self with: aString collated: AsciiOrder) >= 2! Item was changed: ----- Method: String>>\\ (in category 'arithmetic') ----- \\ arg ^ arg adaptToString: self andSend: #\\! Item was changed: ----- Method: String>>adaptToCollection:andSend: (in category 'converting') ----- adaptToCollection: rcvr andSend: selector "If I am involved in arithmetic with a collection, convert me to a number." ^ rcvr perform: selector with: self asNumber! Item was changed: ----- Method: String>>adaptToNumber:andSend: (in category 'converting') ----- adaptToNumber: rcvr andSend: selector "If I am involved in arithmetic with a number, convert me to a number." ^ rcvr perform: selector with: self asNumber! Item was changed: ----- Method: String>>adaptToPoint:andSend: (in category 'converting') ----- adaptToPoint: rcvr andSend: selector "If I am involved in arithmetic with a point, convert me to a number." ^ rcvr perform: selector with: self asNumber! Item was changed: ----- Method: String>>adaptToString:andSend: (in category 'converting') ----- adaptToString: rcvr andSend: selector "If I am involved in arithmetic with a string, convert us both to numbers, and return the printString of the result." ^ (rcvr asNumber perform: selector with: self asNumber) printString! Item was changed: ----- Method: String>>asHtml (in category 'converting') ----- asHtml "Do the basic character conversion for HTML. Leave all original return and tabs in place, so can conver back by simply removing bracked things. 4/4/96 tk" | temp | temp := self copyReplaceAll: '&' with: '&'. HtmlEntities keysAndValuesDo: [:entity :char | char = $& ifFalse: [temp := temp copyReplaceAll: char asString with: '&' , entity , ';']]. temp := temp copyReplaceAll: ' ' with: ' <IMG SRC="tab.gif" ALT=" ">'. temp := temp copyReplaceAll: ' ' with: ' <BR>'. ^ temp " 'A<&>B' asHtml "! Item was changed: ----- Method: String>>asLowercase (in category 'converting') ----- asLowercase "Answer a String made up from the receiver whose characters are all lowercase." ^ self copy asString translateToLowercase! Item was changed: ----- Method: String>>asString (in category 'converting') ----- asString "Answer this string." ^ self ! Item was changed: ----- Method: String>>asUppercase (in category 'converting') ----- asUppercase "Answer a String made up from the receiver whose characters are all uppercase." ^self copy asString translateToUppercase! Item was changed: ----- Method: String>>askIfAddStyle:req: (in category 'converting') ----- askIfAddStyle: priorMethod req: requestor ^ self "we are a string with no text style"! Item was changed: ----- Method: String>>capitalized (in category 'converting') ----- capitalized "Return a copy with the first letter capitalized" | cap | self isEmpty ifTrue: [ ^self copy ]. cap := self copy. cap at: 1 put: (cap at: 1) asUppercase. ^ cap! Item was changed: ----- Method: String>>contractTo: (in category 'converting') ----- contractTo: smallSize "return myself or a copy shortened by ellipsis to smallSize" | leftSize | self size <= smallSize ifTrue: [^ self]. "short enough" smallSize < 5 ifTrue: [^ self copyFrom: 1 to: smallSize]. "First N characters" leftSize := smallSize-2//2. ^ self copyReplaceFrom: leftSize+1 "First N/2 ... last N/2" to: self size - (smallSize - leftSize - 3) with: '...' " 'A clear but rather long-winded summary' contractTo: 18 "! Item was changed: ----- Method: String>>correctAgainst:continuedFrom: (in category 'converting') ----- correctAgainst: wordList continuedFrom: oldCollection "Like correctAgainst:. Use when you want to correct against several lists, give nil as the first oldCollection, and nil as the last wordList." ^ wordList isNil ifTrue: [ self correctAgainstEnumerator: nil continuedFrom: oldCollection ] ifFalse: [ self correctAgainstEnumerator: [ :action | wordList do: action without: nil] continuedFrom: oldCollection ]! Item was changed: ----- Method: String>>displayAt: (in category 'displaying') ----- displayAt: aPoint "Display the receiver as a DisplayText at aPoint on the display screen." self displayOn: Display at: aPoint! Item was changed: ----- Method: String>>endsWithAnyOf: (in category 'testing') ----- endsWithAnyOf: aCollection aCollection do:[:suffix| (self endsWith: suffix) ifTrue:[^true]. ]. ^false! Item was changed: ----- Method: String>>findBetweenSubStrs: (in category 'accessing') ----- findBetweenSubStrs: delimiters "Answer the collection of String tokens that result from parsing self. Tokens are separated by 'delimiters', which can be a collection of Strings, or a collection of Characters. Several delimiters in a row are considered as just one separation." | tokens keyStart keyStop | tokens := OrderedCollection new. keyStop := 1. [keyStop <= self size] whileTrue: [keyStart := self skipAnySubStr: delimiters startingAt: keyStop. keyStop := self findAnySubStr: delimiters startingAt: keyStart. keyStart < keyStop ifTrue: [tokens add: (self copyFrom: keyStart to: (keyStop - 1))]]. ^tokens! Item was changed: ----- Method: String>>findString: (in category 'accessing') ----- findString: subString "Answer the index of subString within the receiver, starting at start. If the receiver does not contain subString, answer 0." ^self findString: subString startingAt: 1.! Item was changed: ----- Method: String>>findTokens:includes: (in category 'accessing') ----- findTokens: delimiters includes: subString "Divide self into pieces using delimiters. Return the piece that includes subString anywhere in it. Is case sensitive (say asLowercase to everything beforehand to make insensitive)." ^ (self findTokens: delimiters) detect: [:str | (str includesSubString: subString)] ifNone: [nil]! Item was changed: ----- Method: String>>findTokens:keep: (in category 'accessing') ----- findTokens: delimiters keep: keepers "Answer the collection of tokens that result from parsing self. The tokens are seperated by delimiters, any of a string of characters. If a delimiter is also in keepers, make a token for it. (Very useful for carriage return. A sole return ends a line, but is also saved as a token so you can see where the line breaks were.)" | tokens keyStart keyStop | tokens := OrderedCollection new. keyStop := 1. [keyStop <= self size] whileTrue: [keyStart := self skipDelimiters: delimiters startingAt: keyStop. keyStop to: keyStart-1 do: [:ii | (keepers includes: (self at: ii)) ifTrue: [ tokens add: (self copyFrom: ii to: ii)]]. "Make this keeper be a token" keyStop := self findDelimiters: delimiters startingAt: keyStart. keyStart < keyStop ifTrue: [tokens add: (self copyFrom: keyStart to: (keyStop - 1))]]. ^tokens! Item was changed: ----- Method: String>>includesSubString: (in category 'testing') ----- includesSubString: subString ^ (self findString: subString startingAt: 1) > 0! Item was changed: ----- Method: String>>includesSubstring:caseSensitive: (in category 'testing') ----- includesSubstring: aString caseSensitive: caseSensitive ^ (self findString: aString startingAt: 1 caseSensitive: caseSensitive) > 0! Item was changed: ----- Method: String>>isAllDigits (in category 'testing') ----- isAllDigits "whether the receiver is composed entirely of digits" self do: [:c | c isDigit ifFalse: [^ false]]. ^ true! Item was changed: ----- Method: String>>isAllSeparators (in category 'testing') ----- isAllSeparators "whether the receiver is composed entirely of separators" self do: [ :c | c isSeparator ifFalse: [ ^false ] ]. ^true! Item was changed: ----- Method: String>>isString (in category 'testing') ----- isString ^ true! Item was changed: ----- Method: String>>lastSpacePosition (in category 'accessing') ----- lastSpacePosition "Answer the character position of the final space or other separator character in the receiver, and 0 if none" self size to: 1 by: -1 do: [:i | ((self at: i) isSeparator) ifTrue: [^ i]]. ^ 0 " 'fred the bear' lastSpacePosition 'ziggie' lastSpacePosition 'elvis ' lastSpacePosition 'wimpy ' lastSpacePosition '' lastSpacePosition "! Item was changed: ----- Method: String>>numericSuffix (in category 'converting') ----- numericSuffix ^ self stemAndNumericSuffix last " 'abc98' numericSuffix '98abc' numericSuffix "! Item was changed: ----- Method: String>>padded:to:with: (in category 'copying') ----- padded: leftOrRight to: length with: char leftOrRight = #left ifTrue: [^ (String new: (length - self size max: 0) withAll: char) , self]. leftOrRight = #right ifTrue: [^ self , (String new: (length - self size max: 0) withAll: char)].! Item was changed: ----- Method: String>>romanNumber (in category 'converting') ----- romanNumber | value v1 v2 | value := v1 := v2 := 0. self reverseDo: [:each | v1 := #(1 5 10 50 100 500 1000) at: ('IVXLCDM' indexOf: each). v1 >= v2 ifTrue: [value := value + v1] ifFalse: [value := value - v1]. v2 := v1]. ^ value! Item was changed: ----- Method: String>>startsWithDigit (in category 'testing') ----- startsWithDigit "Answer whether the receiver's first character represents a digit" ^ self size > 0 and: [self first isDigit]! Item was changed: ----- Method: String>>surroundedBySingleQuotes (in category 'converting') ----- surroundedBySingleQuotes "Answer the receiver with leading and trailing quotes. " ^ $' asString, self, $' asString! Item was changed: ----- Method: String>>translateToLowercase (in category 'converting') ----- translateToLowercase "Translate all characters to lowercase, in place" self translateWith: LowercasingTable! Item was changed: ----- Method: String>>truncateWithElipsisTo: (in category 'converting') ----- truncateWithElipsisTo: maxLength "Return myself or a copy suitably shortened but with elipsis added" ^ self size <= maxLength ifTrue: [self] ifFalse: [(self copyFrom: 1 to: (maxLength - 3)), '...'] "'truncateWithElipsisTo:' truncateWithElipsisTo: 20"! Item was changed: ----- Method: String>>withoutTrailingBlanks (in category 'converting') ----- withoutTrailingBlanks "Return a copy of the receiver from which trailing blanks have been trimmed." | last | last := self findLast: [:c | c isSeparator not]. last = 0 ifTrue: [^ '']. "no non-separator character" ^ self copyFrom: 1 to: last " ' abc d ' withoutTrailingBlanks" ! Item was changed: ----- Method: TranscriptStream>>flush (in category 'stream extensions') ----- flush self endEntry ! Item was changed: ----- Method: WriteStream>>nextPut: (in category 'accessing') ----- nextPut: anObject "Primitive. Insert the argument at the next position in the Stream represented by the receiver. Fail if the collection of this stream is not an Array or a String. Fail if the stream is positioned at its end, or if the position is out of bounds in the collection. Fail if the argument is not of the right type for the collection. Optional. See Object documentation whatIsAPrimitive." <primitive: 66> position >= writeLimit ifTrue: [^ self pastEndPut: anObject] ifFalse: [position := position + 1. ^collection at: position put: anObject]!

1 0

The Trunk: Balloon-bf.25.mcz
by commits＠source.squeak.org 08 Dec '14

08 Dec '14

Bert Freudenberg uploaded a new version of Balloon to project The Trunk: http://source.squeak.org/trunk/Balloon-bf.25.mcz ==================== Summary ==================== Name: Balloon-bf.25 Author: bf Time: 8 December 2014, 1:28:08.723 am UUID: a70d4874-08d4-4e1b-be4a-6668c5c55d45 Ancestors: Balloon-nice.24 Restore timestamps lost in assignment conversion. =============== Diff against Balloon-nice.24 =============== Item was changed: ----- Method: BalloonEngine>>initialize (in category 'initialize') ----- initialize externals := OrderedCollection new: 100. span := Bitmap new: 2048. bitBlt := nil. self bitBlt: ((BitBlt toForm: Display) destRect: Display boundingBox; yourself). forms := #(). deferred := false.!

1 0

Re: [Vm-dev] [ANN] ARM Stack VMs available
by Eliot Miranda 07 Dec '14

07 Dec '14

Hi Juan, On Dec 5, 2014, at 4:56 AM, "J. Vuletich (mail lists)" <juanlists(a)jvuletich.org> wrote: > Hi Folks, > > The Squeak process scheduler usually preempts a process only by another one of higher priority. And when the scheduler is ready to go back at the lower priority, it will always resume the same process that was last suspended. The only way for two or more processes of the same priority to share the processor is when the running process calls #wait or #yield. No. According to the blue book preempting sends the preempted process to the back if its run queue so preempting forces a yield. Obviously this is wrong, but that's the way it was defined. The ObjectWorks & VisualWorks VMs changed this to work as you describe. When I implemented Cog I wanted to fix this but not break old code so I made it optional. The behavior is controlled by a flag in the image. You can see the flags via Smalltalk vmParameterAt: 48. Bit 2 (value 4) is set if preempting puts the preempted process at the head of its list, and hence does not yield. Here's the part of the comment from vmParameterAt: 48 various properties of the Cog VM as an integer encoding an array of bit flags. Bit 0: implies the image's Process class has threadId as its 3rd inst var (zero relative) Bit 1: on Cog VMs asks the VM to set the flag bit in interpreted methods Bit 2: if set, preempting a process puts it to the head of its run queue, not the back, i.e. preempting a process by a higher one will not cause the process to yield to others at the same priority. > This means that using shared state from several processes at the same priority (without using any locking mechanism, such as Semaphores, Monitors or critical sections) is safe, as long as the processes do #wait or #yield only when that shared state is in a consistent state. Right. > > It looks like this ARM VM is somehow not following this convention. If this was the case, the problems Ken sees are to be expected. Can you check the bit is set in the image? Thanks for raising this. It looks like the Spur images have the bit cleared. Ouch. Ah, it's not a problem of the bootstrap, its at least a problem in trunk. The bit is not set in trunk. I need to a) write some tests to test the bit and b) make sure its set in the relevant places. > > HTH, > Juan Vuletich Eliot (phone) > Quoting Douglas McPherson <djm1329(a)san.rr.com>: > >> Hi Ken, >> >>> On Nov 11, 2014, at 16:28, Ken Dickey <Ken.Dickey(a)whidbey.com> wrote: >>> >>> >>> On Sun, 9 Nov 2014 20:56:47 -0800 >>> Douglas McPherson <djm1329(a)san.rr.com> wrote: >>> >>> KenD>> >>>>> The stkspurlinuxhtARM VM, however, complains: >>>>> This interpreter (vers. 6521) cannot read image file (vers. 6505). >>>>> >>>>> I presume some conversion is required to get the image into SPUR format? >>>> Yes, the Spur VMs require a new image format. There are recent Squeak trunk images in the spur format on Eliot’s site. I’ll let Eliot and others comment about how a Cuis image might be converted. >>> >>> I tried out the Squeak SPUR image from the Cog site and everything Squeak seems fine. >>> >>> >>> There is a timing bug with Cuis redraw that shows up on both the stklinuxhtARM vm and the one you sent me earlier. >>> >>> Basically, I am using DisplayObject>>slideFrom:to:nSteps:delay: to do some animation. When multiple timer events fire during an animation it sometimes appears that the x,y redraw origin is used from the currently drawing morph's position, not 0,0. I.e. part of the redisplay is offset. [Display redraw via menu corrects the display]. >>> >>> This _only_ happens on the Samsung ARM Chromebook, never on Intel CPUs. >> >> Thanks for reporting this. I’ll try to look into it. There are definitely ARM-specific changes to support certain atomic operations, so there may be something not quite right with these. >> >> Can you suggest a method for reproducing this in Squeak? I repeatedly sent morphs to the trash (with appropriate preference set to enable the animation) but didn’t see an issue. I suspect I’m not driving it hard enough. >> >>> My life is really, really busy right now, so I have never had time to dig into this. I can redraw the display, so a workaround exists. >>> >>> [One possible resource. The Apache Portable Runtime, http://apr.apache.org/ , implements compareAndSwap and various other atomic operations across various OSs.] >> >> Thanks for the reference. It may be useful. I also found a library called Mintomic (http://preshing.com/20130505/introducing-mintomic-a-small-portable-lock-fre…) which may help. >> >>> I am happy to do quick tests, but must apologize for lack of time to dig into this. >> >> No problems, and thanks again for reporting it. >> >> >>> FYI, >>> -KenD

6 7

Daily Commit Log
by commits＠source.squeak.org 07 Dec '14

07 Dec '14

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2014-December/007391.h… Name: Tools-eem.530 Ancestors: Tools-eem.529 Don't make the assumption that Smalltalk at: answers a class. Hence fix scanning a source file that includes a definition for TextConstants. Fix runUntil to not return. Add an inspect key item to the DictionaryInspector. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007392.h… Name: Monticello-eem.606 Ancestors: Monticello-dtl.605 Include the old list of changes in the screed provided at the end of the save dialog. This text is useful when writing detailed check-in comments. Categorise the save dialog methods. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-December/007393.h… Name: Morphic-eem.752 Ancestors: Morphic-bf.751 Include URL Link (TextURL) as one of the available emphasis extras. =============================================

1 0

'mc history' function
by Chris Muller 06 Dec '14

06 Dec '14

While responding to David's note in the other thread, I noticed the magma-based trunk on box4 was no longer running since early November. I see a lot of errors that say "Could not open display `:1'" in the log. So I restarted it and it is back up and running. However, now the job which tries to load all .mcz's from real trunk into box4 trunk is getting an error in MCStWriter>>writeClassDefinition:, "Unrecognized class type". So, it is not being automatically updated anymore. My hunch is that maybe it encountered some new Spur packages and running into an issue? It might just be that this image being used needs to be udpated..? Unfortunately I cannot focus on this right now due to other life pressures, but if anyone else can look into it I'd be happy to help with anything Magma related..

2 1

The Trunk: Morphic-eem.752.mcz
by commits＠source.squeak.org 06 Dec '14

06 Dec '14

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.752.mcz ==================== Summary ==================== Name: Morphic-eem.752 Author: eem Time: 6 December 2014, 12:55:42.607 pm UUID: 9b2b1d98-9eb4-40e0-ac78-f82326fe92f2 Ancestors: Morphic-bf.751 Include URL Link (TextURL) as one of the available emphasis extras. =============== Diff against Morphic-bf.751 =============== Item was changed: ----- Method: SmalltalkEditor>>emphasisExtras (in category 'editing keys') ----- emphasisExtras ^#( 'Do it' 'Print it' 'Link to comment of class' 'Link to definition of class' 'Link to hierarchy of class' 'Link to method' + 'URL Link' ).!

1 0

The Trunk: Monticello-eem.606.mcz
by commits＠source.squeak.org 06 Dec '14

06 Dec '14

Eliot Miranda uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-eem.606.mcz ==================== Summary ==================== Name: Monticello-eem.606 Author: eem Time: 6 December 2014, 12:53:02.345 pm UUID: a82ff1d4-aae4-466c-8d74-5fb75ace18a4 Ancestors: Monticello-dtl.605 Include the old list of changes in the screed provided at the end of the save dialog. This text is useful when writing detailed check-in comments. Categorise the save dialog methods. =============== Diff against Monticello-dtl.605 =============== Item was changed: + ----- Method: MCSaveVersionDialog>>buttonSpecs (in category 'ui') ----- - ----- Method: MCSaveVersionDialog>>buttonSpecs (in category 'as yet unclassified') ----- buttonSpecs ^ #((Accept accept 'accept version name and log message') (Cancel cancel 'cancel saving version') ) ! Item was changed: + ----- Method: MCSaveVersionDialog>>defaultExtent (in category 'ui') ----- - ----- Method: MCSaveVersionDialog>>defaultExtent (in category 'as yet unclassified') ----- defaultExtent ^ 700@600! Item was changed: + ----- Method: MCSaveVersionDialog>>defaultLabel (in category 'ui') ----- - ----- Method: MCSaveVersionDialog>>defaultLabel (in category 'as yet unclassified') ----- defaultLabel ^ 'Edit Version Name and Message:'! Item was changed: + ----- Method: MCSaveVersionDialog>>list (in category 'accessing') ----- - ----- Method: MCSaveVersionDialog>>list (in category 'as yet unclassified') ----- list ^ self items collect: [:ea | (self ignore includes: ea) ifFalse: [ea summary] ifTrue: [Text string: '( ', ea summary, ' )' attribute: TextEmphasis struckOut ]]! Item was changed: + ----- Method: MCSaveVersionDialog>>logMessage (in category 'accessing') ----- - ----- Method: MCSaveVersionDialog>>logMessage (in category 'as yet unclassified') ----- logMessage ^ message ifNil: ['empty log message']! Item was changed: + ----- Method: MCSaveVersionDialog>>logMessage: (in category 'accessing') ----- - ----- Method: MCSaveVersionDialog>>logMessage: (in category 'as yet unclassified') ----- logMessage: aString message := aString. self changed: #logMessage! Item was changed: + ----- Method: MCSaveVersionDialog>>methodListKey:from: (in category 'menus') ----- - ----- Method: MCSaveVersionDialog>>methodListKey:from: (in category 'as yet unclassified') ----- methodListKey: aKeystroke from: aListMorph aKeystroke caseOf: { [$I] -> [self ignoreSelection]. } otherwise: [super methodListKey: aKeystroke from: aListMorph ]! Item was changed: + ----- Method: MCSaveVersionDialog>>methodListMenu: (in category 'accessing') ----- - ----- Method: MCSaveVersionDialog>>methodListMenu: (in category 'as yet unclassified') ----- methodListMenu: aMenu aMenu addList:#( ('ignore (I)' ignoreSelection 'Do not include this change when saving') -). super methodListMenu: aMenu. ^aMenu! Item was changed: + ----- Method: MCSaveVersionDialog>>representsSameBrowseeAs: (in category 'ui') ----- - ----- Method: MCSaveVersionDialog>>representsSameBrowseeAs: (in category 'as yet unclassified') ----- representsSameBrowseeAs: anotherModel ^ self class = anotherModel class and: [ self versionName = anotherModel versionName ]! Item was changed: + ----- Method: MCSaveVersionDialog>>updateItems (in category 'ui') ----- - ----- Method: MCSaveVersionDialog>>updateItems (in category 'as yet unclassified') ----- updateItems " update our items using the patchBlock " self patch: patchBlock value! Item was changed: + ----- Method: MCSaveVersionDialog>>versionName (in category 'accessing') ----- - ----- Method: MCSaveVersionDialog>>versionName (in category 'as yet unclassified') ----- versionName ^ name! Item was changed: + ----- Method: MCSaveVersionDialog>>versionName: (in category 'accessing') ----- - ----- Method: MCSaveVersionDialog>>versionName: (in category 'as yet unclassified') ----- versionName: aString name := aString. self changed: #versionName! Item was changed: + ----- Method: MCSaveVersionDialog>>widgetSpecs (in category 'ui') ----- - ----- Method: MCSaveVersionDialog>>widgetSpecs (in category 'as yet unclassified') ----- widgetSpecs ^ #( ((listMorph:selection:menu:keystroke: list selection methodListMenu: methodListKey:from:) (0 0 0.5 0.6) ) ((textMorph: versionName) (0.5 0 1 0) (0 0 0 30)) ((textMorph: logMessage) (0.5 0 1 0.6) (0 30 0 -30)) ((buttonRow) (0.5 0.6 1 0.6) (0 -30 0 0)) ((textMorph: text) (0 0.6 1 1) (0 0 0 0)) )! Item was changed: ----- Method: MCWorkingCopy>>patchMessageSuggestion (in category 'operations') ----- patchMessageSuggestion ^ String streamContents: [:strm | strm nextPutAll: self patchMessageDefault; cr;cr; nextPutAll: self patchMessageChangesDelimiter; cr; + nextPutAll: self patchMessageAncestry; cr; cr; + nextPutAll: self patchMessageChanges]! - nextPutAll: self patchMessageAncestry]!

1 0

The Trunk: Tools-eem.530.mcz
by commits＠source.squeak.org 06 Dec '14

06 Dec '14

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.530.mcz ==================== Summary ==================== Name: Tools-eem.530 Author: eem Time: 6 December 2014, 12:46:32.373 pm UUID: 360aa978-7b45-44b7-917e-37a00a467589 Ancestors: Tools-eem.529 Don't make the assumption that Smalltalk at: answers a class. Hence fix scanning a source file that includes a definition for TextConstants. Fix runUntil to not return. Add an inspect key item to the DictionaryInspector. =============== Diff against Tools-eem.529 =============== Item was changed: ----- Method: ChangeList>>scanCategory:class:meta:stamp: (in category 'scanning') ----- scanCategory: category class: class meta: meta stamp: stamp | itemPosition method selector | [itemPosition := file position. method := file nextChunk. file skipStyleChunk. method size > 0] "done when double terminators" whileTrue: [self addItem: (ChangeRecord new file: file position: itemPosition type: #method class: class category: category meta: meta stamp: stamp) text: 'method: ' , class , (meta ifTrue: [' class '] ifFalse: [' ']) + , ((selector := ((Smalltalk classNamed: class) ifNil: [Object]) newParser parseSelector: method) isNil - , ((selector := (Smalltalk at: class ifAbsent: [Object]) newParser parseSelector: method) isNil ifTrue: ['unparsableSelector'] ifFalse: [selector]) , (stamp isEmpty ifTrue: [''] ifFalse: ['; ' , stamp])]! Item was changed: ----- Method: Debugger>>runUntil (in category 'code pane menu') ----- runUntil "Step until an expression evaluates to other than false, reporting an error if it doesn't evaluate to true. Remember the expression in an inst var. If shift is pressed when the expression is supplied, don't update the UI. If shift is pressed while stepping, stop stepping. Using a user interrupt to break out would be more natural but Squeak currently doesn't provide a UserInterrupt expection. It should do." | expression receiver context method value lastUpdate updateUI breakOnShift | expression := UIManager default request: 'run until expression is true (shift to disable ui update; shift to break).' initialAnswer: (untilExpression ifNil: 'boolean expression'). (expression isNil or: [expression isEmpty]) ifTrue: [^self]. updateUI := breakOnShift := Sensor shiftPressed not. untilExpression := expression. context := self selectedContext. receiver := context receiver. method := receiver class evaluatorClass new compiledMethodFor: untilExpression in: context to: receiver notifying: nil ifFail: [^ #failedDoit]. lastUpdate := Time millisecondClockValue. Cursor execute showWhile: [[self selectedContext == context + and: [context willReturn not + and: [(value := receiver with: context executeMethod: method) == false]]] whileTrue: - and: [(value := receiver with: context executeMethod: method) == false]] whileTrue: [interruptedProcess completeStep: self selectedContext. self selectedContext == context ifTrue: [self resetContext: interruptedProcess stepToSendOrReturn changeContents: false]. Time millisecondClockValue - lastUpdate > 50 ifTrue: [updateUI ifTrue: [self changed: #contentsSelection. World displayWorldSafely]. breakOnShift ifTrue: [Sensor shiftPressed ifTrue: [self changed: #contentsSelection. self updateInspectors. ^self]] ifFalse: [Sensor shiftPressed ifFalse: [breakOnShift := true]]. lastUpdate := Time millisecondClockValue]]]. self changed: #contentsSelection. self updateInspectors. (value ~~ false and: [value ~~ true]) ifTrue: [UIManager default inform: 'expression ', (untilExpression contractTo: 40), ' answered ', (value printString contractTo: 20), '!!!!']! Item was changed: ----- Method: DictionaryInspector>>fieldListMenu: (in category 'menu') ----- fieldListMenu: aMenu ^ aMenu labels: 'inspect + inspect key copy name references objects pointing to this value senders of this key refresh view add key rename key remove basic inspect' lines: #(6 9) + selections: #(inspectSelection inspectKey copyName selectionReferences objectReferencesToSelection sendersOfSelectedKey refreshView addEntry renameEntry removeSelection inspectBasic) - selections: #(inspectSelection copyName selectionReferences objectReferencesToSelection sendersOfSelectedKey refreshView addEntry renameEntry removeSelection inspectBasic) ! Item was added: + ----- Method: DictionaryInspector>>inspectKey (in category 'menu commands') ----- + inspectKey + "Create and schedule an Inspector on the receiver's model's currently selected key." + + selectionIndex >= self numberOfFixedFields ifTrue: + [(keyArray at: selectionIndex - self numberOfFixedFields) inspect]!

1 0

TextURL
by Eliot Miranda 06 Dec '14

06 Dec '14

Hi All, I notice that the emphasis menu for the new editor, SmalltalkEditor>>emphasisExtras, excluded TextURL. Any objections if I put it back? This allows one e.g. to change a string in a comment into a URL via the command-6 menu that changes text colour etc. -- best, Eliot

2 1