Squeak-dev September 2013

squeak-dev@lists.squeakfoundation.org

42 participants
315 discussions

Daily Commit Log
by commits＠source.squeak.org 01 Oct '13

01 Oct '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-September/006465.… Name: Collections-tpr.537 Ancestors: Collections-fbs.536 Add Character class>>characterForColumnBreak - to replace TextComposer equivalent. See Mantis 4814 ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-September/006466.… Name: Graphics-tpr.241 Ancestors: Graphics-nice.240 Change from TextComposer characterForColumnBreak to Character characterForColumnBreak ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-September/006467.… Name: MorphicExtras-tpr.120 Ancestors: MorphicExtras-nice.119 Change from TextComposer characterForColumnBreak to Character characterForColumnBreak =============================================

1 0

The Trunk: MorphicExtras-tpr.120.mcz
by commits＠source.squeak.org 01 Oct '13

01 Oct '13

tim Rowledge uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-tpr.120.mcz ==================== Summary ==================== Name: MorphicExtras-tpr.120 Author: tpr Time: 30 September 2013, 4:11:52.606 pm UUID: 532f584d-ee41-4783-b9eb-ddf00d760fa7 Ancestors: MorphicExtras-nice.119 Change from TextComposer characterForColumnBreak to Character characterForColumnBreak =============== Diff against MorphicExtras-nice.119 =============== Item was changed: ----- Method: TextPlusMorph>>addColumnBreak (in category 'as yet unclassified') ----- addColumnBreak | ed old new break | ed := self editor. old := ed selection. + break := Character characterForColumnBreak asString. - break := TextComposer characterForColumnBreak asString. break := Text string: break attributes: {}. new := old ,break. ed replaceSelectionWith: new. self releaseParagraphReally. self layoutChanged. !

1 0

The Trunk: Graphics-tpr.241.mcz
by commits＠source.squeak.org 01 Oct '13

01 Oct '13

tim Rowledge uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-tpr.241.mcz ==================== Summary ==================== Name: Graphics-tpr.241 Author: tpr Time: 30 September 2013, 4:09:51.588 pm UUID: 61719896-2cc1-4c63-b5b7-fa0f97c9a01d Ancestors: Graphics-nice.240 Change from TextComposer characterForColumnBreak to Character characterForColumnBreak =============== Diff against Graphics-nice.240 =============== Item was changed: ----- Method: CharacterScanner class>>initialize (in category 'class initialization') ----- initialize " CharacterScanner initialize " | a | a := TextStopConditions new. a at: 1 + 1 put: #embeddedObject. a at: Space asciiValue + 1 put: #space. a at: Tab asciiValue + 1 put: #tab. a at: CR asciiValue + 1 put: #cr. a at: Character lf asciiValue + 1 put: #cr. DefaultStopConditions := a copy. ColumnBreakStopConditions := a copy. + ColumnBreakStopConditions at: Character characterForColumnBreak asciiValue + 1 put: #columnBreak. - ColumnBreakStopConditions at: TextComposer characterForColumnBreak asciiValue + 1 put: #columnBreak. PaddedSpaceCondition := a copy. PaddedSpaceCondition at: Space asciiValue + 1 put: #paddedSpace. MeasuringStopConditions := TextStopConditions new! Item was changed: ----- Method: TextComposer class>>characterForColumnBreak (in category 'as yet unclassified') ----- characterForColumnBreak + ^Character characterForColumnBreak! - ^Character value: 12! Item was changed: ----- Method: TextComposer>>composeEachRectangleIn: (in category 'as yet unclassified') ----- composeEachRectangleIn: rectangles | myLine lastChar | 1 to: rectangles size do: [:i | currCharIndex <= theText size ifFalse: [^false]. myLine := scanner composeFrom: currCharIndex inRectangle: (rectangles at: i) firstLine: isFirstLine leftSide: i=1 rightSide: i=rectangles size. lines addLast: myLine. actualHeight := actualHeight max: myLine lineHeight. "includes font changes" currCharIndex := myLine last + 1. lastChar := theText at: myLine last. (CharacterSet crlf includes: lastChar) ifTrue: [^#cr]. wantsColumnBreaks ifTrue: [ + lastChar = Character characterForColumnBreak ifTrue: [^#columnBreak]. - lastChar = TextComposer characterForColumnBreak ifTrue: [^#columnBreak]. ]. ]. ^false! Item was changed: ----- Method: TextComposer>>slideOneLineDown (in category 'as yet unclassified') ----- slideOneLineDown | priorLine | "Having detected the end of rippling recoposition, we are only sliding old lines" prevIndex < prevLines size ifFalse: [ "There are no more prevLines to slide." ^nowSliding := possibleSlide := false ]. "Adjust and re-use previously composed line" prevIndex := prevIndex + 1. priorLine := (prevLines at: prevIndex) slideIndexBy: deltaCharIndex andMoveTopTo: currentY. lines addLast: priorLine. currentY := priorLine bottom. currCharIndex := priorLine last + 1. wantsColumnBreaks ifTrue: [ priorLine first to: priorLine last do: [ :i | + (theText at: i) = Character characterForColumnBreak ifTrue: [ - (theText at: i) = TextComposer characterForColumnBreak ifTrue: [ nowSliding := possibleSlide := false. ^nil ]. ]. ]. !

1 0

The Trunk: Collections-tpr.537.mcz
by commits＠source.squeak.org 01 Oct '13

01 Oct '13

tim Rowledge uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-tpr.537.mcz ==================== Summary ==================== Name: Collections-tpr.537 Author: tpr Time: 30 September 2013, 4:06:41.402 pm UUID: b3a96179-9642-40b1-93f3-3f1d82f3e256 Ancestors: Collections-fbs.536 Add Character class>>characterForColumnBreak - to replace TextComposer equivalent. See Mantis 4814 =============== Diff against Collections-fbs.536 =============== Item was added: + ----- Method: Character class>>characterForColumnBreak (in category 'accessing untypeable characters') ----- + characterForColumnBreak + "use a newPage to split columns in character scanners" + ^self newPage!

1 0

Mantis 5712 "Allow underscores in selectors for portability and by popular demand." still open though facility is in image
by tim Rowledge 01 Oct '13

01 Oct '13

While checking for more character scanner related issues I spotted that 5712 is still open despite the Preferences having 'Allow underscore selectors'. That lead me to notice that there are 5 open issues assigned to Ralph since … well about the time dinosaurs flew the skies, which means they're likely related to the 3.10 release cycle. Could some kind person with a functioning memory of that era perhaps clean them out? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Fractured Idiom:- ICH LIEBE RICH - I'm really crazy about having dough

1 0

Features of text composition with different alignments and CharacterBlockScanner
by Nicolas Cellier 30 Sep '13

30 Sep '13

Currently, the scanner family is wrapping the composition/display on next line when line is too long. With a single space, the feature is quite simple, a space is then conceptually equal to a cr (and a line feed if you are stuck to the typewriter). So for example in rightFlush alignment: - align character before space with right margin - let character after space lay on next line - do not materialize any spacing in text selection selecting before the space let the cursor at upper line, right margin. selecting after the space let the cursor at lower line, left of next character. But what if there are two spaces? Should spacing be materialized before right margin or left of next line? IMHO, when rightFlush, spacing should be materialized left of next line, by symmetry with leftFlush (in which case they are materialized right of current line). And what about Centered? And Justified? Currently CharacterBlockScanner and rightFlush alignment don't play well together. Even leftFlush doesn't correctly update the cursor position (and I checked that this was already broken before I touched anything). It's not really amazing, looking at the bunch of states that come onto the playfield: - spaceCount for adjusting the padding in Justified case - spaceX for determining the (left) position of last space (or other breakable char) - lastIndex the index of next character to be processed in the text - runStopIndex the last index in the text from current position (?) before a change of run (emphasis) - destX the (left) position for next character to go - kern & pendingKernX for adjusting spacing of next character (if in same font) plus all the ones specific for CharacterBlockScanner: - lastCharacter the last character that was processed - lastCharacterExtent its extent - lastSpaceOrTabExtent the extent of last spce or tab (why?) - specialWidth if it wasn't a character but an embedded morph And the number of conditions scattered in the stop conditions: ((characterIndex ~= nil and: [characterIndex > text size]) or: [(line last = text size) and: [(destY + line lineHeight) < characterPoint y]]) characterIndex == nil ifFalse: [ characterIndex > text size ifTrue: [ characterPoint x <= (destX + (lastCharacterExtent x // 2)) ifTrue: [ lastIndex >= line last ifTrue: [ (((characterIndex ~~ nil and: [runStopIndex < characterIndex and: [runStopIndex < text size]]) or: [characterIndex == nil and: [lastIndex < line last]]) or: [ ((lastIndex < line last) and: [((text at: lastIndex) leadingChar ~= (text at: lastIndex+1) leadingChar) and: [lastIndex ~= characterIndex]])]) ifTrue: [ ((lastCharacter = Space and: [alignment = Justified]) or: [lastCharacter = Tab and: [lastSpaceOrTabExtent notNil]]) ifTrue: [ runStopIndex = text size ifTrue: [ (destX + lastSpaceOrTabExtent x) >= characterPoint x ifTrue: [ (alignment = Justified and: [self leadingTab not]) ifTrue: "imbedded tabs in justified text are weird" [ currentX >= characterPoint x ifTrue: [ Plus the ones before and after scanning (text isEmpty or: [(characterPoint y < destY or: [characterPoint x < destX]) or: [characterIndex notNil and: [characterIndex < line first]]]) ifTrue: [ characterIndex ifNil: [ (stopCondition ~~ #cr and: [ lastIndex = line last and: [ aPoint x > ((characterPoint x) + (lastCharacterExtent x / 2)) ]]) ifTrue: [ Of course, a MVC Paragraph does not behave exactly the same. I cannot really reverse engineer the state machine... It's not our best production. I can conjecture that: - characterIndex ~~ nil tests are probably related to the fact that moving cursor position with mouse or with arrow keys does not always result in consistent behavior (the cursor disappear in one case, remain visible in the other) - testing once for (destX + lastSpaceOrTabExtent x) and the other for (destX + (lastCharacterExtent x // 2)) sounds weird If you have any advice, reminiscence of bug report, useful comments to explain each and every logic, or anything related in this area, that might be helpful. Nicolas

3 3

Shout appears to remove underline and strikethrough emphasis
by tim Rowledge 30 Sep '13

30 Sep '13

I thought I'd broken something myself, but actually it appears that it is the Shout code colorater that did it; try selecting some code in a browser and cmd-- or cmd-=. It *should* underline or strikethrough but at best you might notice a little flash of some text change before Poof! gone. Do same in a Workspace and all is well. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful Latin Phrases:- Aio, quantitas magna frumentorum est. = Yes, that is a very large amount of corn.

7 11

Re: [squeak-dev] The Trunk: Graphics-nice.236.mcz
by Nicolas Cellier 30 Sep '13

30 Sep '13

NOTE: I could have added baselineY: baselineY parameter to font displayString:... like it is in MultiDispalyScanner BUT: there is currently a workaround in StrikeFont which is found only in the version without baselineY: All this stuff is really getting funny... 2013/9/29 <commits(a)source.squeak.org> > Nicolas Cellier uploaded a new version of Graphics to project The Trunk: > http://source.squeak.org/trunk/Graphics-nice.236.mcz > > ==================== Summary ==================== > > Name: Graphics-nice.236 > Author: nice > Time: 29 September 2013, 3:37:33.253 am > UUID: 38c2e6a3-d9fa-4a5b-b5e1-91a85e4afae6 > Ancestors: Graphics-nice.235 > > Don't setStopConditions twice in CharacterBlockScanner and DisplayScanner > in MVC compatibility methods. > SharedPools are inherited in Squeak, so don't declare TextConstants in > CompositionScanner. > > =============== Diff against Graphics-nice.235 =============== > > Item was changed: > ----- Method: CharacterBlockScanner>>buildCharacterBlockIn: (in category > 'private') ----- > buildCharacterBlockIn: para > + "This method is used by the MVC version only." > + > + | lineIndex runLength lineStop stopCondition | > - | lineIndex runLength lineStop done stopCondition | > "handle nullText" > (para numberOfLines = 0 or: [text size = 0]) > ifTrue: [^ CharacterBlock new stringIndex: 1 "like being > off end of string" > text: para text > topLeft: (para > leftMarginForDisplayForLine: 1 alignment: (alignment ifNil:[textStyle > alignment])) > @ para > compositionRectangle top > extent: 0 @ textStyle lineGrid]. > "find the line" > lineIndex := para lineIndexOfTop: characterPoint y. > destY := para topAtLineIndex: lineIndex. > line := para lines at: lineIndex. > lastIndex := line first. > - > rightMargin := para rightMarginForDisplay. > + self setStopConditions. " also loads the font, alignment and all > emphasis attributes " > - self setStopConditions. " also loads the font and loads all > emphasis attributes " > > - > (lineIndex = para numberOfLines and: > [(destY + line lineHeight) < characterPoint y]) > ifTrue: ["if beyond lastLine, force search to last > character" > self characterPointSetX: > rightMargin] > ifFalse: [characterPoint y < (para > compositionRectangle) top > ifTrue: ["force search to > first line" > > characterPoint := (para compositionRectangle) topLeft]. > characterPoint x > rightMargin > ifTrue: [self > characterPointSetX: rightMargin]]. > + destX := leftMargin := para leftMarginForDisplayForLine: lineIndex > alignment: alignment. > + nextLeftMargin:= para leftMarginForDisplayForLine: lineIndex+1 > alignment: alignment. > + runLength := text runLengthFor: line first. > + lineStop := characterIndex "scanning for index" > + ifNil: [ line last ]. "scanning for > point" > + runStopIndex := lastIndex + (runLength - 1) min: lineStop. > - destX := (leftMargin := para leftMarginForDisplayForLine: > lineIndex alignment: (alignment ifNil:[textStyle alignment])). > - nextLeftMargin:= para leftMarginForDisplayForLine: lineIndex+1 > alignment: (alignment ifNil:[textStyle alignment]). > - lastIndex := line first. > - > - self setStopConditions. "also sets font" > - runLength := (text runLengthFor: line first). > - characterIndex == nil > - ifTrue: [lineStop := line last "characterBlockAtPoint"] > - ifFalse: [lineStop := characterIndex > "characterBlockForIndex"]. > - (runStopIndex := lastIndex + (runLength - 1)) > lineStop > - ifTrue: [runStopIndex := lineStop]. > lastCharacterExtent := 0 @ line lineHeight. > + spaceCount := 0. > - spaceCount := 0. done := false. > self handleIndentation. > > - [done] > - whileFalse: > [stopCondition := self scanCharactersFrom: lastIndex to: > runStopIndex > in: text string rightX: characterPoint x > stopConditions: stopConditions kern: kern. > + "see setStopConditions for stopping conditions for character block > operations." > - > - "see setStopConditions for stopping conditions for character block > operations." > self lastCharacterExtentSetX: (font widthOf: (text at: lastIndex)). > + self perform: stopCondition] whileFalse. > + > + ^characterIndex == nil > - (self perform: stopCondition) ifTrue: > - [characterIndex == nil > ifTrue: ["characterBlockAtPoint" > ^ CharacterBlock new stringIndex: > lastIndex text: text > topLeft: characterPoint + > (font descentKern @ 0) > extent: > lastCharacterExtent] > ifFalse: ["characterBlockForIndex" > ^ CharacterBlock new stringIndex: > lastIndex text: text > topLeft: characterPoint + > ((font descentKern) - kern @ 0) > + extent: > lastCharacterExtent]! > - extent: > lastCharacterExtent]]]! > > Item was changed: > CharacterScanner subclass: #CompositionScanner > instanceVariableNames: 'spaceX spaceIndex lineHeight baseline > lineHeightAtSpace baselineAtSpace' > classVariableNames: '' > + poolDictionaries: '' > - poolDictionaries: 'TextConstants' > category: 'Graphics-Text'! > > !CompositionScanner commentStamp: '<historical>' prior: 0! > CompositionScanners are used to measure text and determine where line > breaks and space padding should occur.! > > Item was changed: > ----- Method: DisplayScanner>>displayLines:in:clippedBy: (in category > 'MVC-compatibility') ----- > displayLines: linesInterval in: aParagraph clippedBy: visibleRectangle > "The central display routine. The call on the primitive > (scanCharactersFrom:to:in:rightX:) will be interrupted according > to an > array of stop conditions passed to the scanner at which time the > code to > handle the stop condition is run and the call on the primitive > continued > until a stop condition returns true (which means the line has > terminated)." > | leftInRun | > "leftInRun is the # of characters left to scan in the current run; > when 0, it is time to call 'self setStopConditions'" > morphicOffset := 0@0. > leftInRun := 0. > self initializeFromParagraph: aParagraph clippedBy: > visibleRectangle. > ignoreColorChanges := false. > foregroundColor := paragraphColor := aParagraph foregroundColor. > backgroundColor := aParagraph backgroundColor. > aParagraph backgroundColor isTransparent > ifTrue: [fillBlt := nil] > ifFalse: [fillBlt := bitBlt copy. "Blt to fill spaces, > tabs, margins" > fillBlt sourceForm: nil; sourceOrigin: 0@0. > fillBlt fillColor: aParagraph > backgroundColor]. > rightMargin := aParagraph rightMarginForDisplay. > lineY := aParagraph topAtLineIndex: linesInterval first. > bitBlt destForm deferUpdatesIn: visibleRectangle while: [ > linesInterval do: > [:lineIndex | > + | string startIndex lastPos runLength > stopCondition baselineY | > - | string startIndex lastPos runLength > stopCondition | > line := aParagraph lines at: lineIndex. > lastIndex := line first. > + leftInRun <= 0 > + ifTrue: [self setStopConditions. "also > sets the font, alignment and emphasisCode" > + leftInRun := text > runLengthFor: line first]. > + leftMargin := aParagraph > leftMarginForDisplayForLine: lineIndex alignment: alignment. > + destX := runX := leftMargin. > - self setStopConditions. " causes an assignment to inst > var. alignment " > - > - leftMargin := aParagraph > leftMarginForDisplayForLine: lineIndex alignment: (alignment > ifNil:[textStyle alignment]). > - destX := (runX := leftMargin). > - line := aParagraph lines at: lineIndex. > lineHeight := line lineHeight. > fillBlt == nil ifFalse: > [fillBlt destX: visibleRectangle left > destY: lineY > width: visibleRectangle width > height: lineHeight; copyBits]. > + baselineY := lineY + line baseline. > + destY := baselineY - font ascent. "Should have > happened in setFont" > - lastIndex := line first. > - leftInRun <= 0 > - ifTrue: [self setStopConditions. "also > sets the font" > - leftInRun := text > runLengthFor: line first]. > - destY := lineY + line baseline - font ascent. > "Should have happened in setFont" > runLength := leftInRun. > runStopIndex := lastIndex + (runLength - 1) min: > line last. > leftInRun := leftInRun - (runStopIndex - lastIndex > + 1). > spaceCount := 0. > string := text string. > self handleIndentation. > [ > startIndex := lastIndex. > lastPos := destX@destY. > stopCondition := self scanCharactersFrom: > lastIndex to: runStopIndex > in: string rightX: > rightMargin stopConditions: stopConditions > kern: kern. > lastIndex >= startIndex ifTrue:[ > font displayString: string on: > bitBlt > from: startIndex to: > lastIndex at: lastPos kern: kern]. > "see setStopConditions for stopping > conditions for displaying." > self perform: stopCondition > ] whileFalse. > fillBlt == nil ifFalse: > [fillBlt destX: destX destY: lineY width: > visibleRectangle right-destX height: lineHeight; copyBits]. > lineY := lineY + lineHeight]]! > > >

3 2

some CharacterScanner methods weirdly send setStopConditions twice
by Nicolas Cellier 30 Sep '13

30 Sep '13

Sending twice some complex initialization message with inter-mixed state messing smells... This is for example in CharacterBlockScanner>>buildCharacterBlockIn: I found http://bugs.squeak.org/view.php?id=3570 which were included in Graphics-ar.39 (in 3.9 repository see http://source.squeak.org/39a/Graphics-ar.39.diff)... ...but the doubled setStopConditions was there already, the change just swapped some lines... This is not in the Multilingual branch, so it seems newer than 2002... Does anyone remember where to dig to understand why, which bug it solves, which feature it supports, and whether it is really needed?

3 10

sqConnectToAddressSize: Address family not supported by protocol
by Chris Muller 30 Sep '13

30 Sep '13

After 15 years of paying $50 / month for Internet service, Google Fiber has arrived and offering a much better deal. Unfortunately, there seems to be a problem using Squeak's HTTPSocket with GF. I'm getting ready to call their tech-support but wanted to ask you all first to see if I can at least understand a background of the problem from a networking perspective. The difference between connecting to my old ISP and new GF begins at obtaining a SocketAddress via NetNameResolver. If I do: NetNameResolver addressForName: 'www.google.com' timeout: 20. With Surewest (old ISP) I get: 64.126.1.187(64-126-1-187.static.everestkc.net),0(0) But with Google Fiber I get: 2607:f8b0:4001:c05::93(ig-in-x93.1e100.net),80(http) Those are the printStrings for instances of SocketAddress. The first one is 24 bytes, the GF one is 36 bytes and will not allow me to connect. If I try to use the one from GF to connect to HTTP server like this: SocketStream openConnectionToHostNamed: 'www.google.com' port: 80 then I get a ConnectionRefused is signaled, 'Cannot Connect to 2607:f8b0:4001:c05::93(ig-in-x93.1e100.net),80(http)'. and the subject line of this mail is reported from the VM on the command-line. Turning off "Enable IPv6 and new network support" in Preferences works but my understanding when we flipped that ON by default was that it would be "transparent" with old IPv4. Did no one else in the community experience an issue or is Google doing something unique from other ISP's that could be causing this issue? Is this a problem with Squeak or Google Fiber? Many thanks.

6 15

Jump to page: