Squeak-dev June 2013

squeak-dev@lists.squeakfoundation.org

45 participants
215 discussions

The Inbox: Files-cmm.125.mcz
by commits＠source.squeak.org 28 Jun '13

28 Jun '13

A new version of Files was added to project The Inbox: http://source.squeak.org/inbox/Files-cmm.125.mcz ==================== Summary ==================== Name: Files-cmm.125 Author: cmm Time: 27 June 2013, 7:24:33.37 pm UUID: 0b00b2c4-3430-442b-a924-72040ff43d73 Ancestors: Files-fbs.124 FileDirectory>>statsForDirectoryTree: is a prime example of FileDirectory living up to its poor reputation. It does one useless thing, and does it inefficiently. It has no senders, deservedly. Tree-walking operations like gathering stats can be written in apps more generally using directoryTreeDo:. =============== Diff against Files-fbs.124 =============== Item was changed: + ----- Method: FileDirectory>>directoryTreeDo:entries: (in category 'private') ----- - ----- Method: FileDirectory>>directoryTreeDo:entries: (in category 'enumeration') ----- directoryTreeDo: oneArgBlock entries: entriesCollection "Value oneArgBlock with the path (an OrderedCollection of FileDirectory's) to each DirectoryEntry and the DirectoryEntry itself." self entries do: [ : each | entriesCollection add: each. oneArgBlock value: entriesCollection. each isDirectory ifTrue: [ | subdir | subdir := each asFileDirectory. subdir directoryTreeDo: oneArgBlock entries: entriesCollection ]. entriesCollection removeLast ]! Item was removed: - ----- Method: FileDirectory>>statsForDirectoryTree: (in category 'enumeration') ----- - statsForDirectoryTree: rootedPathName - "Return the size statistics for the entire directory tree starting at the given root. The result is a three element array of the form: (<number of folders><number of files><total bytes in all files>). This method also serves as an example of how recursively enumerate a directory tree." - "FileDirectory default statsForDirectoryTree: '\smalltalk'" - - | dirs files bytes todo entries p | - dirs := files := bytes := 0. - todo := OrderedCollection with: rootedPathName. - [todo isEmpty] whileFalse: [ - p := todo removeFirst. - entries := self directoryContentsFor: p. - entries do: [:entry | - entry isDirectory - ifTrue: [ - todo addLast: p , self pathNameDelimiter asString , entry name. - dirs := dirs + 1] - ifFalse: [ - files := files + 1. - bytes := bytes + entry fileSize]]]. - ^ Array with: dirs with: files with: bytes - !

1 0

Daily Commit Log
by commits＠source.squeak.org 28 Jun '13

28 Jun '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-June/006074.html Name: Files-fbs.124 Ancestors: Files-tpr.123 Remove the Cursor >> #showWhile because this method has no senders (it's an example of how to recursively enumerate a FileDirectory) and so needlessly introduces a dependency on Graphics. The diff is very noisy because we unindent the block. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-June/006075.html Name: Tests-fbs.225 Ancestors: Tests-fbs.224 Files -/-> Graphics ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-June/006076.html Name: Tests-fbs.226 Ancestors: Tests-fbs.225 #decompilerFailures lets us record the failure case while not breaking tests unnecessarily. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-June/006077.html Name: Monticello-cmm.549 Ancestors: Monticello-fbs.548 Allow RepositoryGroup to function as a partially-connected repository, where some of its 'repositories' may be accessible, some not. Do not signal an error just because one of several repositories is unavailable. =============================================

1 0

The Trunk: Monticello-cmm.549.mcz
by commits＠source.squeak.org 27 Jun '13

27 Jun '13

Chris Muller uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-cmm.549.mcz ==================== Summary ==================== Name: Monticello-cmm.549 Author: cmm Time: 27 June 2013, 4:09:58.012 pm UUID: 43fed9bc-ca4c-4bdd-a31e-8d3d6339a357 Ancestors: Monticello-fbs.548 Allow RepositoryGroup to function as a partially-connected repository, where some of its 'repositories' may be accessible, some not. Do not signal an error just because one of several repositories is unavailable. =============== Diff against Monticello-fbs.548 =============== Item was changed: ----- Method: MCHttpRepository>>allFileNames (in category 'required') ----- allFileNames | index | + self displayProgress: 'Updating ', self description during:[ - [self displayProgress: 'Updating ', self description during:[ index := HTTPSocket httpGet: self locationWithTrailingSlash, '?C=M;O=D' args: nil user: self user passwd: self password. + ]. + index isString ifTrue: [NetworkError signal: 'Could not access ', location]. - ]] on: NetworkError do: [ :e | self error: 'Could not access ', location, '(', e className, ')']. - index isString ifTrue: [self error: 'Could not access ', location]. ^ self parseFileNamesFromStream: index ! Item was changed: ----- Method: MCRepositoryGroup>>versionNamesForPackageNamed: (in category 'repository-api') ----- versionNamesForPackageNamed: aString ^ repositories inject: Set new into: [ : set : each | set + addAll: + ([ each versionNamesForPackageNamed: aString ] + on: NetworkError + do: [ : err | Array empty ]) ; - addAll: (each versionNamesForPackageNamed: aString) ; yourself ]! Item was changed: ----- Method: MCRepositoryGroup>>versionWithInfo:ifAbsent: (in category 'repository-api') ----- versionWithInfo: aVersionInfo ifAbsent: aBlock repositories do: + [ : each | ([each - [ : each | (each versionWithInfo: aVersionInfo + ifAbsent: [ nil ]] on: NetworkError do: [ : err | nil ]) ifNotNil: - ifAbsent: [ ]) ifNotNil: [ : ver | ^ ver ] ]. ^ aBlock value!

1 0

The Trunk: Tests-fbs.226.mcz
by commits＠source.squeak.org 27 Jun '13

27 Jun '13

Frank Shearar uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-fbs.226.mcz ==================== Summary ==================== Name: Tests-fbs.226 Author: fbs Time: 27 June 2013, 8:55:56.713 pm UUID: c4ac4684-08cc-3244-8c13-81f648224b6c Ancestors: Tests-fbs.225 #decompilerFailures lets us record the failure case while not breaking tests unnecessarily. =============== Diff against Tests-fbs.225 =============== Item was changed: ----- Method: DecompilerTests>>decompilerFailures (in category 'utilities') ----- decompilerFailures "Here is the list of failures: either a syntax error, a hard error or some failure to decompile correctly. Collected via CurrentReadOnlySourceFiles cacheDuring: [ (DecompilerTestFailuresCollector new computeFailures collect: [:mr| { mr classSymbol. mr selector }]) asArray ]." ^#( (BrowserCommentTextMorph showPane) (ClassDescription replaceSilently:to:) (CodeHolder getSelectorAndSendQuery:to:with:) (Date printOn:) + (DecompilerTests testDecompileUnreachableParameter) (HttpUrl checkAuthorization:retry:) (MCConfigurationBrowser post) (MailComposition breakLinesInMessage:) (MVCToolBuilder setLayout:in:) "same-name block-local temps in optimized blocks" (ParagraphEditor inOutdent:delta:) (PNGReadWriter copyPixelsGray:) (PointTest testNormal) "fraction printing??" (PointTest testTheta) "fraction printing??" (ScaledDecimalTest testConvertFromFraction) "local/non-local temps" (StandardScriptingSystem holderWithAlphabet) "same-name block-local temps in optimized blocks" (SystemWindow convertAlignment) (TextEditor inOutdent:delta:) (TextURL actOnClickFor:) (TTContourConstruction segmentsDo:) "Worth fixing; these two are mistaken conversion from a whileTrue: to a to:do: but the index is used outside the whileTrue:" (TTFontReader processHorizontalMetricsTable:length:))! Item was added: + ----- Method: DecompilerTests>>expectedFailures (in category 'testing') ----- + expectedFailures + ^ #(testDecompileUnreachableParameter)! Item was added: + ----- Method: DecompilerTests>>testDecompileUnreachableParameter (in category 'failing decompile tests') ----- + testDecompileUnreachableParameter + "The call to #value: is unreachable because both blocks in the #ifTrue:ifFalse: send force a return." + self shouldnt: [[self value: (true ifTrue: [^true] ifFalse: [^false])] decompile] raise: Error.!

1 0

The Trunk: Tests-fbs.225.mcz
by commits＠source.squeak.org 27 Jun '13

27 Jun '13

Frank Shearar uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-fbs.225.mcz ==================== Summary ==================== Name: Tests-fbs.225 Author: fbs Time: 27 June 2013, 5:23:17.783 pm UUID: bfa249c2-5be9-1e41-8d55-0f97d4754625 Ancestors: Tests-fbs.224 Files -/-> Graphics =============== Diff against Tests-fbs.224 =============== Item was changed: ----- Method: PackageDependencyTest>>testFiles (in category 'tests') ----- testFiles self testPackage: 'Files' dependsExactlyOn: #( Collections Compression - Graphics Kernel Multilingual System 'ToolBuilder-Kernel' ).!

1 0

The Trunk: Files-fbs.124.mcz
by commits＠source.squeak.org 27 Jun '13

27 Jun '13

Frank Shearar uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-fbs.124.mcz ==================== Summary ==================== Name: Files-fbs.124 Author: fbs Time: 27 June 2013, 5:18:49.925 pm UUID: db8086ca-e21b-9748-a401-0430a5641821 Ancestors: Files-tpr.123 Remove the Cursor >> #showWhile because this method has no senders (it's an example of how to recursively enumerate a FileDirectory) and so needlessly introduces a dependency on Graphics. The diff is very noisy because we unindent the block. =============== Diff against Files-tpr.123 =============== Item was changed: ----- Method: FileDirectory>>statsForDirectoryTree: (in category 'enumeration') ----- statsForDirectoryTree: rootedPathName "Return the size statistics for the entire directory tree starting at the given root. The result is a three element array of the form: (<number of folders><number of files><total bytes in all files>). This method also serves as an example of how recursively enumerate a directory tree." "FileDirectory default statsForDirectoryTree: '\smalltalk'" + | dirs files bytes todo entries p | + dirs := files := bytes := 0. + todo := OrderedCollection with: rootedPathName. + [todo isEmpty] whileFalse: [ + p := todo removeFirst. + entries := self directoryContentsFor: p. + entries do: [:entry | + entry isDirectory + ifTrue: [ + todo addLast: p , self pathNameDelimiter asString , entry name. + dirs := dirs + 1] + ifFalse: [ + files := files + 1. + bytes := bytes + entry fileSize]]]. + ^ Array with: dirs with: files with: bytes - ^Cursor wait showWhile: [ - | dirs files bytes todo entries p | - dirs := files := bytes := 0. - todo := OrderedCollection with: rootedPathName. - [todo isEmpty] whileFalse: [ - p := todo removeFirst. - entries := self directoryContentsFor: p. - entries do: [:entry | - entry isDirectory - ifTrue: [ - todo addLast: p , self pathNameDelimiter asString , entry name. - dirs := dirs + 1] - ifFalse: [ - files := files + 1. - bytes := bytes + entry fileSize]]]. - Array with: dirs with: files with: bytes] !

1 0

Re: [squeak-dev] The Trunk: Tests-fbs.224.mcz
by Levente Uzonyi 27 Jun '13

27 Jun '13

On Wed, 26 Jun 2013, commits(a)source.squeak.org wrote: > Frank Shearar uploaded a new version of Tests to project The Trunk: > http://source.squeak.org/trunk/Tests-fbs.224.mcz > > ==================== Summary ==================== > > Name: Tests-fbs.224 > Author: fbs > Time: 26 June 2013, 12:40:25.578 pm > UUID: 3e0351c4-903b-4f74-9d53-2eae254fe5bb > Ancestors: Tests-fbs.223 > > Remove the test for http://bugs.squeak.org/view.php?id=7771. You can't make it an expected failure because it breaks testDecompilerInClassesDAtoDM. > > The workaround of making testDecompilerInClassesDAtoDM clever enough to avoid this marker test just isn't worth it. It's recorded in the bugtracker anyway. There's already a workaround for that. Just add an entry to DecompilerTests >> #decompilerFailures. Levente > > =============== Diff against Tests-fbs.223 =============== > > Item was removed: > - ----- Method: DecompilerTests>>expectedFailures (in category 'testing') ----- > - expectedFailures > - ^ #(testDecompileUnreachableParameter)! > > Item was removed: > - ----- Method: DecompilerTests>>testDecompileUnreachableParameter (in category 'tests') ----- > - testDecompileUnreachableParameter > - "DecompilerTests new testDecompileUnreachableParameter" > - "The call to #value: is unreachable because both blocks in the #ifTrue:ifFalse: send force a return." > - self shouldnt: [[self value: (true ifTrue: [^true] ifFalse: [^false])] decompile] raise: Error.! > > >

2 1

Dependencies on Cursor
by Ken Dickey 27 Jun '13

27 Jun '13

I think Juan's point may have been missed, but shows up in his change notes: - Automatic hourglass mouse pointer when Morphic is busy - Removed about 80 calls like 'Cursor wait showWhile: []', as they are no longer needed! $0.02 -KenD -- Ken [dot] Dickey [at] whidbey [dot] com

11 28

alpha images
by Chris Muller 27 Jun '13

27 Jun '13

What's the story on http://ftp.squeak.org/4.5alpha/Squeak4.5-12641.zip ? Is it the official alpha image I should be testing? It's dated only a couple of weeks ago. Is this one from the CI build and had its packages unloaded and reloaded? If that's what we intend to release, I'd like to start testing on that one.

2 1

Daily Commit Log
by commits＠source.squeak.org 27 Jun '13

27 Jun '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-June/006072.html Name: Installer-Core-fbs.372 Ancestors: Installer-Core-cmm.371 Update the SS3 link references, as per Dale Henrich's announcement (part of GemTalk Systems' separation from VMWare). ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-June/006073.html Name: Tests-fbs.224 Ancestors: Tests-fbs.223 Remove the test for http://bugs.squeak.org/view.php?id=7771. You can't make it an expected failure because it breaks testDecompilerInClassesDAtoDM. The workaround of making testDecompilerInClassesDAtoDM clever enough to avoid this marker test just isn't worth it. It's recorded in the bugtracker anyway. =============================================

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
22
Older →

Jump to page: