Squeak-dev June 2013

squeak-dev@lists.squeakfoundation.org

45 participants
215 discussions

Daily Commit Log
by commits＠source.squeak.org 02 Jun '13

02 Jun '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-June/006010.html Name: Network-fbs.141 Ancestors: Network-fbs.140 Move MailComposition >> #addAttachment to Morphic-Support because the sole sender of #addAttachment (MailComposition >> #morphicOpen) is in Morphic-Support. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-June/006011.html Name: Morphic-fbs.655 Ancestors: Morphic-fbs.654 Move MailComposition >> #addAttachment to Morphic-Support because the sole sender of #addAttachment (MailComposition >> #morphicOpen) is in Morphic-Support. =============================================

1 0

Re: [squeak-dev] The Trunk: Morphic-fbs.655.mcz
by Frank Shearar 02 Jun '13

02 Jun '13

On 1 June 2013 23:20, <commits(a)source.squeak.org> wrote: > Frank Shearar uploaded a new version of Morphic to project The Trunk: > http://source.squeak.org/trunk/Morphic-fbs.655.mcz > > ==================== Summary ==================== > > Name: Morphic-fbs.655 > Author: fbs > Time: 1 June 2013, 11:19:58.083 pm > UUID: b2ebeb75-74c9-4909-b81c-8eb82350599a > Ancestors: Morphic-fbs.654 > > Move MailComposition >> #addAttachment to Morphic-Support because the sole sender of #addAttachment (MailComposition >> #morphicOpen) is in Morphic-Support. > > =============== Diff against Morphic-fbs.653 =============== I made this commit against Morphic-fbs.654 in the Inbox, instead of working from a clean image. You'll note it contains none of the code from .654 though. I'm happy to pull it and resubmit if a missing commit's a problem. frank

1 0

The Trunk: Morphic-fbs.655.mcz
by commits＠source.squeak.org 02 Jun '13

02 Jun '13

Frank Shearar uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-fbs.655.mcz ==================== Summary ==================== Name: Morphic-fbs.655 Author: fbs Time: 1 June 2013, 11:19:58.083 pm UUID: b2ebeb75-74c9-4909-b81c-8eb82350599a Ancestors: Morphic-fbs.654 Move MailComposition >> #addAttachment to Morphic-Support because the sole sender of #addAttachment (MailComposition >> #morphicOpen) is in Morphic-Support. =============== Diff against Morphic-fbs.653 =============== Item was added: + ----- Method: MailComposition>>addAttachment (in category '*Morphic-Support') ----- + addAttachment + | file fileResult fileName | + textEditor + ifNotNil: [self hasUnacceptedEdits ifTrue: [textEditor accept]]. + + (fileResult := StandardFileMenu oldFile) + ifNotNil: + [fileName := fileResult directory fullNameFor: fileResult name. + file := FileStream readOnlyFileNamed: fileName. + file ifNotNil: + [file binary. + self messageText: + ((MailMessage from: self messageText asString) + addAttachmentFrom: file withName: fileResult name; text). + file close]] !

1 0

The Trunk: Network-fbs.141.mcz
by commits＠source.squeak.org 02 Jun '13

02 Jun '13

Frank Shearar uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-fbs.141.mcz ==================== Summary ==================== Name: Network-fbs.141 Author: fbs Time: 1 June 2013, 11:18:12.251 pm UUID: fef0a0b0-1402-42f1-a75d-88f082e0741a Ancestors: Network-fbs.140 Move MailComposition >> #addAttachment to Morphic-Support because the sole sender of #addAttachment (MailComposition >> #morphicOpen) is in Morphic-Support. =============== Diff against Network-fbs.140 =============== Item was removed: - ----- Method: MailComposition>>addAttachment (in category 'interface') ----- - addAttachment - | file fileResult fileName | - textEditor - ifNotNil: [self hasUnacceptedEdits ifTrue: [textEditor accept]]. - - (fileResult := StandardFileMenu oldFile) - ifNotNil: - [fileName := fileResult directory fullNameFor: fileResult name. - file := FileStream readOnlyFileNamed: fileName. - file ifNotNil: - [file binary. - self messageText: - ((MailMessage from: self messageText asString) - addAttachmentFrom: file withName: fileResult name; text). - file close]] !

1 0

TheWorldMenu, TheWorldDockingBar
by Frank Shearar 01 Jun '13

01 Jun '13

These guys live in Morphic, and they thus cause a whole bunch of things to depend on Morphic. While I do think something called "TheWorldMenu" is rather clearly a UI thing, I don't think it's necessarily a _Morphic_ thing. One way to approach this is to move TheWorldMenu and TheWorldDockingBar into another package. Perhaps System-Support, because that's where Project lives. Or perhaps System-World. Then we move all Morphic referencing methods to *Morphic, and so on. There are a fair number of these! Alternatively, we implement a registry thing, and TheWorldMenu and TheWorldDockingBar reference this registry to build its list of tools. Thoughts? frank

2 2

Jump to page: