Squeak-dev February 2013

squeak-dev@lists.squeakfoundation.org

61 participants
225 discussions

Re: [squeak-dev] The Inbox: Kernel-fbs.736.mcz
by Frank Shearar 06 Feb '13

06 Feb '13

On 30 January 2013 20:04, <commits(a)source.squeak.org> wrote: > Frank Shearar uploaded a new version of Kernel to project The Inbox: > http://source.squeak.org/inbox/Kernel-fbs.736.mcz > > ==================== Summary ==================== > > Name: Kernel-fbs.736 > Author: fbs > Time: 30 January 2013, 8:04:08.926 pm > UUID: 1d99c937-4c68-475c-987b-2990c8040c29 > Ancestors: Kernel-fbs.735 > > Rename NotImplemented errors in line with conventions 2 of 3. > > =============== Diff against Kernel-fbs.735 =============== If folks are happy with what I've got, I'd like to make one more change, and remove NotYetImplemented>>#defaultAction. This will make this message send open up a Debugger. Then I just need to tweak the Debugger to show the Create button. If people think that's sensible I'll make the change and resubmit, clearing out obsolete Inbox ancestors to show a more complete diff. frank

3 6

Re: [squeak-dev] The Inbox: Kernel-fbs.735.mcz
by Frank Shearar 06 Feb '13

06 Feb '13

On 30 January 2013 18:33, <commits(a)source.squeak.org> wrote: > Frank Shearar uploaded a new version of Kernel to project The Inbox: > http://source.squeak.org/inbox/Kernel-fbs.735.mcz > > ==================== Summary ==================== > > Name: Kernel-fbs.735 > Author: fbs > Time: 30 January 2013, 6:33:47.078 pm > UUID: 18ffff61-cfcf-4843-8c64-caea3ceb3fbc > Ancestors: Kernel-fbs.734 > > Actually, return a Message, and find out the receiver of the Message from the signalercontext. > > Also, _returning_ the value of #subclassResponsibility means that you can return to the original caller the value of your just implemented method. > > =============== Diff against Kernel-fbs.734 =============== > > Item was added: > + ----- Method: ContextPart>>asMessage (in category 'converting') ----- > + asMessage > + | sender selector args | > + sender := self sender. > + selector := sender method selector. > + args := Array new: selector numArgs. > + 1 to: selector numArgs do: [ :i | args at: i put: (sender tempAt: i)]. > + ^ Message selector: selector arguments: args.! > > Item was removed: > - ----- Method: ContextPart>>asMessageSend (in category 'converting') ----- > - asMessageSend > - | sender selector args | > - sender := self sender. > - selector := sender method selector. > - args := Array new: selector numArgs. > - 1 to: selector numArgs do: [ :i | args at: i put: (sender tempAt: i)]. > - ^ MessageSend receiver: self receiver selector: selector arguments: args.! <snip> Diffs serve as a helper for reviewers. To that end, the diffs ought to actually show what changes would be applied to trunk should the change be accepted. This diff, for instance, shows the removal of #asMessageSend and the addition of #asMessage, but really the change applied to trunk will be just the addition of #asMessage. In other words when something undergoes a few rounds of review (and I'd think this should be the _norm_) the reviewer must reconstruct a series of diffs to get an idea of how trunk will change. Wouldn't it be better to diff against trunk rather than against the mcz's ancestor? (*) frank (*) This is actually how github's pull requests work: you _can_ see the commit history, but you also have a straight "this is what will change" view, which is where I normally look.

4 12

The Inbox: KernelTests-fbs.243.mcz
by commits＠source.squeak.org 06 Feb '13

06 Feb '13

Frank Shearar uploaded a new version of KernelTests to project The Inbox: http://source.squeak.org/inbox/KernelTests-fbs.243.mcz ==================== Summary ==================== Name: KernelTests-fbs.243 Author: fbs Time: 5 February 2013, 11:15:32.593 pm UUID: 6566a862-0f12-4218-b502-b18369e49a11 Ancestors: KernelTests-nice.240 Backported From: KernelTests-fbs.242 Stay in the debugger for longer. Part 5 of _5_. Tests showing the signalling of the new style marker methods. =============== Diff against KernelTests-nice.240 =============== Item was added: + Object subclass: #NotImplementedTestData + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Objects'! Item was added: + ----- Method: NotImplementedTestData>>shouldBeImplementedMsg (in category 'accessing') ----- + shouldBeImplementedMsg + ^ self shouldBeImplemented.! Item was added: + ----- Method: NotImplementedTestData>>shouldNotImplementMsg (in category 'accessing') ----- + shouldNotImplementMsg + ^ self shouldNotImplement.! Item was added: + ----- Method: ObjectTest>>testShouldBeImplemented (in category 'as yet unclassified') ----- + testShouldBeImplemented + | testClass | + testClass := NotImplementedTestData. + self should: [testClass new shouldBeImplementedMsg] raise: NotImplemented. + [testClass new shouldBeImplementedMsg] ifError: [:errDesc | + self assert: (errDesc includesSubString: testClass name) description: 'Error should include class name'. + self assert: (errDesc includesSubString: #shouldBeImplementedMsg asString) description: 'Error should include selector name'].! Item was added: + ----- Method: ObjectTest>>testShouldNotImplement (in category 'as yet unclassified') ----- + testShouldNotImplement + | testClass | + testClass := NotImplementedTestData. + self should: [testClass new shouldNotImplementMsg] raise: NotImplemented. + [testClass new shouldNotImplementMsg] ifError: [:errDesc | + self assert: (errDesc includesSubString: testClass name) description: 'Error should include class name'. + self assert: (errDesc includesSubString: #shouldNotImplementMsg asString) description: 'Error should include selector name'].!

1 0

The Inbox: Tools-fbs.445.mcz
by commits＠source.squeak.org 06 Feb '13

06 Feb '13

Frank Shearar uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-fbs.445.mcz ==================== Summary ==================== Name: Tools-fbs.445 Author: fbs Time: 5 February 2013, 11:14:02.879 pm UUID: 87b52e34-e0e6-4fad-bbf3-5187979c3a12 Ancestors: Tools-bf.439 Backported From: Tools-fbs.444 Stay in the debugger for longer. Part 4 of _5_. Implement the Debugger side of things. Actually _remove_ the frame that signaled the NotImplemented from the call stack. =============== Diff against Tools-bf.439 =============== Item was changed: ----- Method: Debugger>>buildNotifierWith:label:message: (in category 'toolbuilder') ----- buildNotifierWith: builder label: label message: messageString | windowSpec listSpec textSpec panelSpec quads | windowSpec := builder pluggableWindowSpec new. windowSpec model: self. windowSpec extent: 450 @ 156. "nice and wide to show plenty of the error msg" windowSpec label: label. windowSpec children: OrderedCollection new. panelSpec := builder pluggablePanelSpec new. panelSpec children: OrderedCollection new. quads := self preDebugButtonQuads. + (#(#notYetImplemented #shouldBeImplemented #doesNotUnderstand:) includes: self interruptedContext selector) ifTrue: [ - (self interruptedContext selector == #doesNotUnderstand:) ifTrue: [ quads := quads copyWith: { 'Create'. #createMethod. #magenta. 'create the missing method' } ]. + (self interruptedContext selector == #subclassResponsibility) ifTrue: [ + quads := quads copyWith: + { 'Create'. #createOverridingMethod. #magenta. 'create the missing overriding method' } + ]. quads do:[:spec| | buttonSpec | buttonSpec := builder pluggableButtonSpec new. buttonSpec model: self. buttonSpec label: spec first. buttonSpec action: spec second. buttonSpec help: spec fourth. buttonSpec frame: self preDebugButtonQuadFrame. panelSpec children add: buttonSpec. ]. panelSpec layout: #horizontal. "buttons" panelSpec frame: self preDebugButtonQuadFrame. windowSpec children add: panelSpec. Preferences eToyFriendly | messageString notNil ifFalse:[ listSpec := builder pluggableListSpec new. listSpec model: self; list: #contextStackList; getIndex: #contextStackIndex; setIndex: #debugAt:; frame: self contextStackFrame. windowSpec children add: listSpec. ] ifTrue:[ message := messageString. textSpec := builder pluggableTextSpec new. textSpec model: self; getText: #preDebugMessageString; setText: nil; selection: nil; menu: #debugProceedMenu:; frame: self contextStackFrame. windowSpec children add: textSpec. ]. ^windowSpec! Item was changed: ----- Method: Debugger>>createMethod (in category 'private') ----- createMethod "Should only be called when this Debugger was created in response to a MessageNotUnderstood exception. Create a stub for the method that was missing and proceed into it." | msg chosenClass | + msg := self contextStackTop exceptionMessage. - msg := self contextStackTop tempAt: 1. chosenClass := self askForSuperclassOf: self contextStackTop receiver class toImplement: msg selector ifCancel: [^self]. + self implement: msg inClass: chosenClass.! - self implement: msg inClass: chosenClass. - ! Item was added: + ----- Method: Debugger>>createOverridingMethod (in category 'private') ----- + createOverridingMethod + "Should only be called when this Debugger was created in response to a + SubclassResponsibility exception. Create a stub for the method that was + missing and proceed into it." + | msg | + msg := self contextStackTop exceptionMessage. + self implement: msg inClass: self contextStackTop receiver class inCategory: self contextStackTop selectorCategory.! Item was changed: ----- Method: Debugger>>implement:inClass: (in category 'context stack menu') ----- implement: aMessage inClass: aClass + ^ self + implement: aMessage + inClass: aClass + inCategory: (self askForCategoryIn: aClass default: 'as yet unclassified').! - - aClass - compile: aMessage createStubMethod - classified: (self askForCategoryIn: aClass default: 'as yet unclassified'). - self setContentsToForceRefetch. - self selectedContext privRefreshWith: (aClass lookupSelector: aMessage selector). - self selectedContext method numArgs > 0 ifTrue: - [(self selectedContext tempAt: 1) arguments withIndexDo: - [:arg :index| - self selectedContext tempAt: index put: arg]]. - self resetContext: self selectedContext. - self debug. - ! Item was added: + ----- Method: Debugger>>implement:inClass:inCategory: (in category 'context stack menu') ----- + implement: aMessage inClass: aClass inCategory: aSymbol + aClass + compile: aMessage createStubMethod + classified: aSymbol. + self setContentsToForceRefetch. + self selectedContext privRefreshWith: (aClass lookupSelector: aMessage selector). + aMessage numArgs > 0 ifTrue: + [aMessage arguments withIndexDo: + [:arg :index| + self selectedContext tempAt: index put: arg]]. + + "Snip out of the call stack the context that raised the debugger. - the #notYetImplemented send, for example." + self selectedContext privSender: self selectedContext sender sender. + self resetContext: self selectedContext. + self debug.!

1 0

The Inbox: Kernel-fbs.738.mcz
by commits＠source.squeak.org 06 Feb '13

06 Feb '13

Frank Shearar uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-fbs.738.mcz ==================== Summary ==================== Name: Kernel-fbs.738 Author: fbs Time: 5 February 2013, 11:09:23.219 pm UUID: 792498b5-658b-4286-a580-755e9ae392a0 Ancestors: Kernel-nice.731 Backported From: Kernel-fbs.737 Stay in the debugger for longer. Part 3 of _5_. Stack introspection so the Debugger doesn't have to. Signal the new exceptions when necessary. =============== Diff against Kernel-nice.731 =============== Item was added: + ----- Method: ContextPart>>asMessage (in category 'converting') ----- + asMessage + | sender selector args | + sender := self sender. + selector := sender method selector. + args := Array new: selector numArgs. + 1 to: selector numArgs do: [ :i | args at: i put: (sender tempAt: i)]. + ^ Message selector: selector arguments: args.! Item was added: + ----- Method: ContextPart>>exceptionMessage (in category 'accessing') ----- + exceptionMessage + ^ self selector caseOf: { + [#doesNotUnderstand:] -> [self tempAt: 1]. + [#notYetImplemented] -> [self asMessage]. + [#shouldBeImplemented] -> [self asMessage]. + [#subclassResponsibility] -> [self asMessage]} + otherwise: [self error: 'This context is not the result of a message exception.'].! Item was added: + ----- Method: ContextPart>>selectorCategory (in category 'accessing') ----- + selectorCategory + "Return the category to which this message belongs (relative to the receiver). If no superclass categorises this message, use the default." + | organizers | + organizers := self receiver class withAllSuperclasses collect: [:ea | ea organization]. + organizers addFirst: self receiver class organization. + ^ (organizers collect: [ :org | org categoryOfElement: self selector]) + detect: [:ea | ea ~= ClassOrganizer default and: [ ea ~= nil]] + ifNone: [ClassOrganizer default]! Item was added: + ----- Method: MessageSend>>asMessage (in category 'converting') ----- + asMessage + ^ Message selector: selector arguments: arguments.! Item was changed: ----- Method: Object>>shouldBeImplemented (in category 'error handling') ----- shouldBeImplemented "Announce that this message should be implemented" + ^ NotImplemented signal: ('{1} or a superclass should implement {2}' format: {self className. thisContext sender selector})! - self error: 'This message should be implemented'! Item was changed: ----- Method: Object>>shouldNotImplement (in category 'error handling') ----- shouldNotImplement "Announce that, although the receiver inherits this message, it should not implement it." + NotImplemented signal: ('{1} is not a message appropriate for a {2}' format: {thisContext sender selector. self className}).! - self error: 'This message is not appropriate for this object'! Item was changed: ----- Method: Object>>subclassResponsibility (in category 'error handling') ----- subclassResponsibility "This message sets up a framework for the behavior of the class' subclasses. Announce that the subclass should have implemented this message." + ^ SubclassResponsibility + signal: ('My {1} subclass should have overridden {2}' + format: {self className. thisContext sender selector}).! - - self error: 'My subclass should have overridden ', thisContext sender selector printString!

1 0

The Inbox: Exceptions-fbs.43.mcz
by commits＠source.squeak.org 06 Feb '13

06 Feb '13

Frank Shearar uploaded a new version of Exceptions to project The Inbox: http://source.squeak.org/inbox/Exceptions-fbs.43.mcz ==================== Summary ==================== Name: Exceptions-fbs.43 Author: fbs Time: 5 February 2013, 11:06:32.257 pm UUID: 1a5409d5-3bfb-4728-9945-6898e8c3adca Ancestors: Exceptions-cmm.37 Backported From: Exceptions-fbs.42 Stay in the debugger for longer. Part 2 of 3. New exception hierarchy lets interesting parties catch NotImplemented errors to encourage developers to implement missing parts. =============== Diff against Exceptions-cmm.37 =============== Item was changed: + NotImplemented subclass: #MessageNotUnderstood - Error subclass: #MessageNotUnderstood instanceVariableNames: 'message receiver reachedDefaultHandler' classVariableNames: '' poolDictionaries: '' category: 'Exceptions-Kernel'! !MessageNotUnderstood commentStamp: '<historical>' prior: 0! This exception is provided to support Object>>doesNotUnderstand:.! Item was added: + Error subclass: #NotImplemented + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Exceptions-Kernel'! Item was changed: + NotImplemented subclass: #NotYetImplemented - Error subclass: #NotYetImplemented instanceVariableNames: 'receiverClass selector context' classVariableNames: '' poolDictionaries: '' category: 'Exceptions-Kernel'! !NotYetImplemented commentStamp: 'jcg 10/21/2009 01:20' prior: 0! Sent by #notYetImplemented. Better than the age-old behavior of opening a notifier window, because this can be caught and handled. ! Item was removed: - ----- Method: NotYetImplemented>>defaultAction (in category 'handling') ----- - defaultAction - self inform: 'Not yet implemented (', self messageText, ')'! Item was added: + NotImplemented subclass: #SubclassResponsibility + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Exceptions-Kernel'! + + !SubclassResponsibility commentStamp: 'fbs 1/26/2013 00:20' prior: 0! + I am signalled when a subclass fails to implement an "abstract method" and something sends an instance of this subclass the unimplemented message.!

1 0

The Inbox: Morphic-fbs.638.mcz
by commits＠source.squeak.org 06 Feb '13

06 Feb '13

Frank Shearar uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-fbs.638.mcz ==================== Summary ==================== Name: Morphic-fbs.638 Author: fbs Time: 5 February 2013, 11:03:21.697 pm UUID: 78dd37be-9165-4279-a78a-d8892418990f Ancestors: Morphic-bf.636 Backported From: Morphic-fbs.637 Stay in the debugger for longer. Part 1 of 3. UI hooks to create overriding methods. =============== Diff against Morphic-bf.636 =============== Item was added: + ----- Method: PreDebugWindow>>createOverridingMethod (in category 'as yet unclassified') ----- + createOverridingMethod + model createOverridingMethod!

1 0

The Trunk: SUnit-cmm.90.mcz
by commits＠source.squeak.org 05 Feb '13

05 Feb '13

Chris Muller uploaded a new version of SUnit to project The Trunk: http://source.squeak.org/trunk/SUnit-cmm.90.mcz ==================== Summary ==================== Name: SUnit-cmm.90 Author: cmm Time: 4 January 2013, 3:33:36.616 pm UUID: 8533f0b4-2587-412b-b465-4ad7f20331d0 Ancestors: SUnit-ul.89 - Do not wipe out pre-initialized state on TestCases. Tests do not need to be prevented from running more than once if proper setUp/tearDown methods are present. =============== Diff against SUnit-ul.89 =============== Item was changed: ----- Method: TestCase>>debug (in category 'running') ----- debug + self resources do: + [ : res | res isAvailable ifFalse: [ ^ res signalInitializationError ] ]. + [ self runCase ] ensure: + [ self resources do: + [ : each | each reset ] ]! - self resources do: [:res | - res isAvailable ifFalse: [^res signalInitializationError]]. - [(self class selector: testSelector) runCase] - ensure: [self resources do: [:each | each reset]] - !

1 0

Tutorial videos
by tim Rowledge 04 Feb '13

04 Feb '13

I've just spent a ridiculous amount of time trying to explain to a curious new-user how to open the Score Player and use it to play a midi file. It took probably ten times as long as a suitable video tutorial would run for. Has anybody done some videos? Would anyone like to? I'm thinking 2/3/4 minute snippets on different themes to introduce newcomers to the wild list of stuff we can do. Make a nice big batch of them, stick'em on youtube and become a star! Hang on a mo'. Looks like Lawson English has done a pretty decent list already - good for you Lawson. And a few other contributors; excellent start. We could do with a good list of them for the website as introductions. I only found one very short sound related vid though. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: LOW: Launch on Warning

4 4

Release 4.4?
by Colin Putney 04 Feb '13

04 Feb '13

Is there a 4.4 image available anywhere? Oughtn't we make it available for download on ftp.squeak.org? Colin

5 7

Jump to page: