Squeak-dev January 2013

squeak-dev@lists.squeakfoundation.org

105 participants
332 discussions

The Inbox: Kernel-fbs.735.mcz
by commits＠source.squeak.org 30 Jan '13

30 Jan '13

Frank Shearar uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-fbs.735.mcz ==================== Summary ==================== Name: Kernel-fbs.735 Author: fbs Time: 30 January 2013, 6:33:47.078 pm UUID: 18ffff61-cfcf-4843-8c64-caea3ceb3fbc Ancestors: Kernel-fbs.734 Actually, return a Message, and find out the receiver of the Message from the signalercontext. Also, _returning_ the value of #subclassResponsibility means that you can return to the original caller the value of your just implemented method. =============== Diff against Kernel-fbs.734 =============== Item was added: + ----- Method: ContextPart>>asMessage (in category 'converting') ----- + asMessage + | sender selector args | + sender := self sender. + selector := sender method selector. + args := Array new: selector numArgs. + 1 to: selector numArgs do: [ :i | args at: i put: (sender tempAt: i)]. + ^ Message selector: selector arguments: args.! Item was removed: - ----- Method: ContextPart>>asMessageSend (in category 'converting') ----- - asMessageSend - | sender selector args | - sender := self sender. - selector := sender method selector. - args := Array new: selector numArgs. - 1 to: selector numArgs do: [ :i | args at: i put: (sender tempAt: i)]. - ^ MessageSend receiver: self receiver selector: selector arguments: args.! Item was changed: ----- Method: ContextPart>>exceptionMessage (in category 'accessing') ----- exceptionMessage ^ self selector caseOf: { [#doesNotUnderstand:] -> [self tempAt: 1]. + [#subclassResponsibility] -> [self asMessage]} - [#subclassResponsibility] -> [self asMessageSend]} otherwise: [self error: 'This context is not the result of a message exception.'].! Item was added: + ----- Method: ContextPart>>selectorCategory (in category 'accessing') ----- + selectorCategory + "Return the category to which this message belongs (relative to the receiver). If no superclass categorises this message, use the default." + | organizers | + organizers := self receiver class withAllSuperclasses collect: [:ea | ea organization]. + organizers addFirst: self receiver class organization. + ^ (organizers collect: [ :org | org categoryOfElement: self selector]) + detect: [:ea | ea ~= ClassOrganizer default and: [ ea ~= nil]] + ifNone: [ClassOrganizer default]! Item was removed: - ----- Method: MessageSend>>selectorCategory (in category 'accessing') ----- - selectorCategory - "Return the category to which this message belongs (relative to the receiver). If no superclass categorises this message, use the default." - | organizers | - organizers := receiver class withAllSuperclasses collect: [:ea | ea organization]. - organizers addFirst: receiver class organization. - ^ (organizers collect: [ :org | org categoryOfElement: selector]) - detect: [:ea | ea ~= ClassOrganizer default and: [ ea ~= nil]] - ifNone: [ClassOrganizer default]! Item was changed: ----- Method: Object>>shouldBeImplemented (in category 'error handling') ----- shouldBeImplemented "Announce that this message should be implemented" + ^ NotImplementedError signal: ('{1} or a superclass should implement {2}' format: {self className. thisContext sender selector})! - NotImplementedError signal: ('{1} or a superclass should implement {2}' format: {self className. thisContext sender selector})! Item was changed: ----- Method: Object>>subclassResponsibility (in category 'error handling') ----- subclassResponsibility "This message sets up a framework for the behavior of the class' subclasses. Announce that the subclass should have implemented this message." + ^ SubclassResponsibilityError - SubclassResponsibilityError signal: ('My {1} subclass should have overridden {2}' format: {self className. thisContext sender selector}).!

1 0

Re: I hate 'as yet unclassified'
by Stephan Eggermont 30 Jan '13

30 Jan '13

As there was a discussion on the Pharo mailing list on the number of these methods, I thought to check in the 4.3 one-click too. Some synchronisation would be possible by adding a hash over the method source, compare one method in the other system to see if it was classified there. Stephan #unclassified methods by package Etoys-Experimental 126 Morphic-Widgets 112 MorphicExtras-GeeMail 94 Collections-Text 90 Monticello-Repositories 79 ToolsTests-Browser 76 Multilingual-Display 76 Monticello-UI 72 Nebraska-Morphic-Collaborative 62 Monticello-Versioning 61 Tests-Monticello 52 Multilingual-TextConversion 49 Monticello-Merging 46 MorphicExtras-Demo 46 Morphic-Windows 45 MorphicExtras-Books 39 Etoys-Outliner 35 Tools-Browser 33 Network-RemoteDirectory 33 Tests-Bugs 32 Compression-Streams 32 Monticello-Storing 31 Sound-Scores 28 Tests-Monticello-Mocks 28 MorphicExtras-Navigators 27 MorphicExtras-AdditionalSupport 25 Morphic-Explorer 24 Nebraska-Morphic-Remote 22 Monticello-Patching 22 Tests-Files 20 Monticello-Chunk Format 20 Morphic-Text Support 20 Nebraska-Morphic-Experimental 20 Exceptions-Kernel 16 MorphicExtras-Text Support 16 MorphicExtras-Support 15 Monticello-Modeling 15 Sound-Synthesis 14 Tools-Inspector 14 MorphicExtras-Palettes 11 MorphicExtras-SoundInterface 10 Collections-Streams 10 TraitsTests-Kernel 10 Tests-Utilities 9 System-Changes 9 ST80-Pluggable Views 9 MorphicExtras-AdditionalWidgets 8 Installer-Core 7 Compiler-Exceptions 7 Morphic-Menus-DockingBar 7 Nebraska-Network-ObjectSocket 7 Files-Kernel 7 Monticello-Loading 6 ST80-Views 6 MorphicExtras-Widgets 6 MorphicExtras-AdditionalMorphs 6 Tests-ObjectsAsMethods 6 Multilingual-Editor 5 SMBase-domain 5 MorphicTests-Widgets 5 Nebraska-Audio Chat 5 MorphicTests-Kernel 5 ToolBuilder-Kernel 5 ST80-Controllers 4 Etoys-Stacks 4 Morphic-Menus 4 ST80-Framework 4 MorphicExtras-SqueakPage 4 CollectionsTests-Weak 4 MorphicTests-Layouts 4 Morphic-Pluggable Widgets 4 SUnit-Tests 4 Tests-Hex 4 ToolBuilder-SUnit 3 Etoys-Scripting 3 Graphics-Fonts 3 Kernel-Methods 3 Multilingual-Scanning 3 Files-Directories 3 SUnit-Extensions 3 ToolBuilder-Morphic 3 SystemChangeNotification-Tests 3 Morphic-Basic 3 ST80-Support 2 Network-Kernel 2 Etoys-Scripting Tiles 2 Kernel-Classes 2 Graphics-Primitives 2 Collections-Arrayed 2 MorphicExtras-Postscript Canvases 2 Services-Base 2 Graphics-Display Objects 2 Balloon-Fills 2 NetworkTests-UUID 1 PackageInfo-Base 1 Tools-FileList 1 CollectionsTests-Text 1 NetworkTests-RFC822 1 Services-Base-GUI 1 Tests-System-Support 1 System-Support 1 ST80-Editors 1 Etoys-Tile Scriptors 1 System-FileRegistry 1 Etoys-Scripting Support 1 NetworkTests-Url 1 Morphic-Kernel 1 ToolsTests-Inspector 1 #unclassified methods by author RAA 438 stephaneducasse 145 ar 144 avi 99 yo 97 gvc 80 fbs 80 tk 80 di 76 nice 73 ab 73 sd 58 jm 47 dgd 44 sw 41 ul 35 nk 35 cmm 27 27 cwp 26 bf 26 md 19 kb 12 wiz 12 jrp 11 kph 7 dvf 6 Tsutomu 6 ajh 6 mjr 6 ls 6 rej 6 apb 5 dtl 5 acg 4 gk 4 sbw 4 abc 4 bp 4 nb 4 jmv 3 spfa 3 laza 3 rr 3 JPF 3 MarcusDenker 3 al 3 Igor.Stasenko 3 BG 2 tetha 2 pk 2 btc 2 jrd 2 eem 2 mha 2 tfel 2 mir 1 jcg 1 mist 1 LC 1 tlk 1 djp 1 sumim 1 DSM 1 TN 1 aoy 1 DF 1 alain.plantec 1 gm 1 th 1 bvs 1 sma 1 jf 1 sps 1 tonyg 1 hh 1 tak 1 '

2 2

The Trunk: CollectionsTests-cmm.196.mcz
by commits＠source.squeak.org 30 Jan '13

30 Jan '13

Chris Muller uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-cmm.196.mcz ==================== Summary ==================== Name: CollectionsTests-cmm.196 Author: cmm Time: 30 January 2013, 10:43:47.826 am UUID: 325b1f24-eee1-4aaa-82fc-fe7fc2cb8525 Ancestors: CollectionsTests-cmm.195 fix =============== Diff against CollectionsTests-cmm.195 =============== Item was changed: ----- Method: FloatCollectionTest>>testInternalArray (in category 'tests') ----- testInternalArray | fc internalArray | fc := FloatCollection new. self deny: (internalArray := fc instVarNamed: 'array') class isPointers ; assert: fc isEmpty. internalArray size + 1 timesRepeat: [ fc add: 0.0 ]. self + assert: fc size = (internalArray size + 1) ; - assert: fc size = internalArray size + 1 ; assert: (fc instVarNamed: 'array') size = (internalArray size * 2)!

1 0

The Trunk: Collections-cmm.500.mcz
by commits＠source.squeak.org 30 Jan '13

30 Jan '13

Chris Muller uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-cmm.500.mcz ==================== Summary ==================== Name: Collections-cmm.500 Author: cmm Time: 30 January 2013, 10:42:57.578 am UUID: 0a0b5dd7-a9c6-4f08-ad24-e7e36f33a21b Ancestors: Collections-cmm.499 Categorize overridden method. =============== Diff against Collections-cmm.499 =============== Item was changed: + ----- Method: FloatCollection>>addLast: (in category 'adding') ----- - ----- Method: FloatCollection>>addLast: (in category 'as yet unclassified') ----- addLast: aFloat aFloat isNumber ifFalse: [ self error: 'This collection can only store Floats.' ]. ^ super addLast: aFloat!

1 0

Re: [squeak-dev] The Trunk: Collections-cmm.499.mcz
by Frank Shearar 30 Jan '13

30 Jan '13

On 29 January 2013 02:19, <commits(a)source.squeak.org> wrote: > Chris Muller uploaded a new version of Collections to project The Trunk: > http://source.squeak.org/trunk/Collections-cmm.499.mcz > > ==================== Summary ==================== > > Name: Collections-cmm.499 > Author: cmm > Time: 28 January 2013, 8:19:08.858 pm > UUID: 9af9bd27-3342-4203-88e5-22c85c57d5ae > Ancestors: Collections-bf.498 > > FloatCollection inherits the convenient add:/remove: API of OrderedCollection, but using an internal FloatArray for better efficiency. > > =============== Diff against Collections-bf.498 =============== > > Item was added: > + OrderedCollection subclass: #FloatCollection > + instanceVariableNames: '' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'Collections-Sequenceable'! > + > + !FloatCollection commentStamp: 'cmm 1/28/2013 19:49' prior: 0! > + FloatCollctions store 32bit IEEE floating point numbers.! > > Item was added: > + ----- Method: FloatCollection class>>arrayType (in category 'overriding') ----- > + arrayType > + ^ FloatArray! > > Item was added: > + ----- Method: FloatCollection>>addLast: (in category 'as yet unclassified') ----- > + addLast: aFloat > + aFloat isNumber ifFalse: [ self error: 'This collection can only store Floats.' ]. > + ^ super addLast: aFloat! I just noticed that CI says you're wrong: http://build.squeak.org/job/SqueakTrunk/lastBuild/testReport/junit/Collecti… Regressions: FloatCollectionTest>>testInternalArray FloatCollectionTest(ClassTestCase)>>testUnCategorizedMethods (Well, I say "you're wrong" but this is just the most recent commit to FloatCollection. You might be exposing a deficiency in the tests.) frank

1 0

Problem with my account
by Daniel Aviv Notario 30 Jan '13

30 Jan '13

Hi! I been experiencing a problem with my squeaksource account. My profile keeps getting removed for apparently no reason. I first noticed the in the project I work i was no longer developer, so I cannot commit my changes. but when an administrator tries to add me, my profile doesn't exists. Greetings!Daniel Aviv Notario

2 1

FW: Please VOTE!!
by Ron Teitelbaum 30 Jan '13

30 Jan '13

Hi All, I just wanted to send a reminder that the Squeak Oversight Board election ballots have gone out. Please VOTE!! It's easy to forget or lose track of the email, so please vote while you still know where the email is! The subject is: Poll: Squeak Oversight Board 2013 Sent on 28th of Jan between 5 and 6pm Eastern Time. From: andru(a)cs.cornell.edu; on behalf of; Ron Teitelbaum (CIVS poll supervisor) ron(a)usmedrec.com Thank you!! Ron Teitelbaum

1 0

The Inbox: Tools-fbs.442.mcz
by commits＠source.squeak.org 30 Jan '13

30 Jan '13

Frank Shearar uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-fbs.442.mcz ==================== Summary ==================== Name: Tools-fbs.442 Author: fbs Time: 30 January 2013, 12:31:30.073 pm UUID: e0c3f13d-4fb8-4ade-af04-90f3fcc79a1b Ancestors: Tools-fbs.441 Use the new exceptionMessage. =============== Diff against Tools-fbs.441 =============== Item was changed: ----- Method: Debugger>>createMethod (in category 'private') ----- createMethod "Should only be called when this Debugger was created in response to a MessageNotUnderstood exception. Create a stub for the method that was missing and proceed into it." | msg chosenClass | + msg := self contextStackTop exceptionMessage. - msg := self contextStackTop tempAt: 1. chosenClass := self askForSuperclassOf: self contextStackTop receiver class toImplement: msg selector ifCancel: [^self]. + self implement: msg message inClass: chosenClass. - self implement: msg inClass: chosenClass. ! Item was changed: ----- Method: Debugger>>createOverridingMethod (in category 'private') ----- createOverridingMethod "Should only be called when this Debugger was created in response to a SubclassResponsibility exception. Create a stub for the method that was missing and proceed into it." | msgSend | + msgSend := self contextStackTop exceptionMessage. - msgSend := self contextStackTop invocationMessage. self implement: msgSend asMessage inClass: msgSend receiver class inCategory: msgSend selectorCategory.!

1 0

The Inbox: KernelTests-fbs.241.mcz
by commits＠source.squeak.org 30 Jan '13

30 Jan '13

Frank Shearar uploaded a new version of KernelTests to project The Inbox: http://source.squeak.org/inbox/KernelTests-fbs.241.mcz ==================== Summary ==================== Name: KernelTests-fbs.241 Author: fbs Time: 30 January 2013, 12:30:48.257 pm UUID: fa6acfce-7077-4564-88bf-8e1dfafcb7e2 Ancestors: KernelTests-nice.240 Tests for Kernel-fbs.734. Suggestions for avoiding the repeated execution of the method under test welcome! =============== Diff against KernelTests-nice.240 =============== Item was added: + Object subclass: #NotImplementedTestData + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Objects'! Item was added: + ----- Method: NotImplementedTestData>>shouldBeImplementedMsg (in category 'accessing') ----- + shouldBeImplementedMsg + ^ self shouldBeImplemented.! Item was added: + ----- Method: NotImplementedTestData>>shouldNotImplementMsg (in category 'accessing') ----- + shouldNotImplementMsg + ^ self shouldNotImplement.! Item was added: + ----- Method: ObjectTest>>testShouldBeImplemented (in category 'as yet unclassified') ----- + testShouldBeImplemented + | testClass | + testClass := NotImplementedTestData. + self should: [testClass new shouldBeImplementedMsg] raise: NotImplementedError. + [testClass new shouldBeImplementedMsg] ifError: [:errDesc | + self assert: (errDesc includesSubString: testClass name) description: 'Error should include class name'. + self assert: (errDesc includesSubString: #shouldBeImplementedMsg asString) description: 'Error should include selector name'].! Item was added: + ----- Method: ObjectTest>>testShouldNotImplement (in category 'as yet unclassified') ----- + testShouldNotImplement + | testClass | + testClass := NotImplementedTestData. + self should: [testClass new shouldNotImplementMsg] raise: NotImplementedError. + [testClass new shouldNotImplementMsg] ifError: [:errDesc | + self assert: (errDesc includesSubString: testClass name) description: 'Error should include class name'. + self assert: (errDesc includesSubString: #shouldNotImplementMsg asString) description: 'Error should include selector name'].!

1 0

The Inbox: Kernel-fbs.734.mcz
by commits＠source.squeak.org 30 Jan '13

30 Jan '13

Frank Shearar uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-fbs.734.mcz ==================== Summary ==================== Name: Kernel-fbs.734 Author: fbs Time: 30 January 2013, 12:29:05.829 pm UUID: ef47c409-cc2c-4e5f-a903-d71ead6268e5 Ancestors: Kernel-fbs.733 Implement Eliot's suggestions: * make the throwing of a NotImplementedError the standard behvaiour for these related selectors; * I went with "exceptionMessage" rather than "messageException" because the latter sounds like something that returns an exception. * Pulled asMessageSend out because it makes the caseOf: easier to read and (YAGNI alert) it's more generally useful. =============== Diff against Kernel-fbs.733 =============== Item was added: + ----- Method: ContextPart>>asMessageSend (in category 'converting') ----- + asMessageSend + | sender selector args | + sender := self sender. + selector := sender method selector. + args := Array new: selector numArgs. + 1 to: selector numArgs do: [ :i | args at: i put: (sender tempAt: i)]. + ^ MessageSend receiver: self receiver selector: selector arguments: args.! Item was added: + ----- Method: ContextPart>>exceptionMessage (in category 'accessing') ----- + exceptionMessage + ^ self selector caseOf: { + [#doesNotUnderstand:] -> [self tempAt: 1]. + [#subclassResponsibility] -> [self asMessageSend]} + otherwise: [self error: 'This context is not the result of a message exception.'].! Item was removed: - ----- Method: ContextPart>>invocationMessage (in category 'accessing') ----- - invocationMessage - "Upon sending messages like #doesNotUnderstand: or #subclassResponsibility - methods that will pop up a Debugger - return the Message that prompted the Debugger." - | sender selector args | - (self method selector == #doesNotUnderstand:) ifTrue: [^ self tempAt: 1]. - sender := self sender. - selector := sender method selector. - args := Array new: selector numArgs. - 1 to: selector numArgs do: [ :i | args at: i put: (sender tempAt: i)]. - ^ MessageSend receiver: self receiver selector: selector arguments: args.! Item was changed: ----- Method: Object>>shouldBeImplemented (in category 'error handling') ----- shouldBeImplemented "Announce that this message should be implemented" + NotImplementedError signal: ('{1} or a superclass should implement {2}' format: {self className. thisContext sender selector})! - self error: 'This message should be implemented'! Item was changed: ----- Method: Object>>shouldNotImplement (in category 'error handling') ----- shouldNotImplement "Announce that, although the receiver inherits this message, it should not implement it." + NotImplementedError signal: ('{1} is not a message appropriate for a {2}' format: {thisContext sender selector. self className}).! - self error: 'This message is not appropriate for this object'!

1 0

← Newer
1
2
3
4
5
6
7
8
...
34
Older →

Jump to page: