Squeak-dev September 2012

squeak-dev@lists.squeakfoundation.org

36 participants
151 discussions

The Inbox: System-cmm.497.mcz
by commits＠source.squeak.org 14 Sep '12

14 Sep '12

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-cmm.497.mcz ==================== Summary ==================== Name: System-cmm.497 Author: cmm Time: 14 September 2012, 3:14:45.552 pm UUID: d55d42e9-1782-4cdd-a0d0-253bf60940f5 Ancestors: System-ul.496 Updates for the Author proposal: - Completely separate the model from the UI. Author should be a "pure domain object." The PerSe methods are no longer needed. - Instead, let Utilities class take responsibility for employing Squeak UI-elements to set the current Author attributes, as well as for being the "convenient" way to access these attributes. - Since we are reifying an Author from a String, it is now treated as a whole Author object, rather than just a String-holder. Allow multiple Author instances to exist and the #current Author can be swapped out with another Author instance. =============== Diff against System-ul.496 =============== Item was removed: - ----- Method: Author class>>changeStamp (in category 'convenience') ----- - changeStamp - - ^self current changeStamp! Item was removed: - ----- Method: Author class>>changeStampPerSe (in category 'convenience') ----- - changeStampPerSe - - ^self current changeStampPerSe! Item was changed: ----- Method: Author class>>current (in category 'instance creation') ----- current + ^ instance ifNil: + [ self current: self new. + instance ]! - - ^instance ifNil: [ instance := super new ]! Item was added: + ----- Method: Author class>>current: (in category 'class initialization') ----- + current: anAuthor + instance := anAuthor! Item was changed: ----- Method: Author class>>fullNamePerSe (in category 'pharo compatibility') ----- fullNamePerSe + ^ self current initials! - - ^self initialsPerSe! Item was removed: - ----- Method: Author class>>initials (in category 'convenience') ----- - initials - - ^self current initials! Item was removed: - ----- Method: Author class>>initialsPerSe (in category 'convenience') ----- - initialsPerSe - - ^self current initialsPerSe! Item was removed: - ----- Method: Author class>>new (in category 'instance creation') ----- - new - - self error: 'Use #current'! Item was changed: ----- Method: Author class>>reset (in category 'instance creation') ----- reset + self current: nil! - - instance := nil! Item was changed: ----- Method: Author class>>useAuthor:during: (in category 'pharo compatibility') ----- + useAuthor: aString during: aBlock + ^ self current + useInitials: aString + during: aBlock! - useAuthor: aString during: aBlock - - ^self useInitials: aString during: aBlock! Item was removed: - ----- Method: Author class>>useInitials:during: (in category 'convenience') ----- - useInitials: aString during: aBlock - - ^self current useInitials: aString during: aBlock! Item was removed: - ----- Method: Author class>>username (in category 'convenience') ----- - username - - ^self current username! Item was removed: - ----- Method: Author class>>usernamePerSe (in category 'convenience') ----- - usernamePerSe - - ^self current usernamePerSe! Item was changed: ----- Method: Author>>changeStamp (in category 'accessing') ----- changeStamp + ^ self changeStampWithInitials: (self initials ifEmpty: [ 'unknown' ])! - - ^self changeStampWithInitials: self initials! Item was removed: - ----- Method: Author>>changeStampPerSe (in category 'accessing') ----- - changeStampPerSe - - ^self changeStampWithInitials: (self initialsPerSe ifEmpty: [ '.' ])! Item was changed: ----- Method: Author>>fullName (in category 'pharo compatibility') ----- fullName + ^ self initials! - - ^self initials! Item was removed: - ----- Method: Author>>fullNamePerSe (in category 'pharo compatibility') ----- - fullNamePerSe - - ^self initialsPerSe! Item was changed: ----- Method: Author>>initialize (in category 'initialize-release') ----- initialize - super initialize. + initials := username := String empty! - initials := String new. - username := String new - ! Item was changed: ----- Method: Author>>initials (in category 'accessing') ----- initials + ^ initials! - - ^initials ifEmpty: [ self requestAndSetInitials ]! Item was removed: - ----- Method: Author>>initialsPerSe (in category 'accessing') ----- - initialsPerSe - - ^initials! Item was removed: - ----- Method: Author>>requestAndSetInitials (in category 'accessing') ----- - requestAndSetInitials - - ^initials := (UIManager default - request: 'Please type your initials: ' translated - initialAnswer: initials) select: [ :each | - #( - ($A $Z) - ($a $z) - ($0 $9)) anySatisfy: [ :range | - each between: range first and: range second ] ]! Item was removed: - ----- Method: Author>>requestAndSetUsername (in category 'accessing') ----- - requestAndSetUsername - - ^username := UIManager default - request: 'Please type your name:' translated - initialAnswer: (username - ifEmpty: [ 'Your Name' translated ] - ifNotEmpty: [ username ])! Item was changed: ----- Method: Author>>username (in category 'accessing') ----- username + ^ username! - - ^username ifEmpty: [ self requestAndSetUsername ]! Item was removed: - ----- Method: Author>>usernamePerSe (in category 'accessing') ----- - usernamePerSe - - ^username! Item was changed: ----- Method: SpaceTally>>spaceTally: (in category 'class analysis') ----- + spaceTally: classes - spaceTally: classes "Answer a collection of SpaceTallyItems representing the memory space (in bytes) consumed by the code and instances of each class in the system. Note that code sizes do not currently report memory consumed by class variables. " - "((SpaceTally new spaceTally: (Array with: TextMorph with: Point)) asSortedCollection: [:a :b | a spaceForInstances > b spaceForInstances]) asArray" - self preAllocateResultsFor: classes. Smalltalk garbageCollect. self computeSpaceUsage. ^ results + sort: [ : a : b | a spaceForInstances > b spaceForInstances ] ; + yourself! - ! Item was changed: ----- Method: Utilities class>>authorInitials (in category 'identification') ----- authorInitials + "Answer the initials to be used to identify the current code author." + ^ self authorInitialsPerSe ifEmpty: + [ self + setAuthorInitials ; + authorInitialsPerSe ]! - "Answer the initials to be used to identify the current code author. " - - ^Author initials! Item was changed: ----- Method: Utilities class>>authorInitialsPerSe (in category 'identification') ----- authorInitialsPerSe + ^ Author current initials! - "Answer the currently-prevailing author initials, such as they, empty or not" - - ^Author initialsPerSe! Item was changed: ----- Method: Utilities class>>authorName (in category 'identification') ----- authorName + ^ self authorNamePerSe ifEmpty: + [ self + setAuthorName ; + authorNamePerSe ]! - - ^Author username! Item was changed: ----- Method: Utilities class>>authorNamePerSe (in category 'identification') ----- authorNamePerSe + ^ Author current username! - - ^Author usernamePerSe! Item was changed: ----- Method: Utilities class>>changeStamp (in category 'identification') ----- + changeStamp + ^ Author current changeStampWithInitials: self authorInitials! - changeStamp - - ^Author changeStamp! Item was changed: ----- Method: Utilities class>>changeStampPerSe (in category 'identification') ----- changeStampPerSe + ^ Author current changeStamp! - - ^Author changeStampPerSe! Item was changed: ----- Method: Utilities class>>setAuthorInitials (in category 'identification') ----- setAuthorInitials "Put up a dialog allowing the user to specify the author's initials. " + | oldInitials | + oldInitials := Author current initials. + Author reset. + Author current initials: + ((UIManager default + request: 'Please type your initials: ' translated + initialAnswer: oldInitials) select: [ : each | each isOctetCharacter and: [ each isAlphaNumeric ] ])! - - ^Author current requestAndSetInitials! Item was changed: ----- Method: Utilities class>>setAuthorName (in category 'identification') ----- setAuthorName + Author current username: + (UIManager default + request: 'Please type your name:' translated + initialAnswer: (Author current username ifEmpty: [ 'Your Name' translated ]))! - - Author requestAndSetUsername!

1 0

The Inbox: System-ul.496.mcz
by commits＠source.squeak.org 14 Sep '12

14 Sep '12

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-ul.496.mcz ==================== Summary ==================== Name: System-ul.496 Author: ul Time: 14 September 2012, 2:54:39.996 pm UUID: 762fe830-0bfc-f545-b636-7811666df4ab Ancestors: System-ul.495 - redirect author related methods from Utilities to Author - removed AuthorInitials and AuthorName from Utilities =============== Diff against System-ul.495 =============== Item was changed: Object subclass: #Utilities instanceVariableNames: '' + classVariableNames: 'CommonRequestStrings LastStats RecentSubmissions ScrapsBook UpdateDownloader UpdateUrlLists' - classVariableNames: 'AuthorInitials AuthorName CommonRequestStrings LastStats RecentSubmissions ScrapsBook UpdateDownloader UpdateUrlLists' poolDictionaries: '' category: 'System-Support'! !Utilities commentStamp: '<historical>' prior: 0! A repository for general and miscellaneous utilities; much of what is here are in effect global methods that don't naturally attach to anything else. 1/96 sw! Item was changed: ----- Method: Utilities class>>authorInitials (in category 'identification') ----- authorInitials "Answer the initials to be used to identify the current code author. " + ^Author initials! - [AuthorInitials isEmpty] whileTrue: [self setAuthorInitials]. - ^ AuthorInitials! Item was changed: ----- Method: Utilities class>>authorInitialsPerSe (in category 'identification') ----- authorInitialsPerSe "Answer the currently-prevailing author initials, such as they, empty or not" + ^Author initialsPerSe! - ^ AuthorInitials! Item was changed: ----- Method: Utilities class>>authorName (in category 'identification') ----- authorName + + ^Author username! - AuthorName ifEmpty: [self setAuthorName]. - ^ AuthorName! Item was changed: ----- Method: Utilities class>>authorName: (in category 'identification') ----- authorName: aString + + Author current username: aString! - AuthorName := aString! Item was changed: ----- Method: Utilities class>>authorNamePerSe (in category 'identification') ----- authorNamePerSe + ^Author usernamePerSe! - ^ AuthorName! Item was changed: ----- Method: Utilities class>>changeStamp (in category 'identification') ----- changeStamp + + ^Author changeStamp! - "Answer a string to be pasted into source code to mark who changed it and when." - ^ self authorInitials , ' ' , Date today mmddyyyy, ' ', - ((String streamContents: [:s | Time now print24: true on: s]) copyFrom: 1 to: 5)! Item was changed: ----- Method: Utilities class>>changeStampPerSe (in category 'identification') ----- changeStampPerSe + + ^Author changeStampPerSe! - "Answer a string to be pasted into source code to mark who changed it and when." - ^String streamContents: - [ : stream | - self authorInitialsPerSe isEmptyOrNil - ifTrue: [ '·' ] - ifFalse: [ self authorInitialsPerSe ]. - stream - space ; - nextPutAll: Date today mmddyyyy ; - space. - (String streamContents: - [ : s | - Time now - print24: true - on: s ]) - copyFrom: 1 - to: 5 ]! Item was changed: ----- Method: Utilities class>>setAuthorInitials (in category 'identification') ----- setAuthorInitials "Put up a dialog allowing the user to specify the author's initials. " + ^Author current requestAndSetInitials! - self setAuthorInitials: - (UIManager default request: 'Please type your initials: ' translated - initialAnswer: AuthorInitials)! Item was changed: ----- Method: Utilities class>>setAuthorInitials: (in category 'identification') ----- setAuthorInitials: aString + Author current initials: aString! - AuthorInitials := aString. - - "Case of being reset due to, eg, copy of image." - aString isEmpty ifTrue: [AuthorName := '']! Item was changed: ----- Method: Utilities class>>setAuthorName (in category 'identification') ----- setAuthorName + + Author requestAndSetUsername! - AuthorName := UIManager default - request: 'Please type your name:' translated - initialAnswer: 'Your Name' translated!

1 0

The Inbox: System-ul.495.mcz
by commits＠source.squeak.org 14 Sep '12

14 Sep '12

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-ul.495.mcz ==================== Summary ==================== Name: System-ul.495 Author: ul Time: 14 September 2012, 2:47:25.624 pm UUID: c4133398-9e02-a244-afd6-c90922184a3c Ancestors: System-ul.494 Extracted author information from Utilities into Author, similar to how it's done in Pharo, but fully backwards compatible. It also has some methods for Pharo compatibility. =============== Diff against System-ul.494 =============== Item was added: + Object subclass: #Author + instanceVariableNames: 'initials username' + classVariableNames: '' + poolDictionaries: '' + category: 'System-Support'! + Author class + instanceVariableNames: 'instance'! + + !Author commentStamp: 'ul 9/14/2012 14:43' prior: 0! + I am responsible for the initials and the name used to identify the current code author. + + Instance Variables + initials: <String> + username: <String> + + initials + - a String conatining the initials of the user. It should consist of ascii alphanumeric characters, because it's being used in method stamps and those are not encoded in the changes and sources files. + + username + - a String containing the name of the current user + ! + Author class + instanceVariableNames: 'instance'! Item was added: + ----- Method: Author class>>changeStamp (in category 'convenience') ----- + changeStamp + + ^self current changeStamp! Item was added: + ----- Method: Author class>>changeStampPerSe (in category 'convenience') ----- + changeStampPerSe + + ^self current changeStampPerSe! Item was added: + ----- Method: Author class>>current (in category 'instance creation') ----- + current + + ^instance ifNil: [ instance := super new ]! Item was added: + ----- Method: Author class>>fullName (in category 'pharo compatibility') ----- + fullName + + ^self initials! Item was added: + ----- Method: Author class>>fullNamePerSe (in category 'pharo compatibility') ----- + fullNamePerSe + + ^self initialsPerSe! Item was added: + ----- Method: Author class>>initialize (in category 'class initialization') ----- + initialize + + self current initializeFromUtilities! Item was added: + ----- Method: Author class>>initials (in category 'convenience') ----- + initials + + ^self current initials! Item was added: + ----- Method: Author class>>initialsPerSe (in category 'convenience') ----- + initialsPerSe + + ^self current initialsPerSe! Item was added: + ----- Method: Author class>>new (in category 'instance creation') ----- + new + + self error: 'Use #current'! Item was added: + ----- Method: Author class>>reset (in category 'instance creation') ----- + reset + + instance := nil! Item was added: + ----- Method: Author class>>uniqueInstance (in category 'pharo compatibility') ----- + uniqueInstance + + ^self current! Item was added: + ----- Method: Author class>>useAuthor:during: (in category 'pharo compatibility') ----- + useAuthor: aString during: aBlock + + ^self useInitials: aString during: aBlock! Item was added: + ----- Method: Author class>>useInitials:during: (in category 'convenience') ----- + useInitials: aString during: aBlock + + ^self current useInitials: aString during: aBlock! Item was added: + ----- Method: Author class>>username (in category 'convenience') ----- + username + + ^self current username! Item was added: + ----- Method: Author class>>usernamePerSe (in category 'convenience') ----- + usernamePerSe + + ^self current usernamePerSe! Item was added: + ----- Method: Author>>changeStamp (in category 'accessing') ----- + changeStamp + + ^self changeStampWithInitials: self initials! Item was added: + ----- Method: Author>>changeStampPerSe (in category 'accessing') ----- + changeStampPerSe + + ^self changeStampWithInitials: (self initialsPerSe ifEmpty: [ '.' ])! Item was added: + ----- Method: Author>>changeStampWithInitials: (in category 'utility') ----- + changeStampWithInitials: aString + + ^String streamContents: [ :stream | + stream + nextPutAll: aString; + space; + nextPutAll: Date today mmddyyyy; + space. + Time now print24: true showSeconds: false on: stream ] ! Item was added: + ----- Method: Author>>fullName (in category 'pharo compatibility') ----- + fullName + + ^self initials! Item was added: + ----- Method: Author>>fullNamePerSe (in category 'pharo compatibility') ----- + fullNamePerSe + + ^self initialsPerSe! Item was added: + ----- Method: Author>>ifUnknownAuthorUse:during: (in category 'pharo compatibility') ----- + ifUnknownAuthorUse: aString during: aBlock + + initials ifEmpty: [ + ^self + useAuthor: aString + during: aBlock ]. + ^aBlock value! Item was added: + ----- Method: Author>>initialize (in category 'initialize-release') ----- + initialize + + super initialize. + initials := String new. + username := String new + ! Item was added: + ----- Method: Author>>initializeFromUtilities (in category 'migration') ----- + initializeFromUtilities + + (Smalltalk classNamed: #Utilities) ifNotNil: [ :utilities | + (utilities respondsTo: #authorInitialsPerSe) ifTrue: [ + initials := utilities authorInitialsPerSe ]. + (utilities respondsTo: #authorNamePerSe) ifTrue: [ + username := utilities authorNamePerSe ] ]! Item was added: + ----- Method: Author>>initials (in category 'accessing') ----- + initials + + ^initials ifEmpty: [ self requestAndSetInitials ]! Item was added: + ----- Method: Author>>initials: (in category 'accessing') ----- + initials: aString + + initials := aString! Item was added: + ----- Method: Author>>initialsPerSe (in category 'accessing') ----- + initialsPerSe + + ^initials! Item was added: + ----- Method: Author>>requestAndSetInitials (in category 'accessing') ----- + requestAndSetInitials + + ^initials := (UIManager default + request: 'Please type your initials: ' translated + initialAnswer: initials) select: [ :each | + #( + ($A $Z) + ($a $z) + ($0 $9)) anySatisfy: [ :range | + each between: range first and: range second ] ]! Item was added: + ----- Method: Author>>requestAndSetUsername (in category 'accessing') ----- + requestAndSetUsername + + ^username := UIManager default + request: 'Please type your name:' translated + initialAnswer: (username + ifEmpty: [ 'Your Name' translated ] + ifNotEmpty: [ username ])! Item was added: + ----- Method: Author>>useAuthor:during: (in category 'pharo compatibility') ----- + useAuthor: aString during: aBlock + + ^self useInitials: aString during: aBlock! Item was added: + ----- Method: Author>>useInitials:during: (in category 'accessing') ----- + useInitials: aString during: aBlock + "Use aString as initials while aBlock is being evaluated." + + | originalInitials | + originalInitials := initials. + initials := aString. + ^aBlock ensure: [ initials := originalInitials ]! Item was added: + ----- Method: Author>>username (in category 'accessing') ----- + username + + ^username ifEmpty: [ self requestAndSetUsername ]! Item was added: + ----- Method: Author>>username: (in category 'accessing') ----- + username: aString + + username := aString! Item was added: + ----- Method: Author>>usernamePerSe (in category 'accessing') ----- + usernamePerSe + + ^username!

1 0

The Inbox: Tests-ul.166.mcz
by commits＠source.squeak.org 14 Sep '12

14 Sep '12

A new version of Tests was added to project The Inbox: http://source.squeak.org/inbox/Tests-ul.166.mcz ==================== Summary ==================== Name: Tests-ul.166 Author: ul Time: 14 September 2012, 4:17:35.362 pm UUID: 8dafc26e-707b-0b4c-bcc8-3d21e71fd4d6 Ancestors: Tests-ul.163 Tests for Author. =============== Diff against Tests-ul.163 =============== Item was added: + TestCase subclass: #AuthorTest + instanceVariableNames: 'originalAuthor' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-System-Support'! Item was added: + ----- Method: AuthorTest>>setUp (in category 'running') ----- + setUp + + originalAuthor := Author current shallowCopy! Item was added: + ----- Method: AuthorTest>>tearDown (in category 'running') ----- + tearDown + + Author current copyFrom: originalAuthor! Item was added: + ----- Method: AuthorTest>>testInitiallyEmpty (in category 'tests') ----- + testInitiallyEmpty + + Author reset. + self assert: Author initialsPerSe isEmpty + ! Item was added: + ----- Method: AuthorTest>>testInitials (in category 'tests') ----- + testInitials + + Author current initials: 'Smalltalk123'. + self assert: 'Smalltalk123' equals: Author initialsPerSe ! Item was added: + ----- Method: AuthorTest>>testInitialsCanContainOnlyAsciiAlphanumericCharacters (in category 'tests') ----- + testInitialsCanContainOnlyAsciiAlphanumericCharacters + + Author reset. + [ Author current requestAndSetInitials ] valueSupplyingAnswer: { + '*'. + '!!@#$Smalltalk123', (Character value: 1234) asString }. + self assert: 'Smalltalk123' equals: Author initialsPerSe + + ! Item was added: + ----- Method: AuthorTest>>testNewRaisesError (in category 'tests') ----- + testNewRaisesError + + self should: [ Author new ] raise: Error! Item was added: + ----- Method: AuthorTest>>testRequestAndSetInitials (in category 'tests') ----- + testRequestAndSetInitials + + Author reset. + [ Author current requestAndSetInitials ] valueSupplyingAnswer: { + '*'. + 'Smalltalk123' }. + self assert: 'Smalltalk123' equals: Author initialsPerSe + ! Item was added: + ----- Method: AuthorTest>>testRequestAndSetUserName (in category 'tests') ----- + testRequestAndSetUserName + + Author reset. + [ Author current requestAndSetUsername ] valueSupplyingAnswer: { + '*'. + 'Smalltalk123' }. + self assert: 'Smalltalk123' equals: Author usernamePerSe + ! Item was added: + ----- Method: AuthorTest>>testUseInitialsDuring (in category 'tests') ----- + testUseInitialsDuring + + | originalInitials | + originalInitials := Author initialsPerSe. + Author useInitials: 'other', originalInitials during: [ + self assert: 'other', originalInitials equals: Author initialsPerSe ]. + self assert: originalInitials equals: Author initialsPerSe! Item was added: + ----- Method: AuthorTest>>testUsername (in category 'tests') ----- + testUsername + + Author current username: 'Smalltalk123'. + self assert: 'Smalltalk123' equals: Author usernamePerSe !

1 0

Failing MC Tests
by Levente Uzonyi 14 Sep '12

14 Sep '12

Hi, today I showed Balázs what I achieved (Tests-ul.164) in fixing the MC tests and he fixed all remaining issues (Tests-ul.165 and 167), so if you load Tests-ul.167 from the Inbox into your Trunk image, then all MC tests should pass. Please review the changes and let us know if there are any problems with them. Cheers, Levente

1 0

The Inbox: Tests-ul.167.mcz
by commits＠source.squeak.org 14 Sep '12

14 Sep '12

A new version of Tests was added to project The Inbox: http://source.squeak.org/inbox/Tests-ul.167.mcz ==================== Summary ==================== Name: Tests-ul.167 Author: ul Time: 14 September 2012, 4:33:14.57 pm UUID: 7a6b5557-0d58-9646-b82c-807335e58d1c Ancestors: Tests-ul.165 Since Monticello-bf.476 MCSnapshotBrowser shows empty categories too, so include the systemCategories of the MCMockPackageInfo in MCSnapshotBrowserTest >> #allCategories in order to make MCSnapshotBrowserTest pass. =============== Diff against Tests-ul.165 =============== Item was changed: ----- Method: MCSnapshotBrowserTest>>allCategories (in category 'private') ----- allCategories + + ^{ + model extensionsCategory. + self mockCategoryName }, + MCSnapshotResource mockPackage packageInfo systemCategories! - ^ Array with: model extensionsCategory with: self mockCategoryName.!

1 0

The Inbox: Tests-ul.165.mcz
by commits＠source.squeak.org 14 Sep '12

14 Sep '12

A new version of Tests was added to project The Inbox: http://source.squeak.org/inbox/Tests-ul.165.mcz ==================== Summary ==================== Name: Tests-ul.165 Author: ul Time: 14 September 2012, 3:32:16.183 pm UUID: 351cb9d0-e4bc-824a-bd34-dc64cff2fd4f Ancestors: Tests-ul.164 Break out Monticello package renaming tests into a separate TestCase, and use the existing category Tests-Monticello-Mock as its mock package name. This is needed because package renaming depends on the contract that package names are prefixes of their contained category names. =============== Diff against Tests-ul.164 =============== Item was changed: SystemOrganization addCategory: #'Tests-Exceptions'! SystemOrganization addCategory: #'Tests-Files'! SystemOrganization addCategory: #'Tests-Compiler'! SystemOrganization addCategory: #'Tests-Digital Signatures'! SystemOrganization addCategory: #'Tests-Object Events'! SystemOrganization addCategory: #'Tests-System-Support'! SystemOrganization addCategory: #'Tests-Bugs'! SystemOrganization addCategory: #'Tests-ObjectsAsMethods'! SystemOrganization addCategory: #'Tests-PrimCallController'! SystemOrganization addCategory: #'Tests-Release'! SystemOrganization addCategory: #'Tests-Utilities'! SystemOrganization addCategory: #'Tests-VM'! SystemOrganization addCategory: #'Tests-Hex'! SystemOrganization addCategory: #'Tests-Monticello'! SystemOrganization addCategory: #'Tests-Localization'! SystemOrganization addCategory: #'Tests-FilePackage'! SystemOrganization addCategory: #'Tests-Finalization'! SystemOrganization addCategory: #'Tests-Dependencies'! SystemOrganization addCategory: #'Tests-Monticello-Mocks'! SystemOrganization addCategory: #'Tests-Environments'! + SystemOrganization addCategory: #'Tests-Monticello-Utils'! Item was changed: PackageInfo subclass: #MCDirtyPackageInfo instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' + category: 'Tests-Monticello-Utils'! - category: 'Tests-Monticello-Mocks'! Item was changed: PackageInfo subclass: #MCEmptyPackageInfo instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' + category: 'Tests-Monticello-Utils'! - category: 'Tests-Monticello-Mocks'! Item was changed: MCDefinition subclass: #MCMockDefinition instanceVariableNames: 'token' classVariableNames: '' poolDictionaries: '' + category: 'Tests-Monticello-Utils'! - category: 'Tests-Monticello-Mocks'! Item was changed: Object subclass: #MCMockDependency instanceVariableNames: 'name children hasResolution' classVariableNames: '' poolDictionaries: '' + category: 'Tests-Monticello-Utils'! - category: 'Tests-Monticello-Mocks'! Item was changed: PackageInfo subclass: #MCMockPackageInfo instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' + category: 'Tests-Monticello-Utils'! - category: 'Tests-Monticello-Mocks'! Item was added: + MCTestCase subclass: #MCWorkingCopyRenameTest + instanceVariableNames: 'savedInitials workingCopy repositoryGroup versions versions2' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-Monticello'! Item was added: + ----- Method: MCWorkingCopyRenameTest>>mockPackage (in category 'running') ----- + mockPackage + + ^MCPackage new name: self mockCategoryName! Item was added: + ----- Method: MCWorkingCopyRenameTest>>setUp (in category 'running') ----- + setUp + | repos1 repos2 | + repositoryGroup := MCRepositoryGroup new. + workingCopy := MCWorkingCopy forPackage: self mockPackage. + versions := Dictionary new. + versions2 := Dictionary new. + repos1 := MCDictionaryRepository new dictionary: versions. + repos2 := MCDictionaryRepository new dictionary: versions2. + repositoryGroup addRepository: repos1. + repositoryGroup addRepository: repos2. + MCRepositoryGroup default removeRepository: repos1; removeRepository: repos2. + workingCopy repositoryGroup: repositoryGroup. + savedInitials := Utilities authorInitialsPerSe. + Utilities setAuthorInitials: 'abc'.! Item was added: + ----- Method: MCWorkingCopyRenameTest>>tearDown (in category 'running') ----- + tearDown + super tearDown. + workingCopy unregister. + SystemOrganizer default removeEmptyCategories. + MCSnapshotTest organization removeEmptyCategories. + Utilities setAuthorInitials: savedInitials! Item was added: + ----- Method: MCWorkingCopyRenameTest>>testRenamePrefix (in category 'tests') ----- + testRenamePrefix + + self verifyRenameTo: 'Renamed-' , workingCopy packageName! Item was added: + ----- Method: MCWorkingCopyRenameTest>>testRenameSuffix (in category 'tests') ----- + testRenameSuffix + + self verifyRenameTo: workingCopy packageName, '-Renamed'! Item was added: + ----- Method: MCWorkingCopyRenameTest>>verifyRenameTo: (in category 'tests') ----- + verifyRenameTo: newName + + | oldWorkingCopy oldDefinitions newWorkingCopy | + oldWorkingCopy := workingCopy. + oldDefinitions := workingCopy package snapshot definitions. + [ + newWorkingCopy := workingCopy renameToBe: newName. + self + assert: oldWorkingCopy ancestors = newWorkingCopy ancestors ; + assert: newWorkingCopy needsSaving ; + assert: newWorkingCopy requiredPackages = oldWorkingCopy requiredPackages ; + assert: newWorkingCopy repositoryGroup repositories = oldWorkingCopy repositoryGroup repositories ; + assert: newWorkingCopy package snapshot definitions size = oldDefinitions size ; + assert: (MCWorkingCopy registry includesKey: newWorkingCopy package) ; + assert: (MCWorkingCopy registry includes: newWorkingCopy) ; + deny: (MCWorkingCopy registry includes: oldWorkingCopy). + workingCopy := newWorkingCopy ] ensure: [ + " ensure that we rename the category back to the original name " + (SystemOrganizer default categories includes: newName) ifTrue: [ + SystemOrganizer default + renameCategory: newName + toBe: oldWorkingCopy packageName ] ]! Item was removed: - ----- Method: MCWorkingCopyTest>>testRenamePrefix (in category 'tests') ----- - testRenamePrefix - self verifyRenameTo: 'Renamed-' , workingCopy packageName. - SystemOrganizer default - renameCategory: 'Renamed-Tests-Monticello-Mocks' - toBe: 'Tests-Monticello-Mocks'! Item was removed: - ----- Method: MCWorkingCopyTest>>testRenameSuffix (in category 'tests') ----- - testRenameSuffix - self verifyRenameTo: workingCopy packageName, '-Renamed'! Item was removed: - ----- Method: MCWorkingCopyTest>>verifyRenameTo: (in category 'tests') ----- - verifyRenameTo: newName - | oldWorkingCopy oldDefinitions newWorkingCopy | - oldWorkingCopy := workingCopy. - oldDefinitions := workingCopy package snapshot definitions. - newWorkingCopy := workingCopy renameToBe: newName. - self - assert: oldWorkingCopy ancestors = newWorkingCopy ancestors ; - assert: newWorkingCopy needsSaving ; - assert: newWorkingCopy requiredPackages = oldWorkingCopy requiredPackages ; - assert: newWorkingCopy repositoryGroup repositories = oldWorkingCopy repositoryGroup repositories ; - assert: newWorkingCopy package snapshot definitions size = oldDefinitions size ; - assert: (MCWorkingCopy registry includesKey: newWorkingCopy package) ; - assert: (MCWorkingCopy registry includes: newWorkingCopy) ; - deny: (MCWorkingCopy registry includes: oldWorkingCopy). - workingCopy := newWorkingCopy!

1 0

The Inbox: Tests-ul.164.mcz
by commits＠source.squeak.org 14 Sep '12

14 Sep '12

A new version of Tests was added to project The Inbox: http://source.squeak.org/inbox/Tests-ul.164.mcz ==================== Summary ==================== Name: Tests-ul.164 Author: ul Time: 14 September 2012, 2:20:59.642 pm UUID: 9431f253-54c9-8144-9de4-17230f13fc9f Ancestors: Tests-ul.163 Fixing Monticello tests: - restore #packageName for MCMockPackageInfo, MCEmptyPackageInfo, MCDirtyPackageInfo - re-register these PackageInfos in postscript - renamed the virtual #systemCategory of MCMockPackageInfo to Tests-MonticelloMocks, so the extension method MCSnapshotTest >> #mockClassExtension can be in the Tests package instead of Monticello MCMethodDefinitionTest enhancements: - updated #ownPackage, because it's Tests now - save and restore the timestamp of #override - remove the empty system category and the workingCopy of the mock package after the tests These changes break MCWorkingCopyTest's #testRenamePrefix and #testRenameSuffix and some of tests in MCSnapshotBrowserTest. =============== Diff against Tests-ul.163 =============== Item was removed: - ----- Method: MCDirtyPackageInfo class>>packageName (in category 'as yet unclassified') ----- - packageName - ^ 'MCDirtyPackage'! Item was added: + ----- Method: MCDirtyPackageInfo>>packageName (in category 'as yet unclassified') ----- + packageName + ^ 'MCDirtyPackage'! Item was removed: - ----- Method: MCEmptyPackageInfo class>>packageName (in category 'as yet unclassified') ----- - packageName - ^ 'MCEmptyPackage'! Item was added: + ----- Method: MCEmptyPackageInfo>>packageName (in category 'as yet unclassified') ----- + packageName + ^ 'MCEmptyPackage'! Item was changed: MCTestCase subclass: #MCMethodDefinitionTest + instanceVariableNames: 'navigation isModified overrideTimestamp' - instanceVariableNames: 'navigation isModified' classVariableNames: '' poolDictionaries: '' category: 'Tests-Monticello'! Item was changed: ----- Method: MCMethodDefinitionTest>>ownPackage (in category 'running') ----- ownPackage + ^ MCWorkingCopy forPackage: (MCPackage named: 'Tests')! - ^ MCWorkingCopy forPackage: (MCPackage named: 'Monticello')! Item was changed: ----- Method: MCMethodDefinitionTest>>setUp (in category 'running') ----- setUp + navigation := (Smalltalk hasClassNamed: #SystemNavigation) ifTrue: [(Smalltalk at: #SystemNavigation) new] ifFalse: [Smalltalk]. + isModified := self ownPackage modified. + overrideTimestamp := (self class >> #override) timeStamp! - isModified := self ownPackage modified.! Item was changed: ----- Method: MCMethodDefinitionTest>>tearDown (in category 'running') ----- tearDown - super tearDown. self restoreMocks. (MCWorkingCopy forPackage: (MCPackage named: 'FooBarBaz')) unregister. + MCMockPackageInfo new mcPackage workingCopy unregister. + self class + compile: 'override ^ 1' + classified: 'mocks' + withStamp: overrideTimestamp + notifying: nil. + SystemOrganizer default removeEmptyCategories. - self class compile: 'override ^ 1' classified: 'mocks'. self ownPackage modified: isModified. + super tearDown ! Item was removed: - ----- Method: MCMockPackageInfo class>>packageName (in category 'as yet unclassified') ----- - packageName - ^ 'MonticelloMocks'! Item was added: + ----- Method: MCMockPackageInfo>>packageName (in category 'as yet unclassified') ----- + packageName + ^ 'MonticelloMocks'! Item was changed: ----- Method: MCMockPackageInfo>>systemCategories (in category 'as yet unclassified') ----- systemCategories + ^ Array with: 'Tests-MonticelloMocks'! - ^ Array with: 'Monticello-Mocks'! Item was changed: + ----- Method: MCSnapshotTest>>mockClassExtension (in category '*Tests-MonticelloMocks') ----- - ----- Method: MCSnapshotTest>>mockClassExtension (in category '*Tests-Monticello-Mocks') ----- mockClassExtension! Item was changed: ----- Method: MCStWriterTest>>expectedOrganizationDefinition (in category 'data') ----- expectedOrganizationDefinition + ^ 'SystemOrganization addCategory: ''Tests-MonticelloMocks''!! - ^ 'SystemOrganization addCategory: ''Monticello-Mocks''!! '! Item was added: + ----- Method: MCStWriterTest>>tearDown (in category 'testing') ----- + tearDown + + SystemOrganizer default removeEmptyCategories. + super tearDown ! Item was added: + (PackageInfo named: 'Tests') postscript: 'PackageOrganizer default unregisterPackageNamed: ''Test-Monticello-Mocks''. + { MCMockPackageInfo. MCEmptyPackageInfo. MCDirtyPackageInfo } do: [ :each | + each initialize ] + '!

1 0

Mantis #7695
by John McKeon 14 Sep '12

14 Sep '12

Hello list, I thought I would take a stab at making a contribution to this software I so love. So I posted a file out to fix this issue<http://bugs.squeak.org/view.php?id=7695> and would ask if someone could review it. Thanks John McKeon -- jmck.seasidehosting.st

5 7

The Trunk: Tests-ul.163.mcz
by commits＠source.squeak.org 14 Sep '12

14 Sep '12

Levente Uzonyi uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-ul.163.mcz ==================== Summary ==================== Name: Tests-ul.163 Author: ul Time: 14 September 2012, 1:58:29.425 pm UUID: c716a059-f5d3-724c-b5c4-54ba9613e026 Ancestors: Tests-ul.162 Added ClassRemovalTest which reveals a bug in the current system. =============== Diff against Tests-ul.162 =============== Item was added: + TestCase subclass: #ClassRemovalTest + instanceVariableNames: 'isClean' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-Bugs'! Item was added: + ----- Method: ClassRemovalTest>>className1 (in category 'utility') ----- + className1 + + ^#ClassToBeRemoved! Item was added: + ----- Method: ClassRemovalTest>>className2 (in category 'utility') ----- + className2 + + ^#ReferringClass! Item was added: + ----- Method: ClassRemovalTest>>setUp (in category 'running') ----- + setUp + + isClean := (SystemOrganizer default listAtCategoryNamed: self systemCategoryName) isEmpty + and: [ (Smalltalk hasClassNamed: self className1) not + and: [ (Smalltalk hasClassNamed: self className2) not ] ]! Item was added: + ----- Method: ClassRemovalTest>>systemCategoryName (in category 'utility') ----- + systemCategoryName + + ^'ReferencedClassRemoveTest'! Item was added: + ----- Method: ClassRemovalTest>>tearDown (in category 'running') ----- + tearDown + + isClean ifTrue: [ + (Smalltalk at: self className1) removeFromSystem. + (Smalltalk at: self className2) removeFromSystem. + SystemOrganizer default removeCategory: self systemCategoryName ]! Item was added: + ----- Method: ClassRemovalTest>>testClassRemovalAndRecompilcationWontCreateDuplicateVariableBindings (in category 'tests') ----- + testClassRemovalAndRecompilcationWontCreateDuplicateVariableBindings + + self + assert: isClean + description: 'The system category or the classes about to be created already exist.'. + "Create a class" + Object subclass: self className1 + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: self systemCategoryName. + "Create another" + Object subclass: self className2 + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: self systemCategoryName. + "Compile a method in the second which references the first" + (Smalltalk at: self className2) + compile: 'foo ^', self className1 + classified: 'accessing'. + "Remove the first class" + (Smalltalk at: self className1) removeFromSystem. + "Compile the first class again" + Object subclass: self className1 + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: self systemCategoryName. + self + deny: (Smalltalk at: self className2) new foo isObsolete + description: '#foo refers to an obsolete class'. + self + assert: (Smalltalk at: self className1) == + (Smalltalk at: self className2) new foo + description: '#foo refers to a different class'!

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
16
Older →

Jump to page: