Squeak-dev September 2012

squeak-dev@lists.squeakfoundation.org

36 participants
151 discussions

The Trunk: Kernel-ul.711.mcz
by commits＠source.squeak.org 21 Sep '12

21 Sep '12

Levente Uzonyi uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ul.711.mcz ==================== Summary ==================== Name: Kernel-ul.711 Author: ul Time: 21 September 2012, 3:52:01.69 am UUID: 34bbbd59-62f6-8a4c-98a1-4277ce568856 Ancestors: Kernel-bf.710 Accept a block as description (besides a string) in Object>>assert:description:. This ensures that the method's behavior is the same as TestCase>>assert:description:'s. =============== Diff against Kernel-bf.710 =============== Item was changed: ----- Method: Object>>assert:description: (in category 'error handling') ----- + assert: aBlock description: aStringOrBlock - assert: aBlock description: aString "Throw an assertion error if aBlock does not evaluates to true." + aBlock value ifFalse: [ AssertionFailure signal: aStringOrBlock value ]! - aBlock value ifFalse: [AssertionFailure signal: aString ]!

1 0

The Trunk: SUnit-ul.89.mcz
by commits＠source.squeak.org 21 Sep '12

21 Sep '12

Levente Uzonyi uploaded a new version of SUnit to project The Trunk: http://source.squeak.org/trunk/SUnit-ul.89.mcz ==================== Summary ==================== Name: SUnit-ul.89 Author: ul Time: 21 September 2012, 3:50:20.289 am UUID: 57658f3e-8679-3748-82a8-c805c9e0c42d Ancestors: SUnit-ul.88 Accept a block (and strings as before) as description in TestCase >> #assert:description:. Instead of printing the objects all the time, only do that if the test fails in TestCase>>assert:equals: and TestCase>>assert:equals:description:. =============== Diff against SUnit-ul.88 =============== Item was changed: ----- Method: TestCase>>assert:description: (in category 'accessing') ----- + assert: aBooleanOrBlock description: aStringOrBlock + - assert: aBooleanOrBlock description: aString aBooleanOrBlock value ifFalse: [ + | description | + description := aStringOrBlock value. + self logFailure: description. + TestResult failure signal: description ] - self logFailure: aString. - TestResult failure signal: aString] ! Item was changed: ----- Method: TestCase>>assert:equals: (in category 'accessing') ----- assert: expected equals: actual + + ^self + assert: expected = actual + description: [ self comparingStringBetween: expected and: actual ] - ^ self - assert: (expected = actual) - description: (self comparingStringBetween: expected and: actual) ! Item was changed: ----- Method: TestCase>>assert:equals:description: (in category 'accessing') ----- assert: expected equals: actual description: aString + + ^self + assert: expected = actual + description: [ aString , ': ', (self comparingStringBetween: expected and: actual) ]! - ^ self - assert: (expected = actual) - description: aString , ': ', (self comparingStringBetween: expected and: actual)!

1 0

Daily Commit Log
by commits＠source.squeak.org 21 Sep '12

21 Sep '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-September/005519.… Name: Monticello-bf.525 Ancestors: Monticello-eem.524 SnapshotBrowser: label class extensions as *inst or *class ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-September/005520.… Name: SUnitGUI-eem.53 Ancestors: SUnitGUI-ul.52 Make TestRunner Filter... recognize multiple patterns separated by semicolons. Remember previous patterns in subsequent prompts. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-September/005521.… Name: SUnitGUI-eem.56 Ancestors: SUnitGUI-eem.53 Filter prompt needs to check for both nil and empty string to prevent cancel from destroying current patterns. =============================================

1 0

The Trunk: SUnitGUI-eem.56.mcz
by commits＠source.squeak.org 20 Sep '12

20 Sep '12

Eliot Miranda uploaded a new version of SUnitGUI to project The Trunk: http://source.squeak.org/trunk/SUnitGUI-eem.56.mcz ==================== Summary ==================== Name: SUnitGUI-eem.56 Author: eem Time: 20 September 2012, 2:04:20.328 pm UUID: c155ae36-4f30-4a86-9ce5-2b1c8dd3de40 Ancestors: SUnitGUI-eem.53 Filter prompt needs to check for both nil and empty string to prevent cancel from destroying current patterns. =============== Diff against SUnitGUI-eem.53 =============== Item was changed: ----- Method: TestRunner>>filterCategories (in category 'accessing-categories') ----- filterCategories | pattern | pattern := UIManager default request: 'Pattern(s) to select categories:\ (separate patterns with '';'')' withCRs initialAnswer: (categoryPattern ifNil: ['*']). + (pattern isNil or: [pattern isEmpty]) ifTrue: + [^self]. - pattern isNil ifTrue: [ ^ self ]. categoriesSelected := ((categoryPattern := pattern) subStrings: ';') inject: Set new into: [:matches :subPattern| matches addAll: (categories select: [ :each | subPattern match: each]); yourself]. self changed: #allSelections; changed: #categorySelected; updateClasses! Item was changed: ----- Method: TestRunner>>filterClasses (in category 'accessing-classes') ----- filterClasses | pattern | pattern := UIManager default request: 'Pattern(s) to select tests:\ (separate patterns with '';'')' withCRs initialAnswer: (classPattern ifNil: '*'). + (pattern isNil or: [pattern isEmpty]) ifTrue: + [^self]. - pattern isNil ifTrue: [ ^ self ]. classesSelected := ((classPattern := pattern) subStrings: ';') inject: Set new into: [:matches :subPattern| matches addAll: (classes select: [ :each | subPattern match: each name]); yourself]. self changed: #allSelections; changed: #classSelected; changed: #hasRunnable!

1 0

Issues in the new network support (was: SocketPlugin issues (was: Re: [Vm-dev] Win32 beta test))
by David T. Lewis 20 Sep '12

20 Sep '12

Moving the discussion to squeak-dev. Follow-up related to the Squeak image should be on squeak-dev, discussion of the primitives can stay on vm-dev. Dave On Thu, Sep 20, 2012 at 02:11:35PM -0400, David T. Lewis wrote: > > We have an upcoming image release, so I think that we should consider > de-activating the new network support for that release. I think that > can be done by just setting UseOldNetwork to true. Right now it is > automatically set at image startup, depending on whether the IPv6 > primitives are available in the image. We could turn it back on in > trunk after the release, and deal with the issues then. > > It would not be good to release with network issues that might affect > the entire Windows user base. > > Dave > > > On Thu, Sep 20, 2012 at 07:50:42PM +0200, Levente Uzonyi wrote: > > On Wed, 19 Sep 2012, David T. Lewis wrote: > > > > >There seem to be some issues with the new networking code (in Squeak, > > >for IPv6 support) when running on a Windows VM that has the IPv6 > > >primitives in the SocketPlugin. > > > > > >I booted up Windows and tried Levente's deadlock test: > > > > > >>>I could reproduce a deadlock-like state by evaluating: > > >>> > > >>>NetNameResolver addressesForName: 'amazon.com' > > >>> > > > > > >I tried this both with Ian's beta interpreter VM, and one of Eliot's > > >recent Cog VMs. Both VMs have the IPv6 primitives now, and both of > > >them show similar issues. I did not see actual deadlocks, but what > > >I did see was extremely long primitive calls that make the image feel > > >like it is deadlocked. The #primitiveResolverGetNameInfo call is a > > >source of problems, and there may be others. > > > > > >It looks to me like some of the new primitives are invoking some very > > >slow system functions on Windows, and the Squeak network code updates > > >cause these primitives to be called if they are available in the VM, > > >so the newer VMs are having problems. I have not seen these issues > > >on Linux, so it may reflect differences in the networking support > > >for different operating systems. > > > > > >Levente, is this consistent with what you were seeing? > > > > It is, though I didn't check which primitive takes too long. I checked the > > implementation of #primitiveResolverGetNameInfo now on win32 and it seems > > to be okay, pretty much the same as on unix/linux. I see no reason why it > > would take so long to respond. > > > > In the meantime I found another thing I don't like about the new > > primitives. The timeout for the namelookup is ignored, so now we have to > > wait till the primitive returns. > > > > Actually I don't like the way how the name lookup is implemented. I think > > it might worth moving the DNS lookup to Squeak. The only thing the VM > > needs to provide then is a primitive which returns the IP addresses > > of the nameservers to be used (though the system can work without that > > too). Here are the pros and cons I came up with so far: > > Pros: > > - the code is in Smalltalk, so it's platform independent > > - concurrent name lookups become possible > > - no more long waits on the VM side > > Cons: > > - extra complexity, since a DNS client has to be implemented > > - the OS's DNS cache can't be used > > > > > > Levente > > > > > > > >Dave > > > > > >On Mon, Sep 17, 2012 at 03:37:45PM -0400, David T. Lewis wrote: > > >>Thanks Levente, this is very helpful. > > >> > > >>It sounds like these are problems in the new network code on the image > > >>side (and I'm responsible for causing that). The updated VM is probably > > >>different only in that it provides the IPv6 primitives, which in turn > > >>expose the bugs on the image side. So I expect that the problems you > > >>describe should also happen with a unix interpreter VM (I'll check > > >>and find out as soon as I can). > > >> > > >>I note for the record that Andreas is fully entitled to say "I told > > >>you so!" at this point ;) > > >> > > >>To the extent that these are Squeak image problems, evaluating > > >>"NetNameResolver useOldNetwork: true" should make the symptoms > > >>go away. > > >> > > >>Other comments in line below. > > >> > > >>On Mon, Sep 17, 2012 at 07:01:47PM +0200, Levente Uzonyi wrote: > > >>> > > >>>On Mon, 17 Sep 2012, David T. Lewis wrote: > > >>> > > >>>>Levente, > > >>>> > > >>>>Can you say anything more about what weakness you found in the > > >>>>network code? > > >>> > > >>>All issues I found are related to name lookup. To do a name lookup the > > >>>new > > >>>code requires multiple primitive calls (see SocketAddressInformation >> > > >>>#forHost:service:flags:addressFamily:socketType:protocol:). The plugin > > >>>uses static variables to store the result of the name lookup > > >>>(hostNameInfo, servNameInfo and nameInfoValid). This means that only one > > >>>name can be looked up at a time. > > >> > > >>I noticed that, and attempted to provide some protection for it with > > >>a semaphore (ResolverMutex) in class NetNameResolver. Apparently I did > > >>not do a very good job of it though. > > >> > > >>> > > >>>The image side code doesn't prevent simultaneous access to these static > > >>>variables, so the can get into an unexpected state (see SocketAddress >> > > >>>#hostName). > > >>> > > >>>Another issue is that the plugin doesn't allocate objects (strings), so 2 > > >>>primitive calls have to be done to fetch a string (see SocketAddress >> > > >>>#hostName again). One requests the size of the string, the other copies > > >>>the data to a string it receives as argument. > > >>> > > >>>I could reproduce a deadlock-like state by evaluating: > > >>> > > >>>NetNameResolver addressesForName: 'amazon.com' > > >>> > > >>>It's sometimes possible to interrupt the process to get a debugger, but > > >>>since the primitives are called by the debugger too (see SocketAddress >> > > >>>#printOn:), the image will hang if you try to use it. > > >>> > > >> > > >>That seems likely to be a problem related to the semaphore in > > >>NetNameResolver. > > >> > > >>If this turns out to be a problem with the network support in Squeak > > >>trunk, we can take the discussion back to squeak-dev for resolution. > > >> > > >>Dave > > >

1 0

The Trunk: SUnitGUI-eem.53.mcz
by commits＠source.squeak.org 20 Sep '12

20 Sep '12

Eliot Miranda uploaded a new version of SUnitGUI to project The Trunk: http://source.squeak.org/trunk/SUnitGUI-eem.53.mcz ==================== Summary ==================== Name: SUnitGUI-eem.53 Author: eem Time: 20 September 2012, 11:07:56.257 am UUID: 2a734976-4fc9-414d-8884-986f5bf9ff58 Ancestors: SUnitGUI-ul.52 Make TestRunner Filter... recognize multiple patterns separated by semicolons. Remember previous patterns in subsequent prompts. =============== Diff against SUnitGUI-ul.52 =============== Item was changed: Object subclass: #TestRunner + instanceVariableNames: 'categories categoriesSelected classes classIndex classesSelected failedList failedSelected errorList errorSelected lastUpdate result previousRun categoryPattern classPattern' - instanceVariableNames: 'categories categoriesSelected classes classIndex classesSelected failedList failedSelected errorList errorSelected lastUpdate result previousRun' classVariableNames: '' poolDictionaries: '' category: 'SUnitGUI'! !TestRunner commentStamp: '<historical>' prior: 0! <lint: #ignore rule: #classNotReferenced rational: 'this view is only accessed from menus'> ! Item was changed: ----- Method: TestRunner>>filterCategories (in category 'accessing-categories') ----- filterCategories | pattern | pattern := UIManager default + request: 'Pattern(s) to select categories:\ (separate patterns with '';'')' withCRs + initialAnswer: (categoryPattern ifNil: ['*']). - request: 'Pattern to select categories:' - initialAnswer: '*'. pattern isNil ifTrue: [ ^ self ]. + categoriesSelected := ((categoryPattern := pattern) subStrings: ';') + inject: Set new + into: [:matches :subPattern| + matches + addAll: (categories select: [ :each | subPattern match: each]); + yourself]. - categoriesSelected := (categories - select: [ :each | pattern match: each ]) asSet. self changed: #allSelections; changed: #categorySelected; updateClasses! Item was changed: ----- Method: TestRunner>>filterClasses (in category 'accessing-classes') ----- filterClasses | pattern | pattern := UIManager default + request: 'Pattern(s) to select tests:\ (separate patterns with '';'')' withCRs + initialAnswer: (classPattern ifNil: '*'). - request: 'Pattern to select tests:' - initialAnswer: '*'. pattern isNil ifTrue: [ ^ self ]. + classesSelected := ((classPattern := pattern) subStrings: ';') + inject: Set new + into: [:matches :subPattern| + matches + addAll: (classes select: [ :each | subPattern match: each name]); + yourself]. - classesSelected := (classes select: [ :each | - pattern match: each name ]) asSet. self changed: #allSelections; changed: #classSelected; changed: #hasRunnable!

1 0

Re: [squeak-dev] The Trunk: Monticello-bf.523.mcz
by Eliot Miranda 20 Sep '12

20 Sep '12

On Fri, Sep 7, 2012 at 4:46 AM, <commits(a)source.squeak.org> wrote: > Bert Freudenberg uploaded a new version of Monticello to project The Trunk: > http://source.squeak.org/trunk/Monticello-bf.523.mcz > > ==================== Summary ==================== > > Name: Monticello-bf.523 > Author: bf > Time: 7 September 2012, 1:46:20.526 pm > UUID: d75a5c9e-14ea-40dd-baaf-243d2f4fa6c1 > Ancestors: Monticello-cmm.522 > > Sundry improvements: > * trim space for version name when saving > * when browsing a package snapshot, do not show the *Extensions category > unless the package actually has extension methods > Thank you!!!!! > * mention 'package' in summary line for package load/unload scripts > > =============== Diff against Monticello-cmm.522 =============== > > Item was changed: > ----- Method: MCScriptDefinition>>summary (in category 'accessing') ----- > summary > + ^ packageName, ' package ', self scriptSelector! > - ^ packageName, ' ', self scriptSelector! > > Item was added: > + ----- Method: MCSnapshotBrowser>>hasExtensions (in category 'accessing') > ----- > + hasExtensions > + ^self extensionClassNames notEmpty! > > Item was changed: > ----- Method: MCSnapshotBrowser>>visibleCategories (in category > 'listing') ----- > visibleCategories > ^ ((self packageOrganizations gather: [:ea | ea categories]), > + (self packageClasses collect: [:ea | ea category]), > + (self hasExtensions ifTrue: [{self > extensionsCategory}] ifFalse: [#()])) > + asSet asSortedCollection! > - (self packageClasses collect: [:ea | ea category])) > - asSet asSortedCollection add: self > extensionsCategory; yourself.! > > Item was changed: > ----- Method: MCWorkingCopy>>newVersion (in category 'operations') ----- > newVersion > ^ (self requestVersionNameAndMessageWithSuggestion: self > uniqueVersionName > initialMessage: self patchMessageSuggestion) ifNotNil: > [:pair | > + self newVersionWithName: pair first > withBlanksTrimmed > - self newVersionWithName: pair first > message: (self patchMessageStripped: pair > last)]. > ! > > > -- best, Eliot

3 4

The Trunk: Monticello-bf.525.mcz
by commits＠source.squeak.org 20 Sep '12

20 Sep '12

Bert Freudenberg uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-bf.525.mcz ==================== Summary ==================== Name: Monticello-bf.525 Author: bf Time: 20 September 2012, 2:07:49.849 pm UUID: 35b8d257-a1b4-4dda-baa1-f497de4d4328 Ancestors: Monticello-eem.524 SnapshotBrowser: label class extensions as *inst or *class =============== Diff against Monticello-eem.524 =============== Item was changed: ----- Method: MCSnapshotBrowser>>classList (in category 'listing') ----- classList + ^ categorySelection = self extensionsCategory + ifTrue: [self labeledClassnames: self visibleClasses] + ifFalse: [self visibleClasses]! - ^ self visibleClasses! Item was added: + ----- Method: MCSnapshotBrowser>>labeledClassnames: (in category 'private') ----- + labeledClassnames: classNames + | methodClassification | + methodClassification := Dictionary new. + items do: [:def | def isMethodDefinition ifTrue: [ + (methodClassification at: def className ifAbsentPut: [Set new]) + add: (def classIsMeta ifFalse: [$i] ifTrue: [$c])]]. + ^ classNames collect: [:className | + String streamContents: [:s | + s nextPutAll: className; space. + (methodClassification at: className) + do: [:each | each = $i + ifTrue: [s nextPutAll: '*inst'] + ifFalse: [s nextPutAll: '*class']] + separatedBy: [s nextPut: $,]]] + !

1 0

Daily Commit Log
by commits＠source.squeak.org 20 Sep '12

20 Sep '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-September/005518.… Name: Monticello-eem.524 Ancestors: Monticello-bf.523 In the snapshot browser select a single extension protocol eagerly when selecting a class, to make browsing extensions more convenient. =============================================

1 0

The Trunk: Monticello-eem.524.mcz
by commits＠source.squeak.org 19 Sep '12

19 Sep '12

Eliot Miranda uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-eem.524.mcz ==================== Summary ==================== Name: Monticello-eem.524 Author: eem Time: 19 September 2012, 2:15:40.733 pm UUID: 1f3477ca-9571-43af-b99a-6d617241e2c9 Ancestors: Monticello-bf.523 In the snapshot browser select a single extension protocol eagerly when selecting a class, to make browsing extensions more convenient. =============== Diff against Monticello-bf.523 =============== Item was changed: ----- Method: MCSnapshotBrowser>>classSelection: (in category 'selecting') ----- classSelection: aNumber classSelection := aNumber = 0 ifFalse: [self visibleClasses at: aNumber]. self protocolSelection: 0. + self changed: #classSelection; changed: #protocolList. + (self protocolList size = 1 + and: [self protocolList first first = $*]) + ifTrue: + [self protocolSelection: 1] + ifFalse: + [self changed: #annotations; + changed: #methodList] - self changed: #classSelection; - changed: #protocolList; - changed: #annotations; - changed: #methodList. !

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
16
Older →

Jump to page: