Squeak-dev May 2012

squeak-dev@lists.squeakfoundation.org

54 participants
171 discussions

The Trunk: Monticello-bf.510.mcz
by commits＠source.squeak.org 31 May '12

31 May '12

Bert Freudenberg uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-bf.510.mcz ==================== Summary ==================== Name: Monticello-bf.510 Author: bf Time: 31 May 2012, 12:02:25.145 pm UUID: 5eb5cc97-d633-4b0c-b426-44dc888f0522 Ancestors: Monticello-bf.509 - if package is nil, do not try to list version names for it (thanks, cbc) - ordering by author made insensitive to case - misc fix: replace an ifNil test by ifEmpty =============== Diff against Monticello-bf.509 =============== Item was changed: ----- Method: MCRepository>>highestNumberedVersionNameForPackageNamed: (in category 'versions') ----- highestNumberedVersionNameForPackageNamed: aString ^ (self versionNamesForPackageNamed: aString) + ifEmpty: [ self error: aString , ' not found in ' , self asString ] + ifNotEmptyDo: + [ : versionNames | versionNames detectMax: - ifNil: [ self error: aString , ' not found in ' , self asString ] - ifNotNilDo: - [ : pkg | pkg detectMax: [ : each | each versionNumber ] ]! Item was changed: ----- Method: MCRepositoryInspector>>initializeVersionNames (in category 'initialize-release') ----- initializeVersionNames repository cacheAllFileNamesDuring: + [ versionNames := selectedPackage + ifNil: [Array new] + ifNotNil: [repository versionNamesForPackageNamed: selectedPackage]. - [ versionNames := repository versionNamesForPackageNamed: selectedPackage. self refreshEmphasis ]! Item was changed: ----- Method: MCRepositoryInspector>>orderSpecs (in category 'morphic ui') ----- orderSpecs ^{ 'unchanged' -> nil. 'order by package' -> [ :x :y | x packageName < y packageName ]. + 'order by author' -> [ :x :y | x author caseInsensitiveLessOrEqual: y author ]. - 'order by author' -> [ :x :y | x author < y author ]. 'order by version-string' -> [ :x :y | x versionNumber asString < y versionNumber asString ]. 'order by version-number' -> [ :x :y | x versionNumber > y versionNumber ]. 'order by filename' -> [ :x :y | x fileName < y fileName ]. }!

1 0

Re: [Pharo-project] Classes that implement unsafe #=
by Chris Muller 31 May '12

31 May '12

Good catch Mariano -- I have run your test on Squeak and fixed a couple of instances there too. On Wed, May 30, 2012 at 7:05 AM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > Hi guys. I found a problem while working with FuelPreview where we store > objects of the graph in a Set. While doing a collect, there was an error > because an implementation of #= was assuming that the argument was of a > certain shape. Of course, that should answer false instead. So I wrote this > test to see all existing wrong implementations: > > testAllClassesImplementSafeEqualsMethod > "This tests that all classes in the system that implements #= do it in a way > that they don't throw error when passing as an argument something different > from expected. The correct behavior is that #= answers false." > | wrongClasses | > wrongClasses := IdentityDictionary new. > ((SystemNavigation default allImplementorsOf: #=) > collect: [:each | each methodClass]) > do: [:each | > | instance | > "Some classes like CompiledMethod override basicNew to throw > an error. > In any case, the comparison will be false, so no problem" > [instance := each basicNew] on: Error do: []. > [instance = Object new] > on: Error > do: [: err | wrongClasses at: each put: err ]]. > self assert: wrongClasses isEmpty > > > The result is: {Magnitude. WideCharacterSet. KMKeymap. MCMockDefinition. > ScaledDecimal. MCSnapshot} > > So, my I think we should change #= in those classes by adding: > > self == aKeymap > ifTrue: [ ^ true ]. > self class = aKeymap class > ifFalse: [ ^ false ]. > > at the beginning of the #= > > what do you think? if agree, I open an issue. > > > -- > Mariano > http://marianopeck.wordpress.com >

1 0

GLMorphic
by Tim Felgentreff 30 May '12

30 May '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi I've been playing with GLMorphic, updating it to work with current CroquetGL. I've been using it as my Display canvas for a couple of days, and I like the idea of allowing Morphs to use OpenGL in their drawOn: methods (makes for much faster transform morphs ;) There's plenty of problems, and performance isn't great, but do people think better OpenGL integration is something that's still worth pursuing? (not necessarily based on GLMorphic) If you want to give it a try, I've updated the ConfigurationOfGLMorphic in the squeaksource.com/GLMorphic repository. Load the #lastVersion (development) and try and enable the GLCanvas with GLDisplayScreen new Works okay here on my i5 with Mesa (software) rendering, and pretty well when run on an nVidia card. I've only tried it on Linux, but it should work wherever CroquetGL works. There's a little example morph in the GLMorphic-Examples category that renders a rotating cube in its drawSubmorphsOn: Best, - -Tim PS: Please do not judge me too harsh for the GL code - never really played with OpenGL before. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPxmBpAAoJEFcGo2TJLgG1gxAIALBOHn31aR8Ou3liuDglNjCp HPwU8C/zQApqHU1CcuTrIfsVd2Y8s2tIV32yitSWuP4xVhQ93sYVZnusnhJMH8am 980m5ssFvuEV0OYg+7SaIWolzW7J5r05MO0eYj/3cQIisUtSca58DlQzavH9Uz3i thKKN2/5OMZqhdVwWvqtddf3k0rWlyOilj0Zz0kk4IYycMoNnZaPX6gKDoZ7Stc+ 0UhOwiTqxvG3lLW0/OvfTfvKthYRcvh0B47tJNkHZ1rhVlvKTvqTdk3jEM2QkgGu IE0wS+Ps0Tbv2Fwjnv3VijSAGGdDCpdloSQ4DrwnwwChooZ5/QJccdRb2XxQSAc= =L0hg -----END PGP SIGNATURE-----

5 5

Installer and http
by Bert Freudenberg 30 May '12

30 May '12

This fails: (Installer squeak project: 'FFI') install: 'FFI-Pool' Installer makes an MCHttpRepository with 'source.squeak.org' as location. Which should be fine since it *knows* it is an HTTP repository, after all. The problem is in HTTPSocket's httpGetDocument:args:accept:request: method which uses "Url absoluteFromText: url" and creates a file (!) URL. Which obviously causes problems later. The question is, how can we normalize this to a http url instead? What kind of strings are passed in here that even require normalization? - Bert -

1 0

Re: [squeak-dev] The Trunk: Kernel-eem.692.mcz
by Levente Uzonyi 30 May '12

30 May '12

It's a bit dangerous to change the hash without rehashing the collections which contain CompiledMethods as keys. For example DebuggerMethodMap's MapCache uses CompiledMethods as keys. Levente On Sun, 27 May 2012, commits(a)source.squeak.org wrote: > Eliot Miranda uploaded a new version of Kernel to project The Trunk: > http://source.squeak.org/trunk/Kernel-eem.692.mcz > > ==================== Summary ==================== > > Name: Kernel-eem.692 > Author: eem > Time: 27 May 2012, 3:08:41.389 pm > UUID: 72f75218-3cfc-4575-b159-8de0e44aa479 > Ancestors: Kernel-nice.691 > > Implement CompiledMethod>>#hash, both to accord with > CompiledMethod>>#= and to override ByteArray>>#hash > which looks at all bytes of the receiver and hence may > produce a variable hash if the GC moves literals in a method. > > =============== Diff against Kernel-nice.691 =============== > > Item was added: > + ----- Method: CompiledMethod>>hash (in category 'comparing') ----- > + hash > + "CompiledMethod>>#= compares code, i.e. same literals and same bytecode. > + So we look at the header, methodClass and some bytes between initialPC and endPC, > + but /not/ the selector because the equal method does not compare selectors. > + Note that we must override ByteArray>hash which looks at all bytes of the receiver. > + Using bytes from the pointer part of a COmpiledmethod can lead to a variable hash > + if and when when the GC moves literals in the receiver." > + | initialPC endPC hash | > + initialPC := self initialPC. > + endPC := self endPC. > + hash := self species hash + self header + initialPC + endPC + self methodClass hash bitAnd: 16rFFFFFFF. > + "sample approximately 20 bytes" > + initialPC to: endPC by: (endPC - initialPC // 20 max: 1) do: > + [:i| hash := hash + (self at: i)]. > + ^hash > + > + "(CompiledMethod>>#hash) hash"! > > >

4 4

Squeak CI notes
by Chris Cunnington 30 May '12

30 May '12

Here are a few notes about squeakci.org in no particular order: - this is a beta, as I'm shutting down this server in a few months; Jenkins will be installed on the new Squeak server - anybody who wants an account and is a core-dev or SOB member can contact me - when you get a Jenkins username/password, you also get an FTP username/password to access the workspace(s). Between the Jenkins UI and access to your job's workspace, you can control all the criteria of a build. - the only change you need to make to Lukas's code ( https://github.com/renggli/builder ) to make it work in 4.3 is to comment out two pieces of this method: HDTestReport >> run "Author uniqueInstance ifUnknownAuthorUse: 'hudson' during: [" [ self setUp. suiteTime := [ self runAll ] timeToRun ] ensure: [ self tearDown ] "]" - a word to the wary about Lukas's code, it's two years old. It will not work on Pharo 1.3 or 1.4 out of the box, as many little things keep changing (i.e. a VM file that was called "Squeak VM Opt" is now called "pharo"). Mariano's blog ( http://marianopeck.wordpress.com/tag/jenkins/ ) addresses some of the changes, as it was only written six months ago - I've deployed Jenkins, but Sean P. DeNigris knows far more about its day-to-day use, and so you're better off asking him how best to use it. Thanks, Chris

1 0

Daily Commit Log
by commits＠source.squeak.org 30 May '12

30 May '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-May/005353.html Name: Monticello-bf.509 Ancestors: Monticello-bf.508 Allow to specify branch name in MCFileBasedRepository>>versionNamesForPackageNamed: ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-May/005354.html Name: Installer-Core-bf.355 Ancestors: Installer-Core-ul.354 Do not automatically pick latest version from a different branch. (this currently happened in the FFI repo where the latest versions are FFI-Kernel-tbn.25 and FFI-Kernel.threaded-eem.25 and Installer picked the branch over the mainline) ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-May/005355.html Name: Graphics-bf.194 Ancestors: Graphics-bf.193 Add Point>>area (needed by CroquetGL) =============================================

1 0

Seeking new list moderator.
by Casey Ransberger 30 May '12

30 May '12

Hello all you wonderful people: bad news. I may lose Internet access for a time, soon. I hoped that I'd be able to fill this role for longer than I have, but the list is more important than my own service, so the correct course of action is to step down if there's anyone else who can do it, rather than risk leaving all of you without a moderator. Will anyone here fill these old shoes? Your friend, Casey Ransberger

2 2

Re: [squeak-dev] The Trunk: KernelTests-eem.224.mcz
by Frank Shearar 30 May '12

30 May '12

On 27 May 2012 23:16, <commits(a)source.squeak.org> wrote: > Eliot Miranda uploaded a new version of KernelTests to project The Trunk: > http://source.squeak.org/trunk/KernelTests-eem.224.mcz > > ==================== Summary ==================== > > Name: KernelTests-eem.224 > Author: eem > Time: 27 May 2012, 3:16:16.618 pm > UUID: 2d674fd0-22e3-4b5c-82ae-af5642c9614f > Ancestors: KernelTests-nice.223 > > Add a long test case for CompiledMethod = & hash > > =============== Diff against KernelTests-nice.223 =============== > > Item was added: > + LongTestCase subclass: #CompiledMethodComparisonTest > + instanceVariableNames: '' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'KernelTests-Methods'! > > Item was added: > + ----- Method: CompiledMethodComparisonTest>>testHash (in category 'tests') ----- > + testHash > + | ai | > + ai := CompiledMethod allInstances. > + ai do: > + [:a| > + ai do: > + [:b| > + a = b ifTrue: [self assert: a hash = b hash]]]! > > Not necessarily here, but it'd be good to see that (a = b) ifFalse: [self deny: a hash = b hash] holds. frank

4 5

GemSource downtime - May 29 2pm PDT
by Dale Henrichs 29 May '12

29 May '12

GemSource (http://seaside.gemstone.com) will be down from 2-3pm PST on May 29 to add additional storage. Please let me know if that will be a problem. Dale

1 1

Jump to page: