Squeak-dev October 2012

squeak-dev@lists.squeakfoundation.org

53 participants
109 discussions

The Trunk: System-eem.499.mcz
by commits＠source.squeak.org 27 Oct '12

27 Oct '12

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.499.mcz ==================== Summary ==================== Name: System-eem.499 Author: eem Time: 26 October 2012, 5:28:56.206 pm UUID: 816a8088-2f4a-4067-8645-ed0968ca0590 Ancestors: System-ul.498 Document remaining undocumented vmParameters. Document the settable vmParameters in the setter. =============== Diff against System-ul.498 =============== Item was changed: ----- Method: SmalltalkImage>>vmParameterAt: (in category 'system attributes') ----- vmParameterAt: parameterIndex "parameterIndex is a positive integer corresponding to one of the VM's internal parameter/metric registers. Answer with the current value of that register. Fail if parameterIndex has no corresponding register. VM parameters are numbered as follows: 1 end of old-space (0-based, read-only) 2 end of young-space (read-only) 3 end of memory (read-only) 4 allocationCount (read-only; nil in Cog VMs) 5 allocations between GCs (read-write; nil in Cog VMs) 6 survivor count tenuring threshold (read-write) 7 full GCs since startup (read-only) 8 total milliseconds in full GCs since startup (read-only) 9 incremental GCs since startup (read-only) 10 total milliseconds in incremental GCs since startup (read-only) 11 tenures of surving objects since startup (read-only) 12-20 specific to the translating VM 21 root table size (read-only) 22 root table overflows since startup (read-only) 23 bytes of extra memory to reserve for VM buffers, plugins, etc. 24 memory threshold above whichto shrink object memory (read-write) 25 memory headroom when growing object memory (read-write) + 26 interruptChecksEveryNms - force an ioProcessEvents every N milliseconds (read-write) - 26 interruptChecksEveryNms - force an ioProcessEvents every N milliseconds (read-write) 27 number of times mark loop iterated for current IGC/FGC (read-only) includes ALL marking + 28 number of times sweep loop iterated for current IGC/FGC (read-only) - 28 number of times sweep loop iterated for current IGC/FGC (read-only) 29 number of times make forward loop iterated for current IGC/FGC (read-only) 30 number of times compact move loop iterated for current IGC/FGC (read-only) 31 number of grow memory requests (read-only) 32 number of shrink memory requests (read-only) 33 number of root table entries used for current IGC/FGC (read-only) 34 number of allocations done before current IGC/FGC (read-only) 35 number of survivor objects after current IGC/FGC (read-only) + 36 millisecond clock when current IGC/FGC completed (read-only) + 37 number of marked objects for Roots of the world, not including Root Table entries for current IGC/FGC (read-only) + 38 milliseconds taken by current IGC (read-only) + 39 Number of finalization signals for Weak Objects pending when current IGC/FGC completed (read-only) + 40 BytesPerWord for this image + 41 imageFormatVersion for the VM - 36 millisecond clock when current IGC/FGC completed (read-only) - 37 number of marked objects for Roots of the world, not including Root Table entries for current IGC/FGC (read-only) - 38 milliseconds taken by current IGC (read-only) - 39 Number of finalization signals for Weak Objects pending when current IGC/FGC completed (read-only) - 40 BytesPerWord for this image - 41 imageFormatVersion for the VM 42 number of stack pages in use (Cog Stack VM only, otherwise nil) 43 desired number of stack pages (stored in image file header, max 65535; Cog VMs only, otherwise nil) 44 size of eden, in bytes (Cog VMs only, otherwise nil) 45 desired size of eden, in bytes (stored in image file header; Cog VMs only, otherwise nil) 46 size of machine code zone, in bytes (stored in image file header; Cog JIT VM only, otherwise nil) 47 desired size of machine code zone, in bytes (applies at startup only, stored in image file header; Cog JIT VM only) 48 various properties of the Cog VM as an integer encoding an array of bit flags. Bit 0: implies the image's Process class has threadId as its 3rd inst var (zero relative) + 49 the size of the external semaphore table (read-write; Cog VMs only) + 50-55 reserved for VM parameters that persist in the image (such as eden above) - 49-55 reserved for VM parameters that persist in the image (such as eden above) 56 number of process switches since startup (read-only) 57 number of ioProcessEvents calls since startup (read-only) 58 number of ForceInterruptCheck (Cog VMs) or quickCheckInterruptCalls (non-Cog VMs) calls since startup (read-only) 59 number of check event calls since startup (read-only) 60 number of stack page overflows since startup (read-only; Cog VMs only) + 61 number of stack page divorces since startup (read-only; Cog VMs only) + 62 number of machine code zone compactions since startup (read-only; Cog VMs only) + 63 milliseconds taken by machine code zone compactions since startup (read-only; Cog VMs only) + 64 current number of machine code methods (read-only; Cog VMs only) + 65 true if the VM supports multiple bytecode sets; (read-only; Cog VMs only; nil in older Cog VMs) + 70 the value of VM_PROXY_MAJOR (the interpreterProxy major version number) + 71 the value of VM_PROXY_MINOR (the interpreterProxy minor version number)" - 61 number of stack page divorces since startup (read-only; Cog VMs only)" <primitive: 254> self primitiveFailed! Item was changed: ----- Method: SmalltalkImage>>vmParameterAt:put: (in category 'vm parameters') ----- vmParameterAt: parameterIndex put: newValue "parameterIndex is a positive integer corresponding to one of the VM's internal parameter/metric registers. Store newValue (a positive integer) into that register and answer with the previous value that was stored there. Fail if newValue is out of range, if parameterIndex has no corresponding + register, or if the corresponding register is read-only. - register, or if the corresponding register is read-only." + As of 2011-ish the parameters which can be set are + 5 allocations between GCs (read-write; nil in Cog VMs) + 6 survivor count tenuring threshold (read-write) + 23 bytes of extra memory to reserve for VM buffers, plugins, etc. + 24 memory threshold above whichto shrink object memory (read-write) + 25 memory headroom when growing object memory (read-write) + 26 interruptChecksEveryNms - force an ioProcessEvents every N milliseconds (read-write) + 43 desired number of stack pages (stored in image file header, max 65535; Cog VMs only, otherwise nil) + 45 desired size of eden, in bytes (stored in image file header; Cog VMs only, otherwise nil) + 47 desired size of machine code zone, in bytes (applies at startup only, stored in image file header; Cog JIT VM only) + 48 various properties of the Cog VM as an integer encoding an array of bit flags. + Bit 0: implies the image's Process class has threadId as its 3rd inst var (zero relative) + 49 the size of the external semaphore table (read-write; Cog VMs only)" + <primitive: 254> self primitiveFailed!

1 0

How to remove doIts from cganges
by Herbert König 26 Oct '12

26 Oct '12

Hi, I know how to remove a version of a method from the changes file but how do I remove a doIt from the changes file? Thanks Herbert

6 8

Linux-VW for ARM
by Dietmar Schielke 26 Oct '12

26 Oct '12

Hello Squeakers, I want to deploy a Seaside 3.0 application on a NAS-Systems (D-LINK 323 and QNAP TS419 PII at the moment) with arm-processors. Does anybody know, where to get a squeak-VM for these systems? Or as an option - Where should I start reading about building my own VM for these systems? I'm a little bit confused about the intended way. There is squeakvm.org, https://gitorious.org/cogvm, a Unix-VM build script, Jenkins.... I searched the wiki with no success. Thanks in advance! Dietmar

3 4

newbie question: how to replace a character with nothing
by Joseph J Alotta 26 Oct '12

26 Oct '12

Greetings. I found a useful method. Only thing is I don't know how to write the character code for no character. '12%31%%1232' replaceAll: $% with: $. '12.31..1232' '12%31%%1232' replaceAll: $% with: $* '12*31**1232' '12%31%%1232' replaceAll: $% with: '' ==> error '12%31%%1232' replaceAll: $% with: Nil ==> error I looked for a deleteAll: method but there is none for Strings. Thank you for your help. Joe.

4 3

Daily Commit Log
by commits＠source.squeak.org 26 Oct '12

26 Oct '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-October/005539.ht… Name: Collections-ul.494 Ancestors: Collections-cwp.493 - more straightforward String >> #numArgs implementation (early returns, less branches) - added an optimized version of #canBeToken to ByteSymbol - removed the sentence about uppercase first letter from String >> #numArgs, because it wasn't true even in 2004 ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-October/005540.ht… Name: Compiler-cwp.237 Ancestors: Compiler-eem.234, Compiler-cwp.235 Reinitialize String every time the #allowUnderscoreSelectors preference is changed, so that the Tokenish character map will be correct. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-October/005541.ht… Name: Tests-cwp.175 Ancestors: Tests-cwp.174 Added more #numArgs tests. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-October/005542.ht… Name: ShoutCore-cwp.36 Ancestors: ShoutCore-fbs.35 Remove support for per-class settings of #allowUnderscoreSelectors. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-October/005543.ht… Name: Kernel-cwp.714 Ancestors: Kernel-eem.713, Kernel-cwp.709 Merge in cwp.709: Remove support for per-class settings of #allowUnderscoreSelectors. =============================================

1 0

The Trunk: Kernel-cwp.714.mcz
by commits＠source.squeak.org 25 Oct '12

25 Oct '12

Colin Putney uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-cwp.714.mcz ==================== Summary ==================== Name: Kernel-cwp.714 Author: cwp Time: 25 October 2012, 12:16:19.282 pm UUID: fd5a8602-5b4f-46d0-86ee-c89e91f2e20f Ancestors: Kernel-eem.713, Kernel-cwp.709 Merge in cwp.709: Remove support for per-class settings of #allowUnderscoreSelectors. =============== Diff against Kernel-eem.713 =============== Item was removed: - ----- Method: Behavior>>allowUnderscoreSelectors (in category 'compiling') ----- - allowUnderscoreSelectors - "Return true if the receiver and its subclasses should be allowed to use underscore in selectors. Returning nil here means that the compiler should use the system-wide default preference. Also see #allowUnderscoreAssignments. - - Combinations: If both preferences are false, underscore is illegal. If both preferences are true, underscore assignment needs the be surrounded by spaces and a single underscore cannot be used as selector." - ^nil!

1 0

The Trunk: ShoutCore-cwp.36.mcz
by commits＠source.squeak.org 25 Oct '12

25 Oct '12

Colin Putney uploaded a new version of ShoutCore to project The Trunk: http://source.squeak.org/trunk/ShoutCore-cwp.36.mcz ==================== Summary ==================== Name: ShoutCore-cwp.36 Author: cwp Time: 13 August 2012, 3:54:21.383 pm UUID: 7729b40e-37ab-47e5-84a0-b115c6a1a55a Ancestors: ShoutCore-fbs.35 Remove support for per-class settings of #allowUnderscoreSelectors. =============== Diff against ShoutCore-fbs.35 =============== Item was removed: - ----- Method: SHMCClassDefinition>>allowUnderscoreSelectors (in category 'act like a class') ----- - allowUnderscoreSelectors - - ^nil! Item was changed: ----- Method: SHParserST80>>allowUnderscoreSelectors (in category 'private') ----- allowUnderscoreSelectors + ^ Scanner prefAllowUnderscoreSelectors! - "Query class + preference" - ^(classOrMetaClass ifNotNil: [:c | c allowUnderscoreSelectors]) - ifNil: [Scanner prefAllowUnderscoreSelectors]!

1 0

The Trunk: Tests-cwp.175.mcz
by commits＠source.squeak.org 25 Oct '12

25 Oct '12

Colin Putney uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-cwp.175.mcz ==================== Summary ==================== Name: Tests-cwp.175 Author: cwp Time: 24 October 2012, 2:51:57.527 pm UUID: 6a009ff2-a82e-4905-ab57-4f4d5b4a9818 Ancestors: Tests-cwp.174 Added more #numArgs tests. =============== Diff against Tests-eem.172 =============== Item was added: + ----- Method: UnderscoreSelectorsTest>>assertString:hasNumArgs: (in category 'support') ----- + assertString: aString hasNumArgs: anInteger + | num | + num := aString numArgs. + self assert: num = anInteger! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA0NoUnderscoreAllowed (in category 'tests') ----- + testA0NoUnderscoreAllowed + self pref: true during: [self assertString: 'ab' hasNumArgs: 0]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA0NoUnderscoreForbidden (in category 'tests') ----- + testA0NoUnderscoreForbidden + self pref: false during: [self assertString: 'ab' hasNumArgs: 0]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA0UnderscoreAllowed (in category 'tests') ----- + testA0UnderscoreAllowed + self pref: true during: [self assertString: 'a_b' hasNumArgs: 0]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA0UnderscoreForbidden (in category 'tests') ----- + testA0UnderscoreForbidden + self pref: false during: [self assertString: 'a_b' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA1NoUnderscoreAllowed (in category 'tests') ----- + testA1NoUnderscoreAllowed + self pref: true during: [self assertString: 'ab:' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA1NoUnderscoreForbidden (in category 'tests') ----- + testA1NoUnderscoreForbidden + self pref: false during: [self assertString: 'ab:' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA1UnderscoreAllowed (in category 'tests') ----- + testA1UnderscoreAllowed + self pref: true during: [self assertString: 'a_b:' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA1UnderscoreForbidden (in category 'tests') ----- + testA1UnderscoreForbidden + self pref: false during: [self assertString: 'a_b:' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA2NoUnderscoreAllowed (in category 'tests') ----- + testA2NoUnderscoreAllowed + self pref: true during: [self assertString: 'ab:cd:' hasNumArgs: 2]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA2NoUnderscoreForbidden (in category 'tests') ----- + testA2NoUnderscoreForbidden + self pref: false during: [self assertString: 'ab:cd:' hasNumArgs: 2]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA2UnderscoreAllowed (in category 'tests') ----- + testA2UnderscoreAllowed + self pref: true during: [self assertString: 'a_b:cd:' hasNumArgs: 2]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testA2UnderscoreForbidden (in category 'tests') ----- + testA2UnderscoreForbidden + self pref: false during: [self assertString: 'a_b:cd:' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testB1Allowed (in category 'tests') ----- + testB1Allowed + self pref: true during: [self assertString: '+' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testB1Forbidden (in category 'tests') ----- + testB1Forbidden + self pref: false during: [self assertString: '+' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testB2Allowed (in category 'tests') ----- + testB2Allowed + self pref: true during: [self assertString: '++' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testB2Forbidden (in category 'tests') ----- + testB2Forbidden + self pref: false during: [self assertString: '++' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testEmpty (in category 'tests') ----- + testEmpty + self assertString: '' hasNumArgs: -1! Item was added: + ----- Method: UnderscoreSelectorsTest>>testInvalidUnderscoreAllowed (in category 'tests') ----- + testInvalidUnderscoreAllowed + self pref: true during: [self assertString: '3' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testInvalidUnderscoreForbidden (in category 'tests') ----- + testInvalidUnderscoreForbidden + self pref: false during: [self assertString: '3' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testLeadingColonAllowed (in category 'tests') ----- + testLeadingColonAllowed + self pref: true during: [self assertString: ':if:then:else:' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testLeadingColonForbidden (in category 'tests') ----- + testLeadingColonForbidden + self pref: false during: [self assertString: #':if:then:else:' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testNoTrailingColonAllowed (in category 'tests') ----- + testNoTrailingColonAllowed + self pref: true during: [self assertString: 'nextPut:andCR' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testNoTrailingColonForbidden (in category 'tests') ----- + testNoTrailingColonForbidden + self pref: false during: [self assertString: 'nextPut:andCR' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA0NoUnderscoreAllowed (in category 'tests') ----- + testSelA0NoUnderscoreAllowed + self pref: true during: [self assertString: #'ab' hasNumArgs: 0]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA0NoUnderscoreForbidden (in category 'tests') ----- + testSelA0NoUnderscoreForbidden + self pref: false during: [self assertString: #'ab' hasNumArgs: 0]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA0UnderscoreAllowed (in category 'tests') ----- + testSelA0UnderscoreAllowed + self pref: true during: [self assertString: #'a_b' hasNumArgs: 0]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA0UnderscoreForbidden (in category 'tests') ----- + testSelA0UnderscoreForbidden + self pref: false during: [self assertString: #'a_b' hasNumArgs: 0]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA1NoUnderscoreAllowed (in category 'tests') ----- + testSelA1NoUnderscoreAllowed + self pref: true during: [self assertString: #'ab:' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA1NoUnderscoreForbidden (in category 'tests') ----- + testSelA1NoUnderscoreForbidden + self pref: false during: [self assertString: #'ab:' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA1UnderscoreAllowed (in category 'tests') ----- + testSelA1UnderscoreAllowed + self pref: true during: [self assertString: #'a_b:' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA1UnderscoreForbidden (in category 'tests') ----- + testSelA1UnderscoreForbidden + self pref: false during: [self assertString: #'a_b:' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA2NoUnderscoreAllowed (in category 'tests') ----- + testSelA2NoUnderscoreAllowed + self pref: true during: [self assertString: #'ab:cd:' hasNumArgs: 2]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA2NoUnderscoreForbidden (in category 'tests') ----- + testSelA2NoUnderscoreForbidden + self pref: false during: [self assertString: #'ab:cd:' hasNumArgs: 2]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA2UnderscoreAllowed (in category 'tests') ----- + testSelA2UnderscoreAllowed + self pref: true during: [self assertString: #'a_b:cd:' hasNumArgs: 2]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelA2UnderscoreForbidden (in category 'tests') ----- + testSelA2UnderscoreForbidden + self pref: false during: [self assertString: #'a_b:cd:' hasNumArgs: 2]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelB1Allowed (in category 'tests') ----- + testSelB1Allowed + self pref: true during: [self assertString: #'+' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelB1Forbidden (in category 'tests') ----- + testSelB1Forbidden + self pref: false during: [self assertString: #'+' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelB2Allowed (in category 'tests') ----- + testSelB2Allowed + self pref: true during: [self assertString: #'++' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelB2Forbidden (in category 'tests') ----- + testSelB2Forbidden + self pref: false during: [self assertString: #'++' hasNumArgs: 1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelEmpty (in category 'tests') ----- + testSelEmpty + self assertString: #'' hasNumArgs: -1! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelInvalidUnderscoreAllowed (in category 'tests') ----- + testSelInvalidUnderscoreAllowed + self pref: true during: [self assertString: #'3' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelInvalidUnderscoreForbidden (in category 'tests') ----- + testSelInvalidUnderscoreForbidden + self pref: false during: [self assertString: #'3' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelLeadingColonAllowed (in category 'tests') ----- + testSelLeadingColonAllowed + self pref: true during: [self assertString: #':if:then:else:' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelNoTrailingColonAllowed (in category 'tests') ----- + testSelNoTrailingColonAllowed + self pref: true during: [self assertString: #'nextPut:andCR' hasNumArgs: -1]! Item was added: + ----- Method: UnderscoreSelectorsTest>>testSelNoTrailingColonForbidden (in category 'tests') ----- + testSelNoTrailingColonForbidden + self pref: false during: [self assertString: #'nextPut:andCR' hasNumArgs: -1]!

1 0

The Trunk: Compiler-cwp.237.mcz
by commits＠source.squeak.org 25 Oct '12

25 Oct '12

Colin Putney uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-cwp.237.mcz ==================== Summary ==================== Name: Compiler-cwp.237 Author: cwp Time: 22 October 2012, 12:41:37.581 am UUID: 88c324fe-9302-4ec9-ba3c-beb6c3aae7d0 Ancestors: Compiler-eem.234, Compiler-cwp.235 Reinitialize String every time the #allowUnderscoreSelectors preference is changed, so that the Tokenish character map will be correct. =============== Diff against Compiler-eem.234 =============== Item was removed: - ----- Method: Parser>>allowUnderscoreSelectors (in category 'private') ----- - allowUnderscoreSelectors - "Query class + preference" - ^encoder classEncoding allowUnderscoreSelectors - ifNil:[super allowUnderscoreSelectors]! Item was changed: ----- Method: Scanner class>>prefAllowUnderscoreSelectors: (in category 'preferences') ----- prefAllowUnderscoreSelectors: aBool "Accessor for the system-wide preference" + AllowUnderscoreSelectors := aBool. + + "Reinitialize String's tokenish character map" + String initialize! - AllowUnderscoreSelectors := aBool!

1 0

The Trunk: Collections-ul.494.mcz
by commits＠source.squeak.org 25 Oct '12

25 Oct '12

Colin Putney uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.494.mcz ==================== Summary ==================== Name: Collections-ul.494 Author: ul Time: 25 October 2012, 1:56:50.407 am UUID: 1b62455b-152d-4ffc-8072-5b6086cb26a8 Ancestors: Collections-cwp.493 - more straightforward String >> #numArgs implementation (early returns, less branches) - added an optimized version of #canBeToken to ByteSymbol - removed the sentence about uppercase first letter from String >> #numArgs, because it wasn't true even in 2004 =============== Diff against Collections-fbs.490 =============== Item was added: + ----- Method: ByteString>>canBeToken (in category 'testing') ----- + canBeToken + "Optimized version for the common case." + + ^ (self findSubstring: '~' in: self startingAt: 1 matchTable: Tokenish) = 0 + ! Item was added: + ----- Method: ByteSymbol>>canBeToken (in category 'testing') ----- + canBeToken + "Optimized version for the common case." + + | index | + index := 0. + [ (index := self findSubstring: '~' in: self startingAt: index + 1 matchTable: Tokenish) = 0 ] + whileFalse: [ + (self at: index) == $_ ifFalse: [ ^false ] ]. + ^true + ! Item was added: + ----- Method: String>>canBeToken (in category 'testing') ----- + canBeToken + "Extracted from #numArgs to allow specialization by subclasses" + + ^ self allSatisfy: [:c | c tokenish]! Item was changed: ----- Method: String>>numArgs (in category 'accessing') ----- numArgs + "Answer either the number of arguments that the receiver would take if considered a selector. Answer -1 if it couldn't be a selector. It is intended mostly for the assistance of spelling correction." - "Answer either the number of arguments that the receiver would take if considered a selector. Answer -1 if it couldn't be a selector. Note that currently this will answer -1 for anything begining with an uppercase letter even though the system will accept such symbols as selectors. It is intended mostly for the assistance of spelling correction." + | firstChar numColons start ix | + self size = 0 ifTrue: [ ^-1 ]. - | firstChar numColons excess start ix | - self size = 0 ifTrue: [^ -1]. firstChar := self at: 1. + firstChar isSpecial ifTrue: [ + 2 to: self size do: [ :i | (self at: i) isSpecial ifFalse: [ ^-1 ] ]. + ^1 ]. + firstChar isLetter ifFalse: [ ^-1 ]. + self canBeToken ifFalse: [ ^-1 ]. + "Fast colon count" + numColons := 0. + start := 1. + [ (ix := self indexOf: $: startingAt: start) > 0 ] whileTrue: [ + numColons := numColons + 1. + start := ix + 1]. + (numColons > 0 and: [ self last ~= $: ]) ifTrue: [ ^-1 ]. + ^numColons! - (firstChar isLetter or: [firstChar = $:]) ifTrue: - ["Fast reject if any chars are non-alphanumeric - NOTE: fast only for Byte things - Broken for Wide" - Scanner prefAllowUnderscoreSelectors ifFalse: - [self class isBytes - ifTrue: [(self findSubstring: '~' in: self startingAt: 1 matchTable: Tokenish) > 0 ifTrue: [^ -1]] - ifFalse: [2 to: self size do: [:i | (self at: i) tokenish ifFalse: [^ -1]]]]. - "Fast colon count" - numColons := 0. start := 1. - [(ix := self indexOf: $: startingAt: start) > 0] - whileTrue: - [numColons := numColons + 1. - start := ix + 1]. - numColons = 0 ifTrue: [^ 0]. - firstChar = $: - ifTrue: [excess := 2 "Has an initial keyword, as #:if:then:else:"] - ifFalse: [excess := 0]. - self last = $: - ifTrue: [^ numColons - excess] - ifFalse: [^ numColons - excess - 1 "Has a final keywords as #nextPut::andCR"]]. - firstChar isSpecial ifTrue: - [self size = 1 ifTrue: [^ 1]. - 2 to: self size do: [:i | (self at: i) isSpecial ifFalse: [^ -1]]. - ^ 1]. - ^ -1.! Item was added: + ----- Method: Symbol>>canBeToken (in category 'testing') ----- + canBeToken + "Since definition of #tokenish depends on a preference, we want to make sure + that underscores are always considered tokenish. This is so that selectors created + when the preference was turned on don't suddenly become invalid when the + preference is turned off." + + ^ self allSatisfy: [:c | c = $_ or: [c tokenish]]!

1 0

← Newer
1
2
3
4
5
6
7
...
11
Older →