Squeak-dev November 2011

squeak-dev@lists.squeakfoundation.org

52 participants
168 discussions

The Inbox: SystemChangeNotification-Tests-laza.16.mcz
by commits＠source.squeak.org 03 Nov '11

03 Nov '11

A new version of SystemChangeNotification-Tests was added to project The Inbox: http://source.squeak.org/inbox/SystemChangeNotification-Tests-laza.16.mcz ==================== Summary ==================== Name: SystemChangeNotification-Tests-laza.16 Author: laza Time: 3 November 2011, 8:09:52.984 am UUID: 8edbb2d9-dbf3-6d44-8e0d-941702d8f7cc Ancestors: SystemChangeNotification-Tests-laza.15 SystemOrganizer>>addCategory:before: does not trigger any notifications =============== Diff against SystemChangeNotification-Tests-laza.15 =============== Item was added: + ----- Method: SystemChangeFileTest>>testCategoryAddedBefore (in category 'testing') ----- + testCategoryAddedBefore + | aClassCategory | + aClassCategory := self genericClassCategory. + self + change: [ + SystemOrganization addCategory: aClassCategory before: nil. + ] + verify: [ + self assert: (SystemOrganization categories includes: aClassCategory). + ] + !

1 0

The Inbox: Kernel-laza.649.mcz
by commits＠source.squeak.org 03 Nov '11

03 Nov '11

Alexander Lazarević uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-laza.649.mcz ==================== Summary ==================== Name: Kernel-laza.649 Author: laza Time: 3 November 2011, 1:09:36.555 am UUID: 9ee9cceb-4b76-3d41-8a57-bd0b6eb79dc0 Ancestors: Kernel-eem.648 Make protocol changes be recorded by the changes file. =============== Diff against Kernel-eem.648 =============== Item was changed: ----- Method: ClassOrganizer>>addCategory:before: (in category 'accessing') ----- addCategory: catString before: nextCategory - | oldCategories | - oldCategories := self categories copy. SystemChangeNotifier uniqueInstance doSilently: [ super addCategory: catString before: nextCategory]. + self notifyOfChangedCategoryFrom: nil to: catString.! - self notifyOfChangedCategoriesFrom: oldCategories to: self categories.! Item was changed: ----- Method: ClassOrganizer>>notifyOfChangedCategoryFrom:to: (in category 'private') ----- notifyOfChangedCategoryFrom: oldNameOrNil to: newNameOrNil (self hasSubject and: [oldNameOrNil ~= newNameOrNil]) + ifTrue: [ + oldNameOrNil + ifNil: [ + newNameOrNil ifNotNil: [ + SystemChangeNotifier uniqueInstance + protocolAdded: newNameOrNil inClass: self subject. + ] + ] + ifNotNil: [ + newNameOrNil ifNil: [ + SystemChangeNotifier uniqueInstance + protocolRemoved: oldNameOrNil inClass: self subject. + ] + ifNotNil: [ + SystemChangeNotifier uniqueInstance + protocolRenamedFrom: oldNameOrNil to: newNameOrNil inClass: self subject. + ] + ]. + ].! - ifTrue: [SystemChangeNotifier uniqueInstance classReorganized: self subject].! Item was changed: ----- Method: ClassOrganizer>>removeCategory: (in category 'accessing') ----- removeCategory: cat - | oldCategories | - oldCategories := self categories copy. SystemChangeNotifier uniqueInstance doSilently: [ super removeCategory: cat]. + self notifyOfChangedCategoryFrom: cat to: nil.! - self notifyOfChangedCategoriesFrom: oldCategories to: self categories.! Item was changed: ----- Method: ClassOrganizer>>renameCategory:toBe: (in category 'accessing') ----- renameCategory: oldCatString toBe: newCatString + | oldCat newCat | - | oldCat newCat oldElementsBefore oldElementsAfter | oldCat := oldCatString asSymbol. newCat := newCatString asSymbol. - oldElementsBefore := self listAtCategoryNamed: oldCat. SystemChangeNotifier uniqueInstance doSilently: [ super renameCategory: oldCatString toBe: newCatString]. - oldElementsAfter := (self listAtCategoryNamed: oldCat) asSet. - oldElementsBefore do: [:each | - (oldElementsAfter includes: each) - ifFalse: [self notifyOfChangedSelector: each from: oldCat to: newCat]. - ]. self notifyOfChangedCategoryFrom: oldCat to: newCat.!

1 0

The Inbox: System-laza.458.mcz
by commits＠source.squeak.org 03 Nov '11

03 Nov '11

Alexander Lazarević uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-laza.458.mcz ==================== Summary ==================== Name: System-laza.458 Author: laza Time: 3 November 2011, 1:07:36.814 am UUID: 8f28a011-2e47-6a4a-b6a1-8a141585de6a Ancestors: System-laza.457 Connect some lose ends to make more changes be recorded by the changes file =============== Diff against System-laza.457 =============== Item was added: + ----- Method: AbstractEvent class>>protocol:class: (in category 'instance creation') ----- + protocol: aProtocol class: aClass + + | instance | + instance := self item: aProtocol kind: self protocolKind. + instance itemClass: aClass. + ^instance! Item was changed: ----- Method: SmalltalkImage>>event: (in category 'sources, changes log') ----- event: anEvent "Hook for SystemChangeNotifier" + anEvent isDoIt ifTrue: [^self logChange: anEvent item]. + (anEvent itemKind = SystemChangeNotifier categoryKind) ifTrue: [ + anEvent isAdded + ifTrue: [^self logChange: 'SystemOrganization addCategory: ', anEvent item storeString]. + anEvent isRemoved + ifTrue: [^self logChange: 'SystemOrganization removeSystemCategory: ', anEvent item storeString]. + anEvent isRenamed + ifTrue: [^self logChange: 'SystemOrganization renameCategory: ', anEvent oldName storeString, ' toBe: ', anEvent newName storeString]. - (anEvent isRemoved and: [anEvent itemKind = SystemChangeNotifier classKind]) ifTrue: [ - anEvent item acceptsLoggingOfCompilation - ifTrue: [self logChange: 'Smalltalk removeClassNamed: #' , anEvent item name]. ]. + + (anEvent itemKind = SystemChangeNotifier classKind) ifTrue: [ + anEvent item acceptsLoggingOfCompilation ifFalse: [^self]. + "anEvent isAdded ifTrue: [ + self logChange: anEvent item definition. + ]." + anEvent isModified + ifTrue: [^self logChange: anEvent item definition]. + anEvent isRemoved + ifTrue: [^self logChange: 'Smalltalk removeClassNamed: ' , anEvent item name storeString]. + anEvent isRenamed + ifTrue: [^self logChange: 'Smalltalk renameClassNamed: ', anEvent oldName storeString, ' as: ', anEvent newName storeString]. + ]. + + (anEvent itemKind = SystemChangeNotifier protocolKind) ifTrue: [ + anEvent isAdded + ifTrue: [^self logChange: anEvent itemClass name , ' organization addCategory: ' , anEvent itemProtocol storeString]. + anEvent isRemoved + ifTrue: [^self logChange: anEvent itemClass name , ' organization removeCategory: ' , anEvent itemProtocol storeString]. + anEvent isRenamed + ifTrue: [^self logChange: anEvent itemClass name , ' organization renameCategory: ' , anEvent oldName storeString, ' toBe: ', anEvent newName storeString]. + ]. + + (anEvent itemKind = SystemChangeNotifier methodKind) ifTrue: [ + anEvent itemClass acceptsLoggingOfCompilation ifFalse: [^self]. + anEvent isRemoved + ifTrue: [^self logChange: anEvent itemClass name , ' removeSelector: ' , anEvent itemSelector storeString]. + anEvent isRecategorized + ifTrue: [ + | newProtocol | + newProtocol := anEvent itemClass organization categoryOfElement: anEvent item selector. + ^self logChange: anEvent itemClass name , ' organization classify: ', anEvent item selector storeString, ' under: ', newProtocol storeString. + ]. + ].! - anEvent isDoIt - ifTrue: [self logChange: anEvent item]. - (anEvent isRemoved and: [anEvent itemKind = SystemChangeNotifier methodKind]) ifTrue: [ - anEvent itemClass acceptsLoggingOfCompilation - ifTrue: [self logChange: anEvent itemClass name , ' removeSelector: #' , anEvent itemSelector]].! Item was added: + ----- Method: SystemChangeNotifier>>protocolAdded:inClass: (in category 'system triggers') ----- + protocolAdded: aProtocol inClass: aClass + self trigger: ( + AddedEvent protocol: aProtocol class: aClass + )! Item was added: + ----- Method: SystemChangeNotifier>>protocolRemoved:inClass: (in category 'system triggers') ----- + protocolRemoved: aProtocol inClass: aClass + self trigger: ( + RemovedEvent protocol: aProtocol class: aClass + )! Item was added: + ----- Method: SystemChangeNotifier>>protocolRenamedFrom:to:inClass: (in category 'system triggers') ----- + protocolRenamedFrom: anOldProtocol to: aNewProtocol inClass: aClass + self trigger: ( + (RenamedEvent protocol: anOldProtocol class: aClass) + oldName: anOldProtocol; + newName: aNewProtocol + )!

1 0

The Inbox: SystemChangeNotification-Tests-laza.15.mcz
by commits＠source.squeak.org 03 Nov '11

03 Nov '11

Alexander Lazarević uploaded a new version of SystemChangeNotification-Tests to project The Inbox: http://source.squeak.org/inbox/SystemChangeNotification-Tests-laza.15.mcz ==================== Summary ==================== Name: SystemChangeNotification-Tests-laza.15 Author: laza Time: 3 November 2011, 1:04:56.372 am UUID: e087542f-fe58-0142-9ac6-e789b19abe57 Ancestors: SystemChangeNotification-Tests-laza.14 Some tests to check the things that are recorded by the changes file =============== Diff against SystemChangeNotification-Tests-bp.11 =============== Item was added: + TestCase subclass: #SystemChangeFileTest + instanceVariableNames: 'tempChangesFile' + classVariableNames: '' + poolDictionaries: '' + category: 'SystemChangeNotification-Tests'! Item was added: + ----- Method: SystemChangeFileTest>>change:verify: (in category 'testing') ----- + change: changeBlock verify: verifyBlock + self prepare: [] change: changeBlock verify: verifyBlock! Item was added: + ----- Method: SystemChangeFileTest>>createClass: (in category 'private') ----- + createClass: name + ^Object + subclass: name + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: self genericClassCategory! Item was added: + ----- Method: SystemChangeFileTest>>directory (in category 'accessing') ----- + directory + "Where we want to place the temporary changes file" + ^FileDirectory default! Item was added: + ----- Method: SystemChangeFileTest>>genericClassCategory (in category 'private') ----- + genericClassCategory + ^(self prefixClassCategory, self randomString capitalized) asSymbol! Item was added: + ----- Method: SystemChangeFileTest>>genericClassName (in category 'private') ----- + genericClassName + ^(self prefixClassName, self randomString capitalized) asSymbol! Item was added: + ----- Method: SystemChangeFileTest>>genericInstVarName (in category 'private') ----- + genericInstVarName + ^(self prefixInstVarName, self randomString capitalized) asSymbol! Item was added: + ----- Method: SystemChangeFileTest>>genericProtocol (in category 'private') ----- + genericProtocol + ^(self prefixProtocol, self randomString) asSymbol! Item was added: + ----- Method: SystemChangeFileTest>>genericSelector (in category 'private') ----- + genericSelector + ^(self prefixSelector, self randomString capitalized) asSymbol! Item was added: + ----- Method: SystemChangeFileTest>>prefixClassCategory (in category 'private') ----- + prefixClassCategory + ^self prefixGeneral, 'Category-'! Item was added: + ----- Method: SystemChangeFileTest>>prefixClassName (in category 'private') ----- + prefixClassName + ^self prefixGeneral, 'Class'! Item was added: + ----- Method: SystemChangeFileTest>>prefixGeneral (in category 'private') ----- + prefixGeneral + ^self class name select: [:each | each isUppercase]! Item was added: + ----- Method: SystemChangeFileTest>>prefixInstVarName (in category 'private') ----- + prefixInstVarName + ^self prefixGeneral asLowercase, 'InstVar'! Item was added: + ----- Method: SystemChangeFileTest>>prefixProtocol (in category 'private') ----- + prefixProtocol + ^self prefixGeneral asLowercase, ' protocol '! Item was added: + ----- Method: SystemChangeFileTest>>prefixSelector (in category 'private') ----- + prefixSelector + ^self prefixGeneral asLowercase, 'Selector'! Item was added: + ----- Method: SystemChangeFileTest>>prepare:change:verify: (in category 'testing') ----- + prepare: prepareBlock change: changeBlock verify: verifyBlock + "All tests follow this pattern. Beware that prepareBlock (and verifyBlock) will be evalutated twice." + + "Setup the testcourt" + prepareBlock value. + + "Embrace the changeBlock so that any changes to our testcourt + gets recorded in our temporary changes file" + self useTemporaryChangesFile. + changeBlock value. + "Check if the changes we made worked as expected. We need to do + this before we switch back to the standard changes file" + "We raise an Error if this fails, because then the testcase is broken" + [verifyBlock value] + on: TestFailure + do: [self error: 'The verifyBlock needs to validate the changes made in the changeBlock']. + self useStandardChangesFile. + + "Remove the testcourt completely" + self removeTestcourt. + + "Setup the testcourt once again" + prepareBlock value. + + "Replay the changes from the temporary changes file" + self replayChanges. + + "See if we got the same changes as we did before using the changeBlock" + verifyBlock value. + ! Item was added: + ----- Method: SystemChangeFileTest>>randomString (in category 'private') ----- + randomString + ^Character alphabet shuffled! Item was added: + ----- Method: SystemChangeFileTest>>removeTestcourt (in category 'private') ----- + removeTestcourt + SystemOrganization categories do: [:each | + (each beginsWith: self prefixClassCategory) ifTrue: [ + SystemOrganization removeSystemCategory: each. + ]. + ]. + + ! Item was added: + ----- Method: SystemChangeFileTest>>replayChanges (in category 'private') ----- + replayChanges + | file | + file := FileStream fileNamed: (self directory fullNameFor: self tempChangesName). + Transcript show: file contents; cr. + file fileIn. + ! Item was added: + ----- Method: SystemChangeFileTest>>tearDown (in category 'running') ----- + tearDown + self useStandardChangesFile. + tempChangesFile := tempChangesFile ifNotNil: [tempChangesFile close]. + (self directory fileExists: self tempChangesName) + ifTrue: [self directory deleteFileNamed: self tempChangesName]. + self removeTestcourt. + ! Item was added: + ----- Method: SystemChangeFileTest>>tempChangesName (in category 'accessing') ----- + tempChangesName + ^'temp.changes'! Item was added: + ----- Method: SystemChangeFileTest>>testCategoryAdded (in category 'testing') ----- + testCategoryAdded + | aClassCategory | + aClassCategory := self genericClassCategory. + self + change: [ + SystemOrganization addCategory: aClassCategory. + ] + verify: [ + self assert: (SystemOrganization categories includes: aClassCategory). + ] + ! Item was added: + ----- Method: SystemChangeFileTest>>testCategoryModified (in category 'as yet unclassified') ----- + testCategoryModified! Item was added: + ----- Method: SystemChangeFileTest>>testCategoryRemoved (in category 'testing') ----- + testCategoryRemoved + | aClassCategory | + aClassCategory := self genericClassCategory. + self + prepare: [ + SystemOrganization addCategory: aClassCategory. + ] + change: [ + SystemOrganization removeCategory: aClassCategory. + ] + verify: [ + self deny: (SystemOrganization categories includes: aClassCategory). + ] + ! Item was added: + ----- Method: SystemChangeFileTest>>testCategoryRenamed (in category 'testing') ----- + testCategoryRenamed + | aNewClassCategory anOldClassCategory | + anOldClassCategory := self genericClassCategory. + aNewClassCategory := self genericClassCategory. + self + prepare: [ + SystemOrganization addCategory: anOldClassCategory. + ] + change: [ + SystemOrganization renameCategory: anOldClassCategory toBe: aNewClassCategory + ] + verify: [ + self assert: (SystemOrganization categories includes: aNewClassCategory). + self deny: (SystemOrganization categories includes: anOldClassCategory). + ] + ! Item was added: + ----- Method: SystemChangeFileTest>>testClassAdded (in category 'testing') ----- + testClassAdded + | aClassName | + aClassName := self genericClassName. + self + change: [ + self createClass: aClassName. + ] + verify: [ + self assert: (Smalltalk keys includes: aClassName). + ] + + ! Item was added: + ----- Method: SystemChangeFileTest>>testClassCommented (in category 'testing') ----- + testClassCommented + | aClass aClassName aComment | + aClassName := self genericClassName. + self + prepare: [ + aClass := self createClass: aClassName. + ] + change: [ + aComment := self randomString. + aClass classComment: aComment. + ] + verify: [ + self assert: aClass organization classComment string = aComment. + ].! Item was added: + ----- Method: SystemChangeFileTest>>testClassModified (in category 'testing') ----- + testClassModified + | aClass aClassName aInstVarName | + aClassName := self genericClassName. + self + prepare: [ + aClass := self createClass: aClassName. + ] + change: [ + aInstVarName := self genericInstVarName. + aClass addInstVarName: aInstVarName. + ] + verify: [ + self assert: (aClass instVarNames includes: aInstVarName). + ].! Item was added: + ----- Method: SystemChangeFileTest>>testClassRecategorized (in category 'as yet unclassified') ----- + testClassRecategorized! Item was added: + ----- Method: SystemChangeFileTest>>testClassRemoved (in category 'testing') ----- + testClassRemoved + | aClass aClassName | + aClassName := self genericClassName. + self + prepare: [ + aClass := self createClass: aClassName. + ] + change: [ + aClass removeFromSystem. + ] + verify: [ + self deny: (Smalltalk keys includes: aClassName). + ]. + ! Item was added: + ----- Method: SystemChangeFileTest>>testClassRenamed (in category 'testing') ----- + testClassRenamed + | aClass aNewClassName anOldClassName | + anOldClassName := self genericClassName. + aNewClassName := self genericClassName. + self + prepare: [ + aClass := self createClass: anOldClassName. + ] + change: [ + aClass rename: aNewClassName. + ] + verify: [ + self assert: (Smalltalk keys includes: aNewClassName). + self deny: (Smalltalk keys includes: anOldClassName). + ].! Item was added: + ----- Method: SystemChangeFileTest>>testClassReorganized (in category 'as yet unclassified') ----- + testClassReorganized! Item was added: + ----- Method: SystemChangeFileTest>>testExpressionDoIt (in category 'testing') ----- + testExpressionDoIt + | aClassName | + aClassName := self genericClassName.. + self + prepare: [ + self createClass: aClassName. + ] + change: [ + Compiler evaluate: '(Smalltalk at: ', aClassName storeString, ') removeFromSystem'. + ] + verify: [ + self deny: (Smalltalk keys includes: aClassName). + ].! Item was added: + ----- Method: SystemChangeFileTest>>testMethodAdded (in category 'testing') ----- + testMethodAdded + | aClassName aClass aSelector | + aClassName := self genericClassName. + self + prepare: [ + aClass := self createClass: aClassName. + ] + change: [ + aSelector := self genericSelector. + aClass compile: aSelector. + ] + verify: [ + self assert: (aClass methodDict keys includes: aSelector). + ] + + ! Item was added: + ----- Method: SystemChangeFileTest>>testMethodModified (in category 'testing') ----- + testMethodModified + | aClassName aClass aSelector aMethodSource | + aClassName := self genericClassName. + aSelector := self genericSelector. + self + prepare: [ + aClass := self createClass: aClassName. + aClass compile: aSelector, ' ', self randomString storeString. + ] + change: [ + aMethodSource := aSelector, ' ', self randomString storeString. + aClass compile: aMethodSource. + ] + verify: [ + self assert: (aClass sourceCodeAt: aSelector) string = aMethodSource. + ] + + ! Item was added: + ----- Method: SystemChangeFileTest>>testMethodRecategorized (in category 'testing') ----- + testMethodRecategorized + | aClassName aClass aNewProtocol aSelector anOldProtocol | + aClassName := self genericClassName. + aSelector := self genericSelector. + anOldProtocol := self genericProtocol. + self + prepare: [ + aClass := self createClass: aClassName. + aClass compile: aSelector classified: anOldProtocol. + ] + change: [ + aNewProtocol := self genericProtocol. + aClass organization classify: aSelector under: aNewProtocol. + ] + verify: [ + self assert: (aClass organization categoryOfElement: aSelector) = aNewProtocol + ] + + ! Item was added: + ----- Method: SystemChangeFileTest>>testMethodRemoved (in category 'testing') ----- + testMethodRemoved + | aClassName aClass aSelector | + aClassName := self genericClassName. + aSelector := self genericSelector. + self + prepare: [ + aClass := self createClass: aClassName. + aClass compile: aSelector. + ] + change: [ + aClass removeSelector: aSelector. + ] + verify: [ + self deny: (aClass methodDict keys includes: aSelector). + ] + + ! Item was added: + ----- Method: SystemChangeFileTest>>testProtocolAdded (in category 'testing') ----- + testProtocolAdded + | aClassName aClass aProtocol | + aClassName := self genericClassName. + aProtocol := self genericProtocol. + self + prepare: [ + aClass := self createClass: aClassName. + ] + change: [ + aClass organization addCategory: aProtocol. + ] + verify: [ + self assert: (aClass organization categories includes: aProtocol) + ] + + ! Item was added: + ----- Method: SystemChangeFileTest>>testProtocolDefault (in category 'testing') ----- + testProtocolDefault + | aClassName aClass aSelector | + aClassName := self genericClassName. + self + prepare: [ + aClass := self createClass: aClassName. + ] + change: [ + aSelector := self genericSelector. + aClass compile: aSelector. + ] + verify: [ + self assert: (aClass organization categoryOfElement: aSelector) = aClass organization class default. + ] + + ! Item was added: + ----- Method: SystemChangeFileTest>>testProtocolModified (in category 'as yet unclassified') ----- + testProtocolModified! Item was added: + ----- Method: SystemChangeFileTest>>testProtocolRemoved (in category 'testing') ----- + testProtocolRemoved + | aClassName aClass aProtocol | + aClassName := self genericClassName. + aProtocol := self genericProtocol. + self + prepare: [ + aClass := self createClass: aClassName. + aClass organization addCategory: aProtocol. + ] + change: [ + aClass organization removeCategory: aProtocol. + ] + verify: [ + self deny: (aClass organization categories includes: aProtocol) + ] + + ! Item was added: + ----- Method: SystemChangeFileTest>>testProtocolRenamed (in category 'testing') ----- + testProtocolRenamed + | aClassName aClass anOldProtocol aNewProtocol | + aClassName := self genericClassName. + anOldProtocol := self genericProtocol. + self + prepare: [ + aClass := self createClass: aClassName. + aClass organization addCategory: anOldProtocol. + ] + change: [ + aNewProtocol := self genericProtocol. + aClass organization renameCategory: anOldProtocol toBe: aNewProtocol. + ] + verify: [ + self deny: (aClass organization categories includes: anOldProtocol). + self assert: (aClass organization categories includes: aNewProtocol). + ] + + ! Item was added: + ----- Method: SystemChangeFileTest>>useStandardChangesFile (in category 'private') ----- + useStandardChangesFile + Smalltalk + closeSourceFiles; + openSourceFiles! Item was added: + ----- Method: SystemChangeFileTest>>useTemporaryChangesFile (in category 'private') ----- + useTemporaryChangesFile + Smalltalk closeSourceFiles. + tempChangesFile := self directory forceNewFileNamed: self tempChangesName. + SourceFiles at: 2 put: tempChangesFile!

1 0

Daily Commit Log
by commits＠source.squeak.org 03 Nov '11

03 Nov '11

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2011-November/005056.h… Name: Kernel-nice.647 Ancestors: Kernel-nice.646 Optimize #ln and #log as in Pharo. 1) SmallInteger just inherits from super (^self asFloat log) 2) LargePositiveInteger can avoid self > à guard 3) LargeNegativeInteger can goto Error (no raise, just kidding) 4) Fraction can avoid arithmetic because (a/b) log = (a log - b log) and because a log or b log are unlikely to overflow - (10 raisedTo: (10 raisedTo: 308)) is likely to exhaust your memory before any overflow occurs ;). ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-November/005057.h… Name: KernelTests-nice.209 Ancestors: KernelTests-nice.208 Restore the intention of testNaN2 which is to test both = and == (there can be several instances of NaN) Complete the ScaledDecimalTest (from Pharo) and correct intention (test absolute value of difference). ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-November/005058.h… Name: Kernel-eem.648 Ancestors: Kernel-nice.647 First part of changes to restore protection against infinite recursion on printing circular array literals. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-November/005059.h… Name: Collections-eem.464 Ancestors: Collections-ul.463 Second part of changes to restore protection against infinite recursion on printing circular array literals. Add a visited set to Array>shouldBePrintedAsLiteral => shouldBePrintedAsLiteralVisiting:. =============================================

1 0

The Trunk: Collections-eem.464.mcz
by commits＠source.squeak.org 02 Nov '11

02 Nov '11

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.464.mcz ==================== Summary ==================== Name: Collections-eem.464 Author: eem Time: 2 November 2011, 1:08:39.649 pm UUID: 0984ea11-ef0f-40e0-9de1-aea54055ef85 Ancestors: Collections-ul.463 Second part of changes to restore protection against infinite recursion on printing circular array literals. Add a visited set to Array>shouldBePrintedAsLiteral => shouldBePrintedAsLiteralVisiting:. =============== Diff against Collections-ul.463 =============== Item was changed: ----- Method: Array>>shouldBePrintedAsLiteral (in category 'testing') ----- shouldBePrintedAsLiteral + ^self class == Array + and: [self shouldBePrintedAsLiteralVisiting: (IdentitySet new: 8)]! - ^self class == Array and: [ self allSatisfy: [ :each | each shouldBePrintedAsLiteral ] ]! Item was added: + ----- Method: Array>>shouldBePrintedAsLiteralVisiting: (in category 'testing') ----- + shouldBePrintedAsLiteralVisiting: aSet + self class == Array ifFalse: + [^false]. + (aSet includes: self) ifTrue: + [^false]. + aSet add: self. + ^self allSatisfy: [:each | each shouldBePrintedAsLiteralVisiting: aSet]! Item was added: + ----- Method: Character>>shouldBePrintedAsLiteralVisiting: (in category 'testing') ----- + shouldBePrintedAsLiteralVisiting: aSet + + ^self shouldBePrintedAsLiteral!

1 0

The Trunk: Kernel-eem.648.mcz
by commits＠source.squeak.org 02 Nov '11

02 Nov '11

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.648.mcz ==================== Summary ==================== Name: Kernel-eem.648 Author: eem Time: 2 November 2011, 12:58:59.757 pm UUID: c3ee000c-6816-4eff-9f24-4ddc497c4171 Ancestors: Kernel-nice.647 First part of changes to restore protection against infinite recursion on printing circular array literals. =============== Diff against Kernel-nice.647 =============== Item was added: + ----- Method: Object>>shouldBePrintedAsLiteralVisiting: (in category 'testing') ----- + shouldBePrintedAsLiteralVisiting: aSet + + ^self isLiteral!

1 0

The Trunk: KernelTests-nice.209.mcz
by commits＠source.squeak.org 02 Nov '11

02 Nov '11

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.209.mcz ==================== Summary ==================== Name: KernelTests-nice.209 Author: nice Time: 2 November 2011, 8:12:16.968 pm UUID: 91e9e8ee-ff2b-4cce-8df3-ff2d1ade58ea Ancestors: KernelTests-nice.208 Restore the intention of testNaN2 which is to test both = and == (there can be several instances of NaN) Complete the ScaledDecimalTest (from Pharo) and correct intention (test absolute value of difference). =============== Diff against KernelTests-nice.208 =============== Item was changed: ----- Method: FloatTest>>testNaN2 (in category 'NaN behavior') ----- testNaN2 "Two NaN values are always considered to be different. On an little-endian machine (32 bit Intel), Float nan is 16rFFF80000 16r00000000. On a big-endian machine (PowerPC), Float nan is 16r7FF80000 16r00000000. Changing the bit pattern of the first word of a NaN produces another value that is still considered equal to NaN. This test should work on both little endian and big endian machines. However, it is not guaranteed to work on future 64 bit versions of Squeak, for which Float may have different internal representations." "FloatTest new testNaN2" | nan1 nan2 | nan1 := Float nan copy. nan2 := Float nan copy. "test two instances of NaN with the same bit pattern" self deny: nan1 = nan2. + self deny: nan1 == nan2. - self deny: nan1 = nan2. self deny: nan1 = nan1. self assert: nan1 == nan1. "change the bit pattern of nan1" self assert: nan1 size = 2. self assert: (nan1 at: 2) = 0. nan1 at: 1 put: (nan1 at: 1) + 999. self assert: nan1 isNaN. self assert: nan2 isNaN. self deny: (nan1 at: 1) = (nan2 at: 1). "test two instances of NaN with different bit patterns" self deny: nan1 = nan2. + self deny: nan1 == nan2. - self deny: nan1 = nan2. self deny: nan1 = nan1. self assert: nan1 == nan1 ! Item was changed: ----- Method: ScaledDecimalTest>>testConvertFromFloat (in category 'tests') ----- testConvertFromFloat | aFloat sd f2 diff | aFloat := 11/13 asFloat. sd := aFloat asScaledDecimal: 2. self assert: 2 = sd scale. self assert: '0.84s2' = sd printString. + self assert: '-0.84s2' = sd negated printString. f2 := sd asFloat. diff := f2 - aFloat. + self assert: diff abs < 1.0e-9. "actually, f = f2, but this is not a requirement" - self assert: diff < 1.0e-9. "actually, f = f2, but this is not a requirement" ! Item was changed: ----- Method: ScaledDecimalTest>>testConvertFromFractionWithScale (in category 'tests') ----- testConvertFromFractionWithScale | sd | sd := (13 / 11) asScaledDecimal: 6. self assert: ScaledDecimal == sd class. self assert: ('1.181818s6' = sd printString). + self assert: 6 = sd scale. + sd := (-13 / 11) asScaledDecimal: 6. + self assert: ScaledDecimal == sd class. + self assert: ('-1.181818s6' = sd printString). self assert: 6 = sd scale !

1 0

The Trunk: Kernel-nice.647.mcz
by commits＠source.squeak.org 02 Nov '11

02 Nov '11

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.647.mcz ==================== Summary ==================== Name: Kernel-nice.647 Author: nice Time: 2 November 2011, 7:50:14.247 pm UUID: 68374059-00c3-4605-bfb3-615f3793071a Ancestors: Kernel-nice.646 Optimize #ln and #log as in Pharo. 1) SmallInteger just inherits from super (^self asFloat log) 2) LargePositiveInteger can avoid self > à guard 3) LargeNegativeInteger can goto Error (no raise, just kidding) 4) Fraction can avoid arithmetic because (a/b) log = (a log - b log) and because a log or b log are unlikely to overflow - (10 raisedTo: (10 raisedTo: 308)) is likely to exhaust your memory before any overflow occurs ;). =============== Diff against Kernel-nice.646 =============== Item was changed: ----- Method: Fraction>>ln (in category 'mathematical functions') ----- ln + "This function is defined because super ln might overflow." + | res | - "This function is defined because super ln might overflow. - Note that < 1 is tested before converting to float in order to avoid precision loss due to gradual underflow." - | res int | self <= 0 ifTrue: [DomainError signal: 'ln is only defined for x > 0']. + "Test self < 1 before converting to float in order to avoid precision loss due to gradual underflow." + numerator < denominator ifTrue: [^self reciprocal ln negated]. - self < 1 ifTrue: [^self reciprocal ln negated]. res := super ln. res isFinite ifTrue: [^res]. + ^numerator ln - denominator ln! - int := self integerPart. - ^int ln + (self / int) ln! Item was changed: ----- Method: Fraction>>log (in category 'mathematical functions') ----- log + "This function is defined because super log might overflow." + | res | - "This function is defined because super log might overflow. - Note that < 1 is tested before converting to float in order to avoid precision loss due to gradual underflow." - | res int | self <= 0 ifTrue: [DomainError signal: 'log is only defined for x > 0']. + "Test self < 1 before converting to float in order to avoid precision loss due to gradual underflow." + numerator < denominator ifTrue: [^self reciprocal log negated]. - self < 1 ifTrue: [^self reciprocal log negated]. res := super log. res isFinite ifTrue: [^res]. + ^numerator log - denominator log! - int := self integerPart. - ^int log + (self / int) log! Item was removed: - ----- Method: Integer>>ln (in category 'mathematical functions') ----- - ln - "This function is defined because super ln might overflow." - | res h | - self <= 0 ifTrue: [DomainError signal: 'ln is only defined for x > 0']. - res := super ln. - res isFinite ifTrue: [^res]. - h := self highBit. - ^2 ln * h + (self / (1 << h)) asFloat ln! Item was removed: - ----- Method: Integer>>log (in category 'mathematical functions') ----- - log - "This function is defined because super log might overflow." - | res h | - self <= 0 ifTrue: [DomainError signal: 'log is only defined for x > 0']. - res := super log. - res isFinite ifTrue: [^res]. - h := self highBit. - ^2 log * h + (self / (1 << h)) asFloat log! Item was added: + ----- Method: LargeNegativeInteger>>ln (in category 'mathematical functions') ----- + ln + ^DomainError signal: 'ln is only defined for x > 0' from: 0! Item was added: + ----- Method: LargeNegativeInteger>>log (in category 'mathematical functions') ----- + log + ^DomainError signal: 'log is only defined for x > 0' from: 0! Item was added: + ----- Method: LargePositiveInteger>>ln (in category 'mathematical functions') ----- + ln + "This function is defined because super ln might overflow." + | res h | + res := super ln. + res isFinite ifTrue: [^res]. + h := self highBit. + ^2 ln * h + (self / (1 << h)) asFloat ln! Item was added: + ----- Method: LargePositiveInteger>>log (in category 'mathematical functions') ----- + log + "This function is defined because super log might overflow." + | res h | + res := super log. + res isFinite ifTrue: [^res]. + h := self highBit. + ^2 log * h + (self / (1 << h)) asFloat log!

1 0

Squeak Oversight Board minutes – 11/01/11 redux
by Chris Cunnington 02 Nov '11

02 Nov '11

Hmmm, those links seemed to have fused to the preceding "at". Here the are again. Squeak Map server alpha image: http://www.16r.ca/SMView.zip SqueakCore image: http://ftp.squeak.org/4.3alpha

1 0

Jump to page: