Squeak-dev June 2010

squeak-dev@lists.squeakfoundation.org

96 participants
269 discussions

Cog VM crash upon loading Connectors
by Stéphane Rollandin 30 Jun '10

30 Jun '10

Hello, Trying to load muO in a 4.1 image with Cog, I got a crash while loading the Connectors package. Crash dump attached... Stef

2 4

Re: [squeak-dev] The Trunk: Monticello-eem.396.mcz
by Nicolas Cellier 30 Jun '10

30 Jun '10

Great! I also have a similar fileOutAllMessages for StringHolder. (unpublished because StringHolder stinks, and because a recent change make it auto select 1 item) Nicolas 2010/6/30 <commits(a)source.squeak.org>: > Eliot Miranda uploaded a new version of Monticello to project The Trunk: > http://source.squeak.org/trunk/Monticello-eem.396.mcz > > ==================== Summary ==================== > > Name: Monticello-eem.396 > Author: eem > Time: 29 June 2010, 6:30:15.515 pm > UUID: 4bfae8e6-8254-4d67-8f17-5317a3cf4cb0 > Ancestors: Monticello-ar.395 > > Make sure MCWorkingCopy receives system change > notifications by reregistering for them on startup. > > File-out-all for PatchBrowser (package changes). > > =============== Diff against Monticello-ar.395 =============== > > Item was changed: > ----- Method: MCWorkingCopy class>>initialize (in category 'as yet unclassified') ----- > initialize > Smalltalk > at: #MczInstaller > ifPresent: [:installer | self adoptVersionInfoFrom: installer]. > self updateInstVars. > "Temporary conversion code -- remove later" > registry ifNotNil:[registry rehash]. "changed #=" > self allInstancesDo:[:each| "moved notifications" > Smalltalk at: #SystemChangeNotifier ifPresent:[:cls| > cls uniqueInstance noMoreNotificationsFor: each. > ]. > ]. > + self registerForNotifications. > + Smalltalk addToStartUpList: self! > - self registerForNotifications.! > > Item was added: > + ----- Method: MCPackageManager class>>reregisterForNotificationsWith: (in category 'system changes') ----- > + reregisterForNotificationsWith: aSystemChangeNotifier > + aSystemChangeNotifier > + notify: self ofSystemChangesOfItem: #class change: #Added using: #classModified:; > + notify: self ofSystemChangesOfItem: #class change: #Modified using: #classModified:; > + notify: self ofSystemChangesOfItem: #class change: #Renamed using: #classModified:; > + notify: self ofSystemChangesOfItem: #class change: #Commented using: #classModified:; > + notify: self ofSystemChangesOfItem: #class change: #Recategorized using: #classMoved:; > + notify: self ofSystemChangesOfItem: #class change: #Removed using: #classRemoved:; > + notify: self ofSystemChangesOfItem: #method change: #Added using: #methodModified:; > + notify: self ofSystemChangesOfItem: #method change: #Modified using: #methodModified:; > + notify: self ofSystemChangesOfItem: #method change: #Recategorized using: #methodMoved:; > + notify: self ofSystemChangesOfItem: #method change: #Removed using: #methodRemoved:! > > Item was changed: > ----- Method: MCCodeTool>>methodListMenu: (in category 'menus') ----- > methodListMenu: aMenu > "Build the menu for the selected method, if any." > > + self selectedMessageName > + ifNil: [items notEmpty ifTrue: > + [aMenu addList:#(('fileOut (o)' fileOutMessage))]] > + ifNotNil: [ > - self selectedMessageName ifNotNil: [ > aMenu addList:#( > ('browse full (b)' browseMethodFull) > ('browse hierarchy (h)' classHierarchy) > ('browse method (O)' openSingleMessageBrowser) > ('browse protocol (p)' browseFullProtocol) > - > ('fileOut (o)' fileOutMessage) > ('printOut' printOutMessage) > ('copy selector (c)' copySelector)). > aMenu addList: #( > - > ('browse senders (n)' browseSendersOfMessages) > ('browse implementors (m)' browseMessages) > ('inheritance (i)' methodHierarchy) > ('versions (v)' browseVersions) > ('change sets with this method' findMethodInChangeSets) > " ('x revert to previous version' revertToPreviousVersion)" > ('remove from current change set' removeFromCurrentChanges) > " ('x revert & remove from changes' revertAndForget)" > ('add to current change set' adoptMessageInCurrentChangeset) > " ('x copy up or copy down...' copyUpOrCopyDown)" > " ('x remove method (x)' removeMessage)" > "-" > ). > ]. > " aMenu addList: #( > ('x inst var refs...' browseInstVarRefs) > ('x inst var defs...' browseInstVarDefs) > ('x class var refs...' browseClassVarRefs) > ('x class variables' browseClassVariables) > ('x class refs (N)' browseClassRefs) > ). > " > ^ aMenu > ! > > Item was changed: > ----- Method: MCPackageManager class>>registerForNotifications (in category 'system changes') ----- > registerForNotifications > + Smalltalk > + at: #SystemChangeNotifier > + ifPresent: > + [:cls| > + cls uniqueInstance noMoreNotificationsFor: self. > + self reregisterForNotificationsWith: cls uniqueInstance]! > - Smalltalk at: #SystemChangeNotifier ifPresent:[:cls| > - (cls uniqueInstance) > - noMoreNotificationsFor: self; > - notify: self ofSystemChangesOfItem: #class change: #Added using: #classModified:; > - notify: self ofSystemChangesOfItem: #class change: #Modified using: #classModified:; > - notify: self ofSystemChangesOfItem: #class change: #Renamed using: #classModified:; > - notify: self ofSystemChangesOfItem: #class change: #Commented using: #classModified:; > - notify: self ofSystemChangesOfItem: #class change: #Recategorized using: #classMoved:; > - notify: self ofSystemChangesOfItem: #class change: #Removed using: #classRemoved:; > - notify: self ofSystemChangesOfItem: #method change: #Added using: #methodModified:; > - notify: self ofSystemChangesOfItem: #method change: #Modified using: #methodModified:; > - notify: self ofSystemChangesOfItem: #method change: #Recategorized using: #methodMoved:; > - notify: self ofSystemChangesOfItem: #method change: #Removed using: #methodRemoved: > - ].! > > Item was added: > + ----- Method: MCWorkingCopy class>>startUp: (in category 'system startup') ----- > + startUp: resuming > + "Ensure Monticello is receiving system change notifications." > + > + resuming ifTrue: > + [Smalltalk > + at: #SystemChangeNotifier > + ifPresent: [:scn| self reregisterForNotificationsWith: scn uniqueInstance]] > + ! > > Item was changed: > ----- Method: MCCodeTool>>fileOutMessage (in category 'menus') ----- > fileOutMessage > "Put a description of the selected message on a file" > > + | fileName | > self selectedMessageName ifNotNil: > [Cursor write showWhile: > + [self selectedClassOrMetaClass fileOutMethod: self selectedMessageName]. > + ^self]. > + items isEmpty ifTrue: > + [^self]. > + fileName := UIManager default request: 'File out on which file?' initialAnswer: 'methods'. > + Cursor write showWhile: > + [| internalStream | > + internalStream := WriteStream on: (String new: 1000). > + internalStream header; timeStamp. > + items do: > + [:patchOp| > + patchOp definition isMethodDefinition ifTrue: > + [(patchOp definition actualClass notNil > + and: [patchOp definition actualClass includesSelector: patchOp definition selector]) > + ifTrue: > + [patchOp definition actualClass > + printMethodChunk: patchOp definition selector > + withPreamble: true > + on: internalStream > + moveSource: false > + toFile: nil] > + ifFalse: > + [internalStream nextChunkPut: patchOp definition className, ' removeSelector: ', patchOp definition selector printString]]. > + patchOp definition isClassDefinition ifTrue: > + [patchOp definition actualClass > + ifNotNil: > + [internalStream nextChunkPut: patchOp definition actualClass definition. > + patchOp definition comment ifNotNil: > + [patchOp definition actualClass organization > + putCommentOnFile: internalStream > + numbered: 1 > + moveSource: false > + forClass: patchOp definition actualClass]] > + ifNil: > + [internalStream nextChunkPut: patchOp definition className, ' removeFromSystem']]]. > + FileStream writeSourceCodeFrom: internalStream baseName: fileName isSt: true useHtml: false]! > - [self selectedClassOrMetaClass fileOutMethod: self selectedMessageName]]! > > >

1 0

The Trunk: Tools-eem.249.mcz
by commits＠source.squeak.org 30 Jun '10

30 Jun '10

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.249.mcz ==================== Summary ==================== Name: Tools-eem.249 Author: eem Time: 29 June 2010, 6:08:05.192 pm UUID: de379f2a-657e-4776-afa8-cdb1a6a21823 Ancestors: Tools-eem.248 ChangeList improvements - recognize class definitions and reorganization doits and class comments so they can be diffed - include class defs and comments in "remove unchanged definitions" so they are removed as well as unchanged methods, and in select methods for this class - provide a "select changes containing pattern" operation - provide a "select itemps for existig classes" operation - use class's parser class (if it exists) when parsing selectors, defaulting the selector to unparsableSelector if it can't be parsed. =============== Diff against Tools-eem.248 =============== Item was changed: ----- Method: ChangeList>>changeListMenu: (in category 'menu actions') ----- changeListMenu: aMenu "Fill aMenu up so that it comprises the primary changelist-browser menu" aMenu addTitle: 'change list'. aMenu addStayUpItemSpecial. aMenu addList: #( ('fileIn selections' fileInSelections 'import the selected items into the image') ('fileOut selections... ' fileOutSelections 'create a new file containing the selected items') - ('compare to current' compareToCurrentVersion 'open a separate window which shows the text differences between the on-file version and the in-image version.' ) ('toggle diffing (D)' toggleDiffing 'start or stop showing diffs in the code pane.') - ('select conflicts with any changeset' selectAllConflicts 'select methods in the file which also occur in any change-set in the system') ('select conflicts with current changeset' selectConflicts 'select methods in the file which also occur in the current change-set') ('select conflicts with...' selectConflictsWith 'allows you to designate a file or change-set against which to check for code conflicts.') - + ('select unchanged definitions' selectUnchangedDefinitions 'select class definitions, class comments and methods in the file whose in-image versions are the same as their in-file counterparts' ) ('select unchanged methods' selectUnchangedMethods 'select methods in the file whose in-image versions are the same as their in-file counterparts' ) ('select new methods' selectNewMethods 'select methods in the file that do not current occur in the image') ('select methods for this class' selectMethodsForThisClass 'select all methods in the file that belong to the currently-selected class') + ('select methods for extant classes' selectMethodsForExtantClasses 'select all methods in the file that belong to a class that exists in the image') + ('select changes with contents matching' selectContentsMatching 'select all changes in the file whose text includes a pattern') - ('select all (a)' selectAll 'select all the items in the list') ('deselect all' deselectAll 'deselect all the items in the list') ('invert selections' invertSelections 'select every item that is not currently selected, and deselect every item that *is* currently selected') - ('browse all versions of single selection' browseVersions 'open a version browser showing the versions of the currently selected method') ('browse all versions of selections' browseAllVersionsOfSelections 'open a version browser showing all the versions of all the selected methods') ('browse current versions of selections' browseCurrentVersionsOfSelections 'open a message-list browser showing the current (in-image) counterparts of the selected methods') ('destroy current methods of selections' destroyCurrentCodeOfSelections 'remove (*destroy*) the in-image counterparts of all selected methods') - ('remove doIts' removeDoIts 'remove all items that are doIts rather than methods') ('remove older versions' removeOlderMethodVersions 'remove all but the most recent versions of methods in the list') ('remove up-to-date versions' removeExistingMethodVersions 'remove all items whose code is the same as the counterpart in-image code') ('remove selected items' removeSelections 'remove the selected items from the change-list') ('remove unselected items' removeNonSelections 'remove all the items not currently selected from the change-list')). ^ aMenu ! Item was added: + ----- Method: ChangeList>>selectContentsMatching (in category 'menu actions') ----- + selectContentsMatching + | pattern | + pattern := UIManager default request: 'pattern to match'. + pattern isEmpty ifTrue: [^self]. + ^Cursor execute showWhile: + [self selectSuchThat: ((pattern includesAnyOf: '?*') + ifTrue: [[ :change | pattern match: change string]] + ifFalse: [[ :change | change string includesSubString: pattern]])]! Item was changed: ----- Method: ChangeList>>scanCategory (in category 'scanning') ----- scanCategory "Scan anything that involves more than one chunk; method name is historical only" + | itemPosition item tokens stamp anIndex | - | itemPosition item tokens stamp isComment anIndex | itemPosition := file position. item := file nextChunk. + ((item includesSubString: 'commentStamp:') + or: [(item includesSubString: 'methodsFor:') + or: [item endsWith: 'reorganize']]) ifFalse: - isComment := (item includesSubString: 'commentStamp:'). - (isComment or: [item includesSubString: 'methodsFor:']) ifFalse: ["Maybe a preamble, but not one we recognize; bail out with the preamble trick" ^ self addItem: (ChangeRecord new file: file position: itemPosition type: #preamble) text: ('preamble: ' , item contractTo: 50)]. tokens := Scanner new scanTokens: item. tokens size >= 3 ifTrue: [stamp := ''. anIndex := tokens indexOf: #stamp: ifAbsent: [nil]. anIndex ifNotNil: [stamp := tokens at: (anIndex + 1)]. tokens second == #methodsFor: ifTrue: [^ self scanCategory: tokens third class: tokens first meta: false stamp: stamp]. tokens third == #methodsFor: ifTrue: [^ self scanCategory: tokens fourth class: tokens first meta: true stamp: stamp]]. + tokens second == #commentStamp: + ifTrue: + [stamp := tokens third. + self addItem: + (ChangeRecord new file: file position: file position type: #classComment + class: tokens first category: nil meta: false stamp: stamp) + text: 'class comment for ' , tokens first, + (stamp isEmpty ifTrue: [''] ifFalse: ['; ' , stamp]). + file nextChunk. + ^ file skipStyleChunk]. + + self assert: tokens last == #reorganize. + self addItem: + (ChangeRecord new + file: file position: file position type: #reorganize + class: tokens first category: nil meta: false stamp: stamp) + text: 'organization for ' , tokens first, (tokens second == #class ifTrue: [' class'] ifFalse: ['']). + file nextChunk! - tokens second == #commentStamp: - ifTrue: - [stamp := tokens third. - self addItem: - (ChangeRecord new file: file position: file position type: #classComment - class: tokens first category: nil meta: false stamp: stamp) - text: 'class comment for ' , tokens first, - (stamp isEmpty ifTrue: [''] ifFalse: ['; ' , stamp]). - file nextChunk. - ^ file skipStyleChunk]! Item was added: + ----- Method: ChangeList>>selectUnchangedDefinitions (in category 'menu actions') ----- + selectUnchangedDefinitions + "Selects all recognizable definitions for which there is already a definition in the current image, whose source is exactly the same." + | change class tokens | + Cursor read showWhile: + [1 to: changeList size do: + [:i | change := changeList at: i. + listSelections at: i put: false. + + (change type = #method + and: [(class := change methodClass) notNil + and: [class includesSelector: change methodSelector]]) ifTrue: + [listSelections + at: i + put: change string withBlanksCondensed + = (class sourceCodeAt: change methodSelector) asString withBlanksCondensed]. + + (change type == #classComment + and: [(class := change commentClass) notNil]) ifTrue: + [listSelections at: i put: change string = class comment asString]. + + change type == #doIt ifTrue: + [tokens := Scanner new scanTokens: change string. + + ((tokens select: + [:substr| #(subclass: variableByteSubclass: variableWordSubclass: + instanceVariableNames: classVariableNames: ) includes: substr]) + asSet size >= 3 + and: [(class := Smalltalk at: tokens third ifAbsent: []) notNil + and: [class isBehavior]]) ifTrue: + [listSelections + at: i + put: change string withBlanksCondensed + = class definition withBlanksCondensed]. + + (tokens size = 4 + and: [tokens second == #class + and: [tokens third == #instanceVariableNames: + and: [(class := Smalltalk at: tokens first ifAbsent: []) notNil + and: [class isBehavior]]]]) ifTrue: + [listSelections + at: i + put: change string withBlanksCondensed + = class class definition withBlanksCondensed]. + + (tokens size = 3 + and: [tokens second == #removeSelector: + and: [(class := Smalltalk at: tokens first ifAbsent: []) isNil + or: [class isBehavior and: [(class includesSelector: tokens third) not]]]]) ifTrue: + [listSelections at: i put: true]. + + (tokens size = 4 + and: [tokens second == #class + and: [tokens third == #removeSelector: + and: [(class := Smalltalk at: tokens first ifAbsent: []) isNil + or: [class isBehavior and: [(class class includesSelector: tokens fourth) not]]]]]) ifTrue: + [listSelections at: i put: true]]]]. + + self changed: #allSelections! Item was changed: ----- Method: ChangeList>>scanCategory:class:meta:stamp: (in category 'scanning') ----- scanCategory: category class: class meta: meta stamp: stamp + | itemPosition method selector | - | itemPosition method | [itemPosition := file position. method := file nextChunk. file skipStyleChunk. method size > 0] "done when double terminators" whileTrue: [self addItem: (ChangeRecord new file: file position: itemPosition type: #method class: class category: category meta: meta stamp: stamp) text: 'method: ' , class , (meta ifTrue: [' class '] ifFalse: [' ']) + , ((selector := (Smalltalk at: class ifAbsent: [Object]) parserClass new parseSelector: method) isNil + ifTrue: ['unparsableSelector'] + ifFalse: [selector]) - , (self class parserClass new parseSelector: method) , (stamp isEmpty ifTrue: [''] ifFalse: ['; ' , stamp])]! Item was changed: ----- Method: ChangeList>>contentsDiffedFromCurrent (in category 'viewing access') ----- contentsDiffedFromCurrent "Answer the contents diffed forward from current (in-memory) method version" | aChange aClass | listIndex = 0 ifTrue: [^ '']. aChange := changeList at: listIndex. + (aChange type == #method + and: [(aClass := aChange methodClass) notNil + and: [aClass includesSelector: aChange methodSelector]]) ifTrue: + [^Utilities + methodDiffFor: aChange text + class: aClass + selector: aChange methodSelector + prettyDiffs: self showingPrettyDiffs]. + + aChange type == #doIt ifTrue: + [| tokens | + tokens := Scanner new scanTokens: aChange string. + ((tokens select: + [:substr| #(subclass: variableByteSubclass: variableWordSubclass: + instanceVariableNames: classVariableNames: ) includes: substr]) + asSet size >= 3 + and: [(aClass := Smalltalk at: tokens third ifAbsent: []) notNil + and: [aClass isBehavior]]) ifTrue: + [^TextDiffBuilder buildDisplayPatchFrom: aClass definition to: aChange string]. + + (tokens size = 4 + and: [tokens second == #class + and: [tokens third == #instanceVariableNames: + and: [(aClass := Smalltalk at: tokens first ifAbsent: []) notNil + and: [aClass isBehavior]]]]) ifTrue: + [^TextDiffBuilder buildDisplayPatchFrom: aClass class definition to: aChange string]]. + + (aChange type == #classComment + and: [(aClass := aChange commentClass) notNil]) ifTrue: + [^TextDiffBuilder buildDisplayPatchFrom: aClass comment asString to: aChange string]. + + ^(changeList at: listIndex) text! - ^ ((aChange type == #method and: [(aClass := aChange methodClass) notNil]) and: [aClass includesSelector: aChange methodSelector]) - ifTrue: - [Utilities methodDiffFor: aChange text class: aClass selector: aChange methodSelector prettyDiffs: self showingPrettyDiffs] - ifFalse: - [(changeList at: listIndex) text]! Item was added: + ----- Method: ChangeList>>selectMethodsForExtantClasses (in category 'menu actions') ----- + selectMethodsForExtantClasses + ^self selectSuchThat: + [ :change | + Smalltalk hasClassNamed: change methodClassName]!

1 0

The Trunk: Tools-eem.248.mcz
by commits＠source.squeak.org 30 Jun '10

30 Jun '10

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.248.mcz ==================== Summary ==================== Name: Tools-eem.248 Author: eem Time: 29 June 2010, 5:35:42.881 pm UUID: 0b9c21cf-7f57-4db1-82c1-a8edbfb07600 Ancestors: Tools-jcg.247 Make MessageNames accept semicolon-separated patterns, so "at:put*;*remove*" answers all selectors beginning with "at:put" and all including remove. Needs Collections-eem.367. =============== Diff against Tools-jcg.247 =============== Item was changed: ----- Method: MessageNames>>computeSelectorListFromSearchString (in category 'search') ----- computeSelectorListFromSearchString "Compute selector list from search string" + searchString := searchString asString copyWithout: $ . "?dubious?" + selectorList := Cursor wait showWhile: + [| sorted | + sorted := SortedCollection sortBlock: [:x :y | x asLowercase <= y asLowercase]. + (searchString findBetweenSubStrs: ';') do: + [:selPat| | raw n m | + selPat size > 0 ifTrue: + [(selPat first = $" and: [selPat last = $" and: [selPat size > 2]]) + ifTrue: + [Symbol hasInterned: (selPat copyFrom: 2 to: selPat size - 1) ifTrue: [:sym| sorted add: sym]] + ifFalse: + [raw := (((n := selPat occurrencesOf: $*) > 0) + | ((m := selPat occurrencesOf: $#) > 0) + and: [selPat size > (n + m)]) + ifTrue: [Symbol selectorsMatching: selPat] + ifFalse: [Symbol selectorsContaining: selPat]. + sorted addAll: raw]]]. - searchString := searchString asString copyWithout: $ . - selectorList := Cursor wait - showWhile: [ - | raw sorted | - raw := Symbol selectorsContaining: searchString. - sorted := raw as: SortedCollection. - sorted - sortBlock: [:x :y | x asLowercase <= y asLowercase]. sorted asArray]. + ^selectorList! - selectorList size > 19 - ifFalse: ["else the following filtering is considered too expensive. This 19 - should be a system-maintained Parameter, someday" - selectorList := self systemNavigation allSelectorsWithAnyImplementorsIn: selectorList]. - ^ selectorList!

1 0

The Trunk: Monticello-eem.396.mcz
by commits＠source.squeak.org 30 Jun '10

30 Jun '10

Eliot Miranda uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-eem.396.mcz ==================== Summary ==================== Name: Monticello-eem.396 Author: eem Time: 29 June 2010, 6:30:15.515 pm UUID: 4bfae8e6-8254-4d67-8f17-5317a3cf4cb0 Ancestors: Monticello-ar.395 Make sure MCWorkingCopy receives system change notifications by reregistering for them on startup. File-out-all for PatchBrowser (package changes). =============== Diff against Monticello-ar.395 =============== Item was changed: ----- Method: MCWorkingCopy class>>initialize (in category 'as yet unclassified') ----- initialize Smalltalk at: #MczInstaller ifPresent: [:installer | self adoptVersionInfoFrom: installer]. self updateInstVars. "Temporary conversion code -- remove later" registry ifNotNil:[registry rehash]. "changed #=" self allInstancesDo:[:each| "moved notifications" Smalltalk at: #SystemChangeNotifier ifPresent:[:cls| cls uniqueInstance noMoreNotificationsFor: each. ]. ]. + self registerForNotifications. + Smalltalk addToStartUpList: self! - self registerForNotifications.! Item was added: + ----- Method: MCPackageManager class>>reregisterForNotificationsWith: (in category 'system changes') ----- + reregisterForNotificationsWith: aSystemChangeNotifier + aSystemChangeNotifier + notify: self ofSystemChangesOfItem: #class change: #Added using: #classModified:; + notify: self ofSystemChangesOfItem: #class change: #Modified using: #classModified:; + notify: self ofSystemChangesOfItem: #class change: #Renamed using: #classModified:; + notify: self ofSystemChangesOfItem: #class change: #Commented using: #classModified:; + notify: self ofSystemChangesOfItem: #class change: #Recategorized using: #classMoved:; + notify: self ofSystemChangesOfItem: #class change: #Removed using: #classRemoved:; + notify: self ofSystemChangesOfItem: #method change: #Added using: #methodModified:; + notify: self ofSystemChangesOfItem: #method change: #Modified using: #methodModified:; + notify: self ofSystemChangesOfItem: #method change: #Recategorized using: #methodMoved:; + notify: self ofSystemChangesOfItem: #method change: #Removed using: #methodRemoved:! Item was changed: ----- Method: MCCodeTool>>methodListMenu: (in category 'menus') ----- methodListMenu: aMenu "Build the menu for the selected method, if any." + self selectedMessageName + ifNil: [items notEmpty ifTrue: + [aMenu addList:#(('fileOut (o)' fileOutMessage))]] + ifNotNil: [ - self selectedMessageName ifNotNil: [ aMenu addList:#( ('browse full (b)' browseMethodFull) ('browse hierarchy (h)' classHierarchy) ('browse method (O)' openSingleMessageBrowser) ('browse protocol (p)' browseFullProtocol) - ('fileOut (o)' fileOutMessage) ('printOut' printOutMessage) ('copy selector (c)' copySelector)). aMenu addList: #( - ('browse senders (n)' browseSendersOfMessages) ('browse implementors (m)' browseMessages) ('inheritance (i)' methodHierarchy) ('versions (v)' browseVersions) ('change sets with this method' findMethodInChangeSets) " ('x revert to previous version' revertToPreviousVersion)" ('remove from current change set' removeFromCurrentChanges) " ('x revert & remove from changes' revertAndForget)" ('add to current change set' adoptMessageInCurrentChangeset) " ('x copy up or copy down...' copyUpOrCopyDown)" " ('x remove method (x)' removeMessage)" "-" ). ]. " aMenu addList: #( ('x inst var refs...' browseInstVarRefs) ('x inst var defs...' browseInstVarDefs) ('x class var refs...' browseClassVarRefs) ('x class variables' browseClassVariables) ('x class refs (N)' browseClassRefs) ). " ^ aMenu ! Item was changed: ----- Method: MCPackageManager class>>registerForNotifications (in category 'system changes') ----- registerForNotifications + Smalltalk + at: #SystemChangeNotifier + ifPresent: + [:cls| + cls uniqueInstance noMoreNotificationsFor: self. + self reregisterForNotificationsWith: cls uniqueInstance]! - Smalltalk at: #SystemChangeNotifier ifPresent:[:cls| - (cls uniqueInstance) - noMoreNotificationsFor: self; - notify: self ofSystemChangesOfItem: #class change: #Added using: #classModified:; - notify: self ofSystemChangesOfItem: #class change: #Modified using: #classModified:; - notify: self ofSystemChangesOfItem: #class change: #Renamed using: #classModified:; - notify: self ofSystemChangesOfItem: #class change: #Commented using: #classModified:; - notify: self ofSystemChangesOfItem: #class change: #Recategorized using: #classMoved:; - notify: self ofSystemChangesOfItem: #class change: #Removed using: #classRemoved:; - notify: self ofSystemChangesOfItem: #method change: #Added using: #methodModified:; - notify: self ofSystemChangesOfItem: #method change: #Modified using: #methodModified:; - notify: self ofSystemChangesOfItem: #method change: #Recategorized using: #methodMoved:; - notify: self ofSystemChangesOfItem: #method change: #Removed using: #methodRemoved: - ].! Item was added: + ----- Method: MCWorkingCopy class>>startUp: (in category 'system startup') ----- + startUp: resuming + "Ensure Monticello is receiving system change notifications." + + resuming ifTrue: + [Smalltalk + at: #SystemChangeNotifier + ifPresent: [:scn| self reregisterForNotificationsWith: scn uniqueInstance]] + ! Item was changed: ----- Method: MCCodeTool>>fileOutMessage (in category 'menus') ----- fileOutMessage "Put a description of the selected message on a file" + | fileName | self selectedMessageName ifNotNil: [Cursor write showWhile: + [self selectedClassOrMetaClass fileOutMethod: self selectedMessageName]. + ^self]. + items isEmpty ifTrue: + [^self]. + fileName := UIManager default request: 'File out on which file?' initialAnswer: 'methods'. + Cursor write showWhile: + [| internalStream | + internalStream := WriteStream on: (String new: 1000). + internalStream header; timeStamp. + items do: + [:patchOp| + patchOp definition isMethodDefinition ifTrue: + [(patchOp definition actualClass notNil + and: [patchOp definition actualClass includesSelector: patchOp definition selector]) + ifTrue: + [patchOp definition actualClass + printMethodChunk: patchOp definition selector + withPreamble: true + on: internalStream + moveSource: false + toFile: nil] + ifFalse: + [internalStream nextChunkPut: patchOp definition className, ' removeSelector: ', patchOp definition selector printString]]. + patchOp definition isClassDefinition ifTrue: + [patchOp definition actualClass + ifNotNil: + [internalStream nextChunkPut: patchOp definition actualClass definition. + patchOp definition comment ifNotNil: + [patchOp definition actualClass organization + putCommentOnFile: internalStream + numbered: 1 + moveSource: false + forClass: patchOp definition actualClass]] + ifNil: + [internalStream nextChunkPut: patchOp definition className, ' removeFromSystem']]]. + FileStream writeSourceCodeFrom: internalStream baseName: fileName isSt: true useHtml: false]! - [self selectedClassOrMetaClass fileOutMethod: self selectedMessageName]]!

1 0

The Trunk: Collections-eem.367.mcz
by commits＠source.squeak.org 30 Jun '10

30 Jun '10

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.367.mcz ==================== Summary ==================== Name: Collections-eem.367 Author: eem Time: 29 June 2010, 5:33:09.841 pm UUID: f8a9fe6b-b224-4a6b-96ed-04c03a98222d Ancestors: Collections-eem.366 Fix bug in Symbol class>>selectorsContaining: which won''t find selectors containing digits. Add Symbol class>>selectorsMatching:. Both the above used in improved MessageNames =============== Diff against Collections-eem.366 =============== Item was changed: ----- Method: Symbol class>>selectorsContaining: (in category 'access') ----- selectorsContaining: aString "Answer a list of selectors that contain aString within them. Case-insensitive. Does return symbols that begin with a capital letter." | size selectorList ascii | selectorList := OrderedCollection new. (size := aString size) = 0 ifTrue: [^selectorList]. aString size = 1 ifTrue: [ ascii := aString first asciiValue. ascii < 128 ifTrue: [selectorList add: (OneCharacterSymbols at: ascii+1)] ]. + (aString first isLetter or: [aString first isDigit]) ifFalse: - aString first isLetter ifFalse: [ aString size == 2 ifTrue: [Symbol hasInterned: aString ifTrue: [:s | selectorList add: s]]. ^selectorList ]. selectorList := selectorList copyFrom: 2 to: selectorList size. self allSymbolTablesDo: [:each | each size >= size ifTrue: + [(each findSubstring: aString in: each startingAt: 1 + matchTable: CaseInsensitiveOrder) > 0 - [(each findString: aString startingAt: 1 caseSensitive: false) > 0 ifTrue: [selectorList add: each]]]. ^selectorList reject: [:each | "reject non-selectors, but keep ones that begin with an uppercase" each numArgs < 0 and: [each asString withFirstCharacterDownshifted numArgs < 0]]. "Symbol selectorsContaining: 'scon'"! Item was added: + ----- Method: Symbol class>>selectorsMatching: (in category 'access') ----- + selectorsMatching: aStringPattern + "Answer a list of selectors that match aStringPattern within them. Case-insensitive. + Does return symbols that begin with a capital letter." + + | selectorList | + + selectorList := OrderedCollection new. + + aStringPattern isEmpty ifTrue: [^selectorList]. + + self allSymbolTablesDo: + [:each | (aStringPattern match: each) ifTrue: [selectorList add: each]]. + + ^selectorList reject: "reject non-selectors, but keep ones that begin with an uppercase" + [:each | each numArgs < 0 and: [each asString withFirstCharacterDownshifted numArgs < 0]] + + "Symbol selectorsMatching: 'parse:*'"!

1 0

The Trunk: Collections-eem.366.mcz
by commits＠source.squeak.org 30 Jun '10

30 Jun '10

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.366.mcz ==================== Summary ==================== Name: Collections-eem.366 Author: eem Time: 29 June 2010, 5:26:30.834 pm UUID: b8b3d29c-7d22-45a6-a235-aae3dd6316ea Ancestors: Collections-ul.365 Much faster Dictionary>>unreferencedKeys (single pass over class hierarchy) speeds up removeUnreferencedKeys. =============== Diff against Collections-ul.365 =============== Item was changed: ----- Method: Dictionary>>unreferencedKeys (in category 'removing') ----- unreferencedKeys + "| uk | (Time millisecondsToRun: [uk := TextConstants unreferencedKeys]) -> uk" - "TextConstants unreferencedKeys" ^'Scanning for references . . .' displayProgressAt: Sensor cursorPoint from: 0 + to: Smalltalk classNames size * 2 - to: self size during: + [:bar | | currentClass n associations referencedAssociations | + currentClass := nil. - [:bar | - | n | n := 0. + associations := self associations asIdentitySet. + referencedAssociations := IdentitySet new: associations size. + self systemNavigation allSelect: + [:m| + m methodClass ~~ currentClass ifTrue: + [currentClass := m methodClass. + bar value: (n := n + 1)]. + m literalsDo: + [:l| + (l isVariableBinding and: [associations includes: l]) ifTrue: + [referencedAssociations add: l]]. + false]. + ((associations reject: [:assoc | referencedAssociations includes: assoc]) collect: [:assoc| assoc key]) asSet]! - self keys select: - [:key | - bar value: (n := n + 1). - (self systemNavigation allCallsOn: (self associationAt: key)) isEmpty]]!

1 0

The Trunk: Monticello-eem.396.mcz
by commits＠source.squeak.org 30 Jun '10

30 Jun '10

1 0

Re: [squeak-dev] The Trunk: System-eem.345.mcz
by Nicolas Cellier 30 Jun '10

30 Jun '10

Great! How did people ever worked with change lists without this ? There might be interesting related features to pick in Cuis too. Nicolas 2010/6/30 <commits(a)source.squeak.org>: > Eliot Miranda uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-eem.345.mcz > > ==================== Summary ==================== > > Name: System-eem.345 > Author: eem > Time: 29 June 2010, 5:48:20.596 pm > UUID: 1ba583d2-9788-4bfd-b1d5-9b88c7769cd2 > Ancestors: System-tbn.344 > > Changes to ChangeRecord to support remove unchanged > definitions and file-in reorganizations in the ChangeList. > > =============== Diff against System-tbn.344 =============== > > Item was added: > + ----- Method: ChangeRecord>>commentClass (in category 'access') ----- > + commentClass > + | commentClass | > + type == #classComment ifFalse: [^ nil]. > + (Smalltalk includesKey: class asSymbol) ifFalse: [^ nil]. > + commentClass := Smalltalk at: class asSymbol. > + ^meta ifTrue: [commentClass class] > + ifFalse: [commentClass]! > > Item was changed: > ----- Method: ChangeRecord>>methodClassName (in category 'access') ----- > methodClassName > + | text tokens | > + (class isNil > + and: [type = #doIt > + and: [((text := self text) includes: $.) not "exclude multi-statement doits" > + and: [(tokens := Scanner new scanTokens: text) size >= 4 > + and: [tokens first isSymbol > + and: [tokens first isKeyword not > + and: [tokens first first canBeGlobalVarInitial > + and: [tokens includes: #instanceVariableNames:]]]]]]]) ifTrue: > + ["Could be a class definition. > + Class definitions start with Superclass blahSubclass: #ClassName > + Metaclass definitions start with ClassName class instanceVariableNames:" > + (tokens second isSymbol > + and: [tokens second isKeyword > + and: [tokens third isSymbol > + and: [tokens third isKeyword not > + and: [(2 to: tokens size by: 2) allSatisfy: [:i| (tokens at: i) isKeyword]]]]]) ifTrue: > + [^tokens third]. > + (tokens size = 4 > + and: [tokens second = #class > + and: [tokens third = #instanceVariableNames: > + and: [tokens last isString]]]) ifTrue: > + [^tokens first]]. > ^class! > > Item was changed: > ----- Method: ChangeRecord>>fileIn (in category 'initialization') ----- > fileIn > + "File the receiver in. If I represent a method or a class-comment, file the method in and make a note of it in the recent-submissions list; if I represent a do-it, then, well, do it; if I represent a reorganization then get organized!!" > - "File the receiver in. If I represent a method or a class-comment, file the method in and make a note of it in the recent-submissions list; if I represent a do-it, then, well, do it." > > Cursor read showWhile: > + [| s cls aSelector | > + type == #doIt > + ifTrue: > + [((s := self string) beginsWith: '----') ifFalse: [Compiler evaluate: s]] > + ifFalse: > + [cls := Smalltalk at: class asSymbol. > + cls := meta ifTrue: [cls class] ifFalse: [cls]. > + type == #method ifTrue: > + [cls compile: self text classified: category withStamp: stamp notifying: nil. > + (aSelector := self methodSelector) ifNotNil: > + [Utilities noteMethodSubmission: aSelector forClass: cls]]. > + type == #classComment ifTrue: > + [cls comment: self text stamp: stamp. > + Utilities noteMethodSubmission: #Comment forClass: cls ]. > + type == #reorganize ifTrue: > + [cls organization changeFromString: self text]]]! > - [| methodClass s aSelector | > - (methodClass := self methodClass) notNil ifTrue: > - [methodClass compile: self text classified: category withStamp: stamp notifying: nil. > - (aSelector := self methodSelector) ifNotNil: > - [Utilities noteMethodSubmission: aSelector forClass: methodClass]]. > - (type == #doIt) ifTrue: > - [((s := self string) beginsWith: '----') ifFalse: [Compiler evaluate: s]]. > - (type == #classComment) ifTrue: > - [ | cls | (cls := Smalltalk at: class asSymbol) comment: self text stamp: stamp. > - Utilities noteMethodSubmission: #Comment forClass: cls ]]! > > Item was changed: > ----- Method: ChangeRecord>>fileIndex (in category 'access') ----- > fileIndex > + SourceFiles withIndexDo: [:sf :i| sf name = file name ifTrue: [^i]]. > + ^nil! > - ^ (SourceFiles collect: [ :sf | sf name]) > - indexOf: file name ifAbsent: [^ nil]. > - ! > > >

1 0

The Trunk: System-eem.345.mcz
by commits＠source.squeak.org 30 Jun '10

30 Jun '10

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.345.mcz ==================== Summary ==================== Name: System-eem.345 Author: eem Time: 29 June 2010, 5:48:20.596 pm UUID: 1ba583d2-9788-4bfd-b1d5-9b88c7769cd2 Ancestors: System-tbn.344 Changes to ChangeRecord to support remove unchanged definitions and file-in reorganizations in the ChangeList. =============== Diff against System-tbn.344 =============== Item was added: + ----- Method: ChangeRecord>>commentClass (in category 'access') ----- + commentClass + | commentClass | + type == #classComment ifFalse: [^ nil]. + (Smalltalk includesKey: class asSymbol) ifFalse: [^ nil]. + commentClass := Smalltalk at: class asSymbol. + ^meta ifTrue: [commentClass class] + ifFalse: [commentClass]! Item was changed: ----- Method: ChangeRecord>>methodClassName (in category 'access') ----- methodClassName + | text tokens | + (class isNil + and: [type = #doIt + and: [((text := self text) includes: $.) not "exclude multi-statement doits" + and: [(tokens := Scanner new scanTokens: text) size >= 4 + and: [tokens first isSymbol + and: [tokens first isKeyword not + and: [tokens first first canBeGlobalVarInitial + and: [tokens includes: #instanceVariableNames:]]]]]]]) ifTrue: + ["Could be a class definition. + Class definitions start with Superclass blahSubclass: #ClassName + Metaclass definitions start with ClassName class instanceVariableNames:" + (tokens second isSymbol + and: [tokens second isKeyword + and: [tokens third isSymbol + and: [tokens third isKeyword not + and: [(2 to: tokens size by: 2) allSatisfy: [:i| (tokens at: i) isKeyword]]]]]) ifTrue: + [^tokens third]. + (tokens size = 4 + and: [tokens second = #class + and: [tokens third = #instanceVariableNames: + and: [tokens last isString]]]) ifTrue: + [^tokens first]]. ^class! Item was changed: ----- Method: ChangeRecord>>fileIn (in category 'initialization') ----- fileIn + "File the receiver in. If I represent a method or a class-comment, file the method in and make a note of it in the recent-submissions list; if I represent a do-it, then, well, do it; if I represent a reorganization then get organized!!" - "File the receiver in. If I represent a method or a class-comment, file the method in and make a note of it in the recent-submissions list; if I represent a do-it, then, well, do it." Cursor read showWhile: + [| s cls aSelector | + type == #doIt + ifTrue: + [((s := self string) beginsWith: '----') ifFalse: [Compiler evaluate: s]] + ifFalse: + [cls := Smalltalk at: class asSymbol. + cls := meta ifTrue: [cls class] ifFalse: [cls]. + type == #method ifTrue: + [cls compile: self text classified: category withStamp: stamp notifying: nil. + (aSelector := self methodSelector) ifNotNil: + [Utilities noteMethodSubmission: aSelector forClass: cls]]. + type == #classComment ifTrue: + [cls comment: self text stamp: stamp. + Utilities noteMethodSubmission: #Comment forClass: cls ]. + type == #reorganize ifTrue: + [cls organization changeFromString: self text]]]! - [| methodClass s aSelector | - (methodClass := self methodClass) notNil ifTrue: - [methodClass compile: self text classified: category withStamp: stamp notifying: nil. - (aSelector := self methodSelector) ifNotNil: - [Utilities noteMethodSubmission: aSelector forClass: methodClass]]. - (type == #doIt) ifTrue: - [((s := self string) beginsWith: '----') ifFalse: [Compiler evaluate: s]]. - (type == #classComment) ifTrue: - [ | cls | (cls := Smalltalk at: class asSymbol) comment: self text stamp: stamp. - Utilities noteMethodSubmission: #Comment forClass: cls ]]! Item was changed: ----- Method: ChangeRecord>>fileIndex (in category 'access') ----- fileIndex + SourceFiles withIndexDo: [:sf :i| sf name = file name ifTrue: [^i]]. + ^nil! - ^ (SourceFiles collect: [ :sf | sf name]) - indexOf: file name ifAbsent: [^ nil]. - !

1 0

← Newer
1
2
3
4
5
6
7
...
27
Older →

Jump to page: