Squeak-dev October 2009

squeak-dev@lists.squeakfoundation.org

84 participants
353 discussions

Daily Commit Log
by commits＠source.squeak.org 31 Oct '09

31 Oct '09

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2009-October/001693.ht… Name: GraphicsTests-dtl.15 Ancestors: GraphicsTests-ar.14 Add six new tests to BitBltTest provided by Juan Vuletich, reference Mantis 7407. These tests will fail until the necessary fixes have been applied to BitBltPlugin in the VM. Two existing tests in BitBltTest (#testAlphaCompositingSimulated and #testAlphaCompositing2Simulated) should be moved to the VMMaker package as per Juan's recommendation, but are left here until the VMaker changes have been made (follow-up required). ============================================= http://lists.squeakfoundation.org/pipermail/packages/2009-October/001694.ht… Name: CollectionsTests-nice.105 Ancestors: CollectionsTests-ar.104 Test #isSelfEvaluating a bit deeper ============================================= http://lists.squeakfoundation.org/pipermail/packages/2009-October/001695.ht… Name: Collections-nice.173 Ancestors: Collections-ar.172 Correct some #isSelfEvaluating implementations that were a bit relax. Anyway, the implementation is still weak: Try ((0 at 1 extent: 1 at 1) -> 0) isSelfEvaluating Then try to evaluate ((0 at 1 extent: 1 at 1) -> 0) printString ============================================= http://lists.squeakfoundation.org/pipermail/packages/2009-October/001696.ht… Name: Kernel-nice.282 Ancestors: Kernel-nice.281 Just a comment about #isSelfEvaluating ============================================= http://lists.squeakfoundation.org/pipermail/packages/2009-October/001697.ht… Name: GraphicsTests-nice.16 Ancestors: GraphicsTests-dtl.15 Some basic tests of the color wheel using #h:s:v: (By the way, I wonder how other Smalltalk model hue, isn't it a fraction of revolution between 0 and 1 ?) ============================================= http://lists.squeakfoundation.org/pipermail/packages/2009-October/001698.ht… Name: Graphics-nice.85 Ancestors: Graphics-jdr.84 Make h:s:v: work in case of negative angle ============================================= http://lists.squeakfoundation.org/pipermail/packages/2009-October/001699.ht… Name: KernelTests-nice.104 Ancestors: KernelTests-nice.103 Test #arcTan: behavior especially near zero and negativeZero ============================================= http://lists.squeakfoundation.org/pipermail/packages/2009-October/001700.ht… Name: Kernel-nice.283 Ancestors: Kernel-nice.282 Make #arcTan: behave as libm atan2 near zero and negativeZero ============================================= http://lists.squeakfoundation.org/pipermail/packages/2009-October/001701.ht… Name: Collections-nice.174 Ancestors: Collections-nice.173 A bit of cleanup before printing every Array with a Brace notation (unless they are literal of course) ============================================= http://lists.squeakfoundation.org/pipermail/packages/2009-October/001702.ht… Name: Traits-nice.241 Ancestors: Traits-ar.240 remove #arraySize from FixedIdentitySet (a Trait private class) It was unsent. It was sole implementor. It was a synonym for #capacity, so useless anyway It was invoking super with a different selector, which is possible but questionable. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2009-October/001703.ht… Name: Collections-nice.175 Ancestors: Collections-nice.174 Implement Eliot suggestion to always print Array with a brace format (unless they are literal). Thus I renamed #printAsSelfEvaluatingFormOn: -> #printAsBraceFormOn: If community agree on this one, then more cleanup and removal will follow =============================================

1 0

source.squeak.org deadly slow BIS
by Nicolas Cellier 31 Oct '09

31 Oct '09

I noticed very loooooong unresponsive periods when I commit a Kernel change. (That can be around half an hour). I don't know what is the cause, but it ends up when the diff is commited to squeak-dev... Maybe it would be worth tracing what goes on...

1 0

Server Outages
by Ken Causey 31 Oct '09

31 Oct '09

As I'm sure most of you have noticed we have had continued problems with the community server seemingly in a repeat of the events of last year. To make a long story short the latest is that the power supply has been replaced and we are currently holding our breath waiting to see if it remains up longer than a day or two. Ken

1 0

The Trunk: Collections-nice.175.mcz
by commits＠source.squeak.org 31 Oct '09

31 Oct '09

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.175.mcz ==================== Summary ==================== Name: Collections-nice.175 Author: nice Time: 31 October 2009, 12:01:10 pm UUID: b57c4abc-b35c-430d-a8f1-28a4956dd753 Ancestors: Collections-nice.174 Implement Eliot suggestion to always print Array with a brace format (unless they are literal). Thus I renamed #printAsSelfEvaluatingFormOn: -> #printAsBraceFormOn: If community agree on this one, then more cleanup and removal will follow =============== Diff against Collections-nice.174 =============== Item was added: + ----- Method: Array>>printAsBraceFormOn: (in category 'self evaluating') ----- + printAsBraceFormOn: aStream + + aStream nextPut: ${. + self do: [:el | aStream print: el] separatedBy: [ aStream nextPutAll: ' . ']. + aStream nextPut: $}! Item was changed: ----- Method: Array>>printOn: (in category 'printing') ----- printOn: aStream + self isLiteral ifTrue: [^self printAsLiteralFormOn: aStream]. + self class = Array ifTrue: [^self printAsBraceFormOn: aStream]. + ^super printOn: aStream! - self isLiteral ifTrue: [self printAsLiteralFormOn: aStream. ^ self]. - self isSelfEvaluating ifTrue: [self printAsSelfEvaluatingFormOn: aStream. ^ self]. - - super printOn: aStream! Item was removed: - ----- Method: Array>>printAsSelfEvaluatingFormOn: (in category 'self evaluating') ----- - printAsSelfEvaluatingFormOn: aStream - - aStream nextPut: ${. - self do: [:el | aStream print: el] separatedBy: [ aStream nextPutAll: ' . ']. - aStream nextPut: $}!

1 0

The Trunk: Traits-nice.241.mcz
by commits＠source.squeak.org 30 Oct '09

30 Oct '09

Nicolas Cellier uploaded a new version of Traits to project The Trunk: http://source.squeak.org/trunk/Traits-nice.241.mcz ==================== Summary ==================== Name: Traits-nice.241 Author: nice Time: 30 October 2009, 11:44:57 am UUID: f3040a5d-7396-46d0-ad3a-8246236df7b2 Ancestors: Traits-ar.240 remove #arraySize from FixedIdentitySet (a Trait private class) It was unsent. It was sole implementor. It was a synonym for #capacity, so useless anyway It was invoking super with a different selector, which is possible but questionable. =============== Diff against Traits-ar.240 =============== Item was removed: - ----- Method: FixedIdentitySet>>arraySize (in category 'private') ----- - arraySize - ^ super size!

1 0

The Trunk: Collections-nice.174.mcz
by commits＠source.squeak.org 30 Oct '09

30 Oct '09

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.174.mcz ==================== Summary ==================== Name: Collections-nice.174 Author: nice Time: 30 October 2009, 11:37:32 am UUID: 56b3b0ea-6199-4d3b-9961-89a635d5ed50 Ancestors: Collections-nice.173 A bit of cleanup before printing every Array with a Brace notation (unless they are literal of course) =============== Diff against Collections-nice.173 =============== Item was changed: ----- Method: WeakRegistry>>printElementsOn: (in category 'printing') ----- printElementsOn: aStream + accessLock ifNil: [^super printElementsOn: aStream]. + aStream nextPutAll: '(<this WeakRegistry is locked>)'! - aStream nextPut: $(. - accessLock - ifNil: [self do: [:element | aStream print: element; space]] - ifNotNil: [aStream nextPutAll: '<this WeakRegistry is locked>; space']. - self isEmpty ifFalse: [aStream skip: -1]. - aStream nextPut: $)! Item was removed: - ----- Method: WeakSet>>printElementsOn: (in category 'public') ----- - printElementsOn: aStream - | oldPos | - aStream nextPut: $(. - oldPos := aStream position. - self do: [:element | aStream print: element; space]. - aStream position > oldPos ifTrue: [aStream skip: -1 "remove the extra space"]. - aStream nextPut: $)!

1 0

The Trunk: Kernel-nice.283.mcz
by commits＠source.squeak.org 30 Oct '09

30 Oct '09

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.283.mcz ==================== Summary ==================== Name: Kernel-nice.283 Author: nice Time: 30 October 2009, 10:32:03 am UUID: 5180827b-8f52-4516-af31-271e133a385a Ancestors: Kernel-nice.282 Make #arcTan: behave as libm atan2 near zero and negativeZero =============== Diff against Kernel-nice.282 =============== Item was changed: ----- Method: Float>>arcTan: (in category 'mathematical functions') ----- arcTan: denominator "Answer the angle in radians. + Optional. See Object documentation whatIsAPrimitive. + Implementation note: use sign in order to catch cases of negativeZero" - Optional. See Object documentation whatIsAPrimitive." - - | result | + ^self = 0.0 + ifTrue: [denominator sign >= 0 + ifTrue: [ 0 ] + ifFalse: [ self sign >= 0 + ifTrue: [ Pi ] + ifFalse: [ Pi negated ]]] + ifFalse: [denominator = 0.0 + ifTrue: [self > 0.0 + ifTrue: [ Halfpi ] + ifFalse: [ Halfpi negated ]] + ifFalse: [denominator > 0 + ifTrue: [ (self / denominator) arcTan ] + ifFalse: [self > 0 + ifTrue: [ ((self / denominator) arcTan) + Pi ] + ifFalse: [ ((self / denominator) arcTan) - Pi ]]]]! - (self = 0.0) ifTrue: [ (denominator > 0.0) ifTrue: [ result := 0 ] - ifFalse: [ result := Pi ] - ] - ifFalse: [(denominator = 0.0) - ifTrue: [ (self > 0.0) ifTrue: [ result := Halfpi ] - ifFalse: [ result := Halfpi negated ] - ] - ifFalse: [ (denominator > 0) ifTrue: [ result := (self / denominator) arcTan ] - ifFalse: [ (self > 0) ifTrue: [result := ((self / denominator) arcTan) + Pi ] - ifFalse: [result := ((self / denominator) arcTan) - Pi] - ] - ]. - ]. - - ^ result.!

1 0

The Trunk: KernelTests-nice.104.mcz
by commits＠source.squeak.org 30 Oct '09

30 Oct '09

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.104.mcz ==================== Summary ==================== Name: KernelTests-nice.104 Author: nice Time: 30 October 2009, 10:30:16 am UUID: b00c25ae-448f-45af-ab6b-2cc5f303632a Ancestors: KernelTests-nice.103 Test #arcTan: behavior especially near zero and negativeZero =============== Diff against KernelTests-nice.103 =============== Item was added: + ----- Method: FloatTest>>testArcTan (in category 'testing') ----- + testArcTan + + self assert: ((100 arcTan: 100) closeTo: Float pi / 4). + self assert: ((-100 arcTan: 100) closeTo: Float pi / -4). + self assert: ((100 arcTan: -100) closeTo: Float pi * 3 / 4). + self assert: ((-100 arcTan: -100) closeTo: Float pi * -3 / 4). + self assert: ((0 arcTan: 100) closeTo: 0). + self assert: ((0 arcTan: -100) closeTo: Float pi). + self assert: ((100 arcTan: 0) closeTo: Float pi / 2). + self assert: ((-100 arcTan: 0) closeTo: Float pi / -2). + + self assert: ((Float negativeZero arcTan: 100) closeTo: 0). + self assert: ((Float negativeZero arcTan: -100) closeTo: Float pi * -1). + + self assert: (0 arcTan: 0) = 0. + self assert: (Float negativeZero arcTan: 0) = 0. + self assert: ((0 arcTan: Float negativeZero) closeTo: Float pi). + self assert: ((Float negativeZero arcTan: Float negativeZero) closeTo: Float pi negated). !

1 0

The Trunk: Graphics-nice.85.mcz
by commits＠source.squeak.org 30 Oct '09

30 Oct '09

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.85.mcz ==================== Summary ==================== Name: Graphics-nice.85 Author: nice Time: 30 October 2009, 9:31:17 am UUID: c4be00d5-d749-4a62-96a8-cc23d6e50d8e Ancestors: Graphics-jdr.84 Make h:s:v: work in case of negative angle =============== Diff against Graphics-jdr.84 =============== Item was changed: ----- Method: Color>>setHue:saturation:brightness: (in category 'private') ----- setHue: hue saturation: saturation brightness: brightness "Initialize this color to the given hue, saturation, and brightness. See the comment in the instance creation method for details." | s v hf i f p q t | s := (saturation asFloat max: 0.0) min: 1.0. v := (brightness asFloat max: 0.0) min: 1.0. "zero saturation yields gray with the given brightness" s = 0.0 ifTrue: [ ^ self setRed: v green: v blue: v ]. hf := hue asFloat. (hf < 0.0 or: [hf >= 360.0]) + ifTrue: [hf := hf \\ 360]. - ifTrue: [hf := hf - ((hf quo: 360.0) asFloat * 360.0)]. hf := hf / 60.0. i := hf asInteger. "integer part of hue" f := hf fractionPart. "fractional part of hue" p := (1.0 - s) * v. q := (1.0 - (s * f)) * v. t := (1.0 - (s * (1.0 - f))) * v. 0 = i ifTrue: [ ^ self setRed: v green: t blue: p ]. 1 = i ifTrue: [ ^ self setRed: q green: v blue: p ]. 2 = i ifTrue: [ ^ self setRed: p green: v blue: t ]. 3 = i ifTrue: [ ^ self setRed: p green: q blue: v ]. 4 = i ifTrue: [ ^ self setRed: t green: p blue: v ]. 5 = i ifTrue: [ ^ self setRed: v green: p blue: q ]. self error: 'implementation error'. !

1 0

The Trunk: GraphicsTests-nice.16.mcz
by commits＠source.squeak.org 30 Oct '09

30 Oct '09

Nicolas Cellier uploaded a new version of GraphicsTests to project The Trunk: http://source.squeak.org/trunk/GraphicsTests-nice.16.mcz ==================== Summary ==================== Name: GraphicsTests-nice.16 Author: nice Time: 30 October 2009, 9:29:04 am UUID: 19b70fc6-fe1d-4aa1-a494-098d4801f5e6 Ancestors: GraphicsTests-dtl.15 Some basic tests of the color wheel using #h:s:v: (By the way, I wonder how other Smalltalk model hue, isn't it a fraction of revolution between 0 and 1 ?) =============== Diff against GraphicsTests-dtl.15 =============== Item was added: + ----- Method: ColorTest>>testHSV (in category 'testing') ----- + testHSV + "Test the color wheel modulo 360" + + self assert: (Color h: 0 s: 1 v: 1) = Color red. + self assert: (Color h: 60 s: 1 v: 1) = Color yellow. + self assert: (Color h: 120 s: 1 v: 1) = Color green. + self assert: (Color h: 180 s: 1 v: 1) = Color cyan. + self assert: (Color h: 240 s: 1 v: 1) = Color blue. + self assert: (Color h: 300 s: 1 v: 1) = Color magenta. + self assert: (Color h: 0+360 s: 1 v: 1) = Color red. + self assert: (Color h: 120+720 s: 1 v: 1) = Color green. + self assert: (Color h: 180-360 s: 1 v: 1) = Color cyan. + self assert: (Color h: 240-720 s: 1 v: 1) = Color blue.!

1 0

← Newer
1
2
3
4
5
6
7
8
...
36
Older →

Jump to page: