Squeak-dev October 2009

squeak-dev@lists.squeakfoundation.org

84 participants
353 discussions

O2PackageBrowser help
by alesch 31 Oct '09

31 Oct '09

Hello List: At ESUG'09, the paper "Tackling Software Navigation Issues of the Smalltalk" was presented. There, they describe some ehancements that I'd like to try but I don't know how to. 1) AutumLeaves (point 7 in the paper) 2) Opening multiple methods (3.2 in the paper) 3) Dependecies and References (5.1 in the paper) Thanks in advance! -- View this message in context: http://n4.nabble.com/O2PackageBrowser-help-tp350543p350543.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

2 1

The Trunk: Collections-nice.177.mcz
by commits＠source.squeak.org 31 Oct '09

31 Oct '09

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.177.mcz ==================== Summary ==================== Name: Collections-nice.177 Author: nice Time: 31 October 2009, 5:41:03 am UUID: 5444f379-2664-46a1-9db9-7c74edf779fe Ancestors: Collections-ar.176 Patch to make literal Array store Float exactly =============== Diff against Collections-ar.176 =============== Item was changed: ----- Method: Array>>storeOn: (in category 'printing') ----- storeOn: aStream "Use the literal form if possible." self isLiteral ifTrue: [aStream nextPut: $#; nextPut: $(. self do: [:element | + element storeOn: aStream. - element printOn: aStream. aStream space]. aStream nextPut: $)] ifFalse: [super storeOn: aStream]!

1 0

The Trunk: Kernel-nice.285.mcz
by commits＠source.squeak.org 31 Oct '09

31 Oct '09

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.285.mcz ==================== Summary ==================== Name: Kernel-nice.285 Author: nice Time: 31 October 2009, 5:21:55 am UUID: a71e2eb9-aade-4ec1-8c30-77e6c9eaf9c8 Ancestors: Kernel-ar.284 store a Float exactly so it can be interpreted back unchanged - according to my solution proposed at http://bugs.squeak.org/view.php?id=1631 Note that SqNumberParser SHOULD be used for interpreting the Number exactly. Previous Number>>readFrom: accumulate roundoff errors =============== Diff against Kernel-ar.284 =============== Item was changed: ----- Method: Float>>storeOn:base: (in category 'printing') ----- + storeOn: aStream base: base + "Print the Number exactly so it can be interpreted back unchanged" + self isFinite + ifTrue: [self > 0 + ifTrue: [self absPrintExactlyOn: aStream base: base] + ifFalse: [self sign = -1 + ifTrue: [aStream nextPutAll: '-']. + self = 0.0 + ifTrue: [aStream nextPutAll: '0.0'] + ifFalse: [self negated absPrintExactlyOn: aStream base: base]]] + ifFalse: [self isNaN + ifTrue: [aStream nextPutAll: 'Float nan'] + ifFalse: [self > 0.0 + ifTrue: [aStream nextPutAll: 'Float infinity'] + ifFalse: [aStream nextPutAll: 'Float infinity negated']]]! - storeOn: aStream base: base - "Defined here to handle special cases of NaN Infinity and negative zero" - - | abs | - self isNaN ifTrue: [aStream nextPutAll: 'NaN'. ^ self]. "check for NaN before sign" - abs := self sign = -1 "Test sign rather than > 0 for special case of negative zero" - ifTrue: - [aStream nextPutAll: '-'. - self negated] - ifFalse: [self]. - abs isInfinite ifTrue: [aStream nextPutAll: 'Infinity'. ^ self]. - aStream print: base; nextPut: $r. - self = 0.0 - ifTrue: [aStream nextPutAll: '0.0'. ^ self] - ifFalse: [abs absPrintOn: aStream base: base]! Item was added: + ----- Method: Float>>storeOn: (in category 'printing') ----- + storeOn: aStream + "Print the Number exactly so it can be interpreted back unchanged" + + self storeOn: aStream base: 10!

1 0

isSelfEvaluating (was: Re: The Trunk: Collections-nice.173.mcz)
by Andreas Raab 31 Oct '09

31 Oct '09

Question: I've always wondered what this "isSelfEvaluating" stuff is good for. There are thirteen implementors and a single user in Array>>printOn:. Is there any *need* for Array>>printOn: to print a "self evaluating" expression? Why not just Array(element1, element2, ....) just like any other collection? We'd remove some 20 methods with no downside that I am aware of. Cheers, - Andreas

6 18

The Trunk: Monticello-nice.330.mcz
by commits＠source.squeak.org 31 Oct '09

31 Oct '09

Nicolas Cellier uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-nice.330.mcz ==================== Summary ==================== Name: Monticello-nice.330 Author: nice Time: 31 October 2009, 1:55:51 am UUID: ff29814c-6499-4bf1-acaf-f54d31ab3582 Ancestors: Monticello-nice.329 Add a protection in order to be able to evaluate (MCDefinition classPool at: #Instances) inspect. While at it, changed some and: [] and: [] into and: [ and: []] I do not see what the former brings but downspeed. =============== Diff against Monticello-nice.329 =============== Item was changed: ----- Method: MCClassTraitDefinition>>= (in category 'accessing') ----- = aDefinition ^ (super = aDefinition) + and: [baseTrait = aDefinition baseTrait + and: [self classTraitCompositionString = aDefinition classTraitCompositionString]] - and: [baseTrait = aDefinition baseTrait] - and: [self classTraitCompositionString = aDefinition classTraitCompositionString] ! Item was changed: ----- Method: MCDefinition>>= (in category 'comparing') ----- = aDefinition + ^(aDefinition isKindOf: MCDefinition) and: [self isRevisionOf: aDefinition]! - ^ self isRevisionOf: aDefinition! Item was changed: ----- Method: MCClassDefinition>>= (in category 'visiting') ----- = aDefinition + ^(super = aDefinition) + and: [superclassName = aDefinition superclassName + and: [self traitCompositionString = aDefinition traitCompositionString + and: [self classTraitCompositionString = aDefinition classTraitCompositionString + and: [category = aDefinition category + and: [type = aDefinition type + and: [self sortedVariables = aDefinition sortedVariables + and: [comment = aDefinition comment]]]]]]]! - ^((super = aDefinition) - and: [superclassName = aDefinition superclassName] - and: [self traitCompositionString = aDefinition traitCompositionString] - and: [self classTraitCompositionString = aDefinition classTraitCompositionString]) - and: [category = aDefinition category] - and: [type = aDefinition type] - and: [self sortedVariables = aDefinition sortedVariables] - and: [comment = aDefinition comment] - ! Item was changed: ----- Method: MCTraitDefinition>>= (in category 'visiting') ----- = aDefinition self flag: #traits. "Ugly we harcoded the super superclass method. We will have to refactor the definition hierarchy" + ^ (aDefinition isKindOf: MCDefinition) + and: [(self isRevisionOf: aDefinition) + and: [self traitCompositionString = aDefinition traitCompositionString + and: [category = aDefinition category + and: [comment = aDefinition comment]]]]! - ^ (self isRevisionOf: aDefinition) - and: [self traitCompositionString = aDefinition traitCompositionString] - and: [category = aDefinition category] - and: [comment = aDefinition comment]! Item was changed: ----- Method: MCMethodDefinition>>= (in category 'comparing') ----- = aDefinition ^(super = aDefinition) + and: [aDefinition source = self source + and: [aDefinition category = self category + and: [aDefinition timeStamp = self timeStamp]]]! - and: [aDefinition source = self source] - and: [aDefinition category = self category] - and: [aDefinition timeStamp = self timeStamp]!

1 0

The Trunk: Kernel-ar.284.mcz
by commits＠source.squeak.org 31 Oct '09

31 Oct '09

Andreas Raab uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ar.284.mcz ==================== Summary ==================== Name: Kernel-ar.284 Author: ar Time: 30 October 2009, 11:22:18 am UUID: f00d24a4-e752-9c4a-b7cc-6a5052f49b9b Ancestors: Kernel-nice.283, Kernel-ul.283 Merging Kernel-ul.283: Updated MethodDictionary - added MethodDictionary class >> #rehashAllInstances which rehashes all instances and changes the identities in one shot. Much faster than single #become: sends. - removed - #add: - same implementation in superclass - #at:putNoBecome:, #fullCheckNoBecome, #growNoBecome, #removeKeyNoBecome: - old methods with no senders (not even in 3.8 full), no comment stating their usefulness - modified several methods which have cleaner code and/or better performance assuming the following invariant: (self basicAt: index) isNil = (array at: index) isNil - added a line about the invariant to the class comment =============== Diff against Kernel-nice.283 =============== Item was changed: ----- Method: MethodDictionary class>>new (in category 'instance creation') ----- new "change the default size to be a bit bigger to help reduce the number of #grows while filing in" + ^self new: 16! Item was changed: ----- Method: MethodDictionary>>keyAtIdentityValue:ifAbsent: (in category 'accessing') ----- keyAtIdentityValue: value ifAbsent: exceptionBlock "Answer the key whose value equals the argument, value. If there is none, answer the result of evaluating exceptionBlock." + + value ifNotNil: [ + 1 to: self basicSize do: [ :index | + (array at: index) == value ifTrue: [ + ^self basicAt: index ] ] ]. + ^exceptionBlock value! - | theKey | - 1 to: self basicSize do: - [:index | - value == (array at: index) - ifTrue: - [(theKey := self basicAt: index) == nil - ifFalse: [^ theKey]]]. - ^ exceptionBlock value! Item was changed: ----- Method: MethodDictionary>>removeKey:ifAbsent: (in category 'removing') ----- removeKey: key ifAbsent: errorBlock "The interpreter might be using this MethodDict while this method is running!! Therefore we perform the removal in a copy, and then atomically become that copy" + | copy | copy := self copy. copy removeDangerouslyKey: key ifAbsent: [^ errorBlock value]. self become: copy! Item was changed: ----- Method: MethodDictionary>>methodArray (in category 'private') ----- methodArray + + ^array! - ^ array! Item was changed: ----- Method: MethodDictionary>>at:put: (in category 'accessing') ----- at: key put: value "Set the value at key to be value." + | index | index := self scanFor: key. + (self basicAt: index) + ifNil: [ + tally := tally + 1. + self basicAt: index put: key ] + ifNotNil: [ (array at: index) flushCache ]. - (self basicAt: index) == nil - ifTrue: - [tally := tally + 1. - self basicAt: index put: key] - ifFalse: - [(array at: index) flushCache]. array at: index put: value. self fullCheck. + ^value! - ^ value! Item was changed: ----- Method: MethodDictionary>>removeDangerouslyKey:ifAbsent: (in category 'private') ----- removeDangerouslyKey: key ifAbsent: aBlock "This is not really dangerous. But if normal removal were done WHILE a MethodDict were being used, the system might crash. So instead we make a copy, then do this operation (which is NOT dangerous in a copy that is not being used), and then use the copy after the removal." | index element | index := self scanFor: key. + (element := array at: index) ifNil: [ ^aBlock value ]. - (self basicAt: index) == nil ifTrue: [ ^ aBlock value ]. - element := array at: index. array at: index put: nil. self basicAt: index put: nil. tally := tally - 1. self fixCollisionsFrom: index. + ^element! - ^ element! Item was changed: Dictionary variableSubclass: #MethodDictionary instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Kernel-Methods'! + !MethodDictionary commentStamp: 'ul 10/30/2009 04:43' prior: 0! - !MethodDictionary commentStamp: '<historical>' prior: 0! I am just like a normal Dictionary, except that I am implemented differently. Each Class has an instances of MethodDictionary to hold the correspondence between selectors (names of methods) and methods themselves. + - In a normal Dictionary, the instance variable 'array' holds an array of Associations. Since there are thousands of methods in the system, these Associations waste space. + Each MethodDictionary is a variable object, with the list of keys (selector Symbols) in the variable part of the instance. The variable 'array' holds the values, which are CompiledMethods. + + I also maintain the following invariant: (self basicAt: index) isNil = (array at: index) isNil.! - Each MethodDictionary is a variable object, with the list of keys (selector Symbols) in the variable part of the instance. The variable 'array' holds the values, which are CompiledMethods.! Item was changed: ----- Method: MethodDictionary>>keysDo: (in category 'enumeration') ----- + keysDo: aBlock + + tally = 0 ifTrue: [ ^self ]. + 1 to: self basicSize do: [ :i | + | key | + (key := self basicAt: i) ifNotNil: [ + aBlock value: key ] ]! - keysDo: aBlock - | key | - tally = 0 ifTrue: [^ self]. - 1 to: self basicSize do: - [:i | (key := self basicAt: i) == nil - ifFalse: [aBlock value: key]]! Item was changed: ----- Method: MethodDictionary>>swap:with: (in category 'private') ----- swap: oneIndex with: otherIndex + | element | element := self basicAt: oneIndex. self basicAt: oneIndex put: (self basicAt: otherIndex). self basicAt: otherIndex put: element. + super swap: oneIndex with: otherIndex - super swap: oneIndex with: otherIndex. ! Item was changed: ----- Method: MethodDictionary>>rehashWithoutBecome (in category 'private') ----- rehashWithoutBecome + + | newSelf | - | newSelf key | newSelf := self species new: self size. + 1 to: self basicSize do: [ :i | + | key | + (key := self basicAt: i) ifNotNil: [ + newSelf at: key put: (array at: i) ] ]. - 1 to: self basicSize do: - [:i | key := self basicAt: i. - key == nil ifFalse: [newSelf at: key put: (array at: i)]]. ^newSelf! Item was changed: ----- Method: MethodDictionary>>keyAtValue:ifAbsent: (in category 'accessing') ----- keyAtValue: value ifAbsent: exceptionBlock "Answer the key whose value equals the argument, value. If there is none, answer the result of evaluating exceptionBlock." + + value ifNotNil: [ + 1 to: self basicSize do: [ :index | + (array at: index) = value ifTrue: [ + ^self basicAt: index ] ] ]. + ^exceptionBlock value! - | theKey | - 1 to: self basicSize do: - [:index | - value = (array at: index) - ifTrue: - [(theKey := self basicAt: index) == nil - ifFalse: [^ theKey]]]. - ^ exceptionBlock value! Item was changed: ----- Method: MethodDictionary>>keysAndValuesDo: (in category 'enumeration') ----- keysAndValuesDo: aBlock "Enumerate the receiver with all the keys and values passed to the block" + - | key | tally = 0 ifTrue: [^ self]. + 1 to: self basicSize do: [ :i | + | key | + (key := self basicAt: i) ifNotNil: [ + aBlock value: key value: (array at: i) ] ]! - 1 to: self basicSize do: - [:i | (key := self basicAt: i) == nil ifFalse: - [aBlock value: key value: (array at: i)] - ]! Item was changed: ----- Method: MethodDictionary>>grow (in category 'private') ----- + grow + + | newSelf | - grow - | newSelf key | newSelf := self species new: self basicSize. "This will double the size" + 1 to: self basicSize do: [ :i | + | key | + (key := self basicAt: i) ifNotNil: [ + newSelf at: key put: (array at: i) ] ]. - 1 to: self basicSize do: - [:i | key := self basicAt: i. - key == nil ifFalse: [newSelf at: key put: (array at: i)]]. self become: newSelf! Item was added: + ----- Method: MethodDictionary class>>rehashAllInstances (in category 'initialization') ----- + rehashAllInstances + + | instances newInstances | + instances := self allInstances asArray. + newInstances := self allInstances collect: [ :each | each rehashWithoutBecome ]. + instances elementsExchangeIdentityWith: newInstances! Item was changed: ----- Method: MethodDictionary>>valuesDo: (in category 'enumeration') ----- valuesDo: aBlock + + tally = 0 ifTrue: [ ^self ]. + 1 to: self basicSize do: [ :i | + | value | + (value := array at: i) ifNotNil: [ + aBlock value: value ] ]! - | value | - tally = 0 ifTrue: [^ self]. - 1 to: self basicSize do: - [:i | (value := array at: i) == nil - ifFalse: [aBlock value: value]]! Item was changed: ----- Method: MethodDictionary>>keyAt: (in category 'private') ----- keyAt: index + ^self basicAt: index! - ^ self basicAt: index! Item was changed: ----- Method: MethodDictionary>>do: (in category 'enumeration') ----- + do: aBlock + + tally = 0 ifTrue: [ ^self ]. + 1 to: self basicSize do: [ :i | + | value | + (value := array at: i) ifNotNil: [ + aBlock value: value ] ] - do: aBlock - tally = 0 ifTrue: [^ self]. - 1 to: self basicSize do: - [:i | (self basicAt: i) == nil ifFalse: - [aBlock value: (array at: i)]] ! Item was changed: ----- Method: MethodDictionary>>associationsDo: (in category 'enumeration') ----- associationsDo: aBlock + + tally = 0 ifTrue: [ ^self ]. + 1 to: self basicSize do: [ :i | + | key | + (key := self basicAt: i) ifNotNil: [ + aBlock value: (Association key: key value: (array at: i)) ] ]! - | key | - tally = 0 ifTrue: [^ self]. - 1 to: self basicSize do: - [:i | (key := self basicAt: i) == nil ifFalse: - [aBlock value: (Association key: key - value: (array at: i))]]! Item was changed: ----- Method: MethodDictionary>>at:ifAbsent: (in category 'accessing') ----- at: key ifAbsent: aBlock + ^(array at: (self scanFor: key)) ifNil: [ aBlock value ]! - | index | - index := self scanFor: key. - (self basicAt: index) == nil ifTrue: [ ^ aBlock value ]. - ^ array at: index! Item was changed: ----- Method: MethodDictionary class>>new: (in category 'instance creation') ----- new: nElements "Create a Dictionary large enough to hold nElements without growing. Note that the basic size must be a power of 2. It is VITAL (see grow) that size gets doubled if nElements is a power of 2" + | size | size := 1 bitShift: nElements highBit. + ^(self basicNew: size) initialize: size! - ^ (self basicNew: size) initialize: size! Item was changed: ----- Method: MethodDictionary>>rehash (in category 'private') ----- rehash + + self become: self rehashWithoutBecome! - | newSelf key | - newSelf := self species new: self size. - 1 to: self basicSize do: - [:i | key := self basicAt: i. - key == nil ifFalse: [newSelf at: key put: (array at: i)]]. - self become: newSelf! Item was removed: - ----- Method: MethodDictionary>>add: (in category 'accessing') ----- - add: anAssociation - ^ self at: anAssociation key put: anAssociation value! Item was removed: - ----- Method: MethodDictionary>>removeKeyNoBecome: (in category 'removing') ----- - removeKeyNoBecome: key - - "The interpreter might be using this MethodDict while - this method is running!! Therefore we perform the removal - in a copy, and then return the copy for subsequent installation" - - | copy | - copy := self copy. - copy removeDangerouslyKey: key ifAbsent: [^ self]. - ^copy! Item was removed: - ----- Method: MethodDictionary>>fullCheckNoBecome (in category 'private') ----- - fullCheckNoBecome - - "Keep array at least 1/4 free for decent hash behavior" - array size - tally < (array size // 4 max: 1) - ifTrue: [^self growNoBecome]. - ^self - ! Item was removed: - ----- Method: MethodDictionary>>at:putNoBecome: (in category 'accessing') ----- - at: key putNoBecome: value - - "Set the value at key to be value. Answer the resulting MethodDictionary" - | index | - index := self scanFor: key. - (self basicAt: index) == nil - ifTrue: - [tally := tally + 1. - self basicAt: index put: key] - ifFalse: - [(array at: index) flushCache]. - array at: index put: value. - ^self fullCheckNoBecome! Item was removed: - ----- Method: MethodDictionary>>growNoBecome (in category 'private') ----- - growNoBecome - - | newSelf key | - - newSelf := self species new: self basicSize. "This will double the size" - 1 to: self basicSize do: - [:i | key := self basicAt: i. - key == nil ifFalse: [newSelf at: key put: (array at: i)]]. - ^newSelf!

1 0

The Trunk: Collections-ar.176.mcz
by commits＠source.squeak.org 31 Oct '09

31 Oct '09

Andreas Raab uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ar.176.mcz ==================== Summary ==================== Name: Collections-ar.176 Author: ar Time: 30 October 2009, 11:20:47 am UUID: 99c0fe48-8a57-904d-b39a-67de96d0d748 Ancestors: Collections-nice.175, Collections-ul.175 Merging Name: Collections-ul.175 - reimplemented Set >> #rehashAllSets, it sends the new #rehashAllInstances to self and all subclasses. - deprecated #quickRehashAllSets, because it didn't rehash all subinstances of Set and #rehashAllSets is fast enough with Kernel-ul.283, it also sends #rehashAllSets instead of the old implementation (no senders in trunk). use it with Kernel-ul.283, load order doesn't matter =============== Diff against Collections-nice.175 =============== Item was changed: ----- Method: Set class>>quickRehashAllSets (in category 'initialization') ----- + quickRehashAllSets + + self deprecated: 'Use #rehashAllSets'. + self rehashAllSets! - quickRehashAllSets "Set rehashAllSets" - | insts | - self withAllSubclassesDo: - [:c | - insts := c allInstances. - (insts isEmpty or: [c = MethodDictionary]) ifFalse: - ['Rehashing instances of ' , c name - displayProgressAt: Sensor cursorPoint - from: 1 to: insts size - during: [:bar | 1 to: insts size do: [:x | bar value: x. (insts at: x) rehash]] - ] - ]! Item was added: + ----- Method: Set class>>rehashAllInstances (in category 'initialization') ----- + rehashAllInstances + "Do not use #allInstancesDo: because rehash may create new instances." + + self allInstances do: [ :each | each rehash ] ! Item was changed: ----- Method: Set class>>rehashAllSets (in category 'initialization') ----- rehashAllSets "Set rehashAllSets" + + self withAllSubclassesDo: [ :each | each rehashAllInstances ]! - self withAllSubclassesDo: [ :setClass | - | instances | - instances := setClass allInstances. - instances isEmpty ifFalse: [ - 1 to: instances size do: [ :index | - (instances at: index) rehash ] ] ]!

1 0

Re: [squeak-dev] The Trunk: Graphics-nice.86.mcz
by Nicolas Cellier 31 Oct '09

31 Oct '09

Note that more variants of this code are found in Complex>>#arg Point>>#degrees this one was probably unnecessary, ^self theta radiansToDegrees would be as accurate knowing that {Float halfPi radiansToDegrees - 90. Float pi radiansToDegrees - 180. (Float pi + Float halfPi) radiansToDegrees - 270. Float twoPi radiansToDegrees - 360} allSatisfy: [:e | e = 0] Point>>#bearingToPoint: (same as degrees but shifted 90° counterclockwise just to have 0° at north - that is upscreen). 2009/10/31 <commits(a)source.squeak.org>: > Nicolas Cellier uploaded a new version of Graphics to project The Trunk: > http://source.squeak.org/trunk/Graphics-nice.86.mcz > > ==================== Summary ==================== > > Name: Graphics-nice.86 > Author: nice > Time: 31 October 2009, 3:13:31 am > UUID: 67835c13-ecca-4ff8-8635-e8f15d789607 > Ancestors: Graphics-nice.85 > > while at arcTan: fix 2 ULP in Float theta > Note that Float theta is in [0,2*pi[ while arcTan: is in [-pi,pi] > (0@0) theta leads to pi/2 instead of 0 for new version of arcTan: (pi for old version) > #arcTan: does handle case of negativeZero, #theta doesn't > > > =============== Diff against Graphics-nice.85 =============== > > Item was changed: > ----- Method: Point>>theta (in category 'polar coordinates') ----- > theta > "Answer the angle the receiver makes with origin in radians. right is 0; > down is 90. > Corrected the constants from single precision to 64 Bit precision > and changed the sends in case of overflow to constants HK 2005-07-23" > > | tan theta | > x = 0 > ifTrue: [y >= 0 > + ifTrue: [^ 1.5707963267948966 "90.0 degreesToRadians"] > - ifTrue: [^ 1.570796326794897 "90.0 degreesToRadians"] > ifFalse: [^ 4.71238898038469 "270.0 degreesToRadians"]] > ifFalse: > [tan := y asFloat / x asFloat. > theta := tan arcTan. > x >= 0 > ifTrue: [y >= 0 > ifTrue: [^theta] > ifFalse: [^"360.0 degreesToRadians" 6.283185307179586 + theta]] > ifFalse: [^"180.0 degreesToRadians" 3.141592653589793 + theta]]! > > >

1 0

The Trunk: Graphics-nice.86.mcz
by commits＠source.squeak.org 31 Oct '09

31 Oct '09

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.86.mcz ==================== Summary ==================== Name: Graphics-nice.86 Author: nice Time: 31 October 2009, 3:13:31 am UUID: 67835c13-ecca-4ff8-8635-e8f15d789607 Ancestors: Graphics-nice.85 while at arcTan: fix 2 ULP in Float theta Note that Float theta is in [0,2*pi[ while arcTan: is in [-pi,pi] (0@0) theta leads to pi/2 instead of 0 for new version of arcTan: (pi for old version) #arcTan: does handle case of negativeZero, #theta doesn't =============== Diff against Graphics-nice.85 =============== Item was changed: ----- Method: Point>>theta (in category 'polar coordinates') ----- theta "Answer the angle the receiver makes with origin in radians. right is 0; down is 90. Corrected the constants from single precision to 64 Bit precision and changed the sends in case of overflow to constants HK 2005-07-23" | tan theta | x = 0 ifTrue: [y >= 0 + ifTrue: [^ 1.5707963267948966 "90.0 degreesToRadians"] - ifTrue: [^ 1.570796326794897 "90.0 degreesToRadians"] ifFalse: [^ 4.71238898038469 "270.0 degreesToRadians"]] ifFalse: [tan := y asFloat / x asFloat. theta := tan arcTan. x >= 0 ifTrue: [y >= 0 ifTrue: [^theta] ifFalse: [^"360.0 degreesToRadians" 6.283185307179586 + theta]] ifFalse: [^"180.0 degreesToRadians" 3.141592653589793 + theta]]!

1 0

The Trunk: Traits-nice.242.mcz
by commits＠source.squeak.org 31 Oct '09

31 Oct '09

Nicolas Cellier uploaded a new version of Traits to project The Trunk: http://source.squeak.org/trunk/Traits-nice.242.mcz ==================== Summary ==================== Name: Traits-nice.242 Author: nice Time: 31 October 2009, 1:49:11 am UUID: 0a436ff9-05a0-46a9-915e-9e4e974c5544 Ancestors: Traits-nice.241 minor refactoring rename #becomeEmpty -> #removeAll (also proposed to pharo) Rationale: no reason to have multiple selectors for the same feature Moreover, becomeEmpty had only 1 implementor and 1 sender =============== Diff against Traits-nice.241 =============== Item was changed: ----- Method: SendInfo>>emptyStack (in category 'stack manipulation') ----- emptyStack + stack removeAll! - stack becomeEmpty! Item was added: + ----- Method: QuickStack>>removeAll (in category 'accessing') ----- + removeAll + top := 0! Item was removed: - ----- Method: QuickStack>>becomeEmpty (in category 'accessing') ----- - becomeEmpty - top := 0!

1 0

← Newer
1
2
3
4
5
6
7
...
36
Older →

Jump to page: