Squeak-dev August 2003

squeak-dev@lists.squeakfoundation.org

171 participants
757 discussions

[FIX] creation of a LineMorph ([sm] [cd] doubts about this)
by Scott Wallace 05 Oct '03

05 Oct '03

Before jumping into adopting this "fix", please look at the class comment of LineMorph. If I understand Dan's intentions correctly, LineMorph (which adds no instance variables and has no instance-side methods) is never intended to be instantiated; all instantiation calls to LineMorph are *expected* to result in instances of vanilla PolygonMorph. Thus, Dan's use of the hard-coded "PolygonMorph" in LineMorph class-side method #from:to:color:width: was decidedly intentional, and the proposed "easy to understand fix" violates that intention. Cheers, -- Scott >[FIX] creation of a LineMorph ([sm][cd] easy to understand fix) >Hannes Hirzel hannes.hirzel.squeaklist at bluewin.ch >Sat Mar 8 19:04:26 CET 2003 > >------------------------------------------------------------------------ > > >... The only change actually done in the change set was >replacing 'PolygonMorph' with 'self' in a class method. > >No problem. A good fix. > >-- Hannes > > >chris at funkyobjects.org wrote: >> >> --==CelesteAttachment73100== >> >> from preamble: >> >> "Change Set: creation of a LineMorph >> Date: 23 February 2003 >> Author: Chris Muller >> >> replaces a hard-coded reference to PolygonMorph with logical class > > reference (self), allowing subclasses of LineMorph to properly > > instantiate."! >

4 4

[FIX SOUGHT]
by Doug Clapp 05 Oct '03

05 Oct '03

Could anyone help fix: http://minnow.cc.gatech.edu/squeak/1760 ?

5 4

[FIX] ProjectArchiveFixes-nk
by Ned Konz 05 Oct '03

05 Oct '03

from preamble: "Change Set: ProjectArchiveFixes-nk Date: 20 December 2002 Author: Ned Konz My recent changes to fileName in ArchiveMember broke project loading in non-Unix systems. This reverts fileName so that it returns the raw Zip name, and adds localFileName for use when you need a name that's compatible with the local file system. "!

2 1

[FIX] Another Acorn FileDir bug fix
by Tim Rowledge 05 Oct '03

05 Oct '03

Should have been in the update 5141 but presumably I sent the wrong dang file. Sigh. tim -- Tim Rowledge, tim(a)sumeru.stanford.edu, http://sumeru.stanford.edu/tim Useful random insult:- Has a one-way ticket on the Disoriented Express.

2 1

[FIX] ClassCommentFix-nk
by Ned Konz 05 Oct '03

05 Oct '03

from preamble: "Change Set: ClassCommentFix-nk Date: 26 November 2002 Author: Ned Konz Version: 3.4a Changing class comments (and reverting them) caused walkbacks. "!

2 1

[FIX] MCInstallPreload-nk
by ned＠bike-nomad.com 03 Oct '03

03 Oct '03

This CS should be filed in before the new version of Monticello if you have been using an old version. It should be harmless if you have the new version loaded already. >From the preamble: This is a preload to convert old Monticello images. It first loads the MCFile code from Monticello 1.71 and then makes sure that each MCFilePackageManager instance is already set up with a 'file' instVar.

2 1

[BUG][FIX][SM] SqueakMap error handling for loading bogus package
by David T. Lewis 03 Oct '03

03 Oct '03

SMSqueakMap behaves badly when attempting to install a nonexistent package. This change set fixes the problem by adding some nil checks and by throwing a Warning when attempting to load a package with a bogus name or UUID. SUnit tests are provided in a companion change set. Note: Most SM functions use #inform: to display warnings to the user. I used #notify: in here because I am assuming that server instances of SqueakMap may be running headless, and that a headless server could handle Warning exceptions with no UI interaction. This seemed better overall than just letting the SMSqueakMap>>installPackageNamed: and SMSqueakMap>>installPackageWithId: methods fail silently. Dave

4 4

[BUG][FIX] HorizontalScrollBarMissingLeftButton ([cd][sm])
by Hernan Tylim 02 Oct '03

02 Oct '03

Hi. I sent this bug fix in April but went unnoticed, so I am resending it with the hopes that someone will review it and harvest it. Please note that I verified that in the last available image (3.6b-5331) the bug is still present. Thanks -----Mensaje original----- De: squeak-dev-bounces(a)lists.squeakfoundation.org [mailto:squeak-dev-bounces@lists.squeakfoundation.org]En nombre de Hernan Tylim Enviado el: Jueves, 03 de Abril de 2003 20:01 Para: squeak-dev(a)lists.squeakfoundation.org Asunto: [BUG][FIX] HorizontalScrollBarMissingLeftButton ([sm]) Hi, In a fresh 3.4 image if you evaluate: TwoWayScrollPane new openInWorld You'll see that the left arrow button from the horizontal scrollbar is missing. The reason is the slider blocking the button. The method Scrollbar>>totalSliderArea is wrongly calculating the slider's bounds when the scrollbar is horizontal and the #ScrollbarWithoutMenuButton preference is disabled (it's default value). from preamble: "Change Set: HorizontalScrollBarMissingLeftButton Date: 3 April 2003 Author: Hernán Tylim This change set fix a problem with the left arrow button of the horizontal scrollbars. The slider's bounds on horizontal scrollbars were wrongly calculated causing the slider to block the left arrow button. This cs fix the method that calculates the slider bounds (ScrollBar>>totalSliderArea)."

4 4

[FIX] IfUnhandledError-nk
by ned＠bike-nomad.com 02 Oct '03

02 Oct '03

A changeset that is sure to be somewhat controversial. from preamble: "Change Set: IfUnhandledError-nk Date: 27 June 2003 Author: Ned Konz This changeset: - edits all callers of BlockContext>>ifError: to use something else, usually #ifUnhandledError: - adds BlockContext>>ifUnhandledError: (see below) - marks BlockContext>>ifError: as deprecated - edits all callers of Semaphore>>critical:ifError: to use something else. - marks Semaphore>>critical:ifError: as deprecated - edits most callers of on: Error do: [ ... ] to use something else, mostly #ifUnhandledError: - restores the behavior of removing step messages from the WorldState step list when the step messages have an error (the 'start stepping again' debug menu choice will restart them) I wrote #ifUnhandledError:, which allows enclosing scopes to handle exceptions. This behaves exactly the same as #ifError:, except that: - if there is an outer exception handler, that handler gets to handle the exception instead, and - there is now a one-argument form as well as the 0 and 2 argument forms that gets passed the exception itself. "!

2 2

[ENH] Speech Removal
by Brent Vukmer 02 Oct '03

02 Oct '03

Registered on SqueakMap by Luciano Notarfresco. The changeset is currently a one-liner!

2 1

← Newer
1
...
4
5
6
7
8
9
10
...
76
Older →

Jump to page: