From Preamble:
"Change Set: MouseMoveEvtStartPos-ar Date: 18 August 2003 Author: Eddie Cottongim
Fixes a bug where MouseMoveEvents would not report their startPosition correctly. Change by Andreas Raab."
To observe this bug, execute "HandMorph showEvents: true" and observe the starting point for mouse moves. Its usually wrong - most of the time, start point = end point. It makes much more sense after the patch.
The change makes sense to me. startPosition is now set to the hand's current position. Since the hand hasn't yet been moved in response to the event being formed, it makes sense that the hand's current position will the the starting point for the next mouse move event.
Someone should see if this helps/hurts Genie - Genie uses the start position for mouse moves. I'm suprised it would work at all given the old, broken behavior.
Thanks, Eddie
[closed]: Not for the image.
< I'm a bug-fixing machine! >
This post brought to you by the BugFixArchiveViewer, a handy tool that makes it easy to comment on proposed fixes and enhancements for Squeak. For more information, check out the Web page for the BugFixArchiveViewer project: http://minnow.cc.gatech.edu/squeak/3214
< I'm a bug-fixing machine! >
This is a one-liner that appears to originate from Andreas. I'm not clear on why trail first isn't the same as the current position, but I checked and Eddie is right that the actual movement of the HandMorph occurs AFTER this so the current position will be the start position. I loaded this code and it appears to do the correct thing.
If this somehow breaks Genie then I'm of the opinion that there is a bug in Genie and/or it is working around this bug and simply needs to be updated to reflect this fix.
Ken
squeak-dev@lists.squeakfoundation.org