Maybe a masked error of some access error/cache miss to the old version? Just speculating, the Squeaksource admins might know more ...
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von karl ramberg karlramberg@gmail.com Gesendet: Dienstag, 13. September 2022 18:25:22 An: The general-purpose Squeak developers list Betreff: Re: [squeak-dev] Duffing broken for Inbox [was: The Inbox: Compiler-ct.480.mcz]
I have seen the same issue for Etoys in the inbox. Diff is wrong and all classes are added to a commit.
Best, Karl
On Tue, Sep 13, 2022 at 4:34 PM Eliot Miranda <eliot.miranda@gmail.commailto:eliot.miranda@gmail.com> wrote: The below shows that code diffing is broken for Inbox. Instead of showing the difference in the commit the below appears to list the entire Compiler package starting with AssignmentNode.
_,,,^..^,,,_ (phone)
On Tue, Sep 13, 2022 at 05:05:49PM +0000, Thiede, Christoph wrote:
Maybe a masked error of some access error/cache miss to the old version? Just speculating, the Squeaksource admins might know more ...
CC Chris who may be able to help.
In my image I see Compiler-eem.479 as my current version in both trunk and inbox. In both repositories, the UUID for this MCZ version is the same (61d1f08e-6212-45d1-b07a-8d4d39ce7c2f).
Diffing against trunk shows no differences (good). Diffing against inbox shows everything different (bad). Installing the trunk version changes nothing (good). Installing the inbox version locks up the image (not good).
Browsing the trunk MCZ shows the package contents, browsing the inbox MCZ shows an empty package.
I have read access to the server, so I checked there:
davidlewis@andreas:/home/squeaksource/webserver/ss$ ls -l */Compiler-eem.479.mcz -rw-r--r-- 1 squeaksource squeaksource 57029 Jul 14 14:11 inbox/Compiler-eem.479.mcz -rw-r--r-- 1 squeaksource squeaksource 341474 Jul 5 23:06 trunk/Compiler-eem.479.mcz
I downloaded the two "Compiler-eem.479.mcz" files to my local PC and unpacked them. The trunk version is a normal MCZ file (good). The inbox version is something different, possibly an MCD file that was improperly named as MCZ.
The actual contents of the inbox file look like this when unpacked:
$ ls -lR .: total 180 -rw-rw-rw- 1 lewis lewis 43 Jul 14 16:11 base drwxrwxr-x 2 lewis lewis 4096 Sep 13 20:01 new drwxrwxr-x 2 lewis lewis 4096 Sep 13 20:01 old -rw-rw-rw- 1 lewis lewis 17 Jul 14 16:11 package -rw-rw-rw- 1 lewis lewis 1146 Jul 14 16:11 patch.bin -rw-rw-rw- 1 lewis lewis 162663 Jul 14 16:11 version
./new: total 4 -rw-rw-rw- 1 lewis lewis 924 Jul 14 16:11 source.st
./old: total 0 -rw-rw-rw- 1 lewis lewis 0 Jul 14 16:11 source.st
My best guess at this point: One way or another, we have MCD difference files getting saved to the inbox with MCZ file suffix.
Dave
Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von karl ramberg karlramberg@gmail.com Gesendet: Dienstag, 13. September 2022 18:25:22 An: The general-purpose Squeak developers list Betreff: Re: [squeak-dev] Duffing broken for Inbox [was: The Inbox: Compiler-ct.480.mcz]
I have seen the same issue for Etoys in the inbox. Diff is wrong and all classes are added to a commit.
Best, Karl
On Tue, Sep 13, 2022 at 4:34 PM Eliot Miranda <eliot.miranda@gmail.commailto:eliot.miranda@gmail.com> wrote: The below shows that code diffing is broken for Inbox. Instead of showing the difference in the commit the below appears to list the entire Compiler package starting with AssignmentNode.
_,,,^..^,,,_ (phone)
Here are the Compiler files in inbox since late 2021:
-rw-r--r-- 1 squeaksource squeaksource 329K Nov 16 2021 ss/inbox/Compiler-ct.463.mcz -rw-r--r-- 1 squeaksource squeaksource 331K Nov 22 2021 ss/inbox/Compiler-ct.464.mcz -rw-r--r-- 1 squeaksource squeaksource 332K Apr 1 16:41 ss/inbox/Compiler-ct.473.mcz -rw-r--r-- 1 squeaksource squeaksource 333K Jun 8 12:04 ss/inbox/Compiler-mt.477.mcz -rw-r--r-- 1 squeaksource squeaksource 329K Jul 13 20:58 ss/inbox/Compiler-cmm.480.mcz -rw-r--r-- 1 squeaksource squeaksource *56K* Jul 14 14:11 ss/inbox/Compiler-eem.479.mcz -rw-r--r-- 1 squeaksource squeaksource 334K Jul 20 07:49 ss/inbox/Compiler-mt.480.mcz -rw-r--r-- 1 squeaksource squeaksource 334K Sep 9 12:48 ss/inbox/Compiler-ct.480.mcz -rw-r--r-- 1 squeaksource squeaksource 369K Sep 9 12:48 'ss/inbox/Compiler-ct.480(eem.479).mcd'
I only see this single case of a mcd apparently named as a mcz, and it was from two months ago. I have no idea why or how, but if it tried to use that file to create Compiler-ct.480(eem.479).mcd, then it's possible that file is not correct either.
Therefore, I would recommend deleting ./ss/inbox/Compiler-eem.479.mcz and ss/inbox/Compiler-ct.480(eem.479).mcd, and proceeding from there. The former is in trunk, so I don't why it should still be in the Inbox at all.
- Chris
On Tue, Sep 13, 2022 at 7:18 PM David T. Lewis lewis@mail.msen.com wrote:
On Tue, Sep 13, 2022 at 05:05:49PM +0000, Thiede, Christoph wrote:
Maybe a masked error of some access error/cache miss to the old version?
Just speculating, the Squeaksource admins might know more ...
CC Chris who may be able to help.
In my image I see Compiler-eem.479 as my current version in both trunk and inbox. In both repositories, the UUID for this MCZ version is the same (61d1f08e-6212-45d1-b07a-8d4d39ce7c2f).
Diffing against trunk shows no differences (good). Diffing against inbox shows everything different (bad). Installing the trunk version changes nothing (good). Installing the inbox version locks up the image (not good).
Browsing the trunk MCZ shows the package contents, browsing the inbox MCZ shows an empty package.
I have read access to the server, so I checked there:
davidlewis@andreas:/home/squeaksource/webserver/ss$ ls -l */Compiler-eem.479.mcz -rw-r--r-- 1 squeaksource squeaksource 57029 Jul 14 14:11 inbox/Compiler-eem.479.mcz -rw-r--r-- 1 squeaksource squeaksource 341474 Jul 5 23:06 trunk/Compiler-eem.479.mcz
I downloaded the two "Compiler-eem.479.mcz" files to my local PC and unpacked them. The trunk version is a normal MCZ file (good). The inbox version is something different, possibly an MCD file that was improperly named as MCZ.
The actual contents of the inbox file look like this when unpacked:
$ ls -lR .: total 180 -rw-rw-rw- 1 lewis lewis 43 Jul 14 16:11 base drwxrwxr-x 2 lewis lewis 4096 Sep 13 20:01 new drwxrwxr-x 2 lewis lewis 4096 Sep 13 20:01 old -rw-rw-rw- 1 lewis lewis 17 Jul 14 16:11 package -rw-rw-rw- 1 lewis lewis 1146 Jul 14 16:11 patch.bin -rw-rw-rw- 1 lewis lewis 162663 Jul 14 16:11 version
./new: total 4 -rw-rw-rw- 1 lewis lewis 924 Jul 14 16:11 source.st
./old: total 0 -rw-rw-rw- 1 lewis lewis 0 Jul 14 16:11 source.st
My best guess at this point: One way or another, we have MCD difference files getting saved to the inbox with MCZ file suffix.
Dave
Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im
Auftrag von karl ramberg karlramberg@gmail.com
Gesendet: Dienstag, 13. September 2022 18:25:22 An: The general-purpose Squeak developers list Betreff: Re: [squeak-dev] Duffing broken for Inbox [was: The Inbox:
Compiler-ct.480.mcz]
I have seen the same issue for Etoys in the inbox. Diff is wrong and all
classes are added to a commit.
Best, Karl
On Tue, Sep 13, 2022 at 4:34 PM Eliot Miranda <eliot.miranda@gmail.com
mailto:eliot.miranda@gmail.com> wrote:
The below shows that code diffing is broken for Inbox. Instead of
showing the difference in the commit the below appears to list the entire Compiler package starting with AssignmentNode.
_,,,^..^,,,_ (phone)
Hi Chris,
but what’s in Inbox isn’t relevant. Since Inbox receives occasional submissions we can’t diff against just Inbox versions. We have to diff against the union of Inbox and trunk. Only then can we be confident of finding the most recent ancestor.
_,,,^..^,,,_ (phone)
On Sep 13, 2022, at 6:25 PM, Chris Muller asqueaker@gmail.com wrote:
Here are the Compiler files in inbox since late 2021:
-rw-r--r-- 1 squeaksource squeaksource 329K Nov 16 2021 ss/inbox/Compiler-ct.463.mcz -rw-r--r-- 1 squeaksource squeaksource 331K Nov 22 2021 ss/inbox/Compiler-ct.464.mcz -rw-r--r-- 1 squeaksource squeaksource 332K Apr 1 16:41 ss/inbox/Compiler-ct.473.mcz -rw-r--r-- 1 squeaksource squeaksource 333K Jun 8 12:04 ss/inbox/Compiler-mt.477.mcz -rw-r--r-- 1 squeaksource squeaksource 329K Jul 13 20:58 ss/inbox/Compiler-cmm.480.mcz -rw-r--r-- 1 squeaksource squeaksource 56K Jul 14 14:11 ss/inbox/Compiler-eem.479.mcz -rw-r--r-- 1 squeaksource squeaksource 334K Jul 20 07:49 ss/inbox/Compiler-mt.480.mcz -rw-r--r-- 1 squeaksource squeaksource 334K Sep 9 12:48 ss/inbox/Compiler-ct.480.mcz -rw-r--r-- 1 squeaksource squeaksource 369K Sep 9 12:48 'ss/inbox/Compiler-ct.480(eem.479).mcd'
I only see this single case of a mcd apparently named as a mcz, and it was from two months ago. I have no idea why or how, but if it tried to use that file to create Compiler-ct.480(eem.479).mcd, then it's possible that file is not correct either.
Therefore, I would recommend deleting ./ss/inbox/Compiler-eem.479.mcz and ss/inbox/Compiler-ct.480(eem.479).mcd, and proceeding from there. The former is in trunk, so I don't why it should still be in the Inbox at all.
- Chris
On Tue, Sep 13, 2022 at 7:18 PM David T. Lewis lewis@mail.msen.com wrote: On Tue, Sep 13, 2022 at 05:05:49PM +0000, Thiede, Christoph wrote:
Maybe a masked error of some access error/cache miss to the old version? Just speculating, the Squeaksource admins might know more ...
CC Chris who may be able to help.
In my image I see Compiler-eem.479 as my current version in both trunk and inbox. In both repositories, the UUID for this MCZ version is the same (61d1f08e-6212-45d1-b07a-8d4d39ce7c2f).
Diffing against trunk shows no differences (good). Diffing against inbox shows everything different (bad). Installing the trunk version changes nothing (good). Installing the inbox version locks up the image (not good).
Browsing the trunk MCZ shows the package contents, browsing the inbox MCZ shows an empty package.
I have read access to the server, so I checked there:
davidlewis@andreas:/home/squeaksource/webserver/ss$ ls -l */Compiler-eem.479.mcz -rw-r--r-- 1 squeaksource squeaksource 57029 Jul 14 14:11 inbox/Compiler-eem.479.mcz -rw-r--r-- 1 squeaksource squeaksource 341474 Jul 5 23:06 trunk/Compiler-eem.479.mcz
I downloaded the two "Compiler-eem.479.mcz" files to my local PC and unpacked them. The trunk version is a normal MCZ file (good). The inbox version is something different, possibly an MCD file that was improperly named as MCZ.
The actual contents of the inbox file look like this when unpacked:
$ ls -lR .: total 180 -rw-rw-rw- 1 lewis lewis 43 Jul 14 16:11 base drwxrwxr-x 2 lewis lewis 4096 Sep 13 20:01 new drwxrwxr-x 2 lewis lewis 4096 Sep 13 20:01 old -rw-rw-rw- 1 lewis lewis 17 Jul 14 16:11 package -rw-rw-rw- 1 lewis lewis 1146 Jul 14 16:11 patch.bin -rw-rw-rw- 1 lewis lewis 162663 Jul 14 16:11 version
./new: total 4 -rw-rw-rw- 1 lewis lewis 924 Jul 14 16:11 source.st
./old: total 0 -rw-rw-rw- 1 lewis lewis 0 Jul 14 16:11 source.st
My best guess at this point: One way or another, we have MCD difference files getting saved to the inbox with MCZ file suffix.
Dave
Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von karl ramberg karlramberg@gmail.com Gesendet: Dienstag, 13. September 2022 18:25:22 An: The general-purpose Squeak developers list Betreff: Re: [squeak-dev] Duffing broken for Inbox [was: The Inbox: Compiler-ct.480.mcz]
I have seen the same issue for Etoys in the inbox. Diff is wrong and all classes are added to a commit.
Best, Karl
On Tue, Sep 13, 2022 at 4:34 PM Eliot Miranda <eliot.miranda@gmail.commailto:eliot.miranda@gmail.com> wrote: The below shows that code diffing is broken for Inbox. Instead of showing the difference in the commit the below appears to list the entire Compiler package starting with AssignmentNode.
_,,,^..^,,,_ (phone)
On Wed, Sep 14, 2022 at 06:50:33PM -0700, Eliot Miranda wrote:
Hi Chris,
but what???s in Inbox isn???t relevant. Since Inbox receives occasional submissions we can???t diff against just Inbox versions. We have to diff against the union of Inbox and trunk. Only then can we be confident of finding the most recent ancestor.
What's in the inbox is definitely relevant. It is a broken file. The contents are an MCD archive and the file name is MCZ.
Meanwhile, Chris points out that the bad MCZ should not be in the inbox at all because the correct copy of it also exists in trunk. So he suggests deleting ./ss/inbox/Compiler-eem.479.mcz and ss/inbox/Compiler-ct.480(eem.479).mcd, and proceeding from there.
Given that none of us knows the root cause of the problem and nobody is likely to figure it out any time soon, I would say that Chris is giving us good advice.
The problem with good advice (as we all know very well) is that somebody needs to actually follow it. I'm not sure how to do that in this case.
As a first step, I went to https://source.squeak.org and used the web interface to delete Compiler-eem.479 from the inbox. Let's see if that helps.
Dave
What's in the inbox is definitely relevant. It is a broken file. The contents are an MCD archive and the file name is MCZ.
I don't think it's an MCD at all, but just an empty MCZ. That's why it's showing everything different.
When a version is committed, the .mcz file is first created on your local computer, and then uploaded to the server. The server just saves straight to the filesystem, verbatim, never unpacking it. What's on the server is exactly what's on the uploader's computer.
Given that the .mcz is a valid zip, I don't think there was a network glitch. I think something happened on Eliot's computer when he saved that caused Compiler-eem.479.mcz to be saved as an empty mcz, which it then uploaded to the server.
Given that none of us knows the root cause of the problem
I'm satisfied this case is cracked. Is Inbox diffing working for everything else?
As a first step, I went to https://source.squeak.org and used the web interface to delete Compiler-eem.479 from the inbox. Let's see if that helps.
Thanks, that's exactly the right action. I would've done it, but wanted to be conservative about deleting someone else's file since it's available in the interface.
So now I wonder if diffing Christoph's version in the image is now working better?
Best, Chris
The Compiler-eem.479.mcz on my machine is fine. I’ve re-uploaded it. Note that Compiler-eem.479 is the current tip of trunk’s Compiler package.
_,,,^..^,,,_ (phone)
On Sep 14, 2022, at 8:40 PM, Chris Muller asqueaker@gmail.com wrote:
What's in the inbox is definitely relevant. It is a broken file. The contents are an MCD archive and the file name is MCZ.
I don't think it's an MCD at all, but just an empty MCZ. That's why it's showing everything different.
When a version is committed, the .mcz file is first created on your local computer, and then uploaded to the server. The server just saves straight to the filesystem, verbatim, never unpacking it. What's on the server is exactly what's on the uploader's computer.
Given that the .mcz is a valid zip, I don't think there was a network glitch. I think something happened on Eliot's computer when he saved that caused Compiler-eem.479.mcz to be saved as an empty mcz, which it then uploaded to the server.
Given that none of us knows the root cause of the problem
I'm satisfied this case is cracked. Is Inbox diffing working for everything else?
As a first step, I went to https://source.squeak.org and used the web interface to delete Compiler-eem.479 from the inbox. Let's see if that helps.
Thanks, that's exactly the right action. I would've done it, but wanted to be conservative about deleting someone else's file since it's available in the interface.
So now I wonder if diffing Christoph's version in the image is now working better?
Best, Chris
squeak-dev@lists.squeakfoundation.org
-
Chris Muller -
David T. Lewis -
Eliot Miranda -
Thiede, Christoph