Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.2021.mcz
==================== Summary ====================
Name: Morphic-eem.2021 Author: eem Time: 26 July 2022, 12:01:10.585585 pm UUID: 3cae6374-47d3-49e9-99a8-8c59697058d1 Ancestors: Morphic-eem.2020
Tiny reliability tweak.
=============== Diff against Morphic-eem.2020 ===============
Item was changed: ----- Method: TextMorph>>minHeight (in category 'layout') ----- minHeight
| result | result := (paragraph ifNil: [self minCompositionHeight] + ifNotNil: [:para| para lines first lineHeight]) - ifNotNil: [paragraph lines first lineHeight]) + (self borderWidth*2). margins ifNil: [^ result]. ^ margins isRectangle ifTrue: [result + margins top + margins bottom] ifFalse: [margins isPoint ifTrue: [result + margins y + margins y] ifFalse: [result + (2*margins)]]!
Hi Eliot,
I find this very interesting. So there could be a suspension point "inside" inlined #ifNotNil:?
(By the way, maybe we should add something like Object class>>#whatIsASuspensionPoint, I'm always unsure where they might occur and where not ...)
Best,
Christoph
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Dienstag, 26. Juli 2022 21:01:15 An: squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org Betreff: [squeak-dev] The Trunk: Morphic-eem.2021.mcz
Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.2021.mcz
==================== Summary ====================
Name: Morphic-eem.2021 Author: eem Time: 26 July 2022, 12:01:10.585585 pm UUID: 3cae6374-47d3-49e9-99a8-8c59697058d1 Ancestors: Morphic-eem.2020
Tiny reliability tweak.
=============== Diff against Morphic-eem.2020 ===============
Item was changed: ----- Method: TextMorph>>minHeight (in category 'layout') ----- minHeight
| result | result := (paragraph ifNil: [self minCompositionHeight] + ifNotNil: [:para| para lines first lineHeight]) - ifNotNil: [paragraph lines first lineHeight]) + (self borderWidth*2). margins ifNil: [^ result].
^ margins isRectangle ifTrue: [result + margins top + margins bottom] ifFalse: [margins isPoint ifTrue: [result + margins y + margins y] ifFalse: [result + (2*margins)]]!
squeak-dev@lists.squeakfoundation.org